)]}'
{"id":"openstack%2Fpython-openstackclient~364635","triplet_id":"openstack%2Fpython-openstackclient~master~I0d7c542272315590536c427a8865e49660361e55","project":"openstack/python-openstackclient","branch":"master","topic":"assertIn","hashtags":[],"change_id":"I0d7c542272315590536c427a8865e49660361e55","subject":"Use assertIn(A, B) instead of assertTrue(A in B )","status":"MERGED","created":"2016-09-02 03:12:00.000000000","updated":"2016-09-06 13:53:17.000000000","submitted":"2016-09-06 13:53:17.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"6b6e72af530a96b36fc603b7120c824f793544ed","_number":364635,"virtual_id_number":364635,"owner":{"_account_id":12732,"name":"Bin Zhou","email":"zhou.bin9@zte.com.cn","username":"BinZhou"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2016-09-06 13:53:17.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},{"value":0,"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":0,"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"value":0,"_account_id":12732,"name":"Bin Zhou","email":"zhou.bin9@zte.com.cn","username":"BinZhou"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"recommended":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-09-06 11:35:42.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},{"value":2,"date":"2016-09-06 02:47:08.000000000","_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":2,"date":"2016-09-06 12:53:27.000000000","_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"value":1,"date":"2016-09-06 06:45:54.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":12732,"name":"Bin Zhou","email":"zhou.bin9@zte.com.cn","username":"BinZhou"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},{"value":0,"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":1,"date":"2016-09-06 12:53:27.000000000","_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"value":0,"_account_id":12732,"name":"Bin Zhou","email":"zhou.bin9@zte.com.cn","username":"BinZhou"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"_account_id":12732,"name":"Bin Zhou","email":"zhou.bin9@zte.com.cn","username":"BinZhou"},{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-09-06 02:47:08.000000000","updated_by":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"reviewer":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"state":"REVIEWER"},{"updated":"2016-09-06 11:35:42.000000000","updated_by":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"reviewer":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"state":"REVIEWER"},{"updated":"2016-09-06 12:53:27.000000000","updated_by":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"reviewer":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"state":"REVIEWER"},{"updated":"2016-09-06 13:53:17.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"4b3c6f7e1fe9d2fde9fbe275276a767ca88baa32","author":{"_account_id":12732,"name":"Bin Zhou","email":"zhou.bin9@zte.com.cn","username":"BinZhou"},"date":"2016-09-02 03:12:00.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a6498d1f4af9d1024af735f9da45081de8ef8536","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-02 04:27:14.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/35/364635/1/check/gate-python-openstackclient-docs-ubuntu-xenial/e1f2ba0//doc/build/html/ : SUCCESS in 5m 11s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/35/364635/1/check/gate-python-openstackclient-pep8-ubuntu-xenial/141bdb2/ : SUCCESS in 2m 42s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/35/364635/1/check/gate-python-openstackclient-python27-ubuntu-xenial/8421e6c/ : SUCCESS in 2m 41s\n- gate-python-openstackclient-python34 http://logs.openstack.org/35/364635/1/check/gate-python-openstackclient-python34/173e2d5/ : SUCCESS in 2m 34s\n- gate-python-openstackclient-python35-nv http://logs.openstack.org/35/364635/1/check/gate-python-openstackclient-python35-nv/bce3a9a/ : SUCCESS in 6m 47s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/35/364635/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/ac82e8d/ : POST_FAILURE in 1h 14m 48s\n- check-osc-plugins http://logs.openstack.org/35/364635/1/check/check-osc-plugins/4596424/ : SUCCESS in 6m 59s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/35/364635/1/check/gate-osc-dsvm-functional/50367da/ : POST_FAILURE in 41m 57s","accounts_in_message":[],"_revision_number":1},{"id":"e4456a4b7d340a009b2def78ae8c9020300688c2","author":{"_account_id":12732,"name":"Bin Zhou","email":"zhou.bin9@zte.com.cn","username":"BinZhou"},"date":"2016-09-02 08:32:27.000000000","message":"Patch Set 1:\n\nrecheck POST_FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"878cab7662b7bd5beb2ee28d160a623718b14ab5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-02 09:35:44.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/35/364635/1/check/gate-python-openstackclient-docs-ubuntu-xenial/40b7183//doc/build/html/ : SUCCESS in 2m 43s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/35/364635/1/check/gate-python-openstackclient-pep8-ubuntu-xenial/f2b7625/ : POST_FAILURE in 5m 06s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/35/364635/1/check/gate-python-openstackclient-python27-ubuntu-xenial/2ad5036/ : SUCCESS in 3m 53s\n- gate-python-openstackclient-python34 http://logs.openstack.org/35/364635/1/check/gate-python-openstackclient-python34/ecff41e/ : SUCCESS in 2m 48s\n- gate-python-openstackclient-python35-nv http://logs.openstack.org/35/364635/1/check/gate-python-openstackclient-python35-nv/3f0ed18/ : SUCCESS in 7m 48s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/35/364635/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/250760d/ : SUCCESS in 1h 03m 03s\n- check-osc-plugins http://logs.openstack.org/35/364635/1/check/check-osc-plugins/7df5e7c/ : SUCCESS in 3m 18s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/35/364635/1/check/gate-osc-dsvm-functional/89b815d/ : SUCCESS in 28m 57s","accounts_in_message":[],"_revision_number":1},{"id":"0df397e545432368043dec331805e482211b39de","author":{"_account_id":12732,"name":"Bin Zhou","email":"zhou.bin9@zte.com.cn","username":"BinZhou"},"date":"2016-09-03 01:51:41.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"74d1125bb7af9e71bd73d800e9fca95f3a133031","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-03 02:56:05.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/35/364635/1/check/gate-python-openstackclient-docs-ubuntu-xenial/d7fa7fd//doc/build/html/ : SUCCESS in 4m 40s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/35/364635/1/check/gate-python-openstackclient-pep8-ubuntu-xenial/3b6aa82/ : SUCCESS in 3m 46s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/35/364635/1/check/gate-python-openstackclient-python27-ubuntu-xenial/ff8049e/ : SUCCESS in 4m 26s\n- gate-python-openstackclient-python34 http://logs.openstack.org/35/364635/1/check/gate-python-openstackclient-python34/42c4780/ : SUCCESS in 2m 35s\n- gate-python-openstackclient-python35-nv http://logs.openstack.org/35/364635/1/check/gate-python-openstackclient-python35-nv/847305e/ : SUCCESS in 5m 21s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/35/364635/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/38d088f/ : SUCCESS in 1h 03m 31s\n- check-osc-plugins http://logs.openstack.org/35/364635/1/check/check-osc-plugins/d2e2303/ : SUCCESS in 3m 10s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/35/364635/1/check/gate-osc-dsvm-functional/a42a49c/ : SUCCESS in 38m 43s","accounts_in_message":[],"_revision_number":1},{"id":"95b2dc59770783344f39a7ea142aff011d98832d","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-09-06 02:47:08.000000000","message":"Patch Set 1: Code-Review+2\n\nNice catch. :)","accounts_in_message":[],"_revision_number":1},{"id":"51ade857c2515c9ec5259d579d51c64e9a20d906","author":{"_account_id":12732,"name":"Bin Zhou","email":"zhou.bin9@zte.com.cn","username":"BinZhou"},"date":"2016-09-06 06:45:54.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"d18cea3a0d410e27dc4abfd49b47dd1b6ac7ff5c","author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"date":"2016-09-06 11:35:42.000000000","message":"Patch Set 1: Code-Review+1\n\nThank you do these stuff :-)","accounts_in_message":[],"_revision_number":1},{"id":"3d7997c9e4fad84a6c956a8928ca162425e4c47c","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2016-09-06 12:53:27.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"115b9e5e8aaf92a007d27b10017a2e628bc9f9ac","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-06 12:53:37.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"2ecb8cf0bd65b2c6211727700fbd4e5574d26c3d","date":"2016-09-06 13:53:17.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"08eff707797fbd67c08102c950ba39d933285e77","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-06 13:53:17.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/35/364635/1/gate/gate-python-openstackclient-docs-ubuntu-xenial/b4aefd8//doc/build/html/ : SUCCESS in 5m 52s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/35/364635/1/gate/gate-python-openstackclient-pep8-ubuntu-xenial/5b1eb2d/ : SUCCESS in 4m 58s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/35/364635/1/gate/gate-python-openstackclient-python27-ubuntu-xenial/562821b/ : SUCCESS in 2m 43s\n- gate-python-openstackclient-python34 http://logs.openstack.org/35/364635/1/gate/gate-python-openstackclient-python34/c5402a8/ : SUCCESS in 5m 18s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/35/364635/1/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/32d82cf/ : SUCCESS in 59m 14s\n- gate-osc-dsvm-functional http://logs.openstack.org/35/364635/1/gate/gate-osc-dsvm-functional/83dfb1c/ : SUCCESS in 37m 15s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"1626b63f5698918ac73ec407b1922fc006b0db66","revisions":{"1626b63f5698918ac73ec407b1922fc006b0db66":{"kind":"REWORK","_number":1,"created":"2016-09-02 03:12:00.000000000","uploader":{"_account_id":12732,"name":"Bin Zhou","email":"zhou.bin9@zte.com.cn","username":"BinZhou"},"ref":"refs/changes/35/364635/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/35/364635/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/35/364635/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/35/364635/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/35/364635/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/35/364635/1"}}},"commit":{"parents":[{"commit":"45d3e67b98d59016d9f3ce66d2c8519d1cdbe7b7","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/45d3e67b98d59016d9f3ce66d2c8519d1cdbe7b7"}]}],"author":{"name":"Bin Zhou","email":"zhou.bin9@zte.com.cn","date":"2016-09-02 04:05:58.000000000","tz":480},"committer":{"name":"Bin Zhou","email":"zhou.bin9@zte.com.cn","date":"2016-09-02 04:48:41.000000000","tz":480},"subject":"Use assertIn(A, B) instead of assertTrue(A in B )","message":"Use assertIn(A, B) instead of assertTrue(A in B )\n\nDevelopers should use assertIn(A, B) instead of assertTrue(A in B ).\n\nTrivialFix\n\nChange-Id: I0d7c542272315590536c427a8865e49660361e55\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/1626b63f5698918ac73ec407b1922fc006b0db66"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/1626b63f5698918ac73ec407b1922fc006b0db66"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}