)]}'
{"id":"openstack%2Fpython-openstackclient~369826","triplet_id":"openstack%2Fpython-openstackclient~master~I7aeceede6bd3cb88cf04f398454f9758dbee20f1","project":"openstack/python-openstackclient","branch":"master","topic":"bug/1475722","hashtags":[],"change_id":"I7aeceede6bd3cb88cf04f398454f9758dbee20f1","subject":"Replace \u0027MagicMock\u0027 with \u0027Mock\u0027","status":"MERGED","created":"2016-09-14 05:23:13.000000000","updated":"2016-09-14 13:58:24.000000000","submitted":"2016-09-14 13:58:24.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"1eaef994b4abd8d7e509a71d70d24bb753546c42","_number":369826,"virtual_id_number":369826,"owner":{"_account_id":22754,"name":"Qiang Tang","email":"qtang@vmware.com","username":"qtang"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":22754,"name":"Qiang Tang","email":"qtang@vmware.com","username":"qtang"},{"value":2,"date":"2016-09-14 13:58:24.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"value":0,"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":2,"date":"2016-09-14 12:48:30.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":22754,"name":"Qiang Tang","email":"qtang@vmware.com","username":"qtang"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-09-14 11:32:02.000000000","_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"value":0,"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":1,"date":"2016-09-14 12:48:30.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":22754,"name":"Qiang Tang","email":"qtang@vmware.com","username":"qtang"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"value":0,"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},{"_account_id":22754,"name":"Qiang Tang","email":"qtang@vmware.com","username":"qtang"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-09-14 05:47:29.000000000","updated_by":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"reviewer":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"state":"REVIEWER"},{"updated":"2016-09-14 11:32:02.000000000","updated_by":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"reviewer":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"state":"REVIEWER"},{"updated":"2016-09-14 12:48:30.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2016-09-14 13:58:24.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"d485e1a1ac87260a493aefc7d0085f473fe511ae","author":{"_account_id":22754,"name":"Qiang Tang","email":"qtang@vmware.com","username":"qtang"},"date":"2016-09-14 05:23:13.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"fe432e554ac45e2f11afccad6259f8542cf7f649","author":{"_account_id":22754,"name":"Qiang Tang","email":"qtang@vmware.com","username":"qtang"},"date":"2016-09-14 05:23:44.000000000","message":"Patch Set 1: Workflow-1","accounts_in_message":[],"_revision_number":1},{"id":"9e7c2eced1c644b5cb4bcc5fdbafa9d04c6f18c4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-14 06:25:48.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/26/369826/1/check/gate-python-openstackclient-docs-ubuntu-xenial/4c0308a//doc/build/html/ : SUCCESS in 2m 42s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/26/369826/1/check/gate-python-openstackclient-pep8-ubuntu-xenial/ace7e15/ : SUCCESS in 3m 05s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/26/369826/1/check/gate-python-openstackclient-python27-ubuntu-xenial/1a3f767/ : FAILURE in 7m 22s\n- gate-python-openstackclient-python34 http://logs.openstack.org/26/369826/1/check/gate-python-openstackclient-python34/7ae114f/ : FAILURE in 4m 11s\n- gate-python-openstackclient-python35-nv http://logs.openstack.org/26/369826/1/check/gate-python-openstackclient-python35-nv/635c966/ : FAILURE in 4m 35s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/26/369826/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/aaabb84/ : SUCCESS in 59m 35s\n- check-osc-plugins http://logs.openstack.org/26/369826/1/check/check-osc-plugins/4498285/ : SUCCESS in 3m 12s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/26/369826/1/check/gate-osc-dsvm-functional/627bc84/ : SUCCESS in 24m 48s","accounts_in_message":[],"_revision_number":1},{"id":"9cd4bf266aeb13e4e61600bc00379d53a51de64d","author":{"_account_id":22754,"name":"Qiang Tang","email":"qtang@vmware.com","username":"qtang"},"date":"2016-09-14 09:07:06.000000000","message":"Patch Set 1:\n\nHi Reviewers,\n\nCan we just keep the MagicMock in the 3 failure cases of UT since the default Mock not handle __exit__ compare with the MagicMock when exit the \u0027with\u0027 statement.\n\nThe other UT cases work fine with the default Mock.\n\nWhat\u0027s your idea for this? Thanks.","accounts_in_message":[],"_revision_number":1},{"id":"28ad60539583a43a770746204b54b2b230d8d480","author":{"_account_id":22754,"name":"Qiang Tang","email":"qtang@vmware.com","username":"qtang"},"date":"2016-09-14 09:53:45.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"80cd3c66a30d99eb04795523d6f83b676cc9300d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-14 10:50:18.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/26/369826/2/check/gate-python-openstackclient-docs-ubuntu-xenial/4aaf703//doc/build/html/ : SUCCESS in 2m 51s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/26/369826/2/check/gate-python-openstackclient-pep8-ubuntu-xenial/977aea8/ : SUCCESS in 2m 50s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/26/369826/2/check/gate-python-openstackclient-python27-ubuntu-xenial/bf27352/ : SUCCESS in 2m 51s\n- gate-python-openstackclient-python34 http://logs.openstack.org/26/369826/2/check/gate-python-openstackclient-python34/151849c/ : SUCCESS in 2m 40s\n- gate-python-openstackclient-python35-nv http://logs.openstack.org/26/369826/2/check/gate-python-openstackclient-python35-nv/90f9d5b/ : SUCCESS in 3m 40s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/26/369826/2/check/gate-tempest-dsvm-neutron-src-python-openstackclient/dc8deb0/ : SUCCESS in 53m 39s\n- check-osc-plugins http://logs.openstack.org/26/369826/2/check/check-osc-plugins/3c4fd93/ : SUCCESS in 3m 24s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/26/369826/2/check/gate-osc-dsvm-functional/2910805/ : SUCCESS in 19m 37s","accounts_in_message":[],"_revision_number":2},{"id":"31bff4f786df12a7c484ae28bab6f1f6e6a567e9","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2016-09-14 11:32:02.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"10e73a14998c0a8358ca9999741c263b3c737580","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-09-14 12:48:30.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"cf0342db7da9ddb0f23b8cee4c5a2d1390d87598","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-14 12:53:01.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"1f392a7b96f67c5828ca35c278575425ba4d637a","date":"2016-09-14 13:58:24.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"48e1030104d31747cafe66e9ba7e44b53e3e157d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-14 13:58:24.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/26/369826/2/gate/gate-python-openstackclient-docs-ubuntu-xenial/a6d3624//doc/build/html/ : SUCCESS in 4m 14s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/26/369826/2/gate/gate-python-openstackclient-pep8-ubuntu-xenial/77778fd/ : SUCCESS in 4m 20s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/26/369826/2/gate/gate-python-openstackclient-python27-ubuntu-xenial/d4c8935/ : SUCCESS in 4m 02s\n- gate-python-openstackclient-python34 http://logs.openstack.org/26/369826/2/gate/gate-python-openstackclient-python34/5c4c194/ : SUCCESS in 5m 06s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/26/369826/2/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/4e10d0e/ : SUCCESS in 1h 04m 15s\n- gate-osc-dsvm-functional http://logs.openstack.org/26/369826/2/gate/gate-osc-dsvm-functional/7584e19/ : SUCCESS in 20m 29s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"bc222e97b155152be3c8cced987ef1d443076d10","revisions":{"5393149b9c33da725c40834af107be939cbb1fdf":{"kind":"REWORK","_number":1,"created":"2016-09-14 05:23:13.000000000","uploader":{"_account_id":22754,"name":"Qiang Tang","email":"qtang@vmware.com","username":"qtang"},"ref":"refs/changes/26/369826/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/26/369826/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/26/369826/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/26/369826/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/26/369826/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/26/369826/1"}}},"commit":{"parents":[{"commit":"6f326acd260d035cb024f0c5e3ef2237277d8b37","subject":"Support fetching network project default quota","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/6f326acd260d035cb024f0c5e3ef2237277d8b37"}]}],"author":{"name":"qtang","email":"qtang@vmware.com","date":"2016-09-14 05:27:31.000000000","tz":480},"committer":{"name":"qtang","email":"qtang@vmware.com","date":"2016-09-14 05:29:09.000000000","tz":480},"subject":"Replace \u0027MagicMock\u0027 with \u0027Mock\u0027","message":"Replace \u0027MagicMock\u0027 with \u0027Mock\u0027\n\nChange-Id: I7aeceede6bd3cb88cf04f398454f9758dbee20f1\nCloses-Bug: #1475722\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/5393149b9c33da725c40834af107be939cbb1fdf"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/5393149b9c33da725c40834af107be939cbb1fdf"}]},"branch":"refs/heads/master"},"bc222e97b155152be3c8cced987ef1d443076d10":{"kind":"REWORK","_number":2,"created":"2016-09-14 09:53:45.000000000","uploader":{"_account_id":22754,"name":"Qiang Tang","email":"qtang@vmware.com","username":"qtang"},"ref":"refs/changes/26/369826/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/26/369826/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/26/369826/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/26/369826/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/26/369826/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/26/369826/2"}}},"commit":{"parents":[{"commit":"6f326acd260d035cb024f0c5e3ef2237277d8b37","subject":"Support fetching network project default quota","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/6f326acd260d035cb024f0c5e3ef2237277d8b37"}]}],"author":{"name":"qtang","email":"qtang@vmware.com","date":"2016-09-14 05:27:31.000000000","tz":480},"committer":{"name":"qtang","email":"qtang@vmware.com","date":"2016-09-14 09:59:31.000000000","tz":480},"subject":"Replace \u0027MagicMock\u0027 with \u0027Mock\u0027","message":"Replace \u0027MagicMock\u0027 with \u0027Mock\u0027\n\nChange-Id: I7aeceede6bd3cb88cf04f398454f9758dbee20f1\nCloses-Bug: #1475722\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/bc222e97b155152be3c8cced987ef1d443076d10"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/bc222e97b155152be3c8cced987ef1d443076d10"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}