)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"fa50508d01aec48c6aa698347d13c82bed218511","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Added option for create and set router as well."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Partially Implements: blueprint neutron-client-descriptions"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ib8cd8af449e9ff33b980017b2527a6b196894a00"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5a8bc5a2_bd11e0ae","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":59},"updated":"2016-09-23 02:30:38.000000000","message":"I think this implementation is also belong to the following blueprint network-commands-options. Because --description option is just one of options we need to support.\n\nIt is also need to add to the commit message to track the work.","commit_id":"04ed9fe8ef9f0170c7f91a0cd1b7235589b8bf24"}],"doc/source/command-objects/floating-ip.rst":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"31fc9599a11cb8b4c2d2c7beb2d012c40259a032","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":".. option:: --description \u003cdescription\u003e"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    Set Floating IP description"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":".. describe:: \u003cnetwork\u003e"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a8ec9b2_7ad3bd38","line":45,"range":{"start_line":45,"start_character":8,"end_line":45,"end_character":9},"updated":"2016-09-20 20:29:14.000000000","message":"lowercase F here","commit_id":"3465cc173b3072fa9fae2d5619831459d6c2c374"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"5224eb2ee1c9bc1f76388eb53395aea93c53ed80","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":".. option:: --description \u003cdescription\u003e"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    Set Floating IP description"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":".. describe:: \u003cnetwork\u003e"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a8ec9b2_1d47131e","line":45,"range":{"start_line":45,"start_character":8,"end_line":45,"end_character":9},"in_reply_to":"7a8ec9b2_7ad3bd38","updated":"2016-09-20 20:49:50.000000000","message":"Done","commit_id":"3465cc173b3072fa9fae2d5619831459d6c2c374"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"9003b43d6b3c0e46eb82baca537234f93a715e0d","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":".. option:: --description \u003cdescription\u003e"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    Set floating IP description"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":".. describe:: \u003cnetwork\u003e"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"5a8bc5a2_02b16c47","line":45,"updated":"2016-09-23 15:13:31.000000000","message":"This is for network v2 only.  So please add the following:\n\n*Network version 2 only*","commit_id":"7b60aedf7a7d6ea6545465deb1721f00bb93a9b8"}],"openstackclient/network/v2/floating_ip.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"31fc9599a11cb8b4c2d2c7beb2d012c40259a032","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        parser.add_argument("},{"line_number":104,"context_line":"            \u0027--description\u0027,"},{"line_number":105,"context_line":"            metavar\u003d\u0027\u003cdescription\u003e\u0027,"},{"line_number":106,"context_line":"            help\u003d_(\u0027Set Floating IP description\u0027)"},{"line_number":107,"context_line":"        )"},{"line_number":108,"context_line":"        return parser"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_9ad6c925","line":106,"range":{"start_line":106,"start_character":24,"end_line":106,"end_character":32},"updated":"2016-09-20 20:29:14.000000000","message":"lowercase F here","commit_id":"3465cc173b3072fa9fae2d5619831459d6c2c374"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"5224eb2ee1c9bc1f76388eb53395aea93c53ed80","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        parser.add_argument("},{"line_number":104,"context_line":"            \u0027--description\u0027,"},{"line_number":105,"context_line":"            metavar\u003d\u0027\u003cdescription\u003e\u0027,"},{"line_number":106,"context_line":"            help\u003d_(\u0027Set Floating IP description\u0027)"},{"line_number":107,"context_line":"        )"},{"line_number":108,"context_line":"        return parser"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_7d5e57ea","line":106,"range":{"start_line":106,"start_character":24,"end_line":106,"end_character":32},"in_reply_to":"7a8ec9b2_9ad6c925","updated":"2016-09-20 20:49:50.000000000","message":"Done","commit_id":"3465cc173b3072fa9fae2d5619831459d6c2c374"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"e3218a9cf544e23b3bdd9f2ff2f3158f6a594cb2","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    if parsed_args.fixed_ip_address:"},{"line_number":56,"context_line":"        attrs[\u0027fixed_ip_address\u0027] \u003d parsed_args.fixed_ip_address"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    if parsed_args.description:"},{"line_number":59,"context_line":"        attrs[\u0027description\u0027] \u003d parsed_args.description"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    return attrs"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8ec9b2_48cfcc55","line":58,"updated":"2016-09-21 21:37:40.000000000","message":"Please check is not None to allow an empty description.","commit_id":"d5e1fd44c9b9b2e7e0456b48880b8a11543af812"}],"openstackclient/tests/unit/network/v2/test_floating_ip.py":[{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"a7133545d652af9a741499dfb336e593c9180dd8","unresolved":false,"context_lines":[{"line_number":120,"context_line":"            \u0027--floating-ip-address\u0027, self.floating_ip.floating_ip_address,"},{"line_number":121,"context_line":"            \u0027--fixed-ip-address\u0027, self.floating_ip.fixed_ip_address,"},{"line_number":122,"context_line":"            self.floating_ip.floating_network_id,"},{"line_number":123,"context_line":"            \u0027--description\u0027, self.floating_ip.description,"},{"line_number":124,"context_line":"        ]"},{"line_number":125,"context_line":"        verifylist \u003d ["},{"line_number":126,"context_line":"            (\u0027subnet\u0027, self.subnet.id),"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_f7919b9b","line":123,"updated":"2016-09-21 02:31:19.000000000","message":"positional parameter usually in the end of the list, the more common order:\n        \u0027--description\u0027, self.floating_ip.description,\n        self.floating_ip.floating_network_id,","commit_id":"5cf5298ceb1a3a1c0cf5a2b3053ef70c9bf8a2be"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"0e55c68a9a0021d768987554c98cfb694bed0461","unresolved":false,"context_lines":[{"line_number":120,"context_line":"            \u0027--floating-ip-address\u0027, self.floating_ip.floating_ip_address,"},{"line_number":121,"context_line":"            \u0027--fixed-ip-address\u0027, self.floating_ip.fixed_ip_address,"},{"line_number":122,"context_line":"            self.floating_ip.floating_network_id,"},{"line_number":123,"context_line":"            \u0027--description\u0027, self.floating_ip.description,"},{"line_number":124,"context_line":"        ]"},{"line_number":125,"context_line":"        verifylist \u003d ["},{"line_number":126,"context_line":"            (\u0027subnet\u0027, self.subnet.id),"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_19252e08","line":123,"in_reply_to":"7a8ec9b2_f7919b9b","updated":"2016-09-21 15:39:04.000000000","message":"Done","commit_id":"5cf5298ceb1a3a1c0cf5a2b3053ef70c9bf8a2be"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"a7133545d652af9a741499dfb336e593c9180dd8","unresolved":false,"context_lines":[{"line_number":128,"context_line":"            (\u0027floating_ip_address\u0027, self.floating_ip.floating_ip_address),"},{"line_number":129,"context_line":"            (\u0027fixed_ip_address\u0027, self.floating_ip.fixed_ip_address),"},{"line_number":130,"context_line":"            (\u0027network\u0027, self.floating_ip.floating_network_id),"},{"line_number":131,"context_line":"            (\u0027description\u0027, self.floating_ip.description),"},{"line_number":132,"context_line":"        ]"},{"line_number":133,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":134,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_378ce37e","line":131,"updated":"2016-09-21 02:31:19.000000000","message":"ditto","commit_id":"5cf5298ceb1a3a1c0cf5a2b3053ef70c9bf8a2be"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"0e55c68a9a0021d768987554c98cfb694bed0461","unresolved":false,"context_lines":[{"line_number":128,"context_line":"            (\u0027floating_ip_address\u0027, self.floating_ip.floating_ip_address),"},{"line_number":129,"context_line":"            (\u0027fixed_ip_address\u0027, self.floating_ip.fixed_ip_address),"},{"line_number":130,"context_line":"            (\u0027network\u0027, self.floating_ip.floating_network_id),"},{"line_number":131,"context_line":"            (\u0027description\u0027, self.floating_ip.description),"},{"line_number":132,"context_line":"        ]"},{"line_number":133,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":134,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_591b36ca","line":131,"in_reply_to":"7a8ec9b2_378ce37e","updated":"2016-09-21 15:39:04.000000000","message":"Done","commit_id":"5cf5298ceb1a3a1c0cf5a2b3053ef70c9bf8a2be"},{"author":{"_account_id":14867,"name":"Jaivish Kothari(janonymous)","email":"janonymous.codevulture@gmail.com","username":"Janonymous"},"change_message_id":"099f298b0e245bc6fe6d2f4e46fff2c79fc8a0e6","unresolved":false,"context_lines":[{"line_number":128,"context_line":"            (\u0027fixed_ip_address\u0027, self.floating_ip.fixed_ip_address),"},{"line_number":129,"context_line":"            (\u0027network\u0027, self.floating_ip.floating_network_id),"},{"line_number":130,"context_line":"            (\u0027description\u0027, self.floating_ip.description),"},{"line_number":131,"context_line":"            (\u0027floating_ip_address\u0027, self.floating_ip.floating_ip_address),"},{"line_number":132,"context_line":"        ]"},{"line_number":133,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":134,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a8bc5a2_e474ac9d","line":131,"updated":"2016-09-23 05:40:58.000000000","message":"any specific reason for reordering?","commit_id":"e8f3ccc39540447f83bfe562f4f7ec357ac96e97"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"1223a95046e318b0304c33757ed7ff2d49b6a74c","unresolved":false,"context_lines":[{"line_number":128,"context_line":"            (\u0027fixed_ip_address\u0027, self.floating_ip.fixed_ip_address),"},{"line_number":129,"context_line":"            (\u0027network\u0027, self.floating_ip.floating_network_id),"},{"line_number":130,"context_line":"            (\u0027description\u0027, self.floating_ip.description),"},{"line_number":131,"context_line":"            (\u0027floating_ip_address\u0027, self.floating_ip.floating_ip_address),"},{"line_number":132,"context_line":"        ]"},{"line_number":133,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":134,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a8bc5a2_774ccb42","line":131,"in_reply_to":"5a8bc5a2_e474ac9d","updated":"2016-09-23 08:29:51.000000000","message":"Hi, Jaivish, In the unit tests in OSC, positional arguments usually in the end of the list, This reordering may not necessary but make the code consistent with others","commit_id":"e8f3ccc39540447f83bfe562f4f7ec357ac96e97"}],"releasenotes/notes/bp-neutron-client-descriptions-a80902b4295843cf.yaml":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"178f3393732623bdc7e8459bcbdfd78515d6b4bf","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    Allows users to set a description in human"},{"line_number":6,"context_line":"    readable format for all resources."},{"line_number":7,"context_line":"    ``floating ip create``"},{"line_number":8,"context_line":"    [BP `Neutron Client Descriptions \u003chttps://blueprints.launchpad.net/python-openstackclient/+spec/neutron-client-descriptions\u003e`_]"},{"line_number":9,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7a8ec9b2_12f7c38b","line":8,"range":{"start_line":8,"start_character":4,"end_line":8,"end_character":131},"updated":"2016-09-21 16:14:53.000000000","message":"you can use the notation:\n\n  [Blueprint :oscbp:`neutron-client-descriptions`]","commit_id":"89dd377e5b6875d702240aa41ec92eec8973de0e"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"2a5683e52ba9a1c93746bb5ccedacb1daa8d7f4d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Add ``--description`` option for core network resources. Allows users to"},{"line_number":5,"context_line":"    set a description for: ``floating ip create``."},{"line_number":6,"context_line":"    set a description for: ``router set/create``"},{"line_number":7,"context_line":"    [Blueprint :oscbp:`neutron-client-descriptions`]"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5a8bc5a2_ece725e2","line":7,"range":{"start_line":7,"start_character":5,"end_line":7,"end_character":52},"updated":"2016-09-23 10:55:55.000000000","message":"Maybe also add both blueprints here. :)","commit_id":"e8f3ccc39540447f83bfe562f4f7ec357ac96e97"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"7b2fe77538757b76e9e2bed3aadd3bbb71aa181e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Add ``--description`` option for core network resources. Allows users to"},{"line_number":5,"context_line":"    set a description for: ``floating ip create``."},{"line_number":6,"context_line":"    set a description for: ``router set/create``"},{"line_number":7,"context_line":"    [Blueprint :oscbp:`neutron-client-descriptions`]"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5a8bc5a2_774a02ae","line":7,"range":{"start_line":7,"start_character":5,"end_line":7,"end_character":52},"in_reply_to":"5a8bc5a2_ece725e2","updated":"2016-09-23 11:22:20.000000000","message":"+1","commit_id":"e8f3ccc39540447f83bfe562f4f7ec357ac96e97"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"22da93a47d3adc3a31924af7603f58db95477a4f","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add ``--description`` option for core network resources. Allows users to"},{"line_number":5,"context_line":"    set a description for: ``floating ip create``."},{"line_number":6,"context_line":"    set a description for: ``router set/create``"},{"line_number":7,"context_line":"    [Blueprint :oscbp:`neutron-client-descriptions`]"},{"line_number":8,"context_line":"    [Blueprint :oscbp:`network-commands-options`]"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"5a8bc5a2_b3164ca5","line":6,"range":{"start_line":5,"start_character":4,"end_line":6,"end_character":48},"updated":"2016-09-23 16:08:59.000000000","message":"nit: set a description for: ``floating ip create`` and ``router set/create``.","commit_id":"316ee848e9c0c5e9808313b75e0ec22253e4820b"}]}