)]}'
{"openstackclient/tests/unit/volume/v1/test_volume.py":[{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"7fc2e7efbda1f12765e26997e4f4233881c93689","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        self.images_mock \u003d self.app.client_manager.image.images"},{"line_number":49,"context_line":"        self.images_mock.reset_mock()"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def setup_volumes_mock(self, count):"},{"line_number":52,"context_line":"        volumes \u003d volume_fakes.FakeVolume.create_volumes(count\u003dcount)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        self.volumes_mock.get \u003d volume_fakes.FakeVolume.get_volumes("}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_0eab491e","line":51,"range":{"start_line":51,"start_character":8,"end_line":51,"end_character":26},"updated":"2016-09-21 07:01:50.000000000","message":"We have defined a list of volumes here.","commit_id":"2e6b378c694bfdd666a21292e574d2523792c478"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"7fc2e7efbda1f12765e26997e4f4233881c93689","unresolved":false,"context_lines":[{"line_number":505,"context_line":""},{"line_number":506,"context_line":"class TestVolumeList(TestVolume):"},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"    _volume \u003d volume_fakes.FakeVolume.create_one_volume()"},{"line_number":509,"context_line":"    columns \u003d ("},{"line_number":510,"context_line":"        \u0027ID\u0027,"},{"line_number":511,"context_line":"        \u0027Display Name\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_6e4dad98","line":508,"range":{"start_line":508,"start_character":4,"end_line":508,"end_character":11},"updated":"2016-09-21 07:01:50.000000000","message":"You can reuse the volumes defined in setup_volumes_mock().","commit_id":"2e6b378c694bfdd666a21292e574d2523792c478"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"34c9eec75f7dc525b385853c9e675c76660a4f02","unresolved":false,"context_lines":[{"line_number":505,"context_line":""},{"line_number":506,"context_line":"class TestVolumeList(TestVolume):"},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"    _volume \u003d volume_fakes.FakeVolume.create_one_volume()"},{"line_number":509,"context_line":"    columns \u003d ("},{"line_number":510,"context_line":"        \u0027ID\u0027,"},{"line_number":511,"context_line":"        \u0027Display Name\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_dcf3db9d","line":508,"range":{"start_line":508,"start_character":4,"end_line":508,"end_character":11},"in_reply_to":"7a8ec9b2_6e4dad98","updated":"2016-09-21 07:31:58.000000000","message":"Seems the function cannot be used here, it can only be used in a test function with \"self\"","commit_id":"2e6b378c694bfdd666a21292e574d2523792c478"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"ea3d302276911af26ba8424729ab88300de8dff9","unresolved":false,"context_lines":[{"line_number":505,"context_line":""},{"line_number":506,"context_line":"class TestVolumeList(TestVolume):"},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"    _volume \u003d volume_fakes.FakeVolume.create_one_volume()"},{"line_number":509,"context_line":"    columns \u003d ("},{"line_number":510,"context_line":"        \u0027ID\u0027,"},{"line_number":511,"context_line":"        \u0027Display Name\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_68583afb","line":508,"range":{"start_line":508,"start_character":4,"end_line":508,"end_character":11},"in_reply_to":"7a8ec9b2_d23c9fc1","updated":"2016-09-21 09:07:40.000000000","message":"I think it is unnecessary to do it. We know setUp() will be called before every test runs, if we move codes to setUp(), then the codes will be called repeatedly. We could let the codes as-if so it will run once only :)","commit_id":"2e6b378c694bfdd666a21292e574d2523792c478"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"e6d004bffdfb71a0f734adbf77b0296cca7669de","unresolved":false,"context_lines":[{"line_number":505,"context_line":""},{"line_number":506,"context_line":"class TestVolumeList(TestVolume):"},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"    _volume \u003d volume_fakes.FakeVolume.create_one_volume()"},{"line_number":509,"context_line":"    columns \u003d ("},{"line_number":510,"context_line":"        \u0027ID\u0027,"},{"line_number":511,"context_line":"        \u0027Display Name\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_d23c9fc1","line":508,"range":{"start_line":508,"start_character":4,"end_line":508,"end_character":11},"in_reply_to":"7a8ec9b2_dcf3db9d","updated":"2016-09-21 08:39:48.000000000","message":"You can call it in setUp(). And of course, you have to move all of these code to setUp(). :)","commit_id":"2e6b378c694bfdd666a21292e574d2523792c478"}]}