)]}'
{"id":"openstack%2Fpython-openstackclient~373823","triplet_id":"openstack%2Fpython-openstackclient~master~I07b463753eedf41f79c6e00e9224d0f7697a1bd3","project":"openstack/python-openstackclient","branch":"master","topic":"bug/1625954","hashtags":[],"change_id":"I07b463753eedf41f79c6e00e9224d0f7697a1bd3","subject":"Use correct router add/remove interface methods","status":"MERGED","created":"2016-09-21 07:39:43.000000000","updated":"2016-09-21 15:49:22.000000000","submitted":"2016-09-21 15:49:22.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"9a0399fe6551d87a35aa30fae637aacbd657f444","_number":373823,"virtual_id_number":373823,"owner":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2016-09-21 15:49:22.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":0,"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},{"value":0,"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-09-21 08:37:09.000000000","_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":1,"date":"2016-09-21 09:12:39.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},{"value":2,"date":"2016-09-21 14:39:27.000000000","_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":0,"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},{"value":1,"date":"2016-09-21 14:39:27.000000000","_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-09-21 08:37:09.000000000","updated_by":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"reviewer":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"state":"REVIEWER"},{"updated":"2016-09-21 09:12:39.000000000","updated_by":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"reviewer":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"state":"REVIEWER"},{"updated":"2016-09-21 14:39:27.000000000","updated_by":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"reviewer":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"state":"REVIEWER"},{"updated":"2016-09-21 15:49:22.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"5490b61d883b20333ff8ac9faaa3e81af3480aff","author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"date":"2016-09-21 07:39:43.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3ad53f5f2123a87979439fcd700dd1abd768c934","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-09-21 08:37:09.000000000","message":"Patch Set 1: Code-Review+2\n\nThanks rabi. :)","accounts_in_message":[],"_revision_number":1},{"id":"3f56c278867e9e96b28e0a807a6670e06a8205f0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-21 08:59:54.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/23/373823/1/check/gate-python-openstackclient-docs-ubuntu-xenial/103e13d//doc/build/html/ : SUCCESS in 5m 19s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/23/373823/1/check/gate-python-openstackclient-pep8-ubuntu-xenial/6119ae0/ : SUCCESS in 4m 32s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/23/373823/1/check/gate-python-openstackclient-python27-ubuntu-xenial/0200eea/ : SUCCESS in 2m 56s\n- gate-python-openstackclient-python34 http://logs.openstack.org/23/373823/1/check/gate-python-openstackclient-python34/fcdfcf6/ : SUCCESS in 5m 00s\n- gate-python-openstackclient-python35-nv http://logs.openstack.org/23/373823/1/check/gate-python-openstackclient-python35-nv/6271ae0/ : SUCCESS in 3m 38s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/23/373823/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/2692731/ : SUCCESS in 1h 05m 21s\n- check-osc-plugins http://logs.openstack.org/23/373823/1/check/check-osc-plugins/1ba810c/ : SUCCESS in 5m 52s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/23/373823/1/check/gate-osc-dsvm-functional/7418e98/ : SUCCESS in 24m 01s","accounts_in_message":[],"_revision_number":1},{"id":"825f2e53541a4c8e4ad68a4d201b9c6350ccdb90","author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"date":"2016-09-21 09:12:39.000000000","message":"Patch Set 1: Code-Review+1\n\nThanks!","accounts_in_message":[],"_revision_number":1},{"id":"78c5ed13ce2f4079b86b4d367f398d29086f1b4a","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2016-09-21 11:27:47.000000000","message":"Patch Set 1:\n\nThis fix has already been proposed: https://review.openstack.org/#/c/367429/.  Also, https://review.openstack.org/#/c/373716/ needs to merge first.","accounts_in_message":[],"_revision_number":1},{"id":"1f26f4b8d88ed78a9608fa37d9af6033e7784885","author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"date":"2016-09-21 11:39:52.000000000","message":"Patch Set 1:\n\n@Richard,\n\nIt does not matter which of the patches merge, but should merge soon. I don\u0027t think it has to wait for the requirements change to merge as its \u0027\u003e\u003d\u003cversion\u003e\u0027. Heat gate was broken after the release of the new openstacksdk.","accounts_in_message":[],"_revision_number":1},{"id":"3e2eb9bb7f29372543be655664c39b6f7be642df","author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"date":"2016-09-21 11:41:15.000000000","message":"Patch Set 1:\n\nyou can see it here.\n\nhttp://logs.openstack.org/69/360269/3/gate/gate-heat-dsvm-functional-orig-mysql-lbaasv2/557bd3a/console.html#_2016-09-21_06_20_22_709763","accounts_in_message":[],"_revision_number":1},{"id":"4a20fdd1e9314484fac4c18717d5b40b6c39cd85","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2016-09-21 14:39:27.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nLet\u0027s go with this patch since the other is in merge conflict.","accounts_in_message":[],"_revision_number":1},{"id":"fe5ca96de940772be9fbbbec52faef30551d2484","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-21 14:39:48.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"b57978fe6910b7f1cf9c48cafe4cc864a5bacd8e","date":"2016-09-21 15:49:22.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"4be88115ccd4cb614133de7ff8b37a1599b4ac61","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-21 15:49:22.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/23/373823/1/gate/gate-python-openstackclient-docs-ubuntu-xenial/ede7e43//doc/build/html/ : SUCCESS in 4m 00s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/23/373823/1/gate/gate-python-openstackclient-pep8-ubuntu-xenial/89aa620/ : SUCCESS in 3m 48s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/23/373823/1/gate/gate-python-openstackclient-python27-ubuntu-xenial/e8be71a/ : SUCCESS in 4m 17s\n- gate-python-openstackclient-python34 http://logs.openstack.org/23/373823/1/gate/gate-python-openstackclient-python34/d52aa23/ : SUCCESS in 6m 49s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/23/373823/1/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/ec17025/ : SUCCESS in 1h 06m 34s\n- gate-osc-dsvm-functional http://logs.openstack.org/23/373823/1/gate/gate-osc-dsvm-functional/e6d446c/ : SUCCESS in 24m 41s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"47b782687f4c23d03e872fb2b2b69b57ba3f9aec","revisions":{"47b782687f4c23d03e872fb2b2b69b57ba3f9aec":{"kind":"REWORK","_number":1,"created":"2016-09-21 07:39:43.000000000","uploader":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"ref":"refs/changes/23/373823/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/23/373823/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/23/373823/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/23/373823/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/23/373823/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/23/373823/1"}}},"commit":{"parents":[{"commit":"682c2bfb8b1f17ed636c9aa26a640744ba6bfd87","subject":"Merge \"Remove unnecessary setUp\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/682c2bfb8b1f17ed636c9aa26a640744ba6bfd87"}]}],"author":{"name":"rabi","email":"ramishra@redhat.com","date":"2016-09-21 07:28:50.000000000","tz":330},"committer":{"name":"rabi","email":"ramishra@redhat.com","date":"2016-09-21 07:39:39.000000000","tz":330},"subject":"Use correct router add/remove interface methods","message":"Use correct router add/remove interface methods\n\nUse the correct openstacksdk method names.\n\nChange-Id: I07b463753eedf41f79c6e00e9224d0f7697a1bd3\nCloses-Bug: #1625954\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/47b782687f4c23d03e872fb2b2b69b57ba3f9aec"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/47b782687f4c23d03e872fb2b2b69b57ba3f9aec"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}