)]}'
{"id":"openstack%2Fpython-openstackclient~373836","triplet_id":"openstack%2Fpython-openstackclient~master~I5b5d587670acf0af4262b8521292455bf9f60fe5","project":"openstack/python-openstackclient","branch":"master","topic":"bug/1588588","hashtags":[],"change_id":"I5b5d587670acf0af4262b8521292455bf9f60fe5","subject":"Fix \"volume unset\" command pass normally when nothing specified","status":"MERGED","created":"2016-09-21 07:48:32.000000000","updated":"2016-09-22 02:35:13.000000000","submitted":"2016-09-22 02:35:13.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"68c46aafda8fd03c81dd38e34f063acf6b4c4fab","_number":373836,"virtual_id_number":373836,"owner":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2016-09-22 02:35:13.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":2,"date":"2016-09-21 16:27:31.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-09-21 20:15:21.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-09-21 20:15:21.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-09-21 16:27:31.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2016-09-21 20:15:21.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2016-09-22 02:35:13.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"d6cd509557666b731e1d72bd99d3245e5dac4160","author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"date":"2016-09-21 07:48:32.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"99a2a90f6572493373687e788cd307cef4eaea22","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-21 09:03:03.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/36/373836/1/check/gate-python-openstackclient-docs-ubuntu-xenial/825c5b9//doc/build/html/ : SUCCESS in 4m 25s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/36/373836/1/check/gate-python-openstackclient-pep8-ubuntu-xenial/b9b2ec3/ : SUCCESS in 4m 02s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/36/373836/1/check/gate-python-openstackclient-python27-ubuntu-xenial/18ba320/ : SUCCESS in 4m 42s\n- gate-python-openstackclient-python34 http://logs.openstack.org/36/373836/1/check/gate-python-openstackclient-python34/959cb25/ : SUCCESS in 4m 40s\n- gate-python-openstackclient-python35-nv http://logs.openstack.org/36/373836/1/check/gate-python-openstackclient-python35-nv/af078ad/ : SUCCESS in 4m 49s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/36/373836/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/09d09d9/ : SUCCESS in 1h 04m 44s\n- check-osc-plugins http://logs.openstack.org/36/373836/1/check/check-osc-plugins/24bbbc0/ : SUCCESS in 5m 23s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/36/373836/1/check/gate-osc-dsvm-functional/13995ca/ : SUCCESS in 25m 55s","accounts_in_message":[],"_revision_number":1},{"id":"41f01e31aa3627949a09bd1ab485cd9e9538426a","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-09-21 16:27:31.000000000","message":"Patch Set 1: Code-Review+2\n\nnice catch!","accounts_in_message":[],"_revision_number":1},{"id":"4668bc156e581cd2d0dc07fbb352893ae2139e65","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2016-09-21 20:15:21.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"f059b958806274e8e4298cc9d00ad79cdae4b880","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-22 01:31:53.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"b73934f383859e0a19b3732e210be300a7ea6204","date":"2016-09-22 02:35:13.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"223b1d46fda668b6c1fce9106dbd5640a934f94b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-22 02:35:13.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/36/373836/1/gate/gate-python-openstackclient-docs-ubuntu-xenial/919fc21//doc/build/html/ : SUCCESS in 4m 03s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/36/373836/1/gate/gate-python-openstackclient-pep8-ubuntu-xenial/26281c9/ : SUCCESS in 2m 35s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/36/373836/1/gate/gate-python-openstackclient-python27-ubuntu-xenial/d870cbc/ : SUCCESS in 3m 13s\n- gate-python-openstackclient-python34 http://logs.openstack.org/36/373836/1/gate/gate-python-openstackclient-python34/dc885fc/ : SUCCESS in 2m 42s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/36/373836/1/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/7f24ca4/ : SUCCESS in 1h 03m 17s\n- gate-osc-dsvm-functional http://logs.openstack.org/36/373836/1/gate/gate-osc-dsvm-functional/e728a7e/ : SUCCESS in 13m 48s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"bba5c9047f81439a18e4e8be434f51abab83a24a","revisions":{"bba5c9047f81439a18e4e8be434f51abab83a24a":{"kind":"REWORK","_number":1,"created":"2016-09-21 07:48:32.000000000","uploader":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"ref":"refs/changes/36/373836/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/36/373836/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/36/373836/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/36/373836/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/36/373836/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/36/373836/1"}}},"commit":{"parents":[{"commit":"4a8b802d6b1b4de4979260234b0fda4b18a01699","subject":"Refactor volume unit test with FakeVolume class in volume v1","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/4a8b802d6b1b4de4979260234b0fda4b18a01699"}]}],"author":{"name":"Huanxuan Ao","email":"huanxuan.ao@easystack.cn","date":"2016-09-21 07:08:14.000000000","tz":480},"committer":{"name":"Huanxuan Ao","email":"huanxuan.ao@easystack.cn","date":"2016-09-21 07:47:55.000000000","tz":480},"subject":"Fix \"volume unset\" command pass normally when nothing specified","message":"Fix \"volume unset\" command pass normally when nothing specified\n\nWhen nothing specified in \"volume unset\" command, there\nwill be an error message says that the \"--properties\"\noption is required, it is unusual behaviour, this patch\nfix it and also add unit test for it.\nAlso, this patch add unit test for \"volume show\" command\nby the way.\n\nChange-Id: I5b5d587670acf0af4262b8521292455bf9f60fe5\nPartial-bug: #1588588\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/bba5c9047f81439a18e4e8be434f51abab83a24a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/bba5c9047f81439a18e4e8be434f51abab83a24a"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}