)]}'
{"id":"openstack%2Fpython-openstackclient~375249","triplet_id":"openstack%2Fpython-openstackclient~master~I46775f24643d715e168b30785b8b531c0431a55b","project":"openstack/python-openstackclient","branch":"master","topic":"bug/1588588","hashtags":[],"change_id":"I46775f24643d715e168b30785b8b531c0431a55b","subject":"Fix unset commands to pass normally when nothing specified","status":"MERGED","created":"2016-09-23 05:22:43.000000000","updated":"2016-09-23 21:36:14.000000000","submitted":"2016-09-23 21:36:14.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"059745d3435a4c4516bf229d0fcfcaf05bd507e3","_number":375249,"virtual_id_number":375249,"owner":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2016-09-23 21:36:14.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":2,"date":"2016-09-23 20:31:36.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-09-23 11:34:09.000000000","_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":1,"date":"2016-09-23 20:31:36.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-09-23 11:34:09.000000000","updated_by":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"reviewer":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"state":"REVIEWER"},{"updated":"2016-09-23 20:31:36.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2016-09-23 21:36:14.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"66e666725cc5c3c2fbc9121a8b44e6456731bc81","author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"date":"2016-09-23 05:22:43.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8ed8ad6bf1caa11cc699a155821a2949525d934a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-23 06:26:45.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/49/375249/1/check/gate-python-openstackclient-docs-ubuntu-xenial/c36a487//doc/build/html/ : SUCCESS in 3m 14s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/49/375249/1/check/gate-python-openstackclient-pep8-ubuntu-xenial/707a702/ : SUCCESS in 2m 39s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/49/375249/1/check/gate-python-openstackclient-python27-ubuntu-xenial/2d551f0/ : SUCCESS in 2m 43s\n- gate-python-openstackclient-python34 http://logs.openstack.org/49/375249/1/check/gate-python-openstackclient-python34/4277ab4/ : SUCCESS in 5m 26s\n- gate-python-openstackclient-python35-nv http://logs.openstack.org/49/375249/1/check/gate-python-openstackclient-python35-nv/051698e/ : SUCCESS in 3m 08s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/49/375249/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/91c74fc/ : SUCCESS in 1h 03m 46s\n- check-osc-plugins http://logs.openstack.org/49/375249/1/check/check-osc-plugins/1e99dd0/ : SUCCESS in 3m 34s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/49/375249/1/check/gate-osc-dsvm-functional/4e133bf/ : SUCCESS in 20m 41s","accounts_in_message":[],"_revision_number":1},{"id":"6037978c8bd529c98e717c65e51b5958e3db47f4","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-09-23 11:34:09.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"a641d80f37127c71e8438b7c8cd7b8230a2cd951","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-09-23 20:31:36.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"31d24d59009194f8d1578d965bc3406d7b218f8f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-23 20:31:46.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"3397fb486c66f3ebcad6a1136e17d6e5d9517363","date":"2016-09-23 21:36:14.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"5c0605c98e66457660c61dcfe6a483e5c0eae61a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-23 21:36:14.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/49/375249/1/gate/gate-python-openstackclient-docs-ubuntu-xenial/5c50a82//doc/build/html/ : SUCCESS in 4m 01s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/49/375249/1/gate/gate-python-openstackclient-pep8-ubuntu-xenial/0fec50e/ : SUCCESS in 3m 40s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/49/375249/1/gate/gate-python-openstackclient-python27-ubuntu-xenial/204edd4/ : SUCCESS in 4m 05s\n- gate-python-openstackclient-python34 http://logs.openstack.org/49/375249/1/gate/gate-python-openstackclient-python34/12fc2f7/ : SUCCESS in 3m 32s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/49/375249/1/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/e0f0ff8/ : SUCCESS in 1h 04m 26s\n- gate-osc-dsvm-functional http://logs.openstack.org/49/375249/1/gate/gate-osc-dsvm-functional/afb91fe/ : SUCCESS in 26m 24s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"fd876e4cc699d7e6da7c5439a8452c4a8b395139","revisions":{"fd876e4cc699d7e6da7c5439a8452c4a8b395139":{"kind":"REWORK","_number":1,"created":"2016-09-23 05:22:43.000000000","uploader":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"ref":"refs/changes/49/375249/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/49/375249/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/49/375249/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/49/375249/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/49/375249/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/49/375249/1"}}},"commit":{"parents":[{"commit":"465a5d08e0b931b22c055fcbd5f530ee5547e7ab","subject":"Merge \"Align \u0027\u003d\u0027 for image.rst\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/465a5d08e0b931b22c055fcbd5f530ee5547e7ab"}]}],"author":{"name":"Huanxuan Ao","email":"huanxuan.ao@easystack.cn","date":"2016-09-23 05:02:13.000000000","tz":480},"committer":{"name":"Huanxuan Ao","email":"huanxuan.ao@easystack.cn","date":"2016-09-23 05:20:51.000000000","tz":480},"subject":"Fix unset commands to pass normally when nothing specified","message":"Fix unset commands to pass normally when nothing specified\n\nAfter I found this problem appear in \"volume unset\",\nI checked all the volume command and also found some\nsame problems. This patch fix them all.\nThe main reason of we ignored this problem before is\nthere was not any tests for it. So I add tests for\n\"nothing unset\" for them all to test and aviod this\nproblem.\nAlso, I add unit tests for all snapshot commands\nin volume v1 by the way in this patch. We will\nneed more tests to avoid some ignored problem.\n\nChange-Id: I46775f24643d715e168b30785b8b531c0431a55b\nPartial-bug: #1588588\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/fd876e4cc699d7e6da7c5439a8452c4a8b395139"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/fd876e4cc699d7e6da7c5439a8452c4a8b395139"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}