)]}'
{"doc/source/command-objects/volume.rst":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"6eb79c3e0a3e5a41d5209180564bab3b4289f233","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        [--image-property \u003ckey\u003dvalue\u003e [...] ]"},{"line_number":195,"context_line":"        [--state \u003cstate\u003e]"},{"line_number":196,"context_line":"        [--bootable | --non-bootable]"},{"line_number":197,"context_line":"        [--readonly | --no-readonly]"},{"line_number":198,"context_line":"        \u003cvolume\u003e"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":".. option:: --name \u003cname\u003e"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a8bc5a2_1a6cc307","line":197,"range":{"start_line":197,"start_character":11,"end_line":197,"end_character":19},"updated":"2016-09-28 03:37:41.000000000","message":"i think --read-only sounds better, thoughts?","commit_id":"83d9d76f7caff1218758272cfe497ab3abcb2567"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"6eb79c3e0a3e5a41d5209180564bab3b4289f233","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        [--image-property \u003ckey\u003dvalue\u003e [...] ]"},{"line_number":195,"context_line":"        [--state \u003cstate\u003e]"},{"line_number":196,"context_line":"        [--bootable | --non-bootable]"},{"line_number":197,"context_line":"        [--readonly | --no-readonly]"},{"line_number":198,"context_line":"        \u003cvolume\u003e"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":".. option:: --name \u003cname\u003e"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a8bc5a2_5a764bd9","line":197,"range":{"start_line":197,"start_character":24,"end_line":197,"end_character":35},"updated":"2016-09-28 03:37:41.000000000","message":"why not:\n\n  --non-read-only\n\nit matches the --non-bootable option better","commit_id":"83d9d76f7caff1218758272cfe497ab3abcb2567"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"dd2d752286b0e930c34c137d40166c5115a1892f","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        [--image-property \u003ckey\u003dvalue\u003e [...] ]"},{"line_number":195,"context_line":"        [--state \u003cstate\u003e]"},{"line_number":196,"context_line":"        [--bootable | --non-bootable]"},{"line_number":197,"context_line":"        [--readonly | --no-readonly]"},{"line_number":198,"context_line":"        \u003cvolume\u003e"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":".. option:: --name \u003cname\u003e"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a8bc5a2_c5c43c61","line":197,"range":{"start_line":197,"start_character":11,"end_line":197,"end_character":19},"in_reply_to":"5a8bc5a2_1a6cc307","updated":"2016-09-28 04:09:06.000000000","message":"Yep, will change it","commit_id":"83d9d76f7caff1218758272cfe497ab3abcb2567"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"dd2d752286b0e930c34c137d40166c5115a1892f","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        [--image-property \u003ckey\u003dvalue\u003e [...] ]"},{"line_number":195,"context_line":"        [--state \u003cstate\u003e]"},{"line_number":196,"context_line":"        [--bootable | --non-bootable]"},{"line_number":197,"context_line":"        [--readonly | --no-readonly]"},{"line_number":198,"context_line":"        \u003cvolume\u003e"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":".. option:: --name \u003cname\u003e"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a8bc5a2_e5c5b80a","line":197,"range":{"start_line":197,"start_character":24,"end_line":197,"end_character":35},"in_reply_to":"5a8bc5a2_5a764bd9","updated":"2016-09-28 04:09:06.000000000","message":"I think a more common format is with \u0027no-\u0027 prepended, we have a doc about it:\nhttp://docs.openstack.org/developer/python-openstackclient/command-options.html#boolean-options\nand we can see \u0027no-\u0027 is used widely in some where else in OSC.\nActually, I want to change the \"--non-bootable\" to \"--no-bootable\" as well in this review.","commit_id":"83d9d76f7caff1218758272cfe497ab3abcb2567"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"3a1c91c6e5a3bdf5ca79539f7ab0088c6ae5e171","unresolved":false,"context_lines":[{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    Mark volume as bootable"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":".. option:: --no-bootable"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    Mark volume as no-bootable"},{"line_number":223,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a98d1f4_82c15e31","line":220,"range":{"start_line":220,"start_character":3,"end_line":220,"end_character":25},"updated":"2016-09-28 13:07:41.000000000","message":"to other reviewers: the rename is fine, the option only exists in master and not in any released version: https://github.com/openstack/python-openstackclient/commit/6a914d0056e810e1ef37eaf4f01cd5c85217aba6","commit_id":"2eb3b86f7224675d26ec979c1ebb163f88be0dd4"}],"openstackclient/volume/v1/volume.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"6eb79c3e0a3e5a41d5209180564bab3b4289f233","unresolved":false,"context_lines":[{"line_number":417,"context_line":"            except Exception as e:"},{"line_number":418,"context_line":"                LOG.error(_(\"Failed to set volume read-only access \""},{"line_number":419,"context_line":"                            \"mode flag: %s\"), e)"},{"line_number":420,"context_line":"                result +\u003d 1"},{"line_number":421,"context_line":"        kwargs \u003d {}"},{"line_number":422,"context_line":"        if parsed_args.name:"},{"line_number":423,"context_line":"            kwargs[\u0027display_name\u0027] \u003d parsed_args.name"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_fa1b977e","line":420,"range":{"start_line":420,"start_character":16,"end_line":420,"end_character":27},"updated":"2016-09-28 03:37:41.000000000","message":"unfortunately, there is no \"result\" here :)","commit_id":"83d9d76f7caff1218758272cfe497ab3abcb2567"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"dd2d752286b0e930c34c137d40166c5115a1892f","unresolved":false,"context_lines":[{"line_number":417,"context_line":"            except Exception as e:"},{"line_number":418,"context_line":"                LOG.error(_(\"Failed to set volume read-only access \""},{"line_number":419,"context_line":"                            \"mode flag: %s\"), e)"},{"line_number":420,"context_line":"                result +\u003d 1"},{"line_number":421,"context_line":"        kwargs \u003d {}"},{"line_number":422,"context_line":"        if parsed_args.name:"},{"line_number":423,"context_line":"            kwargs[\u0027display_name\u0027] \u003d parsed_args.name"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_259ec007","line":420,"range":{"start_line":420,"start_character":16,"end_line":420,"end_character":27},"in_reply_to":"5a8bc5a2_fa1b977e","updated":"2016-09-28 04:09:06.000000000","message":"Oh...Yes, then I will add the \"result\" for other APIs as well in next patch set :)","commit_id":"83d9d76f7caff1218758272cfe497ab3abcb2567"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"25f956e9877046eb2dc38c268e1dba8aae70ce0e","unresolved":false,"context_lines":[{"line_number":383,"context_line":"        readonly_group.add_argument("},{"line_number":384,"context_line":"            \"--no-read-only\","},{"line_number":385,"context_line":"            action\u003d\"store_true\","},{"line_number":386,"context_line":"            help\u003d_(\"Set volume to not read-only access mode\")"},{"line_number":387,"context_line":"        )"},{"line_number":388,"context_line":"        return parser"},{"line_number":389,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3a98d1f4_9d41983c","line":386,"range":{"start_line":386,"start_character":34,"end_line":386,"end_character":47},"updated":"2016-09-29 02:44:34.000000000","message":"Any better term instead of this ?  Is it read-write access mode ?","commit_id":"2eb3b86f7224675d26ec979c1ebb163f88be0dd4"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"d7cdbbedadbfb47b7fb6e16c7cb2f8f973bec0b6","unresolved":false,"context_lines":[{"line_number":383,"context_line":"        readonly_group.add_argument("},{"line_number":384,"context_line":"            \"--no-read-only\","},{"line_number":385,"context_line":"            action\u003d\"store_true\","},{"line_number":386,"context_line":"            help\u003d_(\"Set volume to not read-only access mode\")"},{"line_number":387,"context_line":"        )"},{"line_number":388,"context_line":"        return parser"},{"line_number":389,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3a98d1f4_5df3900a","line":386,"range":{"start_line":386,"start_character":34,"end_line":386,"end_character":47},"in_reply_to":"3a98d1f4_9d41983c","updated":"2016-09-29 02:46:59.000000000","message":"++","commit_id":"2eb3b86f7224675d26ec979c1ebb163f88be0dd4"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"329ae3f1c88727b5d1f8d7aa3ef211c8ae312bb0","unresolved":false,"context_lines":[{"line_number":383,"context_line":"        readonly_group.add_argument("},{"line_number":384,"context_line":"            \"--no-read-only\","},{"line_number":385,"context_line":"            action\u003d\"store_true\","},{"line_number":386,"context_line":"            help\u003d_(\"Set volume to not read-only access mode\")"},{"line_number":387,"context_line":"        )"},{"line_number":388,"context_line":"        return parser"},{"line_number":389,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3a98d1f4_f5b54ccd","line":386,"range":{"start_line":386,"start_character":34,"end_line":386,"end_character":47},"in_reply_to":"3a98d1f4_9d41983c","updated":"2016-09-29 07:22:56.000000000","message":"Done","commit_id":"2eb3b86f7224675d26ec979c1ebb163f88be0dd4"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"25f956e9877046eb2dc38c268e1dba8aae70ce0e","unresolved":false,"context_lines":[{"line_number":396,"context_line":"            try:"},{"line_number":397,"context_line":"                if volume.status !\u003d \u0027available\u0027:"},{"line_number":398,"context_line":"                    msg \u003d (_(\"Volume is in %s state, it must be available \""},{"line_number":399,"context_line":"                           \"before size can be extended\"), volume.status)"},{"line_number":400,"context_line":"                    raise exceptions.CommandError(msg)"},{"line_number":401,"context_line":"                if parsed_args.size \u003c\u003d volume.size:"},{"line_number":402,"context_line":"                    msg \u003d _(\"New size must be greater than %s GB\"), volume.size"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a98d1f4_4a9ae815","line":399,"range":{"start_line":399,"start_character":57,"end_line":399,"end_character":59},"updated":"2016-09-29 02:44:34.000000000","message":"% should be used here. () is not a function, and (\"xxx\", var) is a tuple, not a string.","commit_id":"2eb3b86f7224675d26ec979c1ebb163f88be0dd4"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"329ae3f1c88727b5d1f8d7aa3ef211c8ae312bb0","unresolved":false,"context_lines":[{"line_number":396,"context_line":"            try:"},{"line_number":397,"context_line":"                if volume.status !\u003d \u0027available\u0027:"},{"line_number":398,"context_line":"                    msg \u003d (_(\"Volume is in %s state, it must be available \""},{"line_number":399,"context_line":"                           \"before size can be extended\"), volume.status)"},{"line_number":400,"context_line":"                    raise exceptions.CommandError(msg)"},{"line_number":401,"context_line":"                if parsed_args.size \u003c\u003d volume.size:"},{"line_number":402,"context_line":"                    msg \u003d _(\"New size must be greater than %s GB\"), volume.size"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a98d1f4_35c89455","line":399,"range":{"start_line":399,"start_character":57,"end_line":399,"end_character":59},"in_reply_to":"3a98d1f4_4a9ae815","updated":"2016-09-29 07:22:56.000000000","message":"Done","commit_id":"2eb3b86f7224675d26ec979c1ebb163f88be0dd4"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"25f956e9877046eb2dc38c268e1dba8aae70ce0e","unresolved":false,"context_lines":[{"line_number":399,"context_line":"                           \"before size can be extended\"), volume.status)"},{"line_number":400,"context_line":"                    raise exceptions.CommandError(msg)"},{"line_number":401,"context_line":"                if parsed_args.size \u003c\u003d volume.size:"},{"line_number":402,"context_line":"                    msg \u003d _(\"New size must be greater than %s GB\"), volume.size"},{"line_number":403,"context_line":"                    raise exceptions.CommandError(msg)"},{"line_number":404,"context_line":"                volume_client.volumes.extend(volume.id, parsed_args.size)"},{"line_number":405,"context_line":"            except Exception as e:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a98d1f4_0afaa042","line":402,"range":{"start_line":402,"start_character":26,"end_line":402,"end_character":79},"updated":"2016-09-29 02:44:34.000000000","message":"This is wrong, I think.","commit_id":"2eb3b86f7224675d26ec979c1ebb163f88be0dd4"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"d7cdbbedadbfb47b7fb6e16c7cb2f8f973bec0b6","unresolved":false,"context_lines":[{"line_number":399,"context_line":"                           \"before size can be extended\"), volume.status)"},{"line_number":400,"context_line":"                    raise exceptions.CommandError(msg)"},{"line_number":401,"context_line":"                if parsed_args.size \u003c\u003d volume.size:"},{"line_number":402,"context_line":"                    msg \u003d _(\"New size must be greater than %s GB\"), volume.size"},{"line_number":403,"context_line":"                    raise exceptions.CommandError(msg)"},{"line_number":404,"context_line":"                volume_client.volumes.extend(volume.id, parsed_args.size)"},{"line_number":405,"context_line":"            except Exception as e:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a98d1f4_9d96f892","line":402,"range":{"start_line":402,"start_character":26,"end_line":402,"end_character":79},"in_reply_to":"3a98d1f4_0afaa042","updated":"2016-09-29 02:46:59.000000000","message":"\"New size must be greater than or equal to current size (% GB)\"","commit_id":"2eb3b86f7224675d26ec979c1ebb163f88be0dd4"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"329ae3f1c88727b5d1f8d7aa3ef211c8ae312bb0","unresolved":false,"context_lines":[{"line_number":399,"context_line":"                           \"before size can be extended\"), volume.status)"},{"line_number":400,"context_line":"                    raise exceptions.CommandError(msg)"},{"line_number":401,"context_line":"                if parsed_args.size \u003c\u003d volume.size:"},{"line_number":402,"context_line":"                    msg \u003d _(\"New size must be greater than %s GB\"), volume.size"},{"line_number":403,"context_line":"                    raise exceptions.CommandError(msg)"},{"line_number":404,"context_line":"                volume_client.volumes.extend(volume.id, parsed_args.size)"},{"line_number":405,"context_line":"            except Exception as e:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a98d1f4_75c21c35","line":402,"range":{"start_line":402,"start_character":26,"end_line":402,"end_character":79},"in_reply_to":"3a98d1f4_9d96f892","updated":"2016-09-29 07:22:56.000000000","message":"Done","commit_id":"2eb3b86f7224675d26ec979c1ebb163f88be0dd4"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"56c705d3a08e0bf2c92dd44cf71a8ef2141a0922","unresolved":false,"context_lines":[{"line_number":407,"context_line":""},{"line_number":408,"context_line":"        result \u003d 0"},{"line_number":409,"context_line":"        if parsed_args.size:"},{"line_number":410,"context_line":"            try:"},{"line_number":411,"context_line":"                if volume.status !\u003d \u0027available\u0027:"},{"line_number":412,"context_line":"                    msg \u003d (_(\"Volume is in %s state, it must be available \""},{"line_number":413,"context_line":"                           \"before size can be extended\") % volume.status)"},{"line_number":414,"context_line":"                    raise exceptions.CommandError(msg)"},{"line_number":415,"context_line":"                if parsed_args.size \u003c\u003d volume.size:"},{"line_number":416,"context_line":"                    msg \u003d (_(\"New size must be greater than %s GB\")"},{"line_number":417,"context_line":"                           % volume.size)"},{"line_number":418,"context_line":"                    raise exceptions.CommandError(msg)"},{"line_number":419,"context_line":"                volume_client.volumes.extend(volume.id, parsed_args.size)"},{"line_number":420,"context_line":"            except Exception as e:"},{"line_number":421,"context_line":"                LOG.error(_(\"Failed to set volume size: %s\"), e)"},{"line_number":422,"context_line":"                result +\u003d 1"},{"line_number":423,"context_line":"        if parsed_args.property:"},{"line_number":424,"context_line":"            try:"},{"line_number":425,"context_line":"                volume_client.volumes.set_metadata("},{"line_number":426,"context_line":"                    volume.id, parsed_args.property)"},{"line_number":427,"context_line":"            except Exception as e:"},{"line_number":428,"context_line":"                LOG.error(_(\"Failed to set volume property: %s\"), e)"},{"line_number":429,"context_line":"                result +\u003d 1"},{"line_number":430,"context_line":"        if parsed_args.bootable or parsed_args.no_bootable:"},{"line_number":431,"context_line":"            try:"},{"line_number":432,"context_line":"                volume_client.volumes.set_bootable("}],"source_content_type":"text/x-python","patch_set":7,"id":"fa6399be_23307f9e","line":429,"range":{"start_line":410,"start_character":0,"end_line":429,"end_character":27},"updated":"2016-10-18 03:18:24.000000000","message":"these changes should be isolated to their own change, but that\u0027s OK","commit_id":"5e3d39a37da578924f502c95b27dae3602bdf8c2"}],"releasenotes/notes/rename-volume-set-options-c3ca67525df8216e.yaml":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"3a1c91c6e5a3bdf5ca79539f7ab0088c6ae5e171","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3a98d1f4_029e2e56","updated":"2016-09-28 13:07:41.000000000","message":"you don\u0027t need a release note for this, the option hasn\u0027t been released yet, it\u0027s only merged into master: https://github.com/openstack/python-openstackclient/commit/6a914d0056e810e1ef37eaf4f01cd5c85217aba6","commit_id":"2eb3b86f7224675d26ec979c1ebb163f88be0dd4"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"987223dd942729597d02e3f4e0bb87ffec5f7513","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3a98d1f4_87b5c9ce","in_reply_to":"3a98d1f4_029e2e56","updated":"2016-09-29 02:00:14.000000000","message":"Yes, I will remove this","commit_id":"2eb3b86f7224675d26ec979c1ebb163f88be0dd4"}]}