)]}'
{"doc/source/command-objects/volume.rst":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"e4b666301937773c6d2bfb2424b244d97f61bdc1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3a98d1f4_84344e4a","updated":"2016-10-03 02:55:37.000000000","message":"looks like the help is mostly copied from cinderclient and adapted as needed, good start.\n\n-- https://github.com/openstack/python-cinderclient/blob/master/cinderclient/v3/shell.py","commit_id":"a83086a3a8a052b5fd7f7f130a515d9eef74c8bb"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"1e064f464d1a07be6cf3f9ac8d304556c64c90ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1a95cdbc_9555141f","in_reply_to":"3a98d1f4_84344e4a","updated":"2016-10-04 15:33:41.000000000","message":"Yep, thanks ;)","commit_id":"a83086a3a8a052b5fd7f7f130a515d9eef74c8bb"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"e0b53a5179ea64f9cd6231fd8a4de32229574590","unresolved":false,"context_lines":[{"line_number":208,"context_line":"    os volume migrate"},{"line_number":209,"context_line":"        --host \u003chost\u003e"},{"line_number":210,"context_line":"        [--force-host-copy]"},{"line_number":211,"context_line":"        [--lock-volume]"},{"line_number":212,"context_line":"        \u003cvolume\u003e"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":".. option:: --host \u003chost\u003e"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a95cdbc_e31ffd05","line":211,"updated":"2016-10-06 23:18:28.000000000","message":"Let\u0027s do the exclusive pair of options for these.  I\u0027m not sure I understand them enough to know how to name them though...which is a clue that these may not be the best names for options...","commit_id":"a83086a3a8a052b5fd7f7f130a515d9eef74c8bb"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"e0b53a5179ea64f9cd6231fd8a4de32229574590","unresolved":false,"context_lines":[{"line_number":218,"context_line":".. option:: --force-host-copy"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    Enable generic host-based force-migration,"},{"line_number":221,"context_line":"    which bypasses driver optimizations (default to False)"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":".. option:: --lock-volume"},{"line_number":224,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a95cdbc_03194922","line":221,"updated":"2016-10-06 23:18:28.000000000","message":"\u0027default is false\u0027 doesn\u0027t make sense","commit_id":"a83086a3a8a052b5fd7f7f130a515d9eef74c8bb"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"e0b53a5179ea64f9cd6231fd8a4de32229574590","unresolved":false,"context_lines":[{"line_number":229,"context_line":"    status will be in maintenance during the migration."},{"line_number":230,"context_line":"    Otherwise means it allows the volume migration to be"},{"line_number":231,"context_line":"    aborted. The volume status is still in the original"},{"line_number":232,"context_line":"    status) (default to false)"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"    *Volume version 2 only*"},{"line_number":235,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a95cdbc_231645f1","line":232,"updated":"2016-10-06 23:18:28.000000000","message":"\u0027default is false\u0027 doesn\u0027t make sense\n\nthe length of the parentetical here indicates there is more to be explained.  Maybe the top-level command description should cover the multiple modes?","commit_id":"a83086a3a8a052b5fd7f7f130a515d9eef74c8bb"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"3ecab053a90df0cdd5b2c1304d7c669a8c348b80","unresolved":false,"context_lines":[{"line_number":206,"context_line":".. code:: bash"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    os volume migrate"},{"line_number":209,"context_line":"        --host \u003chost\u003e"},{"line_number":210,"context_line":"        [--force]"},{"line_number":211,"context_line":"        [--lock-volume | --unlock-volume]"},{"line_number":212,"context_line":"        \u003cvolume\u003e"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa6399be_ca53e869","line":209,"updated":"2016-10-13 12:37:28.000000000","message":"Switching the order from existing cinder syntax:\ncinder migrate \u003cvolume\u003e \u003chost\u003e\nto this seems weird:\nos volume migrate --host\u003chost\u003e \u003cvolume\u003e\nBut I guess it\u0027s ok. I could see operators getting confused, or having to do extra work to migrate their scripts.","commit_id":"fb0296216fcf6b3648ff91131e05e23f28b9582b"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"a9aaa0b48089e73694ee7e4531ef43e724ec0768","unresolved":false,"context_lines":[{"line_number":206,"context_line":".. code:: bash"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    os volume migrate"},{"line_number":209,"context_line":"        --host \u003chost\u003e"},{"line_number":210,"context_line":"        [--force]"},{"line_number":211,"context_line":"        [--lock-volume | --unlock-volume]"},{"line_number":212,"context_line":"        \u003cvolume\u003e"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa6399be_a9c69765","line":209,"in_reply_to":"fa6399be_ca53e869","updated":"2016-10-14 09:22:34.000000000","message":"I am also OK with implementing it like\n    os volume migrate \u003chost\u003e \u003cvolume\u003e\nThis will similar with the command in cinder\nBut I do not sure which format is better for the UX\n\n1.Users can ignore the order of input parameters (need not match the order \"\u003chost\u003e \u003cvolume\u003e\") if the \"host\" is a required option.\n2.If implementing the \"host\" as a positional parameter then users can input less words (need not input \"--host\") when using this command.\n\nIt seems like OSC has not a rule or a doc about this, I hope can get some more suggestions about this and then I will choose a better way to implement it.","commit_id":"fb0296216fcf6b3648ff91131e05e23f28b9582b"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"3ecab053a90df0cdd5b2c1304d7c669a8c348b80","unresolved":false,"context_lines":[{"line_number":215,"context_line":""},{"line_number":216,"context_line":"    Destination host (takes the form: host@backend-name#pool) (required)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":".. option:: --force"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    Enable generic host-based force-migration,"},{"line_number":221,"context_line":"    which bypasses driver optimizations"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa6399be_0a8c007e","line":218,"updated":"2016-10-13 12:37:28.000000000","message":"I\u0027m not sure abbreviating the existing cinder migrate --force-host-copy is a good idea.\nUsually, I think of --force as a way of overcoming state checks and/or locking mechanisms. But --force-host-copy means forcing the volume to by copied from one host to another, without driver optimizations (that might just move around pointers or do some renaming). I think we could stand to be more explicit here.\nI\u0027m not sure what discussion went into the original naming of this option, but I imagine quite a git of bikeshedding...","commit_id":"fb0296216fcf6b3648ff91131e05e23f28b9582b"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"a9aaa0b48089e73694ee7e4531ef43e724ec0768","unresolved":false,"context_lines":[{"line_number":215,"context_line":""},{"line_number":216,"context_line":"    Destination host (takes the form: host@backend-name#pool) (required)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":".. option:: --force"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    Enable generic host-based force-migration,"},{"line_number":221,"context_line":"    which bypasses driver optimizations"}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa6399be_1b07ca18","line":218,"in_reply_to":"fa6399be_0a8c007e","updated":"2016-10-14 09:22:34.000000000","message":"OK, Thanks for your explanation, I get you opinion, I will change back to \"--force-host-copy\"","commit_id":"fb0296216fcf6b3648ff91131e05e23f28b9582b"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"efb86641e6cde93a689152b8f9aab1dfa0df9653","unresolved":false,"context_lines":[{"line_number":222,"context_line":""},{"line_number":223,"context_line":".. option:: --lock-volume"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    Enable the termination of volume migration caused by"},{"line_number":226,"context_line":"    other commands (This option applies to the available"},{"line_number":227,"context_line":"    volume, specfied means it locks the volume state and"},{"line_number":228,"context_line":"    does not allow the migration to be aborted. The volume"},{"line_number":229,"context_line":"    status will be in maintenance during the migration."},{"line_number":230,"context_line":"    Otherwise means it allows the volume migration to be"},{"line_number":231,"context_line":"    aborted. The volume status is still in the original"},{"line_number":232,"context_line":"    status) (default to false)"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"    *Volume version 2 only*"},{"line_number":235,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa6399be_1e10f14d","line":232,"range":{"start_line":225,"start_character":4,"end_line":232,"end_character":30},"updated":"2016-10-12 16:12:14.000000000","message":"this, and the help below is not the best (too many words). but it is accurate, it is copied from cinderclient\u0027s help\n\nhow about just:\n\n  If specified, the volume state will be locked and will not allow\n  a migration to be aborted (possibly by another operation).","commit_id":"fb0296216fcf6b3648ff91131e05e23f28b9582b"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"3ecab053a90df0cdd5b2c1304d7c669a8c348b80","unresolved":false,"context_lines":[{"line_number":222,"context_line":""},{"line_number":223,"context_line":".. option:: --lock-volume"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    Enable the termination of volume migration caused by"},{"line_number":226,"context_line":"    other commands (This option applies to the available"},{"line_number":227,"context_line":"    volume, specfied means it locks the volume state and"},{"line_number":228,"context_line":"    does not allow the migration to be aborted. The volume"},{"line_number":229,"context_line":"    status will be in maintenance during the migration."},{"line_number":230,"context_line":"    Otherwise means it allows the volume migration to be"},{"line_number":231,"context_line":"    aborted. The volume status is still in the original"},{"line_number":232,"context_line":"    status) (default to false)"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"    *Volume version 2 only*"},{"line_number":235,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa6399be_6ac81ca9","line":232,"range":{"start_line":225,"start_character":4,"end_line":232,"end_character":30},"in_reply_to":"fa6399be_1e10f14d","updated":"2016-10-13 12:37:28.000000000","message":"Yes, I think this shortened version gives enough info.\n\nAnd I think the original statement is confusing, since \u0027--lock-volume\u0027 does not enable the termination, it disables the termination of the migration.","commit_id":"fb0296216fcf6b3648ff91131e05e23f28b9582b"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"a9aaa0b48089e73694ee7e4531ef43e724ec0768","unresolved":false,"context_lines":[{"line_number":222,"context_line":""},{"line_number":223,"context_line":".. option:: --lock-volume"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    Enable the termination of volume migration caused by"},{"line_number":226,"context_line":"    other commands (This option applies to the available"},{"line_number":227,"context_line":"    volume, specfied means it locks the volume state and"},{"line_number":228,"context_line":"    does not allow the migration to be aborted. The volume"},{"line_number":229,"context_line":"    status will be in maintenance during the migration."},{"line_number":230,"context_line":"    Otherwise means it allows the volume migration to be"},{"line_number":231,"context_line":"    aborted. The volume status is still in the original"},{"line_number":232,"context_line":"    status) (default to false)"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"    *Volume version 2 only*"},{"line_number":235,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa6399be_fb2cd69a","line":232,"range":{"start_line":225,"start_character":4,"end_line":232,"end_character":30},"in_reply_to":"fa6399be_6ac81ca9","updated":"2016-10-14 09:22:34.000000000","message":"Thanks for suggestion! I will change it","commit_id":"fb0296216fcf6b3648ff91131e05e23f28b9582b"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"efb86641e6cde93a689152b8f9aab1dfa0df9653","unresolved":false,"context_lines":[{"line_number":235,"context_line":""},{"line_number":236,"context_line":".. option:: --unlock-volume"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    Disable the termination of volume migration caused by"},{"line_number":239,"context_line":"    other commands (default) (This option applies to the"},{"line_number":240,"context_line":"    available volume, specfied means it allows the volume"},{"line_number":241,"context_line":"    migration to be aborted. The volume status is still in"},{"line_number":242,"context_line":"    the original status)"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"    *Volume version 2 only*"},{"line_number":245,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa6399be_fefa5dbc","line":242,"range":{"start_line":238,"start_character":4,"end_line":242,"end_character":24},"updated":"2016-10-12 16:12:14.000000000","message":"how about:\n\n  If specified, the volume state will not be locked and the a\n  migration can be aborted (possibly by another operation).","commit_id":"fb0296216fcf6b3648ff91131e05e23f28b9582b"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"a9aaa0b48089e73694ee7e4531ef43e724ec0768","unresolved":false,"context_lines":[{"line_number":235,"context_line":""},{"line_number":236,"context_line":".. option:: --unlock-volume"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    Disable the termination of volume migration caused by"},{"line_number":239,"context_line":"    other commands (default) (This option applies to the"},{"line_number":240,"context_line":"    available volume, specfied means it allows the volume"},{"line_number":241,"context_line":"    migration to be aborted. The volume status is still in"},{"line_number":242,"context_line":"    the original status)"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"    *Volume version 2 only*"},{"line_number":245,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa6399be_dbd1d258","line":242,"range":{"start_line":238,"start_character":4,"end_line":242,"end_character":24},"in_reply_to":"fa6399be_b6dffd67","updated":"2016-10-14 09:22:34.000000000","message":"Yea, as Steve said, we often use mutually exclusive flag options in this case.","commit_id":"fb0296216fcf6b3648ff91131e05e23f28b9582b"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"93528fce063a6d9aad1f94842453e0e2d3ab1a97","unresolved":false,"context_lines":[{"line_number":235,"context_line":""},{"line_number":236,"context_line":".. option:: --unlock-volume"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    Disable the termination of volume migration caused by"},{"line_number":239,"context_line":"    other commands (default) (This option applies to the"},{"line_number":240,"context_line":"    available volume, specfied means it allows the volume"},{"line_number":241,"context_line":"    migration to be aborted. The volume status is still in"},{"line_number":242,"context_line":"    the original status)"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"    *Volume version 2 only*"},{"line_number":245,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa6399be_b6dffd67","line":242,"range":{"start_line":238,"start_character":4,"end_line":242,"end_character":24},"in_reply_to":"fa6399be_cad048f9","updated":"2016-10-13 13:50:02.000000000","message":"this is an OSC commandment, we try to give flag their logical opposite (with a few exceptions: --long, --force)","commit_id":"fb0296216fcf6b3648ff91131e05e23f28b9582b"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"3ecab053a90df0cdd5b2c1304d7c669a8c348b80","unresolved":false,"context_lines":[{"line_number":235,"context_line":""},{"line_number":236,"context_line":".. option:: --unlock-volume"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    Disable the termination of volume migration caused by"},{"line_number":239,"context_line":"    other commands (default) (This option applies to the"},{"line_number":240,"context_line":"    available volume, specfied means it allows the volume"},{"line_number":241,"context_line":"    migration to be aborted. The volume status is still in"},{"line_number":242,"context_line":"    the original status)"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"    *Volume version 2 only*"},{"line_number":245,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa6399be_cad048f9","line":242,"range":{"start_line":238,"start_character":4,"end_line":242,"end_character":24},"in_reply_to":"fa6399be_fefa5dbc","updated":"2016-10-13 12:37:28.000000000","message":"Do we really need both --unlock-volume and --lock-volume?\nThe default is that the volume is unlocked (migration capable of being aborted). Why not just have the one option?","commit_id":"fb0296216fcf6b3648ff91131e05e23f28b9582b"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"b784181d015f9ffddcf7e88c4e583f71aa9d488f","unresolved":false,"context_lines":[{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    os volume migrate"},{"line_number":209,"context_line":"        --host \u003chost\u003e"},{"line_number":210,"context_line":"        [--force]"},{"line_number":211,"context_line":"        [--lock-volume | --unlock-volume]"},{"line_number":212,"context_line":"        \u003cvolume\u003e"},{"line_number":213,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa6399be_29850b59","line":210,"updated":"2016-10-14 20:45:37.000000000","message":"--force-host-copy?","commit_id":"e636bd6f02da9fe4abdd7b22117a49aeb1ce8579"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"b32528b2ec9d178be3f3c2fc5c136b7fa702c5b4","unresolved":false,"context_lines":[{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    os volume migrate"},{"line_number":209,"context_line":"        --host \u003chost\u003e"},{"line_number":210,"context_line":"        [--force]"},{"line_number":211,"context_line":"        [--lock-volume | --unlock-volume]"},{"line_number":212,"context_line":"        \u003cvolume\u003e"},{"line_number":213,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa6399be_c357c324","line":210,"in_reply_to":"fa6399be_29850b59","updated":"2016-10-18 03:48:22.000000000","message":"Done","commit_id":"e636bd6f02da9fe4abdd7b22117a49aeb1ce8579"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"b784181d015f9ffddcf7e88c4e583f71aa9d488f","unresolved":false,"context_lines":[{"line_number":215,"context_line":""},{"line_number":216,"context_line":"    Destination host (takes the form: host@backend-name#pool) (required)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":".. option:: --force-host-copy"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    Enable generic host-based force-migration,"},{"line_number":221,"context_line":"    which bypasses driver optimizations"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa6399be_e9b8732c","line":218,"updated":"2016-10-14 20:45:37.000000000","message":"I saw the comments in previous patch sets, this option\u0027s purpose is not clear from the name.  I\u0027ll trust that it makes sense to someone though.","commit_id":"e636bd6f02da9fe4abdd7b22117a49aeb1ce8579"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"b32528b2ec9d178be3f3c2fc5c136b7fa702c5b4","unresolved":false,"context_lines":[{"line_number":215,"context_line":""},{"line_number":216,"context_line":"    Destination host (takes the form: host@backend-name#pool) (required)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":".. option:: --force-host-copy"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    Enable generic host-based force-migration,"},{"line_number":221,"context_line":"    which bypasses driver optimizations"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa6399be_fefd4009","line":218,"in_reply_to":"fa6399be_e9b8732c","updated":"2016-10-18 03:48:22.000000000","message":"I have no idea for the option renaming...seems like it is not easy to explain that clearly with a few words...","commit_id":"e636bd6f02da9fe4abdd7b22117a49aeb1ce8579"}]}