)]}'
{"id":"openstack%2Fpython-openstackclient~382699","triplet_id":"openstack%2Fpython-openstackclient~master~I8e626672ec94fc837610216bccb4354dbdedca17","project":"openstack/python-openstackclient","branch":"master","topic":"bug/1630822","hashtags":[],"change_id":"I8e626672ec94fc837610216bccb4354dbdedca17","subject":"Mask passwords in debug logs for auth_config_hook","status":"MERGED","created":"2016-10-06 01:12:10.000000000","updated":"2016-10-07 01:34:03.000000000","submitted":"2016-10-07 01:34:03.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"2801cfbbc8555ed4249deffb24d3a078cf9573f7","_number":382699,"virtual_id_number":382699,"owner":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2016-10-07 01:34:03.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10086,"name":"Xav Paice","email":"xav.paice@canonical.com","username":"xavpaice"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":2,"date":"2016-10-07 00:51:20.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-10-06 02:21:30.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10086,"name":"Xav Paice","email":"xav.paice@canonical.com","username":"xavpaice"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":2,"date":"2016-10-06 16:50:34.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":1,"date":"2016-10-07 00:51:20.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10086,"name":"Xav Paice","email":"xav.paice@canonical.com","username":"xavpaice"},{"value":0,"date":"2016-10-06 01:56:15.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":10086,"name":"Xav Paice","email":"xav.paice@canonical.com","username":"xavpaice"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-10-06 02:21:30.000000000","updated_by":{"_account_id":10086,"name":"Xav Paice","email":"xav.paice@canonical.com","username":"xavpaice"},"reviewer":{"_account_id":10086,"name":"Xav Paice","email":"xav.paice@canonical.com","username":"xavpaice"},"state":"REVIEWER"},{"updated":"2016-10-06 16:50:34.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2016-10-07 00:51:20.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2016-10-07 01:34:03.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"e5ac4ec6b4ff126b9994ec701df938dc50eeccc9","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2016-10-06 01:12:10.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2b67e859d0a7543c7e326dee590dff661e3b1c7c","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2016-10-06 01:21:31.000000000","message":"Patch Set 1: Workflow-1\n\nNevermind this isn\u0027t it.","accounts_in_message":[],"_revision_number":1},{"id":"4561503e27760779fe01d998c391578588f82196","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-06 01:55:15.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/99/382699/1/check/gate-python-openstackclient-docs-ubuntu-xenial/887041b//doc/build/html/ : SUCCESS in 4m 49s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/99/382699/1/check/gate-python-openstackclient-pep8-ubuntu-xenial/061359c/ : SUCCESS in 2m 43s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/99/382699/1/check/gate-python-openstackclient-python27-ubuntu-xenial/977328f/ : SUCCESS in 4m 03s\n- gate-python-openstackclient-python34 http://logs.openstack.org/99/382699/1/check/gate-python-openstackclient-python34/4aa0d1a/ : SUCCESS in 2m 59s\n- gate-python-openstackclient-python35-nv http://logs.openstack.org/99/382699/1/check/gate-python-openstackclient-python35-nv/cce8d56/ : SUCCESS in 4m 45s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/99/382699/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/7217400/ : SUCCESS in 42m 53s\n- check-osc-plugins http://logs.openstack.org/99/382699/1/check/check-osc-plugins/fa50adc/ : SUCCESS in 5m 09s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/99/382699/1/check/gate-osc-dsvm-functional/6d2d9b4/ : SUCCESS in 14m 51s","accounts_in_message":[],"_revision_number":1},{"id":"f4d2acdd276c2442b4fd486561f70007fa93667a","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2016-10-06 01:56:15.000000000","message":"Patch Set 1: -Workflow\n\nActually this is correct, but for the latest osc it\u0027s leaking the password from osc-lib, which I\u0027ve also fixed, but we should have this in osc so we can backport to older versions that aren\u0027t using osc-lib.","accounts_in_message":[],"_revision_number":1},{"id":"392edfab82a751e4b8564b541cc8a5f13c0446f2","author":{"_account_id":10086,"name":"Xav Paice","email":"xav.paice@canonical.com","username":"xavpaice"},"date":"2016-10-06 02:21:30.000000000","message":"Patch Set 1: Code-Review+1\n\nThe same change works with osc-lib in the most recent versions of openstackclient, but where ocs-lib isn\u0027t yet used I think this change is relevant.","accounts_in_message":[],"_revision_number":1},{"id":"6d98049c83b01bb0955094617caa42a4b0ccce7e","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2016-10-06 16:50:34.000000000","message":"Patch Set 1: Code-Review+2\n\nYes, this is also needed until the compatibility duplication can be removed","accounts_in_message":[],"_revision_number":1},{"id":"7ca10d016bc60599dacb11c25b42e002d7e45174","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-10-07 00:51:20.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"83771b4f3405e5c1d361b4160c9eec41f296e238","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-07 00:51:30.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"805de4a1c52274e65a8c51a9c683400891e15f49","date":"2016-10-07 01:34:03.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"575131ee371b1c4c23c722e87509e3e732200acb","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-07 01:34:03.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/99/382699/1/gate/gate-python-openstackclient-docs-ubuntu-xenial/b8ee4a4//doc/build/html/ : SUCCESS in 4m 33s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/99/382699/1/gate/gate-python-openstackclient-pep8-ubuntu-xenial/235dc27/ : SUCCESS in 2m 42s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/99/382699/1/gate/gate-python-openstackclient-python27-ubuntu-xenial/e4c16fd/ : SUCCESS in 2m 48s\n- gate-python-openstackclient-python34 http://logs.openstack.org/99/382699/1/gate/gate-python-openstackclient-python34/b6c9062/ : SUCCESS in 4m 26s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/99/382699/1/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/16f90a0/ : SUCCESS in 42m 31s\n- gate-osc-dsvm-functional http://logs.openstack.org/99/382699/1/gate/gate-osc-dsvm-functional/a914a51/ : SUCCESS in 15m 26s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"cd1a412408f068aeef97c1ee368400307fce7733","revisions":{"cd1a412408f068aeef97c1ee368400307fce7733":{"kind":"REWORK","_number":1,"created":"2016-10-06 01:12:10.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/99/382699/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/99/382699/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/99/382699/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/99/382699/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/99/382699/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/99/382699/1"}}},"commit":{"parents":[{"commit":"bfeecd50fdb8f1475d51ac662eb09514a1754345","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/bfeecd50fdb8f1475d51ac662eb09514a1754345"}]}],"author":{"name":"Matt Riedemann","email":"mriedem@us.ibm.com","date":"2016-10-06 01:11:16.000000000","tz":-240},"committer":{"name":"Matt Riedemann","email":"mriedem@us.ibm.com","date":"2016-10-06 01:11:16.000000000","tz":-240},"subject":"Mask passwords in debug logs for auth_config_hook","message":"Mask passwords in debug logs for auth_config_hook\n\nThe auth config hook can have credentials in it so\nwe have to mask the config before logging it. To\navoid doing the work of masking the password if we\naren\u0027t going to log it, there is a conditional put\naround the actual debug statement.\n\nChange-Id: I8e626672ec94fc837610216bccb4354dbdedca17\nCloses-Bug: #1630822\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/cd1a412408f068aeef97c1ee368400307fce7733"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/cd1a412408f068aeef97c1ee368400307fce7733"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}