)]}'
{"openstackclient/shell.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"4e56dd331e382ea017172e54f60554fc07aae7f0","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                        self.log.warning("},{"line_number":97,"context_line":"                            \"%s version %s is not in supported versions: %s\""},{"line_number":98,"context_line":"                            % (api, version_opt,"},{"line_number":99,"context_line":"                               \u0027, \u0027.join(list(sorted("},{"line_number":100,"context_line":"                                   mod.API_VERSIONS.keys(),"},{"line_number":101,"context_line":"                                   key\u003dlambda s: list(map(int, s.split(\u0027.\u0027))))"},{"line_number":102,"context_line":"                        ))))"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"                # Command groups deal only with major versions"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a95cdbc_b9436241","line":101,"range":{"start_line":99,"start_character":46,"end_line":101,"end_character":78},"updated":"2016-10-07 00:38:34.000000000","message":"anyway we can pull this out to before the warning? the original bit of code was already hard to read, now it\u0027s really hard :)\n\n  # Sort API versions so major and minor versions appear properly\n  sorted_versions \u003d sorted(mod.API_VERSIONS.keys(),\n                           key\u003dlambda s: list(map(int, s.split(\u0027.\u0027))))","commit_id":"47077ff085305222038cceada89940750554d937"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"763839c8539a141c51dc9977a9d6fdac3d2deb42","unresolved":false,"context_lines":[{"line_number":98,"context_line":"                            % (api, version_opt,"},{"line_number":99,"context_line":"                               \u0027, \u0027.join(list(sorted("},{"line_number":100,"context_line":"                                   mod.API_VERSIONS.keys(),"},{"line_number":101,"context_line":"                                   key\u003dlambda s: list(map(int, s.split(\u0027.\u0027))))"},{"line_number":102,"context_line":"                        ))))"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"                # Command groups deal only with major versions"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a95cdbc_9d394d44","line":101,"updated":"2016-10-06 15:06:24.000000000","message":"let\u0027s just convert them to float instead of this.","commit_id":"47077ff085305222038cceada89940750554d937"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"44646ab3884150c75ae338e441c4cf84413e5465","unresolved":false,"context_lines":[{"line_number":98,"context_line":"                            % (api, version_opt,"},{"line_number":99,"context_line":"                               \u0027, \u0027.join(list(sorted("},{"line_number":100,"context_line":"                                   mod.API_VERSIONS.keys(),"},{"line_number":101,"context_line":"                                   key\u003dlambda s: list(map(int, s.split(\u0027.\u0027))))"},{"line_number":102,"context_line":"                        ))))"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"                # Command groups deal only with major versions"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a95cdbc_2352dcdd","line":101,"in_reply_to":"1a95cdbc_9d394d44","updated":"2016-10-06 15:36:11.000000000","message":"I tried it and floats were sorted by this way:\n\u003e\u003e\u003e vers \u003d [\u00271.4\u0027, \u00271.5\u0027, \u00271.6\u0027, \u00271.7\u0027, \u00271.1\u0027, \u00271.2\u0027, \u00271.3\u0027, \u00271.8\u0027, \u00271.9\u0027, \u00271.16\u0027, \u00271.17\u0027, \u00271.14\u0027, \u00271.15\u0027, \u00271.12\u0027, \u00271.13\u0027, \u00271.10\u0027, \u00271.11\u0027, \u00271.18\u0027, \u00271.19\u0027, \u00271\u0027, \u00271.23\u0027, \u00271.22\u0027, \u00271.21\u0027, \u00271.20\u0027, \u00271.24\u0027]\n\u003e\u003e\u003e print sorted([float(i) for i in vers])\n[1.0, 1.1, 1.1, 1.11, 1.12, 1.13, 1.14, 1.15, 1.16, 1.17, 1.18, 1.19, 1.2, 1.2, 1.21, 1.22, 1.23, 1.24, 1.3, 1.4, 1.5, 1.6, 1.7, 1.8, 1.9]\n\nVlad, can i get expected sorting by options for sorted() function?","commit_id":"47077ff085305222038cceada89940750554d937"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"5e72f7fa0d62ef59c6c84744905a0db54aea34d9","unresolved":false,"context_lines":[{"line_number":98,"context_line":"                            % (api, version_opt,"},{"line_number":99,"context_line":"                               \u0027, \u0027.join(list(sorted("},{"line_number":100,"context_line":"                                   mod.API_VERSIONS.keys(),"},{"line_number":101,"context_line":"                                   key\u003dlambda s: list(map(int, s.split(\u0027.\u0027))))"},{"line_number":102,"context_line":"                        ))))"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"                # Command groups deal only with major versions"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a95cdbc_c34cd844","line":101,"in_reply_to":"1a95cdbc_9d394d44","updated":"2016-10-06 16:58:03.000000000","message":"Vlad, converting to float would work only until the version has only two parts (XX.YY). while AFAIK this is the case everywhere ATM, the moment someone introduces XX.YY.ZZ converting to float will break.","commit_id":"47077ff085305222038cceada89940750554d937"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"b6ce4a54265dec58daf7729602b0fcc81c55e032","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                        self.log.warning("},{"line_number":97,"context_line":"                            \"%s version %s is not in supported versions: %s\""},{"line_number":98,"context_line":"                            % (api, version_opt,"},{"line_number":99,"context_line":"                               \u0027, \u0027.join(list(sorted("},{"line_number":100,"context_line":"                                   mod.API_VERSIONS.keys(),"},{"line_number":101,"context_line":"                                   key\u003dlambda s: list(map(int, s.split(\u0027.\u0027))))"},{"line_number":102,"context_line":"                        ))))"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"                # Command groups deal only with major versions"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a95cdbc_f5d32102","line":101,"range":{"start_line":99,"start_character":46,"end_line":101,"end_character":78},"in_reply_to":"1a95cdbc_b9436241","updated":"2016-10-07 10:57:34.000000000","message":"Thanks! Also i removed list() from original line because sorted() already returns list.","commit_id":"47077ff085305222038cceada89940750554d937"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"4e56dd331e382ea017172e54f60554fc07aae7f0","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                               \u0027, \u0027.join(list(sorted("},{"line_number":100,"context_line":"                                   mod.API_VERSIONS.keys(),"},{"line_number":101,"context_line":"                                   key\u003dlambda s: list(map(int, s.split(\u0027.\u0027))))"},{"line_number":102,"context_line":"                        ))))"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"                # Command groups deal only with major versions"},{"line_number":105,"context_line":"                version \u003d \u0027.v\u0027 + version_opt.replace(\u0027.\u0027, \u0027_\u0027).split(\u0027_\u0027)[0]"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a95cdbc_1930d6e7","line":102,"range":{"start_line":102,"start_character":24,"end_line":102,"end_character":28},"updated":"2016-10-07 00:38:34.000000000","message":"pep8 is failing here\n\nif you pull the code up a bit, you can leave these on the original line and not fail pep8 :)","commit_id":"47077ff085305222038cceada89940750554d937"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"b6ce4a54265dec58daf7729602b0fcc81c55e032","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                               \u0027, \u0027.join(list(sorted("},{"line_number":100,"context_line":"                                   mod.API_VERSIONS.keys(),"},{"line_number":101,"context_line":"                                   key\u003dlambda s: list(map(int, s.split(\u0027.\u0027))))"},{"line_number":102,"context_line":"                        ))))"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"                # Command groups deal only with major versions"},{"line_number":105,"context_line":"                version \u003d \u0027.v\u0027 + version_opt.replace(\u0027.\u0027, \u0027_\u0027).split(\u0027_\u0027)[0]"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a95cdbc_75df110d","line":102,"range":{"start_line":102,"start_character":24,"end_line":102,"end_character":28},"in_reply_to":"1a95cdbc_1930d6e7","updated":"2016-10-07 10:57:34.000000000","message":"Done","commit_id":"47077ff085305222038cceada89940750554d937"}]}