)]}'
{"openstackclient/network/v2/router.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"92120f7aff552d83ddeb76971d0ac2203bcc3ffb","unresolved":false,"context_lines":[{"line_number":519,"context_line":"        attrs \u003d {}"},{"line_number":520,"context_line":"        if parsed_args.routes:"},{"line_number":521,"context_line":"            for route in parsed_args.routes:"},{"line_number":522,"context_line":"                route[\u0027nexthop\u0027] \u003d route.pop(\u0027gateway\u0027)"},{"line_number":523,"context_line":"            try:"},{"line_number":524,"context_line":"                for route in parsed_args.routes:"},{"line_number":525,"context_line":"                    tmp_routes.remove(route)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a95cdbc_dd61c306","line":522,"updated":"2016-10-08 17:48:41.000000000","message":"We already loop through the routes below, so let\u0027s just change them there.","commit_id":"6a54407e14e7c09fb06804528b9a9110a41485f4"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"0a832d8a5840d2e88d90ced09e8bc977c8c53963","unresolved":false,"context_lines":[{"line_number":519,"context_line":"        attrs \u003d {}"},{"line_number":520,"context_line":"        if parsed_args.routes:"},{"line_number":521,"context_line":"            for route in parsed_args.routes:"},{"line_number":522,"context_line":"                route[\u0027nexthop\u0027] \u003d route.pop(\u0027gateway\u0027)"},{"line_number":523,"context_line":"            try:"},{"line_number":524,"context_line":"                for route in parsed_args.routes:"},{"line_number":525,"context_line":"                    tmp_routes.remove(route)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a95cdbc_c13382f4","line":522,"in_reply_to":"1a95cdbc_7198d31c","updated":"2016-10-10 12:44:22.000000000","message":"Sure, but doesn\u0027t the following work:\n\n\nfor route in parsed_args.routes:\n    route[\u0027nexthop\u0027] \u003d route.pop(\u0027gateway\u0027)\n    tmp_routes.remove(route)","commit_id":"6a54407e14e7c09fb06804528b9a9110a41485f4"},{"author":{"_account_id":5003,"name":"Choe, Cheng-Dae","email":"whitekid@gmail.com","username":"whitekid"},"change_message_id":"02d808741890f80a1fc5b7445dbbbfaae80584c9","unresolved":false,"context_lines":[{"line_number":519,"context_line":"        attrs \u003d {}"},{"line_number":520,"context_line":"        if parsed_args.routes:"},{"line_number":521,"context_line":"            for route in parsed_args.routes:"},{"line_number":522,"context_line":"                route[\u0027nexthop\u0027] \u003d route.pop(\u0027gateway\u0027)"},{"line_number":523,"context_line":"            try:"},{"line_number":524,"context_line":"                for route in parsed_args.routes:"},{"line_number":525,"context_line":"                    tmp_routes.remove(route)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a95cdbc_9a1c786b","line":522,"in_reply_to":"1a95cdbc_c13382f4","updated":"2016-10-10 14:57:00.000000000","message":"AH.. I See.. I will submit new patch.\nThanks.","commit_id":"6a54407e14e7c09fb06804528b9a9110a41485f4"},{"author":{"_account_id":5003,"name":"Choe, Cheng-Dae","email":"whitekid@gmail.com","username":"whitekid"},"change_message_id":"86b10f51761568eaebcc46ce09f084dc5883b199","unresolved":false,"context_lines":[{"line_number":519,"context_line":"        attrs \u003d {}"},{"line_number":520,"context_line":"        if parsed_args.routes:"},{"line_number":521,"context_line":"            for route in parsed_args.routes:"},{"line_number":522,"context_line":"                route[\u0027nexthop\u0027] \u003d route.pop(\u0027gateway\u0027)"},{"line_number":523,"context_line":"            try:"},{"line_number":524,"context_line":"                for route in parsed_args.routes:"},{"line_number":525,"context_line":"                    tmp_routes.remove(route)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a95cdbc_7198d31c","line":522,"in_reply_to":"1a95cdbc_dd61c306","updated":"2016-10-09 14:51:32.000000000","message":"Thanks Richard.\n\nIn L525, route(requested to remove) compared with routes router info(tmp_route). so \"gateway\" should converted to \"next\" before remote the route.\n\ntmp_route copied from obj_route stores gateway as \"nexthop\" but parsed_route requested by user stores gateway as \"gateway\"","commit_id":"6a54407e14e7c09fb06804528b9a9110a41485f4"}]}