)]}'
{"id":"openstack%2Fpython-openstackclient~38698","triplet_id":"openstack%2Fpython-openstackclient~master~I3709ecdb297ab15ad44df09d89af840164271a66","project":"openstack/python-openstackclient","branch":"master","topic":"bp/nova-client","hashtags":[],"change_id":"I3709ecdb297ab15ad44df09d89af840164271a66","subject":"Add server commands: (un)lock, (un)rescue, (un)set, add/remove volume","status":"MERGED","created":"2013-07-25 20:40:32.000000000","updated":"2013-07-29 23:26:42.000000000","submitted":"2013-07-29 23:26:42.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"7ab9afdd81191f0560c0f772796d14d88555f378","_number":38698,"virtual_id_number":38698,"owner":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2013-07-29 23:26:42.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2013-07-29 23:24:18.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2013-07-29 23:24:18.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-07-27 21:07:53.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2013-07-29 23:26:42.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"8bcd4fa024a174a69b5ebac5e955ee4bd8c35370","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-25 20:42:09.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/98/38698/1/check/gate-python-openstackclient-pep8/463 : SUCCESS in 1m 30s\n- http://docs-draft.openstack.org/98/38698/1/check/gate-python-openstackclient-docs/387/doc/build/html/ : SUCCESS in 1m 15s\n- http://logs.openstack.org/98/38698/1/check/gate-python-openstackclient-python26/455 : SUCCESS in 1m 34s\n- http://logs.openstack.org/98/38698/1/check/gate-python-openstackclient-python27/459 : SUCCESS in 1m 13s\n","accounts_in_message":[],"_revision_number":1},{"id":"37b02c4edbf70b64abbe0690f450daaca864d10e","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2013-07-27 21:07:46.000000000","message":"Patch Set 1:\n\nOverall very good; I noticed that some of the commands do not have any output. And some commands (like add volume or lock) would really benefit from the user from having some feedback.\n\nUnless I\u0027m getting ahead of myself and it\u0027s handled in novaclient.","accounts_in_message":[],"_revision_number":1},{"id":"e9f4850d16cdd5fe14493cd243b9f2d5bbc494c4","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2013-07-27 21:07:53.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":1},{"id":"116453aa4e5a868959af8820889aec0512dcd851","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-07-29 15:24:18.000000000","message":"Patch Set 1:\n\nWhat output would you like to see?  The create commands need to report something new, add volume and lock have nothing new to report.  I also lean that way about those commands (like set) that make noise when nothing was asked of it: \u0027server set fred\u0027 should return nothing as nothing was asked and I don\u0027t see that as an error condition.","accounts_in_message":[],"_revision_number":1},{"id":"e8b2cf9b409a2c83b553baeb80bac7e18014c32c","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2013-07-29 15:47:57.000000000","message":"Patch Set 1:\n\nI know what you mean; I ran into the same problem in \u0027add user to group\u0027 \n\nI\u0027m just wondering if it\u0027s worth printing \u0027server updated - fred\u0027, if it works successfully. \n\nBut on the other hand, I guess it\u0027s assumed it\u0027s always going to work, and if it does\u0027t the client should toss up an error?","accounts_in_message":[],"_revision_number":1},{"id":"30d48e6901c5b92ccc3bb5284987f3762abbbc37","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-07-29 15:55:21.000000000","message":"Patch Set 1:\n\nUNIX philosophy: no news is good news.  That works until we slip and some error happens and isn\u0027t reported.  I don\u0027t know of any of those ATM.","accounts_in_message":[],"_revision_number":1},{"id":"2e4ee2dfe3a135b4896fa346ef7663e782360094","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-07-29 23:21:39.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"980267f95be3246647b23abdffa541a9f83e0ed5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-29 23:23:21.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/98/38698/2/check/gate-python-openstackclient-pep8/479 : SUCCESS in 1m 12s\n- http://docs-draft.openstack.org/98/38698/2/check/gate-python-openstackclient-docs/403/doc/build/html/ : SUCCESS in 1m 29s\n- http://logs.openstack.org/98/38698/2/check/gate-python-openstackclient-python26/471 : SUCCESS in 1m 39s\n- http://logs.openstack.org/98/38698/2/check/gate-python-openstackclient-python27/475 : SUCCESS in 1m 18s\n","accounts_in_message":[],"_revision_number":2},{"id":"4ae1b7a09d43c23c55a3b2a92dd51ccdaa2d792f","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2013-07-29 23:24:18.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\nRebased...","accounts_in_message":[],"_revision_number":2},{"id":"d6b0a07230c8a944670f09d0e259e1088acdce80","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-29 23:24:19.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"0c4c3ecbc7679501f511df4d85066cff6b7e0b77","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-29 23:26:42.000000000","message":"Patch Set 2: Verified\n\nBuild succeeded.\n\n- http://docs-draft.openstack.org/98/38698/2/gate/gate-python-openstackclient-docs/404/doc/build/html/ : SUCCESS in 1m 54s\n- http://logs.openstack.org/98/38698/2/gate/gate-python-openstackclient-pep8/480 : SUCCESS in 1m 34s\n- http://logs.openstack.org/98/38698/2/gate/gate-python-openstackclient-python26/472 : SUCCESS in 2m 20s\n- http://logs.openstack.org/98/38698/2/gate/gate-python-openstackclient-python27/476 : SUCCESS in 1m 39s\n","accounts_in_message":[],"_revision_number":2},{"id":"e19e0a69ed64d5cc7c04017404bb5183b5c68ddc","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-29 23:26:42.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"3ff6378c23ab103647310d5d64b1e51bf3cdcf04","revisions":{"79cb35212cef015198ebc53c624ddc54654d8caa":{"kind":"REWORK","_number":1,"created":"2013-07-25 20:40:32.000000000","uploader":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"ref":"refs/changes/98/38698/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/98/38698/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/98/38698/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/98/38698/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/98/38698/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/98/38698/1"}}},"commit":{"parents":[{"commit":"e351991d74b9c952dc2d1f46a185a3250fa822d3","subject":"Merge \"Change volume manager to volume type, unset property for type\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/e351991d74b9c952dc2d1f46a185a3250fa822d3"}]}],"author":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2013-07-25 17:17:25.000000000","tz":-300},"committer":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2013-07-25 20:36:42.000000000","tz":-300},"subject":"Add server commands: (un)lock, (un)rescue, (un)set, add/remove volume","message":"Add server commands: (un)lock, (un)rescue, (un)set, add/remove volume\n\n* server lock/unlock, rescue/unrescue, set/unset\n* add/remove volume\n\nBlueprint: nova-client\n\nChange-Id: I3709ecdb297ab15ad44df09d89af840164271a66\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/79cb35212cef015198ebc53c624ddc54654d8caa"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/79cb35212cef015198ebc53c624ddc54654d8caa"}]},"branch":"refs/heads/master"},"3ff6378c23ab103647310d5d64b1e51bf3cdcf04":{"kind":"REWORK","_number":2,"created":"2013-07-29 23:21:39.000000000","uploader":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"ref":"refs/changes/98/38698/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/98/38698/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/98/38698/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/98/38698/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/98/38698/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/98/38698/2"}}},"commit":{"parents":[{"commit":"22386eb9e621012429e0626044c12b764d2ea273","subject":"Merge \"Add usage command for compute api\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/22386eb9e621012429e0626044c12b764d2ea273"}]}],"author":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2013-07-25 17:17:25.000000000","tz":-300},"committer":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2013-07-29 23:21:21.000000000","tz":-300},"subject":"Add server commands: (un)lock, (un)rescue, (un)set, add/remove volume","message":"Add server commands: (un)lock, (un)rescue, (un)set, add/remove volume\n\n* server lock/unlock, rescue/unrescue, set/unset\n* add/remove volume\n\nBlueprint: nova-client\n\nChange-Id: I3709ecdb297ab15ad44df09d89af840164271a66\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/3ff6378c23ab103647310d5d64b1e51bf3cdcf04"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/3ff6378c23ab103647310d5d64b1e51bf3cdcf04"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}