)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"3b555ef55a2786c4647d9fc79f504ccd136960a0","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The equivalent neutron commands implemented in OSC:"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"neutron: dhcp-agent-list-hosting-net"},{"line_number":15,"context_line":"OSC: network agent list --network"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"neutron: dhcp-agent-network-add"},{"line_number":18,"context_line":"OSC: network agent add network"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"neutron: dhcp-agent-network-remove"},{"line_number":21,"context_line":"OSC: network agent remove network"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"neutron: net-list-on-dhcp-agent"},{"line_number":24,"context_line":"OSC: network list --agent"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: I77a933f4b3ce875c63cef5b6a32aee78fd844b03"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":56,"id":"1a1ced50_011c1811","line":24,"range":{"start_line":14,"start_character":0,"end_line":24,"end_character":25},"updated":"2017-03-20 20:22:12.000000000","message":"If you are stating that its DHCP, please use the --dhcp flag here as mentioned in the RST file","commit_id":"f4fd8f6e31dcc177b56d1e618cdefef728d09157"}],"doc/source/command-objects/network-agent.rst":[{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"fa30c67994b612e3be09d4f7b2af4de53ff9c664","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":".. option:: --network \u003cnetwork\u003e"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    List DHCP agents hosted on network"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"network agent set"},{"line_number":45,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":20,"id":"3a71b18c_fee1589b","line":42,"updated":"2016-12-04 19:16:08.000000000","message":"List DHCP agents hosting a network.\n\nand make sure to reflect changes in network_agent description text\n\nPossibly add (name or ID)","commit_id":"53fe9e9b8f20e46e694645ab85718dcf4d4f22ed"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"63aa67f747f01b8660f38f2d0e17fd3ac782e35a","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":".. option:: --network \u003cnetwork\u003e"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    List DHCP agents hosted on network"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"network agent set"},{"line_number":45,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":20,"id":"3a71b18c_ee1d0763","line":42,"in_reply_to":"3a71b18c_fee1589b","updated":"2016-12-05 16:44:13.000000000","message":"Done","commit_id":"53fe9e9b8f20e46e694645ab85718dcf4d4f22ed"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"54edb7b2ceb292ae37969164c7a035cc9df6d16d","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    Network agent to display (ID only)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"network agent dhcp add network"},{"line_number":90,"context_line":"------------------------------"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Add network to DHCP agent."}],"source_content_type":"text/x-rst","patch_set":28,"id":"ba5201f7_afb983cd","line":89,"updated":"2017-01-03 22:01:21.000000000","message":"Why is \u0027dhcp\u0027 in the command here?  Are there multiple network agent types?\n\nAlso, these commands should be in alpha order in this file","commit_id":"3ab358e6eb97c40916fa3b13c2df6544692ca26d"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"10fb0f125a3ce715f2ebb8792d650c1cb30fa426","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    Network agent to display (ID only)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"network agent dhcp add network"},{"line_number":90,"context_line":"------------------------------"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Add network to DHCP agent."}],"source_content_type":"text/x-rst","patch_set":28,"id":"ba5201f7_132a3c90","line":89,"in_reply_to":"ba5201f7_afb983cd","updated":"2017-01-06 16:44:34.000000000","message":"Done sorted. Yes, there are multiple agent types. The other one I can remember is L3 Agent [1].\n\n[1] - https://review.openstack.org/#/c/385729/","commit_id":"3ab358e6eb97c40916fa3b13c2df6544692ca26d"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"e5dcbaac18ac4e28ee54f45f28c4e5fb0ac761a4","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    Network agent(s) to delete (ID only)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"network agent dhcp add network"},{"line_number":30,"context_line":"------------------------------"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Add network to DHCP agent."}],"source_content_type":"text/x-rst","patch_set":31,"id":"ba5201f7_8f02356e","line":29,"updated":"2017-01-09 21:45:02.000000000","message":"DHCP should not be in the resource name here.  Since this command specified a network agent ID, is it necessary to have the agent type in the command at all?","commit_id":"2e8f13e94ab4d34cf87d15142b4e777e948f080f"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"25c456da2a77317d9f1e7b1f8462388ad3eeeae3","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    Network agent(s) to delete (ID only)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"network agent dhcp add network"},{"line_number":30,"context_line":"------------------------------"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Add network to DHCP agent."}],"source_content_type":"text/x-rst","patch_set":31,"id":"ba5201f7_557d3ae6","line":29,"in_reply_to":"ba5201f7_8f02356e","updated":"2017-01-09 22:41:14.000000000","message":"Done","commit_id":"2e8f13e94ab4d34cf87d15142b4e777e948f080f"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"e5dcbaac18ac4e28ee54f45f28c4e5fb0ac761a4","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":".. option:: --network \u003cnetwork\u003e"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    List DHCP agents hosting a network"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"network agent set"},{"line_number":98,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":31,"id":"ba5201f7_af88d9c7","line":95,"updated":"2017-01-09 21:45:02.000000000","message":"Add (name or ID)","commit_id":"2e8f13e94ab4d34cf87d15142b4e777e948f080f"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"25c456da2a77317d9f1e7b1f8462388ad3eeeae3","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":".. option:: --network \u003cnetwork\u003e"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    List DHCP agents hosting a network"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"network agent set"},{"line_number":98,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":31,"id":"ba5201f7_75823eca","line":95,"in_reply_to":"ba5201f7_af88d9c7","updated":"2017-01-09 22:41:14.000000000","message":"Done","commit_id":"2e8f13e94ab4d34cf87d15142b4e777e948f080f"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"e5dcbaac18ac4e28ee54f45f28c4e5fb0ac761a4","unresolved":false,"context_lines":[{"line_number":138,"context_line":".. _network_agent_show-network-agent:"},{"line_number":139,"context_line":".. describe:: \u003cnetwork-agent\u003e"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    Network agent to display (ID only"}],"source_content_type":"text/x-rst","patch_set":31,"id":"ba5201f7_4f992d1f","line":141,"updated":"2017-01-09 21:45:02.000000000","message":"Why is this paren removed?","commit_id":"2e8f13e94ab4d34cf87d15142b4e777e948f080f"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"25c456da2a77317d9f1e7b1f8462388ad3eeeae3","unresolved":false,"context_lines":[{"line_number":138,"context_line":".. _network_agent_show-network-agent:"},{"line_number":139,"context_line":".. describe:: \u003cnetwork-agent\u003e"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    Network agent to display (ID only"}],"source_content_type":"text/x-rst","patch_set":31,"id":"ba5201f7_f5762e05","line":141,"in_reply_to":"ba5201f7_4f992d1f","updated":"2017-01-09 22:41:14.000000000","message":"Fixed.","commit_id":"2e8f13e94ab4d34cf87d15142b4e777e948f080f"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"12195810bf8f945cff953b36126dbd4cf923cd4a","unresolved":false,"context_lines":[{"line_number":29,"context_line":"network agent add network"},{"line_number":30,"context_line":"------------------------------"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Add network to DHCP agent."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":".. program:: network agent dhcp add to network"},{"line_number":35,"context_line":".. code:: bash"}],"source_content_type":"text/x-rst","patch_set":42,"id":"1a430d35_cab41df4","line":32,"range":{"start_line":32,"start_character":2,"end_line":32,"end_character":23},"updated":"2017-02-04 03:05:11.000000000","message":"This is not right, IMHO.\nWhat you are saying is adding a network to an agent.\nAn agent can be LBaaS, DHCP or L3 ( as written in Line#7 ).\nSo here, the agent can be ideally anything,not just a DHCP agent.\n\nI know I am late, and I dont have any other issues with it, but just pointing out where the confusion for the user can occur.","commit_id":"8aa97f394257ed38294bae45169358aaebb9488b"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"751ba76d91f52787af08238e650d861dcbc90bd0","unresolved":false,"context_lines":[{"line_number":29,"context_line":"network agent add network"},{"line_number":30,"context_line":"------------------------------"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Add network to DHCP agent."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":".. program:: network agent dhcp add to network"},{"line_number":35,"context_line":".. code:: bash"}],"source_content_type":"text/x-rst","patch_set":42,"id":"fa31d9ce_ac4f3d32","line":32,"in_reply_to":"1a430d35_73d202d4","updated":"2017-02-15 22:23:56.000000000","message":"You may need to add an option to specify which network agent type","commit_id":"8aa97f394257ed38294bae45169358aaebb9488b"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"df23ed6799b8c124c00f915cc86fec8a5053218c","unresolved":false,"context_lines":[{"line_number":29,"context_line":"network agent add network"},{"line_number":30,"context_line":"------------------------------"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Add network to DHCP agent."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":".. program:: network agent dhcp add to network"},{"line_number":35,"context_line":".. code:: bash"}],"source_content_type":"text/x-rst","patch_set":42,"id":"1a430d35_73d202d4","line":32,"range":{"start_line":32,"start_character":2,"end_line":32,"end_character":23},"in_reply_to":"1a430d35_cab41df4","updated":"2017-02-06 22:30:11.000000000","message":"Hmm. In the initial patch sets [1], we were told to drop the dhcp tag. The l3 is done something like \u0027network agent add router\u0027 [2]. Not sure about LBaaS considering new ones are to yet be done in Octavia. \n\n[1] - https://review.openstack.org/#/c/387611/30/doc/source/command-objects/network-agent.rst\n[2] - https://review.openstack.org/#/c/385729/18/doc/source/command-objects/network-agent.rst","commit_id":"8aa97f394257ed38294bae45169358aaebb9488b"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"06476330e9998b6413581bb38c2a19a8e547e7c9","unresolved":false,"context_lines":[{"line_number":29,"context_line":"network agent add network"},{"line_number":30,"context_line":"------------------------------"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Add network to DHCP agent."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":".. program:: network agent dhcp add to network"},{"line_number":35,"context_line":".. code:: bash"}],"source_content_type":"text/x-rst","patch_set":42,"id":"da36d5c6_ccd0dfcc","line":32,"in_reply_to":"fa31d9ce_ac4f3d32","updated":"2017-02-17 20:28:50.000000000","message":"Done.","commit_id":"8aa97f394257ed38294bae45169358aaebb9488b"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"bb20140bef4a7bac1ef065964248b5592365733b","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":".. describe:: \u003cnetwork-agent\u003e"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    Agent to query (ID)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":".. describe:: \u003cnetwork\u003e"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-rst","patch_set":43,"id":"da36d5c6_606d2632","line":44,"updated":"2017-02-19 17:50:52.000000000","message":"Agent to query doesn\u0027t sound right.","commit_id":"bd35f61cba907855d4c56603d77203807c52b147"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"2cc16fd24e60ce2a231f450f83b37ee8a16e9637","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":".. describe:: \u003cnetwork-agent\u003e"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    Agent to query (ID)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":".. describe:: \u003cnetwork\u003e"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-rst","patch_set":43,"id":"da36d5c6_254ce041","line":44,"in_reply_to":"da36d5c6_606d2632","updated":"2017-02-21 16:31:27.000000000","message":"Done. Changed.","commit_id":"bd35f61cba907855d4c56603d77203807c52b147"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"6fbe6d9a9b802fc8c8dd0f6ba7cdb7a23bfe8b08","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    Network to be added to an agent. (ID or name)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"network agent remove network"},{"line_number":51,"context_line":"---------------------------------"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Remove network from an agent."},{"line_number":54,"context_line":""}],"source_content_type":"text/x-rst","patch_set":44,"id":"da36d5c6_ed4c6144","line":51,"updated":"2017-02-22 14:50:07.000000000","message":"Sort these in the file by command name, also the RST header lines (line 51 here) should match the length of the header text.  This is normally not a -1 on its own but since this section needs to be moved, please fix these too.","commit_id":"54132a9926a6bf5d96f0e16b02f571f0ad005e6d"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"8d791590c955b83fc045e8a08f49d858353089de","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    Network to be added to an agent. (ID or name)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"network agent remove network"},{"line_number":51,"context_line":"---------------------------------"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Remove network from an agent."},{"line_number":54,"context_line":""}],"source_content_type":"text/x-rst","patch_set":44,"id":"da36d5c6_388cde34","line":51,"in_reply_to":"da36d5c6_ed4c6144","updated":"2017-02-22 17:02:30.000000000","message":"Done","commit_id":"54132a9926a6bf5d96f0e16b02f571f0ad005e6d"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"965fd0c61dd87c9d577c557e0a792e494e5d58f5","unresolved":false,"context_lines":[{"line_number":19,"context_line":".. code:: bash"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    openstack network agent add network"},{"line_number":22,"context_line":"        [--agent-type \u003cagent-type\u003e]"},{"line_number":23,"context_line":"        \u003cnetwork-agent\u003e"},{"line_number":24,"context_line":"        \u003cnetwork\u003e"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-rst","patch_set":45,"id":"da36d5c6_42eb5313","line":22,"range":{"start_line":22,"start_character":8,"end_line":22,"end_character":35},"updated":"2017-02-22 21:05:26.000000000","message":"This is not documented.\nIn this case we assume DHCP agent, so I am not sure --agent-type option makes sense or not.","commit_id":"3905486fea7ad0f30b89edcb7a817ebb80a89e5a"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"ee030e01533876e409e09fb50521796e5cf0317d","unresolved":false,"context_lines":[{"line_number":19,"context_line":".. code:: bash"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    openstack network agent add network"},{"line_number":22,"context_line":"        [--agent-type \u003cagent-type\u003e]"},{"line_number":23,"context_line":"        \u003cnetwork-agent\u003e"},{"line_number":24,"context_line":"        \u003cnetwork\u003e"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-rst","patch_set":45,"id":"da36d5c6_485a1252","line":22,"range":{"start_line":22,"start_character":8,"end_line":22,"end_character":35},"in_reply_to":"da36d5c6_42eb5313","updated":"2017-02-27 17:20:51.000000000","message":"We added this so that future agents can be added which are not only DHCP.","commit_id":"3905486fea7ad0f30b89edcb7a817ebb80a89e5a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"965fd0c61dd87c9d577c557e0a792e494e5d58f5","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":".. describe:: \u003cnetwork-agent\u003e"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    Agent to which a network is added. (ID)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":".. describe:: \u003cnetwork\u003e"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-rst","patch_set":45,"id":"da36d5c6_a29c0f5e","line":28,"updated":"2017-02-22 21:05:26.000000000","message":"An agent can be identified by the combination of (host and agent-type).\nIn this case, dhcp agent is assumed, so I think we can use \u0027host\u0027 to specify the agent. There is no need to do this in this patch though. It might be out of scope of this patch.","commit_id":"3905486fea7ad0f30b89edcb7a817ebb80a89e5a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"965fd0c61dd87c9d577c557e0a792e494e5d58f5","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":".. describe:: \u003cnetwork\u003e"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    Network to be added to an agent. (ID or name)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"network agent delete"},{"line_number":35,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":45,"id":"da36d5c6_62da174e","line":32,"range":{"start_line":32,"start_character":27,"end_line":32,"end_character":36},"updated":"2017-02-22 21:05:26.000000000","message":"I would like to say this \"DHCP agent\".","commit_id":"3905486fea7ad0f30b89edcb7a817ebb80a89e5a"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"ee030e01533876e409e09fb50521796e5cf0317d","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":".. describe:: \u003cnetwork\u003e"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    Network to be added to an agent. (ID or name)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"network agent delete"},{"line_number":35,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":45,"id":"da36d5c6_c8660229","line":32,"range":{"start_line":32,"start_character":27,"end_line":32,"end_character":36},"in_reply_to":"da36d5c6_62da174e","updated":"2017-02-27 17:20:51.000000000","message":"Done","commit_id":"3905486fea7ad0f30b89edcb7a817ebb80a89e5a"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"0358bab19395f5cf2ec58b6c8c5acd91d4c304cd","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    openstack network agent add network"},{"line_number":22,"context_line":"        [--dhcp]"},{"line_number":23,"context_line":"        \u003cnetwork-agent\u003e"},{"line_number":24,"context_line":"        \u003cnetwork\u003e"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":".. describe:: \u003cnetwork-agent\u003e"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-rst","patch_set":47,"id":"ba2be162_888f65cb","line":24,"updated":"2017-03-02 01:13:10.000000000","message":".. describe:: \n\nfor --dhcp option","commit_id":"b3ca454e512609b6d2e0689731a9df938580a146"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"f8bdeccae051a1273d2e8480a37a97d78a12035f","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    openstack network agent add network"},{"line_number":22,"context_line":"        [--dhcp]"},{"line_number":23,"context_line":"        \u003cnetwork-agent\u003e"},{"line_number":24,"context_line":"        \u003cnetwork\u003e"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":".. describe:: \u003cnetwork-agent\u003e"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-rst","patch_set":47,"id":"ba2be162_6f2a0c2e","line":24,"in_reply_to":"ba2be162_888f65cb","updated":"2017-03-02 15:54:35.000000000","message":"Done","commit_id":"b3ca454e512609b6d2e0689731a9df938580a146"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"0358bab19395f5cf2ec58b6c8c5acd91d4c304cd","unresolved":false,"context_lines":[{"line_number":23,"context_line":"        \u003cnetwork-agent\u003e"},{"line_number":24,"context_line":"        \u003cnetwork\u003e"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":".. describe:: \u003cnetwork-agent\u003e"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    Agent to which a network is added. (ID)"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":47,"id":"ba2be162_68ab111e","line":26,"updated":"2017-03-02 01:13:10.000000000","message":"if ID only then network-agent-id","commit_id":"b3ca454e512609b6d2e0689731a9df938580a146"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"0358bab19395f5cf2ec58b6c8c5acd91d4c304cd","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        [--dhcp]"},{"line_number":134,"context_line":"        \u003cnetwork-agent\u003e"},{"line_number":135,"context_line":"        \u003cnetwork\u003e"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":".. describe:: \u003cnetwork-agent\u003e"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    Agent to which a network is added. (ID)"}],"source_content_type":"text/x-rst","patch_set":47,"id":"ba2be162_4873ade7","line":136,"updated":"2017-03-02 01:13:10.000000000","message":"ditto for describe","commit_id":"b3ca454e512609b6d2e0689731a9df938580a146"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"f8bdeccae051a1273d2e8480a37a97d78a12035f","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        [--dhcp]"},{"line_number":134,"context_line":"        \u003cnetwork-agent\u003e"},{"line_number":135,"context_line":"        \u003cnetwork\u003e"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":".. describe:: \u003cnetwork-agent\u003e"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    Agent to which a network is added. (ID)"}],"source_content_type":"text/x-rst","patch_set":47,"id":"ba2be162_afe32404","line":136,"in_reply_to":"ba2be162_4873ade7","updated":"2017-03-02 15:54:35.000000000","message":"Done","commit_id":"b3ca454e512609b6d2e0689731a9df938580a146"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"0358bab19395f5cf2ec58b6c8c5acd91d4c304cd","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        \u003cnetwork\u003e"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":".. describe:: \u003cnetwork-agent\u003e"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    Agent to which a network is added. (ID)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":".. describe:: \u003cnetwork\u003e"}],"source_content_type":"text/x-rst","patch_set":47,"id":"ba2be162_68823196","line":138,"updated":"2017-03-02 01:13:10.000000000","message":"ditto for var name","commit_id":"b3ca454e512609b6d2e0689731a9df938580a146"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b5154390f44fd233b45266b67298b227122e17e3","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":".. describe:: --dhcp"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    Agent type is DHCP agent."},{"line_number":29,"context_line":" "},{"line_number":30,"context_line":".. describe:: \u003cagent-id\u003e"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-rst","patch_set":48,"id":"ba2be162_fe7bf725","line":28,"range":{"start_line":28,"start_character":4,"end_line":28,"end_character":29},"updated":"2017-03-03 00:52:36.000000000","message":"How about \"Add a network to DHCP agent\" ?\n\"Agent type is DHCP agent\" is a bit difficult to understand.","commit_id":"01b6ff3e53dfc81c2e4261eb21b94094d1cc826b"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"0d3aa6d50a7c3e379565f07da13e6c851f808426","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":".. describe:: --dhcp"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    Agent type is DHCP agent."},{"line_number":29,"context_line":" "},{"line_number":30,"context_line":".. describe:: \u003cagent-id\u003e"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-rst","patch_set":48,"id":"ba2be162_605bc4f6","line":28,"range":{"start_line":28,"start_character":4,"end_line":28,"end_character":29},"in_reply_to":"ba2be162_fe7bf725","updated":"2017-03-03 16:25:03.000000000","message":"Done","commit_id":"01b6ff3e53dfc81c2e4261eb21b94094d1cc826b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b5154390f44fd233b45266b67298b227122e17e3","unresolved":false,"context_lines":[{"line_number":26,"context_line":".. describe:: --dhcp"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    Agent type is DHCP agent."},{"line_number":29,"context_line":" "},{"line_number":30,"context_line":".. describe:: \u003cagent-id\u003e"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    Agent to which a network is added. (ID)"}],"source_content_type":"text/x-rst","patch_set":48,"id":"ba2be162_bef6dff6","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":1},"updated":"2017-03-03 00:52:36.000000000","message":"Unnecessary space","commit_id":"01b6ff3e53dfc81c2e4261eb21b94094d1cc826b"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"0d3aa6d50a7c3e379565f07da13e6c851f808426","unresolved":false,"context_lines":[{"line_number":26,"context_line":".. describe:: --dhcp"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    Agent type is DHCP agent."},{"line_number":29,"context_line":" "},{"line_number":30,"context_line":".. describe:: \u003cagent-id\u003e"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    Agent to which a network is added. (ID)"}],"source_content_type":"text/x-rst","patch_set":48,"id":"ba2be162_a0f85cc4","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":1},"in_reply_to":"ba2be162_bef6dff6","updated":"2017-03-03 16:25:03.000000000","message":"Removed.","commit_id":"01b6ff3e53dfc81c2e4261eb21b94094d1cc826b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b5154390f44fd233b45266b67298b227122e17e3","unresolved":false,"context_lines":[{"line_number":29,"context_line":" "},{"line_number":30,"context_line":".. describe:: \u003cagent-id\u003e"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    Agent to which a network is added. (ID)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":".. describe:: \u003cnetwork\u003e"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-rst","patch_set":48,"id":"ba2be162_7ed7074b","line":32,"range":{"start_line":32,"start_character":39,"end_line":32,"end_character":42},"updated":"2017-03-03 00:52:36.000000000","message":"According to the convention, it needs to be \"ID only\"","commit_id":"01b6ff3e53dfc81c2e4261eb21b94094d1cc826b"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"0d3aa6d50a7c3e379565f07da13e6c851f808426","unresolved":false,"context_lines":[{"line_number":29,"context_line":" "},{"line_number":30,"context_line":".. describe:: \u003cagent-id\u003e"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    Agent to which a network is added. (ID)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":".. describe:: \u003cnetwork\u003e"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-rst","patch_set":48,"id":"ba2be162_002e8842","line":32,"range":{"start_line":32,"start_character":39,"end_line":32,"end_character":42},"in_reply_to":"ba2be162_7ed7074b","updated":"2017-03-03 16:25:03.000000000","message":"Done","commit_id":"01b6ff3e53dfc81c2e4261eb21b94094d1cc826b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b5154390f44fd233b45266b67298b227122e17e3","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":".. describe:: \u003cagent-id\u003e"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    Agent to which a network is added. (ID)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":".. describe:: \u003cnetwork\u003e"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-rst","patch_set":48,"id":"ba2be162_9e3f5b86","line":147,"range":{"start_line":147,"start_character":40,"end_line":147,"end_character":42},"updated":"2017-03-03 00:52:36.000000000","message":"-\u003e ID only","commit_id":"01b6ff3e53dfc81c2e4261eb21b94094d1cc826b"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"0d3aa6d50a7c3e379565f07da13e6c851f808426","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":".. describe:: \u003cagent-id\u003e"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    Agent to which a network is added. (ID)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":".. describe:: \u003cnetwork\u003e"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-rst","patch_set":48,"id":"ba2be162_60290437","line":147,"range":{"start_line":147,"start_character":40,"end_line":147,"end_character":42},"in_reply_to":"ba2be162_9e3f5b86","updated":"2017-03-03 16:25:03.000000000","message":"Done","commit_id":"01b6ff3e53dfc81c2e4261eb21b94094d1cc826b"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"b38834bc7dc950669850d58f16a0915745d28241","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":".. describe:: \u003cnetwork\u003e"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    Network to be added to a DHCP agent. (ID or name)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"network agent delete"},{"line_number":39,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":53,"id":"9a30ddce_9232f05d","line":36,"updated":"2017-03-09 18:47:43.000000000","message":"Network to be added to an agent. (ID or name)","commit_id":"b4a2cab1e2f41620819f79fa67b04c7459ca4efd"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"939aedb636278e2b7cfe8c676b91890a41564e46","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":".. describe:: \u003cnetwork\u003e"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    Network to be added to a DHCP agent. (ID or name)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"network agent delete"},{"line_number":39,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":53,"id":"9a30ddce_b8b9937b","line":36,"in_reply_to":"9a30ddce_9232f05d","updated":"2017-03-09 19:38:25.000000000","message":"Done","commit_id":"b4a2cab1e2f41620819f79fa67b04c7459ca4efd"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"b38834bc7dc950669850d58f16a0915745d28241","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":".. describe:: \u003cnetwork\u003e"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"   Network to be removed from a DHCP agent. (ID or name)"}],"source_content_type":"text/x-rst","patch_set":53,"id":"9a30ddce_f2416caa","line":151,"updated":"2017-03-09 18:47:43.000000000","message":"Network to be removed from an agent. (ID or name)","commit_id":"b4a2cab1e2f41620819f79fa67b04c7459ca4efd"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"939aedb636278e2b7cfe8c676b91890a41564e46","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":".. describe:: \u003cnetwork\u003e"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"   Network to be removed from a DHCP agent. (ID or name)"}],"source_content_type":"text/x-rst","patch_set":53,"id":"9a30ddce_d8b2c793","line":151,"in_reply_to":"9a30ddce_f2416caa","updated":"2017-03-09 19:38:25.000000000","message":"Done","commit_id":"b4a2cab1e2f41620819f79fa67b04c7459ca4efd"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"3b555ef55a2786c4647d9fc79f504ccd136960a0","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":".. describe:: \u003cagent-id\u003e"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    Agent to which a network is removed. (ID only)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":".. describe:: \u003cnetwork\u003e"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-rst","patch_set":56,"id":"1a1ced50_01ca586d","line":147,"range":{"start_line":147,"start_character":38,"end_line":147,"end_character":40},"updated":"2017-03-20 20:22:12.000000000","message":"Full stop can be removed here ( nit )","commit_id":"f4fd8f6e31dcc177b56d1e618cdefef728d09157"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"3b555ef55a2786c4647d9fc79f504ccd136960a0","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":".. describe:: \u003cnetwork\u003e"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    Network to be removed from an agent. (ID or name)"}],"source_content_type":"text/x-rst","patch_set":56,"id":"1a1ced50_4190d043","line":151,"range":{"start_line":151,"start_character":39,"end_line":151,"end_character":40},"updated":"2017-03-20 20:22:12.000000000","message":"ditto","commit_id":"f4fd8f6e31dcc177b56d1e618cdefef728d09157"}],"doc/source/command-objects/network.rst":[{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"fa30c67994b612e3be09d4f7b2af4de53ff9c664","unresolved":false,"context_lines":[{"line_number":286,"context_line":""},{"line_number":287,"context_line":".. option:: --agent \u003cagent\u003e"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"    List networks hosted by DHCP agent"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"network set"},{"line_number":292,"context_line":"-----------"}],"source_content_type":"text/x-rst","patch_set":20,"id":"3a71b18c_1eeff487","line":289,"updated":"2016-12-04 19:16:08.000000000","message":"(ID only)","commit_id":"53fe9e9b8f20e46e694645ab85718dcf4d4f22ed"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"63aa67f747f01b8660f38f2d0e17fd3ac782e35a","unresolved":false,"context_lines":[{"line_number":286,"context_line":""},{"line_number":287,"context_line":".. option:: --agent \u003cagent\u003e"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"    List networks hosted by DHCP agent"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"network set"},{"line_number":292,"context_line":"-----------"}],"source_content_type":"text/x-rst","patch_set":20,"id":"3a71b18c_4e399bd6","line":289,"in_reply_to":"3a71b18c_1eeff487","updated":"2016-12-05 16:44:13.000000000","message":"Done","commit_id":"53fe9e9b8f20e46e694645ab85718dcf4d4f22ed"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"bb20140bef4a7bac1ef065964248b5592365733b","unresolved":false,"context_lines":[{"line_number":203,"context_line":"        [--provider-network-type \u003cprovider-network-type\u003e]"},{"line_number":204,"context_line":"        [--provider-physical-network \u003cprovider-physical-network\u003e]"},{"line_number":205,"context_line":"        [--provider-segment \u003cprovider-segment\u003e]"},{"line_number":206,"context_line":"        [--agent \u003cagent\u003e]"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":".. option:: --external"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-rst","patch_set":43,"id":"da36d5c6_e07836fb","line":206,"updated":"2017-02-19 17:50:52.000000000","message":"--agent \u003cagent-id\u003e","commit_id":"bd35f61cba907855d4c56603d77203807c52b147"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"2cc16fd24e60ce2a231f450f83b37ee8a16e9637","unresolved":false,"context_lines":[{"line_number":203,"context_line":"        [--provider-network-type \u003cprovider-network-type\u003e]"},{"line_number":204,"context_line":"        [--provider-physical-network \u003cprovider-physical-network\u003e]"},{"line_number":205,"context_line":"        [--provider-segment \u003cprovider-segment\u003e]"},{"line_number":206,"context_line":"        [--agent \u003cagent\u003e]"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":".. option:: --external"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-rst","patch_set":43,"id":"da36d5c6_6556d8d3","line":206,"in_reply_to":"da36d5c6_e07836fb","updated":"2017-02-21 16:31:27.000000000","message":"Done","commit_id":"bd35f61cba907855d4c56603d77203807c52b147"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"bb20140bef4a7bac1ef065964248b5592365733b","unresolved":false,"context_lines":[{"line_number":291,"context_line":""},{"line_number":292,"context_line":"    *Network version 2 only*"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":".. option:: --agent \u003cagent\u003e"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    List networks hosted by agent (ID only)"},{"line_number":297,"context_line":""}],"source_content_type":"text/x-rst","patch_set":43,"id":"da36d5c6_007e2ae4","line":294,"updated":"2017-02-19 17:50:52.000000000","message":"ditto","commit_id":"bd35f61cba907855d4c56603d77203807c52b147"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"2cc16fd24e60ce2a231f450f83b37ee8a16e9637","unresolved":false,"context_lines":[{"line_number":291,"context_line":""},{"line_number":292,"context_line":"    *Network version 2 only*"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":".. option:: --agent \u003cagent\u003e"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    List networks hosted by agent (ID only)"},{"line_number":297,"context_line":""}],"source_content_type":"text/x-rst","patch_set":43,"id":"da36d5c6_85510cdb","line":294,"in_reply_to":"da36d5c6_007e2ae4","updated":"2017-02-21 16:31:27.000000000","message":"Done","commit_id":"bd35f61cba907855d4c56603d77203807c52b147"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"0358bab19395f5cf2ec58b6c8c5acd91d4c304cd","unresolved":false,"context_lines":[{"line_number":203,"context_line":"        [--provider-network-type \u003cprovider-network-type\u003e]"},{"line_number":204,"context_line":"        [--provider-physical-network \u003cprovider-physical-network\u003e]"},{"line_number":205,"context_line":"        [--provider-segment \u003cprovider-segment\u003e]"},{"line_number":206,"context_line":"        [--agent \u003cagent-id\u003e]"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":".. option:: --external"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-rst","patch_set":47,"id":"ba2be162_c84ddd9a","line":206,"updated":"2017-03-02 01:13:10.000000000","message":"agent-id here is fine. but keep consistent. \n\nEither agent-id or network-agent-id across","commit_id":"b3ca454e512609b6d2e0689731a9df938580a146"}],"openstackclient/network/v2/network.py":[{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"fa30c67994b612e3be09d4f7b2af4de53ff9c664","unresolved":false,"context_lines":[{"line_number":512,"context_line":"                    formatters\u003d_formatters,"},{"line_number":513,"context_line":"                ) for s in data))"},{"line_number":514,"context_line":""},{"line_number":515,"context_line":"    def _get_subnets(self, client, data):"},{"line_number":516,"context_line":"        subnet_list \u003d []"},{"line_number":517,"context_line":"        for subnet in data.subnets:"},{"line_number":518,"context_line":"            cidr \u003d client.get_subnet(subnet).cidr"}],"source_content_type":"text/x-python","patch_set":20,"id":"3a71b18c_7ed548b7","line":515,"updated":"2016-12-04 19:16:08.000000000","message":"I would make this a public method (bring outside class). But it is also fine here.","commit_id":"53fe9e9b8f20e46e694645ab85718dcf4d4f22ed"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"751ba76d91f52787af08238e650d861dcbc90bd0","unresolved":false,"context_lines":[{"line_number":423,"context_line":"            help\u003d_(\"List networks according to VLAN ID for VLAN networks \""},{"line_number":424,"context_line":"                   \"or Tunnel ID for GENEVE/GRE/VXLAN networks\")"},{"line_number":425,"context_line":"        )"},{"line_number":426,"context_line":"        # TODO(sshank): Command fails for -h used with and without --agent."},{"line_number":427,"context_line":"        parser.add_argument("},{"line_number":428,"context_line":"            \u0027--agent\u0027,"},{"line_number":429,"context_line":"            metavar\u003d\u0027\u003cagent\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":42,"id":"fa31d9ce_0c0e89e4","line":426,"updated":"2017-02-15 22:23:56.000000000","message":"Is this still true?  IIRC we fixed that, it was a general -h issue for network commands","commit_id":"8aa97f394257ed38294bae45169358aaebb9488b"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"06476330e9998b6413581bb38c2a19a8e547e7c9","unresolved":false,"context_lines":[{"line_number":423,"context_line":"            help\u003d_(\"List networks according to VLAN ID for VLAN networks \""},{"line_number":424,"context_line":"                   \"or Tunnel ID for GENEVE/GRE/VXLAN networks\")"},{"line_number":425,"context_line":"        )"},{"line_number":426,"context_line":"        # TODO(sshank): Command fails for -h used with and without --agent."},{"line_number":427,"context_line":"        parser.add_argument("},{"line_number":428,"context_line":"            \u0027--agent\u0027,"},{"line_number":429,"context_line":"            metavar\u003d\u0027\u003cagent\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":42,"id":"da36d5c6_0cdbd7ee","line":426,"in_reply_to":"fa31d9ce_0c0e89e4","updated":"2017-02-17 20:28:50.000000000","message":"Done. Removed it.","commit_id":"8aa97f394257ed38294bae45169358aaebb9488b"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"bb20140bef4a7bac1ef065964248b5592365733b","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"_formatters \u003d {"},{"line_number":38,"context_line":"    \u0027alive\u0027: _format_alive,"},{"line_number":39,"context_line":"    \u0027subnets\u0027: utils.format_list,"},{"line_number":40,"context_line":"    \u0027subnet_ids\u0027: utils.format_list,"},{"line_number":41,"context_line":"    \u0027admin_state_up\u0027: _format_admin_state,"}],"source_content_type":"text/x-python","patch_set":43,"id":"da36d5c6_c01df2be","line":38,"updated":"2017-02-19 17:50:52.000000000","message":"no need for alive and _format_alive","commit_id":"bd35f61cba907855d4c56603d77203807c52b147"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"2cc16fd24e60ce2a231f450f83b37ee8a16e9637","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"_formatters \u003d {"},{"line_number":38,"context_line":"    \u0027alive\u0027: _format_alive,"},{"line_number":39,"context_line":"    \u0027subnets\u0027: utils.format_list,"},{"line_number":40,"context_line":"    \u0027subnet_ids\u0027: utils.format_list,"},{"line_number":41,"context_line":"    \u0027admin_state_up\u0027: _format_admin_state,"}],"source_content_type":"text/x-python","patch_set":43,"id":"da36d5c6_c56144aa","line":38,"in_reply_to":"da36d5c6_c01df2be","updated":"2017-02-21 16:31:27.000000000","message":"Done","commit_id":"bd35f61cba907855d4c56603d77203807c52b147"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"6fbe6d9a9b802fc8c8dd0f6ba7cdb7a23bfe8b08","unresolved":false,"context_lines":[{"line_number":420,"context_line":"        )"},{"line_number":421,"context_line":"        parser.add_argument("},{"line_number":422,"context_line":"            \u0027--agent\u0027,"},{"line_number":423,"context_line":"            metavar\u003d\u0027\u003cagent\u003e\u0027,"},{"line_number":424,"context_line":"            help\u003d_(\u0027List agents hosted by network.\u0027))"},{"line_number":425,"context_line":"        return parser"},{"line_number":426,"context_line":""}],"source_content_type":"text/x-python","patch_set":44,"id":"da36d5c6_ad10a902","line":423,"updated":"2017-02-22 14:50:07.000000000","message":"This should match the RST doc so the help text is the same.","commit_id":"54132a9926a6bf5d96f0e16b02f571f0ad005e6d"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"8d791590c955b83fc045e8a08f49d858353089de","unresolved":false,"context_lines":[{"line_number":420,"context_line":"        )"},{"line_number":421,"context_line":"        parser.add_argument("},{"line_number":422,"context_line":"            \u0027--agent\u0027,"},{"line_number":423,"context_line":"            metavar\u003d\u0027\u003cagent\u003e\u0027,"},{"line_number":424,"context_line":"            help\u003d_(\u0027List agents hosted by network.\u0027))"},{"line_number":425,"context_line":"        return parser"},{"line_number":426,"context_line":""}],"source_content_type":"text/x-python","patch_set":44,"id":"da36d5c6_1890fa42","line":423,"in_reply_to":"da36d5c6_ad10a902","updated":"2017-02-22 17:02:30.000000000","message":"Done","commit_id":"54132a9926a6bf5d96f0e16b02f571f0ad005e6d"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"6fbe6d9a9b802fc8c8dd0f6ba7cdb7a23bfe8b08","unresolved":false,"context_lines":[{"line_number":421,"context_line":"        parser.add_argument("},{"line_number":422,"context_line":"            \u0027--agent\u0027,"},{"line_number":423,"context_line":"            metavar\u003d\u0027\u003cagent\u003e\u0027,"},{"line_number":424,"context_line":"            help\u003d_(\u0027List agents hosted by network.\u0027))"},{"line_number":425,"context_line":"        return parser"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"    def take_action_network(self, client, parsed_args):"}],"source_content_type":"text/x-python","patch_set":44,"id":"da36d5c6_ed73817e","line":424,"updated":"2017-02-22 14:50:07.000000000","message":"The help text should match the first line in the RST doc, which says this is ID only.","commit_id":"54132a9926a6bf5d96f0e16b02f571f0ad005e6d"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b5154390f44fd233b45266b67298b227122e17e3","unresolved":false,"context_lines":[{"line_number":420,"context_line":"        )"},{"line_number":421,"context_line":"        parser.add_argument("},{"line_number":422,"context_line":"            \u0027--agent\u0027,"},{"line_number":423,"context_line":"            metavar\u003d\u0027\u003cagent\u003e\u0027,"},{"line_number":424,"context_line":"            help\u003d_(\u0027List networks hosted by agent (ID only)\u0027))"},{"line_number":425,"context_line":"        return parser"},{"line_number":426,"context_line":""}],"source_content_type":"text/x-python","patch_set":48,"id":"ba2be162_7e6547b3","line":423,"range":{"start_line":423,"start_character":22,"end_line":423,"end_character":27},"updated":"2017-03-03 00:52:36.000000000","message":"\u003cagent-id\u003e looks better.","commit_id":"01b6ff3e53dfc81c2e4261eb21b94094d1cc826b"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"0d3aa6d50a7c3e379565f07da13e6c851f808426","unresolved":false,"context_lines":[{"line_number":420,"context_line":"        )"},{"line_number":421,"context_line":"        parser.add_argument("},{"line_number":422,"context_line":"            \u0027--agent\u0027,"},{"line_number":423,"context_line":"            metavar\u003d\u0027\u003cagent\u003e\u0027,"},{"line_number":424,"context_line":"            help\u003d_(\u0027List networks hosted by agent (ID only)\u0027))"},{"line_number":425,"context_line":"        return parser"},{"line_number":426,"context_line":""}],"source_content_type":"text/x-python","patch_set":48,"id":"ba2be162_00f04866","line":423,"range":{"start_line":423,"start_character":22,"end_line":423,"end_character":27},"in_reply_to":"ba2be162_7e6547b3","updated":"2017-03-03 16:25:03.000000000","message":"agent-id causes issues in line 454 since Python thinks its agent - id variable.","commit_id":"01b6ff3e53dfc81c2e4261eb21b94094d1cc826b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c255295916b174bee8dd43f6c7e3d8d47c37d1b0","unresolved":false,"context_lines":[{"line_number":420,"context_line":"        )"},{"line_number":421,"context_line":"        parser.add_argument("},{"line_number":422,"context_line":"            \u0027--agent\u0027,"},{"line_number":423,"context_line":"            metavar\u003d\u0027\u003cagent\u003e\u0027,"},{"line_number":424,"context_line":"            help\u003d_(\u0027List networks hosted by agent (ID only)\u0027))"},{"line_number":425,"context_line":"        return parser"},{"line_number":426,"context_line":""}],"source_content_type":"text/x-python","patch_set":52,"id":"ba2be162_430863da","line":423,"range":{"start_line":423,"start_character":22,"end_line":423,"end_character":27},"updated":"2017-03-05 16:58:42.000000000","message":"-\u003e \u003cagent-id\u003e","commit_id":"7c69681e7a433c7b149dbdb71377c0e9572db39a"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"c0b0d327b937881a9e7f5500d2e6140251dac6b7","unresolved":false,"context_lines":[{"line_number":420,"context_line":"        )"},{"line_number":421,"context_line":"        parser.add_argument("},{"line_number":422,"context_line":"            \u0027--agent\u0027,"},{"line_number":423,"context_line":"            metavar\u003d\u0027\u003cagent\u003e\u0027,"},{"line_number":424,"context_line":"            help\u003d_(\u0027List networks hosted by agent (ID only)\u0027))"},{"line_number":425,"context_line":"        return parser"},{"line_number":426,"context_line":""}],"source_content_type":"text/x-python","patch_set":52,"id":"ba2be162_e38be91c","line":423,"range":{"start_line":423,"start_character":22,"end_line":423,"end_character":27},"in_reply_to":"ba2be162_430863da","updated":"2017-03-06 20:22:06.000000000","message":"Done","commit_id":"7c69681e7a433c7b149dbdb71377c0e9572db39a"}],"openstackclient/network/v2/network_agent.py":[{"author":{"_account_id":19644,"name":"Yan Xing\u0027an","email":"yanxingan@cmss.chinamobile.com","username":"yanxingan"},"change_message_id":"17765f827cc9e5bb8181e65b559777dd53558daa","unresolved":false,"context_lines":[{"line_number":170,"context_line":""},{"line_number":171,"context_line":"class ListDHCPAgentHostingNetworks(command.Lister):"},{"line_number":172,"context_line":"    \"\"\"List networks hosted by DHCP agent\"\"\""},{"line_number":173,"context_line":""},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    def get_parser(self, prog_name):"},{"line_number":176,"context_line":"        parser \u003d super(ListDHCPAgentHostingNetworks, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_36e7dbe5","line":173,"range":{"start_line":173,"start_character":0,"end_line":173,"end_character":0},"updated":"2016-10-27 09:52:50.000000000","message":"too many blank lines","commit_id":"57ba6cefd2a2742ce65a28878874fa4dd4b041e5"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"fa30c67994b612e3be09d4f7b2af4de53ff9c664","unresolved":false,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"class AddDHCPAgentToNetwork(command.Command):"},{"line_number":206,"context_line":"    \"\"\"Add DHCP agent to a network\"\"\""},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    def get_parser(self, prog_name):"},{"line_number":209,"context_line":"        parser \u003d super(AddDHCPAgentToNetwork, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":20,"id":"3a71b18c_3ecbd01f","line":206,"updated":"2016-12-04 19:16:08.000000000","message":"Do a rebase. \n\nDocstrings have been replaced with:\n\n_description \u003d _(\"\u003cdocstring\u003e\")","commit_id":"53fe9e9b8f20e46e694645ab85718dcf4d4f22ed"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"63aa67f747f01b8660f38f2d0e17fd3ac782e35a","unresolved":false,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"class AddDHCPAgentToNetwork(command.Command):"},{"line_number":206,"context_line":"    \"\"\"Add DHCP agent to a network\"\"\""},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    def get_parser(self, prog_name):"},{"line_number":209,"context_line":"        parser \u003d super(AddDHCPAgentToNetwork, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":20,"id":"3a71b18c_ee5427ff","line":206,"in_reply_to":"3a71b18c_3ecbd01f","updated":"2016-12-05 16:44:13.000000000","message":"Done","commit_id":"53fe9e9b8f20e46e694645ab85718dcf4d4f22ed"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"a5f9d847941ba5dcc00c5964d70f5349f49d88b0","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        parser.add_argument("},{"line_number":82,"context_line":"            \u0027--network\u0027,"},{"line_number":83,"context_line":"            metavar\u003d\u0027\u003cnetwork\u003e\u0027,"},{"line_number":84,"context_line":"            help\u003d_(\u0027List L3 agents network (name or ID)\u0027)"},{"line_number":85,"context_line":"        )"},{"line_number":86,"context_line":"        return parser"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"3a71b18c_0eb7a3f5","line":84,"updated":"2016-12-05 16:51:52.000000000","message":"List DHCP agents hosting a network (name or ID)","commit_id":"4acf44d6394ec603b6c220b7ef0fb060e035832b"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"c90fa08e22efbaca2e2427f4c3d5416ef6bd87bd","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        parser.add_argument("},{"line_number":82,"context_line":"            \u0027--network\u0027,"},{"line_number":83,"context_line":"            metavar\u003d\u0027\u003cnetwork\u003e\u0027,"},{"line_number":84,"context_line":"            help\u003d_(\u0027List L3 agents network (name or ID)\u0027)"},{"line_number":85,"context_line":"        )"},{"line_number":86,"context_line":"        return parser"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"3a71b18c_fc6bfdb6","line":84,"in_reply_to":"3a71b18c_0eb7a3f5","updated":"2016-12-05 17:21:51.000000000","message":"Thanks. That remained when I was using the L3 stuff.","commit_id":"4acf44d6394ec603b6c220b7ef0fb060e035832b"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"54edb7b2ceb292ae37969164c7a035cc9df6d16d","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        parser.add_argument("},{"line_number":82,"context_line":"            \u0027--network\u0027,"},{"line_number":83,"context_line":"            metavar\u003d\u0027\u003cnetwork\u003e\u0027,"},{"line_number":84,"context_line":"            help\u003d_(\u0027List DHCP agents hosting a network (name or ID)\u0027)"},{"line_number":85,"context_line":"        )"},{"line_number":86,"context_line":"        return parser"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"ba5201f7_ef470b75","line":84,"updated":"2017-01-03 22:01:21.000000000","message":"Maybe I am confused, but it does not seem like this matches what is being done below.  Here you state that agents will be listed, but list_networks_on_agent() appears to be listing networks.\n\nIn general, any given list command only lists its own resource type, ie a network agent list command should only be listing network agents, not networks.","commit_id":"3ab358e6eb97c40916fa3b13c2df6544692ca26d"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"10fb0f125a3ce715f2ebb8792d650c1cb30fa426","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        parser.add_argument("},{"line_number":82,"context_line":"            \u0027--network\u0027,"},{"line_number":83,"context_line":"            metavar\u003d\u0027\u003cnetwork\u003e\u0027,"},{"line_number":84,"context_line":"            help\u003d_(\u0027List DHCP agents hosting a network (name or ID)\u0027)"},{"line_number":85,"context_line":"        )"},{"line_number":86,"context_line":"        return parser"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"ba5201f7_3e054710","line":84,"in_reply_to":"ba5201f7_ef470b75","updated":"2017-01-06 16:44:34.000000000","message":"Fixed the name of the method. It is in fact returning a list of agents.","commit_id":"3ab358e6eb97c40916fa3b13c2df6544692ca26d"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"54edb7b2ceb292ae37969164c7a035cc9df6d16d","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        return columns, data"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"class AddDHCPAgentToNetwork(command.Command):"},{"line_number":206,"context_line":"    _description \u003d _(\"Add DHCP agent to a network\")"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    def get_parser(self, prog_name):"}],"source_content_type":"text/x-python","patch_set":28,"id":"ba5201f7_cfd167cf","line":205,"updated":"2017-01-03 22:01:21.000000000","message":"Sort these classes in the file","commit_id":"3ab358e6eb97c40916fa3b13c2df6544692ca26d"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"10fb0f125a3ce715f2ebb8792d650c1cb30fa426","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        return columns, data"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"class AddDHCPAgentToNetwork(command.Command):"},{"line_number":206,"context_line":"    _description \u003d _(\"Add DHCP agent to a network\")"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    def get_parser(self, prog_name):"}],"source_content_type":"text/x-python","patch_set":28,"id":"ba5201f7_5e1f6b5a","line":205,"in_reply_to":"ba5201f7_cfd167cf","updated":"2017-01-06 16:44:34.000000000","message":"Done","commit_id":"3ab358e6eb97c40916fa3b13c2df6544692ca26d"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"e5dcbaac18ac4e28ee54f45f28c4e5fb0ac761a4","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        parser.add_argument("},{"line_number":127,"context_line":"            \u0027--network\u0027,"},{"line_number":128,"context_line":"            metavar\u003d\u0027\u003cnetwork\u003e\u0027,"},{"line_number":129,"context_line":"            help\u003d_(\u0027List DHCP agents hosting a network.\u0027)"},{"line_number":130,"context_line":"        )"},{"line_number":131,"context_line":"        return parser"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"ba5201f7_effbc145","line":129,"updated":"2017-01-09 21:45:02.000000000","message":"This needs (name or ID) at the end:\n\nhelp\u003d_(\u0027List DHCP agents hosting a network (name or ID)\u0027)","commit_id":"2e8f13e94ab4d34cf87d15142b4e777e948f080f"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"25c456da2a77317d9f1e7b1f8462388ad3eeeae3","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        parser.add_argument("},{"line_number":127,"context_line":"            \u0027--network\u0027,"},{"line_number":128,"context_line":"            metavar\u003d\u0027\u003cnetwork\u003e\u0027,"},{"line_number":129,"context_line":"            help\u003d_(\u0027List DHCP agents hosting a network.\u0027)"},{"line_number":130,"context_line":"        )"},{"line_number":131,"context_line":"        return parser"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"ba5201f7_355fd676","line":129,"in_reply_to":"ba5201f7_effbc145","updated":"2017-01-09 22:41:14.000000000","message":"Done","commit_id":"2e8f13e94ab4d34cf87d15142b4e777e948f080f"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"e5dcbaac18ac4e28ee54f45f28c4e5fb0ac761a4","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        )"},{"line_number":131,"context_line":"        return parser"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def _list_dhcp_agents_on_network(self, client, parsed_args):"},{"line_number":134,"context_line":"        columns \u003d ("},{"line_number":135,"context_line":"            \u0027id\u0027,"},{"line_number":136,"context_line":"            \u0027host\u0027,"}],"source_content_type":"text/x-python","patch_set":31,"id":"ba5201f7_8fecf590","line":133,"updated":"2017-01-09 21:45:02.000000000","message":"First of all, I don\u0027t see the reason to pull this out of take_action().\n\nAlso, the output is vastly different, it does not look like a network agent listing.  Adding a filter option to a command should not change the output format so drastically.","commit_id":"2e8f13e94ab4d34cf87d15142b4e777e948f080f"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"25c456da2a77317d9f1e7b1f8462388ad3eeeae3","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        )"},{"line_number":131,"context_line":"        return parser"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def _list_dhcp_agents_on_network(self, client, parsed_args):"},{"line_number":134,"context_line":"        columns \u003d ("},{"line_number":135,"context_line":"            \u0027id\u0027,"},{"line_number":136,"context_line":"            \u0027host\u0027,"}],"source_content_type":"text/x-python","patch_set":31,"id":"ba5201f7_55cb7a1e","line":133,"in_reply_to":"ba5201f7_8fecf590","updated":"2017-01-09 22:41:14.000000000","message":"Done. Moved inside take_action. However, querying is not supported yet in the SDK [1].\n\n[1] - https://github.com/openstack/python-openstacksdk/blob/master/openstack/network/v2/agent.py#L93","commit_id":"2e8f13e94ab4d34cf87d15142b4e777e948f080f"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"751ba76d91f52787af08238e650d861dcbc90bd0","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"class AddDHCPAgentToNetwork(command.Command):"},{"line_number":48,"context_line":"    _description \u003d _(\"Add DHCP agent to a network\")"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def get_parser(self, prog_name):"},{"line_number":51,"context_line":"        parser \u003d super(AddDHCPAgentToNetwork, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":42,"id":"fa31d9ce_ccbc71de","line":48,"updated":"2017-02-15 22:23:56.000000000","message":"This is phrased backwards, the command adds a network to a DHCP agent.\n\nRemove \u0027DHCP\u0027 from the class names also if there will be other agent types in the future","commit_id":"8aa97f394257ed38294bae45169358aaebb9488b"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"06476330e9998b6413581bb38c2a19a8e547e7c9","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"class AddDHCPAgentToNetwork(command.Command):"},{"line_number":48,"context_line":"    _description \u003d _(\"Add DHCP agent to a network\")"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def get_parser(self, prog_name):"},{"line_number":51,"context_line":"        parser \u003d super(AddDHCPAgentToNetwork, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":42,"id":"da36d5c6_6ce293a1","line":48,"in_reply_to":"fa31d9ce_ccbc71de","updated":"2017-02-17 20:28:50.000000000","message":"Done","commit_id":"8aa97f394257ed38294bae45169358aaebb9488b"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"bb20140bef4a7bac1ef065964248b5592365733b","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def take_action(self, parsed_args):"},{"line_number":67,"context_line":"        client \u003d self.app.client_manager.network"},{"line_number":68,"context_line":"        if parsed_args.agent_type \u003d\u003d \u0027dhcp\u0027:"},{"line_number":69,"context_line":"            dhcp_agent \u003d client.get_agent(parsed_args.agent)"},{"line_number":70,"context_line":"            network \u003d client.find_network("},{"line_number":71,"context_line":"                parsed_args.network, ignore_missing\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":43,"id":"da36d5c6_200c0e94","line":68,"updated":"2017-02-19 17:50:52.000000000","message":"this won\u0027t work if you allow (name or ID) for --agent-type\n\nRun the dhcp_agent \u003d client.get_agent line before the if statement. then confirm dhcp_agent.name \u003d \u0027dhcp\u0027 or something along those line. \n\nSame goes for RemoveNetworkFromAgent","commit_id":"bd35f61cba907855d4c56603d77203807c52b147"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"2cc16fd24e60ce2a231f450f83b37ee8a16e9637","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def take_action(self, parsed_args):"},{"line_number":67,"context_line":"        client \u003d self.app.client_manager.network"},{"line_number":68,"context_line":"        if parsed_args.agent_type \u003d\u003d \u0027dhcp\u0027:"},{"line_number":69,"context_line":"            dhcp_agent \u003d client.get_agent(parsed_args.agent)"},{"line_number":70,"context_line":"            network \u003d client.find_network("},{"line_number":71,"context_line":"                parsed_args.network, ignore_missing\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":43,"id":"da36d5c6_25fa20be","line":68,"in_reply_to":"da36d5c6_200c0e94","updated":"2017-02-21 16:31:27.000000000","message":"Done changed. Now it makes sure user passes the correct choice. This is similar to the agent-type found in listing.","commit_id":"bd35f61cba907855d4c56603d77203807c52b147"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"bb20140bef4a7bac1ef065964248b5592365733b","unresolved":false,"context_lines":[{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    def take_action(self, parsed_args):"},{"line_number":233,"context_line":"        client \u003d self.app.client_manager.network"},{"line_number":234,"context_line":"        if parsed_args.agent_type \u003d\u003d \u0027dhcp\u0027:"},{"line_number":235,"context_line":"            dhcp_agent \u003d client.get_agent(parsed_args.agent)"},{"line_number":236,"context_line":"            network \u003d client.find_network("},{"line_number":237,"context_line":"                parsed_args.network, ignore_missing\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":43,"id":"da36d5c6_8023fa04","line":234,"updated":"2017-02-19 17:50:52.000000000","message":"ditto","commit_id":"bd35f61cba907855d4c56603d77203807c52b147"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"965fd0c61dd87c9d577c557e0a792e494e5d58f5","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        parser.add_argument("},{"line_number":53,"context_line":"            \u0027--agent-type\u0027,"},{"line_number":54,"context_line":"            metavar\u003d\u0027\u003cagent_type\u003e\u0027,"},{"line_number":55,"context_line":"            choices\u003d[\"dhcp\", \"l3\"],"},{"line_number":56,"context_line":"            help\u003d_(\u0027Add only agents with the specified agent type. \u0027"},{"line_number":57,"context_line":"                   \u0027The supported agent types are: dhcp, l3\u0027))"},{"line_number":58,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":45,"id":"da36d5c6_82fc6b73","line":55,"range":{"start_line":55,"start_character":29,"end_line":55,"end_character":34},"updated":"2017-02-22 21:05:26.000000000","message":"What does this mean? L3 agent cannot host a network. Am I missing something?\n\nThe logic below only supports dhcp agent, so I don\u0027t think \u0027l3\u0027 does not make sense now.","commit_id":"3905486fea7ad0f30b89edcb7a817ebb80a89e5a"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"ee030e01533876e409e09fb50521796e5cf0317d","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        parser.add_argument("},{"line_number":53,"context_line":"            \u0027--agent-type\u0027,"},{"line_number":54,"context_line":"            metavar\u003d\u0027\u003cagent_type\u003e\u0027,"},{"line_number":55,"context_line":"            choices\u003d[\"dhcp\", \"l3\"],"},{"line_number":56,"context_line":"            help\u003d_(\u0027Add only agents with the specified agent type. \u0027"},{"line_number":57,"context_line":"                   \u0027The supported agent types are: dhcp, l3\u0027))"},{"line_number":58,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":45,"id":"da36d5c6_c83442fd","line":55,"range":{"start_line":55,"start_character":29,"end_line":55,"end_character":34},"in_reply_to":"da36d5c6_82fc6b73","updated":"2017-02-27 17:20:51.000000000","message":"Done. Makes sense to remove l3.","commit_id":"3905486fea7ad0f30b89edcb7a817ebb80a89e5a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"965fd0c61dd87c9d577c557e0a792e494e5d58f5","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        parser.add_argument("},{"line_number":59,"context_line":"            \u0027agent\u0027,"},{"line_number":60,"context_line":"            metavar\u003d\u0027\u003cagent\u003e\u0027,"},{"line_number":61,"context_line":"            help\u003d_(\u0027Agent (name or ID)\u0027))"},{"line_number":62,"context_line":"        parser.add_argument("},{"line_number":63,"context_line":"            \u0027network\u0027,"},{"line_number":64,"context_line":"            metavar\u003d\u0027\u003cnetwork\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":45,"id":"da36d5c6_a20faf86","line":61,"range":{"start_line":61,"start_character":27,"end_line":61,"end_character":35},"updated":"2017-02-22 21:05:26.000000000","message":"agent does not have \u0027name\u0027.","commit_id":"3905486fea7ad0f30b89edcb7a817ebb80a89e5a"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"ee030e01533876e409e09fb50521796e5cf0317d","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        parser.add_argument("},{"line_number":59,"context_line":"            \u0027agent\u0027,"},{"line_number":60,"context_line":"            metavar\u003d\u0027\u003cagent\u003e\u0027,"},{"line_number":61,"context_line":"            help\u003d_(\u0027Agent (name or ID)\u0027))"},{"line_number":62,"context_line":"        parser.add_argument("},{"line_number":63,"context_line":"            \u0027network\u0027,"},{"line_number":64,"context_line":"            metavar\u003d\u0027\u003cnetwork\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":45,"id":"da36d5c6_682ef6a6","line":61,"range":{"start_line":61,"start_character":27,"end_line":61,"end_character":35},"in_reply_to":"da36d5c6_a20faf86","updated":"2017-02-27 17:20:51.000000000","message":"Done","commit_id":"3905486fea7ad0f30b89edcb7a817ebb80a89e5a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"965fd0c61dd87c9d577c557e0a792e494e5d58f5","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def take_action(self, parsed_args):"},{"line_number":70,"context_line":"        client \u003d self.app.client_manager.network"},{"line_number":71,"context_line":"        if parsed_args.agent_type \u003d\u003d \u0027dhcp\u0027:"},{"line_number":72,"context_line":"            dhcp_agent \u003d client.get_agent(parsed_args.agent)"},{"line_number":73,"context_line":"            network \u003d client.find_network("},{"line_number":74,"context_line":"                parsed_args.network, ignore_missing\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":45,"id":"da36d5c6_e5ae11e5","line":71,"range":{"start_line":71,"start_character":8,"end_line":71,"end_character":44},"updated":"2017-02-22 21:05:26.000000000","message":"Why do we allow \u0027l3\u0027 as a choice of agent-type?\nIf not, this will be unnecessary.","commit_id":"3905486fea7ad0f30b89edcb7a817ebb80a89e5a"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"ee030e01533876e409e09fb50521796e5cf0317d","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def take_action(self, parsed_args):"},{"line_number":70,"context_line":"        client \u003d self.app.client_manager.network"},{"line_number":71,"context_line":"        if parsed_args.agent_type \u003d\u003d \u0027dhcp\u0027:"},{"line_number":72,"context_line":"            dhcp_agent \u003d client.get_agent(parsed_args.agent)"},{"line_number":73,"context_line":"            network \u003d client.find_network("},{"line_number":74,"context_line":"                parsed_args.network, ignore_missing\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":45,"id":"da36d5c6_c81b627f","line":71,"range":{"start_line":71,"start_character":8,"end_line":71,"end_character":44},"in_reply_to":"da36d5c6_e5ae11e5","updated":"2017-02-27 17:20:51.000000000","message":"Done","commit_id":"3905486fea7ad0f30b89edcb7a817ebb80a89e5a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"965fd0c61dd87c9d577c557e0a792e494e5d58f5","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        parser.add_argument("},{"line_number":222,"context_line":"            \u0027--agent-type\u0027,"},{"line_number":223,"context_line":"            metavar\u003d\u0027\u003cagent_type\u003e\u0027,"},{"line_number":224,"context_line":"            choices\u003d[\"dhcp\", \"l3\"],"},{"line_number":225,"context_line":"            help\u003d_(\u0027Add only agents with the specified agent type. \u0027"},{"line_number":226,"context_line":"                   \u0027The supported agent types are: dhcp, l3\u0027))"},{"line_number":227,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":45,"id":"da36d5c6_058fa575","line":224,"range":{"start_line":224,"start_character":29,"end_line":224,"end_character":34},"updated":"2017-02-22 21:05:26.000000000","message":"As commented above","commit_id":"3905486fea7ad0f30b89edcb7a817ebb80a89e5a"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"ee030e01533876e409e09fb50521796e5cf0317d","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        parser.add_argument("},{"line_number":222,"context_line":"            \u0027--agent-type\u0027,"},{"line_number":223,"context_line":"            metavar\u003d\u0027\u003cagent_type\u003e\u0027,"},{"line_number":224,"context_line":"            choices\u003d[\"dhcp\", \"l3\"],"},{"line_number":225,"context_line":"            help\u003d_(\u0027Add only agents with the specified agent type. \u0027"},{"line_number":226,"context_line":"                   \u0027The supported agent types are: dhcp, l3\u0027))"},{"line_number":227,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":45,"id":"da36d5c6_4808522e","line":224,"range":{"start_line":224,"start_character":29,"end_line":224,"end_character":34},"in_reply_to":"da36d5c6_058fa575","updated":"2017-02-27 17:20:51.000000000","message":"Done","commit_id":"3905486fea7ad0f30b89edcb7a817ebb80a89e5a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"965fd0c61dd87c9d577c557e0a792e494e5d58f5","unresolved":false,"context_lines":[{"line_number":227,"context_line":"        parser.add_argument("},{"line_number":228,"context_line":"            \u0027agent\u0027,"},{"line_number":229,"context_line":"            metavar\u003d\u0027\u003cagent\u003e\u0027,"},{"line_number":230,"context_line":"            help\u003d_(\u0027Agent (name or ID)\u0027))"},{"line_number":231,"context_line":"        parser.add_argument("},{"line_number":232,"context_line":"            \u0027network\u0027,"},{"line_number":233,"context_line":"            metavar\u003d\u0027\u003cnetwork\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":45,"id":"da36d5c6_65894175","line":230,"range":{"start_line":230,"start_character":27,"end_line":230,"end_character":35},"updated":"2017-02-22 21:05:26.000000000","message":"No name.","commit_id":"3905486fea7ad0f30b89edcb7a817ebb80a89e5a"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"ee030e01533876e409e09fb50521796e5cf0317d","unresolved":false,"context_lines":[{"line_number":227,"context_line":"        parser.add_argument("},{"line_number":228,"context_line":"            \u0027agent\u0027,"},{"line_number":229,"context_line":"            metavar\u003d\u0027\u003cagent\u003e\u0027,"},{"line_number":230,"context_line":"            help\u003d_(\u0027Agent (name or ID)\u0027))"},{"line_number":231,"context_line":"        parser.add_argument("},{"line_number":232,"context_line":"            \u0027network\u0027,"},{"line_number":233,"context_line":"            metavar\u003d\u0027\u003cnetwork\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":45,"id":"da36d5c6_88024a0a","line":230,"range":{"start_line":230,"start_character":27,"end_line":230,"end_character":35},"in_reply_to":"da36d5c6_65894175","updated":"2017-02-27 17:20:51.000000000","message":"Done","commit_id":"3905486fea7ad0f30b89edcb7a817ebb80a89e5a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b5154390f44fd233b45266b67298b227122e17e3","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            help\u003d_(\u0027Add network to an agent\u0027))"},{"line_number":56,"context_line":"        parser.add_argument("},{"line_number":57,"context_line":"            \u0027agent\u0027,"},{"line_number":58,"context_line":"            metavar\u003d\u0027\u003cagent\u003e\u0027,"},{"line_number":59,"context_line":"            help\u003d_(\u0027Agent (ID)\u0027))"},{"line_number":60,"context_line":"        parser.add_argument("},{"line_number":61,"context_line":"            \u0027network\u0027,"}],"source_content_type":"text/x-python","patch_set":48,"id":"ba2be162_be125f07","line":58,"range":{"start_line":58,"start_character":22,"end_line":58,"end_character":27},"updated":"2017-03-03 00:52:36.000000000","message":"\u003cagent-id\u003e is better.","commit_id":"01b6ff3e53dfc81c2e4261eb21b94094d1cc826b"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"0d3aa6d50a7c3e379565f07da13e6c851f808426","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            help\u003d_(\u0027Add network to an agent\u0027))"},{"line_number":56,"context_line":"        parser.add_argument("},{"line_number":57,"context_line":"            \u0027agent\u0027,"},{"line_number":58,"context_line":"            metavar\u003d\u0027\u003cagent\u003e\u0027,"},{"line_number":59,"context_line":"            help\u003d_(\u0027Agent (ID)\u0027))"},{"line_number":60,"context_line":"        parser.add_argument("},{"line_number":61,"context_line":"            \u0027network\u0027,"}],"source_content_type":"text/x-python","patch_set":48,"id":"ba2be162_80d0b820","line":58,"range":{"start_line":58,"start_character":22,"end_line":58,"end_character":27},"in_reply_to":"ba2be162_be125f07","updated":"2017-03-03 16:25:03.000000000","message":"agent-id causes issues in line 69 since Python thinks its agent - id variable.","commit_id":"01b6ff3e53dfc81c2e4261eb21b94094d1cc826b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b5154390f44fd233b45266b67298b227122e17e3","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        parser.add_argument("},{"line_number":57,"context_line":"            \u0027agent\u0027,"},{"line_number":58,"context_line":"            metavar\u003d\u0027\u003cagent\u003e\u0027,"},{"line_number":59,"context_line":"            help\u003d_(\u0027Agent (ID)\u0027))"},{"line_number":60,"context_line":"        parser.add_argument("},{"line_number":61,"context_line":"            \u0027network\u0027,"},{"line_number":62,"context_line":"            metavar\u003d\u0027\u003cnetwork\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":48,"id":"ba2be162_defb93bf","line":59,"range":{"start_line":59,"start_character":27,"end_line":59,"end_character":29},"updated":"2017-03-03 00:52:36.000000000","message":"ID only","commit_id":"01b6ff3e53dfc81c2e4261eb21b94094d1cc826b"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"0d3aa6d50a7c3e379565f07da13e6c851f808426","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        parser.add_argument("},{"line_number":57,"context_line":"            \u0027agent\u0027,"},{"line_number":58,"context_line":"            metavar\u003d\u0027\u003cagent\u003e\u0027,"},{"line_number":59,"context_line":"            help\u003d_(\u0027Agent (ID)\u0027))"},{"line_number":60,"context_line":"        parser.add_argument("},{"line_number":61,"context_line":"            \u0027network\u0027,"},{"line_number":62,"context_line":"            metavar\u003d\u0027\u003cnetwork\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":48,"id":"ba2be162_804198ab","line":59,"range":{"start_line":59,"start_character":27,"end_line":59,"end_character":29},"in_reply_to":"ba2be162_defb93bf","updated":"2017-03-03 16:25:03.000000000","message":"Done","commit_id":"01b6ff3e53dfc81c2e4261eb21b94094d1cc826b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c255295916b174bee8dd43f6c7e3d8d47c37d1b0","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            help\u003d_(\u0027Add network to an agent\u0027))"},{"line_number":56,"context_line":"        parser.add_argument("},{"line_number":57,"context_line":"            \u0027agent\u0027,"},{"line_number":58,"context_line":"            metavar\u003d\u0027\u003cagent\u003e\u0027,"},{"line_number":59,"context_line":"            help\u003d_(\u0027Agent (ID only)\u0027))"},{"line_number":60,"context_line":"        parser.add_argument("},{"line_number":61,"context_line":"            \u0027network\u0027,"}],"source_content_type":"text/x-python","patch_set":52,"id":"ba2be162_630ba7d6","line":58,"range":{"start_line":58,"start_character":22,"end_line":58,"end_character":27},"updated":"2017-03-05 16:58:42.000000000","message":"-\u003e agent-id","commit_id":"7c69681e7a433c7b149dbdb71377c0e9572db39a"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"c0b0d327b937881a9e7f5500d2e6140251dac6b7","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            help\u003d_(\u0027Add network to an agent\u0027))"},{"line_number":56,"context_line":"        parser.add_argument("},{"line_number":57,"context_line":"            \u0027agent\u0027,"},{"line_number":58,"context_line":"            metavar\u003d\u0027\u003cagent\u003e\u0027,"},{"line_number":59,"context_line":"            help\u003d_(\u0027Agent (ID only)\u0027))"},{"line_number":60,"context_line":"        parser.add_argument("},{"line_number":61,"context_line":"            \u0027network\u0027,"}],"source_content_type":"text/x-python","patch_set":52,"id":"ba2be162_0381ddfb","line":58,"range":{"start_line":58,"start_character":22,"end_line":58,"end_character":27},"in_reply_to":"ba2be162_630ba7d6","updated":"2017-03-06 20:22:06.000000000","message":"Done","commit_id":"7c69681e7a433c7b149dbdb71377c0e9572db39a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c255295916b174bee8dd43f6c7e3d8d47c37d1b0","unresolved":false,"context_lines":[{"line_number":222,"context_line":"            help\u003d_(\u0027Remove network from an agent\u0027))"},{"line_number":223,"context_line":"        parser.add_argument("},{"line_number":224,"context_line":"            \u0027agent\u0027,"},{"line_number":225,"context_line":"            metavar\u003d\u0027\u003cagent\u003e\u0027,"},{"line_number":226,"context_line":"            help\u003d_(\u0027Agent (ID only)\u0027))"},{"line_number":227,"context_line":"        parser.add_argument("},{"line_number":228,"context_line":"            \u0027network\u0027,"}],"source_content_type":"text/x-python","patch_set":52,"id":"ba2be162_830edbe2","line":225,"range":{"start_line":225,"start_character":22,"end_line":225,"end_character":27},"updated":"2017-03-05 16:58:42.000000000","message":"agent-id","commit_id":"7c69681e7a433c7b149dbdb71377c0e9572db39a"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"c0b0d327b937881a9e7f5500d2e6140251dac6b7","unresolved":false,"context_lines":[{"line_number":222,"context_line":"            help\u003d_(\u0027Remove network from an agent\u0027))"},{"line_number":223,"context_line":"        parser.add_argument("},{"line_number":224,"context_line":"            \u0027agent\u0027,"},{"line_number":225,"context_line":"            metavar\u003d\u0027\u003cagent\u003e\u0027,"},{"line_number":226,"context_line":"            help\u003d_(\u0027Agent (ID only)\u0027))"},{"line_number":227,"context_line":"        parser.add_argument("},{"line_number":228,"context_line":"            \u0027network\u0027,"}],"source_content_type":"text/x-python","patch_set":52,"id":"ba2be162_2386e113","line":225,"range":{"start_line":225,"start_character":22,"end_line":225,"end_character":27},"in_reply_to":"ba2be162_830edbe2","updated":"2017-03-06 20:22:06.000000000","message":"Done","commit_id":"7c69681e7a433c7b149dbdb71377c0e9572db39a"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"b38834bc7dc950669850d58f16a0915745d28241","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        parser.add_argument("},{"line_number":53,"context_line":"            \u0027--dhcp\u0027,"},{"line_number":54,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":55,"context_line":"            help\u003d_(\u0027Add network to an agent\u0027))"},{"line_number":56,"context_line":"        parser.add_argument("},{"line_number":57,"context_line":"            \u0027agent_id\u0027,"},{"line_number":58,"context_line":"            metavar\u003d\u0027\u003cagent-id\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":53,"id":"9a30ddce_b2fc5473","line":55,"updated":"2017-03-09 18:47:43.000000000","message":"Add network to a DHCP agent","commit_id":"b4a2cab1e2f41620819f79fa67b04c7459ca4efd"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"939aedb636278e2b7cfe8c676b91890a41564e46","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        parser.add_argument("},{"line_number":53,"context_line":"            \u0027--dhcp\u0027,"},{"line_number":54,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":55,"context_line":"            help\u003d_(\u0027Add network to an agent\u0027))"},{"line_number":56,"context_line":"        parser.add_argument("},{"line_number":57,"context_line":"            \u0027agent_id\u0027,"},{"line_number":58,"context_line":"            metavar\u003d\u0027\u003cagent-id\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":53,"id":"9a30ddce_18a9bf24","line":55,"in_reply_to":"9a30ddce_b2fc5473","updated":"2017-03-09 19:38:25.000000000","message":"Done","commit_id":"b4a2cab1e2f41620819f79fa67b04c7459ca4efd"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"a30844270038e911ef5cc51c82897741e2a6b4c6","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        parser.add_argument("},{"line_number":138,"context_line":"            \u0027--network\u0027,"},{"line_number":139,"context_line":"            metavar\u003d\u0027\u003cnetwork\u003e\u0027,"},{"line_number":140,"context_line":"            help\u003d_(\u0027List DHCP agents hosting a network (name or ID)\u0027)"},{"line_number":141,"context_line":"        )"},{"line_number":142,"context_line":"        return parser"},{"line_number":143,"context_line":""}],"source_content_type":"text/x-python","patch_set":54,"id":"9a30ddce_0171190f","line":140,"updated":"2017-03-10 20:13:16.000000000","message":"List agents hosting a network","commit_id":"8beb2c393d57ab3b9764df45c3bb0afde7cb51b9"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"3660e1932a111fd4575b2cf349b6b6fd74568c13","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        parser.add_argument("},{"line_number":138,"context_line":"            \u0027--network\u0027,"},{"line_number":139,"context_line":"            metavar\u003d\u0027\u003cnetwork\u003e\u0027,"},{"line_number":140,"context_line":"            help\u003d_(\u0027List DHCP agents hosting a network (name or ID)\u0027)"},{"line_number":141,"context_line":"        )"},{"line_number":142,"context_line":"        return parser"},{"line_number":143,"context_line":""}],"source_content_type":"text/x-python","patch_set":54,"id":"9a30ddce_f96c8cd1","line":140,"in_reply_to":"9a30ddce_0171190f","updated":"2017-03-13 15:43:08.000000000","message":"Done","commit_id":"8beb2c393d57ab3b9764df45c3bb0afde7cb51b9"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"41d8fe0ec694c79b2d52f277b9eae66552119964","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"class AddNetworkToAgent(command.Command):"},{"line_number":48,"context_line":"    _description \u003d _(\"Add network to an Agent\")"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def get_parser(self, prog_name):"},{"line_number":51,"context_line":"        parser \u003d super(AddNetworkToAgent, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":55,"id":"1a1ced50_8c676224","line":48,"range":{"start_line":48,"start_character":40,"end_line":48,"end_character":45},"updated":"2017-03-20 18:50:52.000000000","message":"agent*","commit_id":"66be9c1e6d321b0f7a069f9b4d2ee7b5ef364808"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e3dd839caa476843e87f64edc637ca9e251fde92","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        parser \u003d super(AddNetworkToAgent, self).get_parser(prog_name)"},{"line_number":52,"context_line":"        parser.add_argument("},{"line_number":53,"context_line":"            \u0027--dhcp\u0027,"},{"line_number":54,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":55,"context_line":"            help\u003d_(\u0027Add network to a DHCP agent\u0027))"},{"line_number":56,"context_line":"        parser.add_argument("},{"line_number":57,"context_line":"            \u0027agent_id\u0027,"}],"source_content_type":"text/x-python","patch_set":55,"id":"1a1ced50_27f3e9d7","line":54,"updated":"2017-03-20 19:01:41.000000000","message":"If we have \u0027--dhcp\u0027 for future possibility to support other agent type, this option should always return True. How about adding \u0027default\u003dTrue\u0027 here.\n\nAt least, as of now, \"openstack network agent add network \u003cagent\u003e \u003cnetwork\u003e\" should work regardless of specifying --dhcp option or not.","commit_id":"66be9c1e6d321b0f7a069f9b4d2ee7b5ef364808"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"ceaab26e72869ceee0604f5c35ace9055a5da3bc","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        parser \u003d super(AddNetworkToAgent, self).get_parser(prog_name)"},{"line_number":52,"context_line":"        parser.add_argument("},{"line_number":53,"context_line":"            \u0027--dhcp\u0027,"},{"line_number":54,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":55,"context_line":"            help\u003d_(\u0027Add network to a DHCP agent\u0027))"},{"line_number":56,"context_line":"        parser.add_argument("},{"line_number":57,"context_line":"            \u0027agent_id\u0027,"}],"source_content_type":"text/x-python","patch_set":55,"id":"1a1ced50_bd5b662d","line":54,"in_reply_to":"1a1ced50_27f3e9d7","updated":"2017-03-20 19:42:42.000000000","message":"This is here to future-proof scripts.  If we default --dhcp to true, if/when we add other options that will have to change and we\u0027ll have a compatibility problem.","commit_id":"66be9c1e6d321b0f7a069f9b4d2ee7b5ef364808"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"41d8fe0ec694c79b2d52f277b9eae66552119964","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def get_parser(self, prog_name):"},{"line_number":51,"context_line":"        parser \u003d super(AddNetworkToAgent, self).get_parser(prog_name)"},{"line_number":52,"context_line":"        parser.add_argument("},{"line_number":53,"context_line":"            \u0027--dhcp\u0027,"},{"line_number":54,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":55,"context_line":"            help\u003d_(\u0027Add network to a DHCP agent\u0027))"},{"line_number":56,"context_line":"        parser.add_argument("},{"line_number":57,"context_line":"            \u0027agent_id\u0027,"},{"line_number":58,"context_line":"            metavar\u003d\u0027\u003cagent-id\u003e\u0027,"},{"line_number":59,"context_line":"            help\u003d_(\u0027Agent (ID only)\u0027))"},{"line_number":60,"context_line":"        parser.add_argument("},{"line_number":61,"context_line":"            \u0027network\u0027,"},{"line_number":62,"context_line":"            metavar\u003d\u0027\u003cnetwork\u003e\u0027,"},{"line_number":63,"context_line":"            help\u003d_(\u0027Network (name or ID)\u0027))"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        return parser"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":55,"id":"1a1ced50_4c7e4aaf","line":63,"range":{"start_line":52,"start_character":0,"end_line":63,"end_character":43},"updated":"2017-03-20 18:50:52.000000000","message":"the help doesn\u0027t match the proposed text:\n\n.. describe:: --dhcp\n\n    Add a network to DHCP agent.\n\n.. describe:: \u003cagent-id\u003e\n\n    Agent to which a network is added. (ID only)\n\n.. describe:: \u003cnetwork\u003e\n\n    Network to be added to an agent. (ID or name)","commit_id":"66be9c1e6d321b0f7a069f9b4d2ee7b5ef364808"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"41d8fe0ec694c79b2d52f277b9eae66552119964","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    def take_action(self, parsed_args):"},{"line_number":68,"context_line":"        client \u003d self.app.client_manager.network"},{"line_number":69,"context_line":"        agent \u003d client.get_agent(parsed_args.agent_id)"},{"line_number":70,"context_line":"        if parsed_args.dhcp:"},{"line_number":71,"context_line":"            network \u003d client.find_network("},{"line_number":72,"context_line":"                parsed_args.network, ignore_missing\u003dFalse)"},{"line_number":73,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":55,"id":"1a1ced50_4c556a1b","line":70,"range":{"start_line":70,"start_character":8,"end_line":70,"end_character":28},"updated":"2017-03-20 18:50:52.000000000","message":"so if --dhcp isn\u0027t passed in, nothing happens? why do we need it?","commit_id":"66be9c1e6d321b0f7a069f9b4d2ee7b5ef364808"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"ceaab26e72869ceee0604f5c35ace9055a5da3bc","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    def take_action(self, parsed_args):"},{"line_number":68,"context_line":"        client \u003d self.app.client_manager.network"},{"line_number":69,"context_line":"        agent \u003d client.get_agent(parsed_args.agent_id)"},{"line_number":70,"context_line":"        if parsed_args.dhcp:"},{"line_number":71,"context_line":"            network \u003d client.find_network("},{"line_number":72,"context_line":"                parsed_args.network, ignore_missing\u003dFalse)"},{"line_number":73,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":55,"id":"1a1ced50_3d5f760f","line":70,"in_reply_to":"1a1ced50_479c6569","updated":"2017-03-20 19:42:42.000000000","message":"See above, it\u0027s a future-proof option since no one was able to convince me that we\u0027ll never have another agent type that deals with networks","commit_id":"66be9c1e6d321b0f7a069f9b4d2ee7b5ef364808"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e3dd839caa476843e87f64edc637ca9e251fde92","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    def take_action(self, parsed_args):"},{"line_number":68,"context_line":"        client \u003d self.app.client_manager.network"},{"line_number":69,"context_line":"        agent \u003d client.get_agent(parsed_args.agent_id)"},{"line_number":70,"context_line":"        if parsed_args.dhcp:"},{"line_number":71,"context_line":"            network \u003d client.find_network("},{"line_number":72,"context_line":"                parsed_args.network, ignore_missing\u003dFalse)"},{"line_number":73,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":55,"id":"1a1ced50_479c6569","line":70,"range":{"start_line":70,"start_character":8,"end_line":70,"end_character":28},"in_reply_to":"1a1ced50_4c556a1b","updated":"2017-03-20 19:01:41.000000000","message":"My comment at L.54 is related.","commit_id":"66be9c1e6d321b0f7a069f9b4d2ee7b5ef364808"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"41d8fe0ec694c79b2d52f277b9eae66552119964","unresolved":false,"context_lines":[{"line_number":212,"context_line":""},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"class RemoveNetworkFromAgent(command.Command):"},{"line_number":215,"context_line":"    _description \u003d _(\"Remove network from Agent.\")"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    def get_parser(self, prog_name):"},{"line_number":218,"context_line":"        parser \u003d super(RemoveNetworkFromAgent, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":55,"id":"1a1ced50_0c2292b9","line":215,"range":{"start_line":215,"start_character":42,"end_line":215,"end_character":47},"updated":"2017-03-20 18:50:52.000000000","message":"same comment as above","commit_id":"66be9c1e6d321b0f7a069f9b4d2ee7b5ef364808"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"41d8fe0ec694c79b2d52f277b9eae66552119964","unresolved":false,"context_lines":[{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    def get_parser(self, prog_name):"},{"line_number":218,"context_line":"        parser \u003d super(RemoveNetworkFromAgent, self).get_parser(prog_name)"},{"line_number":219,"context_line":"        parser.add_argument("},{"line_number":220,"context_line":"            \u0027--dhcp\u0027,"},{"line_number":221,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":222,"context_line":"            help\u003d_(\u0027Remove network from a DHCP agent\u0027))"},{"line_number":223,"context_line":"        parser.add_argument("},{"line_number":224,"context_line":"            \u0027agent_id\u0027,"},{"line_number":225,"context_line":"            metavar\u003d\u0027\u003cagent-id\u003e\u0027,"},{"line_number":226,"context_line":"            help\u003d_(\u0027Agent (ID only)\u0027))"},{"line_number":227,"context_line":"        parser.add_argument("},{"line_number":228,"context_line":"            \u0027network\u0027,"},{"line_number":229,"context_line":"            metavar\u003d\u0027\u003cnetwork\u003e\u0027,"},{"line_number":230,"context_line":"            help\u003d_(\u0027Network (name or ID)\u0027))"},{"line_number":231,"context_line":"        return parser"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":55,"id":"1a1ced50_2c310e06","line":230,"range":{"start_line":219,"start_character":8,"end_line":230,"end_character":43},"updated":"2017-03-20 18:50:52.000000000","message":"same comment as above","commit_id":"66be9c1e6d321b0f7a069f9b4d2ee7b5ef364808"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"41d8fe0ec694c79b2d52f277b9eae66552119964","unresolved":false,"context_lines":[{"line_number":233,"context_line":"    def take_action(self, parsed_args):"},{"line_number":234,"context_line":"        client \u003d self.app.client_manager.network"},{"line_number":235,"context_line":"        agent \u003d client.get_agent(parsed_args.agent_id)"},{"line_number":236,"context_line":"        if parsed_args.dhcp:"},{"line_number":237,"context_line":"            network \u003d client.find_network("},{"line_number":238,"context_line":"                parsed_args.network, ignore_missing\u003dFalse)"},{"line_number":239,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":55,"id":"1a1ced50_4c2c8aab","line":236,"range":{"start_line":236,"start_character":8,"end_line":236,"end_character":28},"updated":"2017-03-20 18:50:52.000000000","message":"same comment as above","commit_id":"66be9c1e6d321b0f7a069f9b4d2ee7b5ef364808"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"3b555ef55a2786c4647d9fc79f504ccd136960a0","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        parser.add_argument("},{"line_number":57,"context_line":"            \u0027agent_id\u0027,"},{"line_number":58,"context_line":"            metavar\u003d\u0027\u003cagent-id\u003e\u0027,"},{"line_number":59,"context_line":"            help\u003d_(\u0027Agent to which a network is added. (ID only)\u0027))"},{"line_number":60,"context_line":"        parser.add_argument("},{"line_number":61,"context_line":"            \u0027network\u0027,"},{"line_number":62,"context_line":"            metavar\u003d\u0027\u003cnetwork\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":56,"id":"1a1ced50_81b1e8e3","line":59,"range":{"start_line":59,"start_character":53,"end_line":59,"end_character":54},"updated":"2017-03-20 20:22:12.000000000","message":"remove this","commit_id":"f4fd8f6e31dcc177b56d1e618cdefef728d09157"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"3b555ef55a2786c4647d9fc79f504ccd136960a0","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        parser.add_argument("},{"line_number":61,"context_line":"            \u0027network\u0027,"},{"line_number":62,"context_line":"            metavar\u003d\u0027\u003cnetwork\u003e\u0027,"},{"line_number":63,"context_line":"            help\u003d_(\u0027Network to be added to an agent.  (ID or name)\u0027))"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        return parser"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":56,"id":"1a1ced50_c1cbe051","line":63,"range":{"start_line":63,"start_character":51,"end_line":63,"end_character":52},"updated":"2017-03-20 20:22:12.000000000","message":"ditto","commit_id":"f4fd8f6e31dcc177b56d1e618cdefef728d09157"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"3b555ef55a2786c4647d9fc79f504ccd136960a0","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        client \u003d self.app.client_manager.network"},{"line_number":69,"context_line":"        agent \u003d client.get_agent(parsed_args.agent_id)"},{"line_number":70,"context_line":"        if parsed_args.dhcp:"},{"line_number":71,"context_line":"            network \u003d client.find_network("},{"line_number":72,"context_line":"                parsed_args.network, ignore_missing\u003dFalse)"},{"line_number":73,"context_line":"            try:"},{"line_number":74,"context_line":"                client.add_dhcp_agent_to_network(agent, network)"},{"line_number":75,"context_line":"            except Exception:"},{"line_number":76,"context_line":"                msg \u003d \u0027Failed to add {} to {}\u0027.format("}],"source_content_type":"text/x-python","patch_set":56,"id":"1a1ced50_612f8cf6","line":73,"range":{"start_line":71,"start_character":1,"end_line":73,"end_character":2},"updated":"2017-03-20 20:22:12.000000000","message":"This check should not be inside if parsed_Args.dhcp because the user can specify network without specifying DHCP","commit_id":"f4fd8f6e31dcc177b56d1e618cdefef728d09157"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"3b555ef55a2786c4647d9fc79f504ccd136960a0","unresolved":false,"context_lines":[{"line_number":233,"context_line":"    def take_action(self, parsed_args):"},{"line_number":234,"context_line":"        client \u003d self.app.client_manager.network"},{"line_number":235,"context_line":"        agent \u003d client.get_agent(parsed_args.agent_id)"},{"line_number":236,"context_line":"        if parsed_args.dhcp:"},{"line_number":237,"context_line":"            network \u003d client.find_network("},{"line_number":238,"context_line":"                parsed_args.network, ignore_missing\u003dFalse)"},{"line_number":239,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":56,"id":"1a1ced50_c1276010","line":236,"range":{"start_line":236,"start_character":11,"end_line":236,"end_character":22},"updated":"2017-03-20 20:22:12.000000000","message":"ditto","commit_id":"f4fd8f6e31dcc177b56d1e618cdefef728d09157"}],"openstackclient/tests/functional/network/v2/test_network.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"cf499b1681e0d7352ded6f9432a4a5c31258f06b","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    \"\"\"Functional tests for network. \"\"\""},{"line_number":20,"context_line":"    NAME \u003d uuid.uuid4().hex"},{"line_number":21,"context_line":"    HEADERS \u003d [\u0027Name\u0027]"},{"line_number":22,"context_line":"    AGENT_HEADERS \u003d [\u0027Name\u0027]"},{"line_number":23,"context_line":"    FIELDS \u003d [\u0027name\u0027]"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":26,"id":"da4df55a_9538243f","line":22,"updated":"2016-12-26 12:59:39.000000000","message":"Are you using this anywhere?","commit_id":"8d08867a8cee64390798f15a6c3482dbc8dda01c"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"cf499b1681e0d7352ded6f9432a4a5c31258f06b","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    def test_network_list_agent(self):"},{"line_number":54,"context_line":"        # TODO(sshank): Recheck this."},{"line_number":55,"context_line":"        opts \u003d self.get_opts(self.HEADERS)"},{"line_number":56,"context_line":"        raw_output \u003d self.openstack(\u0027network list --agent\u0027 + opts)"},{"line_number":57,"context_line":"        self.assertIn(self.NAME, raw_output)"}],"source_content_type":"text/x-python","patch_set":26,"id":"da4df55a_105e0212","line":56,"updated":"2016-12-26 12:59:39.000000000","message":"You need to change this code.\n\nThe get_opts() function from the base class is returning to you \n\n   -f value -c Name\n\nWhen we use it with ``openstack network list`` , it gives the following response.\n\n\n [outofmemory@localhost neutron-lbaas]$ openstack network list -f value -c Name\n lb-mgmt-net\n private\n public\n\n\nHowever, your functional test case fails because you are creating the following command\n\n    openstack network list --agent -f value -c Name\n\nYou need to add an Agent name as well.\nConsider changing the code to:\n\n    raw_output \u003d self.openstack(\u0027network list --agent DHCP_AGENT_NAME\u0027 + opts)\n\n\nThe DHCP Agent Name can be found from \n\n openstack network agent list  -c \"Agent Type\" -c ID -f value\n\nTry it, hopefully it would help.","commit_id":"8d08867a8cee64390798f15a6c3482dbc8dda01c"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"83c700d375d6d1eccb6a8154ca9aaf289e124413","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    def test_network_list_agent(self):"},{"line_number":54,"context_line":"        # TODO(sshank): Recheck this."},{"line_number":55,"context_line":"        opts \u003d self.get_opts(self.HEADERS)"},{"line_number":56,"context_line":"        raw_output \u003d self.openstack(\u0027network list --agent\u0027 + opts)"},{"line_number":57,"context_line":"        self.assertIn(self.NAME, raw_output)"}],"source_content_type":"text/x-python","patch_set":26,"id":"ba5201f7_fa38af3f","line":56,"in_reply_to":"da4df55a_105e0212","updated":"2017-01-03 18:00:40.000000000","message":"Thanks for the review. I have made the changes. Also, there was another issue in the _get_subnets method which I have updated in the next patch.","commit_id":"8d08867a8cee64390798f15a6c3482dbc8dda01c"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"bc70c2c923b8575873570b75dea7cf01d65586e0","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            re.search(\"\\|\\s+\" + name2 + \"\\s+\\|\\s+ACTIVE\", raw_output)"},{"line_number":163,"context_line":"        )"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        # Test list --agent"},{"line_number":166,"context_line":"        name4 \u003d uuid.uuid4().hex"},{"line_number":167,"context_line":"        raw_output \u003d self.openstack("},{"line_number":168,"context_line":"            \u0027network list --agent \u0027 +"}],"source_content_type":"text/x-python","patch_set":33,"id":"ba5201f7_59862cdc","line":165,"updated":"2017-01-10 16:55:01.000000000","message":"Move to its own function\n\n0. create dummy network\n1. \u0027network agent list --agent-type \u003cdhcp\u003e\n2. grab ID\n3. \u0027network list --agent \u003cID\u003e\u0027\n4  assertions\n5. delete dummy network","commit_id":"a0d4e5fc6371932fb739ba1ab29346f0cf60d563"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"d9112cea41fb193f1e1f80a7ea9ce44daec6d71e","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            re.search(\"\\|\\s+\" + name2 + \"\\s+\\|\\s+ACTIVE\", raw_output)"},{"line_number":163,"context_line":"        )"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        # Test list --agent"},{"line_number":166,"context_line":"        name4 \u003d uuid.uuid4().hex"},{"line_number":167,"context_line":"        raw_output \u003d self.openstack("},{"line_number":168,"context_line":"            \u0027network list --agent \u0027 +"}],"source_content_type":"text/x-python","patch_set":33,"id":"ba5201f7_fb1eb80a","line":165,"in_reply_to":"ba5201f7_59862cdc","updated":"2017-01-11 17:40:15.000000000","message":"Done","commit_id":"a0d4e5fc6371932fb739ba1ab29346f0cf60d563"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"6fbe6d9a9b802fc8c8dd0f6ba7cdb7a23bfe8b08","unresolved":false,"context_lines":[{"line_number":270,"context_line":"        # Test network list --agent"},{"line_number":271,"context_line":"        cmd_output3 \u003d json.loads(self.openstack("},{"line_number":272,"context_line":"            \u0027network list -f json --agent \u0027 + agent_id"},{"line_number":273,"context_line":"        ))"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"        # Cleanup"},{"line_number":276,"context_line":"        # Remove Agent from Network"}],"source_content_type":"text/x-python","patch_set":44,"id":"da36d5c6_8ab495d1","line":273,"updated":"2017-02-22 14:50:07.000000000","message":"There needs to be some validation that the network has actually been added to the DHCP agent here.","commit_id":"54132a9926a6bf5d96f0e16b02f571f0ad005e6d"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"8d791590c955b83fc045e8a08f49d858353089de","unresolved":false,"context_lines":[{"line_number":270,"context_line":"        # Test network list --agent"},{"line_number":271,"context_line":"        cmd_output3 \u003d json.loads(self.openstack("},{"line_number":272,"context_line":"            \u0027network list -f json --agent \u0027 + agent_id"},{"line_number":273,"context_line":"        ))"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"        # Cleanup"},{"line_number":276,"context_line":"        # Remove Agent from Network"}],"source_content_type":"text/x-python","patch_set":44,"id":"da36d5c6_5845126e","line":273,"in_reply_to":"da36d5c6_8ab495d1","updated":"2017-02-22 17:02:30.000000000","message":"The validation is done in line 287. The assert fails if the DHCP agents are not added.","commit_id":"54132a9926a6bf5d96f0e16b02f571f0ad005e6d"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"6fbe6d9a9b802fc8c8dd0f6ba7cdb7a23bfe8b08","unresolved":false,"context_lines":[{"line_number":280,"context_line":"        )"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        # Delete network"},{"line_number":283,"context_line":"        self.openstack(\u0027network delete \u0027 + name1)"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"        # Assert"},{"line_number":286,"context_line":"        col_name \u003d [x[\"ID\"] for x in cmd_output3]"}],"source_content_type":"text/x-python","patch_set":44,"id":"da36d5c6_8a865511","line":283,"updated":"2017-02-22 14:50:07.000000000","message":"This should be done using self.addCleanup() immediately after creating the network:\n\n        self.addCleanup(self.openstack, \u0027network delete \u0027 + name1)","commit_id":"54132a9926a6bf5d96f0e16b02f571f0ad005e6d"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"8d791590c955b83fc045e8a08f49d858353089de","unresolved":false,"context_lines":[{"line_number":280,"context_line":"        )"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        # Delete network"},{"line_number":283,"context_line":"        self.openstack(\u0027network delete \u0027 + name1)"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"        # Assert"},{"line_number":286,"context_line":"        col_name \u003d [x[\"ID\"] for x in cmd_output3]"}],"source_content_type":"text/x-python","patch_set":44,"id":"da36d5c6_589a7264","line":283,"in_reply_to":"da36d5c6_8a865511","updated":"2017-02-22 17:02:30.000000000","message":"Done","commit_id":"54132a9926a6bf5d96f0e16b02f571f0ad005e6d"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"3b555ef55a2786c4647d9fc79f504ccd136960a0","unresolved":false,"context_lines":[{"line_number":270,"context_line":""},{"line_number":271,"context_line":"        # Cleanup"},{"line_number":272,"context_line":"        # Remove Agent from Network"},{"line_number":273,"context_line":"        self.openstack("},{"line_number":274,"context_line":"            \u0027network agent remove network --dhcp \u0027"},{"line_number":275,"context_line":"            + agent_id + \u0027 \u0027 + network_id"},{"line_number":276,"context_line":"        )"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"        # Assert"},{"line_number":279,"context_line":"        col_name \u003d [x[\"ID\"] for x in cmd_output3]"}],"source_content_type":"text/x-python","patch_set":56,"id":"1a1ced50_617dcce6","line":276,"range":{"start_line":273,"start_character":1,"end_line":276,"end_character":9},"updated":"2017-03-20 20:22:12.000000000","message":"Please add to the addCleanup()","commit_id":"f4fd8f6e31dcc177b56d1e618cdefef728d09157"}],"openstackclient/tests/functional/network/v2/test_network_agent.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"a7ce1ee9a268e89a9397815b7cb18f615cd3b7b4","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        opts \u003d cls.get_opts(cls.NETWORK_HEADERS)"},{"line_number":48,"context_line":"        raw_output \u003d cls.openstack(\u0027network agent list --network\u0027 + opts)"},{"line_number":49,"context_line":"        # get the list of network agent IDs."},{"line_number":50,"context_line":"        cls.IDs \u003d raw_output.split(\u0027\\n\u0027)"}],"source_content_type":"text/x-python","patch_set":25,"id":"1a6eadb0_4f02be3f","line":50,"updated":"2016-12-20 11:53:46.000000000","message":"What\u0027s the use of L50 ?\n\nYou can make much stronger assertion. This doesn\u0027t assert more than what unit testing already does.","commit_id":"eee790c4df307a84243a92b3e0eff5e7561891bd"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"ea1e2a733ce2173d4ab515142de4900e31b44d03","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        opts \u003d cls.get_opts(cls.NETWORK_HEADERS)"},{"line_number":48,"context_line":"        raw_output \u003d cls.openstack(\u0027network agent list --network\u0027 + opts)"},{"line_number":49,"context_line":"        # get the list of network agent IDs."},{"line_number":50,"context_line":"        cls.IDs \u003d raw_output.split(\u0027\\n\u0027)"}],"source_content_type":"text/x-python","patch_set":25,"id":"da4df55a_136e2395","line":50,"in_reply_to":"1a6eadb0_4f02be3f","updated":"2016-12-25 03:31:44.000000000","message":"I was following the tests from here: [1] \n\n[1] - https://review.openstack.org/#/c/387611/26/openstackclient/tests/functional/network/v2/test_network_agent.py@26.","commit_id":"eee790c4df307a84243a92b3e0eff5e7561891bd"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"bc70c2c923b8575873570b75dea7cf01d65586e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"ba5201f7_79f8507d","line":55,"updated":"2017-01-10 16:55:01.000000000","message":"1. create dummy network\n2. grab network id\n3. \u0027network agent list --network \u003cnetwork-id\u003e\n4. assertions\n5. delete dummy network using ID","commit_id":"a0d4e5fc6371932fb739ba1ab29346f0cf60d563"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"d9112cea41fb193f1e1f80a7ea9ce44daec6d71e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"ba5201f7_7bd9e856","line":55,"in_reply_to":"ba5201f7_79f8507d","updated":"2017-01-11 17:40:15.000000000","message":"Done","commit_id":"a0d4e5fc6371932fb739ba1ab29346f0cf60d563"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"6fbe6d9a9b802fc8c8dd0f6ba7cdb7a23bfe8b08","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        )"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        # Delete network"},{"line_number":89,"context_line":"        self.openstack(\u0027network delete \u0027 + name1)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        # Assert"},{"line_number":92,"context_line":"        col_name \u003d [x[\"ID\"] for x in cmd_output3]"}],"source_content_type":"text/x-python","patch_set":44,"id":"da36d5c6_aaf95982","line":89,"updated":"2017-02-22 14:50:07.000000000","message":"This should be done using self.addCleanup() immediately after creating the network:\n\n        self.addCleanup(self.openstack, \u0027network delete \u0027 + name1)","commit_id":"54132a9926a6bf5d96f0e16b02f571f0ad005e6d"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"8d791590c955b83fc045e8a08f49d858353089de","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        )"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        # Delete network"},{"line_number":89,"context_line":"        self.openstack(\u0027network delete \u0027 + name1)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        # Assert"},{"line_number":92,"context_line":"        col_name \u003d [x[\"ID\"] for x in cmd_output3]"}],"source_content_type":"text/x-python","patch_set":44,"id":"da36d5c6_d8ae6284","line":89,"in_reply_to":"da36d5c6_aaf95982","updated":"2017-02-22 17:02:30.000000000","message":"Done","commit_id":"54132a9926a6bf5d96f0e16b02f571f0ad005e6d"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"b38834bc7dc950669850d58f16a0915745d28241","unresolved":false,"context_lines":[{"line_number":48,"context_line":"class NetworkAgentListTests(base.TestCase):"},{"line_number":49,"context_line":"    \"\"\"Functional test for network agent list --network. \"\"\""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def test_network_agent_list(self):"},{"line_number":52,"context_line":"        \"\"\"Test network agent list\"\"\""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        name1 \u003d uuid.uuid4().hex"}],"source_content_type":"text/x-python","patch_set":53,"id":"9a30ddce_d2eaa8ab","line":51,"updated":"2017-03-09 18:47:43.000000000","message":"rename to specific to DHCP","commit_id":"b4a2cab1e2f41620819f79fa67b04c7459ca4efd"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"939aedb636278e2b7cfe8c676b91890a41564e46","unresolved":false,"context_lines":[{"line_number":48,"context_line":"class NetworkAgentListTests(base.TestCase):"},{"line_number":49,"context_line":"    \"\"\"Functional test for network agent list --network. \"\"\""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def test_network_agent_list(self):"},{"line_number":52,"context_line":"        \"\"\"Test network agent list\"\"\""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        name1 \u003d uuid.uuid4().hex"}],"source_content_type":"text/x-python","patch_set":53,"id":"9a30ddce_786abbef","line":51,"in_reply_to":"9a30ddce_d2eaa8ab","updated":"2017-03-09 19:38:25.000000000","message":"Done","commit_id":"b4a2cab1e2f41620819f79fa67b04c7459ca4efd"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"3b555ef55a2786c4647d9fc79f504ccd136960a0","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        # Cleanup"},{"line_number":83,"context_line":"        # Remove Agent from Network"},{"line_number":84,"context_line":"        self.openstack("},{"line_number":85,"context_line":"            \u0027network agent remove network --dhcp \u0027"},{"line_number":86,"context_line":"            + agent_id + \u0027 \u0027 + network_id"},{"line_number":87,"context_line":"        )"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        # Assert"},{"line_number":90,"context_line":"        col_name \u003d [x[\"ID\"] for x in cmd_output3]"}],"source_content_type":"text/x-python","patch_set":56,"id":"1a1ced50_2174b4fb","line":87,"range":{"start_line":84,"start_character":3,"end_line":87,"end_character":9},"updated":"2017-03-20 20:22:12.000000000","message":"dITTO","commit_id":"f4fd8f6e31dcc177b56d1e618cdefef728d09157"}],"openstackclient/tests/unit/network/v2/test_network.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"a7ce1ee9a268e89a9397815b7cb18f615cd3b7b4","unresolved":false,"context_lines":[{"line_number":504,"context_line":""},{"line_number":505,"context_line":"        self._dhcp_agent \u003d \\"},{"line_number":506,"context_line":"            network_fakes.FakeNetworkAgent.create_one_network_agent()"},{"line_number":507,"context_line":"        self._subnet \u003d network_fakes.FakeSubnet.create_one_subnet()"},{"line_number":508,"context_line":"        self._subnet_list \u003d []"},{"line_number":509,"context_line":""},{"line_number":510,"context_line":"        subnets \u003d network_fakes.FakeSubnet.create_subnets(count\u003d2)"}],"source_content_type":"text/x-python","patch_set":25,"id":"1a6eadb0_afa51248","line":507,"updated":"2016-12-20 11:53:46.000000000","message":"Why make this an instance variable ? It\u0027s not reused outside of the setUp method.","commit_id":"eee790c4df307a84243a92b3e0eff5e7561891bd"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"ea1e2a733ce2173d4ab515142de4900e31b44d03","unresolved":false,"context_lines":[{"line_number":504,"context_line":""},{"line_number":505,"context_line":"        self._dhcp_agent \u003d \\"},{"line_number":506,"context_line":"            network_fakes.FakeNetworkAgent.create_one_network_agent()"},{"line_number":507,"context_line":"        self._subnet \u003d network_fakes.FakeSubnet.create_one_subnet()"},{"line_number":508,"context_line":"        self._subnet_list \u003d []"},{"line_number":509,"context_line":""},{"line_number":510,"context_line":"        subnets \u003d network_fakes.FakeSubnet.create_subnets(count\u003d2)"}],"source_content_type":"text/x-python","patch_set":25,"id":"da4df55a_f3f51fcb","line":507,"in_reply_to":"1a6eadb0_afa51248","updated":"2016-12-25 03:31:44.000000000","message":"Done","commit_id":"eee790c4df307a84243a92b3e0eff5e7561891bd"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"b38834bc7dc950669850d58f16a0915745d28241","unresolved":false,"context_lines":[{"line_number":772,"context_line":"        self.assertEqual(self.columns, columns)"},{"line_number":773,"context_line":"        self.assertEqual(self.data, list(data))"},{"line_number":774,"context_line":""},{"line_number":775,"context_line":"    def test_network_list_agent(self):"},{"line_number":776,"context_line":"        arglist \u003d ["},{"line_number":777,"context_line":"            \u0027--agent\u0027, self._agent.id"},{"line_number":778,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":53,"id":"9a30ddce_32da2418","line":775,"updated":"2017-03-09 18:47:43.000000000","message":"This will test just default case.\n\nWill have to add one for DHCP specific case","commit_id":"b4a2cab1e2f41620819f79fa67b04c7459ca4efd"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"939aedb636278e2b7cfe8c676b91890a41564e46","unresolved":false,"context_lines":[{"line_number":772,"context_line":"        self.assertEqual(self.columns, columns)"},{"line_number":773,"context_line":"        self.assertEqual(self.data, list(data))"},{"line_number":774,"context_line":""},{"line_number":775,"context_line":"    def test_network_list_agent(self):"},{"line_number":776,"context_line":"        arglist \u003d ["},{"line_number":777,"context_line":"            \u0027--agent\u0027, self._agent.id"},{"line_number":778,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":53,"id":"9a30ddce_b870b3dd","line":775,"in_reply_to":"9a30ddce_32da2418","updated":"2017-03-09 19:38:25.000000000","message":"Made it DHCP specific.","commit_id":"b4a2cab1e2f41620819f79fa67b04c7459ca4efd"}],"openstackclient/tests/unit/network/v2/test_network_agent.py":[{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"30e3c39ed0ef50fee1ada46f0974533f92ec84c9","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        # Get the command object to test"},{"line_number":149,"context_line":"        self.cmd \u003d network_agent.ListNetworkAgent(self.app, self.namespace)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def test_network_agents_list(self):"},{"line_number":152,"context_line":"        arglist \u003d []"},{"line_number":153,"context_line":"        verifylist \u003d []"},{"line_number":154,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"5a74a57a_40a8e8db","line":151,"updated":"2016-11-30 17:16:23.000000000","message":"There should be a list test for the --network option","commit_id":"f3e37a6fd86adba9c0d0cc08c929703f53e8d856"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"fff5de54452a086d857aee489fa9d94e88d53e06","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        # Get the command object to test"},{"line_number":149,"context_line":"        self.cmd \u003d network_agent.ListNetworkAgent(self.app, self.namespace)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def test_network_agents_list(self):"},{"line_number":152,"context_line":"        arglist \u003d []"},{"line_number":153,"context_line":"        verifylist \u003d []"},{"line_number":154,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"5a74a57a_1031d50b","line":151,"in_reply_to":"5a74a57a_40a8e8db","updated":"2016-11-30 22:46:44.000000000","message":"Done","commit_id":"f3e37a6fd86adba9c0d0cc08c929703f53e8d856"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"a7ce1ee9a268e89a9397815b7cb18f615cd3b7b4","unresolved":false,"context_lines":[{"line_number":166,"context_line":"            network_fakes.FakeNetworkAgent.create_one_network_agent()"},{"line_number":167,"context_line":"        self.network.get_agent \u003d mock.Mock(return_value\u003dself._testagent)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        self._testnetwork \u003d network_fakes.FakeNetwork.create_one_network()"},{"line_number":170,"context_line":"        self.network.find_network \u003d mock.Mock(return_value\u003dself._testnetwork)"},{"line_number":171,"context_line":"        self.network.network_hosting_dhcp_agents \u003d mock.Mock("},{"line_number":172,"context_line":"            return_value\u003dself.network_agents)"}],"source_content_type":"text/x-python","patch_set":25,"id":"1a6eadb0_af7c32b6","line":169,"updated":"2016-12-20 11:53:46.000000000","message":"Why make this an instance variable ? It\u0027s not reused outside of the setUp method.","commit_id":"eee790c4df307a84243a92b3e0eff5e7561891bd"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"ea1e2a733ce2173d4ab515142de4900e31b44d03","unresolved":false,"context_lines":[{"line_number":166,"context_line":"            network_fakes.FakeNetworkAgent.create_one_network_agent()"},{"line_number":167,"context_line":"        self.network.get_agent \u003d mock.Mock(return_value\u003dself._testagent)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        self._testnetwork \u003d network_fakes.FakeNetwork.create_one_network()"},{"line_number":170,"context_line":"        self.network.find_network \u003d mock.Mock(return_value\u003dself._testnetwork)"},{"line_number":171,"context_line":"        self.network.network_hosting_dhcp_agents \u003d mock.Mock("},{"line_number":172,"context_line":"            return_value\u003dself.network_agents)"}],"source_content_type":"text/x-python","patch_set":25,"id":"da4df55a_130543bb","line":169,"in_reply_to":"1a6eadb0_af7c32b6","updated":"2016-12-25 03:31:44.000000000","message":"Done","commit_id":"eee790c4df307a84243a92b3e0eff5e7561891bd"}],"releasenotes/notes/bp-network-dhcp-adv-commands-bd42d70b0c73f891.yaml":[{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"30e3c39ed0ef50fee1ada46f0974533f92ec84c9","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add network agent-dhcp related commands."},{"line_number":5,"context_line":"    [Blueprint `network-dhcp-adv-commands \u003chttps://blueprints.launchpad.net/python-openstackclient/+spec/network-dhcp-adv-commands`_] "}],"source_content_type":"text/x-yaml","patch_set":18,"id":"5a74a57a_20204c9b","line":5,"updated":"2016-11-30 17:16:23.000000000","message":"nit:whitespace\n\nAnd write out the commands added please.\nie ``network agent dhcp add network`` etc...","commit_id":"f3e37a6fd86adba9c0d0cc08c929703f53e8d856"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"fff5de54452a086d857aee489fa9d94e88d53e06","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add network agent-dhcp related commands."},{"line_number":5,"context_line":"    [Blueprint `network-dhcp-adv-commands \u003chttps://blueprints.launchpad.net/python-openstackclient/+spec/network-dhcp-adv-commands`_] "}],"source_content_type":"text/x-yaml","patch_set":18,"id":"5a74a57a_9025e5c3","line":5,"in_reply_to":"5a74a57a_20204c9b","updated":"2016-11-30 22:46:44.000000000","message":"Done","commit_id":"f3e37a6fd86adba9c0d0cc08c929703f53e8d856"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"8050f163bfa36f19be2d5aa2de6f98ce1ec8f66a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Add network agent-dhcp related commands:"},{"line_number":5,"context_line":"    ``network agent dhcp add network``, ``network agent dhcp remove network``,"},{"line_number":6,"context_line":"    ``network agent list --network``"},{"line_number":7,"context_line":"    [Blueprint `network-dhcp-adv-commands \u003chttps://blueprints.launchpad.net/python-openstackclient/+spec/network-dhcp-adv-commands`_] "}],"source_content_type":"text/x-yaml","patch_set":19,"id":"3a71b18c_52461f24","line":7,"updated":"2016-12-01 16:36:40.000000000","message":"failing because of missingg \u0027\u003e\u0027","commit_id":"d7fd86a5f9ff8d7d6e4fa919160420eef273c185"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"a5f9d847941ba5dcc00c5964d70f5349f49d88b0","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add network agent-dhcp related commands:"},{"line_number":5,"context_line":"    ``network agent dhcp add network``, ``network agent dhcp remove network``,"},{"line_number":6,"context_line":"    ``network agent list --network``"},{"line_number":7,"context_line":"    [Blueprint `network-dhcp-adv-commands \u003chttps://blueprints.launchpad.net/python-openstackclient/+spec/network-dhcp-adv-commands\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"3a71b18c_aeb78fd6","line":6,"updated":"2016-12-05 16:51:52.000000000","message":"network list --agent?","commit_id":"4acf44d6394ec603b6c220b7ef0fb060e035832b"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"c90fa08e22efbaca2e2427f4c3d5416ef6bd87bd","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add network agent-dhcp related commands:"},{"line_number":5,"context_line":"    ``network agent dhcp add network``, ``network agent dhcp remove network``,"},{"line_number":6,"context_line":"    ``network agent list --network``"},{"line_number":7,"context_line":"    [Blueprint `network-dhcp-adv-commands \u003chttps://blueprints.launchpad.net/python-openstackclient/+spec/network-dhcp-adv-commands\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"3a71b18c_3c6ad5b3","line":6,"in_reply_to":"3a71b18c_aeb78fd6","updated":"2016-12-05 17:21:51.000000000","message":"Done","commit_id":"4acf44d6394ec603b6c220b7ef0fb060e035832b"}],"releasenotes/notes/bp-network-dhcp-adv-commands-e61bf8757f46dc93.yaml":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"3b555ef55a2786c4647d9fc79f504ccd136960a0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add network dhcp-agent related commands ``network agent add network``,"},{"line_number":5,"context_line":"    ``network agent remove network``, ``network agent list --network`` and"},{"line_number":6,"context_line":"    ``network list --agent`` for adding/removing network to dhcp agent."},{"line_number":7,"context_line":"    [Blueprint :oscbp:`network-dhcp-adv-commands`]"}],"source_content_type":"text/x-yaml","patch_set":56,"id":"1a1ced50_0150985c","line":4,"range":{"start_line":4,"start_character":16,"end_line":4,"end_character":26},"updated":"2017-03-20 20:22:12.000000000","message":"Please remove dhcp-agent word here \n\nOR\n\nadd --dhcp option in the OSC commands  , as this is not only DHCP specific but Network specific modification","commit_id":"f4fd8f6e31dcc177b56d1e618cdefef728d09157"}],"setup.cfg":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"48dd87b5047b4646899146dc94916f8c173eaa28","unresolved":false,"context_lines":[{"line_number":365,"context_line":"    network_list \u003d openstackclient.network.v2.network:ListNetwork"},{"line_number":366,"context_line":"    network_set \u003d openstackclient.network.v2.network:SetNetwork"},{"line_number":367,"context_line":"    network_show \u003d openstackclient.network.v2.network:ShowNetwork"},{"line_number":368,"context_line":"    network_hosting_DHCP-agents_list \u003d openstackclient.network.v2.network:ListHostingDHCPAgents"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    network_qos_policy_create \u003d openstackclient.network.v2.network_qos_policy:CreateNetworkQosPolicy"},{"line_number":371,"context_line":"    network_qos_policy_delete \u003d openstackclient.network.v2.network_qos_policy:DeleteNetworkQosPolicy"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"fa6399be_16a8a976","line":368,"updated":"2016-10-20 13:10:53.000000000","message":"You are listing network agents for a network.  So I think this should be part of the network agent list command or something similar.","commit_id":"fb8ef053490227412827757c56380e20f2fa373d"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"76278851793d56e217c982709b9548724b23364f","unresolved":false,"context_lines":[{"line_number":365,"context_line":"    network_list \u003d openstackclient.network.v2.network:ListNetwork"},{"line_number":366,"context_line":"    network_set \u003d openstackclient.network.v2.network:SetNetwork"},{"line_number":367,"context_line":"    network_show \u003d openstackclient.network.v2.network:ShowNetwork"},{"line_number":368,"context_line":"    network_hosting_DHCP-agents_list \u003d openstackclient.network.v2.network:ListHostingDHCPAgents"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    network_qos_policy_create \u003d openstackclient.network.v2.network_qos_policy:CreateNetworkQosPolicy"},{"line_number":371,"context_line":"    network_qos_policy_delete \u003d openstackclient.network.v2.network_qos_policy:DeleteNetworkQosPolicy"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"ba5da102_a06b30f0","line":368,"in_reply_to":"ba5da102_b9fb70c0","updated":"2016-11-01 19:17:46.000000000","message":"Done","commit_id":"fb8ef053490227412827757c56380e20f2fa373d"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"7a6bd9a83e3fe48116892ba8c470fcd33ee3fe25","unresolved":false,"context_lines":[{"line_number":365,"context_line":"    network_list \u003d openstackclient.network.v2.network:ListNetwork"},{"line_number":366,"context_line":"    network_set \u003d openstackclient.network.v2.network:SetNetwork"},{"line_number":367,"context_line":"    network_show \u003d openstackclient.network.v2.network:ShowNetwork"},{"line_number":368,"context_line":"    network_hosting_DHCP-agents_list \u003d openstackclient.network.v2.network:ListHostingDHCPAgents"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    network_qos_policy_create \u003d openstackclient.network.v2.network_qos_policy:CreateNetworkQosPolicy"},{"line_number":371,"context_line":"    network_qos_policy_delete \u003d openstackclient.network.v2.network_qos_policy:DeleteNetworkQosPolicy"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"ba5da102_b9fb70c0","line":368,"in_reply_to":"fa6399be_16a8a976","updated":"2016-11-01 17:01:16.000000000","message":"agreed. \n\nnetwork_agent_dhcp-agents_list or something along those lines","commit_id":"fb8ef053490227412827757c56380e20f2fa373d"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"6fbe6d9a9b802fc8c8dd0f6ba7cdb7a23bfe8b08","unresolved":false,"context_lines":[{"line_number":360,"context_line":"    network_agent_set \u003d openstackclient.network.v2.network_agent:SetNetworkAgent"},{"line_number":361,"context_line":"    network_agent_show \u003d openstackclient.network.v2.network_agent:ShowNetworkAgent"},{"line_number":362,"context_line":"    network_agent_add_network \u003d openstackclient.network.v2.network_agent:AddNetworkToAgent"},{"line_number":363,"context_line":"    network_agent_remove_network \u003d openstackclient.network.v2.network_agent:RemoveNetworkFromAgent"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"    network_create \u003d openstackclient.network.v2.network:CreateNetwork"},{"line_number":366,"context_line":"    network_delete \u003d openstackclient.network.v2.network:DeleteNetwork"}],"source_content_type":"text/x-ttcn-cfg","patch_set":44,"id":"da36d5c6_ca212db6","line":363,"updated":"2017-02-22 14:50:07.000000000","message":"These need to be in alpha order here","commit_id":"54132a9926a6bf5d96f0e16b02f571f0ad005e6d"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"b38834bc7dc950669850d58f16a0915745d28241","unresolved":false,"context_lines":[{"line_number":360,"context_line":"    network_agent_list \u003d openstackclient.network.v2.network_agent:ListNetworkAgent"},{"line_number":361,"context_line":"    network_agent_set \u003d openstackclient.network.v2.network_agent:SetNetworkAgent"},{"line_number":362,"context_line":"    network_agent_show \u003d openstackclient.network.v2.network_agent:ShowNetworkAgent"},{"line_number":363,"context_line":"    network_agent_remove_network \u003d openstackclient.network.v2.network_agent:RemoveNetworkFromAgent"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"    network_auto_allocated_topology_create \u003d openstackclient.network.v2.network_auto_allocated_topology:CreateAutoAllocatedTopology"},{"line_number":366,"context_line":"    network_auto_allocated_topology_delete \u003d openstackclient.network.v2.network_auto_allocated_topology:DeleteAutoAllocatedTopology"}],"source_content_type":"text/x-ttcn-cfg","patch_set":53,"id":"9a30ddce_f2cc0c6c","line":363,"updated":"2017-03-09 18:47:43.000000000","message":"move above set. Alphabetical","commit_id":"b4a2cab1e2f41620819f79fa67b04c7459ca4efd"}]}