)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"5d29d3adb4f21f7487e3ea8a473c6e7ed15af7ae","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Yan Xing\u0027an \u003cyanxingan@cmss.chinamobile.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-12-12 23:33:21 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add filtering options to the address scope list commond"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add --name, --ip-version, --project, --project-domain,"},{"line_number":10,"context_line":"--share, --no-share options to the address scope list command."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a6eadb0_5a9ab515","line":7,"range":{"start_line":7,"start_character":48,"end_line":7,"end_character":55},"updated":"2016-12-13 07:36:43.000000000","message":"nit:\ncommand","commit_id":"8f5dbde87a3d6289687736c3dde85e6b43a86171"}],"doc/source/command-objects/address-scope.rst":[{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"4bf40969a3543d7d0fe9ac840f9baddec0eff812","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    os address scope list"},{"line_number":75,"context_line":"        [--name \u003cname\u003e]"},{"line_number":76,"context_line":"        [--ip-version \u003cip-version\u003e]"},{"line_number":77,"context_line":"        [--project \u003cproject\u003e]"},{"line_number":78,"context_line":"        [--project-domain \u003cproject-domain\u003e]"},{"line_number":79,"context_line":"        [--share | --no-share]"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a6eadb0_a5c48192","line":77,"updated":"2016-12-13 13:36:24.000000000","message":"should be:\n    [--project \u003cproject\u003e [--project-domain \u003cproject-domain\u003e]]","commit_id":"14fb5f432e58399958733f20e46ec87733193f10"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"9930129e422721c8e95a311e9f5e17c5d7c17e9b","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":".. option:: --ip-version \u003cip-version\u003e"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    List address scopes of given IP version networks(4 or 6)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":".. option:: --project \u003cproject\u003e"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a6eadb0_689ee764","line":86,"range":{"start_line":86,"start_character":52,"end_line":86,"end_character":53},"updated":"2016-12-18 11:42:13.000000000","message":"nit: missing one space here","commit_id":"9419857f534d094667c2f25072fed8145fbff261"}],"openstackclient/network/v2/address_scope.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"027f793d360abbc23b56060fa55502b55091a6c8","unresolved":false,"context_lines":[{"line_number":199,"context_line":"            attrs[\u0027name\u0027] \u003d parsed_args.name"},{"line_number":200,"context_line":"        if parsed_args.ip_version:"},{"line_number":201,"context_line":"            attrs[\u0027ip_version\u0027] \u003d parsed_args.ip_version"},{"line_number":202,"context_line":"        if parsed_args.share:"},{"line_number":203,"context_line":"            attrs[\u0027shared\u0027] \u003d True"},{"line_number":204,"context_line":"        if parsed_args.no_share:"},{"line_number":205,"context_line":"            attrs[\u0027shared\u0027] \u003d False"},{"line_number":206,"context_line":"        if \u0027project\u0027 in parsed_args and parsed_args.project is not None:"},{"line_number":207,"context_line":"            identity_client \u003d self.app.client_manager.identity"},{"line_number":208,"context_line":"            project_id \u003d identity_common.find_project("},{"line_number":209,"context_line":"                identity_client,"},{"line_number":210,"context_line":"                parsed_args.project,"},{"line_number":211,"context_line":"                parsed_args.project_domain,"},{"line_number":212,"context_line":"            ).id"},{"line_number":213,"context_line":"            attrs[\u0027tenant_id\u0027] \u003d project_id"},{"line_number":214,"context_line":"        data \u003d client.address_scopes(**attrs)"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        return (column_headers,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_1e12e6b4","line":213,"range":{"start_line":202,"start_character":0,"end_line":213,"end_character":43},"updated":"2016-10-27 14:48:49.000000000","message":"Please see the SDK refactor work being done under https://review.openstack.org/#/c/382052/.  I would prefer that we merge the SDK refactor for address scope and then update this patch to correctly set the filters.","commit_id":"20e5a943e292768001a679390b01891ef6b4c7ac"},{"author":{"_account_id":19644,"name":"Yan Xing\u0027an","email":"yanxingan@cmss.chinamobile.com","username":"yanxingan"},"change_message_id":"3d080e0cf592de15aad43e579466db40ee639288","unresolved":false,"context_lines":[{"line_number":199,"context_line":"            attrs[\u0027name\u0027] \u003d parsed_args.name"},{"line_number":200,"context_line":"        if parsed_args.ip_version:"},{"line_number":201,"context_line":"            attrs[\u0027ip_version\u0027] \u003d parsed_args.ip_version"},{"line_number":202,"context_line":"        if parsed_args.share:"},{"line_number":203,"context_line":"            attrs[\u0027shared\u0027] \u003d True"},{"line_number":204,"context_line":"        if parsed_args.no_share:"},{"line_number":205,"context_line":"            attrs[\u0027shared\u0027] \u003d False"},{"line_number":206,"context_line":"        if \u0027project\u0027 in parsed_args and parsed_args.project is not None:"},{"line_number":207,"context_line":"            identity_client \u003d self.app.client_manager.identity"},{"line_number":208,"context_line":"            project_id \u003d identity_common.find_project("},{"line_number":209,"context_line":"                identity_client,"},{"line_number":210,"context_line":"                parsed_args.project,"},{"line_number":211,"context_line":"                parsed_args.project_domain,"},{"line_number":212,"context_line":"            ).id"},{"line_number":213,"context_line":"            attrs[\u0027tenant_id\u0027] \u003d project_id"},{"line_number":214,"context_line":"        data \u003d client.address_scopes(**attrs)"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        return (column_headers,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_db49518d","line":213,"range":{"start_line":202,"start_character":0,"end_line":213,"end_character":43},"in_reply_to":"ba5da102_1e12e6b4","updated":"2016-10-28 08:09:56.000000000","message":"Ok, thanks. After https://review.openstack.org/#/c/382052/ merged, i will update this patch.","commit_id":"20e5a943e292768001a679390b01891ef6b4c7ac"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"4bf40969a3543d7d0fe9ac840f9baddec0eff812","unresolved":false,"context_lines":[{"line_number":157,"context_line":"            choices\u003d[4, 6],"},{"line_number":158,"context_line":"            metavar\u003d\u0027\u003cip-version\u003e\u0027,"},{"line_number":159,"context_line":"            dest\u003d\u0027ip_version\u0027,"},{"line_number":160,"context_line":"            help\u003d_(\"List address scopes of given IP version networks\")"},{"line_number":161,"context_line":"        )"},{"line_number":162,"context_line":"        parser.add_argument("},{"line_number":163,"context_line":"            \u0027--project\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_0501b5ae","line":160,"updated":"2016-12-13 13:36:24.000000000","message":"Please add the choices in the help message:\n    \"(4 or 6)\"","commit_id":"14fb5f432e58399958733f20e46ec87733193f10"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"4bf40969a3543d7d0fe9ac840f9baddec0eff812","unresolved":false,"context_lines":[{"line_number":207,"context_line":"        if parsed_args.no_share:"},{"line_number":208,"context_line":"            attrs[\u0027shared\u0027] \u003d False"},{"line_number":209,"context_line":"            attrs[\u0027is_shared\u0027] \u003d False"},{"line_number":210,"context_line":"        if \u0027project\u0027 in parsed_args and parsed_args.project is not None:"},{"line_number":211,"context_line":"            identity_client \u003d self.app.client_manager.identity"},{"line_number":212,"context_line":"            project_id \u003d identity_common.find_project("},{"line_number":213,"context_line":"                identity_client,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_a5ce4181","line":210,"range":{"start_line":210,"start_character":11,"end_line":210,"end_character":35},"updated":"2016-12-13 13:36:24.000000000","message":"\u0027project\u0027 will always in parsed_args","commit_id":"14fb5f432e58399958733f20e46ec87733193f10"},{"author":{"_account_id":19644,"name":"Yan Xing\u0027an","email":"yanxingan@cmss.chinamobile.com","username":"yanxingan"},"change_message_id":"27279ef74a700851fc7e365e6a75c58bffc58461","unresolved":false,"context_lines":[{"line_number":207,"context_line":"        if parsed_args.no_share:"},{"line_number":208,"context_line":"            attrs[\u0027shared\u0027] \u003d False"},{"line_number":209,"context_line":"            attrs[\u0027is_shared\u0027] \u003d False"},{"line_number":210,"context_line":"        if \u0027project\u0027 in parsed_args and parsed_args.project is not None:"},{"line_number":211,"context_line":"            identity_client \u003d self.app.client_manager.identity"},{"line_number":212,"context_line":"            project_id \u003d identity_common.find_project("},{"line_number":213,"context_line":"                identity_client,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_632dfca6","line":210,"range":{"start_line":210,"start_character":11,"end_line":210,"end_character":35},"in_reply_to":"1a6eadb0_a5ce4181","updated":"2016-12-13 14:41:26.000000000","message":"This line refers to the _get_attrs() in this file:\nif \u0027project\u0027 in parsed_args and parsed_args.project is not None:","commit_id":"14fb5f432e58399958733f20e46ec87733193f10"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"6320c61f9baaa8dbce29c02696dcde70aaaed5fd","unresolved":false,"context_lines":[{"line_number":140,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"class ListAddressScope(command.Lister):"},{"line_number":144,"context_line":"    _description \u003d _(\"List address scopes\")"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def get_parser(self, prog_name):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_4b9ecdb9","line":143,"updated":"2016-12-15 21:52:53.000000000","message":"Please add a TODO here for the SDK refactor cleanup needed.","commit_id":"28397c4e5790b6e4762f664b79712f32044662e3"},{"author":{"_account_id":19644,"name":"Yan Xing\u0027an","email":"yanxingan@cmss.chinamobile.com","username":"yanxingan"},"change_message_id":"b643adf6cccd5e4e4b4ba70f3d7f0f4140d7437c","unresolved":false,"context_lines":[{"line_number":140,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"class ListAddressScope(command.Lister):"},{"line_number":144,"context_line":"    _description \u003d _(\"List address scopes\")"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def get_parser(self, prog_name):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_54f74558","line":143,"in_reply_to":"1a6eadb0_4b9ecdb9","updated":"2016-12-16 03:05:53.000000000","message":"# Use the SDK resource mapped attribute names once the\n# OSC minimum requirements include SDK 1.0.\nAdd this line? No other modules add this line at List command.","commit_id":"28397c4e5790b6e4762f664b79712f32044662e3"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"11284e52ac84a4519aca70203114bf9639822553","unresolved":false,"context_lines":[{"line_number":140,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"class ListAddressScope(command.Lister):"},{"line_number":144,"context_line":"    _description \u003d _(\"List address scopes\")"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def get_parser(self, prog_name):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_d51de673","line":143,"in_reply_to":"1a6eadb0_54f74558","updated":"2016-12-16 23:02:36.000000000","message":"That\u0027s it.  And yes, other modules have this: https://review.openstack.org/#/c/407324/.","commit_id":"28397c4e5790b6e4762f664b79712f32044662e3"},{"author":{"_account_id":19644,"name":"Yan Xing\u0027an","email":"yanxingan@cmss.chinamobile.com","username":"yanxingan"},"change_message_id":"042c16835064c9469fa1664db54abc9062d600e9","unresolved":false,"context_lines":[{"line_number":140,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"class ListAddressScope(command.Lister):"},{"line_number":144,"context_line":"    _description \u003d _(\"List address scopes\")"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def get_parser(self, prog_name):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_3b7a89bd","line":143,"in_reply_to":"1a6eadb0_d51de673","updated":"2016-12-17 01:11:05.000000000","message":"Ok. Thank you, Richard.","commit_id":"28397c4e5790b6e4762f664b79712f32044662e3"}],"releasenotes/notes/bug-1636046-98dc0e69a4e44850.yaml":[{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"4bf40969a3543d7d0fe9ac840f9baddec0eff812","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add ``--name``, ``--ip-version``, ``--project``, ``project-domain``, ``--share``, ``--no-share`` options to the ``address scope list`` command."},{"line_number":5,"context_line":"    [Bug `1636046 \u003chttps://bugs.launchpad.net/bugs/1636046\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1a6eadb0_2f23ebbe","line":4,"range":{"start_line":4,"start_character":55,"end_line":4,"end_character":69},"updated":"2016-12-13 13:36:24.000000000","message":"nit: --project-domain","commit_id":"14fb5f432e58399958733f20e46ec87733193f10"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"4bf40969a3543d7d0fe9ac840f9baddec0eff812","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add ``--name``, ``--ip-version``, ``--project``, ``project-domain``, ``--share``, ``--no-share`` options to the ``address scope list`` command."},{"line_number":5,"context_line":"    [Bug `1636046 \u003chttps://bugs.launchpad.net/bugs/1636046\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1a6eadb0_cf3b57ea","line":4,"updated":"2016-12-13 13:36:24.000000000","message":"you can separate this one line into two lines","commit_id":"14fb5f432e58399958733f20e46ec87733193f10"}]}
