)]}'
{"openstackclient/network/v2/address_scope.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"05a5cc9c6a6757058a928626bc2407275aeab3cd","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    columns \u003d list(item.keys())"},{"line_number":31,"context_line":"    if \u0027tenant_id\u0027 in columns:"},{"line_number":32,"context_line":"        columns.remove(\u0027tenant_id\u0027)"},{"line_number":33,"context_line":"    if \u0027project_id\u0027 not in columns:"},{"line_number":34,"context_line":"        columns.append(\u0027project_id\u0027)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    return tuple(sorted(columns))"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6895a0_72175aed","line":33,"updated":"2016-10-25 12:40:21.000000000","message":"This only needs to be done if tenant_id is in columns.  A similar comment applies throughout.","commit_id":"49632814624e7a73ab431e3b6a87a334ae1675a0"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"7ad797517181b47200333e4dfe5892d4f21477b6","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    columns \u003d list(item.keys())"},{"line_number":31,"context_line":"    if \u0027tenant_id\u0027 in columns:"},{"line_number":32,"context_line":"        columns.remove(\u0027tenant_id\u0027)"},{"line_number":33,"context_line":"    if \u0027project_id\u0027 not in columns:"},{"line_number":34,"context_line":"        columns.append(\u0027project_id\u0027)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    return tuple(sorted(columns))"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6895a0_a659b300","line":33,"in_reply_to":"da6895a0_264da36c","updated":"2016-10-25 13:12:24.000000000","message":"This is due to the SDK mapping of properties.  Please see https://etherpad.openstack.org/p/osc-network-command-sdk-support for details.","commit_id":"49632814624e7a73ab431e3b6a87a334ae1675a0"},{"author":{"_account_id":18321,"name":"Yu Jie","email":"yujie@cmss.chinamobile.com","username":"judy-yu"},"change_message_id":"40d9b7d20a60d164d5eae678e9ec6cd69978cae6","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    columns \u003d list(item.keys())"},{"line_number":31,"context_line":"    if \u0027tenant_id\u0027 in columns:"},{"line_number":32,"context_line":"        columns.remove(\u0027tenant_id\u0027)"},{"line_number":33,"context_line":"    if \u0027project_id\u0027 not in columns:"},{"line_number":34,"context_line":"        columns.append(\u0027project_id\u0027)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    return tuple(sorted(columns))"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6895a0_264da36c","line":33,"in_reply_to":"da6895a0_72175aed","updated":"2016-10-25 13:04:20.000000000","message":"i do not understand when tenant_id is in columns needs append \u0027project_id\u0027. this is the original method which leads to \u0027project_id\u0027 present twice.","commit_id":"49632814624e7a73ab431e3b6a87a334ae1675a0"}],"openstackclient/network/v2/network_rbac.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"7fcf08aa64453d37d0f3f53dd55e1f7b4e9f528c","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        columns.remove(\u0027tenant_id\u0027)"},{"line_number":33,"context_line":"    if \u0027project_id\u0027 not in columns:"},{"line_number":34,"context_line":"        columns.append(\u0027project_id\u0027)"},{"line_number":35,"context_line":"    if \u0027target_tenant\u0027 in columns:"},{"line_number":36,"context_line":"        columns.remove(\u0027target_tenant\u0027)"},{"line_number":37,"context_line":"        columns.append(\u0027target_project_id\u0027)"},{"line_number":38,"context_line":"    return tuple(sorted(columns))"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6895a0_372234ba","line":35,"range":{"start_line":35,"start_character":8,"end_line":35,"end_character":21},"updated":"2016-10-25 12:25:03.000000000","message":"is target_project also returned?","commit_id":"49632814624e7a73ab431e3b6a87a334ae1675a0"},{"author":{"_account_id":18321,"name":"Yu Jie","email":"yujie@cmss.chinamobile.com","username":"judy-yu"},"change_message_id":"f5518ce68688889f88a16b8922c473f26f16604f","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        columns.remove(\u0027tenant_id\u0027)"},{"line_number":33,"context_line":"    if \u0027project_id\u0027 not in columns:"},{"line_number":34,"context_line":"        columns.append(\u0027project_id\u0027)"},{"line_number":35,"context_line":"    if \u0027target_tenant\u0027 in columns:"},{"line_number":36,"context_line":"        columns.remove(\u0027target_tenant\u0027)"},{"line_number":37,"context_line":"        columns.append(\u0027target_project_id\u0027)"},{"line_number":38,"context_line":"    return tuple(sorted(columns))"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6895a0_d2a6660f","line":35,"range":{"start_line":35,"start_character":8,"end_line":35,"end_character":21},"in_reply_to":"da6895a0_372234ba","updated":"2016-10-25 12:31:18.000000000","message":"target_project returned \"*\".\nis it right? i am not familiar with rbac.","commit_id":"49632814624e7a73ab431e3b6a87a334ae1675a0"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"129bb3dd4a60daafa691690f9be93a5f312ddbde","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        columns.remove(\u0027tenant_id\u0027)"},{"line_number":33,"context_line":"    if \u0027project_id\u0027 not in columns:"},{"line_number":34,"context_line":"        columns.append(\u0027project_id\u0027)"},{"line_number":35,"context_line":"    if \u0027target_tenant\u0027 in columns:"},{"line_number":36,"context_line":"        columns.remove(\u0027target_tenant\u0027)"},{"line_number":37,"context_line":"        columns.append(\u0027target_project_id\u0027)"},{"line_number":38,"context_line":"    return tuple(sorted(columns))"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6895a0_f25e0a75","line":35,"range":{"start_line":35,"start_character":8,"end_line":35,"end_character":21},"in_reply_to":"da6895a0_d2a6660f","updated":"2016-10-25 12:52:24.000000000","message":"I don\u0027t see target_project_id duplicated.","commit_id":"49632814624e7a73ab431e3b6a87a334ae1675a0"},{"author":{"_account_id":18321,"name":"Yu Jie","email":"yujie@cmss.chinamobile.com","username":"judy-yu"},"change_message_id":"40d9b7d20a60d164d5eae678e9ec6cd69978cae6","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        columns.remove(\u0027tenant_id\u0027)"},{"line_number":33,"context_line":"    if \u0027project_id\u0027 not in columns:"},{"line_number":34,"context_line":"        columns.append(\u0027project_id\u0027)"},{"line_number":35,"context_line":"    if \u0027target_tenant\u0027 in columns:"},{"line_number":36,"context_line":"        columns.remove(\u0027target_tenant\u0027)"},{"line_number":37,"context_line":"        columns.append(\u0027target_project_id\u0027)"},{"line_number":38,"context_line":"    return tuple(sorted(columns))"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6895a0_66007b02","line":35,"range":{"start_line":35,"start_character":8,"end_line":35,"end_character":21},"in_reply_to":"da6895a0_f25e0a75","updated":"2016-10-25 13:04:20.000000000","message":"target_project_id is not duplicated.","commit_id":"49632814624e7a73ab431e3b6a87a334ae1675a0"}],"openstackclient/network/v2/router.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"e6596362d37f6797cb59bd3b0412252896e01fa6","unresolved":false,"context_lines":[{"line_number":216,"context_line":"        obj \u003d client.create_router(**attrs)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        display_columns, columns \u003d _get_columns(obj)"},{"line_number":219,"context_line":"        data \u003d utils.get_item_properties(obj, columns, formatters\u003d{})"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"        return (display_columns, data)"},{"line_number":222,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a74a57a_0a5e4776","line":219,"updated":"2016-11-29 17:55:36.000000000","message":"Why are you removing the formatters?","commit_id":"7612e66a022552f36fa1591252e641b286caea71"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"e6596362d37f6797cb59bd3b0412252896e01fa6","unresolved":false,"context_lines":[{"line_number":524,"context_line":"        client \u003d self.app.client_manager.network"},{"line_number":525,"context_line":"        obj \u003d client.find_router(parsed_args.router, ignore_missing\u003dFalse)"},{"line_number":526,"context_line":"        display_columns, columns \u003d _get_columns(obj)"},{"line_number":527,"context_line":"        data \u003d utils.get_item_properties(obj, columns, formatters\u003d{})"},{"line_number":528,"context_line":""},{"line_number":529,"context_line":"        return (display_columns, data)"},{"line_number":530,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a74a57a_2a53036e","line":527,"updated":"2016-11-29 17:55:36.000000000","message":"Why are you removing the formatters?","commit_id":"7612e66a022552f36fa1591252e641b286caea71"}],"openstackclient/network/v2/security_group_rule.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"6efe3601055bfe4b2f2f816e80227c54ef59fd5a","unresolved":false,"context_lines":[{"line_number":342,"context_line":"        # Create and show the security group rule."},{"line_number":343,"context_line":"        obj \u003d client.create_security_group_rule(**attrs)"},{"line_number":344,"context_line":"        display_columns, columns \u003d _get_columns(obj)"},{"line_number":345,"context_line":"        data \u003d utils.get_item_properties(obj, columns)"},{"line_number":346,"context_line":"        return (display_columns, data)"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"    def take_action_compute(self, client, parsed_args):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a74a57a_e7a17395","line":345,"range":{"start_line":345,"start_character":8,"end_line":345,"end_character":54},"updated":"2016-11-28 23:30:56.000000000","message":"nit: shouldn\u0027t be needed to do this?\n\ndata \u003d utils.get_item_properties(obj, columns, formatters\u003d{})","commit_id":"7612e66a022552f36fa1591252e641b286caea71"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"6efe3601055bfe4b2f2f816e80227c54ef59fd5a","unresolved":false,"context_lines":[{"line_number":598,"context_line":"        obj \u003d client.find_security_group_rule(parsed_args.rule,"},{"line_number":599,"context_line":"                                              ignore_missing\u003dFalse)"},{"line_number":600,"context_line":"        display_columns, columns \u003d _get_columns(obj)"},{"line_number":601,"context_line":"        data \u003d utils.get_item_properties(obj, columns)"},{"line_number":602,"context_line":"        return (display_columns, data)"},{"line_number":603,"context_line":""},{"line_number":604,"context_line":"    def take_action_compute(self, client, parsed_args):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a74a57a_67bc83bb","line":601,"range":{"start_line":601,"start_character":8,"end_line":601,"end_character":54},"updated":"2016-11-28 23:30:56.000000000","message":"ditto: line 345","commit_id":"7612e66a022552f36fa1591252e641b286caea71"}],"openstackclient/network/v2/subnet.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"e6596362d37f6797cb59bd3b0412252896e01fa6","unresolved":false,"context_lines":[{"line_number":324,"context_line":"        attrs \u003d _get_attrs(self.app.client_manager, parsed_args)"},{"line_number":325,"context_line":"        obj \u003d client.create_subnet(**attrs)"},{"line_number":326,"context_line":"        display_columns, columns \u003d _get_columns(obj)"},{"line_number":327,"context_line":"        data \u003d utils.get_item_properties(obj, columns, formatters\u003d{})"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"        return (display_columns, data)"},{"line_number":330,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a74a57a_8a4a57ab","line":327,"updated":"2016-11-29 17:55:36.000000000","message":"Why are you removing the formatters?","commit_id":"7612e66a022552f36fa1591252e641b286caea71"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"e6596362d37f6797cb59bd3b0412252896e01fa6","unresolved":false,"context_lines":[{"line_number":566,"context_line":"        obj \u003d self.app.client_manager.network.find_subnet(parsed_args.subnet,"},{"line_number":567,"context_line":"                                                          ignore_missing\u003dFalse)"},{"line_number":568,"context_line":"        display_columns, columns \u003d _get_columns(obj)"},{"line_number":569,"context_line":"        data \u003d utils.get_item_properties(obj, columns, formatters\u003d{})"},{"line_number":570,"context_line":""},{"line_number":571,"context_line":"        return (display_columns, data)"},{"line_number":572,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a74a57a_aac5530b","line":569,"updated":"2016-11-29 17:55:36.000000000","message":"Why are you removing the formatters?","commit_id":"7612e66a022552f36fa1591252e641b286caea71"}]}