)]}'
{"doc/source/command-objects/volume-backup.rst":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"58f0cac63558e223df8bf7e2c272c080be352c92","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":".. options:: --volume \u003cvolume\u003e"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    Filters results by the volume which they backup for (name or ID)\""},{"line_number":115,"context_line":""},{"line_number":116,"context_line":".. options:: --marker \u003cmarker\u003e"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a629dbe_52fe116c","line":114,"range":{"start_line":114,"start_character":52,"end_line":114,"end_character":55},"updated":"2016-11-08 03:00:29.000000000","message":"can probably remove this word","commit_id":"0d84060d8770c03438f1b24b6b8183c31f2bef9d"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"a9ea275c97fcf64266f1f871db64c2853bedd0cd","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":".. options:: --volume \u003cvolume\u003e"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    Filters results by the volume which they backup for (name or ID)\""},{"line_number":115,"context_line":""},{"line_number":116,"context_line":".. options:: --marker \u003cmarker\u003e"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a629dbe_10565129","line":114,"range":{"start_line":114,"start_character":52,"end_line":114,"end_character":55},"in_reply_to":"9a629dbe_52fe116c","updated":"2016-11-08 04:46:05.000000000","message":"oh, I will modify it, thank you!","commit_id":"0d84060d8770c03438f1b24b6b8183c31f2bef9d"}],"openstackclient/tests/unit/volume/v1/test_backup.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"5135e4b991290e12026402ac26885a0231d0d8eb","unresolved":false,"context_lines":[{"line_number":270,"context_line":"            \"status\": None,"},{"line_number":271,"context_line":"            \"volume_id\": None,"},{"line_number":272,"context_line":"        }"},{"line_number":273,"context_line":"        self.volumes_mock.get.assert_not_called"},{"line_number":274,"context_line":"        self.backups_mock.list.assert_called_with("},{"line_number":275,"context_line":"            search_opts\u003dsearch_opts,"},{"line_number":276,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_d2211dfd","line":273,"updated":"2016-11-08 16:40:34.000000000","message":"Hummmm ... :) You are missing a \"()\" here.\n\nI\u0027ve fixed this in https://review.openstack.org/#/c/393732","commit_id":"e07b0e0919784b48dc47ae9cd8836342b8c13480"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"86ab84c3b51e02b3c87ed052645904c41f0a9f28","unresolved":false,"context_lines":[{"line_number":270,"context_line":"            \"status\": None,"},{"line_number":271,"context_line":"            \"volume_id\": None,"},{"line_number":272,"context_line":"        }"},{"line_number":273,"context_line":"        self.volumes_mock.get.assert_not_called"},{"line_number":274,"context_line":"        self.backups_mock.list.assert_called_with("},{"line_number":275,"context_line":"            search_opts\u003dsearch_opts,"},{"line_number":276,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_2f373de4","line":273,"in_reply_to":"9a629dbe_d2211dfd","updated":"2016-11-09 03:05:39.000000000","message":"Thank you very much :)","commit_id":"e07b0e0919784b48dc47ae9cd8836342b8c13480"}],"openstackclient/volume/v1/backup.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"58f0cac63558e223df8bf7e2c272c080be352c92","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        if parsed_args.volume:"},{"line_number":212,"context_line":"            filter_volume_id \u003d utils.find_resource(volume_client.volumes,"},{"line_number":213,"context_line":"                                                   parsed_args.volume).id"},{"line_number":214,"context_line":"        search_opts \u003d {"},{"line_number":215,"context_line":"            \u0027name\u0027: parsed_args.name,"},{"line_number":216,"context_line":"            \u0027status\u0027: parsed_args.status,"},{"line_number":217,"context_line":"            \u0027volume_id\u0027: filter_volume_id,"},{"line_number":218,"context_line":"        }"},{"line_number":219,"context_line":"        data \u003d volume_client.backups.list("},{"line_number":220,"context_line":"            search_opts\u003dsearch_opts,"},{"line_number":221,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_926d0935","line":218,"range":{"start_line":214,"start_character":8,"end_line":218,"end_character":9},"updated":"2016-11-08 03:00:29.000000000","message":"i think this works because these will all default to None, right?","commit_id":"0d84060d8770c03438f1b24b6b8183c31f2bef9d"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"a9ea275c97fcf64266f1f871db64c2853bedd0cd","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        if parsed_args.volume:"},{"line_number":212,"context_line":"            filter_volume_id \u003d utils.find_resource(volume_client.volumes,"},{"line_number":213,"context_line":"                                                   parsed_args.volume).id"},{"line_number":214,"context_line":"        search_opts \u003d {"},{"line_number":215,"context_line":"            \u0027name\u0027: parsed_args.name,"},{"line_number":216,"context_line":"            \u0027status\u0027: parsed_args.status,"},{"line_number":217,"context_line":"            \u0027volume_id\u0027: filter_volume_id,"},{"line_number":218,"context_line":"        }"},{"line_number":219,"context_line":"        data \u003d volume_client.backups.list("},{"line_number":220,"context_line":"            search_opts\u003dsearch_opts,"},{"line_number":221,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_1091f1f0","line":218,"range":{"start_line":214,"start_character":8,"end_line":218,"end_character":9},"in_reply_to":"9a629dbe_926d0935","updated":"2016-11-08 04:46:05.000000000","message":"Yes, it is similar to the cinderclient:\nhttps://github.com/openstack/python-cinderclient/blob/master/cinderclient/v3/shell.py#L1695-L1700\nAnd also the same as we did otherwhere in OSC","commit_id":"0d84060d8770c03438f1b24b6b8183c31f2bef9d"}],"openstackclient/volume/v2/backup.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"58f0cac63558e223df8bf7e2c272c080be352c92","unresolved":false,"context_lines":[{"line_number":263,"context_line":"        data \u003d volume_client.backups.list("},{"line_number":264,"context_line":"            search_opts\u003dsearch_opts,"},{"line_number":265,"context_line":"            marker\u003dmarker_backup_id,"},{"line_number":266,"context_line":"            limit\u003dparsed_args.limit,"},{"line_number":267,"context_line":"        )"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"        return (column_headers,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_1279f9fc","line":266,"range":{"start_line":266,"start_character":12,"end_line":266,"end_character":35},"updated":"2016-11-08 03:00:29.000000000","message":"i think this is OK because the limit should default to None","commit_id":"0d84060d8770c03438f1b24b6b8183c31f2bef9d"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"a9ea275c97fcf64266f1f871db64c2853bedd0cd","unresolved":false,"context_lines":[{"line_number":263,"context_line":"        data \u003d volume_client.backups.list("},{"line_number":264,"context_line":"            search_opts\u003dsearch_opts,"},{"line_number":265,"context_line":"            marker\u003dmarker_backup_id,"},{"line_number":266,"context_line":"            limit\u003dparsed_args.limit,"},{"line_number":267,"context_line":"        )"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"        return (column_headers,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_706dcd03","line":266,"range":{"start_line":266,"start_character":12,"end_line":266,"end_character":35},"in_reply_to":"9a629dbe_1279f9fc","updated":"2016-11-08 04:46:05.000000000","message":"Yes you are right, it is similar to the cinderclient:\nhttps://github.com/openstack/python-cinderclient/blob/master/cinderclient/v3/shell.py#L1704\nAnd also the same as we did otherwhere in OSC","commit_id":"0d84060d8770c03438f1b24b6b8183c31f2bef9d"}]}