)]}'
{"id":"openstack%2Fpython-openstackclient~395790","triplet_id":"openstack%2Fpython-openstackclient~master~Ibe5976f722c4eb966b12a7b1e1c2702fd08ce84b","project":"openstack/python-openstackclient","branch":"master","topic":"bug/1635518","hashtags":[],"change_id":"Ibe5976f722c4eb966b12a7b1e1c2702fd08ce84b","subject":"Show disk format vhdx in help","status":"MERGED","created":"2016-11-09 20:38:38.000000000","updated":"2016-11-22 15:39:47.000000000","submitted":"2016-11-22 15:39:47.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"e54e97b09c87d2cd521818d7ac39cc9b41b28490","_number":395790,"virtual_id_number":395790,"owner":{"_account_id":24101,"name":"Jaspreet Singh Rawel","email":"jaspreetsinghrawel@gmail.com","username":"jaspreetrawel"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2016-11-22 15:39:47.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},{"value":0,"_account_id":24101,"name":"Jaspreet Singh Rawel","email":"jaspreetsinghrawel@gmail.com","username":"jaspreetrawel"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":2,"date":"2016-11-15 01:30:37.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-11-15 08:38:24.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},{"value":0,"_account_id":24101,"name":"Jaspreet Singh Rawel","email":"jaspreetsinghrawel@gmail.com","username":"jaspreetrawel"},{"value":2,"date":"2016-11-22 14:47:41.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":1,"date":"2016-11-15 04:52:44.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},{"value":0,"_account_id":24101,"name":"Jaspreet Singh Rawel","email":"jaspreetsinghrawel@gmail.com","username":"jaspreetrawel"},{"value":1,"date":"2016-11-22 14:47:41.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},{"_account_id":24101,"name":"Jaspreet Singh Rawel","email":"jaspreetsinghrawel@gmail.com","username":"jaspreetrawel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-11-15 01:30:37.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2016-11-15 04:52:44.000000000","updated_by":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"reviewer":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"state":"REVIEWER"},{"updated":"2016-11-15 08:38:24.000000000","updated_by":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"reviewer":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"state":"REVIEWER"},{"updated":"2016-11-22 14:47:41.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2016-11-22 15:39:47.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"6a667b47761a74065e1a6e8c59866d604a4d6027","author":{"_account_id":24101,"name":"Jaspreet Singh Rawel","email":"jaspreetsinghrawel@gmail.com","username":"jaspreetrawel"},"date":"2016-11-09 20:38:38.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7d8c523974202a96cd2bb03371e024a02456d74b","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-11-09 20:46:59.000000000","message":"Patch Set 1: Code-Review+2\n\nso this is fine to add, but it looks like theres more work for us here. the v1 create command doesn\u0027t specify disk-formats (https://github.com/openstack/python-openstackclient/blob/master/openstackclient/image/v1/image.py#L89-L91) and the v2 create and set commands do not specify disk formats either: https://github.com/openstack/python-openstackclient/blob/master/openstackclient/image/v2/image.py#L141-L143","accounts_in_message":[],"_revision_number":1},{"id":"c4c1431ff2a2569a437a8ddf04f1cba0fa92b405","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-09 21:29:36.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/90/395790/1/check/gate-python-openstackclient-docs-ubuntu-xenial/faf610a//doc/build/html/ : SUCCESS in 3m 07s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/90/395790/1/check/gate-python-openstackclient-pep8-ubuntu-xenial/17dc25f/ : SUCCESS in 2m 43s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/90/395790/1/check/gate-python-openstackclient-python27-ubuntu-xenial/d0426ec/ : SUCCESS in 4m 51s\n- gate-python-openstackclient-python34 http://logs.openstack.org/90/395790/1/check/gate-python-openstackclient-python34/eb748e6/ : SUCCESS in 2m 49s\n- gate-python-openstackclient-python35-nv http://logs.openstack.org/90/395790/1/check/gate-python-openstackclient-python35-nv/88a5c19/ : SUCCESS in 2m 37s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/90/395790/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/458cf90/ : SUCCESS in 43m 16s\n- check-osc-plugins http://logs.openstack.org/90/395790/1/check/check-osc-plugins/a81a381/ : SUCCESS in 3m 25s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/90/395790/1/check/gate-osc-dsvm-functional/4b63212/ : SUCCESS in 15m 14s\n- gate-tripleo-ci-centos-7-nonha-multinode-nv http://logs.openstack.org/90/395790/1/check/gate-tripleo-ci-centos-7-nonha-multinode-nv/f6e49e0/ : SUCCESS in 50m 45s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"5ece2d5936fd4a53a2c83cd37f3e570f8122d726","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2016-11-10 16:56:40.000000000","message":"Patch Set 1: Code-Review-1\n\nSince it is a straightforward fix, please get create and set commands for both v1 and v2 to match.  Also update the docs.","accounts_in_message":[],"_revision_number":1},{"id":"f261d0ee7542c151f08fac45934b87dd8fb412eb","author":{"_account_id":24101,"name":"Jaspreet Singh Rawel","email":"jaspreetsinghrawel@gmail.com","username":"jaspreetrawel"},"date":"2016-11-11 06:32:55.000000000","message":"Patch Set 1:\n\nDean, the changes that you have requested have been done as part of https://review.openstack.org/#/c/395796/2","accounts_in_message":[],"_revision_number":1},{"id":"1d53fe42464e048914a6c809cf72e6128a9c58ef","author":{"_account_id":24101,"name":"Jaspreet Singh Rawel","email":"jaspreetsinghrawel@gmail.com","username":"jaspreetrawel"},"date":"2016-11-11 07:08:57.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"9e867c95727ae626c4910b8a50ae55138b82d875","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-11 08:15:15.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/90/395790/2/check/gate-python-openstackclient-docs-ubuntu-xenial/d581cea//doc/build/html/ : SUCCESS in 2m 47s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/90/395790/2/check/gate-python-openstackclient-pep8-ubuntu-xenial/d037909/ : SUCCESS in 2m 34s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/90/395790/2/check/gate-python-openstackclient-python27-ubuntu-xenial/8b407be/ : SUCCESS in 2m 37s\n- gate-python-openstackclient-python34 http://logs.openstack.org/90/395790/2/check/gate-python-openstackclient-python34/d9326dd/ : SUCCESS in 5m 01s\n- gate-python-openstackclient-python35-nv http://logs.openstack.org/90/395790/2/check/gate-python-openstackclient-python35-nv/807d6b5/ : SUCCESS in 2m 37s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/90/395790/2/check/gate-tempest-dsvm-neutron-src-python-openstackclient/77c1062/ : SUCCESS in 43m 55s\n- check-osc-plugins http://logs.openstack.org/90/395790/2/check/check-osc-plugins/bf7da19/ : SUCCESS in 3m 13s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/90/395790/2/check/gate-osc-dsvm-functional/6a7f6f0/ : SUCCESS in 29m 30s\n- gate-tripleo-ci-centos-7-nonha-multinode-nv http://logs.openstack.org/90/395790/2/check/gate-tripleo-ci-centos-7-nonha-multinode-nv/50e4647/ : SUCCESS in 1h 06m 03s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"e3d563dae69f3eef9428300325bcc649863a7736","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-11-15 01:30:37.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"a30586724977256f22909cab6dd8a2e3014baa08","author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"date":"2016-11-15 04:52:44.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"3fccdb227af711e6a83019823332c8187877f8d8","author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"date":"2016-11-15 08:38:24.000000000","message":"Patch Set 2: Code-Review+1\n\nThank you sharing the related patch https://review.openstack.org/#/c/395796 , Jaspreet, LGTM.","accounts_in_message":[],"_revision_number":2},{"id":"db0cf0dceff9f8e9748221364dd02ce126e4f309","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2016-11-22 14:47:41.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"6dd8fa51f8cf6656c6365f26defc5f0a8fb5b8f3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-22 14:47:51.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"db4c59245da7872b64708ae748c18eadec6153bd","date":"2016-11-22 15:39:47.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"48249a8b5e385db15bc4bbda2eefa0bffbcc4724","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-22 15:39:47.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/90/395790/2/gate/gate-python-openstackclient-docs-ubuntu-xenial/c1a6dcb//doc/build/html/ : SUCCESS in 5m 06s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/90/395790/2/gate/gate-python-openstackclient-pep8-ubuntu-xenial/a4e8681/ : SUCCESS in 3m 11s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/90/395790/2/gate/gate-python-openstackclient-python27-ubuntu-xenial/9c19485/ : SUCCESS in 4m 40s\n- gate-python-openstackclient-python34 http://logs.openstack.org/90/395790/2/gate/gate-python-openstackclient-python34/33f2dec/ : SUCCESS in 4m 19s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/90/395790/2/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/2ce46be/ : SUCCESS in 51m 49s\n- gate-osc-dsvm-functional http://logs.openstack.org/90/395790/2/gate/gate-osc-dsvm-functional/ccc716f/ : SUCCESS in 16m 38s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"ff7fda061e4f89744b2c6d237ab913225b2ee14e","revisions":{"e384b95d4148069d5cab79cc0b72eedabb8fe31c":{"kind":"REWORK","_number":1,"created":"2016-11-09 20:38:38.000000000","uploader":{"_account_id":24101,"name":"Jaspreet Singh Rawel","email":"jaspreetsinghrawel@gmail.com","username":"jaspreetrawel"},"ref":"refs/changes/90/395790/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/90/395790/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/90/395790/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/90/395790/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/90/395790/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/90/395790/1"}}},"commit":{"parents":[{"commit":"8b2f25682850ca747dcc0961b894ed5f5644580a","subject":"Merge \"Add \u0027description\u0027 option\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/8b2f25682850ca747dcc0961b894ed5f5644580a"}]}],"author":{"name":"Jaspreet Singh Rawel","email":"jaspreetsinghrawel@gmail.com","date":"2016-11-09 20:35:54.000000000","tz":330},"committer":{"name":"Jaspreet Singh Rawel","email":"jaspreetsinghrawel@gmail.com","date":"2016-11-09 20:37:40.000000000","tz":330},"subject":"show disk format vhdx in help","message":"show disk format vhdx in help\n\nCurrently disk format type vhdx is missing in help.\n\nCloses-Bug: 1635518\n\nChange-Id: Ibe5976f722c4eb966b12a7b1e1c2702fd08ce84b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/e384b95d4148069d5cab79cc0b72eedabb8fe31c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/e384b95d4148069d5cab79cc0b72eedabb8fe31c"}]},"branch":"refs/heads/master"},"ff7fda061e4f89744b2c6d237ab913225b2ee14e":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2016-11-11 07:08:57.000000000","uploader":{"_account_id":24101,"name":"Jaspreet Singh Rawel","email":"jaspreetsinghrawel@gmail.com","username":"jaspreetrawel"},"ref":"refs/changes/90/395790/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/90/395790/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/90/395790/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/90/395790/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/90/395790/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/90/395790/2"}}},"commit":{"parents":[{"commit":"8b2f25682850ca747dcc0961b894ed5f5644580a","subject":"Merge \"Add \u0027description\u0027 option\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/8b2f25682850ca747dcc0961b894ed5f5644580a"}]}],"author":{"name":"Jaspreet Singh Rawel","email":"jaspreetsinghrawel@gmail.com","date":"2016-11-09 20:35:54.000000000","tz":330},"committer":{"name":"Jaspreet Singh Rawel","email":"jaspreetsinghrawel@gmail.com","date":"2016-11-11 07:08:37.000000000","tz":330},"subject":"Show disk format vhdx in help","message":"Show disk format vhdx in help\n\nCurrently disk format type vhdx is missing in help.\n\nCloses-Bug: 1635518\n\nChange-Id: Ibe5976f722c4eb966b12a7b1e1c2702fd08ce84b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/ff7fda061e4f89744b2c6d237ab913225b2ee14e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/ff7fda061e4f89744b2c6d237ab913225b2ee14e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
