)]}'
{"doc/source/command-objects/port.rst":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"33a32a15a69c10e80a684604fe760c8eabecf04e","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        [--name \u003cname\u003e]"},{"line_number":172,"context_line":"        [--security-group \u003csecurity-group\u003e]"},{"line_number":173,"context_line":"        [--no-security-group]"},{"line_number":174,"context_line":"        [--port_security_enabled]"},{"line_number":175,"context_line":"        \u003cport\u003e"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":".. option:: --fixed-ip subnet\u003d\u003csubnet\u003e,ip-address\u003d\u003cip-address\u003e"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a629dbe_7f961540","line":174,"updated":"2016-11-09 22:53:22.000000000","message":"Please use dashes not underscores\n\nBut actually, this is not a proper option name anyway.  Notice above with the --enable | --disable options, that a) there are two, one for each state, and b) they are present tense (enable), not past tense (enabled).\n\nThis should be --enable-port-security | --disable-port-security","commit_id":"7c3052f9d3223e72cd501f0bb4db06f4e0331a34"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"dc644d24d089d43d795bc1b086f0dfca9bb8e805","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        [--name \u003cname\u003e]"},{"line_number":172,"context_line":"        [--security-group \u003csecurity-group\u003e]"},{"line_number":173,"context_line":"        [--no-security-group]"},{"line_number":174,"context_line":"        [--port_security_enabled]"},{"line_number":175,"context_line":"        \u003cport\u003e"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":".. option:: --fixed-ip subnet\u003d\u003csubnet\u003e,ip-address\u003d\u003cip-address\u003e"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9a629dbe_e3d422ed","line":174,"in_reply_to":"9a629dbe_7f961540","updated":"2016-11-10 20:40:27.000000000","message":"Done","commit_id":"7c3052f9d3223e72cd501f0bb4db06f4e0331a34"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"de412f1a2bd0e03a3581cd68831fbbfffb6fb981","unresolved":false,"context_lines":[{"line_number":240,"context_line":""},{"line_number":241,"context_line":".. option::  --enable-port-security"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    Enable port security for this port (name or ID)"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":".. option::  --disable-port-security"},{"line_number":246,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a629dbe_43d6aef1","line":243,"updated":"2016-11-10 20:40:07.000000000","message":"Boolean. remove (name or ID)","commit_id":"edb01fe2d4223c02bb5bbac8d9756e07678070d2"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"ebd57dd18b899c2215a40cd7e477cd284c9b4488","unresolved":false,"context_lines":[{"line_number":240,"context_line":""},{"line_number":241,"context_line":".. option::  --enable-port-security"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    Enable port security for this port (name or ID)"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":".. option::  --disable-port-security"},{"line_number":246,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a629dbe_007c88ea","line":243,"in_reply_to":"9a629dbe_43d6aef1","updated":"2016-11-11 16:43:41.000000000","message":"Done","commit_id":"edb01fe2d4223c02bb5bbac8d9756e07678070d2"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"916272610d6cba68397c8b363e3e184337863d28","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        [--security-group \u003csecurity-group\u003e]"},{"line_number":173,"context_line":"        [--no-security-group]"},{"line_number":174,"context_line":"        [--enable-port-security]"},{"line_number":175,"context_line":"        [--disable-port-security]"},{"line_number":176,"context_line":"        \u003cport\u003e"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":".. option:: --fixed-ip subnet\u003d\u003csubnet\u003e,ip-address\u003d\u003cip-address\u003e"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a629dbe_abcc8635","line":175,"updated":"2016-11-13 02:56:43.000000000","message":"They are mutually exclusive options. so we should write them like this:\n    [--enable-port-security | --disable-port-security]","commit_id":"fabcb40a90a118a4443b0cd21a233bc6cb013ba7"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"0d5b4dee2d5de2f0a8879dceb623d5814fbfbff3","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        [--security-group \u003csecurity-group\u003e]"},{"line_number":173,"context_line":"        [--no-security-group]"},{"line_number":174,"context_line":"        [--enable-port-security]"},{"line_number":175,"context_line":"        [--disable-port-security]"},{"line_number":176,"context_line":"        \u003cport\u003e"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":".. option:: --fixed-ip subnet\u003d\u003csubnet\u003e,ip-address\u003d\u003cip-address\u003e"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a629dbe_4324a9c5","line":175,"in_reply_to":"9a629dbe_abcc8635","updated":"2016-11-14 03:59:18.000000000","message":"Done","commit_id":"fabcb40a90a118a4443b0cd21a233bc6cb013ba7"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"46b4ea05e062e516509ecb3288e5f4a247c67cc7","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        [--name \u003cname\u003e]"},{"line_number":172,"context_line":"        [--security-group \u003csecurity-group\u003e]"},{"line_number":173,"context_line":"        [--no-security-group]"},{"line_number":174,"context_line":"        [--enable-port-security | --disable-port-security]"},{"line_number":175,"context_line":"        \u003cport\u003e"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":".. option:: --fixed-ip subnet\u003d\u003csubnet\u003e,ip-address\u003d\u003cip-address\u003e"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a629dbe_c1fb3f46","line":174,"updated":"2016-11-14 13:41:14.000000000","message":"I believe this should be supported on create as well.","commit_id":"5f0e06232096901b57e316d2048808279f12b4b1"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"24768a3da70c329c13de296c67937e0e9389eecf","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        [--name \u003cname\u003e]"},{"line_number":172,"context_line":"        [--security-group \u003csecurity-group\u003e]"},{"line_number":173,"context_line":"        [--no-security-group]"},{"line_number":174,"context_line":"        [--enable-port-security | --disable-port-security]"},{"line_number":175,"context_line":"        \u003cport\u003e"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":".. option:: --fixed-ip subnet\u003d\u003csubnet\u003e,ip-address\u003d\u003cip-address\u003e"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7a77a97e_d6dc0449","line":174,"in_reply_to":"9a629dbe_c1fb3f46","updated":"2016-11-14 18:03:40.000000000","message":"Done","commit_id":"5f0e06232096901b57e316d2048808279f12b4b1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"a4f63c5980a975adc98b03aa7ccb34a9bc1a3666","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":".. option::  --enable-port-security"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    Enable port security for this port"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":".. option::  --disable-port-security"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a77a97e_4b59fb59","line":100,"updated":"2016-11-15 16:30:17.000000000","message":"Note that this is the default by adding \"(default)\" to the end of the help.","commit_id":"48688eb4dda037f3f5dc5e917b9263823b074773"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"f3f3c7fe46a370f3f36afe69965652a040490e36","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":".. option::  --enable-port-security"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    Enable port security for this port"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":".. option::  --disable-port-security"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a77a97e_423558d8","line":100,"in_reply_to":"7a77a97e_4b59fb59","updated":"2016-11-15 17:53:47.000000000","message":"Done","commit_id":"48688eb4dda037f3f5dc5e917b9263823b074773"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"5549a12f0662cbb8d16da66eea470de3974096f5","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":".. option::  --enable-port-security"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    Enable port security for this port"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":".. option::  --disable-port-security"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a77a97e_22ccdc88","line":100,"updated":"2016-11-15 18:00:42.000000000","message":"(Default)","commit_id":"a7ef1eec84e03d63b59f3761bb5b3ceca5072bcf"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"9964bcf1ecc335848471557a6e5e1ea754cea32a","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":".. option::  --enable-port-security"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    Enable port security for this port"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":".. option::  --disable-port-security"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a77a97e_a57385e6","line":100,"in_reply_to":"7a77a97e_22ccdc88","updated":"2016-11-16 04:11:23.000000000","message":"Done","commit_id":"a7ef1eec84e03d63b59f3761bb5b3ceca5072bcf"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"5549a12f0662cbb8d16da66eea470de3974096f5","unresolved":false,"context_lines":[{"line_number":248,"context_line":""},{"line_number":249,"context_line":".. option::  --enable-port-security"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    Enable port security for this port (default)"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":".. option::  --disable-port-security"},{"line_number":254,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a77a97e_42a0f89f","line":251,"updated":"2016-11-15 18:00:42.000000000","message":"Don\u0027t think this would be default. Set only will update options given.","commit_id":"a7ef1eec84e03d63b59f3761bb5b3ceca5072bcf"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"919fc2dae1f9da392f89d08f73d76e3238b16887","unresolved":false,"context_lines":[{"line_number":248,"context_line":""},{"line_number":249,"context_line":".. option::  --enable-port-security"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    Enable port security for this port (default)"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":".. option::  --disable-port-security"},{"line_number":254,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a77a97e_82ee9089","line":251,"in_reply_to":"7a77a97e_42a0f89f","updated":"2016-11-15 18:06:22.000000000","message":"Correct, create has the default, not set.","commit_id":"a7ef1eec84e03d63b59f3761bb5b3ceca5072bcf"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"9964bcf1ecc335848471557a6e5e1ea754cea32a","unresolved":false,"context_lines":[{"line_number":248,"context_line":""},{"line_number":249,"context_line":".. option::  --enable-port-security"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    Enable port security for this port (default)"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":".. option::  --disable-port-security"},{"line_number":254,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a77a97e_e57d7db2","line":251,"in_reply_to":"7a77a97e_42a0f89f","updated":"2016-11-16 04:11:23.000000000","message":"Done","commit_id":"a7ef1eec84e03d63b59f3761bb5b3ceca5072bcf"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"9964bcf1ecc335848471557a6e5e1ea754cea32a","unresolved":false,"context_lines":[{"line_number":248,"context_line":""},{"line_number":249,"context_line":".. option::  --enable-port-security"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    Enable port security for this port (default)"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":".. option::  --disable-port-security"},{"line_number":254,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a77a97e_254e9596","line":251,"in_reply_to":"7a77a97e_82ee9089","updated":"2016-11-16 04:11:23.000000000","message":"Done","commit_id":"a7ef1eec84e03d63b59f3761bb5b3ceca5072bcf"}],"openstackclient/network/v2/port.py":[{"author":{"_account_id":20363,"name":"Adit Sarfaty","email":"asarfaty@vmware.com","username":"asarfaty"},"change_message_id":"dd5fbd732e4ca10588dc1888742400578d975b06","unresolved":false,"context_lines":[{"line_number":513,"context_line":"            help\u003d_(\"Clear existing security groups associated with this port\")"},{"line_number":514,"context_line":"        )"},{"line_number":515,"context_line":"        parser.add_argument("},{"line_number":516,"context_line":"            \u0027--port_security_enabled\u0027,"},{"line_number":517,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":518,"context_line":"            help\u003d_(\"Set the port security status to True\")"},{"line_number":519,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_8f4ba486","line":516,"updated":"2016-11-10 11:37:20.000000000","message":"I think it should be --enable-port-security and --disable-port-security like the same parameter for networks","commit_id":"7c3052f9d3223e72cd501f0bb4db06f4e0331a34"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"dc644d24d089d43d795bc1b086f0dfca9bb8e805","unresolved":false,"context_lines":[{"line_number":513,"context_line":"            help\u003d_(\"Clear existing security groups associated with this port\")"},{"line_number":514,"context_line":"        )"},{"line_number":515,"context_line":"        parser.add_argument("},{"line_number":516,"context_line":"            \u0027--port_security_enabled\u0027,"},{"line_number":517,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":518,"context_line":"            help\u003d_(\"Set the port security status to True\")"},{"line_number":519,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_a3fdca6f","line":516,"in_reply_to":"9a629dbe_8f4ba486","updated":"2016-11-10 20:40:27.000000000","message":"Done","commit_id":"7c3052f9d3223e72cd501f0bb4db06f4e0331a34"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"7a0193eca8af79f835634171c875f5451062aa6c","unresolved":false,"context_lines":[{"line_number":515,"context_line":"        parser.add_argument("},{"line_number":516,"context_line":"            \u0027--enable-port-security\u0027,"},{"line_number":517,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":518,"context_line":"            help\u003d_(\"Set the port security status to True\")"},{"line_number":519,"context_line":"        )"},{"line_number":520,"context_line":"        parser.add_argument("},{"line_number":521,"context_line":"            \u0027--disable-port-security\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_a334ea49","line":518,"updated":"2016-11-10 20:40:36.000000000","message":"match the help text in the .rst file","commit_id":"edb01fe2d4223c02bb5bbac8d9756e07678070d2"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"ebd57dd18b899c2215a40cd7e477cd284c9b4488","unresolved":false,"context_lines":[{"line_number":515,"context_line":"        parser.add_argument("},{"line_number":516,"context_line":"            \u0027--enable-port-security\u0027,"},{"line_number":517,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":518,"context_line":"            help\u003d_(\"Set the port security status to True\")"},{"line_number":519,"context_line":"        )"},{"line_number":520,"context_line":"        parser.add_argument("},{"line_number":521,"context_line":"            \u0027--disable-port-security\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_408200c9","line":518,"in_reply_to":"9a629dbe_a334ea49","updated":"2016-11-11 16:43:41.000000000","message":"Done","commit_id":"edb01fe2d4223c02bb5bbac8d9756e07678070d2"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"b60412ab2d9c155ab78b1344a49ff1e4b26ba1b7","unresolved":false,"context_lines":[{"line_number":517,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":518,"context_line":"            help\u003d_(\"Set the port security status to True\")"},{"line_number":519,"context_line":"        )"},{"line_number":520,"context_line":"        parser.add_argument("},{"line_number":521,"context_line":"            \u0027--disable-port-security\u0027,"},{"line_number":522,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":523,"context_line":"            help\u003d_(\"Set the port security status to False\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_42dbff1a","line":520,"updated":"2016-11-11 03:35:42.000000000","message":"I guess these two options are mutually exclusive options, right? if they are, they should be added in a mutually exclusive group.","commit_id":"edb01fe2d4223c02bb5bbac8d9756e07678070d2"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"ebd57dd18b899c2215a40cd7e477cd284c9b4488","unresolved":false,"context_lines":[{"line_number":517,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":518,"context_line":"            help\u003d_(\"Set the port security status to True\")"},{"line_number":519,"context_line":"        )"},{"line_number":520,"context_line":"        parser.add_argument("},{"line_number":521,"context_line":"            \u0027--disable-port-security\u0027,"},{"line_number":522,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":523,"context_line":"            help\u003d_(\"Set the port security status to False\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_608544cd","line":520,"in_reply_to":"9a629dbe_42dbff1a","updated":"2016-11-11 16:43:41.000000000","message":"Done","commit_id":"edb01fe2d4223c02bb5bbac8d9756e07678070d2"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"46b4ea05e062e516509ecb3288e5f4a247c67cc7","unresolved":false,"context_lines":[{"line_number":516,"context_line":"        port_security.add_argument("},{"line_number":517,"context_line":"            \u0027--enable-port-security\u0027,"},{"line_number":518,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":519,"context_line":"            help\u003d_(\"Enable port security for the port\")"},{"line_number":520,"context_line":"        )"},{"line_number":521,"context_line":"        port_security.add_argument("},{"line_number":522,"context_line":"            \u0027--disable-port-security\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a629dbe_01bb7776","line":519,"updated":"2016-11-14 13:41:14.000000000","message":"Please update the help to match the documentation.","commit_id":"5f0e06232096901b57e316d2048808279f12b4b1"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"24768a3da70c329c13de296c67937e0e9389eecf","unresolved":false,"context_lines":[{"line_number":516,"context_line":"        port_security.add_argument("},{"line_number":517,"context_line":"            \u0027--enable-port-security\u0027,"},{"line_number":518,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":519,"context_line":"            help\u003d_(\"Enable port security for the port\")"},{"line_number":520,"context_line":"        )"},{"line_number":521,"context_line":"        port_security.add_argument("},{"line_number":522,"context_line":"            \u0027--disable-port-security\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_16203c49","line":519,"in_reply_to":"9a629dbe_01bb7776","updated":"2016-11-14 18:03:40.000000000","message":"Done","commit_id":"5f0e06232096901b57e316d2048808279f12b4b1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"46b4ea05e062e516509ecb3288e5f4a247c67cc7","unresolved":false,"context_lines":[{"line_number":521,"context_line":"        port_security.add_argument("},{"line_number":522,"context_line":"            \u0027--disable-port-security\u0027,"},{"line_number":523,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":524,"context_line":"            help\u003d_(\"Disable port security for the port\")"},{"line_number":525,"context_line":"        )"},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a629dbe_21c07be0","line":524,"updated":"2016-11-14 13:41:14.000000000","message":"Please update the help to match the documentation.","commit_id":"5f0e06232096901b57e316d2048808279f12b4b1"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"24768a3da70c329c13de296c67937e0e9389eecf","unresolved":false,"context_lines":[{"line_number":521,"context_line":"        port_security.add_argument("},{"line_number":522,"context_line":"            \u0027--disable-port-security\u0027,"},{"line_number":523,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":524,"context_line":"            help\u003d_(\"Disable port security for the port\")"},{"line_number":525,"context_line":"        )"},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_361d3810","line":524,"in_reply_to":"9a629dbe_21c07be0","updated":"2016-11-14 18:03:40.000000000","message":"Done","commit_id":"5f0e06232096901b57e316d2048808279f12b4b1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"a4f63c5980a975adc98b03aa7ccb34a9bc1a3666","unresolved":false,"context_lines":[{"line_number":301,"context_line":"        port_security.add_argument("},{"line_number":302,"context_line":"            \u0027--enable-port-security\u0027,"},{"line_number":303,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":304,"context_line":"            help\u003d_(\"Enable port security for this port\")"},{"line_number":305,"context_line":"        )"},{"line_number":306,"context_line":"        port_security.add_argument("},{"line_number":307,"context_line":"            \u0027--disable-port-security\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_eb400759","line":304,"updated":"2016-11-15 16:30:17.000000000","message":"Note that this is the default by adding \"(default)\" to the end of the help.","commit_id":"48688eb4dda037f3f5dc5e917b9263823b074773"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"f3f3c7fe46a370f3f36afe69965652a040490e36","unresolved":false,"context_lines":[{"line_number":301,"context_line":"        port_security.add_argument("},{"line_number":302,"context_line":"            \u0027--enable-port-security\u0027,"},{"line_number":303,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":304,"context_line":"            help\u003d_(\"Enable port security for this port\")"},{"line_number":305,"context_line":"        )"},{"line_number":306,"context_line":"        port_security.add_argument("},{"line_number":307,"context_line":"            \u0027--disable-port-security\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_824db074","line":304,"in_reply_to":"7a77a97e_eb400759","updated":"2016-11-15 17:53:47.000000000","message":"Done","commit_id":"48688eb4dda037f3f5dc5e917b9263823b074773"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"3abc0026b0b7558bd3fb1a2d287568d39a066db8","unresolved":false,"context_lines":[{"line_number":297,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":298,"context_line":"            help\u003d_(\"Associate no security groups with this port\")"},{"line_number":299,"context_line":"        )"},{"line_number":300,"context_line":"        port_security \u003d parser.add_mutually_exclusive_group()"},{"line_number":301,"context_line":"        port_security.add_argument("},{"line_number":302,"context_line":"            \u0027--enable-port-security\u0027,"},{"line_number":303,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":304,"context_line":"            help\u003d_(\"Enable port security for this port (Default)\")"},{"line_number":305,"context_line":"        )"},{"line_number":306,"context_line":"        port_security.add_argument("},{"line_number":307,"context_line":"            \u0027--disable-port-security\u0027,"},{"line_number":308,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":309,"context_line":"            help\u003d_(\"Disable port security for this port\")"},{"line_number":310,"context_line":"        )"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"        return parser"},{"line_number":313,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7a77a97e_a8643ce5","line":310,"range":{"start_line":300,"start_character":6,"end_line":310,"end_character":9},"updated":"2016-11-16 04:23:11.000000000","message":"isnt this a common code section, which can be put in the updatable args","commit_id":"97e6fc8cf9499dcf54150e39b94f7c357f5dce17"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"f9f64d7008a0d0c0ab2a45cf393ee55565193df9","unresolved":false,"context_lines":[{"line_number":297,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":298,"context_line":"            help\u003d_(\"Associate no security groups with this port\")"},{"line_number":299,"context_line":"        )"},{"line_number":300,"context_line":"        port_security \u003d parser.add_mutually_exclusive_group()"},{"line_number":301,"context_line":"        port_security.add_argument("},{"line_number":302,"context_line":"            \u0027--enable-port-security\u0027,"},{"line_number":303,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":304,"context_line":"            help\u003d_(\"Enable port security for this port (Default)\")"},{"line_number":305,"context_line":"        )"},{"line_number":306,"context_line":"        port_security.add_argument("},{"line_number":307,"context_line":"            \u0027--disable-port-security\u0027,"},{"line_number":308,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":309,"context_line":"            help\u003d_(\"Disable port security for this port\")"},{"line_number":310,"context_line":"        )"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"        return parser"},{"line_number":313,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7a77a97e_9543de41","line":310,"range":{"start_line":300,"start_character":6,"end_line":310,"end_character":9},"in_reply_to":"7a77a97e_a8643ce5","updated":"2016-11-17 20:52:17.000000000","message":"Done","commit_id":"97e6fc8cf9499dcf54150e39b94f7c357f5dce17"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"3abc0026b0b7558bd3fb1a2d287568d39a066db8","unresolved":false,"context_lines":[{"line_number":326,"context_line":"        if parsed_args.no_security_group:"},{"line_number":327,"context_line":"            attrs[\u0027security_groups\u0027] \u003d []"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"        if parsed_args.enable_port_security:"},{"line_number":330,"context_line":"            attrs[\u0027port_security_enabled\u0027] \u003d True"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"        if parsed_args.disable_port_security:"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a77a97e_e8e39431","line":329,"updated":"2016-11-16 04:23:11.000000000","message":"In Line#304, you mentioned enable_port_security is True.\nHowever, the default value of port-security is not satisfied.\nIf I create a port, it would not have any value of port-security, until I create/set with  --enable-port-security\n\nPlease remove the word \"Default\" , as it might be a bit confusing","commit_id":"97e6fc8cf9499dcf54150e39b94f7c357f5dce17"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"f9f64d7008a0d0c0ab2a45cf393ee55565193df9","unresolved":false,"context_lines":[{"line_number":326,"context_line":"        if parsed_args.no_security_group:"},{"line_number":327,"context_line":"            attrs[\u0027security_groups\u0027] \u003d []"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"        if parsed_args.enable_port_security:"},{"line_number":330,"context_line":"            attrs[\u0027port_security_enabled\u0027] \u003d True"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"        if parsed_args.disable_port_security:"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a77a97e_7a70f1dc","line":329,"in_reply_to":"7a77a97e_e8e39431","updated":"2016-11-17 20:52:17.000000000","message":"I am not sure I understand what you are saying, but if a port is created the attribute: \u0027port_security_enabled\u0027 is by default set to true.","commit_id":"97e6fc8cf9499dcf54150e39b94f7c357f5dce17"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"3abc0026b0b7558bd3fb1a2d287568d39a066db8","unresolved":false,"context_lines":[{"line_number":325,"context_line":"                                        for sg in parsed_args.security_groups]"},{"line_number":326,"context_line":"        if parsed_args.no_security_group:"},{"line_number":327,"context_line":"            attrs[\u0027security_groups\u0027] \u003d []"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"        if parsed_args.enable_port_security:"},{"line_number":330,"context_line":"            attrs[\u0027port_security_enabled\u0027] \u003d True"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"        if parsed_args.disable_port_security:"},{"line_number":333,"context_line":"            attrs[\u0027port_security_enabled\u0027] \u003d False"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"        obj \u003d client.create_port(**attrs)"},{"line_number":336,"context_line":"        columns \u003d _get_columns(obj)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a77a97e_289f4cb5","line":333,"range":{"start_line":328,"start_character":0,"end_line":333,"end_character":50},"updated":"2016-11-16 04:23:11.000000000","message":"this is a common code section, and can be put in a single function which can be called later","commit_id":"97e6fc8cf9499dcf54150e39b94f7c357f5dce17"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"f9f64d7008a0d0c0ab2a45cf393ee55565193df9","unresolved":false,"context_lines":[{"line_number":325,"context_line":"                                        for sg in parsed_args.security_groups]"},{"line_number":326,"context_line":"        if parsed_args.no_security_group:"},{"line_number":327,"context_line":"            attrs[\u0027security_groups\u0027] \u003d []"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"        if parsed_args.enable_port_security:"},{"line_number":330,"context_line":"            attrs[\u0027port_security_enabled\u0027] \u003d True"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"        if parsed_args.disable_port_security:"},{"line_number":333,"context_line":"            attrs[\u0027port_security_enabled\u0027] \u003d False"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"        obj \u003d client.create_port(**attrs)"},{"line_number":336,"context_line":"        columns \u003d _get_columns(obj)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a77a97e_60fad744","line":333,"range":{"start_line":328,"start_character":0,"end_line":333,"end_character":50},"in_reply_to":"7a77a97e_289f4cb5","updated":"2016-11-17 20:52:17.000000000","message":"Done","commit_id":"97e6fc8cf9499dcf54150e39b94f7c357f5dce17"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"a71c243288b08fd7798c004e72b5577e7e6766cf","unresolved":false,"context_lines":[{"line_number":235,"context_line":"    port_security.add_argument("},{"line_number":236,"context_line":"        \u0027--enable-port-security\u0027,"},{"line_number":237,"context_line":"        action\u003d\u0027store_true\u0027,"},{"line_number":238,"context_line":"        default\u003dTrue,"},{"line_number":239,"context_line":"        help\u003d_(\"Enable port security for this port (Default)\")"},{"line_number":240,"context_line":"    )"},{"line_number":241,"context_line":"    port_security.add_argument("}],"source_content_type":"text/x-python","patch_set":9,"id":"7a77a97e_7dc26bea","line":238,"updated":"2016-11-18 09:04:28.000000000","message":"Do we really need to set a default here? I guess if a port is created the \u0027port_security_enabled\u0027 is True by default without any setting, right?","commit_id":"7c2ad5e079af0343616bc480858f943f3617ec23"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"84af26f139b06f2fa61657ef0d02ad31f500201b","unresolved":false,"context_lines":[{"line_number":235,"context_line":"    port_security.add_argument("},{"line_number":236,"context_line":"        \u0027--enable-port-security\u0027,"},{"line_number":237,"context_line":"        action\u003d\u0027store_true\u0027,"},{"line_number":238,"context_line":"        default\u003dTrue,"},{"line_number":239,"context_line":"        help\u003d_(\"Enable port security for this port (Default)\")"},{"line_number":240,"context_line":"    )"},{"line_number":241,"context_line":"    port_security.add_argument("}],"source_content_type":"text/x-python","patch_set":9,"id":"7a77a97e_836dc8ce","line":238,"in_reply_to":"7a77a97e_7dc26bea","updated":"2016-11-21 19:52:54.000000000","message":"Correct.","commit_id":"7c2ad5e079af0343616bc480858f943f3617ec23"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"a71c243288b08fd7798c004e72b5577e7e6766cf","unresolved":false,"context_lines":[{"line_number":231,"context_line":"        metavar\u003d\u0027\u003chost-id\u003e\u0027,"},{"line_number":232,"context_line":"        help\u003dargparse.SUPPRESS,"},{"line_number":233,"context_line":"    )"},{"line_number":234,"context_line":"    port_security \u003d parser.add_mutually_exclusive_group()"},{"line_number":235,"context_line":"    port_security.add_argument("},{"line_number":236,"context_line":"        \u0027--enable-port-security\u0027,"},{"line_number":237,"context_line":"        action\u003d\u0027store_true\u0027,"},{"line_number":238,"context_line":"        default\u003dTrue,"},{"line_number":239,"context_line":"        help\u003d_(\"Enable port security for this port (Default)\")"},{"line_number":240,"context_line":"    )"},{"line_number":241,"context_line":"    port_security.add_argument("},{"line_number":242,"context_line":"        \u0027--disable-port-security\u0027,"},{"line_number":243,"context_line":"        action\u003d\u0027store_true\u0027,"},{"line_number":244,"context_line":"        help\u003d_(\"Disable port security for this port\")"},{"line_number":245,"context_line":"    )"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"class CreatePort(command.ShowOne):"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a77a97e_1df2579a","line":245,"range":{"start_line":234,"start_character":0,"end_line":245,"end_character":5},"updated":"2016-11-18 09:04:28.000000000","message":"I do not think this is common code section, create command will have default value, but set command have not, they are a bit different.","commit_id":"7c2ad5e079af0343616bc480858f943f3617ec23"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"84af26f139b06f2fa61657ef0d02ad31f500201b","unresolved":false,"context_lines":[{"line_number":231,"context_line":"        metavar\u003d\u0027\u003chost-id\u003e\u0027,"},{"line_number":232,"context_line":"        help\u003dargparse.SUPPRESS,"},{"line_number":233,"context_line":"    )"},{"line_number":234,"context_line":"    port_security \u003d parser.add_mutually_exclusive_group()"},{"line_number":235,"context_line":"    port_security.add_argument("},{"line_number":236,"context_line":"        \u0027--enable-port-security\u0027,"},{"line_number":237,"context_line":"        action\u003d\u0027store_true\u0027,"},{"line_number":238,"context_line":"        default\u003dTrue,"},{"line_number":239,"context_line":"        help\u003d_(\"Enable port security for this port (Default)\")"},{"line_number":240,"context_line":"    )"},{"line_number":241,"context_line":"    port_security.add_argument("},{"line_number":242,"context_line":"        \u0027--disable-port-security\u0027,"},{"line_number":243,"context_line":"        action\u003d\u0027store_true\u0027,"},{"line_number":244,"context_line":"        help\u003d_(\"Disable port security for this port\")"},{"line_number":245,"context_line":"    )"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"class CreatePort(command.ShowOne):"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a77a97e_c367c0e8","line":245,"range":{"start_line":234,"start_character":0,"end_line":245,"end_character":5},"in_reply_to":"7a77a97e_1df2579a","updated":"2016-11-21 19:52:54.000000000","message":"Makes sense.","commit_id":"7c2ad5e079af0343616bc480858f943f3617ec23"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"92df6b2597c0e91cca2d31bc0bd1b1a8515eb786","unresolved":false,"context_lines":[{"line_number":300,"context_line":"        port_security \u003d parser.add_mutually_exclusive_group()"},{"line_number":301,"context_line":"        port_security.add_argument("},{"line_number":302,"context_line":"            \u0027--enable-port-security\u0027,"},{"line_number":303,"context_line":"            default\u003dTrue,"},{"line_number":304,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":305,"context_line":"            help\u003d_(\"Enable port security for this port (Default)\")"},{"line_number":306,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a77a97e_6b6cfa08","line":303,"range":{"start_line":303,"start_character":12,"end_line":303,"end_character":25},"updated":"2016-11-22 03:08:34.000000000","message":"I think you need not to set a default value here. In this case, if \"--disable-port-security\" is specified, I guess both \"enable-port-security\" and \"disable-port-security\" are \"True\". We will pass the two if condition in line330 and line333, and the last one will be the final value.\nIf the \u0027port_security_enabled\u0027 is True by default without any setting, we need not set a default for it manually.","commit_id":"02558c6185177ce386433e2a68e665d386e647f6"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"f975f2033ab8e70bd5ffd207cc69070cd4ba0f10","unresolved":false,"context_lines":[{"line_number":300,"context_line":"        port_security \u003d parser.add_mutually_exclusive_group()"},{"line_number":301,"context_line":"        port_security.add_argument("},{"line_number":302,"context_line":"            \u0027--enable-port-security\u0027,"},{"line_number":303,"context_line":"            default\u003dTrue,"},{"line_number":304,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":305,"context_line":"            help\u003d_(\"Enable port security for this port (Default)\")"},{"line_number":306,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a74a57a_4d590f5a","line":303,"range":{"start_line":303,"start_character":12,"end_line":303,"end_character":25},"in_reply_to":"5a74a57a_1e812c4b","updated":"2016-11-23 20:54:08.000000000","message":"When a port is created the port_security_enabled attribute will be set to True by default. If \u0027--disable-port-security\u0027 is used while creating a port, parsed_args only contains only \u0027--disable-port-security\u0027 so \u0027port_security_enabled\u0027 will be set to false. The order shouldn\u0027t matter right?","commit_id":"02558c6185177ce386433e2a68e665d386e647f6"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"5afe91d6b57cf5a129ecb2988df281c92f6a00f3","unresolved":false,"context_lines":[{"line_number":300,"context_line":"        port_security \u003d parser.add_mutually_exclusive_group()"},{"line_number":301,"context_line":"        port_security.add_argument("},{"line_number":302,"context_line":"            \u0027--enable-port-security\u0027,"},{"line_number":303,"context_line":"            default\u003dTrue,"},{"line_number":304,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":305,"context_line":"            help\u003d_(\"Enable port security for this port (Default)\")"},{"line_number":306,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a74a57a_7de3cf05","line":303,"range":{"start_line":303,"start_character":12,"end_line":303,"end_character":25},"in_reply_to":"5a74a57a_4d590f5a","updated":"2016-11-24 01:51:12.000000000","message":"I do not think so. If only \"--disable-port-security\" is specified, parsed_args.enable_port_security is still True. Both parsed.args.disable_port_security and parsed.args.enable_port_security are True, you can test it in the unit test.","commit_id":"02558c6185177ce386433e2a68e665d386e647f6"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"909e29d91fcd7130dbb6af87dbfd845bad472527","unresolved":false,"context_lines":[{"line_number":300,"context_line":"        port_security \u003d parser.add_mutually_exclusive_group()"},{"line_number":301,"context_line":"        port_security.add_argument("},{"line_number":302,"context_line":"            \u0027--enable-port-security\u0027,"},{"line_number":303,"context_line":"            default\u003dTrue,"},{"line_number":304,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":305,"context_line":"            help\u003d_(\"Enable port security for this port (Default)\")"},{"line_number":306,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a77a97e_b849d890","line":303,"range":{"start_line":303,"start_character":12,"end_line":303,"end_character":25},"in_reply_to":"7a77a97e_6b6cfa08","updated":"2016-11-22 20:25:51.000000000","message":"I disagree. If the port security driver is enabled when a port is created even if not specified a port will be created with port-security enabled. \n\nThe default\u003dTrue value is overridden if the parser receives one of these options. \n\nIt is similar to the --enable option above.","commit_id":"02558c6185177ce386433e2a68e665d386e647f6"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"61ca3ac7857a7bde23d2ac2783c2e5ed308e0395","unresolved":false,"context_lines":[{"line_number":300,"context_line":"        port_security \u003d parser.add_mutually_exclusive_group()"},{"line_number":301,"context_line":"        port_security.add_argument("},{"line_number":302,"context_line":"            \u0027--enable-port-security\u0027,"},{"line_number":303,"context_line":"            default\u003dTrue,"},{"line_number":304,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":305,"context_line":"            help\u003d_(\"Enable port security for this port (Default)\")"},{"line_number":306,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a74a57a_1e812c4b","line":303,"range":{"start_line":303,"start_character":12,"end_line":303,"end_character":25},"in_reply_to":"7a77a97e_b849d890","updated":"2016-11-23 03:04:54.000000000","message":"Sorry I am not quite understand your option, could you say it more detailed.\n\nI know these two options work now, but just feel a bit weird since the both options are \"True\" and the final result is depend on the order of the if conditions (in line 330 and 333) when only \"--disable-port-security\" is specified.","commit_id":"02558c6185177ce386433e2a68e665d386e647f6"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"92df6b2597c0e91cca2d31bc0bd1b1a8515eb786","unresolved":false,"context_lines":[{"line_number":327,"context_line":"        if parsed_args.no_security_group:"},{"line_number":328,"context_line":"            attrs[\u0027security_groups\u0027] \u003d []"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"        if parsed_args.enable_port_security:"},{"line_number":331,"context_line":"            attrs[\u0027port_security_enabled\u0027] \u003d True"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"        if parsed_args.disable_port_security:"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a77a97e_0b2c66aa","line":330,"updated":"2016-11-22 03:08:34.000000000","message":"This code section is the same as line584-589, so I think this can be moved to the \"_get_attrs()\" as a common code","commit_id":"02558c6185177ce386433e2a68e665d386e647f6"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"ec3909beb9743006be62eb54ab86f921725bb4d9","unresolved":false,"context_lines":[{"line_number":307,"context_line":"        port_security.add_argument("},{"line_number":308,"context_line":"            \u0027--enable-port-security\u0027,"},{"line_number":309,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":310,"context_line":"            help\u003d_(\"Enable port security for this port (Default)\")"},{"line_number":311,"context_line":"        )"},{"line_number":312,"context_line":"        port_security.add_argument("},{"line_number":313,"context_line":"            \u0027--disable-port-security\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"5a74a57a_a47059a5","line":310,"updated":"2016-11-28 22:40:01.000000000","message":"nit: Not sure if (Default) is needed of not id default\u003dTrue was taken out.","commit_id":"246f60ab13b57df0cdff2190ebaca316a946f3e7"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"b0e3b2e533d30fd0c12973ad6992daed6078c39e","unresolved":false,"context_lines":[{"line_number":307,"context_line":"        port_security.add_argument("},{"line_number":308,"context_line":"            \u0027--enable-port-security\u0027,"},{"line_number":309,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":310,"context_line":"            help\u003d_(\"Enable port security for this port (Default)\")"},{"line_number":311,"context_line":"        )"},{"line_number":312,"context_line":"        port_security.add_argument("},{"line_number":313,"context_line":"            \u0027--disable-port-security\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a71b18c_e0e127d2","line":310,"in_reply_to":"5a74a57a_a47059a5","updated":"2016-12-01 12:28:36.000000000","message":"Neutron itself creates the port with port_security enabled by default, whether the client asks for it or not, so it\u0027s fine to leave this here.","commit_id":"246f60ab13b57df0cdff2190ebaca316a946f3e7"}],"openstackclient/tests/unit/network/v2/fakes.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"a4f63c5980a975adc98b03aa7ccb34a9bc1a3666","unresolved":false,"context_lines":[{"line_number":437,"context_line":"            \u0027mac_address\u0027: \u0027fa:16:3e:a9:4e:72\u0027,"},{"line_number":438,"context_line":"            \u0027name\u0027: \u0027port-name-\u0027 + uuid.uuid4().hex,"},{"line_number":439,"context_line":"            \u0027network_id\u0027: \u0027network-id-\u0027 + uuid.uuid4().hex,"},{"line_number":440,"context_line":"            \u0027port_security_enabled\u0027: False,"},{"line_number":441,"context_line":"            \u0027security_groups\u0027: [],"},{"line_number":442,"context_line":"            \u0027status\u0027: \u0027ACTIVE\u0027,"},{"line_number":443,"context_line":"            \u0027tenant_id\u0027: \u0027project-id-\u0027 + uuid.uuid4().hex,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_ae045d15","line":440,"updated":"2016-11-15 16:30:17.000000000","message":"Why is this changed?  I believe the default is True in most configurations.","commit_id":"48688eb4dda037f3f5dc5e917b9263823b074773"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"8cda953c879c274411f1c09adafc356e22e87222","unresolved":false,"context_lines":[{"line_number":437,"context_line":"            \u0027mac_address\u0027: \u0027fa:16:3e:a9:4e:72\u0027,"},{"line_number":438,"context_line":"            \u0027name\u0027: \u0027port-name-\u0027 + uuid.uuid4().hex,"},{"line_number":439,"context_line":"            \u0027network_id\u0027: \u0027network-id-\u0027 + uuid.uuid4().hex,"},{"line_number":440,"context_line":"            \u0027port_security_enabled\u0027: False,"},{"line_number":441,"context_line":"            \u0027security_groups\u0027: [],"},{"line_number":442,"context_line":"            \u0027status\u0027: \u0027ACTIVE\u0027,"},{"line_number":443,"context_line":"            \u0027tenant_id\u0027: \u0027project-id-\u0027 + uuid.uuid4().hex,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_eeec95c9","line":440,"in_reply_to":"7a77a97e_ae045d15","updated":"2016-11-15 16:43:38.000000000","message":"Hi Richard, the SDK says default is False [1]. So I made the change here.\n\n[1] https://github.com/openstack/python-openstacksdk/blob/master/openstack/network/v2/port.py#L80","commit_id":"48688eb4dda037f3f5dc5e917b9263823b074773"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"f3f3c7fe46a370f3f36afe69965652a040490e36","unresolved":false,"context_lines":[{"line_number":437,"context_line":"            \u0027mac_address\u0027: \u0027fa:16:3e:a9:4e:72\u0027,"},{"line_number":438,"context_line":"            \u0027name\u0027: \u0027port-name-\u0027 + uuid.uuid4().hex,"},{"line_number":439,"context_line":"            \u0027network_id\u0027: \u0027network-id-\u0027 + uuid.uuid4().hex,"},{"line_number":440,"context_line":"            \u0027port_security_enabled\u0027: False,"},{"line_number":441,"context_line":"            \u0027security_groups\u0027: [],"},{"line_number":442,"context_line":"            \u0027status\u0027: \u0027ACTIVE\u0027,"},{"line_number":443,"context_line":"            \u0027tenant_id\u0027: \u0027project-id-\u0027 + uuid.uuid4().hex,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_0242803e","line":440,"in_reply_to":"7a77a97e_d10cdc96","updated":"2016-11-15 17:53:47.000000000","message":"Done","commit_id":"48688eb4dda037f3f5dc5e917b9263823b074773"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"74ba52926f9d64795b5fdfc5526b5c18981cfc86","unresolved":false,"context_lines":[{"line_number":437,"context_line":"            \u0027mac_address\u0027: \u0027fa:16:3e:a9:4e:72\u0027,"},{"line_number":438,"context_line":"            \u0027name\u0027: \u0027port-name-\u0027 + uuid.uuid4().hex,"},{"line_number":439,"context_line":"            \u0027network_id\u0027: \u0027network-id-\u0027 + uuid.uuid4().hex,"},{"line_number":440,"context_line":"            \u0027port_security_enabled\u0027: False,"},{"line_number":441,"context_line":"            \u0027security_groups\u0027: [],"},{"line_number":442,"context_line":"            \u0027status\u0027: \u0027ACTIVE\u0027,"},{"line_number":443,"context_line":"            \u0027tenant_id\u0027: \u0027project-id-\u0027 + uuid.uuid4().hex,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_d10cdc96","line":440,"in_reply_to":"7a77a97e_eeec95c9","updated":"2016-11-15 16:58:49.000000000","message":"Please check the neutron code for the default.","commit_id":"48688eb4dda037f3f5dc5e917b9263823b074773"}],"openstackclient/tests/unit/network/v2/test_port.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"3abc0026b0b7558bd3fb1a2d287568d39a066db8","unresolved":false,"context_lines":[{"line_number":318,"context_line":"    def test_create_port_security_enabled(self):"},{"line_number":319,"context_line":"        arglist \u003d ["},{"line_number":320,"context_line":"            \u0027--network\u0027, self._port.network_id,"},{"line_number":321,"context_line":"            \u0027--enable-port-security\u0027,"},{"line_number":322,"context_line":"            \u0027test-port\u0027,"},{"line_number":323,"context_line":"        ]"},{"line_number":324,"context_line":"        verifylist \u003d ["}],"source_content_type":"text/x-python","patch_set":7,"id":"7a77a97e_68806447","line":321,"range":{"start_line":321,"start_character":12,"end_line":321,"end_character":36},"updated":"2016-11-16 04:23:11.000000000","message":"This is the default, right?\nSo it means if we dont specify it, port security would be enabled ?\n\nIf so, can you update the test case for create/set","commit_id":"97e6fc8cf9499dcf54150e39b94f7c357f5dce17"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"f9f64d7008a0d0c0ab2a45cf393ee55565193df9","unresolved":false,"context_lines":[{"line_number":318,"context_line":"    def test_create_port_security_enabled(self):"},{"line_number":319,"context_line":"        arglist \u003d ["},{"line_number":320,"context_line":"            \u0027--network\u0027, self._port.network_id,"},{"line_number":321,"context_line":"            \u0027--enable-port-security\u0027,"},{"line_number":322,"context_line":"            \u0027test-port\u0027,"},{"line_number":323,"context_line":"        ]"},{"line_number":324,"context_line":"        verifylist \u003d ["}],"source_content_type":"text/x-python","patch_set":7,"id":"7a77a97e_7bdfe968","line":321,"range":{"start_line":321,"start_character":12,"end_line":321,"end_character":36},"in_reply_to":"7a77a97e_68806447","updated":"2016-11-17 20:52:17.000000000","message":"Done","commit_id":"97e6fc8cf9499dcf54150e39b94f7c357f5dce17"}],"releasenotes/notes/add-port-security-enabled-to-port-set-82b801d21d45e715.yaml":[{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"916272610d6cba68397c8b363e3e184337863d28","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added ``--enable-port-security`` and ``--disable-port-security``"},{"line_number":5,"context_line":"    option to ``port set`` command."},{"line_number":6,"context_line":"    [Blueprint :oscbp:`network-commands-options`]"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9a629dbe_2bd956f3","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":10},"updated":"2016-11-13 02:56:43.000000000","message":"nit: options","commit_id":"fabcb40a90a118a4443b0cd21a233bc6cb013ba7"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"0d5b4dee2d5de2f0a8879dceb623d5814fbfbff3","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added ``--enable-port-security`` and ``--disable-port-security``"},{"line_number":5,"context_line":"    option to ``port set`` command."},{"line_number":6,"context_line":"    [Blueprint :oscbp:`network-commands-options`]"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9a629dbe_a32bc593","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":10},"in_reply_to":"9a629dbe_2bd956f3","updated":"2016-11-14 03:59:18.000000000","message":"Done","commit_id":"fabcb40a90a118a4443b0cd21a233bc6cb013ba7"}]}