)]}'
{"id":"openstack%2Fpython-openstackclient~396007","triplet_id":"openstack%2Fpython-openstackclient~master~Ifcb9164b39bda007acc18a874caac5ee11da190d","project":"openstack/python-openstackclient","branch":"master","topic":"sg_attrs","hashtags":[],"change_id":"Ifcb9164b39bda007acc18a874caac5ee11da190d","subject":"Refactor security group \u0026 rule take action methods","status":"ABANDONED","created":"2016-11-10 08:25:52.000000000","updated":"2018-07-01 06:36:21.000000000","total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"ae10fda743e413ffb52d9380f269253d7ae3e523","_number":396007,"virtual_id_number":396007,"owner":{"_account_id":20363,"name":"Adit Sarfaty","email":"asarfaty@vmware.com","username":"asarfaty"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":1,"date":"2016-11-10 09:16:08.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2016-11-15 13:41:42.000000000","_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"date":"2016-11-21 09:06:03.000000000","_account_id":20363,"name":"Adit Sarfaty","email":"asarfaty@vmware.com","username":"asarfaty"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":20363,"name":"Adit Sarfaty","email":"asarfaty@vmware.com","username":"asarfaty"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"date":"2016-11-15 13:41:40.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":20363,"name":"Adit Sarfaty","email":"asarfaty@vmware.com","username":"asarfaty"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"_account_id":20363,"name":"Adit Sarfaty","email":"asarfaty@vmware.com","username":"asarfaty"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-11-10 09:16:08.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2016-11-15 13:41:40.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2016-11-15 13:41:42.000000000","updated_by":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"reviewer":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"state":"REVIEWER"}],"messages":[{"id":"c5cdcc3413c650928239c565f045a783d1c749bb","author":{"_account_id":20363,"name":"Adit Sarfaty","email":"asarfaty@vmware.com","username":"asarfaty"},"date":"2016-11-10 08:25:52.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"521cb2c40e05d7d69b8200f22a17bdeeb8f94e7e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-10 09:16:08.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/07/396007/1/check/gate-python-openstackclient-docs-ubuntu-xenial/820e259//doc/build/html/ : SUCCESS in 2m 46s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/07/396007/1/check/gate-python-openstackclient-pep8-ubuntu-xenial/94ce8ad/ : SUCCESS in 4m 06s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/07/396007/1/check/gate-python-openstackclient-python27-ubuntu-xenial/a90b21a/ : SUCCESS in 2m 39s\n- gate-python-openstackclient-python34 http://logs.openstack.org/07/396007/1/check/gate-python-openstackclient-python34/848ede7/ : SUCCESS in 4m 32s\n- gate-python-openstackclient-python35-nv http://logs.openstack.org/07/396007/1/check/gate-python-openstackclient-python35-nv/338dc70/ : SUCCESS in 2m 45s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/07/396007/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/c31aaed/ : SUCCESS in 42m 56s\n- check-osc-plugins http://logs.openstack.org/07/396007/1/check/check-osc-plugins/a5f7842/ : SUCCESS in 5m 39s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/07/396007/1/check/gate-osc-dsvm-functional/21c8036/ : SUCCESS in 15m 16s\n- gate-tripleo-ci-centos-7-nonha-multinode-nv http://logs.openstack.org/07/396007/1/check/gate-tripleo-ci-centos-7-nonha-multinode-nv/3b72344/ : SUCCESS in 50m 05s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"e93b871ae209bd093b598dd7a98ee43c8a7c9f65","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2016-11-15 13:41:42.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"85d6bfdd5c657503e5b003058b83020eb567d31f","author":{"_account_id":20363,"name":"Adit Sarfaty","email":"asarfaty@vmware.com","username":"asarfaty"},"date":"2016-11-21 09:06:03.000000000","message":"Patch Set 1:\n\nI couldn\u0027t find a way to add a parameter to an existing api (security-group for example) using the osc-lib.","accounts_in_message":[],"_revision_number":1},{"id":"81029b6700d78b9c1476f354bf98129254bc9c09","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2016-11-21 13:52:39.000000000","message":"Patch Set 1:\n\n\u003e I couldn\u0027t find a way to add a parameter to an existing api\n \u003e (security-group for example) using the osc-lib.\n\nYou need to talk with Dean Troyer (dtroyer) about this.  osc-lib is the intended interface for plugins.","accounts_in_message":[],"_revision_number":1},{"id":"bf0486510cc2e97b6c1123a7c05160a0b94a01e0","author":{"_account_id":20363,"name":"Adit Sarfaty","email":"asarfaty@vmware.com","username":"asarfaty"},"date":"2018-07-01 06:36:21.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"8db1d41e045f9a65d4324935cee65b47dc4ee321","revisions":{"8db1d41e045f9a65d4324935cee65b47dc4ee321":{"kind":"REWORK","_number":1,"created":"2016-11-10 08:25:52.000000000","uploader":{"_account_id":20363,"name":"Adit Sarfaty","email":"asarfaty@vmware.com","username":"asarfaty"},"ref":"refs/changes/07/396007/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/07/396007/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/07/396007/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/07/396007/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/07/396007/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/07/396007/1"}}},"commit":{"parents":[{"commit":"8b2f25682850ca747dcc0961b894ed5f5644580a","subject":"Merge \"Add \u0027description\u0027 option\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/8b2f25682850ca747dcc0961b894ed5f5644580a"}]}],"author":{"name":"Adit Sarfaty","email":"asarfaty@vmware.com","date":"2016-11-10 08:11:30.000000000","tz":120},"committer":{"name":"Adit Sarfaty","email":"asarfaty@vmware.com","date":"2016-11-10 08:25:49.000000000","tz":120},"subject":"Refactor security group \u0026 rule take action methods","message":"Refactor security group \u0026 rule take action methods\n\nAdd get_attributes internal functions to the security groups and\nsecurity groups rules create \u0026 set, to allow other plugins to\noverride only the attributes code and add extensions attributes\nwithout having to rewrite the entire take_action method.\n\nFor example see in https://review.openstack.org/#/c/393322/\nwhere vmware-nsx adds some extensions to the security group.\n\nChange-Id: Ifcb9164b39bda007acc18a874caac5ee11da190d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/8db1d41e045f9a65d4324935cee65b47dc4ee321"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/8db1d41e045f9a65d4324935cee65b47dc4ee321"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}