)]}'
{"doc/source/command-objects/network-flavor-profile.rst":[{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"6ccda6474efb93f135ad9947763de10f659735de","unresolved":false,"context_lines":[{"line_number":18,"context_line":"        [--project \u003cproject\u003e [--project-domain \u003cproject-domain\u003e]]"},{"line_number":19,"context_line":"        [--description \u003cdescription\u003e]"},{"line_number":20,"context_line":"        [--enable | --disable]"},{"line_number":21,"context_line":"        [--driver \u003cdriver\u003e]"},{"line_number":22,"context_line":"        [--metainfo \u003cmetainfo\u003e]"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":".. option:: --project \u003cproject\u003e"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a77a97e_b87398b3","line":21,"updated":"2016-11-22 20:17:19.000000000","message":"[--driver \u003cdriver\u003e | --metainfo \u003cmetainfo\u003e]","commit_id":"752cd164087368aedd61e2638f42b4b080e5621f"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"9da08e677f3e7feff1d9714a3453868ab230a1fb","unresolved":false,"context_lines":[{"line_number":18,"context_line":"        [--project \u003cproject\u003e [--project-domain \u003cproject-domain\u003e]]"},{"line_number":19,"context_line":"        [--description \u003cdescription\u003e]"},{"line_number":20,"context_line":"        [--enable | --disable]"},{"line_number":21,"context_line":"        [--driver \u003cdriver\u003e]"},{"line_number":22,"context_line":"        [--metainfo \u003cmetainfo\u003e]"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":".. option:: --project \u003cproject\u003e"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5a74a57a_51a0d3f4","line":21,"in_reply_to":"7a77a97e_b87398b3","updated":"2016-11-23 18:04:05.000000000","message":"Done","commit_id":"752cd164087368aedd61e2638f42b4b080e5621f"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"6ccda6474efb93f135ad9947763de10f659735de","unresolved":false,"context_lines":[{"line_number":70,"context_line":".. code:: bash"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    os network flavor profile delete"},{"line_number":73,"context_line":"        \u003cflavor_profile\u003e [\u003cflavor_profile\u003e ...]"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":".. _network_flavor_profile_delete:"},{"line_number":76,"context_line":".. describe:: \u003cflavor_profile\u003e"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a77a97e_386868ba","line":73,"updated":"2016-11-22 20:17:19.000000000","message":"\u003cflavor_profile\u003e [\u003cflavor-profile\u003e ...]","commit_id":"752cd164087368aedd61e2638f42b4b080e5621f"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"9da08e677f3e7feff1d9714a3453868ab230a1fb","unresolved":false,"context_lines":[{"line_number":70,"context_line":".. code:: bash"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    os network flavor profile delete"},{"line_number":73,"context_line":"        \u003cflavor_profile\u003e [\u003cflavor_profile\u003e ...]"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":".. _network_flavor_profile_delete:"},{"line_number":76,"context_line":".. describe:: \u003cflavor_profile\u003e"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5a74a57a_b1af67e2","line":73,"in_reply_to":"7a77a97e_386868ba","updated":"2016-11-23 18:04:05.000000000","message":"Done","commit_id":"752cd164087368aedd61e2638f42b4b080e5621f"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"6ccda6474efb93f135ad9947763de10f659735de","unresolved":false,"context_lines":[{"line_number":75,"context_line":".. _network_flavor_profile_delete:"},{"line_number":76,"context_line":".. describe:: \u003cflavor_profile\u003e"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    ID(s) or name(s) of flavor profile to delete."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"network flavor profile list"},{"line_number":81,"context_line":"---------------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a77a97e_985dfc17","line":78,"updated":"2016-11-22 20:17:19.000000000","message":"has to be ID since flavor profiles have no name","commit_id":"752cd164087368aedd61e2638f42b4b080e5621f"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"9da08e677f3e7feff1d9714a3453868ab230a1fb","unresolved":false,"context_lines":[{"line_number":75,"context_line":".. _network_flavor_profile_delete:"},{"line_number":76,"context_line":".. describe:: \u003cflavor_profile\u003e"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    ID(s) or name(s) of flavor profile to delete."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"network flavor profile list"},{"line_number":81,"context_line":"---------------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5a74a57a_f1b9df2f","line":78,"in_reply_to":"7a77a97e_985dfc17","updated":"2016-11-23 18:04:05.000000000","message":"Done","commit_id":"752cd164087368aedd61e2638f42b4b080e5621f"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"6ccda6474efb93f135ad9947763de10f659735de","unresolved":false,"context_lines":[{"line_number":85,"context_line":".. program:: network flavor profile list"},{"line_number":86,"context_line":".. code:: bash"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    os network flavor profile list"}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a77a97e_98b41c36","line":88,"updated":"2016-11-22 20:17:19.000000000","message":"Assuming show and update on the way","commit_id":"752cd164087368aedd61e2638f42b4b080e5621f"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"9da08e677f3e7feff1d9714a3453868ab230a1fb","unresolved":false,"context_lines":[{"line_number":85,"context_line":".. program:: network flavor profile list"},{"line_number":86,"context_line":".. code:: bash"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    os network flavor profile list"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5a74a57a_b1968792","line":88,"in_reply_to":"7a77a97e_98b41c36","updated":"2016-11-23 18:04:05.000000000","message":"yes,soon.","commit_id":"752cd164087368aedd61e2638f42b4b080e5621f"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"3f8b37b84c3243c6947d73e3f12c59bdafc798fe","unresolved":false,"context_lines":[{"line_number":69,"context_line":".. code:: bash"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    os network flavor profile delete"},{"line_number":72,"context_line":"        \u003cflavor_profile\u003e [\u003cflavor-profile\u003e ...]"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":".. _network_flavor_profile_delete:"},{"line_number":75,"context_line":".. describe:: \u003cflavor_profile\u003e"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5a74a57a_d51c266c","line":72,"updated":"2016-11-28 21:48:37.000000000","message":"\u003cflavor-profile\u003e [\u003cflavor-profile\u003e ...]","commit_id":"c1ca820ecab66dd112b1abe6122bde2df761fca5"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"fe2b10e88d3b46b30675c4de429a36066a96fe7a","unresolved":false,"context_lines":[{"line_number":69,"context_line":".. code:: bash"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    os network flavor profile delete"},{"line_number":72,"context_line":"        \u003cflavor_profile\u003e [\u003cflavor-profile\u003e ...]"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":".. _network_flavor_profile_delete:"},{"line_number":75,"context_line":".. describe:: \u003cflavor_profile\u003e"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5a74a57a_895189db","line":72,"in_reply_to":"5a74a57a_d51c266c","updated":"2016-11-29 17:00:07.000000000","message":"Done.","commit_id":"c1ca820ecab66dd112b1abe6122bde2df761fca5"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"3f8b37b84c3243c6947d73e3f12c59bdafc798fe","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        \u003cflavor_profile\u003e [\u003cflavor-profile\u003e ...]"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":".. _network_flavor_profile_delete:"},{"line_number":75,"context_line":".. describe:: \u003cflavor_profile\u003e"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    ID(s) of flavor profile to delete."},{"line_number":78,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"5a74a57a_551f365a","line":75,"updated":"2016-11-28 21:48:37.000000000","message":"ditto","commit_id":"c1ca820ecab66dd112b1abe6122bde2df761fca5"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"fe2b10e88d3b46b30675c4de429a36066a96fe7a","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        \u003cflavor_profile\u003e [\u003cflavor-profile\u003e ...]"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":".. _network_flavor_profile_delete:"},{"line_number":75,"context_line":".. describe:: \u003cflavor_profile\u003e"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    ID(s) of flavor profile to delete."},{"line_number":78,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"5a74a57a_e93f5d85","line":75,"in_reply_to":"5a74a57a_551f365a","updated":"2016-11-29 17:00:07.000000000","message":"Done","commit_id":"c1ca820ecab66dd112b1abe6122bde2df761fca5"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"3f8b37b84c3243c6947d73e3f12c59bdafc798fe","unresolved":false,"context_lines":[{"line_number":96,"context_line":".. code:: bash"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    os network flavor profile show"},{"line_number":99,"context_line":"        \u003cflavor_profile\u003e"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":".. _network_flavor_profile_show:"},{"line_number":102,"context_line":".. describe:: \u003cflavor_profile\u003e"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5a74a57a_b5388ad4","line":99,"updated":"2016-11-28 21:48:37.000000000","message":"ditto","commit_id":"c1ca820ecab66dd112b1abe6122bde2df761fca5"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"fe2b10e88d3b46b30675c4de429a36066a96fe7a","unresolved":false,"context_lines":[{"line_number":96,"context_line":".. code:: bash"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    os network flavor profile show"},{"line_number":99,"context_line":"        \u003cflavor_profile\u003e"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":".. _network_flavor_profile_show:"},{"line_number":102,"context_line":".. describe:: \u003cflavor_profile\u003e"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5a74a57a_a95c85f1","line":99,"in_reply_to":"5a74a57a_b5388ad4","updated":"2016-11-29 17:00:07.000000000","message":"Done","commit_id":"c1ca820ecab66dd112b1abe6122bde2df761fca5"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"e7f2b4c95fae1850c192cb7c96afc592a1c96e22","unresolved":false,"context_lines":[{"line_number":2,"context_line":"network flavor profile"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"A **network flavor profile** allows administrators to create,delete,list,show network service profile."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Network v2"},{"line_number":8,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a71b18c_f481edfc","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":102},"updated":"2016-12-01 11:10:46.000000000","message":"I believe this section is supposed to contain a brief description of the network flavor profile feature itself, not just the functions of the command. See https://specs.openstack.org/openstack/neutron-specs/specs/liberty/neutron-flavor-framework.html for reference, or ping me if you\u0027d like me to take a shot at this.","commit_id":"37a6e3b2c9fb4c45295d9e0af768a9a8edb356b1"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"cdf85f2c102c9756f4f48af0b3554cc36ed42be3","unresolved":false,"context_lines":[{"line_number":2,"context_line":"network flavor profile"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"A **network flavor profile** allows administrators to create,delete,list,show network service profile."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Network v2"},{"line_number":8,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"3a71b18c_b7b92531","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":102},"in_reply_to":"3a71b18c_f481edfc","updated":"2016-12-01 16:25:22.000000000","message":"Done","commit_id":"37a6e3b2c9fb4c45295d9e0af768a9a8edb356b1"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"761218c6619845b2855b78faa6797c86a0d3545c","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    *Network version 2 only*"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":".. option:: --enable"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    Sets enable flag to True."},{"line_number":50,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"3a71b18c_3e991020","line":47,"updated":"2016-12-04 19:24:47.000000000","message":"Which one is the default value enable or disable?\n\n(Default)","commit_id":"a73b0a04e964e8ba458cc149d1ec4eacf8e8e5a9"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"657e843531d57a72d1945ecf72d57855254fe78d","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    *Network version 2 only*"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":".. option:: --enable"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    Sets enable flag to True."},{"line_number":50,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"3a71b18c_f7b15602","line":47,"in_reply_to":"3a71b18c_3e991020","updated":"2016-12-05 17:49:16.000000000","message":"Done","commit_id":"a73b0a04e964e8ba458cc149d1ec4eacf8e8e5a9"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"761218c6619845b2855b78faa6797c86a0d3545c","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        \u003cflavor-profile\u003e"},{"line_number":121,"context_line":"        [--description \u003cdescription\u003e]"},{"line_number":122,"context_line":"        [--driver \u003cdriver\u003e]"},{"line_number":123,"context_line":"        [--enable | --disable]"},{"line_number":124,"context_line":"        [--metainfo \u003cmetainfo\u003e]"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"3a71b18c_5ea08c43","line":123,"updated":"2016-12-04 19:24:47.000000000","message":"ditto","commit_id":"a73b0a04e964e8ba458cc149d1ec4eacf8e8e5a9"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"657e843531d57a72d1945ecf72d57855254fe78d","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        \u003cflavor-profile\u003e"},{"line_number":121,"context_line":"        [--description \u003cdescription\u003e]"},{"line_number":122,"context_line":"        [--driver \u003cdriver\u003e]"},{"line_number":123,"context_line":"        [--enable | --disable]"},{"line_number":124,"context_line":"        [--metainfo \u003cmetainfo\u003e]"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"3a71b18c_77c62669","line":123,"in_reply_to":"3a71b18c_5ea08c43","updated":"2016-12-05 17:49:16.000000000","message":"Done","commit_id":"a73b0a04e964e8ba458cc149d1ec4eacf8e8e5a9"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c0ee54c79fffb4f3ca1d4eefda75741e81e27235","unresolved":false,"context_lines":[{"line_number":2,"context_line":"network flavor profile"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"A **network flavor profile** allows administrators to create,delete,list,"},{"line_number":6,"context_line":"show and update  network service profile,which details a framework to enable"},{"line_number":7,"context_line":"Operators to configure and Users to select from different abstract"},{"line_number":8,"context_line":"representations of a service implementation in Neutron. It decouples"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a6eadb0_e72bf392","line":5,"range":{"start_line":5,"start_character":54,"end_line":5,"end_character":73},"updated":"2016-12-19 10:09:55.000000000","message":"Add a space after a comma","commit_id":"326a37f67518f9bab9144c04f13d90da1cd2b10f"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"07c284423ce597b96747788f6defbd6760668f22","unresolved":false,"context_lines":[{"line_number":2,"context_line":"network flavor profile"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"A **network flavor profile** allows administrators to create,delete,list,"},{"line_number":6,"context_line":"show and update  network service profile,which details a framework to enable"},{"line_number":7,"context_line":"Operators to configure and Users to select from different abstract"},{"line_number":8,"context_line":"representations of a service implementation in Neutron. It decouples"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a6eadb0_f213980b","line":5,"range":{"start_line":5,"start_character":54,"end_line":5,"end_character":73},"in_reply_to":"1a6eadb0_e72bf392","updated":"2016-12-19 17:43:31.000000000","message":"Done","commit_id":"326a37f67518f9bab9144c04f13d90da1cd2b10f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c0ee54c79fffb4f3ca1d4eefda75741e81e27235","unresolved":false,"context_lines":[{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"A **network flavor profile** allows administrators to create,delete,list,"},{"line_number":6,"context_line":"show and update  network service profile,which details a framework to enable"},{"line_number":7,"context_line":"Operators to configure and Users to select from different abstract"},{"line_number":8,"context_line":"representations of a service implementation in Neutron. It decouples"},{"line_number":9,"context_line":"the logical configuration from its instantiation enabling Operators to"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a6eadb0_e702130b","line":6,"range":{"start_line":6,"start_character":40,"end_line":6,"end_character":46},"updated":"2016-12-19 10:09:55.000000000","message":"a space between a comma and \u0027which\u0027","commit_id":"326a37f67518f9bab9144c04f13d90da1cd2b10f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c0ee54c79fffb4f3ca1d4eefda75741e81e27235","unresolved":false,"context_lines":[{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"A **network flavor profile** allows administrators to create,delete,list,"},{"line_number":6,"context_line":"show and update  network service profile,which details a framework to enable"},{"line_number":7,"context_line":"Operators to configure and Users to select from different abstract"},{"line_number":8,"context_line":"representations of a service implementation in Neutron. It decouples"},{"line_number":9,"context_line":"the logical configuration from its instantiation enabling Operators to"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a6eadb0_67160357","line":6,"range":{"start_line":6,"start_character":15,"end_line":6,"end_character":17},"updated":"2016-12-19 10:09:55.000000000","message":"two spaces -\u003e single space","commit_id":"326a37f67518f9bab9144c04f13d90da1cd2b10f"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"07c284423ce597b96747788f6defbd6760668f22","unresolved":false,"context_lines":[{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"A **network flavor profile** allows administrators to create,delete,list,"},{"line_number":6,"context_line":"show and update  network service profile,which details a framework to enable"},{"line_number":7,"context_line":"Operators to configure and Users to select from different abstract"},{"line_number":8,"context_line":"representations of a service implementation in Neutron. It decouples"},{"line_number":9,"context_line":"the logical configuration from its instantiation enabling Operators to"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a6eadb0_32f6f0d7","line":6,"range":{"start_line":6,"start_character":15,"end_line":6,"end_character":17},"in_reply_to":"1a6eadb0_67160357","updated":"2016-12-19 17:43:31.000000000","message":"Done","commit_id":"326a37f67518f9bab9144c04f13d90da1cd2b10f"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"07c284423ce597b96747788f6defbd6760668f22","unresolved":false,"context_lines":[{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"A **network flavor profile** allows administrators to create,delete,list,"},{"line_number":6,"context_line":"show and update  network service profile,which details a framework to enable"},{"line_number":7,"context_line":"Operators to configure and Users to select from different abstract"},{"line_number":8,"context_line":"representations of a service implementation in Neutron. It decouples"},{"line_number":9,"context_line":"the logical configuration from its instantiation enabling Operators to"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a6eadb0_720068ab","line":6,"range":{"start_line":6,"start_character":40,"end_line":6,"end_character":46},"in_reply_to":"1a6eadb0_e702130b","updated":"2016-12-19 17:43:31.000000000","message":"Done","commit_id":"326a37f67518f9bab9144c04f13d90da1cd2b10f"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"60f1f247f70a7aa8c34da3a3de9ec077057581ea","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"network flavor profile"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"A **network flavor profile** allows administrators to create, delete, list,"}],"source_content_type":"text/x-rst","patch_set":14,"id":"ba5201f7_0127c364","line":2,"updated":"2017-01-03 22:33:04.000000000","message":"I feel like I\u0027ve asked this question before but can\u0027t find it...\n\nWhy do we need both \u0027flavor\u0027 and \u0027profile\u0027 in this resource name?  flavor is consistent with server flavor, what distinction does \u0027profile\u0027 add here?","commit_id":"d2f9ea10812550f211f65505d1ba328d70317156"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"a489c95155578baa9478d6bcf710d25a09ebfc8c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"network flavor profile"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"A **network flavor profile** allows administrators to create, delete, list,"}],"source_content_type":"text/x-rst","patch_set":14,"id":"ba5201f7_2041283a","line":2,"in_reply_to":"ba5201f7_0127c364","updated":"2017-01-10 18:11:36.000000000","message":"I think there might be confusion here between network_flavor and network_flavor_profile. The patch you might be referring to is https://review.openstack.org/#/c/382530/","commit_id":"d2f9ea10812550f211f65505d1ba328d70317156"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"60f1f247f70a7aa8c34da3a3de9ec077057581ea","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Operators to configure and Users to select from different abstract"},{"line_number":8,"context_line":"representations of a service implementation in Neutron. It decouples"},{"line_number":9,"context_line":"the logical configuration from its instantiation enabling Operators to"},{"line_number":10,"context_line":"create user options according to deployment needs."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Network v2"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"ba5201f7_e1a47fba","line":10,"updated":"2017-01-03 22:33:04.000000000","message":"That\u0027s a complicated first sentence...\n\nA **network flavor** defines the network service configurations available to users.  This allows operators to create logical network configurations that users may select according to their deployment needs.","commit_id":"d2f9ea10812550f211f65505d1ba328d70317156"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"a489c95155578baa9478d6bcf710d25a09ebfc8c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Operators to configure and Users to select from different abstract"},{"line_number":8,"context_line":"representations of a service implementation in Neutron. It decouples"},{"line_number":9,"context_line":"the logical configuration from its instantiation enabling Operators to"},{"line_number":10,"context_line":"create user options according to deployment needs."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Network v2"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"ba5201f7_604b305a","line":10,"in_reply_to":"ba5201f7_e1a47fba","updated":"2017-01-10 18:11:36.000000000","message":"Ditto","commit_id":"d2f9ea10812550f211f65505d1ba328d70317156"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"505d8bbdeda761284ddad4ecc036309dfd534a42","unresolved":false,"context_lines":[{"line_number":19,"context_line":".. program:: network flavor profile create"},{"line_number":20,"context_line":".. code:: bash"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    os network flavor profile create"},{"line_number":23,"context_line":"        [--project \u003cproject\u003e [--project-domain \u003cproject-domain\u003e]]"},{"line_number":24,"context_line":"        [--description \u003cdescription\u003e]"},{"line_number":25,"context_line":"        [--enable | --disable]"}],"source_content_type":"text/x-rst","patch_set":14,"id":"ba5201f7_421114ac","line":22,"range":{"start_line":22,"start_character":4,"end_line":22,"end_character":6},"updated":"2016-12-29 20:18:02.000000000","message":"Replace all os to openstack in this file","commit_id":"d2f9ea10812550f211f65505d1ba328d70317156"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"a489c95155578baa9478d6bcf710d25a09ebfc8c","unresolved":false,"context_lines":[{"line_number":19,"context_line":".. program:: network flavor profile create"},{"line_number":20,"context_line":".. code:: bash"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    os network flavor profile create"},{"line_number":23,"context_line":"        [--project \u003cproject\u003e [--project-domain \u003cproject-domain\u003e]]"},{"line_number":24,"context_line":"        [--description \u003cdescription\u003e]"},{"line_number":25,"context_line":"        [--enable | --disable]"}],"source_content_type":"text/x-rst","patch_set":14,"id":"ba5201f7_a036f8b1","line":22,"range":{"start_line":22,"start_character":4,"end_line":22,"end_character":6},"in_reply_to":"ba5201f7_421114ac","updated":"2017-01-10 18:11:36.000000000","message":"Done","commit_id":"d2f9ea10812550f211f65505d1ba328d70317156"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"60f1f247f70a7aa8c34da3a3de9ec077057581ea","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        [--description \u003cdescription\u003e]"},{"line_number":25,"context_line":"        [--enable | --disable]"},{"line_number":26,"context_line":"        [--driver \u003cdriver\u003e]"},{"line_number":27,"context_line":"        [--metainfo \u003cmetainfo\u003e]"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":".. option:: --project \u003cproject\u003e"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"ba5201f7_417d4b1b","line":27,"updated":"2017-01-03 22:33:04.000000000","message":"Write this to indicate that --driver and/or --metainfo are required (even if argparse does not have a way to show that in its output):\n\n  --driver \u003cdriver\u003e | --metainfo \u003cmetainfo\u003e | --driver \u003cdriver\u003e --metainfo \u003cmetainfo\u003e\n\n\nUh oh, network flavors don\u0027t have names, just a UUID?  Ouch says every user ever, again...","commit_id":"d2f9ea10812550f211f65505d1ba328d70317156"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"a489c95155578baa9478d6bcf710d25a09ebfc8c","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        [--description \u003cdescription\u003e]"},{"line_number":25,"context_line":"        [--enable | --disable]"},{"line_number":26,"context_line":"        [--driver \u003cdriver\u003e]"},{"line_number":27,"context_line":"        [--metainfo \u003cmetainfo\u003e]"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":".. option:: --project \u003cproject\u003e"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"ba5201f7_60b9702e","line":27,"in_reply_to":"ba5201f7_417d4b1b","updated":"2017-01-10 18:11:36.000000000","message":"Network Flavors do have names but Network Flavor Profile doesn\u0027t.\nhttps://review.openstack.org/#/c/382530/","commit_id":"d2f9ea10812550f211f65505d1ba328d70317156"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"505d8bbdeda761284ddad4ecc036309dfd534a42","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":".. option:: --description \u003cdescription\u003e"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    Description for the flavor profile."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    *Network version 2 only*"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"ba5201f7_8223fc04","line":43,"range":{"start_line":43,"start_character":38,"end_line":43,"end_character":39},"updated":"2016-12-29 20:18:02.000000000","message":"Period is not needed here and everywhere in the help texts","commit_id":"d2f9ea10812550f211f65505d1ba328d70317156"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"a489c95155578baa9478d6bcf710d25a09ebfc8c","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":".. option:: --description \u003cdescription\u003e"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    Description for the flavor profile."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    *Network version 2 only*"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"ba5201f7_40462c22","line":43,"range":{"start_line":43,"start_character":38,"end_line":43,"end_character":39},"in_reply_to":"ba5201f7_8223fc04","updated":"2017-01-10 18:11:36.000000000","message":"Done","commit_id":"d2f9ea10812550f211f65505d1ba328d70317156"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"60f1f247f70a7aa8c34da3a3de9ec077057581ea","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    *Network version 2 only*"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":".. option:: --enable(Default)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    Enable the flavor profile(default)."},{"line_number":50,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"ba5201f7_41a46ba5","line":47,"updated":"2017-01-03 22:33:04.000000000","message":"(Default) should not appear here, it is not part of the option syntax","commit_id":"d2f9ea10812550f211f65505d1ba328d70317156"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"a489c95155578baa9478d6bcf710d25a09ebfc8c","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    *Network version 2 only*"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":".. option:: --enable(Default)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    Enable the flavor profile(default)."},{"line_number":50,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"ba5201f7_c0605ca7","line":47,"in_reply_to":"ba5201f7_41a46ba5","updated":"2017-01-10 18:11:36.000000000","message":"Done","commit_id":"d2f9ea10812550f211f65505d1ba328d70317156"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"60f1f247f70a7aa8c34da3a3de9ec077057581ea","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":".. option:: --enable(Default)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    Enable the flavor profile(default)."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":".. option:: --disable"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"ba5201f7_21b4c7cf","line":49,"updated":"2017-01-03 22:33:04.000000000","message":"There should generally be spaces in front of paranthesis:\n\n  ... flavor profile (Default)","commit_id":"d2f9ea10812550f211f65505d1ba328d70317156"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"a489c95155578baa9478d6bcf710d25a09ebfc8c","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":".. option:: --enable(Default)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    Enable the flavor profile(default)."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":".. option:: --disable"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"ba5201f7_606c109d","line":49,"in_reply_to":"ba5201f7_21b4c7cf","updated":"2017-01-10 18:11:36.000000000","message":"Done","commit_id":"d2f9ea10812550f211f65505d1ba328d70317156"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"60f1f247f70a7aa8c34da3a3de9ec077057581ea","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    Flavor profile to display(ID)."},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"network flavor profile set"},{"line_number":112,"context_line":"--------------------------"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"Set network flavor profile properties"}],"source_content_type":"text/x-rst","patch_set":14,"id":"ba5201f7_e1071f7f","line":111,"updated":"2017-01-03 22:33:04.000000000","message":"Sort the commands in this file (set before show)","commit_id":"d2f9ea10812550f211f65505d1ba328d70317156"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"a489c95155578baa9478d6bcf710d25a09ebfc8c","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    Flavor profile to display(ID)."},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"network flavor profile set"},{"line_number":112,"context_line":"--------------------------"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"Set network flavor profile properties"}],"source_content_type":"text/x-rst","patch_set":14,"id":"ba5201f7_20f928c9","line":111,"in_reply_to":"ba5201f7_e1071f7f","updated":"2017-01-10 18:11:36.000000000","message":"Done","commit_id":"d2f9ea10812550f211f65505d1ba328d70317156"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"60f1f247f70a7aa8c34da3a3de9ec077057581ea","unresolved":false,"context_lines":[{"line_number":117,"context_line":".. code:: bash"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    os network flavor profile set"},{"line_number":120,"context_line":"        \u003cflavor-profile\u003e"},{"line_number":121,"context_line":"        [--description \u003cdescription\u003e]"},{"line_number":122,"context_line":"        [--driver \u003cdriver\u003e]"},{"line_number":123,"context_line":"        [--enable | --disable]"}],"source_content_type":"text/x-rst","patch_set":14,"id":"ba5201f7_21ebe7b1","line":120,"updated":"2017-01-03 22:33:04.000000000","message":"List the positional arguments after the command options; this mirrors the argparse output.","commit_id":"d2f9ea10812550f211f65505d1ba328d70317156"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"a489c95155578baa9478d6bcf710d25a09ebfc8c","unresolved":false,"context_lines":[{"line_number":117,"context_line":".. code:: bash"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    os network flavor profile set"},{"line_number":120,"context_line":"        \u003cflavor-profile\u003e"},{"line_number":121,"context_line":"        [--description \u003cdescription\u003e]"},{"line_number":122,"context_line":"        [--driver \u003cdriver\u003e]"},{"line_number":123,"context_line":"        [--enable | --disable]"}],"source_content_type":"text/x-rst","patch_set":14,"id":"ba5201f7_600330b9","line":120,"in_reply_to":"ba5201f7_21ebe7b1","updated":"2017-01-10 18:11:36.000000000","message":"Done","commit_id":"d2f9ea10812550f211f65505d1ba328d70317156"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a7bdf8f0d88a95a99035a50f8f7e9d3f353e1e3b","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"A **network flavor profile** allows administrators to create, delete, list,"},{"line_number":6,"context_line":"show and update network service profile, which details a framework to enable"},{"line_number":7,"context_line":"Operators to configure and Users to select from different abstract"},{"line_number":8,"context_line":"representations of a service implementation in Neutron. It decouples"},{"line_number":9,"context_line":"the logical configuration from its instantiation enabling Operators to"},{"line_number":10,"context_line":"create user options according to deployment needs."}],"source_content_type":"text/x-rst","patch_set":22,"id":"ba2be162_bc356b47","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":9},"updated":"2017-03-01 13:00:44.000000000","message":"No need to capitalize it.","commit_id":"e068b1826d2fbd7982a37dfeef9683736c01a8c3"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a7bdf8f0d88a95a99035a50f8f7e9d3f353e1e3b","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"A **network flavor profile** allows administrators to create, delete, list,"},{"line_number":6,"context_line":"show and update network service profile, which details a framework to enable"},{"line_number":7,"context_line":"Operators to configure and Users to select from different abstract"},{"line_number":8,"context_line":"representations of a service implementation in Neutron. It decouples"},{"line_number":9,"context_line":"the logical configuration from its instantiation enabling Operators to"},{"line_number":10,"context_line":"create user options according to deployment needs."}],"source_content_type":"text/x-rst","patch_set":22,"id":"ba2be162_9c17c7a2","line":7,"range":{"start_line":7,"start_character":27,"end_line":7,"end_character":33},"updated":"2017-03-01 13:00:44.000000000","message":"Users -\u003e users","commit_id":"e068b1826d2fbd7982a37dfeef9683736c01a8c3"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"841f55d9fae3a0e06948c210d293008f22a8640a","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"A **network flavor profile** allows administrators to create, delete, list,"},{"line_number":6,"context_line":"show and update network service profile, which details a framework to enable"},{"line_number":7,"context_line":"Operators to configure and Users to select from different abstract"},{"line_number":8,"context_line":"representations of a service implementation in Neutron. It decouples"},{"line_number":9,"context_line":"the logical configuration from its instantiation enabling Operators to"},{"line_number":10,"context_line":"create user options according to deployment needs."}],"source_content_type":"text/x-rst","patch_set":22,"id":"ba2be162_cc0c2645","line":7,"range":{"start_line":7,"start_character":27,"end_line":7,"end_character":33},"in_reply_to":"ba2be162_9c17c7a2","updated":"2017-03-01 16:21:13.000000000","message":"Done","commit_id":"e068b1826d2fbd7982a37dfeef9683736c01a8c3"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"841f55d9fae3a0e06948c210d293008f22a8640a","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"A **network flavor profile** allows administrators to create, delete, list,"},{"line_number":6,"context_line":"show and update network service profile, which details a framework to enable"},{"line_number":7,"context_line":"Operators to configure and Users to select from different abstract"},{"line_number":8,"context_line":"representations of a service implementation in Neutron. It decouples"},{"line_number":9,"context_line":"the logical configuration from its instantiation enabling Operators to"},{"line_number":10,"context_line":"create user options according to deployment needs."}],"source_content_type":"text/x-rst","patch_set":22,"id":"ba2be162_ec09ea32","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":9},"in_reply_to":"ba2be162_bc356b47","updated":"2017-03-01 16:21:13.000000000","message":"Done","commit_id":"e068b1826d2fbd7982a37dfeef9683736c01a8c3"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a7bdf8f0d88a95a99035a50f8f7e9d3f353e1e3b","unresolved":false,"context_lines":[{"line_number":5,"context_line":"A **network flavor profile** allows administrators to create, delete, list,"},{"line_number":6,"context_line":"show and update network service profile, which details a framework to enable"},{"line_number":7,"context_line":"Operators to configure and Users to select from different abstract"},{"line_number":8,"context_line":"representations of a service implementation in Neutron. It decouples"},{"line_number":9,"context_line":"the logical configuration from its instantiation enabling Operators to"},{"line_number":10,"context_line":"create user options according to deployment needs."},{"line_number":11,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"ba2be162_7c7933fc","line":8,"range":{"start_line":8,"start_character":47,"end_line":8,"end_character":54},"updated":"2017-03-01 13:00:44.000000000","message":"Neutron -\u003e the Networking service","commit_id":"e068b1826d2fbd7982a37dfeef9683736c01a8c3"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"841f55d9fae3a0e06948c210d293008f22a8640a","unresolved":false,"context_lines":[{"line_number":5,"context_line":"A **network flavor profile** allows administrators to create, delete, list,"},{"line_number":6,"context_line":"show and update network service profile, which details a framework to enable"},{"line_number":7,"context_line":"Operators to configure and Users to select from different abstract"},{"line_number":8,"context_line":"representations of a service implementation in Neutron. It decouples"},{"line_number":9,"context_line":"the logical configuration from its instantiation enabling Operators to"},{"line_number":10,"context_line":"create user options according to deployment needs."},{"line_number":11,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"ba2be162_0c071e1d","line":8,"range":{"start_line":8,"start_character":47,"end_line":8,"end_character":54},"in_reply_to":"ba2be162_7c7933fc","updated":"2017-03-01 16:21:13.000000000","message":"Done","commit_id":"e068b1826d2fbd7982a37dfeef9683736c01a8c3"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a7bdf8f0d88a95a99035a50f8f7e9d3f353e1e3b","unresolved":false,"context_lines":[{"line_number":6,"context_line":"show and update network service profile, which details a framework to enable"},{"line_number":7,"context_line":"Operators to configure and Users to select from different abstract"},{"line_number":8,"context_line":"representations of a service implementation in Neutron. It decouples"},{"line_number":9,"context_line":"the logical configuration from its instantiation enabling Operators to"},{"line_number":10,"context_line":"create user options according to deployment needs."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Network v2"}],"source_content_type":"text/x-rst","patch_set":22,"id":"ba2be162_fc6d2333","line":9,"range":{"start_line":9,"start_character":58,"end_line":9,"end_character":67},"updated":"2017-03-01 13:00:44.000000000","message":"No need to capitalize it","commit_id":"e068b1826d2fbd7982a37dfeef9683736c01a8c3"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"841f55d9fae3a0e06948c210d293008f22a8640a","unresolved":false,"context_lines":[{"line_number":6,"context_line":"show and update network service profile, which details a framework to enable"},{"line_number":7,"context_line":"Operators to configure and Users to select from different abstract"},{"line_number":8,"context_line":"representations of a service implementation in Neutron. It decouples"},{"line_number":9,"context_line":"the logical configuration from its instantiation enabling Operators to"},{"line_number":10,"context_line":"create user options according to deployment needs."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Network v2"}],"source_content_type":"text/x-rst","patch_set":22,"id":"ba2be162_47ff2f01","line":9,"range":{"start_line":9,"start_character":58,"end_line":9,"end_character":67},"in_reply_to":"ba2be162_fc6d2333","updated":"2017-03-01 16:21:13.000000000","message":"Done","commit_id":"e068b1826d2fbd7982a37dfeef9683736c01a8c3"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a7bdf8f0d88a95a99035a50f8f7e9d3f353e1e3b","unresolved":false,"context_lines":[{"line_number":14,"context_line":"network flavor profile create"},{"line_number":15,"context_line":"-----------------------------"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Create flavor profile"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":".. program:: network flavor profile create"},{"line_number":20,"context_line":".. code:: bash"}],"source_content_type":"text/x-rst","patch_set":22,"id":"ba2be162_bfa55d05","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":21},"updated":"2017-03-01 13:00:44.000000000","message":"It is better the command description matches the help message.\n\n  Create a new network flavor profile\n\nThis applies to all other commands.","commit_id":"e068b1826d2fbd7982a37dfeef9683736c01a8c3"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"841f55d9fae3a0e06948c210d293008f22a8640a","unresolved":false,"context_lines":[{"line_number":14,"context_line":"network flavor profile create"},{"line_number":15,"context_line":"-----------------------------"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Create flavor profile"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":".. program:: network flavor profile create"},{"line_number":20,"context_line":".. code:: bash"}],"source_content_type":"text/x-rst","patch_set":22,"id":"ba2be162_67043315","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":21},"in_reply_to":"ba2be162_bfa55d05","updated":"2017-03-01 16:21:13.000000000","message":"Done","commit_id":"e068b1826d2fbd7982a37dfeef9683736c01a8c3"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a7bdf8f0d88a95a99035a50f8f7e9d3f353e1e3b","unresolved":false,"context_lines":[{"line_number":23,"context_line":"        [--project \u003cproject\u003e [--project-domain \u003cproject-domain\u003e]]"},{"line_number":24,"context_line":"        [--description \u003cdescription\u003e]"},{"line_number":25,"context_line":"        [--enable | --disable]"},{"line_number":26,"context_line":"        [--driver \u003cdriver\u003e | --metainfo \u003cmetainfo\u003e | --driver \u003cdriver\u003e --metainfo \u003cmetainfo\u003e]"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":".. option:: --project \u003cproject\u003e"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"ba2be162_3fbfadfc","line":26,"range":{"start_line":26,"start_character":8,"end_line":26,"end_character":93},"updated":"2017-03-01 13:00:44.000000000","message":"At least one of --driver and --metainfo is required.\n[] means optional, so it is suggested to use () or no [].\n\n  (--driver \u003cdriver\u003e | --metainfo \u003cmetainfo\u003e | --driver \u003cdriver\u003e --metainfo \u003cmetadata\u003e)\n\nUsing () is the way that argparse help message does.","commit_id":"e068b1826d2fbd7982a37dfeef9683736c01a8c3"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"841f55d9fae3a0e06948c210d293008f22a8640a","unresolved":false,"context_lines":[{"line_number":23,"context_line":"        [--project \u003cproject\u003e [--project-domain \u003cproject-domain\u003e]]"},{"line_number":24,"context_line":"        [--description \u003cdescription\u003e]"},{"line_number":25,"context_line":"        [--enable | --disable]"},{"line_number":26,"context_line":"        [--driver \u003cdriver\u003e | --metainfo \u003cmetainfo\u003e | --driver \u003cdriver\u003e --metainfo \u003cmetainfo\u003e]"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":".. option:: --project \u003cproject\u003e"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"ba2be162_a70e2b32","line":26,"range":{"start_line":26,"start_character":8,"end_line":26,"end_character":93},"in_reply_to":"ba2be162_3fbfadfc","updated":"2017-03-01 16:21:13.000000000","message":"Done","commit_id":"e068b1826d2fbd7982a37dfeef9683736c01a8c3"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a7bdf8f0d88a95a99035a50f8f7e9d3f353e1e3b","unresolved":false,"context_lines":[{"line_number":79,"context_line":".. _network_flavor_profile_delete:"},{"line_number":80,"context_line":".. describe:: \u003cflavor-profile\u003e"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    Flavor profile(s) to delete(ID)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"network flavor profile list"},{"line_number":85,"context_line":"---------------------------"}],"source_content_type":"text/x-rst","patch_set":22,"id":"ba2be162_5fbc6105","line":82,"range":{"start_line":82,"start_character":31,"end_line":82,"end_character":35},"updated":"2017-03-01 13:00:44.000000000","message":"-\u003e (ID only)","commit_id":"e068b1826d2fbd7982a37dfeef9683736c01a8c3"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"841f55d9fae3a0e06948c210d293008f22a8640a","unresolved":false,"context_lines":[{"line_number":79,"context_line":".. _network_flavor_profile_delete:"},{"line_number":80,"context_line":".. describe:: \u003cflavor-profile\u003e"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    Flavor profile(s) to delete(ID)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"network flavor profile list"},{"line_number":85,"context_line":"---------------------------"}],"source_content_type":"text/x-rst","patch_set":22,"id":"ba2be162_e7102351","line":82,"range":{"start_line":82,"start_character":31,"end_line":82,"end_character":35},"in_reply_to":"ba2be162_5fbc6105","updated":"2017-03-01 16:21:13.000000000","message":"Done","commit_id":"e068b1826d2fbd7982a37dfeef9683736c01a8c3"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a7bdf8f0d88a95a99035a50f8f7e9d3f353e1e3b","unresolved":false,"context_lines":[{"line_number":84,"context_line":"network flavor profile list"},{"line_number":85,"context_line":"---------------------------"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"List network flavor profile"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":".. program:: network flavor profile list"},{"line_number":90,"context_line":".. code:: bash"}],"source_content_type":"text/x-rst","patch_set":22,"id":"ba2be162_3f56cdd2","line":87,"range":{"start_line":87,"start_character":20,"end_line":87,"end_character":27},"updated":"2017-03-01 13:00:44.000000000","message":"-\u003e profiles","commit_id":"e068b1826d2fbd7982a37dfeef9683736c01a8c3"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"841f55d9fae3a0e06948c210d293008f22a8640a","unresolved":false,"context_lines":[{"line_number":84,"context_line":"network flavor profile list"},{"line_number":85,"context_line":"---------------------------"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"List network flavor profile"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":".. program:: network flavor profile list"},{"line_number":90,"context_line":".. code:: bash"}],"source_content_type":"text/x-rst","patch_set":22,"id":"ba2be162_071e1763","line":87,"range":{"start_line":87,"start_character":20,"end_line":87,"end_character":27},"in_reply_to":"ba2be162_3f56cdd2","updated":"2017-03-01 16:21:13.000000000","message":"Done","commit_id":"e068b1826d2fbd7982a37dfeef9683736c01a8c3"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a7bdf8f0d88a95a99035a50f8f7e9d3f353e1e3b","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    Python module path to driver"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":".. option:: --enable(Default)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    Enable the flavor profile"},{"line_number":121,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"ba2be162_5f5381e1","line":118,"range":{"start_line":118,"start_character":20,"end_line":118,"end_character":29},"updated":"2017-03-01 13:00:44.000000000","message":"space before (","commit_id":"e068b1826d2fbd7982a37dfeef9683736c01a8c3"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"841f55d9fae3a0e06948c210d293008f22a8640a","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    Python module path to driver"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":".. option:: --enable(Default)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    Enable the flavor profile"},{"line_number":121,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"ba2be162_47264fbb","line":118,"range":{"start_line":118,"start_character":20,"end_line":118,"end_character":29},"in_reply_to":"ba2be162_5f5381e1","updated":"2017-03-01 16:21:13.000000000","message":"Done","commit_id":"e068b1826d2fbd7982a37dfeef9683736c01a8c3"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"a71f50def5ac497b9dbe8a355a21b19dc8aca7fa","unresolved":false,"context_lines":[{"line_number":2,"context_line":"network flavor profile"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"A **network flavor profile** allows administrators to create, delete, list,"},{"line_number":6,"context_line":"show and update network service profile, which details a framework to enable"},{"line_number":7,"context_line":"operators to configure and users to select from different abstract"},{"line_number":8,"context_line":"representations of a service implementation in the Networking service."}],"source_content_type":"text/x-rst","patch_set":23,"id":"ba2be162_4b1c8713","line":5,"updated":"2017-03-02 01:24:26.000000000","message":"I would prefer every \u003cflavor-profile\u003e be changed to \u003cflavor-profile-id\u003e since it only accepts IDs as values.","commit_id":"88830810b14cf5455f553a6b0997bae491b9d958"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"fa95df2551f0acd0531fe557d8abef5d4c01db56","unresolved":false,"context_lines":[{"line_number":2,"context_line":"network flavor profile"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"A **network flavor profile** allows administrators to create, delete, list,"},{"line_number":6,"context_line":"show and update network service profile, which details a framework to enable"},{"line_number":7,"context_line":"operators to configure and users to select from different abstract"},{"line_number":8,"context_line":"representations of a service implementation in the Networking service."}],"source_content_type":"text/x-rst","patch_set":23,"id":"ba2be162_b4d7f7bd","line":5,"in_reply_to":"ba2be162_4b1c8713","updated":"2017-03-02 15:45:46.000000000","message":"Done","commit_id":"88830810b14cf5455f553a6b0997bae491b9d958"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"a71f50def5ac497b9dbe8a355a21b19dc8aca7fa","unresolved":false,"context_lines":[{"line_number":130,"context_line":".. _network_flavor_profile_set:"},{"line_number":131,"context_line":".. describe:: \u003cflavor-profile\u003e"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    Flavor profile to update(ID)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"network flavor profile show"},{"line_number":136,"context_line":"---------------------------"}],"source_content_type":"text/x-rst","patch_set":23,"id":"ba2be162_6b04ebbf","line":133,"updated":"2017-03-02 01:24:26.000000000","message":"space needed after update","commit_id":"88830810b14cf5455f553a6b0997bae491b9d958"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"fa95df2551f0acd0531fe557d8abef5d4c01db56","unresolved":false,"context_lines":[{"line_number":130,"context_line":".. _network_flavor_profile_set:"},{"line_number":131,"context_line":".. describe:: \u003cflavor-profile\u003e"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    Flavor profile to update(ID)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"network flavor profile show"},{"line_number":136,"context_line":"---------------------------"}],"source_content_type":"text/x-rst","patch_set":23,"id":"ba2be162_d4e62bb3","line":133,"in_reply_to":"ba2be162_6b04ebbf","updated":"2017-03-02 15:45:46.000000000","message":"Done","commit_id":"88830810b14cf5455f553a6b0997bae491b9d958"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"576e488bc08e4f8ca07c72c1f3136351aa14f5a3","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Create a new network flavor profile"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":".. program:: network flavor profile create"},{"line_number":20,"context_line":".. code:: bash"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    openstack network flavor profile create"},{"line_number":23,"context_line":"        [--project \u003cproject\u003e [--project-domain \u003cproject-domain\u003e]]"}],"source_content_type":"text/x-rst","patch_set":25,"id":"ba2be162_a1b77b38","line":20,"updated":"2017-03-03 17:56:00.000000000","message":"(ID only) instead of ID through out this file and in the help text in the associated .py file please","commit_id":"b645215953ae036bda43964cce6695a46da4a389"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"807368652dff7190a4094a7860f5df47badcf734","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Create a new network flavor profile"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":".. program:: network flavor profile create"},{"line_number":20,"context_line":".. code:: bash"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    openstack network flavor profile create"},{"line_number":23,"context_line":"        [--project \u003cproject\u003e [--project-domain \u003cproject-domain\u003e]]"}],"source_content_type":"text/x-rst","patch_set":25,"id":"ba2be162_1c25c509","line":20,"in_reply_to":"ba2be162_a1b77b38","updated":"2017-03-06 17:21:25.000000000","message":"Done","commit_id":"b645215953ae036bda43964cce6695a46da4a389"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"64fb8aa38d443e93b3390d22617c8deeef90c0d7","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    *Network version 2 only*"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":".. _network_flavor_profile_create:"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"network flavor profile delete"},{"line_number":69,"context_line":"-----------------------------"}],"source_content_type":"text/x-rst","patch_set":28,"id":"9a30ddce_5985dd04","line":66,"range":{"start_line":66,"start_character":0,"end_line":66,"end_character":34},"updated":"2017-03-10 16:03:18.000000000","message":"The place of this reference looks odd. unnecessary?","commit_id":"71aa7c207dac743f31799b7f620b80c8949325bb"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"419b516fd477920d5aae6e9e93f6b6bce3c2f3ce","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    *Network version 2 only*"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":".. _network_flavor_profile_create:"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"network flavor profile delete"},{"line_number":69,"context_line":"-----------------------------"}],"source_content_type":"text/x-rst","patch_set":28,"id":"9a30ddce_3670f30a","line":66,"range":{"start_line":66,"start_character":0,"end_line":66,"end_character":34},"in_reply_to":"9a30ddce_5985dd04","updated":"2017-03-13 15:36:16.000000000","message":"Done","commit_id":"71aa7c207dac743f31799b7f620b80c8949325bb"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"64fb8aa38d443e93b3390d22617c8deeef90c0d7","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    openstack network flavor profile delete"},{"line_number":77,"context_line":"        \u003cflavor-profile-id\u003e [\u003cflavor-profile-id\u003e ...]"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":".. _network_flavor_profile_delete:"},{"line_number":80,"context_line":".. describe:: \u003cflavor-profile-id\u003e"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    Flavor profile(s) to delete (ID only)"}],"source_content_type":"text/x-rst","patch_set":28,"id":"9a30ddce_f9b771d5","line":79,"range":{"start_line":79,"start_character":0,"end_line":79,"end_character":34},"updated":"2017-03-10 16:03:18.000000000","message":"Do we need this? If needed, is the current place appropriate?","commit_id":"71aa7c207dac743f31799b7f620b80c8949325bb"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"419b516fd477920d5aae6e9e93f6b6bce3c2f3ce","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    openstack network flavor profile delete"},{"line_number":77,"context_line":"        \u003cflavor-profile-id\u003e [\u003cflavor-profile-id\u003e ...]"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":".. _network_flavor_profile_delete:"},{"line_number":80,"context_line":".. describe:: \u003cflavor-profile-id\u003e"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    Flavor profile(s) to delete (ID only)"}],"source_content_type":"text/x-rst","patch_set":28,"id":"9a30ddce_566ba71d","line":79,"range":{"start_line":79,"start_character":0,"end_line":79,"end_character":34},"in_reply_to":"9a30ddce_f9b771d5","updated":"2017-03-13 15:36:16.000000000","message":"Done","commit_id":"71aa7c207dac743f31799b7f620b80c8949325bb"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"6b9dd1d00548b868c9272449d1e9b8d8bc73e665","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Network v2"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":".. _network_flavor_profile_create:"},{"line_number":15,"context_line":"network flavor profile create"},{"line_number":16,"context_line":"-----------------------------"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-rst","patch_set":29,"id":"1a1ced50_84b93bec","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":34},"updated":"2017-03-17 16:48:17.000000000","message":"These references aren\u0027t really necessary as they\u0027re not being used anywhere - see [1] for an example of how they\u0027re used. But there\u0027s no harm in including them for future documentation.\n\n[1] https://github.com/openstack/python-openstackclient/commit/85d598a9aca506ef7a9ef60bd5c85067ce1a2d7c","commit_id":"740535f1aa8fea59dd1b168620db84075806cdef"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"58182fdefaf8fba601f0ed107f358a9a30c24e0e","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Network v2"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":".. _network_flavor_profile_create:"},{"line_number":15,"context_line":"network flavor profile create"},{"line_number":16,"context_line":"-----------------------------"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-rst","patch_set":29,"id":"1a1ced50_e9728dac","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":34},"in_reply_to":"1a1ced50_84b93bec","updated":"2017-03-20 16:28:33.000000000","message":"Done","commit_id":"740535f1aa8fea59dd1b168620db84075806cdef"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"38c916989e88bc3bfe8de7c8ae6028b3acedfd57","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Network v2"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":".. _network_flavor_profile_create:"},{"line_number":15,"context_line":"network flavor profile create"},{"line_number":16,"context_line":"-----------------------------"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-rst","patch_set":29,"id":"1a1ced50_fa00c4ac","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":34},"in_reply_to":"1a1ced50_84b93bec","updated":"2017-03-17 17:48:16.000000000","message":"In addition, references for section titles are automatically generated by Sphinx. This is unnecessary unless we need cross reference explicitly.","commit_id":"740535f1aa8fea59dd1b168620db84075806cdef"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"58182fdefaf8fba601f0ed107f358a9a30c24e0e","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Network v2"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":".. _network_flavor_profile_create:"},{"line_number":15,"context_line":"network flavor profile create"},{"line_number":16,"context_line":"-----------------------------"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-rst","patch_set":29,"id":"1a1ced50_296585e0","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":34},"in_reply_to":"1a1ced50_fa00c4ac","updated":"2017-03-20 16:28:33.000000000","message":"Done","commit_id":"740535f1aa8fea59dd1b168620db84075806cdef"}],"openstackclient/network/v2/network_flavor_profile.py":[{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"2a5ebb6deee666a60aa24ca39aa773eed2f6c74a","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def _get_columns(item):"},{"line_number":30,"context_line":"    columns \u003d list(item.keys())"},{"line_number":31,"context_line":"    if \u0027tenant_id\u0027 in columns:"},{"line_number":32,"context_line":"        columns.remove(\u0027tenant_id\u0027)"},{"line_number":33,"context_line":"        columns.append(\u0027project_id\u0027)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    return tuple(sorted(columns))"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"def _get_attrs(client_manager, parsed_args):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_da487ecf","line":35,"range":{"start_line":30,"start_character":0,"end_line":35,"end_character":33},"updated":"2016-11-22 01:21:00.000000000","message":"Could be shortened to something like: \n\nreturn tuple(sorted([\u0027project_id\u0027 if val \u003d\u003d \u0027tenant_id\u0027 else val for val in item.keys()])\n\nBut it is up to you.","commit_id":"2eb982d0724524d6af408c2b27d8a75cee24cf3c"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"32c2eac757df5450dc085010d064e23b302a016e","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def _get_columns(item):"},{"line_number":30,"context_line":"    columns \u003d list(item.keys())"},{"line_number":31,"context_line":"    if \u0027tenant_id\u0027 in columns:"},{"line_number":32,"context_line":"        columns.remove(\u0027tenant_id\u0027)"},{"line_number":33,"context_line":"        columns.append(\u0027project_id\u0027)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    return tuple(sorted(columns))"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"def _get_attrs(client_manager, parsed_args):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_e91aa87b","line":35,"range":{"start_line":30,"start_character":0,"end_line":35,"end_character":33},"in_reply_to":"7a77a97e_da487ecf","updated":"2016-11-22 18:35:54.000000000","message":"Done.Thanks","commit_id":"2eb982d0724524d6af408c2b27d8a75cee24cf3c"},{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"2a5ebb6deee666a60aa24ca39aa773eed2f6c74a","unresolved":false,"context_lines":[{"line_number":38,"context_line":"def _get_attrs(client_manager, parsed_args):"},{"line_number":39,"context_line":"    attrs \u003d {}"},{"line_number":40,"context_line":"    if parsed_args.description is not None:"},{"line_number":41,"context_line":"        attrs[\u0027description\u0027] \u003d parsed_args.description"},{"line_number":42,"context_line":"    if parsed_args.driver is not None:"},{"line_number":43,"context_line":"        attrs[\u0027driver\u0027] \u003d parsed_args.driver"},{"line_number":44,"context_line":"    if parsed_args.metainfo is not None:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_f58f0b73","line":41,"range":{"start_line":41,"start_character":26,"end_line":41,"end_character":28},"updated":"2016-11-22 01:21:00.000000000","message":"is there a reason that for each of the `keys` the truth value is checked?","commit_id":"2eb982d0724524d6af408c2b27d8a75cee24cf3c"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"32c2eac757df5450dc085010d064e23b302a016e","unresolved":false,"context_lines":[{"line_number":38,"context_line":"def _get_attrs(client_manager, parsed_args):"},{"line_number":39,"context_line":"    attrs \u003d {}"},{"line_number":40,"context_line":"    if parsed_args.description is not None:"},{"line_number":41,"context_line":"        attrs[\u0027description\u0027] \u003d parsed_args.description"},{"line_number":42,"context_line":"    if parsed_args.driver is not None:"},{"line_number":43,"context_line":"        attrs[\u0027driver\u0027] \u003d parsed_args.driver"},{"line_number":44,"context_line":"    if parsed_args.metainfo is not None:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_6cf4e6ce","line":41,"range":{"start_line":41,"start_character":26,"end_line":41,"end_character":28},"in_reply_to":"7a77a97e_f58f0b73","updated":"2016-11-22 18:35:54.000000000","message":"I think all the args are optional here,thats why the \u0027none\u0027 condition is checked.\nAny positional arg won\u0027t be checked for none.","commit_id":"2eb982d0724524d6af408c2b27d8a75cee24cf3c"},{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"2a5ebb6deee666a60aa24ca39aa773eed2f6c74a","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"def _get_attrs(client_manager, parsed_args):"},{"line_number":39,"context_line":"    attrs \u003d {}"},{"line_number":40,"context_line":"    if parsed_args.description is not None:"},{"line_number":41,"context_line":"        attrs[\u0027description\u0027] \u003d parsed_args.description"},{"line_number":42,"context_line":"    if parsed_args.driver is not None:"},{"line_number":43,"context_line":"        attrs[\u0027driver\u0027] \u003d parsed_args.driver"},{"line_number":44,"context_line":"    if parsed_args.metainfo is not None:"},{"line_number":45,"context_line":"        attrs[\u0027metainfo\u0027] \u003d parsed_args.metainfo"},{"line_number":46,"context_line":"    if parsed_args.enable:"},{"line_number":47,"context_line":"        attrs[\u0027enabled\u0027] \u003d True"},{"line_number":48,"context_line":"    if parsed_args.disable:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_35cfc3b4","line":45,"range":{"start_line":40,"start_character":3,"end_line":45,"end_character":48},"updated":"2016-11-22 01:21:00.000000000","message":"The lines of code could be reduced by using something like what i have described below[1], but again, it is up to you, the comprehension would be created another dict, if you don\u0027t want that and you must truth to be checked, then you need not change anything.","commit_id":"2eb982d0724524d6af408c2b27d8a75cee24cf3c"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"32c2eac757df5450dc085010d064e23b302a016e","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"def _get_attrs(client_manager, parsed_args):"},{"line_number":39,"context_line":"    attrs \u003d {}"},{"line_number":40,"context_line":"    if parsed_args.description is not None:"},{"line_number":41,"context_line":"        attrs[\u0027description\u0027] \u003d parsed_args.description"},{"line_number":42,"context_line":"    if parsed_args.driver is not None:"},{"line_number":43,"context_line":"        attrs[\u0027driver\u0027] \u003d parsed_args.driver"},{"line_number":44,"context_line":"    if parsed_args.metainfo is not None:"},{"line_number":45,"context_line":"        attrs[\u0027metainfo\u0027] \u003d parsed_args.metainfo"},{"line_number":46,"context_line":"    if parsed_args.enable:"},{"line_number":47,"context_line":"        attrs[\u0027enabled\u0027] \u003d True"},{"line_number":48,"context_line":"    if parsed_args.disable:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_4c956a3e","line":45,"range":{"start_line":40,"start_character":3,"end_line":45,"end_character":48},"in_reply_to":"7a77a97e_35cfc3b4","updated":"2016-11-22 18:35:54.000000000","message":"I think the truth must be checked for reasons mentioned above,until I find a reason not to.If i don\u0027t need to,might change it to your suggestion as it definitely reduces the no. of lines of code.Thanks for the suggestion.","commit_id":"2eb982d0724524d6af408c2b27d8a75cee24cf3c"},{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"2a5ebb6deee666a60aa24ca39aa773eed2f6c74a","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        ).id"},{"line_number":57,"context_line":"        attrs[\u0027tenant_id\u0027] \u003d project_id"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    return attrs"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"class CreateNetworkFlavorProfile(command.ShowOne):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_55beffd4","line":59,"range":{"start_line":59,"start_character":11,"end_line":59,"end_character":16},"updated":"2016-11-22 01:21:00.000000000","message":"[1] {k:v for k, v in attrs.items() if v is not None}","commit_id":"2eb982d0724524d6af408c2b27d8a75cee24cf3c"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"32c2eac757df5450dc085010d064e23b302a016e","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        ).id"},{"line_number":57,"context_line":"        attrs[\u0027tenant_id\u0027] \u003d project_id"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    return attrs"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"class CreateNetworkFlavorProfile(command.ShowOne):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_8c9f825e","line":59,"range":{"start_line":59,"start_character":11,"end_line":59,"end_character":16},"in_reply_to":"7a77a97e_55beffd4","updated":"2016-11-22 18:35:54.000000000","message":"Same as above","commit_id":"2eb982d0724524d6af408c2b27d8a75cee24cf3c"},{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"2a5ebb6deee666a60aa24ca39aa773eed2f6c74a","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        parser.add_argument("},{"line_number":74,"context_line":"            \u0027--description\u0027,"},{"line_number":75,"context_line":"            metavar\u003d\"\u003cdescription\u003e\","},{"line_number":76,"context_line":"            help\u003d_(\u0027Description for the flavor profile.\u0027)"},{"line_number":77,"context_line":"        )"},{"line_number":78,"context_line":"        enable_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":79,"context_line":"        enable_group.add_argument("}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_35d26335","line":76,"range":{"start_line":76,"start_character":19,"end_line":76,"end_character":20},"updated":"2016-11-22 01:21:00.000000000","message":"styling nit: For uniformity sake, either use single quotes or double quotes, it better not to mix both","commit_id":"2eb982d0724524d6af408c2b27d8a75cee24cf3c"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"32c2eac757df5450dc085010d064e23b302a016e","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        parser.add_argument("},{"line_number":74,"context_line":"            \u0027--description\u0027,"},{"line_number":75,"context_line":"            metavar\u003d\"\u003cdescription\u003e\","},{"line_number":76,"context_line":"            help\u003d_(\u0027Description for the flavor profile.\u0027)"},{"line_number":77,"context_line":"        )"},{"line_number":78,"context_line":"        enable_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":79,"context_line":"        enable_group.add_argument("}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_4c7c8a20","line":76,"range":{"start_line":76,"start_character":19,"end_line":76,"end_character":20},"in_reply_to":"7a77a97e_35d26335","updated":"2016-11-22 18:35:54.000000000","message":"Done","commit_id":"2eb982d0724524d6af408c2b27d8a75cee24cf3c"},{"author":{"_account_id":18462,"name":"Rahul U Nair","email":"rahulunair@gmail.com","username":"rahulunair"},"change_message_id":"2a5ebb6deee666a60aa24ca39aa773eed2f6c74a","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                obj \u003d client.find_service_profile(flavor_profile,"},{"line_number":132,"context_line":"                                                  ignore_missing\u003dFalse)"},{"line_number":133,"context_line":"                client.delete_service_profile(obj)"},{"line_number":134,"context_line":"            except Exception as e:"},{"line_number":135,"context_line":"                result +\u003d 1"},{"line_number":136,"context_line":"                LOG.error(_(\"Failed to delete flavor profile with \""},{"line_number":137,"context_line":"                            \"ID \u0027%(flavor_profile)s\u0027: %(e)s\"),"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_d5ca0f6e","line":134,"range":{"start_line":134,"start_character":19,"end_line":134,"end_character":28},"updated":"2016-11-22 01:21:00.000000000","message":"use a specific exception if possible, rather than blanket Exception.\nAlso, it is always good to keep the exact line that you want exception handling for, in this case the line client.delete (as per the error message)","commit_id":"2eb982d0724524d6af408c2b27d8a75cee24cf3c"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"32c2eac757df5450dc085010d064e23b302a016e","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                obj \u003d client.find_service_profile(flavor_profile,"},{"line_number":132,"context_line":"                                                  ignore_missing\u003dFalse)"},{"line_number":133,"context_line":"                client.delete_service_profile(obj)"},{"line_number":134,"context_line":"            except Exception as e:"},{"line_number":135,"context_line":"                result +\u003d 1"},{"line_number":136,"context_line":"                LOG.error(_(\"Failed to delete flavor profile with \""},{"line_number":137,"context_line":"                            \"ID \u0027%(flavor_profile)s\u0027: %(e)s\"),"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_4cf80a7d","line":134,"range":{"start_line":134,"start_character":19,"end_line":134,"end_character":28},"in_reply_to":"7a77a97e_d5ca0f6e","updated":"2016-11-22 18:35:54.000000000","message":"I am getting multiple Exceptions here such as AssertionError, MismatchError...etc.\nThe underlying ResourceNotFound Exception is taken care at the sdk level for not finding the service_profile to delete.\nExample:https://github.com/openstack/python-openstacksdk/blob/master/openstack/network/v2/_proxy.py#L2336-L2351\nSo, currently staying with this.","commit_id":"2eb982d0724524d6af408c2b27d8a75cee24cf3c"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"6ccda6474efb93f135ad9947763de10f659735de","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def _get_columns(item):"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    return tuple(sorted([\u0027project_id\u0027 if val \u003d\u003d \u0027tenant_id\u0027"},{"line_number":30,"context_line":"        else val for val in item.keys()]))"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_38ddc870","line":29,"updated":"2016-11-22 20:17:19.000000000","message":"please refactor as per https://etherpad.openstack.org/p/osc-network-command-sdk-support","commit_id":"752cd164087368aedd61e2638f42b4b080e5621f"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"9da08e677f3e7feff1d9714a3453868ab230a1fb","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def _get_columns(item):"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    return tuple(sorted([\u0027project_id\u0027 if val \u003d\u003d \u0027tenant_id\u0027"},{"line_number":30,"context_line":"        else val for val in item.keys()]))"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a74a57a_51ee1323","line":29,"in_reply_to":"7a77a97e_38ddc870","updated":"2016-11-23 18:04:05.000000000","message":"Done","commit_id":"752cd164087368aedd61e2638f42b4b080e5621f"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"6ccda6474efb93f135ad9947763de10f659735de","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":82,"context_line":"            help\u003d_(\"Set the enabled flag to False.\")"},{"line_number":83,"context_line":"        )"},{"line_number":84,"context_line":"        parser.add_argument("},{"line_number":85,"context_line":"            \u0027--driver\u0027,"},{"line_number":86,"context_line":"            required\u003dTrue,"},{"line_number":87,"context_line":"            help\u003d_(\"Python module path to driver.\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_98d6dcef","line":84,"updated":"2016-11-22 20:17:19.000000000","message":"driver and metainfo should be a mutually exclusive group since it needs one or the other (Don\u0027t know if it can take both)","commit_id":"752cd164087368aedd61e2638f42b4b080e5621f"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"549c6a02f4f1d5f719a649fccade417934f2d8ca","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":82,"context_line":"            help\u003d_(\"Set the enabled flag to False.\")"},{"line_number":83,"context_line":"        )"},{"line_number":84,"context_line":"        parser.add_argument("},{"line_number":85,"context_line":"            \u0027--driver\u0027,"},{"line_number":86,"context_line":"            required\u003dTrue,"},{"line_number":87,"context_line":"            help\u003d_(\"Python module path to driver.\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a74a57a_b1a3e79d","line":84,"in_reply_to":"5a74a57a_71414f0b","updated":"2016-11-23 18:11:04.000000000","message":"Okay if this is the case remove the required\u003dTrue from --driver.\n\nand instead in take_action run a check. \n\nif parser_args.driver and parser_args.metainfo is None:\n\u003craise exception\u003e\n\nSimilar to https://github.com/openstack/python-openstackclient/blob/master/openstackclient/network/v2/security_group_rule.py#L619\n\nbut have the message return that --driver, --metainfo, or both are required","commit_id":"752cd164087368aedd61e2638f42b4b080e5621f"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"19cbfe1af22bc340203fe8eb077209a7fd7166dc","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":82,"context_line":"            help\u003d_(\"Set the enabled flag to False.\")"},{"line_number":83,"context_line":"        )"},{"line_number":84,"context_line":"        parser.add_argument("},{"line_number":85,"context_line":"            \u0027--driver\u0027,"},{"line_number":86,"context_line":"            required\u003dTrue,"},{"line_number":87,"context_line":"            help\u003d_(\"Python module path to driver.\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a74a57a_c559dd8f","line":84,"in_reply_to":"5a74a57a_b1a3e79d","updated":"2016-11-28 18:16:08.000000000","message":"Added the \u0027if\u0027 condition, Also enhanced the help msg for both --driver and --metainfo in PS7 for the user to get a better understanding.\nAnd removed the test_create_no_options from test_flavor_profile.py as there are no positional arguments.","commit_id":"752cd164087368aedd61e2638f42b4b080e5621f"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"9da08e677f3e7feff1d9714a3453868ab230a1fb","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":82,"context_line":"            help\u003d_(\"Set the enabled flag to False.\")"},{"line_number":83,"context_line":"        )"},{"line_number":84,"context_line":"        parser.add_argument("},{"line_number":85,"context_line":"            \u0027--driver\u0027,"},{"line_number":86,"context_line":"            required\u003dTrue,"},{"line_number":87,"context_line":"            help\u003d_(\"Python module path to driver.\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a74a57a_71414f0b","line":84,"in_reply_to":"7a77a97e_98d6dcef","updated":"2016-11-23 18:04:05.000000000","message":"It can take both,so I don\u0027t think they are mutually exclusive.\nThe either or here would mean that we need atleast one of the two to create a flavor profile.","commit_id":"752cd164087368aedd61e2638f42b4b080e5621f"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"6ccda6474efb93f135ad9947763de10f659735de","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        parser.add_argument("},{"line_number":113,"context_line":"            \u0027flavor_profile\u0027,"},{"line_number":114,"context_line":"            metavar\u003d\u0027\u003cflavor_profile\u003e\u0027,"},{"line_number":115,"context_line":"            nargs\u003d\u0027+\u0027,"},{"line_number":116,"context_line":"            help\u003d_(\u0027ID(s) or name(s) of flavor profile to delete\u0027)"},{"line_number":117,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_785580c4","line":114,"updated":"2016-11-22 20:17:19.000000000","message":"match comment in .rst","commit_id":"752cd164087368aedd61e2638f42b4b080e5621f"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"9da08e677f3e7feff1d9714a3453868ab230a1fb","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        parser.add_argument("},{"line_number":113,"context_line":"            \u0027flavor_profile\u0027,"},{"line_number":114,"context_line":"            metavar\u003d\u0027\u003cflavor_profile\u003e\u0027,"},{"line_number":115,"context_line":"            nargs\u003d\u0027+\u0027,"},{"line_number":116,"context_line":"            help\u003d_(\u0027ID(s) or name(s) of flavor profile to delete\u0027)"},{"line_number":117,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a74a57a_b14be72a","line":114,"in_reply_to":"7a77a97e_785580c4","updated":"2016-11-23 18:04:05.000000000","message":"Done","commit_id":"752cd164087368aedd61e2638f42b4b080e5621f"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"3f8b37b84c3243c6947d73e3f12c59bdafc798fe","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        columns \u003d _get_columns(obj)"},{"line_number":105,"context_line":"        data \u003d utils.get_item_properties(obj, columns, formatters\u003d{})"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        if parsed_args.driver is None and parsed_args.metainfo is None:"},{"line_number":108,"context_line":"            msg \u003d _(\"Either --driver or --metainfo or both are required\")"},{"line_number":109,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a74a57a_95e0ee2a","line":107,"updated":"2016-11-28 21:48:37.000000000","message":"Move this check to before client.create_service_profile","commit_id":"c1ca820ecab66dd112b1abe6122bde2df761fca5"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"fe2b10e88d3b46b30675c4de429a36066a96fe7a","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        columns \u003d _get_columns(obj)"},{"line_number":105,"context_line":"        data \u003d utils.get_item_properties(obj, columns, formatters\u003d{})"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        if parsed_args.driver is None and parsed_args.metainfo is None:"},{"line_number":108,"context_line":"            msg \u003d _(\"Either --driver or --metainfo or both are required\")"},{"line_number":109,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a74a57a_29f875c4","line":107,"in_reply_to":"5a74a57a_95e0ee2a","updated":"2016-11-29 17:00:07.000000000","message":"Done","commit_id":"c1ca820ecab66dd112b1abe6122bde2df761fca5"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"761218c6619845b2855b78faa6797c86a0d3545c","unresolved":false,"context_lines":[{"line_number":24,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def _get_columns(item):"},{"line_number":28,"context_line":"    columns \u003d list(item.keys())"},{"line_number":29,"context_line":"    if \u0027tenant_id\u0027 in columns:"},{"line_number":30,"context_line":"        columns.remove(\u0027tenant_id\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a71b18c_de949ce3","line":27,"updated":"2016-12-04 19:24:47.000000000","message":"Refactor get_columns for the SDK refactor please\n\n[1]: https://etherpad.openstack.org/p/osc-network-command-sdk-support\n[2]: https://review.openstack.org/#/c/401033/","commit_id":"a73b0a04e964e8ba458cc149d1ec4eacf8e8e5a9"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"657e843531d57a72d1945ecf72d57855254fe78d","unresolved":false,"context_lines":[{"line_number":24,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def _get_columns(item):"},{"line_number":28,"context_line":"    columns \u003d list(item.keys())"},{"line_number":29,"context_line":"    if \u0027tenant_id\u0027 in columns:"},{"line_number":30,"context_line":"        columns.remove(\u0027tenant_id\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a71b18c_97c3c256","line":27,"in_reply_to":"3a71b18c_de949ce3","updated":"2016-12-05 17:49:16.000000000","message":"Done","commit_id":"a73b0a04e964e8ba458cc149d1ec4eacf8e8e5a9"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"761218c6619845b2855b78faa6797c86a0d3545c","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"class CreateNetworkFlavorProfile(command.ShowOne):"},{"line_number":61,"context_line":"    \"\"\"Create a Neutron service flavor profile\"\"\""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def get_parser(self, prog_name):"},{"line_number":64,"context_line":"        parser \u003d super(CreateNetworkFlavorProfile, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a71b18c_9e8a24be","line":61,"updated":"2016-12-04 19:24:47.000000000","message":"replace all docstrings.\n\ninstead of \"\"\"\u003cdocstring\u003e\"\"\"\n\n_description \u003d _(\"\u003cdocstring\u003e\")\n\nas to support translations\n\nThanks","commit_id":"a73b0a04e964e8ba458cc149d1ec4eacf8e8e5a9"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"657e843531d57a72d1945ecf72d57855254fe78d","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"class CreateNetworkFlavorProfile(command.ShowOne):"},{"line_number":61,"context_line":"    \"\"\"Create a Neutron service flavor profile\"\"\""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def get_parser(self, prog_name):"},{"line_number":64,"context_line":"        parser \u003d super(CreateNetworkFlavorProfile, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a71b18c_d7a7faba","line":61,"in_reply_to":"3a71b18c_9e8a24be","updated":"2016-12-05 17:49:16.000000000","message":"Done","commit_id":"a73b0a04e964e8ba458cc149d1ec4eacf8e8e5a9"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"0fb051421c9dbfedc5a3b5d69d145eaa002953a3","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"def _get_columns(item):"},{"line_number":29,"context_line":"    column_map \u003d {"},{"line_number":30,"context_line":"        \u0027tenant_id\u0027: \u0027project_id\u0027,"},{"line_number":31,"context_line":"    }"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3a71b18c_f9282f88","line":29,"range":{"start_line":29,"start_character":4,"end_line":29,"end_character":14},"updated":"2016-12-06 20:46:26.000000000","message":"enabled to is_enabled","commit_id":"b189e273d71cf05eef0d64558b6305afaea1affd"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"92b3a9f3b885050274844e4823df503803deb93c","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"def _get_columns(item):"},{"line_number":29,"context_line":"    column_map \u003d {"},{"line_number":30,"context_line":"        \u0027tenant_id\u0027: \u0027project_id\u0027,"},{"line_number":31,"context_line":"    }"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3a71b18c_2d667a29","line":29,"range":{"start_line":29,"start_character":4,"end_line":29,"end_character":14},"in_reply_to":"3a71b18c_f9282f88","updated":"2016-12-08 20:05:42.000000000","message":"Done","commit_id":"b189e273d71cf05eef0d64558b6305afaea1affd"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"0fb051421c9dbfedc5a3b5d69d145eaa002953a3","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    return attrs"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"class CreateNetworkFlavorProfile(command.ShowOne):"},{"line_number":61,"context_line":"    _description \u003d _(\"Create a Neutron service flavor profile\")"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3a71b18c_391f075c","line":59,"updated":"2016-12-06 20:46:26.000000000","message":"add a TODO here as per https://etherpad.openstack.org/p/osc-network-command-sdk-support","commit_id":"b189e273d71cf05eef0d64558b6305afaea1affd"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"92b3a9f3b885050274844e4823df503803deb93c","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    return attrs"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"class CreateNetworkFlavorProfile(command.ShowOne):"},{"line_number":61,"context_line":"    _description \u003d _(\"Create a Neutron service flavor profile\")"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3a71b18c_8d778ed3","line":59,"in_reply_to":"3a71b18c_391f075c","updated":"2016-12-08 20:05:42.000000000","message":"Done","commit_id":"b189e273d71cf05eef0d64558b6305afaea1affd"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"0fb051421c9dbfedc5a3b5d69d145eaa002953a3","unresolved":false,"context_lines":[{"line_number":157,"context_line":"            \u0027id\u0027,"},{"line_number":158,"context_line":"            \u0027description\u0027,"},{"line_number":159,"context_line":"            \u0027driver\u0027,"},{"line_number":160,"context_line":"            \u0027enabled\u0027,"},{"line_number":161,"context_line":"            \u0027metainfo\u0027,"},{"line_number":162,"context_line":"        )"},{"line_number":163,"context_line":"        column_headers \u003d ("}],"source_content_type":"text/x-python","patch_set":11,"id":"3a71b18c_79441f49","line":160,"range":{"start_line":160,"start_character":13,"end_line":160,"end_character":20},"updated":"2016-12-06 20:46:26.000000000","message":"is_enabled","commit_id":"b189e273d71cf05eef0d64558b6305afaea1affd"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"92b3a9f3b885050274844e4823df503803deb93c","unresolved":false,"context_lines":[{"line_number":157,"context_line":"            \u0027id\u0027,"},{"line_number":158,"context_line":"            \u0027description\u0027,"},{"line_number":159,"context_line":"            \u0027driver\u0027,"},{"line_number":160,"context_line":"            \u0027enabled\u0027,"},{"line_number":161,"context_line":"            \u0027metainfo\u0027,"},{"line_number":162,"context_line":"        )"},{"line_number":163,"context_line":"        column_headers \u003d ("}],"source_content_type":"text/x-python","patch_set":11,"id":"3a71b18c_ad728ae1","line":160,"range":{"start_line":160,"start_character":13,"end_line":160,"end_character":20},"in_reply_to":"3a71b18c_79441f49","updated":"2016-12-08 20:05:42.000000000","message":"Done","commit_id":"b189e273d71cf05eef0d64558b6305afaea1affd"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"0fb051421c9dbfedc5a3b5d69d145eaa002953a3","unresolved":false,"context_lines":[{"line_number":195,"context_line":"        data \u003d utils.get_item_properties(obj, columns)"},{"line_number":196,"context_line":"        return (display_columns, data)"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"class SetNetworkFlavorProfile(command.Command):"},{"line_number":200,"context_line":"    _description \u003d _(\"Update a Neutron service flavor profile.\")"},{"line_number":201,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3a71b18c_f9766fa2","line":198,"updated":"2016-12-06 20:46:26.000000000","message":"add a TODO","commit_id":"b189e273d71cf05eef0d64558b6305afaea1affd"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"92b3a9f3b885050274844e4823df503803deb93c","unresolved":false,"context_lines":[{"line_number":195,"context_line":"        data \u003d utils.get_item_properties(obj, columns)"},{"line_number":196,"context_line":"        return (display_columns, data)"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"class SetNetworkFlavorProfile(command.Command):"},{"line_number":200,"context_line":"    _description \u003d _(\"Update a Neutron service flavor profile.\")"},{"line_number":201,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3a71b18c_ed7c82b7","line":198,"in_reply_to":"3a71b18c_f9766fa2","updated":"2016-12-08 20:05:42.000000000","message":"Done","commit_id":"b189e273d71cf05eef0d64558b6305afaea1affd"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"505d8bbdeda761284ddad4ecc036309dfd534a42","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        parser.add_argument("},{"line_number":75,"context_line":"            \u0027--description\u0027,"},{"line_number":76,"context_line":"            metavar\u003d\"\u003cdescription\u003e\","},{"line_number":77,"context_line":"            help\u003d_(\"Description for the flavor profile.\")"},{"line_number":78,"context_line":"        )"},{"line_number":79,"context_line":"        enable_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":80,"context_line":"        enable_group.add_argument("}],"source_content_type":"text/x-python","patch_set":14,"id":"ba5201f7_e27848fb","line":77,"range":{"start_line":77,"start_character":54,"end_line":77,"end_character":55},"updated":"2016-12-29 20:18:02.000000000","message":"ditto","commit_id":"d2f9ea10812550f211f65505d1ba328d70317156"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"a489c95155578baa9478d6bcf710d25a09ebfc8c","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        parser.add_argument("},{"line_number":75,"context_line":"            \u0027--description\u0027,"},{"line_number":76,"context_line":"            metavar\u003d\"\u003cdescription\u003e\","},{"line_number":77,"context_line":"            help\u003d_(\"Description for the flavor profile.\")"},{"line_number":78,"context_line":"        )"},{"line_number":79,"context_line":"        enable_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":80,"context_line":"        enable_group.add_argument("}],"source_content_type":"text/x-python","patch_set":14,"id":"ba5201f7_40770c3b","line":77,"range":{"start_line":77,"start_character":54,"end_line":77,"end_character":55},"in_reply_to":"ba5201f7_e27848fb","updated":"2017-01-10 18:11:36.000000000","message":"Done","commit_id":"d2f9ea10812550f211f65505d1ba328d70317156"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"505d8bbdeda761284ddad4ecc036309dfd534a42","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        parser \u003d super(DeleteNetworkFlavorProfile, self).get_parser(prog_name)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        parser.add_argument("},{"line_number":125,"context_line":"            \u0027flavor_profile\u0027,"},{"line_number":126,"context_line":"            metavar\u003d\u0027\u003cflavor-profile\u003e\u0027,"},{"line_number":127,"context_line":"            nargs\u003d\u0027+\u0027,"},{"line_number":128,"context_line":"            help\u003d_(\"Flavor profile to delete(ID)\")"}],"source_content_type":"text/x-python","patch_set":14,"id":"ba5201f7_826a1c19","line":125,"range":{"start_line":125,"start_character":13,"end_line":125,"end_character":27},"updated":"2016-12-29 20:18:02.000000000","message":"this should be flavor-profile","commit_id":"d2f9ea10812550f211f65505d1ba328d70317156"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"60f1f247f70a7aa8c34da3a3de9ec077057581ea","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        parser \u003d super(DeleteNetworkFlavorProfile, self).get_parser(prog_name)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        parser.add_argument("},{"line_number":125,"context_line":"            \u0027flavor_profile\u0027,"},{"line_number":126,"context_line":"            metavar\u003d\u0027\u003cflavor-profile\u003e\u0027,"},{"line_number":127,"context_line":"            nargs\u003d\u0027+\u0027,"},{"line_number":128,"context_line":"            help\u003d_(\"Flavor profile to delete(ID)\")"}],"source_content_type":"text/x-python","patch_set":14,"id":"ba5201f7_a430c5e9","line":125,"in_reply_to":"ba5201f7_826a1c19","updated":"2017-01-03 22:33:04.000000000","message":"Actually these are positional arguments, and here \u0027flavor_profile\u0027 is the key/attribute in the Namespace object from argparse, and is correct.  This is not displayed, only the metavar below is visible for positional args.","commit_id":"d2f9ea10812550f211f65505d1ba328d70317156"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"505d8bbdeda761284ddad4ecc036309dfd534a42","unresolved":false,"context_lines":[{"line_number":141,"context_line":"            except Exception as e:"},{"line_number":142,"context_line":"                result +\u003d 1"},{"line_number":143,"context_line":"                LOG.error(_(\"Failed to delete flavor profile with \""},{"line_number":144,"context_line":"                            \"ID \u0027%(flavor_profile)s\u0027: %(e)s\"),"},{"line_number":145,"context_line":"                          {\"flavor_profile\": flavor_profile, \"e\": e})"},{"line_number":146,"context_line":"        if result \u003e 0:"},{"line_number":147,"context_line":"            total \u003d len(parsed_args.flavor_profile)"}],"source_content_type":"text/x-python","patch_set":14,"id":"ba5201f7_02654c44","line":144,"range":{"start_line":144,"start_character":35,"end_line":144,"end_character":49},"updated":"2016-12-29 20:18:02.000000000","message":"ditto","commit_id":"d2f9ea10812550f211f65505d1ba328d70317156"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"505d8bbdeda761284ddad4ecc036309dfd534a42","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                result +\u003d 1"},{"line_number":143,"context_line":"                LOG.error(_(\"Failed to delete flavor profile with \""},{"line_number":144,"context_line":"                            \"ID \u0027%(flavor_profile)s\u0027: %(e)s\"),"},{"line_number":145,"context_line":"                          {\"flavor_profile\": flavor_profile, \"e\": e})"},{"line_number":146,"context_line":"        if result \u003e 0:"},{"line_number":147,"context_line":"            total \u003d len(parsed_args.flavor_profile)"},{"line_number":148,"context_line":"            msg \u003d (_(\"%(result)s of %(total)s flavor_profiles failed \""}],"source_content_type":"text/x-python","patch_set":14,"id":"ba5201f7_225a5084","line":145,"range":{"start_line":145,"start_character":28,"end_line":145,"end_character":59},"updated":"2016-12-29 20:18:02.000000000","message":"ditto","commit_id":"d2f9ea10812550f211f65505d1ba328d70317156"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"60f1f247f70a7aa8c34da3a3de9ec077057581ea","unresolved":false,"context_lines":[{"line_number":201,"context_line":""},{"line_number":202,"context_line":"# TODO(ndahiwade): Use the SDK resource mapped attribute names once the"},{"line_number":203,"context_line":"# OSC minimum requirements include SDK 1.0."},{"line_number":204,"context_line":"class SetNetworkFlavorProfile(command.Command):"},{"line_number":205,"context_line":"    _description \u003d _(\"Update a network flavor profile.\")"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def get_parser(self, prog_name):"}],"source_content_type":"text/x-python","patch_set":14,"id":"ba5201f7_a45e0510","line":204,"updated":"2017-01-03 22:33:04.000000000","message":"Sort the classes in this file (set before show)","commit_id":"d2f9ea10812550f211f65505d1ba328d70317156"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"a489c95155578baa9478d6bcf710d25a09ebfc8c","unresolved":false,"context_lines":[{"line_number":201,"context_line":""},{"line_number":202,"context_line":"# TODO(ndahiwade): Use the SDK resource mapped attribute names once the"},{"line_number":203,"context_line":"# OSC minimum requirements include SDK 1.0."},{"line_number":204,"context_line":"class SetNetworkFlavorProfile(command.Command):"},{"line_number":205,"context_line":"    _description \u003d _(\"Update a network flavor profile.\")"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def get_parser(self, prog_name):"}],"source_content_type":"text/x-python","patch_set":14,"id":"ba5201f7_c0913c48","line":204,"in_reply_to":"ba5201f7_a45e0510","updated":"2017-01-10 18:11:36.000000000","message":"Done","commit_id":"d2f9ea10812550f211f65505d1ba328d70317156"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"505d8bbdeda761284ddad4ecc036309dfd534a42","unresolved":false,"context_lines":[{"line_number":202,"context_line":"# TODO(ndahiwade): Use the SDK resource mapped attribute names once the"},{"line_number":203,"context_line":"# OSC minimum requirements include SDK 1.0."},{"line_number":204,"context_line":"class SetNetworkFlavorProfile(command.Command):"},{"line_number":205,"context_line":"    _description \u003d _(\"Update a network flavor profile.\")"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def get_parser(self, prog_name):"},{"line_number":208,"context_line":"        parser \u003d super(SetNetworkFlavorProfile, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":14,"id":"ba5201f7_82513c65","line":205,"range":{"start_line":205,"start_character":22,"end_line":205,"end_character":54},"updated":"2016-12-29 20:18:02.000000000","message":"Set network flavor profile properties","commit_id":"d2f9ea10812550f211f65505d1ba328d70317156"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"a489c95155578baa9478d6bcf710d25a09ebfc8c","unresolved":false,"context_lines":[{"line_number":202,"context_line":"# TODO(ndahiwade): Use the SDK resource mapped attribute names once the"},{"line_number":203,"context_line":"# OSC minimum requirements include SDK 1.0."},{"line_number":204,"context_line":"class SetNetworkFlavorProfile(command.Command):"},{"line_number":205,"context_line":"    _description \u003d _(\"Update a network flavor profile.\")"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def get_parser(self, prog_name):"},{"line_number":208,"context_line":"        parser \u003d super(SetNetworkFlavorProfile, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":14,"id":"ba5201f7_009c245c","line":205,"range":{"start_line":205,"start_character":22,"end_line":205,"end_character":54},"in_reply_to":"ba5201f7_82513c65","updated":"2017-01-10 18:11:36.000000000","message":"Done","commit_id":"d2f9ea10812550f211f65505d1ba328d70317156"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"505d8bbdeda761284ddad4ecc036309dfd534a42","unresolved":false,"context_lines":[{"line_number":207,"context_line":"    def get_parser(self, prog_name):"},{"line_number":208,"context_line":"        parser \u003d super(SetNetworkFlavorProfile, self).get_parser(prog_name)"},{"line_number":209,"context_line":"        parser.add_argument("},{"line_number":210,"context_line":"            \u0027flavor_profile\u0027,"},{"line_number":211,"context_line":"            metavar\u003d\"\u003cflavor-profile\u003e\","},{"line_number":212,"context_line":"            help\u003d_(\"Flavor profile to update(ID)\")"},{"line_number":213,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":14,"id":"ba5201f7_a24e40bf","line":210,"range":{"start_line":210,"start_character":13,"end_line":210,"end_character":27},"updated":"2016-12-29 20:18:02.000000000","message":"/s/flavor_profile/flavor-profile","commit_id":"d2f9ea10812550f211f65505d1ba328d70317156"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a7bdf8f0d88a95a99035a50f8f7e9d3f353e1e3b","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        )"},{"line_number":90,"context_line":"        parser.add_argument("},{"line_number":91,"context_line":"            \u0027--driver\u0027,"},{"line_number":92,"context_line":"            help\u003d_(\"Python module path to driver.This becomes \""},{"line_number":93,"context_line":"                   \"required if --metainfo is missing and vice versa\")"},{"line_number":94,"context_line":"        )"},{"line_number":95,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":22,"id":"ba2be162_5ca8ef1f","line":92,"range":{"start_line":92,"start_character":49,"end_line":92,"end_character":53},"updated":"2017-03-01 13:00:44.000000000","message":"A space before \"This\".","commit_id":"e068b1826d2fbd7982a37dfeef9683736c01a8c3"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"841f55d9fae3a0e06948c210d293008f22a8640a","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        )"},{"line_number":90,"context_line":"        parser.add_argument("},{"line_number":91,"context_line":"            \u0027--driver\u0027,"},{"line_number":92,"context_line":"            help\u003d_(\"Python module path to driver.This becomes \""},{"line_number":93,"context_line":"                   \"required if --metainfo is missing and vice versa\")"},{"line_number":94,"context_line":"        )"},{"line_number":95,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":22,"id":"ba2be162_474d6f71","line":92,"range":{"start_line":92,"start_character":49,"end_line":92,"end_character":53},"in_reply_to":"ba2be162_5ca8ef1f","updated":"2017-03-01 16:21:13.000000000","message":"Done","commit_id":"e068b1826d2fbd7982a37dfeef9683736c01a8c3"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a7bdf8f0d88a95a99035a50f8f7e9d3f353e1e3b","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        )"},{"line_number":95,"context_line":"        parser.add_argument("},{"line_number":96,"context_line":"            \u0027--metainfo\u0027,"},{"line_number":97,"context_line":"            help\u003d_(\"Metainfo for the flavor profile.This becomes \""},{"line_number":98,"context_line":"                   \"required if --driver is missing and vice versa \")"},{"line_number":99,"context_line":"        )"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"ba2be162_3cab3b1f","line":97,"range":{"start_line":97,"start_character":52,"end_line":97,"end_character":56},"updated":"2017-03-01 13:00:44.000000000","message":"A space before \"This\".","commit_id":"e068b1826d2fbd7982a37dfeef9683736c01a8c3"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"841f55d9fae3a0e06948c210d293008f22a8640a","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        )"},{"line_number":95,"context_line":"        parser.add_argument("},{"line_number":96,"context_line":"            \u0027--metainfo\u0027,"},{"line_number":97,"context_line":"            help\u003d_(\"Metainfo for the flavor profile.This becomes \""},{"line_number":98,"context_line":"                   \"required if --driver is missing and vice versa \")"},{"line_number":99,"context_line":"        )"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"ba2be162_67527315","line":97,"range":{"start_line":97,"start_character":52,"end_line":97,"end_character":56},"in_reply_to":"ba2be162_3cab3b1f","updated":"2017-03-01 16:21:13.000000000","message":"Done","commit_id":"e068b1826d2fbd7982a37dfeef9683736c01a8c3"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a7bdf8f0d88a95a99035a50f8f7e9d3f353e1e3b","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            \u0027flavor_profile\u0027,"},{"line_number":126,"context_line":"            metavar\u003d\u0027\u003cflavor-profile\u003e\u0027,"},{"line_number":127,"context_line":"            nargs\u003d\u0027+\u0027,"},{"line_number":128,"context_line":"            help\u003d_(\"Flavor profile to delete(ID)\")"},{"line_number":129,"context_line":"        )"},{"line_number":130,"context_line":"        return parser"},{"line_number":131,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"ba2be162_3f1ecd63","line":128,"range":{"start_line":128,"start_character":44,"end_line":128,"end_character":48},"updated":"2017-03-01 13:00:44.000000000","message":"-\u003e (ID only)\n\nA space is required before \u0027(\u0027","commit_id":"e068b1826d2fbd7982a37dfeef9683736c01a8c3"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"841f55d9fae3a0e06948c210d293008f22a8640a","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            \u0027flavor_profile\u0027,"},{"line_number":126,"context_line":"            metavar\u003d\u0027\u003cflavor-profile\u003e\u0027,"},{"line_number":127,"context_line":"            nargs\u003d\u0027+\u0027,"},{"line_number":128,"context_line":"            help\u003d_(\"Flavor profile to delete(ID)\")"},{"line_number":129,"context_line":"        )"},{"line_number":130,"context_line":"        return parser"},{"line_number":131,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"ba2be162_87576701","line":128,"range":{"start_line":128,"start_character":44,"end_line":128,"end_character":48},"in_reply_to":"ba2be162_3f1ecd63","updated":"2017-03-01 16:21:13.000000000","message":"Done","commit_id":"e068b1826d2fbd7982a37dfeef9683736c01a8c3"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a7bdf8f0d88a95a99035a50f8f7e9d3f353e1e3b","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        parser.add_argument("},{"line_number":189,"context_line":"            \u0027flavor_profile\u0027,"},{"line_number":190,"context_line":"            metavar\u003d\"\u003cflavor-profile\u003e\","},{"line_number":191,"context_line":"            help\u003d_(\"Flavor profile to update(ID)\")"},{"line_number":192,"context_line":"        )"},{"line_number":193,"context_line":"        identity_common.add_project_domain_option_to_parser(parser)"},{"line_number":194,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":22,"id":"ba2be162_df5cd127","line":191,"range":{"start_line":191,"start_character":44,"end_line":191,"end_character":48},"updated":"2017-03-01 13:00:44.000000000","message":"-\u003e (ID only)\n\nAlso a space is needed before (.","commit_id":"e068b1826d2fbd7982a37dfeef9683736c01a8c3"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"841f55d9fae3a0e06948c210d293008f22a8640a","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        parser.add_argument("},{"line_number":189,"context_line":"            \u0027flavor_profile\u0027,"},{"line_number":190,"context_line":"            metavar\u003d\"\u003cflavor-profile\u003e\","},{"line_number":191,"context_line":"            help\u003d_(\"Flavor profile to update(ID)\")"},{"line_number":192,"context_line":"        )"},{"line_number":193,"context_line":"        identity_common.add_project_domain_option_to_parser(parser)"},{"line_number":194,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":22,"id":"ba2be162_a75c6b26","line":191,"range":{"start_line":191,"start_character":44,"end_line":191,"end_character":48},"in_reply_to":"ba2be162_df5cd127","updated":"2017-03-01 16:21:13.000000000","message":"Done","commit_id":"e068b1826d2fbd7982a37dfeef9683736c01a8c3"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a7bdf8f0d88a95a99035a50f8f7e9d3f353e1e3b","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        parser.add_argument("},{"line_number":238,"context_line":"            \u0027flavor_profile\u0027,"},{"line_number":239,"context_line":"            metavar\u003d\u0027\u003cflavor-profile\u003e\u0027,"},{"line_number":240,"context_line":"            help\u003d_(\"Flavor profile to display(ID)\")"},{"line_number":241,"context_line":"        )"},{"line_number":242,"context_line":"        return parser"},{"line_number":243,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"ba2be162_5f49c15e","line":240,"range":{"start_line":240,"start_character":45,"end_line":240,"end_character":49},"updated":"2017-03-01 13:00:44.000000000","message":"Same comment as for show and delete.","commit_id":"e068b1826d2fbd7982a37dfeef9683736c01a8c3"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"841f55d9fae3a0e06948c210d293008f22a8640a","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        parser.add_argument("},{"line_number":238,"context_line":"            \u0027flavor_profile\u0027,"},{"line_number":239,"context_line":"            metavar\u003d\u0027\u003cflavor-profile\u003e\u0027,"},{"line_number":240,"context_line":"            help\u003d_(\"Flavor profile to display(ID)\")"},{"line_number":241,"context_line":"        )"},{"line_number":242,"context_line":"        return parser"},{"line_number":243,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"ba2be162_c7415f3b","line":240,"range":{"start_line":240,"start_character":45,"end_line":240,"end_character":49},"in_reply_to":"ba2be162_5f49c15e","updated":"2017-03-01 16:21:13.000000000","message":"Done","commit_id":"e068b1826d2fbd7982a37dfeef9683736c01a8c3"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"0857cc81df23a757fae6728b6cfd9dc418f00afe","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        parser.add_argument("},{"line_number":96,"context_line":"            \u0027--metainfo\u0027,"},{"line_number":97,"context_line":"            help\u003d_(\"Metainfo for the flavor profile. This becomes \""},{"line_number":98,"context_line":"                   \"required if --driver is missing and vice versa \")"},{"line_number":99,"context_line":"        )"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":29,"id":"1a1ced50_2577973b","line":98,"range":{"start_line":98,"start_character":66,"end_line":98,"end_character":67},"updated":"2017-03-18 00:41:02.000000000","message":"nut: extra space","commit_id":"740535f1aa8fea59dd1b168620db84075806cdef"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"58182fdefaf8fba601f0ed107f358a9a30c24e0e","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        parser.add_argument("},{"line_number":96,"context_line":"            \u0027--metainfo\u0027,"},{"line_number":97,"context_line":"            help\u003d_(\"Metainfo for the flavor profile. This becomes \""},{"line_number":98,"context_line":"                   \"required if --driver is missing and vice versa \")"},{"line_number":99,"context_line":"        )"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":29,"id":"1a1ced50_496481e3","line":98,"range":{"start_line":98,"start_character":66,"end_line":98,"end_character":67},"in_reply_to":"1a1ced50_2577973b","updated":"2017-03-20 16:28:33.000000000","message":"Done","commit_id":"740535f1aa8fea59dd1b168620db84075806cdef"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"0857cc81df23a757fae6728b6cfd9dc418f00afe","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            \u0027flavor_profile\u0027,"},{"line_number":126,"context_line":"            metavar\u003d\u0027\u003cflavor-profile\u003e\u0027,"},{"line_number":127,"context_line":"            nargs\u003d\u0027+\u0027,"},{"line_number":128,"context_line":"            help\u003d_(\"Flavor profile to delete (ID only)\")"},{"line_number":129,"context_line":"        )"},{"line_number":130,"context_line":"        return parser"},{"line_number":131,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"1a1ced50_c587a30d","line":128,"updated":"2017-03-18 00:41:02.000000000","message":"(s) since  you allow multiple deletes","commit_id":"740535f1aa8fea59dd1b168620db84075806cdef"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"58182fdefaf8fba601f0ed107f358a9a30c24e0e","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            \u0027flavor_profile\u0027,"},{"line_number":126,"context_line":"            metavar\u003d\u0027\u003cflavor-profile\u003e\u0027,"},{"line_number":127,"context_line":"            nargs\u003d\u0027+\u0027,"},{"line_number":128,"context_line":"            help\u003d_(\"Flavor profile to delete (ID only)\")"},{"line_number":129,"context_line":"        )"},{"line_number":130,"context_line":"        return parser"},{"line_number":131,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"1a1ced50_695f7d0e","line":128,"in_reply_to":"1a1ced50_c587a30d","updated":"2017-03-20 16:28:33.000000000","message":"Done","commit_id":"740535f1aa8fea59dd1b168620db84075806cdef"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"0857cc81df23a757fae6728b6cfd9dc418f00afe","unresolved":false,"context_lines":[{"line_number":215,"context_line":"        parser.add_argument("},{"line_number":216,"context_line":"            \u0027--metainfo\u0027,"},{"line_number":217,"context_line":"            help\u003d_(\"Metainfo for the flavor profile. This becomes \""},{"line_number":218,"context_line":"                   \"required if --driver is missing and vice versa \")"},{"line_number":219,"context_line":"        )"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":29,"id":"1a1ced50_658fcf23","line":218,"range":{"start_line":218,"start_character":66,"end_line":218,"end_character":67},"updated":"2017-03-18 00:41:02.000000000","message":"ditto","commit_id":"740535f1aa8fea59dd1b168620db84075806cdef"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"58182fdefaf8fba601f0ed107f358a9a30c24e0e","unresolved":false,"context_lines":[{"line_number":215,"context_line":"        parser.add_argument("},{"line_number":216,"context_line":"            \u0027--metainfo\u0027,"},{"line_number":217,"context_line":"            help\u003d_(\"Metainfo for the flavor profile. This becomes \""},{"line_number":218,"context_line":"                   \"required if --driver is missing and vice versa \")"},{"line_number":219,"context_line":"        )"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":29,"id":"1a1ced50_a99fb5b2","line":218,"range":{"start_line":218,"start_character":66,"end_line":218,"end_character":67},"in_reply_to":"1a1ced50_658fcf23","updated":"2017-03-20 16:28:33.000000000","message":"Done","commit_id":"740535f1aa8fea59dd1b168620db84075806cdef"}],"openstackclient/tests/functional/network/v2/test_network_flavor_profile.py":[{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"6ccda6474efb93f135ad9947763de10f659735de","unresolved":false,"context_lines":[{"line_number":30,"context_line":"                                   \u0027 --description \u0027 + str(cls.DESCRIPTION) +"},{"line_number":31,"context_line":"                                   \u0027--metainfo \u0027 + cls.METAINFO +"},{"line_number":32,"context_line":"                                   opts)"},{"line_number":33,"context_line":"        cls.assertOutput(cls.ID + \"\\n\", raw_output)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @classmethod"},{"line_number":36,"context_line":"    def tearDownClass(cls):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_1812cc09","line":33,"updated":"2016-11-22 20:17:19.000000000","message":"somewhere here set cls.ID \u003d \u003cthe Id of created profile\u003e\n\notherwise your delete doesn\u0027t do anything","commit_id":"752cd164087368aedd61e2638f42b4b080e5621f"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"9da08e677f3e7feff1d9714a3453868ab230a1fb","unresolved":false,"context_lines":[{"line_number":30,"context_line":"                                   \u0027 --description \u0027 + str(cls.DESCRIPTION) +"},{"line_number":31,"context_line":"                                   \u0027--metainfo \u0027 + cls.METAINFO +"},{"line_number":32,"context_line":"                                   opts)"},{"line_number":33,"context_line":"        cls.assertOutput(cls.ID + \"\\n\", raw_output)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @classmethod"},{"line_number":36,"context_line":"    def tearDownClass(cls):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a74a57a_516373b1","line":33,"in_reply_to":"7a77a97e_1812cc09","updated":"2016-11-23 18:04:05.000000000","message":"Done","commit_id":"752cd164087368aedd61e2638f42b4b080e5621f"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"6ccda6474efb93f135ad9947763de10f659735de","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    def tearDownClass(cls):"},{"line_number":37,"context_line":"        raw_output \u003d cls.openstack(\u0027network flavor profile delete \u0027"},{"line_number":38,"context_line":"                                   + cls.ID)"},{"line_number":39,"context_line":"        cls.openstack(\u0027network flavor profile delete \u0027 + cls.NAME)"},{"line_number":40,"context_line":"        cls.assertOutput(\u0027\u0027, raw_output)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_d82e9441","line":39,"updated":"2016-11-22 20:17:19.000000000","message":"no name, remove line","commit_id":"752cd164087368aedd61e2638f42b4b080e5621f"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"9da08e677f3e7feff1d9714a3453868ab230a1fb","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    def tearDownClass(cls):"},{"line_number":37,"context_line":"        raw_output \u003d cls.openstack(\u0027network flavor profile delete \u0027"},{"line_number":38,"context_line":"                                   + cls.ID)"},{"line_number":39,"context_line":"        cls.openstack(\u0027network flavor profile delete \u0027 + cls.NAME)"},{"line_number":40,"context_line":"        cls.assertOutput(\u0027\u0027, raw_output)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a74a57a_71586ffb","line":39,"in_reply_to":"7a77a97e_d82e9441","updated":"2016-11-23 18:04:05.000000000","message":"Done","commit_id":"752cd164087368aedd61e2638f42b4b080e5621f"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"505d8bbdeda761284ddad4ecc036309dfd534a42","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        opts \u003d cls.get_opts(cls.FIELDS)"},{"line_number":29,"context_line":"        raw_output \u003d cls.openstack(\u0027network flavor profile create \u0027"},{"line_number":30,"context_line":"                                   \u0027 --description \u0027 + str(cls.DESCRIPTION) +"},{"line_number":31,"context_line":"                                   \u0027 --metainfo \u0027 + cls.METAINFO + \u0027\u0027 +"},{"line_number":32,"context_line":"                                   opts)"},{"line_number":33,"context_line":"        cls.ID \u003d tuple(raw_output.split(\u0027\\n\u0027))"},{"line_number":34,"context_line":"        cls.assertOutput(cls.ID + \"\\n\", raw_output)"}],"source_content_type":"text/x-python","patch_set":14,"id":"ba5201f7_42d674c6","line":31,"range":{"start_line":31,"start_character":67,"end_line":31,"end_character":69},"updated":"2016-12-29 20:18:02.000000000","message":"no space before \u0027opts\u0027","commit_id":"d2f9ea10812550f211f65505d1ba328d70317156"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"b11d09b618ca143b254de3f6f3d3bee84ed4c2e3","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from openstackclient.tests.functional import base"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class NetworkFlavorProfileTests(base.TestCase):"},{"line_number":19,"context_line":"    \"\"\"Functional tests for network flavor-profile.\"\"\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":19,"id":"da36d5c6_38f21e70","line":18,"updated":"2017-02-22 16:58:09.000000000","message":"Change to json based tests. Example: [1]\n\n[1] - https://github.com/openstack/python-openstackclient/blob/master/openstackclient/tests/functional/network/v2/test_network.py#L47","commit_id":"71e7c5dca00f897658a97d108da455e262c362fc"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"83f5345b9ae3509de95eb583c96dba751d557dd4","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        self.assertEqual("},{"line_number":120,"context_line":"            \u0027Extrainfo\u0027,"},{"line_number":121,"context_line":"            json_output.get(\u0027meta_info\u0027)"},{"line_number":122,"context_line":"        )"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        # Clean up"},{"line_number":125,"context_line":"        raw_output \u003d self.openstack(\u0027network flavor profile delete \u0027 + ID)"}],"source_content_type":"text/x-python","patch_set":22,"id":"da36d5c6_8c4a5154","line":122,"updated":"2017-02-27 22:43:30.000000000","message":"nit: also do an unset command + assertions","commit_id":"e068b1826d2fbd7982a37dfeef9683736c01a8c3"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"841f55d9fae3a0e06948c210d293008f22a8640a","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        self.assertEqual("},{"line_number":120,"context_line":"            \u0027Extrainfo\u0027,"},{"line_number":121,"context_line":"            json_output.get(\u0027meta_info\u0027)"},{"line_number":122,"context_line":"        )"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        # Clean up"},{"line_number":125,"context_line":"        raw_output \u003d self.openstack(\u0027network flavor profile delete \u0027 + ID)"}],"source_content_type":"text/x-python","patch_set":22,"id":"ba2be162_479bafc9","line":122,"in_reply_to":"da36d5c6_8c4a5154","updated":"2017-03-01 16:21:13.000000000","message":"As per our discussion, leaving it unchanged.","commit_id":"e068b1826d2fbd7982a37dfeef9683736c01a8c3"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"0857cc81df23a757fae6728b6cfd9dc418f00afe","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from openstackclient.tests.functional import base"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class NetworkFlavorProfileTests(base.TestCase):"},{"line_number":19,"context_line":"    \"\"\"Functional tests for network flavor-profile.\"\"\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    DESCRIPTION \u003d \u0027fakedescription\u0027"}],"source_content_type":"text/x-python","patch_set":29,"id":"1a1ced50_c59ec355","line":18,"range":{"start_line":18,"start_character":6,"end_line":18,"end_character":31},"updated":"2017-03-18 00:41:02.000000000","message":"how about a test case to ensure driver or metainfo is provided and that it raises when neither is provided","commit_id":"740535f1aa8fea59dd1b168620db84075806cdef"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"58182fdefaf8fba601f0ed107f358a9a30c24e0e","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from openstackclient.tests.functional import base"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class NetworkFlavorProfileTests(base.TestCase):"},{"line_number":19,"context_line":"    \"\"\"Functional tests for network flavor-profile.\"\"\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    DESCRIPTION \u003d \u0027fakedescription\u0027"}],"source_content_type":"text/x-python","patch_set":29,"id":"1a1ced50_09c6099a","line":18,"range":{"start_line":18,"start_character":6,"end_line":18,"end_character":31},"in_reply_to":"1a1ced50_c59ec355","updated":"2017-03-20 16:28:33.000000000","message":"There is a unittest for the exact same scenario which assertRaises the expected exception.\nopenstackclient/tests/unit/network/v2/test_flavor_profile.py  L162-L183","commit_id":"740535f1aa8fea59dd1b168620db84075806cdef"}],"openstackclient/tests/unit/network/v2/test_flavor_profile.py":[{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"3f8b37b84c3243c6947d73e3f12c59bdafc798fe","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        # Get the command object to test"},{"line_number":69,"context_line":"        self.cmd \u003d (network_flavor_profile.CreateNetworkFlavorProfile("},{"line_number":70,"context_line":"            self.app, self.namespace))"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def test_create_all_options(self):"},{"line_number":73,"context_line":"        arglist \u003d ["},{"line_number":74,"context_line":"            \"--description\", self.new_flavor_profile.description,"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a74a57a_55b3b609","line":71,"updated":"2016-11-28 21:48:37.000000000","message":"What happened to test_create_no_options the error case?","commit_id":"c1ca820ecab66dd112b1abe6122bde2df761fca5"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"644742ed6056d6041b81506a14f79e6d4779c881","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        # Get the command object to test"},{"line_number":69,"context_line":"        self.cmd \u003d (network_flavor_profile.CreateNetworkFlavorProfile("},{"line_number":70,"context_line":"            self.app, self.namespace))"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def test_create_all_options(self):"},{"line_number":73,"context_line":"        arglist \u003d ["},{"line_number":74,"context_line":"            \"--description\", self.new_flavor_profile.description,"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a74a57a_045e4076","line":71,"in_reply_to":"5a74a57a_44c0387d","updated":"2016-11-29 17:19:19.000000000","message":"If I introduce the test, then I would have to make either metainfo or driver as \u0027required\u0027 which won\u0027t be true. Currently the \u0027if\u0027 condition is taking care of that and I have also enhanced the help msg for better understanding. I tried searching for something like add_mutually_exclusive_group for a \u0027either-or-both\u0027 condition,but couldn\u0027t find one.","commit_id":"c1ca820ecab66dd112b1abe6122bde2df761fca5"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"fe2b10e88d3b46b30675c4de429a36066a96fe7a","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        # Get the command object to test"},{"line_number":69,"context_line":"        self.cmd \u003d (network_flavor_profile.CreateNetworkFlavorProfile("},{"line_number":70,"context_line":"            self.app, self.namespace))"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def test_create_all_options(self):"},{"line_number":73,"context_line":"        arglist \u003d ["},{"line_number":74,"context_line":"            \"--description\", self.new_flavor_profile.description,"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a74a57a_a98d652c","line":71,"in_reply_to":"5a74a57a_55b3b609","updated":"2016-11-29 17:00:07.000000000","message":"Test_create_no_options is not needed here as there are no positional arguments.\nAll that test is doing is raising an exception when a required field is missing,since there is no required/positional field here,it\u0027s not needed.\nIncluding that was throwing errors.","commit_id":"c1ca820ecab66dd112b1abe6122bde2df761fca5"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"2c8287c871f2d5741622afd36b82e2cb0506aec9","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        # Get the command object to test"},{"line_number":69,"context_line":"        self.cmd \u003d (network_flavor_profile.CreateNetworkFlavorProfile("},{"line_number":70,"context_line":"            self.app, self.namespace))"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def test_create_all_options(self):"},{"line_number":73,"context_line":"        arglist \u003d ["},{"line_number":74,"context_line":"            \"--description\", self.new_flavor_profile.description,"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a74a57a_44c0387d","line":71,"in_reply_to":"5a74a57a_a98d652c","updated":"2016-11-29 17:12:50.000000000","message":"I still think there should be a test case where neither metainfo nor driver are present as args. But we will see what cores think","commit_id":"c1ca820ecab66dd112b1abe6122bde2df761fca5"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c0ee54c79fffb4f3ca1d4eefda75741e81e27235","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import mock"},{"line_number":17,"context_line":"from mock import call"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from osc_lib import exceptions"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"1a6eadb0_42a49507","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":21},"updated":"2016-12-19 10:09:55.000000000","message":"In our convention, we use only module level import. attribute level import is not usually used, so this is unnecessary.","commit_id":"326a37f67518f9bab9144c04f13d90da1cd2b10f"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"07c284423ce597b96747788f6defbd6760668f22","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import mock"},{"line_number":17,"context_line":"from mock import call"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from osc_lib import exceptions"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"1a6eadb0_d2dcdc48","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":21},"in_reply_to":"1a6eadb0_42a49507","updated":"2016-12-19 17:43:31.000000000","message":"Done","commit_id":"326a37f67518f9bab9144c04f13d90da1cd2b10f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c0ee54c79fffb4f3ca1d4eefda75741e81e27235","unresolved":false,"context_lines":[{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        calls \u003d []"},{"line_number":173,"context_line":"        for a in self._network_flavor_profiles:"},{"line_number":174,"context_line":"            calls.append(call(a))"},{"line_number":175,"context_line":"        self.network.delete_service_profile.assert_has_calls(calls)"},{"line_number":176,"context_line":"        self.assertIsNone(result)"},{"line_number":177,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"1a6eadb0_0281bd4d","line":174,"range":{"start_line":174,"start_character":25,"end_line":174,"end_character":29},"updated":"2016-12-19 10:09:55.000000000","message":"This is the only usage of \"call\".\n\n mock.call(a)","commit_id":"326a37f67518f9bab9144c04f13d90da1cd2b10f"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"07c284423ce597b96747788f6defbd6760668f22","unresolved":false,"context_lines":[{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        calls \u003d []"},{"line_number":173,"context_line":"        for a in self._network_flavor_profiles:"},{"line_number":174,"context_line":"            calls.append(call(a))"},{"line_number":175,"context_line":"        self.network.delete_service_profile.assert_has_calls(calls)"},{"line_number":176,"context_line":"        self.assertIsNone(result)"},{"line_number":177,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"1a6eadb0_f2e1d8ff","line":174,"range":{"start_line":174,"start_character":25,"end_line":174,"end_character":29},"in_reply_to":"1a6eadb0_0281bd4d","updated":"2016-12-19 17:43:31.000000000","message":"Done","commit_id":"326a37f67518f9bab9144c04f13d90da1cd2b10f"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"576e488bc08e4f8ca07c72c1f3136351aa14f5a3","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            (\u0027enable\u0027, True),"},{"line_number":86,"context_line":"            (\u0027driver\u0027, self.new_flavor_profile.driver),"},{"line_number":87,"context_line":"            (\u0027metainfo\u0027, self.new_flavor_profile.metainfo)"},{"line_number":88,"context_line":"        ]"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":91,"context_line":"        columns, data \u003d (self.cmd.take_action(parsed_args))"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba2be162_013e878b","line":88,"updated":"2017-03-03 17:56:00.000000000","message":"request for 2 more tests.\n\nOne with a driver and no metainfo.\nOne with metainfo and no driver\n\nThey should both throw an exception","commit_id":"b645215953ae036bda43964cce6695a46da4a389"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"807368652dff7190a4094a7860f5df47badcf734","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            (\u0027enable\u0027, True),"},{"line_number":86,"context_line":"            (\u0027driver\u0027, self.new_flavor_profile.driver),"},{"line_number":87,"context_line":"            (\u0027metainfo\u0027, self.new_flavor_profile.metainfo)"},{"line_number":88,"context_line":"        ]"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":91,"context_line":"        columns, data \u003d (self.cmd.take_action(parsed_args))"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba2be162_bc7cb9ec","line":88,"in_reply_to":"ba2be162_013e878b","updated":"2017-03-06 17:21:25.000000000","message":"Done","commit_id":"b645215953ae036bda43964cce6695a46da4a389"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"e51f4837297fbc78313bb15c44cd15e618d6b0eb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016, Intel Corporation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":29,"id":"1a1ced50_cf3f99d4","line":1,"updated":"2017-03-20 14:43:51.000000000","message":"If respun: rename file to test_network_flavor_profile","commit_id":"740535f1aa8fea59dd1b168620db84075806cdef"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"58182fdefaf8fba601f0ed107f358a9a30c24e0e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016, Intel Corporation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":29,"id":"1a1ced50_09b1a947","line":1,"in_reply_to":"1a1ced50_8332da0e","updated":"2017-03-20 16:28:33.000000000","message":"Done","commit_id":"740535f1aa8fea59dd1b168620db84075806cdef"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"f00914f09833610711d2abd6f6753e8b0e2673e1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016, Intel Corporation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":29,"id":"1a1ced50_8332da0e","line":1,"in_reply_to":"1a1ced50_cf3f99d4","updated":"2017-03-20 16:05:12.000000000","message":"Be consistent with the copyright lines, the other two new files do not have one.\n\nIntel does not require that we add this, I have been leaving them out for quite some time now as they really do not have any value legally.","commit_id":"740535f1aa8fea59dd1b168620db84075806cdef"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"58182fdefaf8fba601f0ed107f358a9a30c24e0e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016, Intel Corporation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":29,"id":"1a1ced50_e9a9ade0","line":1,"in_reply_to":"1a1ced50_cf3f99d4","updated":"2017-03-20 16:28:33.000000000","message":"Done","commit_id":"740535f1aa8fea59dd1b168620db84075806cdef"}],"setup.cfg":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a7bdf8f0d88a95a99035a50f8f7e9d3f353e1e3b","unresolved":false,"context_lines":[{"line_number":376,"context_line":"    network_flavor_profile_delete \u003d openstackclient.network.v2.network_flavor_profile:DeleteNetworkFlavorProfile"},{"line_number":377,"context_line":"    network_flavor_profile_list \u003d openstackclient.network.v2.network_flavor_profile:ListNetworkFlavorProfile"},{"line_number":378,"context_line":"    network_flavor_profile_set \u003d openstackclient.network.v2.network_flavor_profile:SetNetworkFlavorProfile"},{"line_number":379,"context_line":"    network_flavor_profile_show \u003d openstackclient.network.v2.network_flavor_profile:ShowNetworkFlavorProfile"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"    network_meter_create \u003d openstackclient.network.v2.meter:CreateMeter"},{"line_number":382,"context_line":"    network_meter_delete \u003d openstackclient.network.v2.meter:DeleteMeter"}],"source_content_type":"text/x-ttcn-cfg","patch_set":22,"id":"ba2be162_3ce6dbb4","line":379,"updated":"2017-03-01 13:00:44.000000000","message":"It is better to move these 5 lines just after \u0027network flavor\u0027 commands.","commit_id":"e068b1826d2fbd7982a37dfeef9683736c01a8c3"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"841f55d9fae3a0e06948c210d293008f22a8640a","unresolved":false,"context_lines":[{"line_number":376,"context_line":"    network_flavor_profile_delete \u003d openstackclient.network.v2.network_flavor_profile:DeleteNetworkFlavorProfile"},{"line_number":377,"context_line":"    network_flavor_profile_list \u003d openstackclient.network.v2.network_flavor_profile:ListNetworkFlavorProfile"},{"line_number":378,"context_line":"    network_flavor_profile_set \u003d openstackclient.network.v2.network_flavor_profile:SetNetworkFlavorProfile"},{"line_number":379,"context_line":"    network_flavor_profile_show \u003d openstackclient.network.v2.network_flavor_profile:ShowNetworkFlavorProfile"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"    network_meter_create \u003d openstackclient.network.v2.meter:CreateMeter"},{"line_number":382,"context_line":"    network_meter_delete \u003d openstackclient.network.v2.meter:DeleteMeter"}],"source_content_type":"text/x-ttcn-cfg","patch_set":22,"id":"ba2be162_074c576f","line":379,"in_reply_to":"ba2be162_3ce6dbb4","updated":"2017-03-01 16:21:13.000000000","message":"Done","commit_id":"e068b1826d2fbd7982a37dfeef9683736c01a8c3"}]}