)]}'
{"doc/source/command-objects/network-agent.rst":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"667d9ff4502a666739c6cda51e24df458a285baf","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        [--agent-type \u003cagent-type\u003e]"},{"line_number":39,"context_line":"        [--host \u003chost\u003e]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":".. option:: --agent-type \u003cagent-type\u003e"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    List only agents with the specified agent type"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a77a97e_b8ac6aa1","line":41,"range":{"start_line":41,"start_character":14,"end_line":41,"end_character":24},"updated":"2016-11-16 16:55:39.000000000","message":"i think we can call this just --type since it\u0027s already an agent list, but i\u0027ll leave that to you to determine","commit_id":"f8de15ed960357eeac8448f8832cb765df142fd7"},{"author":{"_account_id":18595,"name":"Zhou Zhihong","email":"zhouzhihong@cmss.chinamobile.com","username":"shuihushen"},"change_message_id":"0284b0822581bbb8c4c3ba17933a6bdd915f218d","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        [--agent-type \u003cagent-type\u003e]"},{"line_number":39,"context_line":"        [--host \u003chost\u003e]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":".. option:: --agent-type \u003cagent-type\u003e"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    List only agents with the specified agent type"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a77a97e_7edb1a7c","line":41,"range":{"start_line":41,"start_character":14,"end_line":41,"end_character":24},"in_reply_to":"7a77a97e_b8ac6aa1","updated":"2016-11-20 00:40:32.000000000","message":"Thanks. I think --agent-type is more clear.","commit_id":"f8de15ed960357eeac8448f8832cb765df142fd7"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"44d370bf61615e16b0cc2dd9aaa1dffdc3371ab8","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":".. option:: --agent-type \u003cagent-type\u003e"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    List only agents with the specified agent type."},{"line_number":44,"context_line":"    Can use the key value of the agent type."},{"line_number":45,"context_line":"    Such as use dhcp instead of \u0027DHCP agent\u0027,"},{"line_number":46,"context_line":"    use open-vswitch instead of \u0027Open vSwitch agent\u0027,"},{"line_number":47,"context_line":"    and so on."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":".. option:: --host \u003chost\u003e"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a77a97e_5d549ac8","line":47,"range":{"start_line":43,"start_character":4,"end_line":47,"end_character":14},"updated":"2016-11-20 16:45:28.000000000","message":"the keys can still be listed here","commit_id":"292f466b23cfe09edbde89ca3bc5e249dca16301"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"c0914ef9a1780b4c48844ae819dcb62730cfadb3","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":".. option:: --host \u003chost\u003e"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    List only agents with the specified host"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"network agent set"},{"line_number":53,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba5201f7_bc7a4a86","line":50,"updated":"2017-01-05 16:41:07.000000000","message":"What about \"List only agents running on the specified host\" ? I don\"t really that the \u0027with\u0027 here, it\u0027s not very clear.","commit_id":"cc4bc7a2b0a5bde59f1a86f9b97e95dc6ea9403c"},{"author":{"_account_id":18595,"name":"Zhou Zhihong","email":"zhouzhihong@cmss.chinamobile.com","username":"shuihushen"},"change_message_id":"3532bbbbca8dc85f6d16bfea4a83c573b26a3a4d","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":".. option:: --host \u003chost\u003e"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    List only agents with the specified host"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"network agent set"},{"line_number":53,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba5201f7_e157b455","line":50,"in_reply_to":"ba5201f7_bc7a4a86","updated":"2017-01-06 07:50:55.000000000","message":"Done","commit_id":"cc4bc7a2b0a5bde59f1a86f9b97e95dc6ea9403c"}],"openstackclient/network/v2/network_agent.py":[{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"0453d85402e464271ea675604691a62ac3c60d10","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    def get_parser(self, prog_name):"},{"line_number":76,"context_line":"        parser \u003d super(ListNetworkAgent, self).get_parser(prog_name)"},{"line_number":77,"context_line":"        parser.add_argument("},{"line_number":78,"context_line":"            \u0027--agent-type\u0027,"},{"line_number":79,"context_line":"            metavar\u003d\u0027\u003cagent-type\u003e\u0027,"},{"line_number":80,"context_line":"            help\u003d_(\"List only agents with the specified agent type\")"},{"line_number":81,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_e92e28f9","line":78,"updated":"2016-11-16 12:02:05.000000000","message":"Leave a question, do we have a list of choices of agent type? If have, this should be a option with choices:\nhttp://docs.openstack.org/developer/python-openstackclient/command-options.html#options-with-choices","commit_id":"f8de15ed960357eeac8448f8832cb765df142fd7"},{"author":{"_account_id":18595,"name":"Zhou Zhihong","email":"zhouzhihong@cmss.chinamobile.com","username":"shuihushen"},"change_message_id":"0284b0822581bbb8c4c3ba17933a6bdd915f218d","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    def get_parser(self, prog_name):"},{"line_number":76,"context_line":"        parser \u003d super(ListNetworkAgent, self).get_parser(prog_name)"},{"line_number":77,"context_line":"        parser.add_argument("},{"line_number":78,"context_line":"            \u0027--agent-type\u0027,"},{"line_number":79,"context_line":"            metavar\u003d\u0027\u003cagent-type\u003e\u0027,"},{"line_number":80,"context_line":"            help\u003d_(\"List only agents with the specified agent type\")"},{"line_number":81,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_e3bb0ec2","line":78,"in_reply_to":"7a77a97e_e92e28f9","updated":"2016-11-20 00:40:32.000000000","message":"Thanks. I\u0027ve added the choices. Please review again.","commit_id":"f8de15ed960357eeac8448f8832cb765df142fd7"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"667d9ff4502a666739c6cda51e24df458a285baf","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    def get_parser(self, prog_name):"},{"line_number":76,"context_line":"        parser \u003d super(ListNetworkAgent, self).get_parser(prog_name)"},{"line_number":77,"context_line":"        parser.add_argument("},{"line_number":78,"context_line":"            \u0027--agent-type\u0027,"},{"line_number":79,"context_line":"            metavar\u003d\u0027\u003cagent-type\u003e\u0027,"},{"line_number":80,"context_line":"            help\u003d_(\"List only agents with the specified agent type\")"},{"line_number":81,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_988c0e37","line":78,"in_reply_to":"7a77a97e_e92e28f9","updated":"2016-11-16 16:55:39.000000000","message":"good question","commit_id":"f8de15ed960357eeac8448f8832cb765df142fd7"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"f2a0b865d476f4cf7a2b648058b1054e71ca068e","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        parser.add_argument("},{"line_number":78,"context_line":"            \u0027--agent-type\u0027,"},{"line_number":79,"context_line":"            metavar\u003d\u0027\u003cagent-type\u003e\u0027,"},{"line_number":80,"context_line":"            choices\u003d[\u0027DHCP agent\u0027, \u0027Open vSwitch agent\u0027,"},{"line_number":81,"context_line":"                     \u0027Linux bridge agent\u0027, \u0027OFA driver agent\u0027,"},{"line_number":82,"context_line":"                     \u0027L3 agent\u0027, \u0027Loadbalancer agent\u0027,"},{"line_number":83,"context_line":"                     \u0027Metering agent\u0027, \u0027Metadata agent\u0027,"},{"line_number":84,"context_line":"                     \u0027Macvtap agent\u0027],"},{"line_number":85,"context_line":"            help\u003d_(\"List only agents with the specified agent type. \""},{"line_number":86,"context_line":"                   \"The supported options are: DHCP agent, \""},{"line_number":87,"context_line":"                   \"Open vSwitch agent, Linux bridge agent, \""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_c3061285","line":84,"range":{"start_line":80,"start_character":21,"end_line":84,"end_character":38},"updated":"2016-11-20 01:02:32.000000000","message":"do we need to print agent for all of these? i\u0027m not sure how well the option works with spaces and mixed capitals either...\n\nfrom a user point of view, i think:\n\n  --agent-type dhcp\n\nis easier than\n\n  --agent-type \"DHCP agent\"\n\nMost of these can be simplified:\n\n  [dhcp, open-vswitch, linux-bridge, ofa, l3, loadbalancer, metering, metadata, macvtap]","commit_id":"32c8ceab4549806756662e4e331a49083c673518"},{"author":{"_account_id":18595,"name":"Zhou Zhihong","email":"zhouzhihong@cmss.chinamobile.com","username":"shuihushen"},"change_message_id":"0843ebb9b90188157e9083e73a7a91b375c28af7","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        parser.add_argument("},{"line_number":78,"context_line":"            \u0027--agent-type\u0027,"},{"line_number":79,"context_line":"            metavar\u003d\u0027\u003cagent-type\u003e\u0027,"},{"line_number":80,"context_line":"            choices\u003d[\u0027DHCP agent\u0027, \u0027Open vSwitch agent\u0027,"},{"line_number":81,"context_line":"                     \u0027Linux bridge agent\u0027, \u0027OFA driver agent\u0027,"},{"line_number":82,"context_line":"                     \u0027L3 agent\u0027, \u0027Loadbalancer agent\u0027,"},{"line_number":83,"context_line":"                     \u0027Metering agent\u0027, \u0027Metadata agent\u0027,"},{"line_number":84,"context_line":"                     \u0027Macvtap agent\u0027],"},{"line_number":85,"context_line":"            help\u003d_(\"List only agents with the specified agent type. \""},{"line_number":86,"context_line":"                   \"The supported options are: DHCP agent, \""},{"line_number":87,"context_line":"                   \"Open vSwitch agent, Linux bridge agent, \""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_f5e660ae","line":84,"range":{"start_line":80,"start_character":21,"end_line":84,"end_character":38},"in_reply_to":"7a77a97e_54947a89","updated":"2016-11-20 13:17:33.000000000","message":"Thanks. I will add the key-value pair info to help section.","commit_id":"32c8ceab4549806756662e4e331a49083c673518"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"7c91347759ebaa08c55f024d9c337738c2774b5d","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        parser.add_argument("},{"line_number":78,"context_line":"            \u0027--agent-type\u0027,"},{"line_number":79,"context_line":"            metavar\u003d\u0027\u003cagent-type\u003e\u0027,"},{"line_number":80,"context_line":"            choices\u003d[\u0027DHCP agent\u0027, \u0027Open vSwitch agent\u0027,"},{"line_number":81,"context_line":"                     \u0027Linux bridge agent\u0027, \u0027OFA driver agent\u0027,"},{"line_number":82,"context_line":"                     \u0027L3 agent\u0027, \u0027Loadbalancer agent\u0027,"},{"line_number":83,"context_line":"                     \u0027Metering agent\u0027, \u0027Metadata agent\u0027,"},{"line_number":84,"context_line":"                     \u0027Macvtap agent\u0027],"},{"line_number":85,"context_line":"            help\u003d_(\"List only agents with the specified agent type. \""},{"line_number":86,"context_line":"                   \"The supported options are: DHCP agent, \""},{"line_number":87,"context_line":"                   \"Open vSwitch agent, Linux bridge agent, \""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_54947a89","line":84,"range":{"start_line":80,"start_character":21,"end_line":84,"end_character":38},"in_reply_to":"7a77a97e_c3061285","updated":"2016-11-20 07:23:27.000000000","message":"Agreed.\nBut we need the help section to be updated with a key-value pair, so that user knows whats the short form for each agent","commit_id":"32c8ceab4549806756662e4e331a49083c673518"},{"author":{"_account_id":18595,"name":"Zhou Zhihong","email":"zhouzhihong@cmss.chinamobile.com","username":"shuihushen"},"change_message_id":"0843ebb9b90188157e9083e73a7a91b375c28af7","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        parser.add_argument("},{"line_number":78,"context_line":"            \u0027--agent-type\u0027,"},{"line_number":79,"context_line":"            metavar\u003d\u0027\u003cagent-type\u003e\u0027,"},{"line_number":80,"context_line":"            choices\u003d[\u0027DHCP agent\u0027, \u0027Open vSwitch agent\u0027,"},{"line_number":81,"context_line":"                     \u0027Linux bridge agent\u0027, \u0027OFA driver agent\u0027,"},{"line_number":82,"context_line":"                     \u0027L3 agent\u0027, \u0027Loadbalancer agent\u0027,"},{"line_number":83,"context_line":"                     \u0027Metering agent\u0027, \u0027Metadata agent\u0027,"},{"line_number":84,"context_line":"                     \u0027Macvtap agent\u0027],"},{"line_number":85,"context_line":"            help\u003d_(\"List only agents with the specified agent type. \""},{"line_number":86,"context_line":"                   \"The supported options are: DHCP agent, \""},{"line_number":87,"context_line":"                   \"Open vSwitch agent, Linux bridge agent, \""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_f5cf4026","line":84,"range":{"start_line":80,"start_character":21,"end_line":84,"end_character":38},"in_reply_to":"7a77a97e_c3061285","updated":"2016-11-20 13:17:33.000000000","message":"If use choices, it must print all of these agents and it is not sensible for there are so many agents. I will use dhcp instead of \"DHCP agent\", and add these info to help section.","commit_id":"32c8ceab4549806756662e4e331a49083c673518"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"44d370bf61615e16b0cc2dd9aaa1dffdc3371ab8","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        parser.add_argument("},{"line_number":78,"context_line":"            \u0027--agent-type\u0027,"},{"line_number":79,"context_line":"            metavar\u003d\u0027\u003cagent-type\u003e\u0027,"},{"line_number":80,"context_line":"            help\u003d_(\"List only agents with the specified agent type. \""},{"line_number":81,"context_line":"                   \"Can use the key value of the agent type. \""},{"line_number":82,"context_line":"                   \"Such as use dhcp instead of \u0027DHCP agent\u0027, \""},{"line_number":83,"context_line":"                   \"use open-vswitch instead of \u0027Open vSwitch agent\u0027, \""},{"line_number":84,"context_line":"                   \"and so on.\")"},{"line_number":85,"context_line":"        )"},{"line_number":86,"context_line":"        parser.add_argument("},{"line_number":87,"context_line":"            \u0027--host\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_3d499e31","line":84,"range":{"start_line":80,"start_character":0,"end_line":84,"end_character":32},"updated":"2016-11-20 16:45:28.000000000","message":"the help should still indicate the available keys to use, see https://review.openstack.org/#/c/395796/3/openstackclient/image/v1/image.py for a possible approach","commit_id":"292f466b23cfe09edbde89ca3bc5e249dca16301"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"0e499e821c6858d9ffb9c8e67ea599ccaa065f9e","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    \u0027configurations\u0027: utils.format_dict,"},{"line_number":35,"context_line":"}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"KEY_CHOICES \u003d [\"dhcp\", \"open-vswitch\", \"linux-bridge\", \"ofa\", \"l3\","},{"line_number":38,"context_line":"               \"loadbalancer\", \"metering\", \"metadata\", \"macvtap\", \"nic\"]"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3a71b18c_2e8f7424","line":37,"updated":"2016-12-01 21:24:03.000000000","message":"How often could these choices change?  I wonder if we only document them and not enforce them in the CLI.  Please consider the trade-off.","commit_id":"854971b442d28dddf6896079be97fb2152c552f0"},{"author":{"_account_id":18595,"name":"Zhou Zhihong","email":"zhouzhihong@cmss.chinamobile.com","username":"shuihushen"},"change_message_id":"e38b53e303aa9dcd77e29ede48bfcfc072ccd800","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    \u0027configurations\u0027: utils.format_dict,"},{"line_number":35,"context_line":"}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"KEY_CHOICES \u003d [\"dhcp\", \"open-vswitch\", \"linux-bridge\", \"ofa\", \"l3\","},{"line_number":38,"context_line":"               \"loadbalancer\", \"metering\", \"metadata\", \"macvtap\", \"nic\"]"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3a71b18c_ff951d40","line":37,"in_reply_to":"3a71b18c_2e8f7424","updated":"2016-12-02 03:03:32.000000000","message":"Yes, I\u0027ve considered this situation.And for the others suggestion, use choices is more proper for the end users. If there are new choices exist, the end user can still use grep.","commit_id":"854971b442d28dddf6896079be97fb2152c552f0"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"0e499e821c6858d9ffb9c8e67ea599ccaa065f9e","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        if parsed_args.agent_type is not None:"},{"line_number":132,"context_line":"            try:"},{"line_number":133,"context_line":"                filters[\u0027agent_type\u0027] \u003d key_value[parsed_args.agent_type]"},{"line_number":134,"context_line":"            except Exception:"},{"line_number":135,"context_line":"                filters[\u0027agent_type\u0027] \u003d parsed_args.agent_type"},{"line_number":136,"context_line":"        if parsed_args.host is not None:"},{"line_number":137,"context_line":"            filters[\u0027host\u0027] \u003d parsed_args.host"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a71b18c_8eb5e8ce","line":134,"updated":"2016-12-01 21:24:03.000000000","message":"What is the purpose of this?  Aren\u0027t all of the choices in the dict?","commit_id":"854971b442d28dddf6896079be97fb2152c552f0"},{"author":{"_account_id":18595,"name":"Zhou Zhihong","email":"zhouzhihong@cmss.chinamobile.com","username":"shuihushen"},"change_message_id":"ad3ffabb1815cc5c62aa22741c0bdbc0cb3dfdae","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        if parsed_args.agent_type is not None:"},{"line_number":132,"context_line":"            try:"},{"line_number":133,"context_line":"                filters[\u0027agent_type\u0027] \u003d key_value[parsed_args.agent_type]"},{"line_number":134,"context_line":"            except Exception:"},{"line_number":135,"context_line":"                filters[\u0027agent_type\u0027] \u003d parsed_args.agent_type"},{"line_number":136,"context_line":"        if parsed_args.host is not None:"},{"line_number":137,"context_line":"            filters[\u0027host\u0027] \u003d parsed_args.host"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba5201f7_8afe8669","line":134,"in_reply_to":"3a71b18c_8eb5e8ce","updated":"2017-01-05 01:45:02.000000000","message":"Done","commit_id":"854971b442d28dddf6896079be97fb2152c552f0"},{"author":{"_account_id":18595,"name":"Zhou Zhihong","email":"zhouzhihong@cmss.chinamobile.com","username":"shuihushen"},"change_message_id":"e38b53e303aa9dcd77e29ede48bfcfc072ccd800","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        if parsed_args.agent_type is not None:"},{"line_number":132,"context_line":"            try:"},{"line_number":133,"context_line":"                filters[\u0027agent_type\u0027] \u003d key_value[parsed_args.agent_type]"},{"line_number":134,"context_line":"            except Exception:"},{"line_number":135,"context_line":"                filters[\u0027agent_type\u0027] \u003d parsed_args.agent_type"},{"line_number":136,"context_line":"        if parsed_args.host is not None:"},{"line_number":137,"context_line":"            filters[\u0027host\u0027] \u003d parsed_args.host"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a71b18c_bfe8057e","line":134,"in_reply_to":"3a71b18c_8eb5e8ce","updated":"2016-12-02 03:03:32.000000000","message":"The all choices are in the dict. Add the exception is for the wrong input which is not in the dict. I think hold these code is more benefit.","commit_id":"854971b442d28dddf6896079be97fb2152c552f0"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"0e499e821c6858d9ffb9c8e67ea599ccaa065f9e","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        }"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        filters \u003d {}"},{"line_number":131,"context_line":"        if parsed_args.agent_type is not None:"},{"line_number":132,"context_line":"            try:"},{"line_number":133,"context_line":"                filters[\u0027agent_type\u0027] \u003d key_value[parsed_args.agent_type]"},{"line_number":134,"context_line":"            except Exception:"},{"line_number":135,"context_line":"                filters[\u0027agent_type\u0027] \u003d parsed_args.agent_type"},{"line_number":136,"context_line":"        if parsed_args.host is not None:"},{"line_number":137,"context_line":"            filters[\u0027host\u0027] \u003d parsed_args.host"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        data \u003d client.agents(**filters)"},{"line_number":140,"context_line":"        return (column_headers,"},{"line_number":141,"context_line":"                (utils.get_item_properties("},{"line_number":142,"context_line":"                    s, columns, formatters\u003d_formatters,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a71b18c_aea3849d","line":139,"range":{"start_line":131,"start_character":0,"end_line":139,"end_character":39},"updated":"2016-12-01 21:24:03.000000000","message":"Please add these filters to the SDK documentation for the agents() proxy method.","commit_id":"854971b442d28dddf6896079be97fb2152c552f0"},{"author":{"_account_id":18595,"name":"Zhou Zhihong","email":"zhouzhihong@cmss.chinamobile.com","username":"shuihushen"},"change_message_id":"d08bc1c13c7eb3eefe51ffb157bc8ce6202c86ba","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        }"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        filters \u003d {}"},{"line_number":131,"context_line":"        if parsed_args.agent_type is not None:"},{"line_number":132,"context_line":"            try:"},{"line_number":133,"context_line":"                filters[\u0027agent_type\u0027] \u003d key_value[parsed_args.agent_type]"},{"line_number":134,"context_line":"            except Exception:"},{"line_number":135,"context_line":"                filters[\u0027agent_type\u0027] \u003d parsed_args.agent_type"},{"line_number":136,"context_line":"        if parsed_args.host is not None:"},{"line_number":137,"context_line":"            filters[\u0027host\u0027] \u003d parsed_args.host"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        data \u003d client.agents(**filters)"},{"line_number":140,"context_line":"        return (column_headers,"},{"line_number":141,"context_line":"                (utils.get_item_properties("},{"line_number":142,"context_line":"                    s, columns, formatters\u003d_formatters,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a71b18c_95b753f4","line":139,"range":{"start_line":131,"start_character":0,"end_line":139,"end_character":39},"in_reply_to":"3a71b18c_aea3849d","updated":"2016-12-05 09:42:11.000000000","message":"Done","commit_id":"854971b442d28dddf6896079be97fb2152c552f0"},{"author":{"_account_id":18595,"name":"Zhou Zhihong","email":"zhouzhihong@cmss.chinamobile.com","username":"shuihushen"},"change_message_id":"e38b53e303aa9dcd77e29ede48bfcfc072ccd800","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        }"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        filters \u003d {}"},{"line_number":131,"context_line":"        if parsed_args.agent_type is not None:"},{"line_number":132,"context_line":"            try:"},{"line_number":133,"context_line":"                filters[\u0027agent_type\u0027] \u003d key_value[parsed_args.agent_type]"},{"line_number":134,"context_line":"            except Exception:"},{"line_number":135,"context_line":"                filters[\u0027agent_type\u0027] \u003d parsed_args.agent_type"},{"line_number":136,"context_line":"        if parsed_args.host is not None:"},{"line_number":137,"context_line":"            filters[\u0027host\u0027] \u003d parsed_args.host"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        data \u003d client.agents(**filters)"},{"line_number":140,"context_line":"        return (column_headers,"},{"line_number":141,"context_line":"                (utils.get_item_properties("},{"line_number":142,"context_line":"                    s, columns, formatters\u003d_formatters,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a71b18c_9f9a6913","line":139,"range":{"start_line":131,"start_character":0,"end_line":139,"end_character":39},"in_reply_to":"3a71b18c_aea3849d","updated":"2016-12-02 03:03:32.000000000","message":"OK, I\u0027ll add it later.","commit_id":"854971b442d28dddf6896079be97fb2152c552f0"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"c0914ef9a1780b4c48844ae819dcb62730cfadb3","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    \u0027configurations\u0027: utils.format_dict,"},{"line_number":35,"context_line":"}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"KEY_CHOICES \u003d [\"dhcp\", \"open-vswitch\", \"linux-bridge\", \"ofa\", \"l3\","},{"line_number":38,"context_line":"               \"loadbalancer\", \"metering\", \"metadata\", \"macvtap\", \"nic\"]"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"ba5201f7_bc532a16","line":37,"updated":"2017-01-05 16:41:07.000000000","message":"Given that it seems you are not reusing this list, I would inline it L83. Or at least rename it, because here a variable named \"key_choices\" is too vague, we don\"t have enough context.","commit_id":"cc4bc7a2b0a5bde59f1a86f9b97e95dc6ea9403c"},{"author":{"_account_id":18595,"name":"Zhou Zhihong","email":"zhouzhihong@cmss.chinamobile.com","username":"shuihushen"},"change_message_id":"3532bbbbca8dc85f6d16bfea4a83c573b26a3a4d","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    \u0027configurations\u0027: utils.format_dict,"},{"line_number":35,"context_line":"}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"KEY_CHOICES \u003d [\"dhcp\", \"open-vswitch\", \"linux-bridge\", \"ofa\", \"l3\","},{"line_number":38,"context_line":"               \"loadbalancer\", \"metering\", \"metadata\", \"macvtap\", \"nic\"]"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"ba5201f7_214e1cc1","line":37,"in_reply_to":"ba5201f7_bc532a16","updated":"2017-01-06 07:50:55.000000000","message":"Done","commit_id":"cc4bc7a2b0a5bde59f1a86f9b97e95dc6ea9403c"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"c0914ef9a1780b4c48844ae819dcb62730cfadb3","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        parser.add_argument("},{"line_number":90,"context_line":"            \u0027--host\u0027,"},{"line_number":91,"context_line":"            metavar\u003d\u0027\u003chost\u003e\u0027,"},{"line_number":92,"context_line":"            help\u003d_(\"List only agents with the specified host\")"},{"line_number":93,"context_line":"        )"},{"line_number":94,"context_line":"        return parser"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"ba5201f7_f914e44d","line":92,"updated":"2017-01-05 16:41:07.000000000","message":"What about \"List only agents running on the specified host\" ? I don\"t really that the \u0027with\u0027 here, it\u0027s not very clear.","commit_id":"cc4bc7a2b0a5bde59f1a86f9b97e95dc6ea9403c"},{"author":{"_account_id":18595,"name":"Zhou Zhihong","email":"zhouzhihong@cmss.chinamobile.com","username":"shuihushen"},"change_message_id":"3532bbbbca8dc85f6d16bfea4a83c573b26a3a4d","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        parser.add_argument("},{"line_number":90,"context_line":"            \u0027--host\u0027,"},{"line_number":91,"context_line":"            metavar\u003d\u0027\u003chost\u003e\u0027,"},{"line_number":92,"context_line":"            help\u003d_(\"List only agents with the specified host\")"},{"line_number":93,"context_line":"        )"},{"line_number":94,"context_line":"        return parser"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"ba5201f7_a1d04cca","line":92,"in_reply_to":"ba5201f7_f914e44d","updated":"2017-01-06 07:50:55.000000000","message":"Done","commit_id":"cc4bc7a2b0a5bde59f1a86f9b97e95dc6ea9403c"}],"openstackclient/tests/unit/network/v2/test_network_agent.py":[{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"0453d85402e464271ea675604691a62ac3c60d10","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        self.assertEqual(self.columns, columns)"},{"line_number":160,"context_line":"        self.assertEqual(self.data, list(data))"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def test_network_agents_list_agent_type(self):"},{"line_number":163,"context_line":"        arglist \u003d ["},{"line_number":164,"context_line":"            \u0027--agent-type\u0027, self.network_agents[0].agent_type,"},{"line_number":165,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_891bf41a","line":162,"updated":"2016-11-16 12:02:05.000000000","message":"It is also OK if you combine these two tests into one","commit_id":"f8de15ed960357eeac8448f8832cb765df142fd7"}],"releasenotes/notes/bug-1641868-97c284e33f944c2d.yaml":[{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"0453d85402e464271ea675604691a62ac3c60d10","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add ``--agent-type``, ``--host``,"},{"line_number":5,"context_line":"    options to ``network agent list`` command"},{"line_number":6,"context_line":"    [Bug `1641868 \u003chttps://bugs.launchpad.net/bugs/1641868\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7a77a97e_c9124cb4","line":4,"range":{"start_line":4,"start_character":36,"end_line":4,"end_character":37},"updated":"2016-11-16 12:02:05.000000000","message":"Maybe you can remove this comma","commit_id":"f8de15ed960357eeac8448f8832cb765df142fd7"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"667d9ff4502a666739c6cda51e24df458a285baf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add ``--agent-type``, ``--host``,"},{"line_number":5,"context_line":"    options to ``network agent list`` command"},{"line_number":6,"context_line":"    [Bug `1641868 \u003chttps://bugs.launchpad.net/bugs/1641868\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7a77a97e_d89da65a","line":4,"range":{"start_line":4,"start_character":24,"end_line":4,"end_character":25},"updated":"2016-11-16 16:55:39.000000000","message":"replace comma with \"and\"","commit_id":"f8de15ed960357eeac8448f8832cb765df142fd7"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"667d9ff4502a666739c6cda51e24df458a285baf","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add ``--agent-type``, ``--host``,"},{"line_number":5,"context_line":"    options to ``network agent list`` command"},{"line_number":6,"context_line":"    [Bug `1641868 \u003chttps://bugs.launchpad.net/bugs/1641868\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7a77a97e_58aa7671","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":11},"updated":"2016-11-16 16:55:39.000000000","message":"call it a filter","commit_id":"f8de15ed960357eeac8448f8832cb765df142fd7"}]}