)]}'
{"openstackclient/network/v2/router.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"6a03d087cdb4f2125ce85798682a4c7bcb0c387d","unresolved":false,"context_lines":[{"line_number":451,"context_line":"                   \"gateway: nexthop IP address \""},{"line_number":452,"context_line":"                   \"(repeat option to set multiple routes)\")"},{"line_number":453,"context_line":"        )"},{"line_number":454,"context_line":"        parser.add_argument("},{"line_number":455,"context_line":"            \u0027--no-route\u0027,"},{"line_number":456,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":457,"context_line":"            help\u003d_(\"Clear routes associated with the router.\""},{"line_number":458,"context_line":"                   \"Specify both --route and --no-route to overwrite \""},{"line_number":459,"context_line":"                   \"current value of route.\")"},{"line_number":460,"context_line":"        )"},{"line_number":461,"context_line":"        routes_group.add_argument("},{"line_number":462,"context_line":"            \u0027--clear-routes\u0027,"},{"line_number":463,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":464,"context_line":"            help\u003dargparse.SUPPRESS,"},{"line_number":465,"context_line":"        )"},{"line_number":466,"context_line":"        routes_ha \u003d parser.add_mutually_exclusive_group()"},{"line_number":467,"context_line":"        routes_ha.add_argument("},{"line_number":468,"context_line":"            \u0027--ha\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_43592534","line":465,"range":{"start_line":454,"start_character":0,"end_line":465,"end_character":9},"updated":"2016-11-19 12:37:50.000000000","message":"These should be mutually exclusive.","commit_id":"95f53f9e13ef22f93d2c42764de591e43af1252d"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"176382ec9839253a8ffea1c99a23122fc5a6f6c6","unresolved":false,"context_lines":[{"line_number":451,"context_line":"                   \"gateway: nexthop IP address \""},{"line_number":452,"context_line":"                   \"(repeat option to set multiple routes)\")"},{"line_number":453,"context_line":"        )"},{"line_number":454,"context_line":"        parser.add_argument("},{"line_number":455,"context_line":"            \u0027--no-route\u0027,"},{"line_number":456,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":457,"context_line":"            help\u003d_(\"Clear routes associated with the router.\""},{"line_number":458,"context_line":"                   \"Specify both --route and --no-route to overwrite \""},{"line_number":459,"context_line":"                   \"current value of route.\")"},{"line_number":460,"context_line":"        )"},{"line_number":461,"context_line":"        routes_group.add_argument("},{"line_number":462,"context_line":"            \u0027--clear-routes\u0027,"},{"line_number":463,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":464,"context_line":"            help\u003dargparse.SUPPRESS,"},{"line_number":465,"context_line":"        )"},{"line_number":466,"context_line":"        routes_ha \u003d parser.add_mutually_exclusive_group()"},{"line_number":467,"context_line":"        routes_ha.add_argument("},{"line_number":468,"context_line":"            \u0027--ha\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_467a10be","line":465,"range":{"start_line":454,"start_character":0,"end_line":465,"end_character":9},"in_reply_to":"7a77a97e_43592534","updated":"2016-11-20 05:25:09.000000000","message":"clear routes have to be mutually exclusive.\nBut in order to allow clearing/overwriting the information, we need to keep --no-route and --route  NON mutually exclusive.","commit_id":"95f53f9e13ef22f93d2c42764de591e43af1252d"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"f8bd5dc668f2d36cb06132f91368aad2a831d289","unresolved":false,"context_lines":[{"line_number":454,"context_line":"        parser.add_argument("},{"line_number":455,"context_line":"            \u0027--no-route\u0027,"},{"line_number":456,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":457,"context_line":"            help\u003d_(\"Clear routes associated with the router.\""},{"line_number":458,"context_line":"                   \"Specify both --route and --no-route to overwrite \""},{"line_number":459,"context_line":"                   \"current value of route.\")"},{"line_number":460,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a74a57a_3eb2c994","line":457,"range":{"start_line":457,"start_character":60,"end_line":457,"end_character":61},"updated":"2016-11-28 04:56:43.000000000","message":"nit: Need a white space here.","commit_id":"e4c5a0d07c3ea4d75d89995f47a9e984fa84987e"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"4e77d16805dd898eb684d2fc4e0b7d76cd5949a4","unresolved":false,"context_lines":[{"line_number":451,"context_line":"                   \"gateway: nexthop IP address \""},{"line_number":452,"context_line":"                   \"(repeat option to set multiple routes)\")"},{"line_number":453,"context_line":"        )"},{"line_number":454,"context_line":"        parser.add_argument("},{"line_number":455,"context_line":"            \u0027--no-route\u0027,"},{"line_number":456,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":457,"context_line":"            help\u003d_(\"Clear routes associated with the router. \""},{"line_number":458,"context_line":"                   \"Specify both --route and --no-route to overwrite \""},{"line_number":459,"context_line":"                   \"current value of route.\")"},{"line_number":460,"context_line":"        )"},{"line_number":461,"context_line":"        routes_group.add_argument("},{"line_number":462,"context_line":"            \u0027--clear-routes\u0027,"},{"line_number":463,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":464,"context_line":"            help\u003dargparse.SUPPRESS,"},{"line_number":465,"context_line":"        )"},{"line_number":466,"context_line":"        routes_ha \u003d parser.add_mutually_exclusive_group()"},{"line_number":467,"context_line":"        routes_ha.add_argument("},{"line_number":468,"context_line":"            \u0027--ha\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a71b18c_1301ffae","line":465,"range":{"start_line":454,"start_character":1,"end_line":465,"end_character":9},"updated":"2016-12-01 20:56:43.000000000","message":"These should be mutually exclusive.","commit_id":"f165bcfc439fb85da62ecc5c04c49e07cb9c12bc"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"9a944efa1da9b6e829f3990b8b0623ed0cfbda6e","unresolved":false,"context_lines":[{"line_number":451,"context_line":"                   \"gateway: nexthop IP address \""},{"line_number":452,"context_line":"                   \"(repeat option to set multiple routes)\")"},{"line_number":453,"context_line":"        )"},{"line_number":454,"context_line":"        parser.add_argument("},{"line_number":455,"context_line":"            \u0027--no-route\u0027,"},{"line_number":456,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":457,"context_line":"            help\u003d_(\"Clear routes associated with the router. \""},{"line_number":458,"context_line":"                   \"Specify both --route and --no-route to overwrite \""},{"line_number":459,"context_line":"                   \"current value of route.\")"},{"line_number":460,"context_line":"        )"},{"line_number":461,"context_line":"        routes_group.add_argument("},{"line_number":462,"context_line":"            \u0027--clear-routes\u0027,"},{"line_number":463,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":464,"context_line":"            help\u003dargparse.SUPPRESS,"},{"line_number":465,"context_line":"        )"},{"line_number":466,"context_line":"        routes_ha \u003d parser.add_mutually_exclusive_group()"},{"line_number":467,"context_line":"        routes_ha.add_argument("},{"line_number":468,"context_line":"            \u0027--ha\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a71b18c_07cc4f88","line":465,"range":{"start_line":454,"start_character":1,"end_line":465,"end_character":9},"in_reply_to":"3a71b18c_1301ffae","updated":"2016-12-02 04:21:04.000000000","message":"Hi Richard,\n\nAs TangChen mentioned in an earlier comment:\n--route and --clear-route cannot be specified at the same time, and --route and --no-route can be used at the same time.If --clear-route and --no-route are used concurrently, then they both mean \"clear the routes\". \nIt will not hamper the functionality in any way","commit_id":"f165bcfc439fb85da62ecc5c04c49e07cb9c12bc"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"1cc87a7da20b380aa4d78999ea06d5794b94de27","unresolved":false,"context_lines":[{"line_number":451,"context_line":"                   \"gateway: nexthop IP address \""},{"line_number":452,"context_line":"                   \"(repeat option to set multiple routes)\")"},{"line_number":453,"context_line":"        )"},{"line_number":454,"context_line":"        parser.add_argument("},{"line_number":455,"context_line":"            \u0027--no-route\u0027,"},{"line_number":456,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":457,"context_line":"            help\u003d_(\"Clear routes associated with the router. \""},{"line_number":458,"context_line":"                   \"Specify both --route and --no-route to overwrite \""},{"line_number":459,"context_line":"                   \"current value of route.\")"},{"line_number":460,"context_line":"        )"},{"line_number":461,"context_line":"        routes_group.add_argument("},{"line_number":462,"context_line":"            \u0027--clear-routes\u0027,"},{"line_number":463,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":464,"context_line":"            help\u003dargparse.SUPPRESS,"},{"line_number":465,"context_line":"        )"},{"line_number":466,"context_line":"        routes_ha \u003d parser.add_mutually_exclusive_group()"},{"line_number":467,"context_line":"        routes_ha.add_argument("},{"line_number":468,"context_line":"            \u0027--ha\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a71b18c_0cbe5dd4","line":465,"range":{"start_line":454,"start_character":0,"end_line":465,"end_character":9},"updated":"2016-12-07 17:33:54.000000000","message":"I still don\u0027t understand why we would allow both of these to be specified.  Once is replacing the other and they should be used in the same way.","commit_id":"bea476ad88d08602ba3b16d94c8dcfd2abf54354"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"0bc68d529dd9f45b46735b066e72a8b8a80c6b8c","unresolved":false,"context_lines":[{"line_number":451,"context_line":"                   \"gateway: nexthop IP address \""},{"line_number":452,"context_line":"                   \"(repeat option to set multiple routes)\")"},{"line_number":453,"context_line":"        )"},{"line_number":454,"context_line":"        parser.add_argument("},{"line_number":455,"context_line":"            \u0027--no-route\u0027,"},{"line_number":456,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":457,"context_line":"            help\u003d_(\"Clear routes associated with the router. \""},{"line_number":458,"context_line":"                   \"Specify both --route and --no-route to overwrite \""},{"line_number":459,"context_line":"                   \"current value of route.\")"},{"line_number":460,"context_line":"        )"},{"line_number":461,"context_line":"        routes_group.add_argument("},{"line_number":462,"context_line":"            \u0027--clear-routes\u0027,"},{"line_number":463,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":464,"context_line":"            help\u003dargparse.SUPPRESS,"},{"line_number":465,"context_line":"        )"},{"line_number":466,"context_line":"        routes_ha \u003d parser.add_mutually_exclusive_group()"},{"line_number":467,"context_line":"        routes_ha.add_argument("},{"line_number":468,"context_line":"            \u0027--ha\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6eadb0_6467664d","line":465,"range":{"start_line":454,"start_character":0,"end_line":465,"end_character":9},"in_reply_to":"1a6eadb0_149524dd","updated":"2016-12-15 06:05:23.000000000","message":"Now I am confused.\n\nIn the last comment you are saying --route and --clear-routes to be mutually -exclusive.\nAnd 2 comments before that , you mentioned that --route and --clear-routes not to be mutually exclusive :)","commit_id":"bea476ad88d08602ba3b16d94c8dcfd2abf54354"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"02663c525ace23628a9a5ad3f5496878201ab93d","unresolved":false,"context_lines":[{"line_number":451,"context_line":"                   \"gateway: nexthop IP address \""},{"line_number":452,"context_line":"                   \"(repeat option to set multiple routes)\")"},{"line_number":453,"context_line":"        )"},{"line_number":454,"context_line":"        parser.add_argument("},{"line_number":455,"context_line":"            \u0027--no-route\u0027,"},{"line_number":456,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":457,"context_line":"            help\u003d_(\"Clear routes associated with the router. \""},{"line_number":458,"context_line":"                   \"Specify both --route and --no-route to overwrite \""},{"line_number":459,"context_line":"                   \"current value of route.\")"},{"line_number":460,"context_line":"        )"},{"line_number":461,"context_line":"        routes_group.add_argument("},{"line_number":462,"context_line":"            \u0027--clear-routes\u0027,"},{"line_number":463,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":464,"context_line":"            help\u003dargparse.SUPPRESS,"},{"line_number":465,"context_line":"        )"},{"line_number":466,"context_line":"        routes_ha \u003d parser.add_mutually_exclusive_group()"},{"line_number":467,"context_line":"        routes_ha.add_argument("},{"line_number":468,"context_line":"            \u0027--ha\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6eadb0_956889f7","line":465,"range":{"start_line":454,"start_character":0,"end_line":465,"end_character":9},"in_reply_to":"1a6eadb0_45490c8b","updated":"2016-12-13 15:18:04.000000000","message":"Interesting point.\nWhy shouldnt --route and --clear-route also be mutually exclusive?\nDo you want override parameter applicable for both (--route and --no-route ) and (--route and --clear-routes) pair of options?\n\nBecause then the development documentation for Override parameter would have to be changed, isnt it?","commit_id":"bea476ad88d08602ba3b16d94c8dcfd2abf54354"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"25e39b3503cadcca42df516051eb6abb9ceafbe3","unresolved":false,"context_lines":[{"line_number":451,"context_line":"                   \"gateway: nexthop IP address \""},{"line_number":452,"context_line":"                   \"(repeat option to set multiple routes)\")"},{"line_number":453,"context_line":"        )"},{"line_number":454,"context_line":"        parser.add_argument("},{"line_number":455,"context_line":"            \u0027--no-route\u0027,"},{"line_number":456,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":457,"context_line":"            help\u003d_(\"Clear routes associated with the router. \""},{"line_number":458,"context_line":"                   \"Specify both --route and --no-route to overwrite \""},{"line_number":459,"context_line":"                   \"current value of route.\")"},{"line_number":460,"context_line":"        )"},{"line_number":461,"context_line":"        routes_group.add_argument("},{"line_number":462,"context_line":"            \u0027--clear-routes\u0027,"},{"line_number":463,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":464,"context_line":"            help\u003dargparse.SUPPRESS,"},{"line_number":465,"context_line":"        )"},{"line_number":466,"context_line":"        routes_ha \u003d parser.add_mutually_exclusive_group()"},{"line_number":467,"context_line":"        routes_ha.add_argument("},{"line_number":468,"context_line":"            \u0027--ha\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6eadb0_9072ee0f","line":465,"range":{"start_line":454,"start_character":0,"end_line":465,"end_character":9},"in_reply_to":"1a6eadb0_6467664d","updated":"2016-12-15 12:03:37.000000000","message":"Sorry about that typo.  I mean --no-route and --clear-route.","commit_id":"bea476ad88d08602ba3b16d94c8dcfd2abf54354"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"523968776f21c1d8e4f614f87b460f2fddb3eef4","unresolved":false,"context_lines":[{"line_number":451,"context_line":"                   \"gateway: nexthop IP address \""},{"line_number":452,"context_line":"                   \"(repeat option to set multiple routes)\")"},{"line_number":453,"context_line":"        )"},{"line_number":454,"context_line":"        parser.add_argument("},{"line_number":455,"context_line":"            \u0027--no-route\u0027,"},{"line_number":456,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":457,"context_line":"            help\u003d_(\"Clear routes associated with the router. \""},{"line_number":458,"context_line":"                   \"Specify both --route and --no-route to overwrite \""},{"line_number":459,"context_line":"                   \"current value of route.\")"},{"line_number":460,"context_line":"        )"},{"line_number":461,"context_line":"        routes_group.add_argument("},{"line_number":462,"context_line":"            \u0027--clear-routes\u0027,"},{"line_number":463,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":464,"context_line":"            help\u003dargparse.SUPPRESS,"},{"line_number":465,"context_line":"        )"},{"line_number":466,"context_line":"        routes_ha \u003d parser.add_mutually_exclusive_group()"},{"line_number":467,"context_line":"        routes_ha.add_argument("},{"line_number":468,"context_line":"            \u0027--ha\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6eadb0_149524dd","line":465,"range":{"start_line":454,"start_character":0,"end_line":465,"end_character":9},"in_reply_to":"1a6eadb0_956889f7","updated":"2016-12-14 14:41:35.000000000","message":"I think --route and --clear-route should be mutually exclusive and either could be used for override.  I don\u0027t think the help text needs to change since we are suppressing the --clear-routes parameter.","commit_id":"bea476ad88d08602ba3b16d94c8dcfd2abf54354"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"55bde49b90efc2dffc7ff07f181cbf1afd97cc63","unresolved":false,"context_lines":[{"line_number":451,"context_line":"                   \"gateway: nexthop IP address \""},{"line_number":452,"context_line":"                   \"(repeat option to set multiple routes)\")"},{"line_number":453,"context_line":"        )"},{"line_number":454,"context_line":"        parser.add_argument("},{"line_number":455,"context_line":"            \u0027--no-route\u0027,"},{"line_number":456,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":457,"context_line":"            help\u003d_(\"Clear routes associated with the router. \""},{"line_number":458,"context_line":"                   \"Specify both --route and --no-route to overwrite \""},{"line_number":459,"context_line":"                   \"current value of route.\")"},{"line_number":460,"context_line":"        )"},{"line_number":461,"context_line":"        routes_group.add_argument("},{"line_number":462,"context_line":"            \u0027--clear-routes\u0027,"},{"line_number":463,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":464,"context_line":"            help\u003dargparse.SUPPRESS,"},{"line_number":465,"context_line":"        )"},{"line_number":466,"context_line":"        routes_ha \u003d parser.add_mutually_exclusive_group()"},{"line_number":467,"context_line":"        routes_ha.add_argument("},{"line_number":468,"context_line":"            \u0027--ha\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a71b18c_a098be1c","line":465,"range":{"start_line":454,"start_character":0,"end_line":465,"end_character":9},"in_reply_to":"3a71b18c_03ed438e","updated":"2016-12-09 07:41:44.000000000","message":"I can add a check in take_action, but not sure how to add a check in get_parser\n\nAny suggestions ?","commit_id":"bea476ad88d08602ba3b16d94c8dcfd2abf54354"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"42bf94673c197d113de35bf81233421088f702df","unresolved":false,"context_lines":[{"line_number":451,"context_line":"                   \"gateway: nexthop IP address \""},{"line_number":452,"context_line":"                   \"(repeat option to set multiple routes)\")"},{"line_number":453,"context_line":"        )"},{"line_number":454,"context_line":"        parser.add_argument("},{"line_number":455,"context_line":"            \u0027--no-route\u0027,"},{"line_number":456,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":457,"context_line":"            help\u003d_(\"Clear routes associated with the router. \""},{"line_number":458,"context_line":"                   \"Specify both --route and --no-route to overwrite \""},{"line_number":459,"context_line":"                   \"current value of route.\")"},{"line_number":460,"context_line":"        )"},{"line_number":461,"context_line":"        routes_group.add_argument("},{"line_number":462,"context_line":"            \u0027--clear-routes\u0027,"},{"line_number":463,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":464,"context_line":"            help\u003dargparse.SUPPRESS,"},{"line_number":465,"context_line":"        )"},{"line_number":466,"context_line":"        routes_ha \u003d parser.add_mutually_exclusive_group()"},{"line_number":467,"context_line":"        routes_ha.add_argument("},{"line_number":468,"context_line":"            \u0027--ha\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a71b18c_7a369fe8","line":465,"range":{"start_line":454,"start_character":0,"end_line":465,"end_character":9},"in_reply_to":"3a71b18c_0cbe5dd4","updated":"2016-12-07 17:56:17.000000000","message":"when clear routes is already deprecated, should we provide the support on it?","commit_id":"bea476ad88d08602ba3b16d94c8dcfd2abf54354"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"bd1489ab46c2a7dbf3bc22b939cd7d3ea2b2c235","unresolved":false,"context_lines":[{"line_number":451,"context_line":"                   \"gateway: nexthop IP address \""},{"line_number":452,"context_line":"                   \"(repeat option to set multiple routes)\")"},{"line_number":453,"context_line":"        )"},{"line_number":454,"context_line":"        parser.add_argument("},{"line_number":455,"context_line":"            \u0027--no-route\u0027,"},{"line_number":456,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":457,"context_line":"            help\u003d_(\"Clear routes associated with the router. \""},{"line_number":458,"context_line":"                   \"Specify both --route and --no-route to overwrite \""},{"line_number":459,"context_line":"                   \"current value of route.\")"},{"line_number":460,"context_line":"        )"},{"line_number":461,"context_line":"        routes_group.add_argument("},{"line_number":462,"context_line":"            \u0027--clear-routes\u0027,"},{"line_number":463,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":464,"context_line":"            help\u003dargparse.SUPPRESS,"},{"line_number":465,"context_line":"        )"},{"line_number":466,"context_line":"        routes_ha \u003d parser.add_mutually_exclusive_group()"},{"line_number":467,"context_line":"        routes_ha.add_argument("},{"line_number":468,"context_line":"            \u0027--ha\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a71b18c_4b751796","line":465,"range":{"start_line":454,"start_character":0,"end_line":465,"end_character":9},"in_reply_to":"3a71b18c_1bd718c0","updated":"2016-12-11 06:59:30.000000000","message":"The issue is :\n\n  --route and --clear-routes need to be mutually exclusive\n  --no-route and --clear-routes need to be mutually exclusive\n  --route and --no-route dont need to be mutually exclusive\n\nI think we can add --route and --no-route in an argument group[1] which is mutually exclusive with --clear-routes\nWhat do you think?\n\n\n[1]: https://docs.python.org/2/library/argparse.html#argument-groups","commit_id":"bea476ad88d08602ba3b16d94c8dcfd2abf54354"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"5df656f51f341bf6292f8b4ad6e0db18ce442d55","unresolved":false,"context_lines":[{"line_number":451,"context_line":"                   \"gateway: nexthop IP address \""},{"line_number":452,"context_line":"                   \"(repeat option to set multiple routes)\")"},{"line_number":453,"context_line":"        )"},{"line_number":454,"context_line":"        parser.add_argument("},{"line_number":455,"context_line":"            \u0027--no-route\u0027,"},{"line_number":456,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":457,"context_line":"            help\u003d_(\"Clear routes associated with the router. \""},{"line_number":458,"context_line":"                   \"Specify both --route and --no-route to overwrite \""},{"line_number":459,"context_line":"                   \"current value of route.\")"},{"line_number":460,"context_line":"        )"},{"line_number":461,"context_line":"        routes_group.add_argument("},{"line_number":462,"context_line":"            \u0027--clear-routes\u0027,"},{"line_number":463,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":464,"context_line":"            help\u003dargparse.SUPPRESS,"},{"line_number":465,"context_line":"        )"},{"line_number":466,"context_line":"        routes_ha \u003d parser.add_mutually_exclusive_group()"},{"line_number":467,"context_line":"        routes_ha.add_argument("},{"line_number":468,"context_line":"            \u0027--ha\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6eadb0_45490c8b","line":465,"range":{"start_line":454,"start_character":0,"end_line":465,"end_character":9},"in_reply_to":"3a71b18c_4b751796","updated":"2016-12-12 21:18:51.000000000","message":"--route and --clear-routes now shouldn\u0027t need to be mutually exclusive.","commit_id":"bea476ad88d08602ba3b16d94c8dcfd2abf54354"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"bd8b23e2d543bb3c4c6b9bb02e4dae375448030f","unresolved":false,"context_lines":[{"line_number":451,"context_line":"                   \"gateway: nexthop IP address \""},{"line_number":452,"context_line":"                   \"(repeat option to set multiple routes)\")"},{"line_number":453,"context_line":"        )"},{"line_number":454,"context_line":"        parser.add_argument("},{"line_number":455,"context_line":"            \u0027--no-route\u0027,"},{"line_number":456,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":457,"context_line":"            help\u003d_(\"Clear routes associated with the router. \""},{"line_number":458,"context_line":"                   \"Specify both --route and --no-route to overwrite \""},{"line_number":459,"context_line":"                   \"current value of route.\")"},{"line_number":460,"context_line":"        )"},{"line_number":461,"context_line":"        routes_group.add_argument("},{"line_number":462,"context_line":"            \u0027--clear-routes\u0027,"},{"line_number":463,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":464,"context_line":"            help\u003dargparse.SUPPRESS,"},{"line_number":465,"context_line":"        )"},{"line_number":466,"context_line":"        routes_ha \u003d parser.add_mutually_exclusive_group()"},{"line_number":467,"context_line":"        routes_ha.add_argument("},{"line_number":468,"context_line":"            \u0027--ha\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a71b18c_03ed438e","line":465,"range":{"start_line":454,"start_character":0,"end_line":465,"end_character":9},"in_reply_to":"3a71b18c_7a369fe8","updated":"2016-12-07 20:48:00.000000000","message":"They are effectively the same option so we should continue to prevent both from being specified.","commit_id":"bea476ad88d08602ba3b16d94c8dcfd2abf54354"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"3a17d1a005ac5876b706fbeb8cf556a79cd325e1","unresolved":false,"context_lines":[{"line_number":451,"context_line":"                   \"gateway: nexthop IP address \""},{"line_number":452,"context_line":"                   \"(repeat option to set multiple routes)\")"},{"line_number":453,"context_line":"        )"},{"line_number":454,"context_line":"        parser.add_argument("},{"line_number":455,"context_line":"            \u0027--no-route\u0027,"},{"line_number":456,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":457,"context_line":"            help\u003d_(\"Clear routes associated with the router. \""},{"line_number":458,"context_line":"                   \"Specify both --route and --no-route to overwrite \""},{"line_number":459,"context_line":"                   \"current value of route.\")"},{"line_number":460,"context_line":"        )"},{"line_number":461,"context_line":"        routes_group.add_argument("},{"line_number":462,"context_line":"            \u0027--clear-routes\u0027,"},{"line_number":463,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":464,"context_line":"            help\u003dargparse.SUPPRESS,"},{"line_number":465,"context_line":"        )"},{"line_number":466,"context_line":"        routes_ha \u003d parser.add_mutually_exclusive_group()"},{"line_number":467,"context_line":"        routes_ha.add_argument("},{"line_number":468,"context_line":"            \u0027--ha\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a71b18c_1bd718c0","line":465,"range":{"start_line":454,"start_character":0,"end_line":465,"end_character":9},"in_reply_to":"3a71b18c_a098be1c","updated":"2016-12-09 12:14:55.000000000","message":"I would just keep clear-routes and no-route mutually exclusive.","commit_id":"bea476ad88d08602ba3b16d94c8dcfd2abf54354"}],"releasenotes/notes/add-overwrite-option-to-router-7c50c8031dab6bae.yaml":[{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"0a7be3142ab7d0252e32084eab3133a5a3d76b17","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add support to overwrite routes in a router instance, using ``--router``"},{"line_number":5,"context_line":"    and ``--no-router`` option in ``osc router set``."},{"line_number":6,"context_line":"    [ Blueprint `network-property-unset \u003chttps://blueprints.launchpad.net/python-openstackclient/+spec/allow-overwrite-set-options\u003e`_]"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5a74a57a_954bbb86","line":6,"range":{"start_line":6,"start_character":17,"end_line":6,"end_character":39},"updated":"2016-11-28 07:03:03.000000000","message":"nit: \"allow-overwrite-set-options\"?","commit_id":"f165bcfc439fb85da62ecc5c04c49e07cb9c12bc"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"9a944efa1da9b6e829f3990b8b0623ed0cfbda6e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add support to overwrite routes in a router instance, using ``--router``"},{"line_number":5,"context_line":"    and ``--no-router`` option in ``osc router set``."},{"line_number":6,"context_line":"    [ Blueprint `network-property-unset \u003chttps://blueprints.launchpad.net/python-openstackclient/+spec/allow-overwrite-set-options\u003e`_]"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3a71b18c_678fc323","line":6,"range":{"start_line":6,"start_character":17,"end_line":6,"end_character":39},"in_reply_to":"5a74a57a_954bbb86","updated":"2016-12-02 04:21:04.000000000","message":"Done","commit_id":"f165bcfc439fb85da62ecc5c04c49e07cb9c12bc"}]}