)]}'
{"doc/source/command-objects/network-qos-policy.rst":[{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"f40dbe39c36557417511540a9f1af7ecd788ff06","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    os network qos policy list"},{"line_number":74,"context_line":"        [--project \u003cproject\u003e]"},{"line_number":75,"context_line":"        [--project-domain \u003cproject-domain\u003e]"},{"line_number":76,"context_line":"        [--share | --no-share]"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":".. option:: --project \u003cproject\u003e"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a74a57a_37ec42c7","line":75,"updated":"2016-11-23 10:31:11.000000000","message":"We usually use this format for project and project domain:\n    [--project \u003cproject\u003e [--project-domain \u003cproject-domain\u003e]]","commit_id":"1602dbf511f8377918727c44903d9d6ae24720ed"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"f40dbe39c36557417511540a9f1af7ecd788ff06","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":".. option:: --share"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    Make the QoS policy accessible by other projects"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":".. option:: --no-share"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a74a57a_b774d2fd","line":89,"updated":"2016-11-23 10:31:11.000000000","message":"doc should match the help message","commit_id":"1602dbf511f8377918727c44903d9d6ae24720ed"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"f40dbe39c36557417511540a9f1af7ecd788ff06","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":".. option:: --no-share"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    Make the QoS policy not accessible by other projects"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"network qos policy set"},{"line_number":96,"context_line":"----------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a74a57a_57545e53","line":93,"updated":"2016-11-23 10:31:11.000000000","message":"doc should match the help message","commit_id":"1602dbf511f8377918727c44903d9d6ae24720ed"}],"openstackclient/network/v2/network_qos_policy.py":[{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"5332d15e9e54f6a0b69f09c7289346d8fae2465a","unresolved":false,"context_lines":[{"line_number":181,"context_line":"        args \u003d {}"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        if parsed_args.share:"},{"line_number":184,"context_line":"            args[\u0027shared\u0027] \u003d True"},{"line_number":185,"context_line":"        elif parsed_args.no_share:"},{"line_number":186,"context_line":"            args[\u0027shared\u0027] \u003d False"},{"line_number":187,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a430d35_adbbf0e3","line":184,"updated":"2017-02-08 02:46:13.000000000","message":"Please also update \"is_share\" here for the SDK refactor","commit_id":"cb8a14e72dfe0f9e4a79b2387e731058cba6e399"},{"author":{"_account_id":19532,"name":"Lv Jiawei","email":"lvjiawei@cmss.chinamobile.com","username":"zhangoic"},"change_message_id":"808ae4ecb329b8a74611f777208e34d403295f3b","unresolved":false,"context_lines":[{"line_number":181,"context_line":"        args \u003d {}"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        if parsed_args.share:"},{"line_number":184,"context_line":"            args[\u0027shared\u0027] \u003d True"},{"line_number":185,"context_line":"        elif parsed_args.no_share:"},{"line_number":186,"context_line":"            args[\u0027shared\u0027] \u003d False"},{"line_number":187,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a30ddce_e7699efa","line":184,"in_reply_to":"1a430d35_adbbf0e3","updated":"2017-03-10 02:34:47.000000000","message":"Done","commit_id":"cb8a14e72dfe0f9e4a79b2387e731058cba6e399"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"5332d15e9e54f6a0b69f09c7289346d8fae2465a","unresolved":false,"context_lines":[{"line_number":192,"context_line":"                parsed_args.project,"},{"line_number":193,"context_line":"                parsed_args.project_domain,"},{"line_number":194,"context_line":"            )"},{"line_number":195,"context_line":"            args[\u0027tenant_id\u0027] \u003d project.id"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"        data \u003d client.qos_policies(**args)"},{"line_number":198,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a430d35_edb17802","line":195,"updated":"2017-02-08 02:46:13.000000000","message":"Please also update \"project_id\" here for the SDK refactor","commit_id":"cb8a14e72dfe0f9e4a79b2387e731058cba6e399"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e9af79854463561b3e623505396979a33afb8bb9","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        )"},{"line_number":181,"context_line":"        args \u003d {}"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        if parsed_args.share:"},{"line_number":184,"context_line":"            args[\u0027shared\u0027] \u003d True"},{"line_number":185,"context_line":"        elif parsed_args.no_share:"},{"line_number":186,"context_line":"            args[\u0027shared\u0027] \u003d False"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        if parsed_args.project:"},{"line_number":189,"context_line":"            identity_client \u003d self.app.client_manager.identity"},{"line_number":190,"context_line":"            project \u003d identity_common.find_project("},{"line_number":191,"context_line":"                identity_client,"},{"line_number":192,"context_line":"                parsed_args.project,"},{"line_number":193,"context_line":"                parsed_args.project_domain,"},{"line_number":194,"context_line":"            )"},{"line_number":195,"context_line":"            args[\u0027tenant_id\u0027] \u003d project.id"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"        data \u003d client.qos_policies(**args)"},{"line_number":198,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a430d35_70971348","line":195,"range":{"start_line":183,"start_character":0,"end_line":195,"end_character":42},"updated":"2017-02-08 09:31:33.000000000","message":"You should use \"_get_attrs()\" (L38)","commit_id":"cb8a14e72dfe0f9e4a79b2387e731058cba6e399"},{"author":{"_account_id":19532,"name":"Lv Jiawei","email":"lvjiawei@cmss.chinamobile.com","username":"zhangoic"},"change_message_id":"808ae4ecb329b8a74611f777208e34d403295f3b","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        )"},{"line_number":181,"context_line":"        args \u003d {}"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        if parsed_args.share:"},{"line_number":184,"context_line":"            args[\u0027shared\u0027] \u003d True"},{"line_number":185,"context_line":"        elif parsed_args.no_share:"},{"line_number":186,"context_line":"            args[\u0027shared\u0027] \u003d False"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        if parsed_args.project:"},{"line_number":189,"context_line":"            identity_client \u003d self.app.client_manager.identity"},{"line_number":190,"context_line":"            project \u003d identity_common.find_project("},{"line_number":191,"context_line":"                identity_client,"},{"line_number":192,"context_line":"                parsed_args.project,"},{"line_number":193,"context_line":"                parsed_args.project_domain,"},{"line_number":194,"context_line":"            )"},{"line_number":195,"context_line":"            args[\u0027tenant_id\u0027] \u003d project.id"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"        data \u003d client.qos_policies(**args)"},{"line_number":198,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a430d35_921c4c6b","line":195,"range":{"start_line":183,"start_character":0,"end_line":195,"end_character":42},"in_reply_to":"1a430d35_70971348","updated":"2017-03-10 02:34:47.000000000","message":"I think the function does not fit list method. It is used in create or set method.","commit_id":"cb8a14e72dfe0f9e4a79b2387e731058cba6e399"},{"author":{"_account_id":19532,"name":"Lv Jiawei","email":"lvjiawei@cmss.chinamobile.com","username":"zhangoic"},"change_message_id":"808ae4ecb329b8a74611f777208e34d403295f3b","unresolved":false,"context_lines":[{"line_number":192,"context_line":"                parsed_args.project,"},{"line_number":193,"context_line":"                parsed_args.project_domain,"},{"line_number":194,"context_line":"            )"},{"line_number":195,"context_line":"            args[\u0027tenant_id\u0027] \u003d project.id"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"        data \u003d client.qos_policies(**args)"},{"line_number":198,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a30ddce_c7649a23","line":195,"in_reply_to":"1a430d35_edb17802","updated":"2017-03-10 02:34:47.000000000","message":"Done","commit_id":"cb8a14e72dfe0f9e4a79b2387e731058cba6e399"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"61e4d329fb91b2d3c468effb0973b0521e4e63f4","unresolved":false,"context_lines":[{"line_number":178,"context_line":"            \u0027Shared\u0027,"},{"line_number":179,"context_line":"            \u0027Project\u0027,"},{"line_number":180,"context_line":"        )"},{"line_number":181,"context_line":"        args \u003d {}"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        if parsed_args.share:"},{"line_number":184,"context_line":"            args[\u0027is_shared\u0027] \u003d True"},{"line_number":185,"context_line":"        elif parsed_args.no_share:"},{"line_number":186,"context_line":"            args[\u0027is_shared\u0027] \u003d False"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        if parsed_args.project:"},{"line_number":189,"context_line":"            identity_client \u003d self.app.client_manager.identity"},{"line_number":190,"context_line":"            project \u003d identity_common.find_project("},{"line_number":191,"context_line":"                identity_client,"},{"line_number":192,"context_line":"                parsed_args.project,"},{"line_number":193,"context_line":"                parsed_args.project_domain,"},{"line_number":194,"context_line":"            )"},{"line_number":195,"context_line":"            args[\u0027project_id\u0027] \u003d project.id"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"        data \u003d client.qos_policies(**args)"},{"line_number":198,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9a30ddce_e71a397c","line":195,"range":{"start_line":181,"start_character":0,"end_line":195,"end_character":43},"updated":"2017-03-13 10:24:19.000000000","message":"As I told in PS3, you should use \"_get_attrs()\" to avoid redundant code.","commit_id":"0a78bb790c8e97cac72afbde4450c595c5e288fc"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c5cc9e0f1c7d3d790f54c8ffb692a30a08b5aac0","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"def _get_attrs(client_manager, parsed_args):"},{"line_number":39,"context_line":"    attrs \u003d {}"},{"line_number":40,"context_line":"    if getattr(parsed_args, \u0027name\u0027, None) is not None:"},{"line_number":41,"context_line":"        attrs[\u0027name\u0027] \u003d str(parsed_args.name)"},{"line_number":42,"context_line":"    if getattr(parsed_args, \u0027description\u0027, None) is not None:"},{"line_number":43,"context_line":"        attrs[\u0027description\u0027] \u003d parsed_args.description"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a30ddce_2c9984c4","line":40,"range":{"start_line":40,"start_character":4,"end_line":40,"end_character":54},"updated":"2017-03-13 16:07:19.000000000","message":"The correct way is:\n\nif (\u0027name\u0027 in parsed_args and parsed_args.name is not None):","commit_id":"c46b685a383cf26259d5add7f71697eebdb3c64e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c5cc9e0f1c7d3d790f54c8ffb692a30a08b5aac0","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    attrs \u003d {}"},{"line_number":40,"context_line":"    if getattr(parsed_args, \u0027name\u0027, None) is not None:"},{"line_number":41,"context_line":"        attrs[\u0027name\u0027] \u003d str(parsed_args.name)"},{"line_number":42,"context_line":"    if getattr(parsed_args, \u0027description\u0027, None) is not None:"},{"line_number":43,"context_line":"        attrs[\u0027description\u0027] \u003d parsed_args.description"},{"line_number":44,"context_line":"    if getattr(parsed_args, \u0027share\u0027, None):"},{"line_number":45,"context_line":"        attrs[\u0027shared\u0027] \u003d True"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a30ddce_cc87085f","line":42,"range":{"start_line":42,"start_character":4,"end_line":42,"end_character":61},"updated":"2017-03-13 16:07:19.000000000","message":"The correct way is:\n\nif (\u0027description\u0027 in parsed_args and parsed_args.description is not None):","commit_id":"c46b685a383cf26259d5add7f71697eebdb3c64e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c5cc9e0f1c7d3d790f54c8ffb692a30a08b5aac0","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        attrs[\u0027name\u0027] \u003d str(parsed_args.name)"},{"line_number":42,"context_line":"    if getattr(parsed_args, \u0027description\u0027, None) is not None:"},{"line_number":43,"context_line":"        attrs[\u0027description\u0027] \u003d parsed_args.description"},{"line_number":44,"context_line":"    if getattr(parsed_args, \u0027share\u0027, None):"},{"line_number":45,"context_line":"        attrs[\u0027shared\u0027] \u003d True"},{"line_number":46,"context_line":"    if getattr(parsed_args, \u0027no_share\u0027, None):"},{"line_number":47,"context_line":"        attrs[\u0027shared\u0027] \u003d False"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a30ddce_ec55acf9","line":44,"range":{"start_line":44,"start_character":4,"end_line":44,"end_character":43},"updated":"2017-03-13 16:07:19.000000000","message":"\u0027share\u0027 is both in create and list, you don\u0027t need to change it.\n\nYou can keep the old code:\n  if parsed_args.share:","commit_id":"c46b685a383cf26259d5add7f71697eebdb3c64e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c5cc9e0f1c7d3d790f54c8ffb692a30a08b5aac0","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        attrs[\u0027description\u0027] \u003d parsed_args.description"},{"line_number":44,"context_line":"    if getattr(parsed_args, \u0027share\u0027, None):"},{"line_number":45,"context_line":"        attrs[\u0027shared\u0027] \u003d True"},{"line_number":46,"context_line":"    if getattr(parsed_args, \u0027no_share\u0027, None):"},{"line_number":47,"context_line":"        attrs[\u0027shared\u0027] \u003d False"},{"line_number":48,"context_line":"    if getattr(parsed_args, \u0027project\u0027, None) is not None:"},{"line_number":49,"context_line":"        identity_client \u003d client_manager.identity"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a30ddce_2c6b44b8","line":46,"range":{"start_line":46,"start_character":4,"end_line":46,"end_character":46},"updated":"2017-03-13 16:07:19.000000000","message":"ditto, \u0027no_share\u0027 is both in create and list, you don\u0027t need to change it.","commit_id":"c46b685a383cf26259d5add7f71697eebdb3c64e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c5cc9e0f1c7d3d790f54c8ffb692a30a08b5aac0","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        attrs[\u0027shared\u0027] \u003d True"},{"line_number":46,"context_line":"    if getattr(parsed_args, \u0027no_share\u0027, None):"},{"line_number":47,"context_line":"        attrs[\u0027shared\u0027] \u003d False"},{"line_number":48,"context_line":"    if getattr(parsed_args, \u0027project\u0027, None) is not None:"},{"line_number":49,"context_line":"        identity_client \u003d client_manager.identity"},{"line_number":50,"context_line":"        project_id \u003d identity_common.find_project("},{"line_number":51,"context_line":"            identity_client,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a30ddce_8c5c301a","line":48,"range":{"start_line":48,"start_character":4,"end_line":48,"end_character":57},"updated":"2017-03-13 16:07:19.000000000","message":"ditto","commit_id":"c46b685a383cf26259d5add7f71697eebdb3c64e"}],"releasenotes/notes/add-qos-policy-list-options-9ba1ae731a88e7ac.yaml":[{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"f40dbe39c36557417511540a9f1af7ecd788ff06","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"   - Add \"--share\", \"--no-share\", \"--project\", \"--project-domain\""},{"line_number":4,"context_line":"     options to \"qos policy list\" command."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5a74a57a_b75212dc","line":3,"range":{"start_line":3,"start_character":9,"end_line":3,"end_character":10},"updated":"2016-11-23 10:31:11.000000000","message":"Please use `` instead of \"","commit_id":"1602dbf511f8377918727c44903d9d6ae24720ed"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"f40dbe39c36557417511540a9f1af7ecd788ff06","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5a74a57a_77e4fa0c","line":5,"updated":"2016-11-23 10:31:11.000000000","message":"You can add the blueprint link in the end line, see other release note for example","commit_id":"1602dbf511f8377918727c44903d9d6ae24720ed"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"c78889095df599bfc5974ef07ff18c7b5826ae9f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"   - Add ``--share``, ``--no-share``, ``--project``, ``--project-domain``"},{"line_number":4,"context_line":"     options to ``qos policy list`` command."},{"line_number":5,"context_line":"     [Blueprint `network-commands-options \u003chttps://blueprints.launchpad.net/python-openstackclient/+spec/network-commands-options\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5a74a57a_941b0f1b","line":3,"updated":"2016-11-24 13:58:35.000000000","message":"I guess there is one extra space in each line :)","commit_id":"2100a6e8a5c88f7481ca6993ed816350f0107ae0"}]}