)]}'
{"id":"openstack%2Fpython-openstackclient~403742","triplet_id":"openstack%2Fpython-openstackclient~master~Id981739663113447a7bba8ddba81ba9394a19e07","project":"openstack/python-openstackclient","branch":"master","topic":"bug/1624115","hashtags":[],"change_id":"Id981739663113447a7bba8ddba81ba9394a19e07","subject":"Remove auth_with_unscoped_saml decorator","status":"MERGED","created":"2016-11-28 14:47:38.000000000","updated":"2016-12-08 17:40:38.000000000","submitted":"2016-12-08 17:40:38.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"9d297a8260c93796df6656e8dce95a3ebb505519","_number":403742,"virtual_id_number":403742,"owner":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2016-12-08 17:40:38.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":2,"date":"2016-12-04 18:59:14.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-12-08 16:26:24.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-12-08 16:26:24.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-12-04 18:59:14.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2016-12-08 16:26:24.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2016-12-08 17:40:38.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"b4f0f2a60311d97ce76f26c20fdeec6fd0ca7141","author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"date":"2016-11-28 14:47:38.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"40addb8db88e303db4722ba7cdbfd4f4eb9ddf84","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-11-28 15:23:35.000000000","message":"Patch Set 1: Code-Review+2\n\nyes, thanks colleen, this was very wrong since the move to keystoneauth","accounts_in_message":[],"_revision_number":1},{"id":"66b95050df578195f52bd88a20c7f32527298ec7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-28 15:38:28.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/42/403742/1/check/gate-python-openstackclient-docs-ubuntu-xenial/4d32939//doc/build/html/ : SUCCESS in 3m 21s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/42/403742/1/check/gate-python-openstackclient-pep8-ubuntu-xenial/ebaaffc/ : FAILURE in 3m 23s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/42/403742/1/check/gate-python-openstackclient-python27-ubuntu-xenial/59cc15b/ : SUCCESS in 2m 45s\n- gate-python-openstackclient-python34 http://logs.openstack.org/42/403742/1/check/gate-python-openstackclient-python34/4f569f9/ : SUCCESS in 2m 49s\n- gate-python-openstackclient-python35-nv http://logs.openstack.org/42/403742/1/check/gate-python-openstackclient-python35-nv/f638851/ : SUCCESS in 3m 22s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/42/403742/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/86c5aad/ : SUCCESS in 43m 53s\n- check-osc-plugins http://logs.openstack.org/42/403742/1/check/check-osc-plugins/57509f2/ : SUCCESS in 3m 33s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/42/403742/1/check/gate-osc-dsvm-functional/f364c6c/ : SUCCESS in 16m 06s\n- gate-tripleo-ci-centos-7-nonha-multinode-nv http://logs.openstack.org/42/403742/1/check/gate-tripleo-ci-centos-7-nonha-multinode-nv/050ae0f/ : SUCCESS in 49m 32s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"504d6e20c6f61841b3d1ac00f0a07a3ca9364bc1","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-12-04 18:59:10.000000000","message":"Patch Set 2: Published edit on patch set 1","accounts_in_message":[],"_revision_number":2},{"id":"1558f0a7c917439194efd668bbe08904e1abea07","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-12-04 18:59:14.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"67edde8bdde40dcf059ff82a052108b41708de7b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-12-04 20:10:32.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/42/403742/2/check/gate-python-openstackclient-docs-ubuntu-xenial/c245e19//doc/build/html/ : SUCCESS in 2m 44s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/42/403742/2/check/gate-python-openstackclient-pep8-ubuntu-xenial/ce6aab0/ : SUCCESS in 2m 51s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/42/403742/2/check/gate-python-openstackclient-python27-ubuntu-xenial/dde7118/ : SUCCESS in 2m 38s\n- gate-python-openstackclient-python34 http://logs.openstack.org/42/403742/2/check/gate-python-openstackclient-python34/73cb115/ : SUCCESS in 4m 56s\n- gate-python-openstackclient-python35-nv http://logs.openstack.org/42/403742/2/check/gate-python-openstackclient-python35-nv/ece4da7/ : SUCCESS in 2m 40s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/42/403742/2/check/gate-tempest-dsvm-neutron-src-python-openstackclient/324bcc3/ : SUCCESS in 45m 46s\n- check-osc-plugins http://logs.openstack.org/42/403742/2/check/check-osc-plugins/35ad375/ : SUCCESS in 3m 56s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/42/403742/2/check/gate-osc-dsvm-functional/2ba85f6/ : SUCCESS in 27m 56s\n- gate-tripleo-ci-centos-7-nonha-multinode-nv http://logs.openstack.org/42/403742/2/check/gate-tripleo-ci-centos-7-nonha-multinode-nv/bf5656b/ : SUCCESS in 1h 11m 08s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"191b859c48d2f3ee3dee280fae85cae77b07cabf","author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"date":"2016-12-05 09:56:32.000000000","message":"Patch Set 2:\n\nOops, thought I\u0027d already done that, thanks for fixing it","accounts_in_message":[],"_revision_number":2},{"id":"bd53f9cb14e7f179a3000dcee227e42e59ea3f36","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2016-12-08 16:26:24.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"86ad9a9ac4994cf7c0a00a885898bad1fa2e739d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-12-08 16:26:34.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"e91ad342c06fc8e0cb7a01b1ff2f74c6b17d71f0","date":"2016-12-08 17:40:38.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"ac1dc4e5570d1c64c18dc752566ecd64d2f731d7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-12-08 17:40:38.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/42/403742/2/gate/gate-python-openstackclient-docs-ubuntu-xenial/2cc6296//doc/build/html/ : SUCCESS in 3m 05s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/42/403742/2/gate/gate-python-openstackclient-pep8-ubuntu-xenial/dd31d52/ : SUCCESS in 3m 12s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/42/403742/2/gate/gate-python-openstackclient-python27-ubuntu-xenial/5c32c02/ : SUCCESS in 3m 50s\n- gate-python-openstackclient-python34 http://logs.openstack.org/42/403742/2/gate/gate-python-openstackclient-python34/2d67146/ : SUCCESS in 2m 49s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial http://logs.openstack.org/42/403742/2/gate/gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial/e9bf616/ : SUCCESS in 1h 13m 25s\n- gate-osc-dsvm-functional-ubuntu-xenial http://logs.openstack.org/42/403742/2/gate/gate-osc-dsvm-functional-ubuntu-xenial/7df6d7b/ : SUCCESS in 46m 18s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"5203cc970762953e72d4745452d6ed5a2283ad9f","revisions":{"cc67c11b91ae36702b8b2fe5151278499fab6592":{"kind":"REWORK","_number":1,"created":"2016-11-28 14:47:38.000000000","uploader":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"ref":"refs/changes/42/403742/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/42/403742/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/42/403742/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/42/403742/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/42/403742/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/42/403742/1"}}},"commit":{"parents":[{"commit":"b12782726f61a3e50278f2271e0cc254df32ce54","subject":"Merge \"Add QoS support to Network object.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/b12782726f61a3e50278f2271e0cc254df32ce54"}]}],"author":{"name":"Colleen Murphy","email":"colleen@gazlene.net","date":"2016-11-28 14:37:14.000000000","tz":60},"committer":{"name":"Colleen Murphy","email":"colleen@gazlene.net","date":"2016-11-28 14:47:32.000000000","tz":60},"subject":"Remove auth_with_unscoped_saml decorator","message":"Remove auth_with_unscoped_saml decorator\n\nThe auth_with_unscoped_saml decorator existed to make sure the user\nselected the right auth plugin before trying to call either a\n\u0027federation domain\u0027 or \u0027federation project\u0027 command. This is outdated,\nbecause openstackclient now uses keystoneauth[1] and keystoneauth\nremoved its entrypoints for the federation plugins[2] since its\n_Rescoped class no longer needs them. This patch removes the decorator\nsince that validation check was the only thing standing in the way of\nthe commands working correctly. Also removed the \u0027*_list_wrong_auth\u0027\ntests since those only existed to test the decorator, and stopped\nsetting the plugin in the positive tests since the\nautomatically-determined token plugin should now be fine.\n\n[1] http://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id\u003d6ae0d2e8a54fd5139e63a990ab4bdce634e73c5e\n[2] http://git.openstack.org/cgit/openstack/keystoneauth/commit/?id\u003dd9e4d26bb86f8d48e43188b88bab9d7fe778d2c1\n\nChange-Id: Id981739663113447a7bba8ddba81ba9394a19e07\nCloses-bug: #1624115\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/cc67c11b91ae36702b8b2fe5151278499fab6592"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/cc67c11b91ae36702b8b2fe5151278499fab6592"}]},"branch":"refs/heads/master"},"5203cc970762953e72d4745452d6ed5a2283ad9f":{"kind":"REWORK","_number":2,"created":"2016-12-04 18:59:10.000000000","uploader":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"ref":"refs/changes/42/403742/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/42/403742/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/42/403742/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/42/403742/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/42/403742/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/42/403742/2"}}},"commit":{"parents":[{"commit":"b12782726f61a3e50278f2271e0cc254df32ce54","subject":"Merge \"Add QoS support to Network object.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/b12782726f61a3e50278f2271e0cc254df32ce54"}]}],"author":{"name":"Colleen Murphy","email":"colleen@gazlene.net","date":"2016-11-28 14:37:14.000000000","tz":60},"committer":{"name":"Steve Martinelli","email":"s.martinelli@gmail.com","date":"2016-12-04 18:59:09.000000000","tz":0},"subject":"Remove auth_with_unscoped_saml decorator","message":"Remove auth_with_unscoped_saml decorator\n\nThe auth_with_unscoped_saml decorator existed to make sure the user\nselected the right auth plugin before trying to call either a\n\u0027federation domain\u0027 or \u0027federation project\u0027 command. This is outdated,\nbecause openstackclient now uses keystoneauth[1] and keystoneauth\nremoved its entrypoints for the federation plugins[2] since its\n_Rescoped class no longer needs them. This patch removes the decorator\nsince that validation check was the only thing standing in the way of\nthe commands working correctly. Also removed the \u0027*_list_wrong_auth\u0027\ntests since those only existed to test the decorator, and stopped\nsetting the plugin in the positive tests since the\nautomatically-determined token plugin should now be fine.\n\n[1] http://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id\u003d6ae0d2e8a54fd5139e63a990ab4bdce634e73c5e\n[2] http://git.openstack.org/cgit/openstack/keystoneauth/commit/?id\u003dd9e4d26bb86f8d48e43188b88bab9d7fe778d2c1\n\nChange-Id: Id981739663113447a7bba8ddba81ba9394a19e07\nCloses-bug: #1624115\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/5203cc970762953e72d4745452d6ed5a2283ad9f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/5203cc970762953e72d4745452d6ed5a2283ad9f"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}