)]}'
{"id":"openstack%2Fpython-openstackclient~404765","triplet_id":"openstack%2Fpython-openstackclient~master~I745e997b26dabfda75fb4c52a5ee97d351224144","project":"openstack/python-openstackclient","branch":"master","topic":"bp/cinder-command-support","hashtags":[],"change_id":"I745e997b26dabfda75fb4c52a5ee97d351224144","subject":"Add \"replication-promote\" and \"replication-reenable\" options to \"volume set\"","status":"ABANDONED","created":"2016-11-30 13:16:33.000000000","updated":"2016-12-13 02:15:20.000000000","total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"9f4d8f744717782cdb8793be233c5e941309f0d9","_number":404765,"virtual_id_number":404765,"owner":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"date":"2016-12-12 19:28:32.000000000","_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"date":"2016-12-03 04:21:30.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":1,"date":"2016-12-03 02:55:11.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2016-12-13 02:15:07.000000000","_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-12-03 02:55:11.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2016-12-03 04:21:30.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2016-12-12 19:28:32.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"}],"messages":[{"id":"6ec570a0d4d5d5d7e6e23d4cb3e7b5408d9309bf","author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"date":"2016-11-30 13:16:33.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"639b86be76c03c23bb0cfae4e8a76eaffeaf582b","author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"date":"2016-11-30 13:19:43.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"8ca5d8b8b22a47c6d1b0ad50f115da692cc73e85","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-30 14:13:03.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/65/404765/2/check/gate-python-openstackclient-docs-ubuntu-xenial/4df6d78//doc/build/html/ : SUCCESS in 3m 23s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/65/404765/2/check/gate-python-openstackclient-pep8-ubuntu-xenial/6dcffc1/ : SUCCESS in 2m 56s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/65/404765/2/check/gate-python-openstackclient-python27-ubuntu-xenial/76afddb/ : SUCCESS in 3m 21s\n- gate-python-openstackclient-python34 http://logs.openstack.org/65/404765/2/check/gate-python-openstackclient-python34/26328ec/ : SUCCESS in 5m 23s\n- gate-python-openstackclient-python35-nv http://logs.openstack.org/65/404765/2/check/gate-python-openstackclient-python35-nv/8e4c442/ : SUCCESS in 2m 47s (non-voting)\n- gate-python-openstackclient-releasenotes http://docs-draft.openstack.org/65/404765/2/check/gate-python-openstackclient-releasenotes/fd71bcf//releasenotes/build/html/ : SUCCESS in 6m 53s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/65/404765/2/check/gate-tempest-dsvm-neutron-src-python-openstackclient/7895b28/ : SUCCESS in 53m 07s\n- check-osc-plugins http://logs.openstack.org/65/404765/2/check/check-osc-plugins/42b28a8/ : SUCCESS in 4m 20s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/65/404765/2/check/gate-osc-dsvm-functional/cab7370/ : SUCCESS in 15m 54s\n- gate-tripleo-ci-centos-7-nonha-multinode-nv http://logs.openstack.org/65/404765/2/check/gate-tripleo-ci-centos-7-nonha-multinode-nv/342252d/ : SUCCESS in 51m 50s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"93b8907535f4ab6d66039d2f28004671381778b0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-12-02 18:51:38.000000000","message":"Patch Set 2: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":2},{"id":"4319a7060a6412e449e684e459ae2d6b2eef8e72","author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"date":"2016-12-03 01:42:06.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"c8a4fcf5e2c7d83e89aafdeaf12b6e6e9a6f10ab","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-12-03 02:55:11.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/65/404765/3/check/gate-python-openstackclient-docs-ubuntu-xenial/b32e9bf//doc/build/html/ : SUCCESS in 2m 56s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/65/404765/3/check/gate-python-openstackclient-pep8-ubuntu-xenial/2161a7a/ : SUCCESS in 5m 03s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/65/404765/3/check/gate-python-openstackclient-python27-ubuntu-xenial/202edac/ : SUCCESS in 2m 39s\n- gate-python-openstackclient-python34 http://logs.openstack.org/65/404765/3/check/gate-python-openstackclient-python34/a552715/ : SUCCESS in 2m 54s\n- gate-python-openstackclient-python35-nv http://logs.openstack.org/65/404765/3/check/gate-python-openstackclient-python35-nv/a064c55/ : SUCCESS in 3m 12s (non-voting)\n- gate-python-openstackclient-releasenotes http://docs-draft.openstack.org/65/404765/3/check/gate-python-openstackclient-releasenotes/66fc1b4//releasenotes/build/html/ : SUCCESS in 3m 04s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/65/404765/3/check/gate-tempest-dsvm-neutron-src-python-openstackclient/81a5094/ : SUCCESS in 1h 10m 42s\n- check-osc-plugins http://logs.openstack.org/65/404765/3/check/check-osc-plugins/262950c/ : SUCCESS in 3m 32s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/65/404765/3/check/gate-osc-dsvm-functional/39f92f0/ : SUCCESS in 16m 00s\n- gate-tripleo-ci-centos-7-nonha-multinode-nv http://logs.openstack.org/65/404765/3/check/gate-tripleo-ci-centos-7-nonha-multinode-nv/1f32589/ : SUCCESS in 1h 12m 53s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"eb062deecf8a781f8241d773efeb63b2d68b1e41","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-12-03 04:21:30.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"3b4acb5c5c68f85c941ea9a5ea6b4ece976be7d0","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2016-12-12 19:28:32.000000000","message":"Patch Set 3:\n\nUnfortunately these are leftover remnants of our \"v1\" replication implementation. That was only ever done by one vendor, and once others tried to implement support we realized it would not work for all. We\u0027ve since reimplemented replication support and these actions are no longer valid. It would be better not to implement these is OSC to avoid confusion. No current Cinder drivers support the v1 implementation anymore anyway.","accounts_in_message":[],"_revision_number":3},{"id":"92758f478fe5770de846d27db4b8f1e80181fbda","author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"date":"2016-12-13 02:15:07.000000000","message":"Patch Set 3:\n\n\u003e Unfortunately these are leftover remnants of our \"v1\" replication\n \u003e implementation. That was only ever done by one vendor, and once\n \u003e others tried to implement support we realized it would not work for\n \u003e all. We\u0027ve since reimplemented replication support and these\n \u003e actions are no longer valid. It would be better not to implement\n \u003e these is OSC to avoid confusion. No current Cinder drivers support\n \u003e the v1 implementation anymore anyway.\n\nHi, Sean McGinnis, Thank you for reviewing, as you said seems like this is not worth implementing in OSC now, I will abandon it, Thank you :)","accounts_in_message":[],"_revision_number":3},{"id":"9b7713c50b3e6f80112522880ef16189a28ba836","author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"date":"2016-12-13 02:15:20.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"f2d7b9bf58ba9a8b320f766a43edea9a50be39f0","revisions":{"93ebe3729484649475e32ffbbe8bd86552484c2a":{"kind":"REWORK","_number":1,"created":"2016-11-30 13:16:33.000000000","uploader":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"ref":"refs/changes/65/404765/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/65/404765/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/65/404765/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/65/404765/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/65/404765/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/65/404765/1"}}},"commit":{"parents":[{"commit":"d6e058fa1f6323ef73354f0aea0e09efb647bc7e","subject":"Merge \"Add network service provider list to OSC\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/d6e058fa1f6323ef73354f0aea0e09efb647bc7e"}]}],"author":{"name":"Huanxuan Ao","email":"huanxuan.ao@easystack.cn","date":"2016-11-30 05:05:22.000000000","tz":480},"committer":{"name":"Huanxuan Ao","email":"huanxuan.ao@easystack.cn","date":"2016-11-30 13:12:14.000000000","tz":480},"subject":"Add \"replication-promote\" and \"replication-reenable\" options to \"volume set\"","message":"Add \"replication-promote\" and \"replication-reenable\" options to \"volume set\"\n\nImplement the cinder commands:\n\"cinder replication-promote\"\n\"cinder replication-reenable\"\nas options \"--replication-promote\" and \"--replication-reenable\"\nof \"volume set\" command in OSC (volume v2 only)\n\nChange-Id: I745e997b26dabfda75fb4c52a5ee97d351224144\nCloses-Bug: #1645559\nImplements: bp cinder-command-support\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/93ebe3729484649475e32ffbbe8bd86552484c2a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/93ebe3729484649475e32ffbbe8bd86552484c2a"}]},"branch":"refs/heads/master"},"fec1c24f2bbf521c3b7e28c219350e6554456717":{"kind":"REWORK","_number":2,"created":"2016-11-30 13:19:43.000000000","uploader":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"ref":"refs/changes/65/404765/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/65/404765/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/65/404765/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/65/404765/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/65/404765/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/65/404765/2"}}},"commit":{"parents":[{"commit":"d6e058fa1f6323ef73354f0aea0e09efb647bc7e","subject":"Merge \"Add network service provider list to OSC\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/d6e058fa1f6323ef73354f0aea0e09efb647bc7e"}]}],"author":{"name":"Huanxuan Ao","email":"huanxuan.ao@easystack.cn","date":"2016-11-30 05:05:22.000000000","tz":480},"committer":{"name":"Huanxuan Ao","email":"huanxuan.ao@easystack.cn","date":"2016-11-30 13:17:44.000000000","tz":480},"subject":"Add \"replication-promote\" and \"replication-reenable\" options to \"volume set\"","message":"Add \"replication-promote\" and \"replication-reenable\" options to \"volume set\"\n\nImplement the cinder commands:\n\"cinder replication-promote\"\n\"cinder replication-reenable\"\nas options \"--replication-promote\" and \"--replication-reenable\"\nof \"volume set\" command in OSC (volume v2 only)\n\nChange-Id: I745e997b26dabfda75fb4c52a5ee97d351224144\nCloses-Bug: #1645559\nImplements: bp cinder-command-support\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/fec1c24f2bbf521c3b7e28c219350e6554456717"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/fec1c24f2bbf521c3b7e28c219350e6554456717"}]},"branch":"refs/heads/master"},"f2d7b9bf58ba9a8b320f766a43edea9a50be39f0":{"kind":"REWORK","_number":3,"created":"2016-12-03 01:42:06.000000000","uploader":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"ref":"refs/changes/65/404765/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/65/404765/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/65/404765/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/65/404765/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/65/404765/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/65/404765/3"}}},"commit":{"parents":[{"commit":"2fd5ca22f642591e861d3615040feb534479b013","subject":"Merge \"Add \"consistency group show\" command\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/2fd5ca22f642591e861d3615040feb534479b013"}]}],"author":{"name":"Huanxuan Ao","email":"huanxuan.ao@easystack.cn","date":"2016-11-30 05:05:22.000000000","tz":480},"committer":{"name":"Huanxuan Ao","email":"huanxuan.ao@easystack.cn","date":"2016-12-03 01:41:03.000000000","tz":480},"subject":"Add \"replication-promote\" and \"replication-reenable\" options to \"volume set\"","message":"Add \"replication-promote\" and \"replication-reenable\" options to \"volume set\"\n\nImplement the cinder commands:\n\"cinder replication-promote\"\n\"cinder replication-reenable\"\nas options \"--replication-promote\" and \"--replication-reenable\"\nof \"volume set\" command in OSC (volume v2 only)\n\nChange-Id: I745e997b26dabfda75fb4c52a5ee97d351224144\nCloses-Bug: #1645559\nImplements: bp cinder-command-support\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/f2d7b9bf58ba9a8b320f766a43edea9a50be39f0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/f2d7b9bf58ba9a8b320f766a43edea9a50be39f0"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}