)]}'
{"openstackclient/network/v2/network.py":[{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"85bf19dcf4915d9713abab45028d7eabbd487e02","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"def _get_network_columns(item):"},{"line_number":43,"context_line":"    column_map \u003d {"},{"line_number":44,"context_line":"        \u0027tenant_id\u0027: \u0027project_id\u0027,"},{"line_number":45,"context_line":"    }"},{"line_number":46,"context_line":"    return sdk_utils.get_osc_show_columns_for_sdk_resource(item, column_map)"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_d648a0b5","line":44,"updated":"2016-12-06 20:38:50.000000000","message":"please add other unmapped items here as well:for eg: ipv4_address_scope_id to ipv4_address_scope, is_admin_state_up to admin_state_up .. etc\n\nYou can find those mappings here -\u003e https://github.com/openstack/python-openstacksdk/blob/master/openstack/network/v2/network.py","commit_id":"3b524e4d289364c145b1888e22eaa1c2a8fad909"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"e21dcb73c10e2399998b4fb6a8f33ab763c4dbc1","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    return \u0027External\u0027 if item else \u0027Internal\u0027"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"_formatters \u003d {"},{"line_number":34,"context_line":"    \u0027subnets\u0027: utils.format_list,"},{"line_number":35,"context_line":"    \u0027admin_state_up\u0027: _format_admin_state,"},{"line_number":36,"context_line":"    \u0027router:external\u0027: _format_router_external,"},{"line_number":37,"context_line":"    \u0027availability_zones\u0027: utils.format_list,"},{"line_number":38,"context_line":"    \u0027availability_zone_hints\u0027: utils.format_list,"},{"line_number":39,"context_line":"}"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"def _get_network_columns(item):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_29dceb45","line":39,"range":{"start_line":33,"start_character":0,"end_line":39,"end_character":1},"updated":"2016-12-07 17:09:44.000000000","message":"Please see the etherpad for the changes required here too.","commit_id":"fc2a808b3ec20773131dcab44913d1c662ce1ca7"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"e21dcb73c10e2399998b4fb6a8f33ab763c4dbc1","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"def _get_network_columns(item):"},{"line_number":43,"context_line":"    column_map \u003d {"},{"line_number":44,"context_line":"        \u0027subnet_ids\u0027: \u0027subnets\u0027,"},{"line_number":45,"context_line":"        \u0027is_router_external\u0027: \u0027router:external\u0027,"},{"line_number":46,"context_line":"        \u0027is_port_security_enabled\u0027: \u0027port_security_enabled\u0027,"},{"line_number":47,"context_line":"        \u0027is_admin_state_up\u0027: \u0027admin_state_up\u0027,"},{"line_number":48,"context_line":"        \u0027is_shared\u0027: \u0027shared\u0027,"},{"line_number":49,"context_line":"        \u0027tenant_id\u0027: \u0027project_id\u0027,"},{"line_number":50,"context_line":"    }"},{"line_number":51,"context_line":"    return sdk_utils.get_osc_show_columns_for_sdk_resource(item, column_map)"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_e903d3bc","line":49,"range":{"start_line":44,"start_character":0,"end_line":49,"end_character":34},"updated":"2016-12-07 17:09:44.000000000","message":"There are other mappings missing.","commit_id":"fc2a808b3ec20773131dcab44913d1c662ce1ca7"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"e21dcb73c10e2399998b4fb6a8f33ab763c4dbc1","unresolved":false,"context_lines":[{"line_number":422,"context_line":"                \u0027name\u0027,"},{"line_number":423,"context_line":"                \u0027status\u0027,"},{"line_number":424,"context_line":"                \u0027project_id\u0027,"},{"line_number":425,"context_line":"                \u0027admin_state_up\u0027,"},{"line_number":426,"context_line":"                \u0027shared\u0027,"},{"line_number":427,"context_line":"                \u0027subnets\u0027,"},{"line_number":428,"context_line":"                \u0027provider_network_type\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_29c94bad","line":425,"updated":"2016-12-07 17:09:44.000000000","message":"is_admin_state_up","commit_id":"fc2a808b3ec20773131dcab44913d1c662ce1ca7"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"e21dcb73c10e2399998b4fb6a8f33ab763c4dbc1","unresolved":false,"context_lines":[{"line_number":423,"context_line":"                \u0027status\u0027,"},{"line_number":424,"context_line":"                \u0027project_id\u0027,"},{"line_number":425,"context_line":"                \u0027admin_state_up\u0027,"},{"line_number":426,"context_line":"                \u0027shared\u0027,"},{"line_number":427,"context_line":"                \u0027subnets\u0027,"},{"line_number":428,"context_line":"                \u0027provider_network_type\u0027,"},{"line_number":429,"context_line":"                \u0027router:external\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_89c09f7e","line":426,"updated":"2016-12-07 17:09:44.000000000","message":"is_shared","commit_id":"fc2a808b3ec20773131dcab44913d1c662ce1ca7"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"e21dcb73c10e2399998b4fb6a8f33ab763c4dbc1","unresolved":false,"context_lines":[{"line_number":424,"context_line":"                \u0027project_id\u0027,"},{"line_number":425,"context_line":"                \u0027admin_state_up\u0027,"},{"line_number":426,"context_line":"                \u0027shared\u0027,"},{"line_number":427,"context_line":"                \u0027subnets\u0027,"},{"line_number":428,"context_line":"                \u0027provider_network_type\u0027,"},{"line_number":429,"context_line":"                \u0027router:external\u0027,"},{"line_number":430,"context_line":"                \u0027availability_zones\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_c9ba970a","line":427,"updated":"2016-12-07 17:09:44.000000000","message":"subnet_ids","commit_id":"fc2a808b3ec20773131dcab44913d1c662ce1ca7"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"e21dcb73c10e2399998b4fb6a8f33ab763c4dbc1","unresolved":false,"context_lines":[{"line_number":426,"context_line":"                \u0027shared\u0027,"},{"line_number":427,"context_line":"                \u0027subnets\u0027,"},{"line_number":428,"context_line":"                \u0027provider_network_type\u0027,"},{"line_number":429,"context_line":"                \u0027router:external\u0027,"},{"line_number":430,"context_line":"                \u0027availability_zones\u0027,"},{"line_number":431,"context_line":"            )"},{"line_number":432,"context_line":"            column_headers \u003d ("}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_4945a715","line":429,"updated":"2016-12-07 17:09:44.000000000","message":"is_router_external","commit_id":"fc2a808b3ec20773131dcab44913d1c662ce1ca7"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"e21dcb73c10e2399998b4fb6a8f33ab763c4dbc1","unresolved":false,"context_lines":[{"line_number":445,"context_line":"            columns \u003d ("},{"line_number":446,"context_line":"                \u0027id\u0027,"},{"line_number":447,"context_line":"                \u0027name\u0027,"},{"line_number":448,"context_line":"                \u0027subnets\u0027"},{"line_number":449,"context_line":"            )"},{"line_number":450,"context_line":"            column_headers \u003d ("},{"line_number":451,"context_line":"                \u0027ID\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_a9547bca","line":448,"updated":"2016-12-07 17:09:44.000000000","message":"subnet_ids","commit_id":"fc2a808b3ec20773131dcab44913d1c662ce1ca7"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"e21dcb73c10e2399998b4fb6a8f33ab763c4dbc1","unresolved":false,"context_lines":[{"line_number":455,"context_line":""},{"line_number":456,"context_line":"        args \u003d {}"},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"        if parsed_args.external:"},{"line_number":459,"context_line":"            args[\u0027router:external\u0027] \u003d True"},{"line_number":460,"context_line":"        elif parsed_args.internal:"},{"line_number":461,"context_line":"            args[\u0027router:external\u0027] \u003d False"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"        if parsed_args.name is not None:"},{"line_number":464,"context_line":"            args[\u0027name\u0027] \u003d parsed_args.name"},{"line_number":465,"context_line":""},{"line_number":466,"context_line":"        if parsed_args.enable:"},{"line_number":467,"context_line":"            args[\u0027admin_state_up\u0027] \u003d True"},{"line_number":468,"context_line":"        elif parsed_args.disable:"},{"line_number":469,"context_line":"            args[\u0027admin_state_up\u0027] \u003d False"},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"        if parsed_args.project:"},{"line_number":472,"context_line":"            project \u003d identity_common.find_project("},{"line_number":473,"context_line":"                identity_client,"},{"line_number":474,"context_line":"                parsed_args.project,"},{"line_number":475,"context_line":"                parsed_args.project_domain,"},{"line_number":476,"context_line":"            )"},{"line_number":477,"context_line":"            args[\u0027tenant_id\u0027] \u003d project.id"},{"line_number":478,"context_line":""},{"line_number":479,"context_line":"        if parsed_args.share:"},{"line_number":480,"context_line":"            args[\u0027shared\u0027] \u003d True"},{"line_number":481,"context_line":"        elif parsed_args.no_share:"},{"line_number":482,"context_line":"            args[\u0027shared\u0027] \u003d False"},{"line_number":483,"context_line":""},{"line_number":484,"context_line":"        if parsed_args.status:"},{"line_number":485,"context_line":"            args[\u0027status\u0027] \u003d parsed_args.status"},{"line_number":486,"context_line":""},{"line_number":487,"context_line":"        if parsed_args.provider_network_type:"},{"line_number":488,"context_line":"            args[\u0027provider:network_type\u0027] \u003d parsed_args.provider_network_type"},{"line_number":489,"context_line":"        if parsed_args.physical_network:"},{"line_number":490,"context_line":"            args[\u0027provider:physical_network\u0027] \u003d parsed_args.physical_network"},{"line_number":491,"context_line":"        if parsed_args.segmentation_id:"},{"line_number":492,"context_line":"            args[\u0027provider:segmentation_id\u0027] \u003d parsed_args.segmentation_id"},{"line_number":493,"context_line":""},{"line_number":494,"context_line":"        data \u003d client.networks(**args)"},{"line_number":495,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_49804747","line":492,"range":{"start_line":458,"start_character":0,"end_line":492,"end_character":74},"updated":"2016-12-07 17:09:44.000000000","message":"Please review the etherpad to handle these filters properly.","commit_id":"fc2a808b3ec20773131dcab44913d1c662ce1ca7"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"455a678292e4b889b8fba48b546e8b1d5a020d25","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    columns \u003d list(item.keys())"},{"line_number":43,"context_line":"    if \u0027tenant_id\u0027 in columns:"},{"line_number":44,"context_line":"        columns.remove(\u0027tenant_id\u0027)"},{"line_number":45,"context_line":"    if \u0027project_id\u0027 not in columns:"},{"line_number":46,"context_line":"        columns.append(\u0027project_id\u0027)"},{"line_number":47,"context_line":"    return tuple(sorted(columns))"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_abafab92","side":"PARENT","line":45,"updated":"2016-12-14 16:04:54.000000000","message":"Why is this changed?","commit_id":"158dbe124a11873129d2b3fbc6a9b5a6695e7bcc"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"f56d61bf694f259cc47bf111c17da4a2d86f63de","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    columns \u003d list(item.keys())"},{"line_number":43,"context_line":"    if \u0027tenant_id\u0027 in columns:"},{"line_number":44,"context_line":"        columns.remove(\u0027tenant_id\u0027)"},{"line_number":45,"context_line":"    if \u0027project_id\u0027 not in columns:"},{"line_number":46,"context_line":"        columns.append(\u0027project_id\u0027)"},{"line_number":47,"context_line":"    return tuple(sorted(columns))"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_26f9124e","side":"PARENT","line":45,"in_reply_to":"1a6eadb0_abafab92","updated":"2016-12-14 17:54:00.000000000","message":"By mistake. Corrected.","commit_id":"158dbe124a11873129d2b3fbc6a9b5a6695e7bcc"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"455a678292e4b889b8fba48b546e8b1d5a020d25","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"def _get_network_columns(item):"},{"line_number":46,"context_line":"    column_map \u003d {"},{"line_number":47,"context_line":"        \u0027subnet_ids\u0027: \u0027subnets\u0027,"},{"line_number":48,"context_line":"        \u0027is_admin_state_up\u0027: \u0027admin_state_up\u0027,"},{"line_number":49,"context_line":"        \u0027is_router_external\u0027: \u0027router:external\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_2bc55b5a","line":46,"updated":"2016-12-14 16:04:54.000000000","message":"This is missing ipv4_address_scope and ipv6_address_scope","commit_id":"8e0b09222aa9bc29104bb417d052e2549c6a5ce1"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"f56d61bf694f259cc47bf111c17da4a2d86f63de","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"def _get_network_columns(item):"},{"line_number":46,"context_line":"    column_map \u003d {"},{"line_number":47,"context_line":"        \u0027subnet_ids\u0027: \u0027subnets\u0027,"},{"line_number":48,"context_line":"        \u0027is_admin_state_up\u0027: \u0027admin_state_up\u0027,"},{"line_number":49,"context_line":"        \u0027is_router_external\u0027: \u0027router:external\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_26a75250","line":46,"in_reply_to":"1a6eadb0_2bc55b5a","updated":"2016-12-14 17:54:00.000000000","message":"Yes, Will add it in the following patches.","commit_id":"8e0b09222aa9bc29104bb417d052e2549c6a5ce1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"455a678292e4b889b8fba48b546e8b1d5a020d25","unresolved":false,"context_lines":[{"line_number":466,"context_line":"            args[\u0027is_router_external\u0027] \u003d True"},{"line_number":467,"context_line":"        elif parsed_args.internal:"},{"line_number":468,"context_line":"            args[\u0027router:external\u0027] \u003d False"},{"line_number":469,"context_line":"            args[\u0027is_router_external\u0027] \u003d False"},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"        if parsed_args.name is not None:"},{"line_number":472,"context_line":"            args[\u0027name\u0027] \u003d parsed_args.name"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_ab9deb5a","line":469,"updated":"2016-12-14 16:04:54.000000000","message":"It appears the you need to update the SDK to support this query.","commit_id":"8e0b09222aa9bc29104bb417d052e2549c6a5ce1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"83a652d8c032614ec904e9f61c3c8a18f8106fe1","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"def _get_network_columns(item):"},{"line_number":46,"context_line":"    column_map \u003d {"},{"line_number":47,"context_line":"        \u0027subnet_ids\u0027: \u0027subnets\u0027,"},{"line_number":48,"context_line":"        \u0027is_admin_state_up\u0027: \u0027admin_state_up\u0027,"},{"line_number":49,"context_line":"        \u0027is_router_external\u0027: \u0027router:external\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6eadb0_1feff087","line":46,"updated":"2016-12-14 18:38:03.000000000","message":"This is missing ipv4_address_scope and ipv6_address_scope","commit_id":"baf1122fd3f9918b289eddd028b03e4e800aa19d"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"e00569495cbe2f63d569b28a4092da7c47a4da5b","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"def _get_network_columns(item):"},{"line_number":46,"context_line":"    column_map \u003d {"},{"line_number":47,"context_line":"        \u0027subnet_ids\u0027: \u0027subnets\u0027,"},{"line_number":48,"context_line":"        \u0027is_admin_state_up\u0027: \u0027admin_state_up\u0027,"},{"line_number":49,"context_line":"        \u0027is_router_external\u0027: \u0027router:external\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6eadb0_7ae0c496","line":46,"in_reply_to":"1a6eadb0_1feff087","updated":"2016-12-15 15:02:09.000000000","message":"Done","commit_id":"baf1122fd3f9918b289eddd028b03e4e800aa19d"}],"openstackclient/tests/unit/network/v2/fakes.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"455a678292e4b889b8fba48b546e8b1d5a020d25","unresolved":false,"context_lines":[{"line_number":308,"context_line":"        network \u003d fakes.FakeResource(info\u003dcopy.deepcopy(network_attrs),"},{"line_number":309,"context_line":"                                     loaded\u003dTrue)"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"        # Set attributes with special mapping in OpenStack SDK."},{"line_number":312,"context_line":"        network.project_id \u003d network_attrs[\u0027tenant_id\u0027]"},{"line_number":313,"context_line":"        network.is_router_external \u003d network_attrs[\u0027router:external\u0027]"},{"line_number":314,"context_line":"        network.is_admin_state_up \u003d network_attrs[\u0027admin_state_up\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_0bc6df47","line":311,"updated":"2016-12-14 16:04:54.000000000","message":"Please include all of the mappings.","commit_id":"8e0b09222aa9bc29104bb417d052e2549c6a5ce1"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"f56d61bf694f259cc47bf111c17da4a2d86f63de","unresolved":false,"context_lines":[{"line_number":308,"context_line":"        network \u003d fakes.FakeResource(info\u003dcopy.deepcopy(network_attrs),"},{"line_number":309,"context_line":"                                     loaded\u003dTrue)"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"        # Set attributes with special mapping in OpenStack SDK."},{"line_number":312,"context_line":"        network.project_id \u003d network_attrs[\u0027tenant_id\u0027]"},{"line_number":313,"context_line":"        network.is_router_external \u003d network_attrs[\u0027router:external\u0027]"},{"line_number":314,"context_line":"        network.is_admin_state_up \u003d network_attrs[\u0027admin_state_up\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_3a7a02f2","line":311,"in_reply_to":"1a6eadb0_0bc6df47","updated":"2016-12-14 17:54:00.000000000","message":"network_attrs already has the mapped attributes. do we still need to add it explicitly?","commit_id":"8e0b09222aa9bc29104bb417d052e2549c6a5ce1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"e8b0cb44471e01c7ff0d6ee66e65919aba4215d3","unresolved":false,"context_lines":[{"line_number":308,"context_line":"        network \u003d fakes.FakeResource(info\u003dcopy.deepcopy(network_attrs),"},{"line_number":309,"context_line":"                                     loaded\u003dTrue)"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"        # Set attributes with special mapping in OpenStack SDK."},{"line_number":312,"context_line":"        network.project_id \u003d network_attrs[\u0027tenant_id\u0027]"},{"line_number":313,"context_line":"        network.is_router_external \u003d network_attrs[\u0027router:external\u0027]"},{"line_number":314,"context_line":"        network.is_admin_state_up \u003d network_attrs[\u0027admin_state_up\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_4409a1dc","line":311,"in_reply_to":"1a6eadb0_3a7a02f2","updated":"2016-12-14 18:09:39.000000000","message":"okay, that explains why the test cases had to change.  I think we should fix network_attrs and add the properties.","commit_id":"8e0b09222aa9bc29104bb417d052e2549c6a5ce1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"83a652d8c032614ec904e9f61c3c8a18f8106fe1","unresolved":false,"context_lines":[{"line_number":308,"context_line":"        network \u003d fakes.FakeResource(info\u003dcopy.deepcopy(network_attrs),"},{"line_number":309,"context_line":"                                     loaded\u003dTrue)"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"        # Set attributes with special mapping in OpenStack SDK."},{"line_number":312,"context_line":"        network.project_id \u003d network_attrs[\u0027tenant_id\u0027]"},{"line_number":313,"context_line":"        network.is_router_external \u003d network_attrs[\u0027router:external\u0027]"},{"line_number":314,"context_line":"        network.is_admin_state_up \u003d network_attrs[\u0027admin_state_up\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6eadb0_bf50bc5f","line":311,"updated":"2016-12-14 18:38:03.000000000","message":"Fixing network_attrs and including all of the mappings should cleanup the unit tests.","commit_id":"baf1122fd3f9918b289eddd028b03e4e800aa19d"}],"openstackclient/tests/unit/network/v2/test_network.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"455a678292e4b889b8fba48b546e8b1d5a020d25","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        \u0027name\u0027,"},{"line_number":67,"context_line":"        \u0027port_security_enabled\u0027,"},{"line_number":68,"context_line":"        \u0027project_id\u0027,"},{"line_number":69,"context_line":"        \u0027provider:network_type\u0027,"},{"line_number":70,"context_line":"        \u0027provider:physical_network\u0027,"},{"line_number":71,"context_line":"        \u0027provider:segmentation_id\u0027,"},{"line_number":72,"context_line":"        \u0027qos_policy_id\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_ebf44388","line":69,"updated":"2016-12-14 16:04:54.000000000","message":"Something is wrong because the columns shouldn\u0027t change.","commit_id":"8e0b09222aa9bc29104bb417d052e2549c6a5ce1"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"93df124ef0d31dbfa7d6d95ade510220878e8551","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        \u0027name\u0027,"},{"line_number":67,"context_line":"        \u0027port_security_enabled\u0027,"},{"line_number":68,"context_line":"        \u0027project_id\u0027,"},{"line_number":69,"context_line":"        \u0027provider:network_type\u0027,"},{"line_number":70,"context_line":"        \u0027provider:physical_network\u0027,"},{"line_number":71,"context_line":"        \u0027provider:segmentation_id\u0027,"},{"line_number":72,"context_line":"        \u0027qos_policy_id\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_5a1ea8bb","line":69,"in_reply_to":"1a6eadb0_64277d64","updated":"2016-12-15 15:01:54.000000000","message":"Fixed the network_attrs, but it won\u0027t affect the columns as it only affects the data part. So this change is still required.","commit_id":"8e0b09222aa9bc29104bb417d052e2549c6a5ce1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"e8b0cb44471e01c7ff0d6ee66e65919aba4215d3","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        \u0027name\u0027,"},{"line_number":67,"context_line":"        \u0027port_security_enabled\u0027,"},{"line_number":68,"context_line":"        \u0027project_id\u0027,"},{"line_number":69,"context_line":"        \u0027provider:network_type\u0027,"},{"line_number":70,"context_line":"        \u0027provider:physical_network\u0027,"},{"line_number":71,"context_line":"        \u0027provider:segmentation_id\u0027,"},{"line_number":72,"context_line":"        \u0027qos_policy_id\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_64277d64","line":69,"in_reply_to":"1a6eadb0_d0080f30","updated":"2016-12-14 18:09:39.000000000","message":"See comment in fakes which will likely impact this.","commit_id":"8e0b09222aa9bc29104bb417d052e2549c6a5ce1"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"f56d61bf694f259cc47bf111c17da4a2d86f63de","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        \u0027name\u0027,"},{"line_number":67,"context_line":"        \u0027port_security_enabled\u0027,"},{"line_number":68,"context_line":"        \u0027project_id\u0027,"},{"line_number":69,"context_line":"        \u0027provider:network_type\u0027,"},{"line_number":70,"context_line":"        \u0027provider:physical_network\u0027,"},{"line_number":71,"context_line":"        \u0027provider:segmentation_id\u0027,"},{"line_number":72,"context_line":"        \u0027qos_policy_id\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_d0080f30","line":69,"in_reply_to":"1a6eadb0_ebf44388","updated":"2016-12-14 17:54:00.000000000","message":"In #L176, the columns returned from take_action contains provider:network_type. so it results in a mismatch error if this is not changed.","commit_id":"8e0b09222aa9bc29104bb417d052e2549c6a5ce1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"455a678292e4b889b8fba48b546e8b1d5a020d25","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        _network.id,"},{"line_number":85,"context_line":"        _network.is_default,"},{"line_number":86,"context_line":"        _network.name,"},{"line_number":87,"context_line":"        _network.port_security_enabled,"},{"line_number":88,"context_line":"        _network.project_id,"},{"line_number":89,"context_line":"        _network.provider_network_type,"},{"line_number":90,"context_line":"        _network.provider_physical_network,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_ab396b43","line":87,"updated":"2016-12-14 16:04:54.000000000","message":"This should be left as-is.","commit_id":"8e0b09222aa9bc29104bb417d052e2549c6a5ce1"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"f56d61bf694f259cc47bf111c17da4a2d86f63de","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        _network.id,"},{"line_number":85,"context_line":"        _network.is_default,"},{"line_number":86,"context_line":"        _network.name,"},{"line_number":87,"context_line":"        _network.port_security_enabled,"},{"line_number":88,"context_line":"        _network.project_id,"},{"line_number":89,"context_line":"        _network.provider_network_type,"},{"line_number":90,"context_line":"        _network.provider_physical_network,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_ddc66848","line":87,"in_reply_to":"1a6eadb0_ab396b43","updated":"2016-12-14 17:54:00.000000000","message":"correct. my bad.","commit_id":"8e0b09222aa9bc29104bb417d052e2549c6a5ce1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"455a678292e4b889b8fba48b546e8b1d5a020d25","unresolved":false,"context_lines":[{"line_number":240,"context_line":"        \u0027name\u0027,"},{"line_number":241,"context_line":"        \u0027port_security_enabled\u0027,"},{"line_number":242,"context_line":"        \u0027project_id\u0027,"},{"line_number":243,"context_line":"        \u0027provider:network_type\u0027,"},{"line_number":244,"context_line":"        \u0027provider:physical_network\u0027,"},{"line_number":245,"context_line":"        \u0027provider:segmentation_id\u0027,"},{"line_number":246,"context_line":"        \u0027qos_policy_id\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_eb3b6336","line":243,"updated":"2016-12-14 16:04:54.000000000","message":"Something is wrong because the columns shouldn\u0027t change.","commit_id":"8e0b09222aa9bc29104bb417d052e2549c6a5ce1"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"f56d61bf694f259cc47bf111c17da4a2d86f63de","unresolved":false,"context_lines":[{"line_number":240,"context_line":"        \u0027name\u0027,"},{"line_number":241,"context_line":"        \u0027port_security_enabled\u0027,"},{"line_number":242,"context_line":"        \u0027project_id\u0027,"},{"line_number":243,"context_line":"        \u0027provider:network_type\u0027,"},{"line_number":244,"context_line":"        \u0027provider:physical_network\u0027,"},{"line_number":245,"context_line":"        \u0027provider:segmentation_id\u0027,"},{"line_number":246,"context_line":"        \u0027qos_policy_id\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_d391f953","line":243,"in_reply_to":"1a6eadb0_eb3b6336","updated":"2016-12-14 17:54:00.000000000","message":"ditto","commit_id":"8e0b09222aa9bc29104bb417d052e2549c6a5ce1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"455a678292e4b889b8fba48b546e8b1d5a020d25","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        _network.id,"},{"line_number":259,"context_line":"        _network.is_default,"},{"line_number":260,"context_line":"        _network.name,"},{"line_number":261,"context_line":"        _network.port_security_enabled,"},{"line_number":262,"context_line":"        _network.project_id,"},{"line_number":263,"context_line":"        _network.provider_network_type,"},{"line_number":264,"context_line":"        _network.provider_physical_network,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_6b1673a8","line":261,"updated":"2016-12-14 16:04:54.000000000","message":"This should be left as-is.","commit_id":"8e0b09222aa9bc29104bb417d052e2549c6a5ce1"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"f56d61bf694f259cc47bf111c17da4a2d86f63de","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        _network.id,"},{"line_number":259,"context_line":"        _network.is_default,"},{"line_number":260,"context_line":"        _network.name,"},{"line_number":261,"context_line":"        _network.port_security_enabled,"},{"line_number":262,"context_line":"        _network.project_id,"},{"line_number":263,"context_line":"        _network.provider_network_type,"},{"line_number":264,"context_line":"        _network.provider_physical_network,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_fddc0414","line":261,"in_reply_to":"1a6eadb0_6b1673a8","updated":"2016-12-14 17:54:00.000000000","message":"Done","commit_id":"8e0b09222aa9bc29104bb417d052e2549c6a5ce1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"455a678292e4b889b8fba48b546e8b1d5a020d25","unresolved":false,"context_lines":[{"line_number":885,"context_line":"        \u0027name\u0027,"},{"line_number":886,"context_line":"        \u0027port_security_enabled\u0027,"},{"line_number":887,"context_line":"        \u0027project_id\u0027,"},{"line_number":888,"context_line":"        \u0027provider:network_type\u0027,"},{"line_number":889,"context_line":"        \u0027provider:physical_network\u0027,"},{"line_number":890,"context_line":"        \u0027provider:segmentation_id\u0027,"},{"line_number":891,"context_line":"        \u0027qos_policy_id\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_ab108ba9","line":888,"updated":"2016-12-14 16:04:54.000000000","message":"Something is wrong because the columns shouldn\u0027t change.","commit_id":"8e0b09222aa9bc29104bb417d052e2549c6a5ce1"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"f56d61bf694f259cc47bf111c17da4a2d86f63de","unresolved":false,"context_lines":[{"line_number":885,"context_line":"        \u0027name\u0027,"},{"line_number":886,"context_line":"        \u0027port_security_enabled\u0027,"},{"line_number":887,"context_line":"        \u0027project_id\u0027,"},{"line_number":888,"context_line":"        \u0027provider:network_type\u0027,"},{"line_number":889,"context_line":"        \u0027provider:physical_network\u0027,"},{"line_number":890,"context_line":"        \u0027provider:segmentation_id\u0027,"},{"line_number":891,"context_line":"        \u0027qos_policy_id\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_9386a111","line":888,"in_reply_to":"1a6eadb0_ab108ba9","updated":"2016-12-14 17:54:00.000000000","message":"ditto","commit_id":"8e0b09222aa9bc29104bb417d052e2549c6a5ce1"}]}