)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"52219aac830f2dbddf69b471dd980897e0c388ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3a71b18c_0b57dc02","line":14,"updated":"2016-12-09 02:33:57.000000000","message":"Could you please add \"Partially-Implements: blueprint network-commands-options\" to the commit message when you updated as well. It will help us to track the work. Thanks!","commit_id":"a9db92776f5150fb8da88f6cb40d8bcb61239709"}],"doc/source/command-objects/network-rbac.rst":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"75fff08c11911c9e4aadf89f290ec915e38aea74","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":".. option:: --type \u003ctype\u003e"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    List network RBAC policies according to given object type (\"qos_policy\" or \"network\")"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":".. option:: --action \u003caction\u003e"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a6eadb0_8b4a5854","line":88,"range":{"start_line":88,"start_character":64,"end_line":88,"end_character":74},"updated":"2016-12-19 01:18:08.000000000","message":"shouldn\u0027t this be qos-policy?","commit_id":"d4630be8d71fb7601e9efb0f3804476b7a84580c"},{"author":{"_account_id":18086,"name":"guiyanxing","email":"guiyanxing@cmss.chinamobile.com","username":"guiyanxing"},"change_message_id":"0540a76300fb4650161743f93ff35201b5e10e18","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":".. option:: --type \u003ctype\u003e"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    List network RBAC policies according to given object type (\"qos_policy\" or \"network\")"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":".. option:: --action \u003caction\u003e"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a6eadb0_e6d3035e","line":88,"range":{"start_line":88,"start_character":64,"end_line":88,"end_character":74},"in_reply_to":"1a6eadb0_8b4a5854","updated":"2016-12-19 02:33:58.000000000","message":"Sorry,I don\u0027t think so.this should be the same with the help message in network_rbac.py.When list rbac policice,you can specify the qos_policy or network filtering option。","commit_id":"d4630be8d71fb7601e9efb0f3804476b7a84580c"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"75fff08c11911c9e4aadf89f290ec915e38aea74","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":".. option:: --action \u003caction\u003e"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    List network RBAC policies according to given action (\"access_as_external\" or \"access_as_shared\")"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":".. option:: --long"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a6eadb0_ab47144a","line":92,"range":{"start_line":92,"start_character":59,"end_line":92,"end_character":77},"updated":"2016-12-19 01:18:08.000000000","message":"shouldn\u0027t this be \u0027access-as-external\u0027 -- same with the other option","commit_id":"d4630be8d71fb7601e9efb0f3804476b7a84580c"},{"author":{"_account_id":18086,"name":"guiyanxing","email":"guiyanxing@cmss.chinamobile.com","username":"guiyanxing"},"change_message_id":"0540a76300fb4650161743f93ff35201b5e10e18","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":".. option:: --action \u003caction\u003e"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    List network RBAC policies according to given action (\"access_as_external\" or \"access_as_shared\")"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":".. option:: --long"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a6eadb0_26cedbb4","line":92,"range":{"start_line":92,"start_character":59,"end_line":92,"end_character":77},"in_reply_to":"1a6eadb0_ab47144a","updated":"2016-12-19 02:33:58.000000000","message":"when create or list rbac policy,the action must be specfified as access_as_external or access_as_shared.","commit_id":"d4630be8d71fb7601e9efb0f3804476b7a84580c"}],"openstackclient/network/v2/network_rbac.py":[{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"19a733647c0d162455b89cd03e4e6329b238797c","unresolved":false,"context_lines":[{"line_number":176,"context_line":"            \u0027--type\u0027,"},{"line_number":177,"context_line":"            metavar\u003d\u0027\u003ctype\u003e\u0027,"},{"line_number":178,"context_line":"            choices\u003d[\u0027qos_policy\u0027, \u0027network\u0027],"},{"line_number":179,"context_line":"            help\u003d_(\"List network rbac policies according to\""},{"line_number":180,"context_line":"                   \"given object type\")"},{"line_number":181,"context_line":"        )"},{"line_number":182,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_6417c4ed","line":179,"range":{"start_line":179,"start_character":59,"end_line":179,"end_character":60},"updated":"2016-12-08 11:37:30.000000000","message":"need a space here","commit_id":"75b5ebfeba7e3d3a1b65eab8eafb2663f8982ecd"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"19a733647c0d162455b89cd03e4e6329b238797c","unresolved":false,"context_lines":[{"line_number":177,"context_line":"            metavar\u003d\u0027\u003ctype\u003e\u0027,"},{"line_number":178,"context_line":"            choices\u003d[\u0027qos_policy\u0027, \u0027network\u0027],"},{"line_number":179,"context_line":"            help\u003d_(\"List network rbac policies according to\""},{"line_number":180,"context_line":"                   \"given object type\")"},{"line_number":181,"context_line":"        )"},{"line_number":182,"context_line":"        parser.add_argument("},{"line_number":183,"context_line":"            \u0027--action\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_241dcc0f","line":180,"updated":"2016-12-08 11:37:30.000000000","message":"Help message should match the doc","commit_id":"75b5ebfeba7e3d3a1b65eab8eafb2663f8982ecd"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"19a733647c0d162455b89cd03e4e6329b238797c","unresolved":false,"context_lines":[{"line_number":183,"context_line":"            \u0027--action\u0027,"},{"line_number":184,"context_line":"            metavar\u003d\u0027\u003caction\u003e\u0027,"},{"line_number":185,"context_line":"            choices\u003d[\u0027access_as_external\u0027, \u0027access_as_shared\u0027],"},{"line_number":186,"context_line":"            help\u003d_(\"List network rbac policies according to\""},{"line_number":187,"context_line":"                   \"given action\")"},{"line_number":188,"context_line":"        )"},{"line_number":189,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_64eee4ed","line":186,"range":{"start_line":186,"start_character":59,"end_line":186,"end_character":60},"updated":"2016-12-08 11:37:30.000000000","message":"need a space here","commit_id":"75b5ebfeba7e3d3a1b65eab8eafb2663f8982ecd"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"19a733647c0d162455b89cd03e4e6329b238797c","unresolved":false,"context_lines":[{"line_number":184,"context_line":"            metavar\u003d\u0027\u003caction\u003e\u0027,"},{"line_number":185,"context_line":"            choices\u003d[\u0027access_as_external\u0027, \u0027access_as_shared\u0027],"},{"line_number":186,"context_line":"            help\u003d_(\"List network rbac policies according to\""},{"line_number":187,"context_line":"                   \"given action\")"},{"line_number":188,"context_line":"        )"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_a4be3cd2","line":187,"updated":"2016-12-08 11:37:30.000000000","message":"Help message should match the doc","commit_id":"75b5ebfeba7e3d3a1b65eab8eafb2663f8982ecd"}],"openstackclient/tests/unit/network/v2/test_network_rbac.py":[{"author":{"_account_id":24080,"name":"jiahui.qiang","email":"jiahui.qiang@easystack.cn","username":"qiangjiahui"},"change_message_id":"b6f854bf1d75c3ca4bf62137ffda6982abfaa3f4","unresolved":false,"context_lines":[{"line_number":369,"context_line":"        self.assertEqual(self.columns, columns)"},{"line_number":370,"context_line":"        self.assertEqual(self.data, list(data))"},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"    def test_network_rbac_list_type_opt(self):"},{"line_number":373,"context_line":"        arglist \u003d ["},{"line_number":374,"context_line":"            \u0027--type\u0027, self.rbac_policies[0].object_type, ]"},{"line_number":375,"context_line":"        verifylist \u003d ["},{"line_number":376,"context_line":"            (\u0027type\u0027, self.rbac_policies[0].object_type)]"},{"line_number":377,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"        # DisplayCommandBase.take_action() returns two tuples"},{"line_number":380,"context_line":"        columns, data \u003d self.cmd.take_action(parsed_args)"},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"        self.network.rbac_policies.assert_called_with(**{"},{"line_number":383,"context_line":"            \u0027object_type\u0027: self.rbac_policies[0].object_type"},{"line_number":384,"context_line":"        })"},{"line_number":385,"context_line":"        self.assertEqual(self.columns, columns)"},{"line_number":386,"context_line":"        self.assertEqual(self.data, list(data))"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"    def test_network_rbac_list_action_opt(self):"},{"line_number":389,"context_line":"        arglist \u003d ["},{"line_number":390,"context_line":"            \u0027--action\u0027, self.rbac_policies[0].action, ]"},{"line_number":391,"context_line":"        verifylist \u003d ["},{"line_number":392,"context_line":"            (\u0027action\u0027, self.rbac_policies[0].action)]"},{"line_number":393,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"        # DisplayCommandBase.take_action() returns two tuples"},{"line_number":396,"context_line":"        columns, data \u003d self.cmd.take_action(parsed_args)"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"        self.network.rbac_policies.assert_called_with(**{"},{"line_number":399,"context_line":"            \u0027action\u0027: self.rbac_policies[0].action"},{"line_number":400,"context_line":"        })"},{"line_number":401,"context_line":"        self.assertEqual(self.columns, columns)"},{"line_number":402,"context_line":"        self.assertEqual(self.data, list(data))"},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"    def test_network_rbac_list_with_long(self):"},{"line_number":405,"context_line":"        arglist \u003d ["}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_e455b11d","line":402,"range":{"start_line":372,"start_character":4,"end_line":402,"end_character":47},"updated":"2016-12-13 03:17:31.000000000","message":"I think this two options can be tested in one method like \u0027test_network_rbac_list_with_opts\u0027. But it also looks good to me.","commit_id":"d4630be8d71fb7601e9efb0f3804476b7a84580c"}],"releasenotes/notes/bug-1648307-a2c6d7698e927449.yaml":[{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"19a733647c0d162455b89cd03e4e6329b238797c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add ``--type``, ``--action``, ``--long``,"},{"line_number":5,"context_line":"    options to ``network rbac list`` command"},{"line_number":6,"context_line":"    [Bug `1648307 \u003chttps://bugs.launchpad.net/bugs/1648307\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3a71b18c_84dce019","line":4,"range":{"start_line":4,"start_character":44,"end_line":4,"end_character":45},"updated":"2016-12-08 11:37:30.000000000","message":"Remove this comma.\nYou can feel free to combine line 4 and 5 into one line only.","commit_id":"75b5ebfeba7e3d3a1b65eab8eafb2663f8982ecd"}]}