)]}'
{"doc/source/command-objects/volume.rst":[{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"6f06d6af67b902e5de71147365e4cd04d332e588","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    Allow volume to be attached more than once (default to False)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":".. option:: --bootable"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    Mark volume as bootable"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a6eadb0_f93fcbd3","line":94,"updated":"2016-12-14 11:23:52.000000000","message":"Mark the default one in the help message","commit_id":"7ce758daa1f6d6ea685f25c073170eacbc76fb08"},{"author":{"_account_id":24080,"name":"jiahui.qiang","email":"jiahui.qiang@easystack.cn","username":"qiangjiahui"},"change_message_id":"a5e6703e6c15705b9fe7e39b3df3657c13eb0127","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    Allow volume to be attached more than once (default to False)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":".. option:: --bootable"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    Mark volume as bootable"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a6eadb0_91b767f4","line":94,"in_reply_to":"1a6eadb0_cc1f8e06","updated":"2016-12-15 02:43:37.000000000","message":"it will be \"--non-bootable\" and \"--read-write\" if it is not set.","commit_id":"7ce758daa1f6d6ea685f25c073170eacbc76fb08"},{"author":{"_account_id":24080,"name":"jiahui.qiang","email":"jiahui.qiang@easystack.cn","username":"qiangjiahui"},"change_message_id":"a5e6703e6c15705b9fe7e39b3df3657c13eb0127","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    Allow volume to be attached more than once (default to False)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":".. option:: --bootable"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    Mark volume as bootable"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a6eadb0_08ad1231","line":94,"in_reply_to":"1a6eadb0_f93fcbd3","updated":"2016-12-15 02:43:37.000000000","message":"Done","commit_id":"7ce758daa1f6d6ea685f25c073170eacbc76fb08"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"4b7d1536cfcb9c9dac9f82ce96ac79eb194b3d13","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    Allow volume to be attached more than once (default to False)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":".. option:: --bootable"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    Mark volume as bootable"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a6eadb0_cc1f8e06","line":94,"in_reply_to":"1a6eadb0_f93fcbd3","updated":"2016-12-14 22:12:15.000000000","message":"is there a default? the code looks like it only changes the volume if one of the flags is used:\n\n  if parsed_args.bootable or parsed_args.non_bootable","commit_id":"7ce758daa1f6d6ea685f25c073170eacbc76fb08"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"6f06d6af67b902e5de71147365e4cd04d332e588","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    Mark volume as non-bootable"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":".. option:: --read-only"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    Set volume to read-only access mode"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a6eadb0_59319f04","line":102,"updated":"2016-12-14 11:23:52.000000000","message":"Mark the default one in the help message","commit_id":"7ce758daa1f6d6ea685f25c073170eacbc76fb08"},{"author":{"_account_id":24080,"name":"jiahui.qiang","email":"jiahui.qiang@easystack.cn","username":"qiangjiahui"},"change_message_id":"a5e6703e6c15705b9fe7e39b3df3657c13eb0127","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    Mark volume as non-bootable"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":".. option:: --read-only"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    Set volume to read-only access mode"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a6eadb0_c8ba3a6e","line":102,"in_reply_to":"1a6eadb0_59319f04","updated":"2016-12-15 02:43:37.000000000","message":"Done","commit_id":"7ce758daa1f6d6ea685f25c073170eacbc76fb08"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"ddb048eaaef17a220242b778d62e4e51f5af8a6c","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":".. option:: --bootable"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    Mark volume as bootable (default to non-bootable)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":".. option:: --non-bootable"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a6eadb0_da6b98b7","line":96,"range":{"start_line":96,"start_character":28,"end_line":96,"end_character":53},"updated":"2016-12-15 14:48:05.000000000","message":"You just need to mark the default one, add the \"(default)\" in the end of the help message of the default one","commit_id":"9ec6379e7c039dfa739238cc2272c8d3c6ee7430"},{"author":{"_account_id":24080,"name":"jiahui.qiang","email":"jiahui.qiang@easystack.cn","username":"qiangjiahui"},"change_message_id":"0fb1b3d45e03239a4ad62db5c8b9bc33d8c85a65","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":".. option:: --bootable"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    Mark volume as bootable (default to non-bootable)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":".. option:: --non-bootable"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a6eadb0_14dced71","line":96,"range":{"start_line":96,"start_character":28,"end_line":96,"end_character":53},"in_reply_to":"1a6eadb0_da6b98b7","updated":"2016-12-16 02:51:58.000000000","message":"Done","commit_id":"9ec6379e7c039dfa739238cc2272c8d3c6ee7430"}],"openstackclient/tests/unit/volume/v1/test_volume.py":[{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"6f06d6af67b902e5de71147365e4cd04d332e588","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1a6eadb0_f4f7d2f2","updated":"2016-12-14 11:23:52.000000000","message":"You can feel free to combine these four tests into two, and it would be nice if you add a test for the case of error handling","commit_id":"7ce758daa1f6d6ea685f25c073170eacbc76fb08"},{"author":{"_account_id":24080,"name":"jiahui.qiang","email":"jiahui.qiang@easystack.cn","username":"qiangjiahui"},"change_message_id":"a5e6703e6c15705b9fe7e39b3df3657c13eb0127","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1a6eadb0_eb037040","in_reply_to":"1a6eadb0_f4f7d2f2","updated":"2016-12-15 02:43:37.000000000","message":"Yes, i also think two tests look better.:)","commit_id":"7ce758daa1f6d6ea685f25c073170eacbc76fb08"}],"openstackclient/tests/unit/volume/v2/test_volume.py":[{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"6f06d6af67b902e5de71147365e4cd04d332e588","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1a6eadb0_14c60e9a","updated":"2016-12-14 11:23:52.000000000","message":"You can feel free to combine these four tests into two, and it would be nice if you add a test for the case of error handling","commit_id":"7ce758daa1f6d6ea685f25c073170eacbc76fb08"}],"openstackclient/volume/v2/volume.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"af7f34133b9ca721df70f77c1cccd3aa3ab77b9a","unresolved":false,"context_lines":[{"line_number":235,"context_line":"                volume_client.volumes.update_readonly_flag("},{"line_number":236,"context_line":"                    volume.id,"},{"line_number":237,"context_line":"                    parsed_args.read_only)"},{"line_number":238,"context_line":"            except Exception:"},{"line_number":239,"context_line":"                LOG.error(_(\"Failed to set volume read-only access \""},{"line_number":240,"context_line":"                            \"mode flag: %s\"), e)"},{"line_number":241,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_56012e37","line":238,"range":{"start_line":238,"start_character":12,"end_line":238,"end_character":29},"updated":"2016-12-15 12:34:16.000000000","message":"why was this changed from:\n\n  except Exception as e:\n\n? now line 240 will fail","commit_id":"5ecb6423764e3b6c71968bfd164b9e30901daa3c"},{"author":{"_account_id":24080,"name":"jiahui.qiang","email":"jiahui.qiang@easystack.cn","username":"qiangjiahui"},"change_message_id":"601e693cb705df8f7e2e11dd8d0487d8c0055b47","unresolved":false,"context_lines":[{"line_number":235,"context_line":"                volume_client.volumes.update_readonly_flag("},{"line_number":236,"context_line":"                    volume.id,"},{"line_number":237,"context_line":"                    parsed_args.read_only)"},{"line_number":238,"context_line":"            except Exception:"},{"line_number":239,"context_line":"                LOG.error(_(\"Failed to set volume read-only access \""},{"line_number":240,"context_line":"                            \"mode flag: %s\"), e)"},{"line_number":241,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_932cb303","line":238,"range":{"start_line":238,"start_character":12,"end_line":238,"end_character":29},"in_reply_to":"1a6eadb0_56012e37","updated":"2016-12-15 13:39:40.000000000","message":"Sorry,I made a mistake!:)","commit_id":"5ecb6423764e3b6c71968bfd164b9e30901daa3c"}]}