)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"e354a18a7401c29e5092e255d4a2926397d0f3f4","unresolved":false,"context_lines":[{"line_number":11,"context_line":"an image."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Unit tests and reno entry is coming: please review the idea and wording :)"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I13b8c067aad68ece9ff636fbdd83bcb3663c91b2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1a6eadb0_401b04ca","line":14,"updated":"2016-12-16 02:26:38.000000000","message":"Add:\n\n  Closes-Bug: 1620481","commit_id":"a93004a600d157d7fc7c198e1ea2b89cc8f4b180"}],"doc/source/command-objects/image.rst":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"744a8944ded9fc659adc5e5849f804e734766df8","unresolved":false,"context_lines":[{"line_number":529,"context_line":""},{"line_number":530,"context_line":"    Image to modify (name or ID)"},{"line_number":531,"context_line":""},{"line_number":532,"context_line":"image update project"},{"line_number":533,"context_line":"--------------------"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"*Only supported for Image v2*"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a6eadb0_f664e3b9","line":532,"range":{"start_line":532,"start_character":0,"end_line":532,"end_character":20},"updated":"2016-12-15 19:49:46.000000000","message":"i agree with dean\u0027s comments here, for the sake of command consistency in OSC. we don\u0027t have \"update\" as a verb, \"update project\" even less so","commit_id":"69e54479cb9552841ba1ffcdd18c09f114842b4a"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"975cf44444d6b2d8d84eaf2be91351b6cb939937","unresolved":false,"context_lines":[{"line_number":541,"context_line":""},{"line_number":542,"context_line":"    os image update project"},{"line_number":543,"context_line":"        [--project-domain \u003cproject-domain\u003e]"},{"line_number":544,"context_line":"        \u003cimage\u003e \u003cproject\u003e \u003cstatus\u003e"},{"line_number":545,"context_line":""},{"line_number":546,"context_line":".. option:: --project-domain \u003cproject-domain\u003e"},{"line_number":547,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a6eadb0_c2564e29","line":544,"updated":"2016-12-15 16:33:03.000000000","message":"I would buy this implemented as an image set option:\n\n  image set\n    [--accepted | --rejected | |--pending]\n    --project \u003cproject\u003e\n    [--project-domain \u003cproject-domain\u003e]\n    \u003cimage\u003e\n\n--accepted is the default","commit_id":"69e54479cb9552841ba1ffcdd18c09f114842b4a"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"e354a18a7401c29e5092e255d4a2926397d0f3f4","unresolved":false,"context_lines":[{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    Accept the image membership."},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    .. versionadded:: 2"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":".. option:: --rejected"},{"line_number":173,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a6eadb0_0094ac40","line":170,"range":{"start_line":170,"start_character":4,"end_line":170,"end_character":23},"updated":"2016-12-16 02:26:38.000000000","message":"hmm, i thought we used \"*Image version 2 only.* here, but I see you just copied from line 164. We\u0027ll have to go back and fix these, they are out of scope for your change though.","commit_id":"a93004a600d157d7fc7c198e1ea2b89cc8f4b180"}],"openstackclient/image/v2/image.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"e354a18a7401c29e5092e255d4a2926397d0f3f4","unresolved":false,"context_lines":[{"line_number":777,"context_line":"                dest\u003ddeadopt.replace(\u0027-\u0027, \u0027_\u0027),"},{"line_number":778,"context_line":"                help\u003dargparse.SUPPRESS,"},{"line_number":779,"context_line":"            )"},{"line_number":780,"context_line":""},{"line_number":781,"context_line":"        membership_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":782,"context_line":"        membership_group.add_argument("},{"line_number":783,"context_line":"            \"--accepted\", action\u003d\"store_true\","}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6eadb0_007bcc28","line":780,"updated":"2016-12-16 02:26:38.000000000","message":"nit: unnecessary new line","commit_id":"a93004a600d157d7fc7c198e1ea2b89cc8f4b180"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"e354a18a7401c29e5092e255d4a2926397d0f3f4","unresolved":false,"context_lines":[{"line_number":780,"context_line":""},{"line_number":781,"context_line":"        membership_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":782,"context_line":"        membership_group.add_argument("},{"line_number":783,"context_line":"            \"--accepted\", action\u003d\"store_true\","},{"line_number":784,"context_line":"            help\u003d_(\"Accept the image membership\"),"},{"line_number":785,"context_line":"        )"},{"line_number":786,"context_line":"        membership_group.add_argument("}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6eadb0_a098586b","line":783,"range":{"start_line":783,"start_character":26,"end_line":783,"end_character":46},"updated":"2016-12-16 02:26:38.000000000","message":"nit, we consistently put each argparse argument in a new line","commit_id":"a93004a600d157d7fc7c198e1ea2b89cc8f4b180"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"e354a18a7401c29e5092e255d4a2926397d0f3f4","unresolved":false,"context_lines":[{"line_number":862,"context_line":"            image_client.images.reactivate(image.id)"},{"line_number":863,"context_line":"            activation_status \u003d \"activated\""},{"line_number":864,"context_line":""},{"line_number":865,"context_line":"        possible_membership_status \u003d (\u0027accepted\u0027, \u0027rejected\u0027, \u0027pending\u0027)"},{"line_number":866,"context_line":"        membership_status \u003d [status for status in possible_membership_status"},{"line_number":867,"context_line":"                             if getattr(parsed_args, status)]"},{"line_number":868,"context_line":"        if membership_status:"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6eadb0_40d6a4f1","line":865,"range":{"start_line":865,"start_character":8,"end_line":865,"end_character":34},"updated":"2016-12-16 02:26:38.000000000","message":"i think membership_group_args may be more clear","commit_id":"a93004a600d157d7fc7c198e1ea2b89cc8f4b180"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"e354a18a7401c29e5092e255d4a2926397d0f3f4","unresolved":false,"context_lines":[{"line_number":864,"context_line":""},{"line_number":865,"context_line":"        possible_membership_status \u003d (\u0027accepted\u0027, \u0027rejected\u0027, \u0027pending\u0027)"},{"line_number":866,"context_line":"        membership_status \u003d [status for status in possible_membership_status"},{"line_number":867,"context_line":"                             if getattr(parsed_args, status)]"},{"line_number":868,"context_line":"        if membership_status:"},{"line_number":869,"context_line":"            # If a specific project is not passed, assume we want to update"},{"line_number":870,"context_line":"            # our own membership"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6eadb0_80319c5c","line":867,"range":{"start_line":867,"start_character":32,"end_line":867,"end_character":61},"updated":"2016-12-16 02:26:38.000000000","message":"sneaky! :)","commit_id":"a93004a600d157d7fc7c198e1ea2b89cc8f4b180"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"e354a18a7401c29e5092e255d4a2926397d0f3f4","unresolved":false,"context_lines":[{"line_number":868,"context_line":"        if membership_status:"},{"line_number":869,"context_line":"            # If a specific project is not passed, assume we want to update"},{"line_number":870,"context_line":"            # our own membership"},{"line_number":871,"context_line":"            if not project_id:"},{"line_number":872,"context_line":"                project_id \u003d self.app.client_manager.auth_ref.project_id"},{"line_number":873,"context_line":"            # The mutually exclusive group of the arg parser ensure we have at"},{"line_number":874,"context_line":"            # most one item in the membership_status list"},{"line_number":875,"context_line":"            image_client.image_members.update("}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6eadb0_40a86477","line":872,"range":{"start_line":871,"start_character":0,"end_line":872,"end_character":72},"updated":"2016-12-16 02:26:38.000000000","message":"nice","commit_id":"a93004a600d157d7fc7c198e1ea2b89cc8f4b180"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"e354a18a7401c29e5092e255d4a2926397d0f3f4","unresolved":false,"context_lines":[{"line_number":871,"context_line":"            if not project_id:"},{"line_number":872,"context_line":"                project_id \u003d self.app.client_manager.auth_ref.project_id"},{"line_number":873,"context_line":"            # The mutually exclusive group of the arg parser ensure we have at"},{"line_number":874,"context_line":"            # most one item in the membership_status list"},{"line_number":875,"context_line":"            image_client.image_members.update("},{"line_number":876,"context_line":"                image.id, project_id, membership_status[0])"},{"line_number":877,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6eadb0_c037144b","line":874,"range":{"start_line":874,"start_character":14,"end_line":874,"end_character":27},"updated":"2016-12-16 02:26:38.000000000","message":"nice","commit_id":"a93004a600d157d7fc7c198e1ea2b89cc8f4b180"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"4a808d970540e1dad9a7cebc0d718c9ce36c2ef1","unresolved":false,"context_lines":[{"line_number":779,"context_line":"            )"},{"line_number":780,"context_line":""},{"line_number":781,"context_line":"        membership_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":782,"context_line":"        membership_group.add_argument("},{"line_number":783,"context_line":"            \"--accept\","},{"line_number":784,"context_line":"            action\u003d\"store_true\","},{"line_number":785,"context_line":"            help\u003d_(\"Accept the image membership\"),"},{"line_number":786,"context_line":"        )"},{"line_number":787,"context_line":"        membership_group.add_argument("},{"line_number":788,"context_line":"            \"--reject\","},{"line_number":789,"context_line":"            action\u003d\"store_true\","},{"line_number":790,"context_line":"            help\u003d_(\"Reject the image membership\"),"},{"line_number":791,"context_line":"        )"},{"line_number":792,"context_line":"        membership_group.add_argument("},{"line_number":793,"context_line":"            \"--pending\","},{"line_number":794,"context_line":"            action\u003d\"store_true\","},{"line_number":795,"context_line":"            help\u003d_(\"Reset the image membership to \u0027pending\u0027\"),"},{"line_number":796,"context_line":"        )"},{"line_number":797,"context_line":"        return parser"},{"line_number":798,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"ba5201f7_c0a2ee98","line":795,"range":{"start_line":782,"start_character":8,"end_line":795,"end_character":62},"updated":"2017-01-04 18:07:00.000000000","message":"bah, these have to match the help doc!","commit_id":"16ef8981debeb213e292efa300330667a3aed82f"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"1468552be5e23e12cbafffc7d439f37a3722be71","unresolved":false,"context_lines":[{"line_number":779,"context_line":"            )"},{"line_number":780,"context_line":""},{"line_number":781,"context_line":"        membership_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":782,"context_line":"        membership_group.add_argument("},{"line_number":783,"context_line":"            \"--accept\","},{"line_number":784,"context_line":"            action\u003d\"store_true\","},{"line_number":785,"context_line":"            help\u003d_(\"Accept the image membership\"),"},{"line_number":786,"context_line":"        )"},{"line_number":787,"context_line":"        membership_group.add_argument("},{"line_number":788,"context_line":"            \"--reject\","},{"line_number":789,"context_line":"            action\u003d\"store_true\","},{"line_number":790,"context_line":"            help\u003d_(\"Reject the image membership\"),"},{"line_number":791,"context_line":"        )"},{"line_number":792,"context_line":"        membership_group.add_argument("},{"line_number":793,"context_line":"            \"--pending\","},{"line_number":794,"context_line":"            action\u003d\"store_true\","},{"line_number":795,"context_line":"            help\u003d_(\"Reset the image membership to \u0027pending\u0027\"),"},{"line_number":796,"context_line":"        )"},{"line_number":797,"context_line":"        return parser"},{"line_number":798,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"ba5201f7_23ebc414","line":795,"range":{"start_line":782,"start_character":8,"end_line":795,"end_character":62},"in_reply_to":"ba5201f7_c0a2ee98","updated":"2017-01-04 18:14:46.000000000","message":"Why ? Can\u0027t we have more information in the help doc than what the \"usage description\" says ?\n\n(I will still update the patch)","commit_id":"16ef8981debeb213e292efa300330667a3aed82f"}]}