)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"2d6576552e0161ad8faf28f169e34476c3e18a6c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Huanxuan Ao \u003chuanxuan.ao@easystack.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-12-30 10:54:58 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add options in \"volume type set\" command"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add \"--encryption-provider\", \"--encryption-cipher\","},{"line_number":10,"context_line":"\"--encryption-key-size\" and \"--encryption-control-location\""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba5201f7_40749a9b","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":11},"updated":"2017-01-04 03:59:24.000000000","message":"Add encryption* options in ...","commit_id":"03bea0e04ee4d0ac4d3ab220adae16ae597616e0"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"92ecf9862f2f65d8e65516eccac1b99b284fecf0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Huanxuan Ao \u003chuanxuan.ao@easystack.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-12-30 10:54:58 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add options in \"volume type set\" command"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add \"--encryption-provider\", \"--encryption-cipher\","},{"line_number":10,"context_line":"\"--encryption-key-size\" and \"--encryption-control-location\""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba5201f7_9d4056a7","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":11},"in_reply_to":"ba5201f7_40749a9b","updated":"2017-01-04 15:26:33.000000000","message":"Yes, will change this","commit_id":"03bea0e04ee4d0ac4d3ab220adae16ae597616e0"}],"doc/source/command-objects/volume-type.rst":[{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"17961c0e39152411afa05b343d24aa5bd4e39fd9","unresolved":false,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    Set the class that provides encryption support for this volume type"},{"line_number":164,"context_line":"    (e.g \"LuksEncryptor\") (admin only)"},{"line_number":165,"context_line":"    (required when first set the encryption type information with any other \"--encryption-*\" option)"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":".. option:: --encryption-cipher \u003ccipher\u003e"},{"line_number":168,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"da4df55a_fe32f6a5","line":165,"updated":"2016-12-28 16:30:30.000000000","message":"same comment from v1","commit_id":"1a3dc5e3006c808a76b63b86249f66711729a535"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"17961c0e39152411afa05b343d24aa5bd4e39fd9","unresolved":false,"context_lines":[{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    Set the notional service where the encryption is performed"},{"line_number":180,"context_line":"    (\"front-end\" or \"back-end\") (admin only)"},{"line_number":181,"context_line":"    (default is \"front-end\" when first set encryption type with any other \"encryption-*\" option)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":".. _volume_type_set-volume-type:"},{"line_number":184,"context_line":".. describe:: \u003cvolume-type\u003e"}],"source_content_type":"text/x-rst","patch_set":3,"id":"da4df55a_1e241a5e","line":181,"updated":"2016-12-28 16:30:30.000000000","message":"same comment from v1","commit_id":"1a3dc5e3006c808a76b63b86249f66711729a535"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"2d6576552e0161ad8faf28f169e34476c3e18a6c","unresolved":false,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    Set the class that provides encryption support for this volume type"},{"line_number":164,"context_line":"    (e.g \"LuksEncryptor\") (admin only)"},{"line_number":165,"context_line":"    (required when the first time to set encryption type information for this volume"},{"line_number":166,"context_line":"    type by :option:`--encryption-cipher`, :option:`--encryption-key-size` or"},{"line_number":167,"context_line":"    :option:`--encryption-control-location` option"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":".. option:: --encryption-cipher \u003ccipher\u003e"},{"line_number":170,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba5201f7_8ad74322","line":167,"range":{"start_line":165,"start_character":4,"end_line":167,"end_character":50},"updated":"2017-01-04 03:59:24.000000000","message":"Remove the \"(\" at the beginning. \n\nIf i may suggest a re-wording..\n\nThis option is required when setting encryption type of a volume for the first time. Consider using other encryption options such as: :option:`--encryption-cipher`, :option:`--encryption-key-size` and :option:`--encryption-control-location`","commit_id":"03bea0e04ee4d0ac4d3ab220adae16ae597616e0"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"92ecf9862f2f65d8e65516eccac1b99b284fecf0","unresolved":false,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    Set the class that provides encryption support for this volume type"},{"line_number":164,"context_line":"    (e.g \"LuksEncryptor\") (admin only)"},{"line_number":165,"context_line":"    (required when the first time to set encryption type information for this volume"},{"line_number":166,"context_line":"    type by :option:`--encryption-cipher`, :option:`--encryption-key-size` or"},{"line_number":167,"context_line":"    :option:`--encryption-control-location` option"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":".. option:: --encryption-cipher \u003ccipher\u003e"},{"line_number":170,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba5201f7_3d868a65","line":167,"range":{"start_line":165,"start_character":4,"end_line":167,"end_character":50},"in_reply_to":"ba5201f7_8ad74322","updated":"2017-01-04 15:26:33.000000000","message":"Thank you for the suggestion! I will modify it","commit_id":"03bea0e04ee4d0ac4d3ab220adae16ae597616e0"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"2d6576552e0161ad8faf28f169e34476c3e18a6c","unresolved":false,"context_lines":[{"line_number":168,"context_line":""},{"line_number":169,"context_line":".. option:: --encryption-cipher \u003ccipher\u003e"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    Set the encryption algorithm or mode for this volume type"},{"line_number":172,"context_line":"    (e.g \"aes-xts-plain64\") (admin only)"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":".. option:: --encryption-key-size \u003ckey-size\u003e"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba5201f7_6aa21fb0","line":171,"range":{"start_line":171,"start_character":33,"end_line":171,"end_character":40},"updated":"2017-01-04 03:59:24.000000000","message":"remove \"or mode\" i don\u0027t know if it helps to make things any more clear","commit_id":"03bea0e04ee4d0ac4d3ab220adae16ae597616e0"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"a22d39fea4f42213f20cc5a6ca5084150e493160","unresolved":false,"context_lines":[{"line_number":168,"context_line":""},{"line_number":169,"context_line":".. option:: --encryption-cipher \u003ccipher\u003e"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    Set the encryption algorithm or mode for this volume type"},{"line_number":172,"context_line":"    (e.g \"aes-xts-plain64\") (admin only)"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":".. option:: --encryption-key-size \u003ckey-size\u003e"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba5201f7_51589532","line":171,"in_reply_to":"ba5201f7_00523ddd","updated":"2017-01-04 16:34:45.000000000","message":"Yes, we plan to add choices for these options, maybe will include all choices in the help message in the future","commit_id":"03bea0e04ee4d0ac4d3ab220adae16ae597616e0"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"92ecf9862f2f65d8e65516eccac1b99b284fecf0","unresolved":false,"context_lines":[{"line_number":168,"context_line":""},{"line_number":169,"context_line":".. option:: --encryption-cipher \u003ccipher\u003e"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    Set the encryption algorithm or mode for this volume type"},{"line_number":172,"context_line":"    (e.g \"aes-xts-plain64\") (admin only)"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":".. option:: --encryption-key-size \u003ckey-size\u003e"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba5201f7_7db812e6","line":171,"range":{"start_line":171,"start_character":33,"end_line":171,"end_character":40},"in_reply_to":"ba5201f7_6aa21fb0","updated":"2017-01-04 15:26:33.000000000","message":"remove it will make it more clear but maybe also loss some informations for users, we can specified not only algorithm but also mode by this option, I think we should let user know it.","commit_id":"03bea0e04ee4d0ac4d3ab220adae16ae597616e0"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"8d56bcdc175f3377a6ef82d5c37e7d2233cb713c","unresolved":false,"context_lines":[{"line_number":168,"context_line":""},{"line_number":169,"context_line":".. option:: --encryption-cipher \u003ccipher\u003e"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    Set the encryption algorithm or mode for this volume type"},{"line_number":172,"context_line":"    (e.g \"aes-xts-plain64\") (admin only)"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":".. option:: --encryption-key-size \u003ckey-size\u003e"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba5201f7_00523ddd","line":171,"in_reply_to":"ba5201f7_7db812e6","updated":"2017-01-04 15:38:11.000000000","message":"Maybe explaining what \u0027mode\u0027 is, or include an example?","commit_id":"03bea0e04ee4d0ac4d3ab220adae16ae597616e0"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"2d6576552e0161ad8faf28f169e34476c3e18a6c","unresolved":false,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    Set the notional service where the encryption is performed"},{"line_number":182,"context_line":"    (\"front-end\" or \"back-end\") (admin only)"},{"line_number":183,"context_line":"    (default is \"front-end\" when the first time to set encryption type information for"},{"line_number":184,"context_line":"    this volume type by :option:`--encryption-cipher`, :option:`--encryption-key-size`"},{"line_number":185,"context_line":"    or :option:`--encryption-provider` option"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":".. _volume_type_set-volume-type:"},{"line_number":188,"context_line":".. describe:: \u003cvolume-type\u003e"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba5201f7_4a9c7b69","line":185,"range":{"start_line":183,"start_character":4,"end_line":185,"end_character":45},"updated":"2017-01-04 03:59:24.000000000","message":"Remove the leading \"(\"\n\nAnother re-wording suggestion. I don\u0027t know if it\u0027s perfect, but see if you like it.\n\nThe default value for this option is \"front-end\". Consider using other encryption options such as: :option:`--encryption-cipher`, :option:`--encryption-key-size` and :option:`--encryption-provider`","commit_id":"03bea0e04ee4d0ac4d3ab220adae16ae597616e0"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"92ecf9862f2f65d8e65516eccac1b99b284fecf0","unresolved":false,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    Set the notional service where the encryption is performed"},{"line_number":182,"context_line":"    (\"front-end\" or \"back-end\") (admin only)"},{"line_number":183,"context_line":"    (default is \"front-end\" when the first time to set encryption type information for"},{"line_number":184,"context_line":"    this volume type by :option:`--encryption-cipher`, :option:`--encryption-key-size`"},{"line_number":185,"context_line":"    or :option:`--encryption-provider` option"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":".. _volume_type_set-volume-type:"},{"line_number":188,"context_line":".. describe:: \u003cvolume-type\u003e"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba5201f7_5de8aeb4","line":185,"range":{"start_line":183,"start_character":4,"end_line":185,"end_character":45},"in_reply_to":"ba5201f7_4a9c7b69","updated":"2017-01-04 15:26:33.000000000","message":"Thank you for the suggestion! And there not a default in set but only in create(set for the first time), so I will also note \"for the first time\" in this help message.","commit_id":"03bea0e04ee4d0ac4d3ab220adae16ae597616e0"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"6d8012d2b593e994ad3be13e60bf3a8c0dde855f","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    *Volume version 2 only*"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":".. option:: --encryption-provider \u003cprovider\u003e"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    Set the class that provides encryption support for this volume type"},{"line_number":66,"context_line":"    (e.g \"LuksEncryptor\") (admin only)"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba5201f7_c7975d46","line":63,"updated":"2017-01-04 21:51:19.000000000","message":"We need to say what happens when the option is not present, ie the default for this value is equivalent to an encryption-provider \u003d\u003d None.\n\nThen add that the following three options are ignored if --encryption-provider is not set.","commit_id":"772266699cbad349e098f02e2d262e213128952c"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"876bff879e21f05059c3d6082949a8e0f4c37251","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    *Volume version 2 only*"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":".. option:: --encryption-provider \u003cprovider\u003e"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    Set the class that provides encryption support for this volume type"},{"line_number":66,"context_line":"    (e.g \"LuksEncryptor\") (admin only)"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba5201f7_b171afaa","line":63,"in_reply_to":"ba5201f7_c7975d46","updated":"2017-01-05 01:42:58.000000000","message":"If this option not specified, then error out, and it has not a default. I think \"required\" in the message can tell users what will happens\n.","commit_id":"772266699cbad349e098f02e2d262e213128952c"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"6d8012d2b593e994ad3be13e60bf3a8c0dde855f","unresolved":false,"context_lines":[{"line_number":63,"context_line":".. option:: --encryption-provider \u003cprovider\u003e"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    Set the class that provides encryption support for this volume type"},{"line_number":66,"context_line":"    (e.g \"LuksEncryptor\") (admin only)"},{"line_number":67,"context_line":"    This option is required when setting encryption type of a volume."},{"line_number":68,"context_line":"    Consider using other encryption options such as: :option:`--encryption-cipher`,"},{"line_number":69,"context_line":"    :option:`--encryption-key-size` and :option:`--encryption-control-location`"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba5201f7_47bc4ddc","line":66,"updated":"2017-01-04 21:51:19.000000000","message":"Add a blank line here","commit_id":"772266699cbad349e098f02e2d262e213128952c"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"876bff879e21f05059c3d6082949a8e0f4c37251","unresolved":false,"context_lines":[{"line_number":63,"context_line":".. option:: --encryption-provider \u003cprovider\u003e"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    Set the class that provides encryption support for this volume type"},{"line_number":66,"context_line":"    (e.g \"LuksEncryptor\") (admin only)"},{"line_number":67,"context_line":"    This option is required when setting encryption type of a volume."},{"line_number":68,"context_line":"    Consider using other encryption options such as: :option:`--encryption-cipher`,"},{"line_number":69,"context_line":"    :option:`--encryption-key-size` and :option:`--encryption-control-location`"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba5201f7_11619bd3","line":66,"in_reply_to":"ba5201f7_47bc4ddc","updated":"2017-01-05 01:42:58.000000000","message":"Done","commit_id":"772266699cbad349e098f02e2d262e213128952c"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"6d8012d2b593e994ad3be13e60bf3a8c0dde855f","unresolved":false,"context_lines":[{"line_number":81,"context_line":".. option:: --encryption-control-location \u003ccontrol-location\u003e"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    Set the notional service where the encryption is performed"},{"line_number":84,"context_line":"    (\"front-end\" or \"back-end\") (admin only)"},{"line_number":85,"context_line":"    The default value for this option is \"front-end\" when setting encryption type of"},{"line_number":86,"context_line":"    a volume. Consider using other encryption options such as: :option:`--encryption-cipher`,"},{"line_number":87,"context_line":"    :option:`--encryption-key-size` and :option:`--encryption-provider`"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba5201f7_87b2b504","line":84,"updated":"2017-01-04 21:51:19.000000000","message":"Add a blank line here","commit_id":"772266699cbad349e098f02e2d262e213128952c"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"876bff879e21f05059c3d6082949a8e0f4c37251","unresolved":false,"context_lines":[{"line_number":81,"context_line":".. option:: --encryption-control-location \u003ccontrol-location\u003e"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    Set the notional service where the encryption is performed"},{"line_number":84,"context_line":"    (\"front-end\" or \"back-end\") (admin only)"},{"line_number":85,"context_line":"    The default value for this option is \"front-end\" when setting encryption type of"},{"line_number":86,"context_line":"    a volume. Consider using other encryption options such as: :option:`--encryption-cipher`,"},{"line_number":87,"context_line":"    :option:`--encryption-key-size` and :option:`--encryption-provider`"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba5201f7_315e9f12","line":84,"in_reply_to":"ba5201f7_87b2b504","updated":"2017-01-05 01:42:58.000000000","message":"Done","commit_id":"772266699cbad349e098f02e2d262e213128952c"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"6d8012d2b593e994ad3be13e60bf3a8c0dde855f","unresolved":false,"context_lines":[{"line_number":191,"context_line":".. option:: --encryption-provider \u003cprovider\u003e"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    Set the class that provides encryption support for this volume type"},{"line_number":194,"context_line":"    (e.g \"LuksEncryptor\") (admin only)"},{"line_number":195,"context_line":"    This option is required when setting encryption type of a volume for the first time."},{"line_number":196,"context_line":"    Consider using other encryption options such as: :option:`--encryption-cipher`,"},{"line_number":197,"context_line":"    :option:`--encryption-key-size` and :option:`--encryption-control-location`"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba5201f7_678f912a","line":194,"updated":"2017-01-04 21:51:19.000000000","message":"Add blank line here","commit_id":"772266699cbad349e098f02e2d262e213128952c"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"876bff879e21f05059c3d6082949a8e0f4c37251","unresolved":false,"context_lines":[{"line_number":191,"context_line":".. option:: --encryption-provider \u003cprovider\u003e"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    Set the class that provides encryption support for this volume type"},{"line_number":194,"context_line":"    (e.g \"LuksEncryptor\") (admin only)"},{"line_number":195,"context_line":"    This option is required when setting encryption type of a volume for the first time."},{"line_number":196,"context_line":"    Consider using other encryption options such as: :option:`--encryption-cipher`,"},{"line_number":197,"context_line":"    :option:`--encryption-key-size` and :option:`--encryption-control-location`"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba5201f7_519de3ba","line":194,"in_reply_to":"ba5201f7_678f912a","updated":"2017-01-05 01:42:58.000000000","message":"Done","commit_id":"772266699cbad349e098f02e2d262e213128952c"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"6d8012d2b593e994ad3be13e60bf3a8c0dde855f","unresolved":false,"context_lines":[{"line_number":209,"context_line":".. option:: --encryption-control-location \u003ccontrol-location\u003e"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    Set the notional service where the encryption is performed"},{"line_number":212,"context_line":"    (\"front-end\" or \"back-end\") (admin only)"},{"line_number":213,"context_line":"    The default value for this option is \"front-end\" when setting encryption type of"},{"line_number":214,"context_line":"    a volume for the first time. Consider using other encryption options such as:"},{"line_number":215,"context_line":"    :option:`--encryption-cipher`, :option:`--encryption-key-size` and :option:`--encryption-provider`"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba5201f7_8780f5f8","line":212,"updated":"2017-01-04 21:51:19.000000000","message":"Add blank line here","commit_id":"772266699cbad349e098f02e2d262e213128952c"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"876bff879e21f05059c3d6082949a8e0f4c37251","unresolved":false,"context_lines":[{"line_number":209,"context_line":".. option:: --encryption-control-location \u003ccontrol-location\u003e"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    Set the notional service where the encryption is performed"},{"line_number":212,"context_line":"    (\"front-end\" or \"back-end\") (admin only)"},{"line_number":213,"context_line":"    The default value for this option is \"front-end\" when setting encryption type of"},{"line_number":214,"context_line":"    a volume for the first time. Consider using other encryption options such as:"},{"line_number":215,"context_line":"    :option:`--encryption-cipher`, :option:`--encryption-key-size` and :option:`--encryption-provider`"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba5201f7_91a3cbff","line":212,"in_reply_to":"ba5201f7_8780f5f8","updated":"2017-01-05 01:42:58.000000000","message":"Done","commit_id":"772266699cbad349e098f02e2d262e213128952c"}],"openstackclient/volume/v1/volume_type.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"42347775cfc1a5abd70b0e7497d9288ba42a6b04","unresolved":false,"context_lines":[{"line_number":36,"context_line":"            volume_type)"},{"line_number":37,"context_line":"    except Exception:"},{"line_number":38,"context_line":"        # create new encryption type"},{"line_number":39,"context_line":"        LOG.warning(_(\"No exiting encryption type found, creating \""},{"line_number":40,"context_line":"                    \"new encryption type for this volume type ...\"))"},{"line_number":41,"context_line":"        if not parsed_args.encryption_provider:"},{"line_number":42,"context_line":"            msg \u003d _(\"\u0027--encryption-provider\u0027 should be specified whlie \""}],"source_content_type":"text/x-python","patch_set":1,"id":"da4df55a_c20ad578","line":39,"range":{"start_line":39,"start_character":26,"end_line":39,"end_character":33},"updated":"2016-12-27 13:52:46.000000000","message":"existing*","commit_id":"7fb13edd232c1cc785b8a7166579a90023427427"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"42347775cfc1a5abd70b0e7497d9288ba42a6b04","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        LOG.warning(_(\"No exiting encryption type found, creating \""},{"line_number":40,"context_line":"                    \"new encryption type for this volume type ...\"))"},{"line_number":41,"context_line":"        if not parsed_args.encryption_provider:"},{"line_number":42,"context_line":"            msg \u003d _(\"\u0027--encryption-provider\u0027 should be specified whlie \""},{"line_number":43,"context_line":"                    \"creating new encryption type\")"},{"line_number":44,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":45,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da4df55a_22264115","line":42,"range":{"start_line":42,"start_character":65,"end_line":42,"end_character":70},"updated":"2016-12-27 13:52:46.000000000","message":"while*","commit_id":"7fb13edd232c1cc785b8a7166579a90023427427"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"42347775cfc1a5abd70b0e7497d9288ba42a6b04","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                    \"new encryption type for this volume type ...\"))"},{"line_number":41,"context_line":"        if not parsed_args.encryption_provider:"},{"line_number":42,"context_line":"            msg \u003d _(\"\u0027--encryption-provider\u0027 should be specified whlie \""},{"line_number":43,"context_line":"                    \"creating new encryption type\")"},{"line_number":44,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":45,"context_line":"        else:"},{"line_number":46,"context_line":"            control_location \u003d parsed_args.encryption_control_location"}],"source_content_type":"text/x-python","patch_set":1,"id":"da4df55a_a28071c1","line":43,"range":{"start_line":43,"start_character":21,"end_line":43,"end_character":33},"updated":"2016-12-27 13:52:46.000000000","message":"creating a* new","commit_id":"7fb13edd232c1cc785b8a7166579a90023427427"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"42347775cfc1a5abd70b0e7497d9288ba42a6b04","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                    \"creating new encryption type\")"},{"line_number":44,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":45,"context_line":"        else:"},{"line_number":46,"context_line":"            control_location \u003d parsed_args.encryption_control_location"},{"line_number":47,"context_line":"            if not parsed_args.encryption_control_location:"},{"line_number":48,"context_line":"                # set the default of control location while creating"},{"line_number":49,"context_line":"                control_location \u003d \u0027front-end\u0027"},{"line_number":50,"context_line":"            body \u003d {"},{"line_number":51,"context_line":"                \u0027provider\u0027: parsed_args.encryption_provider,"},{"line_number":52,"context_line":"                \u0027cipher\u0027: parsed_args.encryption_cipher,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da4df55a_82628d3c","line":49,"range":{"start_line":46,"start_character":12,"end_line":49,"end_character":46},"updated":"2016-12-27 13:52:46.000000000","message":"Just a nit... I always prefer this way of defaulting, i think it reads easier.\n\n  # set the default of control location while creating\n  control_location \u003d \u0027front-end\u0027\n  if parsed_args.encryption_control_location:\n    control_location \u003d parsed_args.encryption_control_location","commit_id":"7fb13edd232c1cc785b8a7166579a90023427427"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"82edf6ab547a66138e76bd7569c9b7c2d95581ff","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                    \"creating new encryption type\")"},{"line_number":44,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":45,"context_line":"        else:"},{"line_number":46,"context_line":"            control_location \u003d parsed_args.encryption_control_location"},{"line_number":47,"context_line":"            if not parsed_args.encryption_control_location:"},{"line_number":48,"context_line":"                # set the default of control location while creating"},{"line_number":49,"context_line":"                control_location \u003d \u0027front-end\u0027"},{"line_number":50,"context_line":"            body \u003d {"},{"line_number":51,"context_line":"                \u0027provider\u0027: parsed_args.encryption_provider,"},{"line_number":52,"context_line":"                \u0027cipher\u0027: parsed_args.encryption_cipher,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da4df55a_fcadb49b","line":49,"range":{"start_line":46,"start_character":12,"end_line":49,"end_character":46},"in_reply_to":"da4df55a_82628d3c","updated":"2016-12-28 02:03:44.000000000","message":"Yes, thank you for the good suggestion!","commit_id":"7fb13edd232c1cc785b8a7166579a90023427427"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"42347775cfc1a5abd70b0e7497d9288ba42a6b04","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            }"},{"line_number":56,"context_line":"            volume_client.volume_encryption_types.create("},{"line_number":57,"context_line":"                volume_type, body)"},{"line_number":58,"context_line":"    else:"},{"line_number":59,"context_line":"        # update the existing encryption type"},{"line_number":60,"context_line":"        body \u003d {"},{"line_number":61,"context_line":"            \u0027provider\u0027: parsed_args.encryption_provider,"},{"line_number":62,"context_line":"            \u0027cipher\u0027: parsed_args.encryption_cipher,"},{"line_number":63,"context_line":"            \u0027key_size\u0027: parsed_args.encryption_key_size,"},{"line_number":64,"context_line":"            \u0027control_location\u0027: parsed_args.control_location"},{"line_number":65,"context_line":"        }"},{"line_number":66,"context_line":"        volume_client.volume_encryption_types.update(volume_type, body)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"class CreateVolumeType(command.ShowOne):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da4df55a_6245a9b1","line":66,"range":{"start_line":58,"start_character":0,"end_line":66,"end_character":71},"updated":"2016-12-27 13:52:46.000000000","message":"Update isn\u0027t implemented in v1: https://github.com/openstack/python-cinderclient/blob/master/cinderclient/v1/volume_encryption_types.py#L78-L87","commit_id":"7fb13edd232c1cc785b8a7166579a90023427427"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"82edf6ab547a66138e76bd7569c9b7c2d95581ff","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            }"},{"line_number":56,"context_line":"            volume_client.volume_encryption_types.create("},{"line_number":57,"context_line":"                volume_type, body)"},{"line_number":58,"context_line":"    else:"},{"line_number":59,"context_line":"        # update the existing encryption type"},{"line_number":60,"context_line":"        body \u003d {"},{"line_number":61,"context_line":"            \u0027provider\u0027: parsed_args.encryption_provider,"},{"line_number":62,"context_line":"            \u0027cipher\u0027: parsed_args.encryption_cipher,"},{"line_number":63,"context_line":"            \u0027key_size\u0027: parsed_args.encryption_key_size,"},{"line_number":64,"context_line":"            \u0027control_location\u0027: parsed_args.control_location"},{"line_number":65,"context_line":"        }"},{"line_number":66,"context_line":"        volume_client.volume_encryption_types.update(volume_type, body)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"class CreateVolumeType(command.ShowOne):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da4df55a_9c902845","line":66,"range":{"start_line":58,"start_character":0,"end_line":66,"end_character":71},"in_reply_to":"da4df55a_6245a9b1","updated":"2016-12-28 02:03:44.000000000","message":"Yes, I did not see that...\nWill remove it","commit_id":"7fb13edd232c1cc785b8a7166579a90023427427"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"42347775cfc1a5abd70b0e7497d9288ba42a6b04","unresolved":false,"context_lines":[{"line_number":178,"context_line":"            help\u003d_(\u0027Set a property on this volume type \u0027"},{"line_number":179,"context_line":"                   \u0027(repeat option to set multiple properties)\u0027),"},{"line_number":180,"context_line":"        )"},{"line_number":181,"context_line":"        parser.add_argument("},{"line_number":182,"context_line":"            \u0027--encryption-provider\u0027,"},{"line_number":183,"context_line":"            metavar\u003d\u0027\u003cprovider\u003e\u0027,"},{"line_number":184,"context_line":"            help\u003d_(\u0027Set the class that provides encryption support \u0027"},{"line_number":185,"context_line":"                   \u0027for this volume type (e.g \"LuksEncryptor\") \u0027"},{"line_number":186,"context_line":"                   \u0027(admin only)\u0027),"},{"line_number":187,"context_line":"        )"},{"line_number":188,"context_line":"        parser.add_argument("},{"line_number":189,"context_line":"            \u0027--encryption-cipher\u0027,"},{"line_number":190,"context_line":"            metavar\u003d\u0027\u003ccipher\u003e\u0027,"},{"line_number":191,"context_line":"            help\u003d_(\u0027Set the encryption algorithm or mode for this \u0027"},{"line_number":192,"context_line":"                   \u0027volume type (e.g \"aes-xts-plain64\") (admin only)\u0027),"},{"line_number":193,"context_line":"        )"},{"line_number":194,"context_line":"        parser.add_argument("},{"line_number":195,"context_line":"            \u0027--encryption-key-size\u0027,"},{"line_number":196,"context_line":"            metavar\u003d\u0027\u003ckey-size\u003e\u0027,"},{"line_number":197,"context_line":"            type\u003dint,"},{"line_number":198,"context_line":"            help\u003d_(\u0027Set the size of the encryption key of this \u0027"},{"line_number":199,"context_line":"                   \u0027volume type (e.g \"128\" or \"256\") (admin only)\u0027),"},{"line_number":200,"context_line":"        )"},{"line_number":201,"context_line":"        parser.add_argument("},{"line_number":202,"context_line":"            \u0027--encryption-control-location\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da4df55a_a232315d","line":199,"range":{"start_line":181,"start_character":8,"end_line":199,"end_character":68},"updated":"2016-12-27 13:52:46.000000000","message":"It would be nice to know what choices are supported by the server so we can provide more meaningful help messages, and know what happens by default. \n\nAnyway, I think this approach is fine for now.\n\nSee bug 1562043 [1]\n\n[1] https://bugs.launchpad.net/cinder/+bug/1562043","commit_id":"7fb13edd232c1cc785b8a7166579a90023427427"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"82edf6ab547a66138e76bd7569c9b7c2d95581ff","unresolved":false,"context_lines":[{"line_number":178,"context_line":"            help\u003d_(\u0027Set a property on this volume type \u0027"},{"line_number":179,"context_line":"                   \u0027(repeat option to set multiple properties)\u0027),"},{"line_number":180,"context_line":"        )"},{"line_number":181,"context_line":"        parser.add_argument("},{"line_number":182,"context_line":"            \u0027--encryption-provider\u0027,"},{"line_number":183,"context_line":"            metavar\u003d\u0027\u003cprovider\u003e\u0027,"},{"line_number":184,"context_line":"            help\u003d_(\u0027Set the class that provides encryption support \u0027"},{"line_number":185,"context_line":"                   \u0027for this volume type (e.g \"LuksEncryptor\") \u0027"},{"line_number":186,"context_line":"                   \u0027(admin only)\u0027),"},{"line_number":187,"context_line":"        )"},{"line_number":188,"context_line":"        parser.add_argument("},{"line_number":189,"context_line":"            \u0027--encryption-cipher\u0027,"},{"line_number":190,"context_line":"            metavar\u003d\u0027\u003ccipher\u003e\u0027,"},{"line_number":191,"context_line":"            help\u003d_(\u0027Set the encryption algorithm or mode for this \u0027"},{"line_number":192,"context_line":"                   \u0027volume type (e.g \"aes-xts-plain64\") (admin only)\u0027),"},{"line_number":193,"context_line":"        )"},{"line_number":194,"context_line":"        parser.add_argument("},{"line_number":195,"context_line":"            \u0027--encryption-key-size\u0027,"},{"line_number":196,"context_line":"            metavar\u003d\u0027\u003ckey-size\u003e\u0027,"},{"line_number":197,"context_line":"            type\u003dint,"},{"line_number":198,"context_line":"            help\u003d_(\u0027Set the size of the encryption key of this \u0027"},{"line_number":199,"context_line":"                   \u0027volume type (e.g \"128\" or \"256\") (admin only)\u0027),"},{"line_number":200,"context_line":"        )"},{"line_number":201,"context_line":"        parser.add_argument("},{"line_number":202,"context_line":"            \u0027--encryption-control-location\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da4df55a_fc0e948a","line":199,"range":{"start_line":181,"start_character":8,"end_line":199,"end_character":68},"in_reply_to":"da4df55a_a232315d","updated":"2016-12-28 02:03:44.000000000","message":"Yes, choices will nice for users, beside that, I am also plan to make the help/error message more specific in next patch set","commit_id":"7fb13edd232c1cc785b8a7166579a90023427427"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"17961c0e39152411afa05b343d24aa5bd4e39fd9","unresolved":false,"context_lines":[{"line_number":190,"context_line":"            help\u003d_(\u0027Set the notional service where the encryption is \u0027"},{"line_number":191,"context_line":"                   \u0027performed (\"front-end\" or \"back-end\") (admin only) \u0027"},{"line_number":192,"context_line":"                   \u0027(default is \"front-end\" when set encryption \u0027"},{"line_number":193,"context_line":"                   \u0027type with any other \"encryption-*\" option)\u0027),"},{"line_number":194,"context_line":"        )"},{"line_number":195,"context_line":"        return parser"},{"line_number":196,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da4df55a_5e74e266","line":193,"updated":"2016-12-28 16:30:30.000000000","message":"Maybe a nit, but I\u0027m not sure everyone will know what encryption-* means. I think help usage shouldn\u0027t assume technical level.","commit_id":"1a3dc5e3006c808a76b63b86249f66711729a535"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"b7c3262721e99617365e06bb45407ad097e63d86","unresolved":false,"context_lines":[{"line_number":190,"context_line":"            help\u003d_(\u0027Set the notional service where the encryption is \u0027"},{"line_number":191,"context_line":"                   \u0027performed (\"front-end\" or \"back-end\") (admin only) \u0027"},{"line_number":192,"context_line":"                   \u0027(default is \"front-end\" when set encryption \u0027"},{"line_number":193,"context_line":"                   \u0027type with any other \"encryption-*\" option)\u0027),"},{"line_number":194,"context_line":"        )"},{"line_number":195,"context_line":"        return parser"},{"line_number":196,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_0b8d6731","line":193,"in_reply_to":"da4df55a_5e74e266","updated":"2016-12-30 02:51:08.000000000","message":"Yes, agree with this, will modify it, thank you","commit_id":"1a3dc5e3006c808a76b63b86249f66711729a535"}],"openstackclient/volume/v2/volume_type.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"42347775cfc1a5abd70b0e7497d9288ba42a6b04","unresolved":false,"context_lines":[{"line_number":36,"context_line":"            volume_type)"},{"line_number":37,"context_line":"    except Exception:"},{"line_number":38,"context_line":"        # create new encryption type"},{"line_number":39,"context_line":"        LOG.warning(_(\"No exiting encryption type found, creating \""},{"line_number":40,"context_line":"                    \"new encryption type for this volume type ...\"))"},{"line_number":41,"context_line":"        if not parsed_args.encryption_provider:"},{"line_number":42,"context_line":"            msg \u003d _(\"\u0027--encryption-provider\u0027 should be specified whlie \""},{"line_number":43,"context_line":"                    \"creating new encryption type\")"},{"line_number":44,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":45,"context_line":"        else:"},{"line_number":46,"context_line":"            control_location \u003d parsed_args.encryption_control_location"}],"source_content_type":"text/x-python","patch_set":1,"id":"da4df55a_22548151","line":43,"range":{"start_line":39,"start_character":0,"end_line":43,"end_character":51},"updated":"2016-12-27 13:52:46.000000000","message":"same spelling typos as in v1","commit_id":"7fb13edd232c1cc785b8a7166579a90023427427"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"42347775cfc1a5abd70b0e7497d9288ba42a6b04","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        volume_client.volume_encryption_types.update(volume_type, body)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"class CreateVolumeType(command.ShowOne):"},{"line_number":70,"context_line":"    _description \u003d _(\"Create new volume type\")"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def get_parser(self, prog_name):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da4df55a_02de9ddc","line":69,"range":{"start_line":69,"start_character":6,"end_line":69,"end_character":22},"updated":"2016-12-27 13:52:46.000000000","message":"I suppose we could add these to the create command later? and perform the steps in sequence.","commit_id":"7fb13edd232c1cc785b8a7166579a90023427427"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"82edf6ab547a66138e76bd7569c9b7c2d95581ff","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        volume_client.volume_encryption_types.update(volume_type, body)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"class CreateVolumeType(command.ShowOne):"},{"line_number":70,"context_line":"    _description \u003d _(\"Create new volume type\")"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def get_parser(self, prog_name):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da4df55a_9c2ca803","line":69,"range":{"start_line":69,"start_character":6,"end_line":69,"end_character":22},"in_reply_to":"da4df55a_02de9ddc","updated":"2016-12-28 02:03:44.000000000","message":"Yes, of course, we will do it","commit_id":"7fb13edd232c1cc785b8a7166579a90023427427"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"17961c0e39152411afa05b343d24aa5bd4e39fd9","unresolved":false,"context_lines":[{"line_number":286,"context_line":"                   \u0027for this volume type (e.g \"LuksEncryptor\") \u0027"},{"line_number":287,"context_line":"                   \u0027(admin only) (required when first set the \u0027"},{"line_number":288,"context_line":"                   \u0027encryption type information with any other \u0027"},{"line_number":289,"context_line":"                   \u0027\"--encryption-*\" option)\u0027),"},{"line_number":290,"context_line":"        )"},{"line_number":291,"context_line":"        parser.add_argument("},{"line_number":292,"context_line":"            \u0027--encryption-cipher\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"da4df55a_1e0dfae7","line":289,"updated":"2016-12-28 16:30:30.000000000","message":"Same comment from v1","commit_id":"1a3dc5e3006c808a76b63b86249f66711729a535"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"17961c0e39152411afa05b343d24aa5bd4e39fd9","unresolved":false,"context_lines":[{"line_number":308,"context_line":"            help\u003d_(\u0027Set the notional service where the encryption is \u0027"},{"line_number":309,"context_line":"                   \u0027performed (\"front-end\" or \"back-end\") (admin only) \u0027"},{"line_number":310,"context_line":"                   \u0027(default is \"front-end\" when first set encryption \u0027"},{"line_number":311,"context_line":"                   \u0027type with any other \"encryption-*\" option)\u0027),"},{"line_number":312,"context_line":"        )"},{"line_number":313,"context_line":"        return parser"},{"line_number":314,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da4df55a_befeaeab","line":311,"updated":"2016-12-28 16:30:30.000000000","message":"same comment from v1","commit_id":"1a3dc5e3006c808a76b63b86249f66711729a535"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"6d8012d2b593e994ad3be13e60bf3a8c0dde855f","unresolved":false,"context_lines":[{"line_number":29,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def _create_encryption_type(volume_client, volume_type, parsed_args):"},{"line_number":33,"context_line":"    if not parsed_args.encryption_provider:"},{"line_number":34,"context_line":"        msg \u003d _(\"\u0027--encryption-provider\u0027 should be specified while \""},{"line_number":35,"context_line":"                \"creating a new encryption type\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5201f7_87971539","line":32,"updated":"2017-01-04 21:51:19.000000000","message":"I do not see a reason to factor these out from the take_action() methods.  There is no sharing happening, it just moved the logic away from the rest of the command.","commit_id":"772266699cbad349e098f02e2d262e213128952c"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"876bff879e21f05059c3d6082949a8e0f4c37251","unresolved":false,"context_lines":[{"line_number":29,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def _create_encryption_type(volume_client, volume_type, parsed_args):"},{"line_number":33,"context_line":"    if not parsed_args.encryption_provider:"},{"line_number":34,"context_line":"        msg \u003d _(\"\u0027--encryption-provider\u0027 should be specified while \""},{"line_number":35,"context_line":"                \"creating a new encryption type\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5201f7_51bc03dc","line":32,"in_reply_to":"ba5201f7_87971539","updated":"2017-01-05 01:42:58.000000000","message":"Actually _create_encryption_type() is shared between create and set command (see line 60 and line 195), and _set_encryption_type() is used only in set, but I think it is a bit long and removing away from take_action() can make the code more easy to read, does it make sense for you?","commit_id":"772266699cbad349e098f02e2d262e213128952c"}]}