)]}'
{"id":"openstack%2Fpython-openstackclient~415301","triplet_id":"openstack%2Fpython-openstackclient~master~I26b85afd646938272dbabe8e045b337b7df58c7d","project":"openstack/python-openstackclient","branch":"master","topic":"bug/1652827","hashtags":[],"change_id":"I26b85afd646938272dbabe8e045b337b7df58c7d","subject":"Fixes image api URL endpoint for certain scenario","status":"MERGED","created":"2016-12-27 22:15:53.000000000","updated":"2017-01-04 23:05:24.000000000","submitted":"2017-01-04 23:05:24.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"db0c2f8ba6a668cf6a646f3327021d3c7618a689","_number":415301,"virtual_id_number":415301,"owner":{"_account_id":10594,"name":"Imtiaz Chowdhury","email":"imtiaz.chowdhury@workday.com","username":"imtiaz"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},{"value":0,"_account_id":16097,"name":"Sergio de Carvalho","email":"sergio.carvalho@workday.com","username":"scarvalhojr"},{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":10594,"name":"Imtiaz Chowdhury","email":"imtiaz.chowdhury@workday.com","username":"imtiaz"},{"value":2,"date":"2017-01-04 23:05:24.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":20294,"name":"Kyle Jorgensen","email":"kyle.jorgensen@workday.com","username":"kyle.jorgensen"},{"value":0,"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":0,"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},{"value":0,"_account_id":16097,"name":"Sergio de Carvalho","email":"sergio.carvalho@workday.com","username":"scarvalhojr"},{"value":2,"date":"2017-01-04 18:14:35.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":10594,"name":"Imtiaz Chowdhury","email":"imtiaz.chowdhury@workday.com","username":"imtiaz"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":20294,"name":"Kyle Jorgensen","email":"kyle.jorgensen@workday.com","username":"kyle.jorgensen"},{"value":0,"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},{"value":2,"date":"2017-01-04 21:39:06.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},{"value":0,"_account_id":16097,"name":"Sergio de Carvalho","email":"sergio.carvalho@workday.com","username":"scarvalhojr"},{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":10594,"name":"Imtiaz Chowdhury","email":"imtiaz.chowdhury@workday.com","username":"imtiaz"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":20294,"name":"Kyle Jorgensen","email":"kyle.jorgensen@workday.com","username":"kyle.jorgensen"},{"value":0,"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},{"value":1,"date":"2017-01-04 21:39:06.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},{"_account_id":10594,"name":"Imtiaz Chowdhury","email":"imtiaz.chowdhury@workday.com","username":"imtiaz"},{"_account_id":16097,"name":"Sergio de Carvalho","email":"sergio.carvalho@workday.com","username":"scarvalhojr"},{"_account_id":20294,"name":"Kyle Jorgensen","email":"kyle.jorgensen@workday.com","username":"kyle.jorgensen"},{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-12-27 22:45:39.000000000","updated_by":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"reviewer":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"state":"REVIEWER"},{"updated":"2016-12-28 10:45:24.000000000","updated_by":{"_account_id":16097,"name":"Sergio de Carvalho","email":"sergio.carvalho@workday.com","username":"scarvalhojr"},"reviewer":{"_account_id":16097,"name":"Sergio de Carvalho","email":"sergio.carvalho@workday.com","username":"scarvalhojr"},"state":"REVIEWER"},{"updated":"2016-12-28 13:18:06.000000000","updated_by":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"reviewer":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"state":"REVIEWER"},{"updated":"2016-12-29 17:51:48.000000000","updated_by":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"reviewer":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"state":"REVIEWER"},{"updated":"2017-01-04 17:53:23.000000000","updated_by":{"_account_id":20294,"name":"Kyle Jorgensen","email":"kyle.jorgensen@workday.com","username":"kyle.jorgensen"},"reviewer":{"_account_id":20294,"name":"Kyle Jorgensen","email":"kyle.jorgensen@workday.com","username":"kyle.jorgensen"},"state":"REVIEWER"},{"updated":"2017-01-04 18:14:35.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2017-01-04 21:39:06.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2017-01-04 23:05:24.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"1cc5aba00a6f2ab0eadcae15a3c05bdd75b01617","author":{"_account_id":10594,"name":"Imtiaz Chowdhury","email":"imtiaz.chowdhury@workday.com","username":"imtiaz"},"date":"2016-12-27 22:15:53.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f891eff6110dca21ac9fa2cb060293c85958e749","author":{"_account_id":10594,"name":"Imtiaz Chowdhury","email":"imtiaz.chowdhury@workday.com","username":"imtiaz"},"date":"2016-12-27 22:43:39.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"157028b5a7a7f231d4199ee24dac0807de7fc1ed","author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"date":"2016-12-27 22:45:39.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"eff17c0192a3daea8bd7f0ca9a1a28ae2b07b878","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-12-27 23:55:09.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/01/415301/2/check/gate-python-openstackclient-docs-ubuntu-xenial/8c8fd60//doc/build/html/ : SUCCESS in 2m 50s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/01/415301/2/check/gate-python-openstackclient-pep8-ubuntu-xenial/2b8d183/ : SUCCESS in 5m 37s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/01/415301/2/check/gate-python-openstackclient-python27-ubuntu-xenial/2cf0052/ : SUCCESS in 3m 18s\n- gate-python-openstackclient-python35 http://logs.openstack.org/01/415301/2/check/gate-python-openstackclient-python35/28febca/ : SUCCESS in 4m 47s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial http://logs.openstack.org/01/415301/2/check/gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial/d972e27/ : SUCCESS in 53m 44s\n- check-osc-plugins http://logs.openstack.org/01/415301/2/check/check-osc-plugins/24a5d17/ : SUCCESS in 5m 48s (non-voting)\n- gate-osc-dsvm-functional-ubuntu-xenial http://logs.openstack.org/01/415301/2/check/gate-osc-dsvm-functional-ubuntu-xenial/6fd64d9/ : SUCCESS in 30m 32s\n- gate-tripleo-ci-centos-7-nonha-multinode-nv http://logs.openstack.org/01/415301/2/check/gate-tripleo-ci-centos-7-nonha-multinode-nv/5f08f2c/ : SUCCESS in 1h 04m 18s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"1ce854fd19765aa50bb05115e499520395fbd217","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-12-28 00:48:12.000000000","message":"Patch Set 2: Code-Review+2\n\nlgtm, does the same thing but under more strict conditions","accounts_in_message":[],"_revision_number":2},{"id":"492fbb5f3075031d2e269e2877d595a1741eb6b8","author":{"_account_id":16097,"name":"Sergio de Carvalho","email":"sergio.carvalho@workday.com","username":"scarvalhojr"},"date":"2016-12-28 10:45:24.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"bccb06d23e4a88b4e97d9f3cfceaf0cadbe3ef1f","author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"date":"2016-12-28 13:18:06.000000000","message":"Patch Set 2:\n\nThis kind of patch would is a good fit for unit tests :)","accounts_in_message":[],"_revision_number":2},{"id":"90af8697962d2bae527cb9f27c859072b4f64dcb","author":{"_account_id":10594,"name":"Imtiaz Chowdhury","email":"imtiaz.chowdhury@workday.com","username":"imtiaz"},"date":"2016-12-28 19:04:18.000000000","message":"Patch Set 3: Patch Set 2 was rebased","accounts_in_message":[],"_revision_number":2},{"id":"b6b082236a08b6894505072f44ce4cb5336d477b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-12-28 20:17:54.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/01/415301/3/check/gate-python-openstackclient-docs-ubuntu-xenial/8a22b1a//doc/build/html/ : SUCCESS in 2m 54s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/01/415301/3/check/gate-python-openstackclient-pep8-ubuntu-xenial/7cc588a/ : SUCCESS in 3m 09s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/01/415301/3/check/gate-python-openstackclient-python27-ubuntu-xenial/0e9224f/ : SUCCESS in 2m 42s\n- gate-python-openstackclient-python35 http://logs.openstack.org/01/415301/3/check/gate-python-openstackclient-python35/3b1b804/ : SUCCESS in 2m 46s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial http://logs.openstack.org/01/415301/3/check/gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial/b853543/ : SUCCESS in 54m 33s\n- check-osc-plugins http://logs.openstack.org/01/415301/3/check/check-osc-plugins/1b6ad36/ : SUCCESS in 3m 38s (non-voting)\n- gate-osc-dsvm-functional-ubuntu-xenial http://logs.openstack.org/01/415301/3/check/gate-osc-dsvm-functional-ubuntu-xenial/94003b3/ : SUCCESS in 28m 55s\n- gate-tripleo-ci-centos-7-nonha-multinode-nv http://logs.openstack.org/01/415301/3/check/gate-tripleo-ci-centos-7-nonha-multinode-nv/26a7246/ : SUCCESS in 1h 13m 23s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"5ff94d2627fb70b8ed7c1afb5444515e175621bb","author":{"_account_id":10594,"name":"Imtiaz Chowdhury","email":"imtiaz.chowdhury@workday.com","username":"imtiaz"},"date":"2016-12-29 17:52:02.000000000","message":"Patch Set 4: Patch Set 3 was rebased","accounts_in_message":[],"_revision_number":3},{"id":"2d81d2faddfe7bc4a16006fda4019bb63098131b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-12-29 19:19:42.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/01/415301/4/check/gate-python-openstackclient-docs-ubuntu-xenial/a71663e//doc/build/html/ : SUCCESS in 5m 12s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/01/415301/4/check/gate-python-openstackclient-pep8-ubuntu-xenial/bf649f1/ : SUCCESS in 3m 05s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/01/415301/4/check/gate-python-openstackclient-python27-ubuntu-xenial/998705f/ : SUCCESS in 2m 39s\n- gate-python-openstackclient-python35 http://logs.openstack.org/01/415301/4/check/gate-python-openstackclient-python35/692167b/ : SUCCESS in 4m 58s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial http://logs.openstack.org/01/415301/4/check/gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial/877848e/ : SUCCESS in 1h 27m 27s\n- check-osc-plugins http://logs.openstack.org/01/415301/4/check/check-osc-plugins/7dd44ec/ : SUCCESS in 7m 01s (non-voting)\n- gate-osc-dsvm-functional-ubuntu-xenial http://logs.openstack.org/01/415301/4/check/gate-osc-dsvm-functional-ubuntu-xenial/9f79520/ : SUCCESS in 29m 26s\n- gate-tripleo-ci-centos-7-nonha-multinode-nv http://logs.openstack.org/01/415301/4/check/gate-tripleo-ci-centos-7-nonha-multinode-nv/096dac9/ : SUCCESS in 1h 09m 12s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"668fa04c5defc883dd8ea5791f63ff173de286b6","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2016-12-29 20:27:05.000000000","message":"Patch Set 4: Code-Review-1\n\nAgree with Jordan here, this is not an innocuous change.  I\u0027d like to see tests for the specific cases where this blows up in the real world at least...","accounts_in_message":[],"_revision_number":4},{"id":"f361e4f49537f91c9e8f3a1f3bdcbd448f31b872","author":{"_account_id":10594,"name":"Imtiaz Chowdhury","email":"imtiaz.chowdhury@workday.com","username":"imtiaz"},"date":"2017-01-04 01:04:58.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"2f6e4712e457760875eb849d7eae323bcc779874","author":{"_account_id":10594,"name":"Imtiaz Chowdhury","email":"imtiaz.chowdhury@workday.com","username":"imtiaz"},"date":"2017-01-04 01:09:20.000000000","message":"Patch Set 5:\n\n@dean.troyer - this issue was discovered in a real production system. I have updated the unit test to reflect that. I hope this latest patch addresses your concern.","accounts_in_message":[],"_revision_number":5},{"id":"225bfc6963018eeeb4bf89f2069864879e0f8bd3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-01-04 02:02:24.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/01/415301/5/check/gate-python-openstackclient-docs-ubuntu-xenial/1d9b444//doc/build/html/ : SUCCESS in 2m 56s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/01/415301/5/check/gate-python-openstackclient-pep8-ubuntu-xenial/ede8e2d/ : SUCCESS in 6m 55s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/01/415301/5/check/gate-python-openstackclient-python27-ubuntu-xenial/62ebec3/ : SUCCESS in 4m 33s\n- gate-python-openstackclient-python35 http://logs.openstack.org/01/415301/5/check/gate-python-openstackclient-python35/db429a9/ : SUCCESS in 5m 06s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial http://logs.openstack.org/01/415301/5/check/gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial/11b948b/ : SUCCESS in 55m 11s\n- check-osc-plugins http://logs.openstack.org/01/415301/5/check/check-osc-plugins/ad71e26/ : SUCCESS in 5m 46s (non-voting)\n- gate-osc-dsvm-functional-ubuntu-xenial http://logs.openstack.org/01/415301/5/check/gate-osc-dsvm-functional-ubuntu-xenial/b049c4b/ : SUCCESS in 29m 26s\n- gate-tripleo-ci-centos-7-nonha-multinode-nv http://logs.openstack.org/01/415301/5/check/gate-tripleo-ci-centos-7-nonha-multinode-nv/bc51855/ : SUCCESS in 45m 36s (non-voting)","accounts_in_message":[],"_revision_number":5},{"id":"3a2c2c582c5ada190237d5ac8ba0cb9589213f14","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2017-01-04 02:25:44.000000000","message":"Patch Set 5: Code-Review-1\n\nPlease add a test for the auth_url ending in /v2.0, which is what has been commonly used in deployments.\n\nHold that, I am going to add a couple of specific tests for real world configurations first, then you can decide how you want to change it to pass that test.","accounts_in_message":[],"_revision_number":5},{"id":"a1af2f9d5b1d732999a096f2d2750927b1c849f6","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2017-01-04 02:51:30.000000000","message":"Patch Set 5:\n\n(1 comment)\n\nOK, good grief, ignore the part about auth_url, for some reason I had Identity on my brain not Image. My apologies for the hasty comment before trying it myself.\n\nSo I can live with the change, I managed to prove to myself that the case I was worried about is a \u0027don\u0027t care\u0027 for us.\n\nHowever, please make the v1 code match, but use _endpoint_suffix in both.","accounts_in_message":[],"_revision_number":5},{"id":"ade7644da57339eb1c424b75433fecfaaf2ae3ce","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2017-01-04 03:30:07.000000000","message":"Patch Set 5: Code-Review-1\n\nas dtroyer mentioned, it needs to be added to v1 as well: https://github.com/openstack/python-openstackclient/blob/master/openstackclient/api/image_v1.py#L30-L33","accounts_in_message":[],"_revision_number":5},{"id":"737c3b23a8cb68c734bb69405a4593231750278e","author":{"_account_id":10594,"name":"Imtiaz Chowdhury","email":"imtiaz.chowdhury@workday.com","username":"imtiaz"},"date":"2017-01-04 16:59:10.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"cf89a36e40e57eee50069e016e3ca4f65cdbbcb5","author":{"_account_id":20294,"name":"Kyle Jorgensen","email":"kyle.jorgensen@workday.com","username":"kyle.jorgensen"},"date":"2017-01-04 17:53:23.000000000","message":"Patch Set 6: Code-Review+1","accounts_in_message":[],"_revision_number":6},{"id":"5886cc9fcec4134999460a47378dcf219cc4cf70","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2017-01-04 18:10:22.000000000","message":"Patch Set 6: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"3e1a4206d0a6434cc99d3b5d452029b512247863","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-01-04 18:12:44.000000000","message":"Patch Set 6: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/01/415301/6/check/gate-python-openstackclient-docs-ubuntu-xenial/34162ab//doc/build/html/ : SUCCESS in 3m 30s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/01/415301/6/check/gate-python-openstackclient-pep8-ubuntu-xenial/9854381/ : FAILURE in 3m 24s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/01/415301/6/check/gate-python-openstackclient-python27-ubuntu-xenial/b0e921c/ : SUCCESS in 2m 56s\n- gate-python-openstackclient-python35 http://logs.openstack.org/01/415301/6/check/gate-python-openstackclient-python35/15ba344/ : SUCCESS in 5m 03s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial http://logs.openstack.org/01/415301/6/check/gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial/329996b/ : SUCCESS in 1h 12m 04s\n- check-osc-plugins http://logs.openstack.org/01/415301/6/check/check-osc-plugins/687d607/ : SUCCESS in 4m 08s (non-voting)\n- gate-osc-dsvm-functional-ubuntu-xenial http://logs.openstack.org/01/415301/6/check/gate-osc-dsvm-functional-ubuntu-xenial/eb0ec85/ : SUCCESS in 45m 48s\n- gate-tripleo-ci-centos-7-nonha-multinode-nv http://logs.openstack.org/01/415301/6/check/gate-tripleo-ci-centos-7-nonha-multinode-nv/6913dd1/ : SUCCESS in 48m 17s (non-voting)","accounts_in_message":[],"_revision_number":6},{"id":"757ac8d995d04f87c7928d778d9c0c5c1ec8e5f4","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2017-01-04 18:14:13.000000000","message":"Patch Set 7: Published edit on patch set 6","accounts_in_message":[],"_revision_number":7},{"id":"c55c64b0d87b51d3398116299862a1eb8c5278cb","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2017-01-04 18:14:35.000000000","message":"Patch Set 7: Code-Review+2\n\nfixed pep8 error and addressed dtroyers comment","accounts_in_message":[],"_revision_number":7},{"id":"cb03cb87e992955a65a0bb4ec140f89ee34fa1de","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-01-04 19:13:58.000000000","message":"Patch Set 7: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/01/415301/7/check/gate-python-openstackclient-docs-ubuntu-xenial/c193e87//doc/build/html/ : SUCCESS in 4m 33s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/01/415301/7/check/gate-python-openstackclient-pep8-ubuntu-xenial/a538d14/ : SUCCESS in 8m 03s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/01/415301/7/check/gate-python-openstackclient-python27-ubuntu-xenial/e6a51cf/ : SUCCESS in 4m 33s\n- gate-python-openstackclient-python35 http://logs.openstack.org/01/415301/7/check/gate-python-openstackclient-python35/ec2b3e3/ : SUCCESS in 3m 39s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial http://logs.openstack.org/01/415301/7/check/gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial/6da0a93/ : SUCCESS in 57m 17s\n- check-osc-plugins http://logs.openstack.org/01/415301/7/check/check-osc-plugins/9c007d8/ : SUCCESS in 3m 59s (non-voting)\n- gate-osc-dsvm-functional-ubuntu-xenial http://logs.openstack.org/01/415301/7/check/gate-osc-dsvm-functional-ubuntu-xenial/2b768db/ : SUCCESS in 33m 34s\n- gate-tripleo-ci-centos-7-nonha-multinode-nv http://logs.openstack.org/01/415301/7/check/gate-tripleo-ci-centos-7-nonha-multinode-nv/e175f34/ : SUCCESS in 48m 10s (non-voting)","accounts_in_message":[],"_revision_number":7},{"id":"5d29b765f4a5d0b7231a47d0a8b919f36e78c984","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2017-01-04 21:39:06.000000000","message":"Patch Set 7: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":7},{"id":"efc848ffb0aaef701f4f6bf42451584d3d3598b2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-01-04 21:39:19.000000000","message":"Patch Set 7: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":7},{"id":"5c786e9311964d3dd6d865ca041f0adc903fb1c5","date":"2017-01-04 23:05:24.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":7},{"id":"7dbdd67ec6c2c76b13b61eff251ab3aab87917a0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-01-04 23:05:24.000000000","message":"Patch Set 7: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/01/415301/7/gate/gate-python-openstackclient-docs-ubuntu-xenial/c213fa3//doc/build/html/ : SUCCESS in 5m 18s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/01/415301/7/gate/gate-python-openstackclient-pep8-ubuntu-xenial/d05ea9d/ : SUCCESS in 3m 10s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/01/415301/7/gate/gate-python-openstackclient-python27-ubuntu-xenial/7c0716a/ : SUCCESS in 5m 18s\n- gate-python-openstackclient-python35 http://logs.openstack.org/01/415301/7/gate/gate-python-openstackclient-python35/5020cc7/ : SUCCESS in 2m 59s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial http://logs.openstack.org/01/415301/7/gate/gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial/670fa12/ : SUCCESS in 1h 25m 30s\n- gate-osc-dsvm-functional-ubuntu-xenial http://logs.openstack.org/01/415301/7/gate/gate-osc-dsvm-functional-ubuntu-xenial/9b16d40/ : SUCCESS in 1h 04m 59s","accounts_in_message":[],"_revision_number":7}],"current_revision_number":7,"current_revision":"1bd2bf67dab86bce06da89db65f2b532edf8e35e","revisions":{"5b6cb4e8127b53f43248fc3237882163dd8ba293":{"kind":"REWORK","_number":1,"created":"2016-12-27 22:15:53.000000000","uploader":{"_account_id":10594,"name":"Imtiaz Chowdhury","email":"imtiaz.chowdhury@workday.com","username":"imtiaz"},"ref":"refs/changes/01/415301/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/01/415301/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/01/415301/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/01/415301/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/01/415301/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/01/415301/1"}}},"commit":{"parents":[{"commit":"05fbd076e494add11daeef77d873c91eeaf037bb","subject":"Merge \"Add unit tests for usage commands in compute v2\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/05fbd076e494add11daeef77d873c91eeaf037bb"}]}],"author":{"name":"Imtiaz Chowdhury","email":"imtiaz.chowdhury@workday.com","date":"2016-12-27 22:04:29.000000000","tz":-480},"committer":{"name":"Imtiaz Chowdhury","email":"imtiaz.chowdhury@workday.com","date":"2016-12-27 22:15:53.000000000","tz":-480},"subject":"Fixes image api URL endpoint for certain scenario","message":"Fixes image api URL endpoint for certain scenario\n\nopenstackclient fails to get image list when the image api endpoint\nhas \u0027v2\u0027 substring in it. Instead of checking whether the api\nendpoint URL terminates with \u0027/v2\u0027, the current logic is checking\nwhether \u0027v2\u0027 appears anywhere in the endpoint string.\nThis commit addresses this issue.\n\nChange-Id: I26b85afd646938272dbabe8e045b337b7df58c7d\nCloses-Bug: 1652827\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/5b6cb4e8127b53f43248fc3237882163dd8ba293"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/5b6cb4e8127b53f43248fc3237882163dd8ba293"}]},"branch":"refs/heads/master"},"47ab9ba04db21976c22f6341a865b11c0ace861c":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2016-12-27 22:43:39.000000000","uploader":{"_account_id":10594,"name":"Imtiaz Chowdhury","email":"imtiaz.chowdhury@workday.com","username":"imtiaz"},"ref":"refs/changes/01/415301/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/01/415301/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/01/415301/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/01/415301/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/01/415301/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/01/415301/2"}}},"commit":{"parents":[{"commit":"05fbd076e494add11daeef77d873c91eeaf037bb","subject":"Merge \"Add unit tests for usage commands in compute v2\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/05fbd076e494add11daeef77d873c91eeaf037bb"}]}],"author":{"name":"Imtiaz Chowdhury","email":"imtiaz.chowdhury@workday.com","date":"2016-12-27 22:04:29.000000000","tz":-480},"committer":{"name":"Imtiaz Chowdhury","email":"imtiaz.chowdhury@workday.com","date":"2016-12-27 22:41:44.000000000","tz":-480},"subject":"Fixes image api URL endpoint for certain scenario","message":"Fixes image api URL endpoint for certain scenario\n\nopenstackclient fails to get image list when the image api endpoint\nhas \u0027v2\u0027 substring in it. Instead of checking whether the api\nendpoint URL terminates with \u0027/v2\u0027, the current logic is checking\nwhether \u0027v2\u0027 appears anywhere in the endpoint string.\nThis commit addresses this issue.\n\nCo-Authored-By: sergio.carvalho@workday.com\nChange-Id: I26b85afd646938272dbabe8e045b337b7df58c7d\nCloses-Bug: 1652827\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/47ab9ba04db21976c22f6341a865b11c0ace861c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/47ab9ba04db21976c22f6341a865b11c0ace861c"}]},"branch":"refs/heads/master"},"cb878362b3105abce02057e7941f703f7fbb1703":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2016-12-28 19:04:18.000000000","uploader":{"_account_id":10594,"name":"Imtiaz Chowdhury","email":"imtiaz.chowdhury@workday.com","username":"imtiaz"},"ref":"refs/changes/01/415301/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/01/415301/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/01/415301/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/01/415301/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/01/415301/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/01/415301/3"}}},"commit":{"parents":[{"commit":"317cbe2c6e5879f9ed1540313ef77215b464c75c","subject":"Merge \"Fix a spelling error\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/317cbe2c6e5879f9ed1540313ef77215b464c75c"}]}],"author":{"name":"Imtiaz Chowdhury","email":"imtiaz.chowdhury@workday.com","date":"2016-12-27 22:04:29.000000000","tz":-480},"committer":{"name":"Imtiaz Chowdhury","email":"imtiaz.chowdhury@workday.com","date":"2016-12-28 19:04:18.000000000","tz":0},"subject":"Fixes image api URL endpoint for certain scenario","message":"Fixes image api URL endpoint for certain scenario\n\nopenstackclient fails to get image list when the image api endpoint\nhas \u0027v2\u0027 substring in it. Instead of checking whether the api\nendpoint URL terminates with \u0027/v2\u0027, the current logic is checking\nwhether \u0027v2\u0027 appears anywhere in the endpoint string.\nThis commit addresses this issue.\n\nCo-Authored-By: sergio.carvalho@workday.com\nChange-Id: I26b85afd646938272dbabe8e045b337b7df58c7d\nCloses-Bug: 1652827\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/cb878362b3105abce02057e7941f703f7fbb1703"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/cb878362b3105abce02057e7941f703f7fbb1703"}]},"branch":"refs/heads/master"},"cfb4420083f7b3a95a8002f90b6c7c37364ed246":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2016-12-29 17:52:02.000000000","uploader":{"_account_id":10594,"name":"Imtiaz Chowdhury","email":"imtiaz.chowdhury@workday.com","username":"imtiaz"},"ref":"refs/changes/01/415301/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/01/415301/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/01/415301/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/01/415301/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/01/415301/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/01/415301/4"}}},"commit":{"parents":[{"commit":"17a249c5ddc22403486f32575e91da7db10ff8e2","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/17a249c5ddc22403486f32575e91da7db10ff8e2"}]}],"author":{"name":"Imtiaz Chowdhury","email":"imtiaz.chowdhury@workday.com","date":"2016-12-27 22:04:29.000000000","tz":-480},"committer":{"name":"Imtiaz Chowdhury","email":"imtiaz.chowdhury@workday.com","date":"2016-12-29 17:52:02.000000000","tz":0},"subject":"Fixes image api URL endpoint for certain scenario","message":"Fixes image api URL endpoint for certain scenario\n\nopenstackclient fails to get image list when the image api endpoint\nhas \u0027v2\u0027 substring in it. Instead of checking whether the api\nendpoint URL terminates with \u0027/v2\u0027, the current logic is checking\nwhether \u0027v2\u0027 appears anywhere in the endpoint string.\nThis commit addresses this issue.\n\nCo-Authored-By: sergio.carvalho@workday.com\nChange-Id: I26b85afd646938272dbabe8e045b337b7df58c7d\nCloses-Bug: 1652827\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/cfb4420083f7b3a95a8002f90b6c7c37364ed246"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/cfb4420083f7b3a95a8002f90b6c7c37364ed246"}]},"branch":"refs/heads/master"},"4e5a9b8e10e5ab62ae6942d6dfdd8af085e4c19f":{"kind":"REWORK","_number":5,"created":"2017-01-04 01:04:58.000000000","uploader":{"_account_id":10594,"name":"Imtiaz Chowdhury","email":"imtiaz.chowdhury@workday.com","username":"imtiaz"},"ref":"refs/changes/01/415301/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/01/415301/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/01/415301/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/01/415301/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/01/415301/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/01/415301/5"}}},"commit":{"parents":[{"commit":"0948aa6aeb573900bb8b80b0d0b1f91202222715","subject":"update server migrate \u0027--wait\u0027 description","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/0948aa6aeb573900bb8b80b0d0b1f91202222715"}]}],"author":{"name":"Imtiaz Chowdhury","email":"imtiaz.chowdhury@workday.com","date":"2016-12-27 22:04:29.000000000","tz":-480},"committer":{"name":"Imtiaz Chowdhury","email":"imtiaz.chowdhury@workday.com","date":"2017-01-04 00:58:04.000000000","tz":-480},"subject":"Fixes image api URL endpoint for certain scenario","message":"Fixes image api URL endpoint for certain scenario\n\nopenstackclient fails to get image list when the image api endpoint\nhas \u0027v2\u0027 substring in the URL. Instead of checking whether the api\nendpoint URL terminates with \u0027/v2\u0027, the current logic is checking\nwhether \u0027v2\u0027 appears anywhere in the endpoint string.\n\nThis issue was discovered on a production setup where certain\nserver names had \u0027v2\u0027 in their names. For example, when a hostname\nis gopher.dev20.com, the image list APIs fail.\n\nThis commit updates the unit test to reflect this scenario. Without\nthe change in openstackclient/api/image_v2.py, all the unit tests\nfail.\n\nCo-Authored-By: sergio.carvalho@workday.com\nChange-Id: I26b85afd646938272dbabe8e045b337b7df58c7d\nCloses-Bug: 1652827\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/4e5a9b8e10e5ab62ae6942d6dfdd8af085e4c19f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/4e5a9b8e10e5ab62ae6942d6dfdd8af085e4c19f"}]},"branch":"refs/heads/master"},"d13b4d6e17871ae66f10351dafaa99b5f220b4fd":{"kind":"REWORK","_number":6,"created":"2017-01-04 16:59:10.000000000","uploader":{"_account_id":10594,"name":"Imtiaz Chowdhury","email":"imtiaz.chowdhury@workday.com","username":"imtiaz"},"ref":"refs/changes/01/415301/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/01/415301/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/01/415301/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/01/415301/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/01/415301/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/01/415301/6"}}},"commit":{"parents":[{"commit":"e6e3cd295ceadadaf7e85a719dc9545157c16e41","subject":"Merge \"Beef up address scope functional tests\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/e6e3cd295ceadadaf7e85a719dc9545157c16e41"}]}],"author":{"name":"Imtiaz Chowdhury","email":"imtiaz.chowdhury@workday.com","date":"2016-12-27 22:04:29.000000000","tz":-480},"committer":{"name":"Imtiaz Chowdhury","email":"imtiaz.chowdhury@workday.com","date":"2017-01-04 16:58:06.000000000","tz":-480},"subject":"Fixes image api URL endpoint for certain scenario","message":"Fixes image api URL endpoint for certain scenario\n\nopenstackclient fails to get image list when the image api endpoint\nhas \u0027v2\u0027 substring in the URL. Instead of checking whether the api\nendpoint URL terminates with \u0027/v2\u0027, the current logic is checking\nwhether \u0027v2\u0027 appears anywhere in the endpoint string.\n\nThis issue was discovered on a production setup where certain\nserver names had \u0027v2\u0027 in their names. For example, when a hostname\nis gopher.dev20.com, the image list APIs fail.\n\nThis commit updates the unit test to reflect this scenario. Without\nthe change in openstackclient/api/image_v2.py, all the unit tests\nfail.\n\nCo-Authored-By: sergio.carvalho@workday.com\nChange-Id: I26b85afd646938272dbabe8e045b337b7df58c7d\nCloses-Bug: 1652827\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/d13b4d6e17871ae66f10351dafaa99b5f220b4fd"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/d13b4d6e17871ae66f10351dafaa99b5f220b4fd"}]},"branch":"refs/heads/master"},"1bd2bf67dab86bce06da89db65f2b532edf8e35e":{"kind":"REWORK","_number":7,"created":"2017-01-04 18:14:13.000000000","uploader":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"ref":"refs/changes/01/415301/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/01/415301/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/01/415301/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/01/415301/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/01/415301/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/01/415301/7"}}},"commit":{"parents":[{"commit":"e6e3cd295ceadadaf7e85a719dc9545157c16e41","subject":"Merge \"Beef up address scope functional tests\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/e6e3cd295ceadadaf7e85a719dc9545157c16e41"}]}],"author":{"name":"Imtiaz Chowdhury","email":"imtiaz.chowdhury@workday.com","date":"2016-12-27 22:04:29.000000000","tz":-480},"committer":{"name":"Steve Martinelli","email":"s.martinelli@gmail.com","date":"2017-01-04 18:14:10.000000000","tz":0},"subject":"Fixes image api URL endpoint for certain scenario","message":"Fixes image api URL endpoint for certain scenario\n\nopenstackclient fails to get image list when the image api endpoint\nhas \u0027v2\u0027 substring in the URL. Instead of checking whether the api\nendpoint URL terminates with \u0027/v2\u0027, the current logic is checking\nwhether \u0027v2\u0027 appears anywhere in the endpoint string.\n\nThis issue was discovered on a production setup where certain\nserver names had \u0027v2\u0027 in their names. For example, when a hostname\nis gopher.dev20.com, the image list APIs fail.\n\nThis commit updates the unit test to reflect this scenario. Without\nthe change in openstackclient/api/image_v2.py, all the unit tests\nfail.\n\nCo-Authored-By: sergio.carvalho@workday.com\nChange-Id: I26b85afd646938272dbabe8e045b337b7df58c7d\nCloses-Bug: 1652827\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/1bd2bf67dab86bce06da89db65f2b532edf8e35e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/1bd2bf67dab86bce06da89db65f2b532edf8e35e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}