)]}'
{"doc/source/command-objects/flavor.rst":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"7e63e24ca4bd383c6d35b7f32a4e605a1b766ec8","unresolved":false,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":".. option:: --no-property"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    Remove all properties from this flavor (specify both --property and --no-property to overwrite the current properties)"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":".. describe:: \u003cflavor\u003e"},{"line_number":171,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"ba5201f7_4a747bfc","line":168,"updated":"2017-01-04 04:10:34.000000000","message":"keep this to about 80 characters (for readability)","commit_id":"11e3f266783529ff3bf264143ee81faad37125e6"},{"author":{"_account_id":24081,"name":"zhiyong.dai","email":"zhiyong.dai@easystack.cn","username":"zhiyong.dai"},"change_message_id":"b72a91b8a6eb17f9bde6373e52115fb0b3941847","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    os flavor set"},{"line_number":147,"context_line":"        [--property \u003ckey\u003dvalue\u003e [...] ]"},{"line_number":148,"context_line":"        [--no-property]"},{"line_number":149,"context_line":"        [--project \u003cproject\u003e]"},{"line_number":150,"context_line":"        [--project-domain \u003cproject-domain\u003e]"},{"line_number":151,"context_line":"        \u003cflavor\u003e"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5a3905b3_4afa7b76","line":148,"range":{"start_line":148,"start_character":8,"end_line":148,"end_character":23},"updated":"2017-01-23 08:03:18.000000000","message":"Move \"--no-property\" above \"--property\" according to the advice given by Dean. You can see in this patch\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003ehttps://review.openstack.org/#/c/416182/","commit_id":"4ee8862fe9f4e3f151e5f79d1aaabe276d863017"},{"author":{"_account_id":24081,"name":"zhiyong.dai","email":"zhiyong.dai@easystack.cn","username":"zhiyong.dai"},"change_message_id":"b72a91b8a6eb17f9bde6373e52115fb0b3941847","unresolved":false,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":".. option:: --no-property"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    Remove all properties from this flavor (specify both --property and "},{"line_number":169,"context_line":"    --no-property to overwrite the current properties)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":".. describe:: \u003cflavor\u003e"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5a3905b3_2ab9af79","line":168,"range":{"start_line":168,"start_character":57,"end_line":168,"end_character":67},"updated":"2017-01-23 08:03:18.000000000","message":"You can add formatting. :option:`--property`","commit_id":"4ee8862fe9f4e3f151e5f79d1aaabe276d863017"},{"author":{"_account_id":24081,"name":"zhiyong.dai","email":"zhiyong.dai@easystack.cn","username":"zhiyong.dai"},"change_message_id":"b72a91b8a6eb17f9bde6373e52115fb0b3941847","unresolved":false,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":".. option:: --no-property"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    Remove all properties from this flavor (specify both --property and "},{"line_number":169,"context_line":"    --no-property to overwrite the current properties)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":".. describe:: \u003cflavor\u003e"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5a3905b3_cabbcbe3","line":168,"range":{"start_line":168,"start_character":71,"end_line":168,"end_character":72},"updated":"2017-01-23 08:03:18.000000000","message":"extra space","commit_id":"4ee8862fe9f4e3f151e5f79d1aaabe276d863017"},{"author":{"_account_id":24081,"name":"zhiyong.dai","email":"zhiyong.dai@easystack.cn","username":"zhiyong.dai"},"change_message_id":"b72a91b8a6eb17f9bde6373e52115fb0b3941847","unresolved":false,"context_lines":[{"line_number":166,"context_line":".. option:: --no-property"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    Remove all properties from this flavor (specify both --property and "},{"line_number":169,"context_line":"    --no-property to overwrite the current properties)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":".. describe:: \u003cflavor\u003e"},{"line_number":172,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"5a3905b3_4a799bc7","line":169,"range":{"start_line":169,"start_character":4,"end_line":169,"end_character":17},"updated":"2017-01-23 08:03:18.000000000","message":"++","commit_id":"4ee8862fe9f4e3f151e5f79d1aaabe276d863017"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"5733d8f1565b988557265730af4c0a884b3dfafe","unresolved":false,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":".. option:: --no-property"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    Remove all properties from this flavor (specify both --no-property and --property"},{"line_number":169,"context_line":"    to remove the current properties before setting new properties.)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":".. describe:: \u003cflavor\u003e"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3a461143_cf19a47b","line":168,"range":{"start_line":168,"start_character":57,"end_line":168,"end_character":85},"updated":"2017-02-02 02:59:37.000000000","message":"nit: we could add format for options in doc by \":option:`--xxx`\"","commit_id":"63b00422ea65b163bb7642e3928c8610a1434480"}],"openstackclient/compute/v2/flavor.py":[{"author":{"_account_id":24081,"name":"zhiyong.dai","email":"zhiyong.dai@easystack.cn","username":"zhiyong.dai"},"change_message_id":"41fee24021f8b5388e2ed848c117d1fee93a5222","unresolved":false,"context_lines":[{"line_number":345,"context_line":"        result \u003d 0"},{"line_number":346,"context_line":"        if parsed_args.no_property:"},{"line_number":347,"context_line":"            try:"},{"line_number":348,"context_line":"                flavor.set_keys({})"},{"line_number":349,"context_line":"            except Exception as e:"},{"line_number":350,"context_line":"                LOG.error(_(\"Failed to clear flavor property: %s\"), e)"},{"line_number":351,"context_line":"                result +\u003d 1"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_81ef8aaf","line":348,"range":{"start_line":348,"start_character":16,"end_line":348,"end_character":35},"updated":"2017-01-19 03:29:48.000000000","message":"This will not clean the properties which already in flavor. You need to find the existing property.  Maybe you can try \n\"       key_list \u003d []\n        if parsed_args.no_property:\n            for key in flavor.get_keys().keys():\n                key_list.append(key)\n            flavor.unset_keys(key_list)     \"","commit_id":"11e3f266783529ff3bf264143ee81faad37125e6"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"ed1c128b1c4319efe307e24639c3137cb337d77d","unresolved":false,"context_lines":[{"line_number":345,"context_line":"        result \u003d 0"},{"line_number":346,"context_line":"        if parsed_args.no_property:"},{"line_number":347,"context_line":"            try:"},{"line_number":348,"context_line":"                flavor.set_keys({})"},{"line_number":349,"context_line":"            except Exception as e:"},{"line_number":350,"context_line":"                LOG.error(_(\"Failed to clear flavor property: %s\"), e)"},{"line_number":351,"context_line":"                result +\u003d 1"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_f6152849","line":348,"range":{"start_line":348,"start_character":16,"end_line":348,"end_character":35},"in_reply_to":"5a3905b3_81ef8aaf","updated":"2017-01-20 08:59:11.000000000","message":"Done","commit_id":"11e3f266783529ff3bf264143ee81faad37125e6"},{"author":{"_account_id":24081,"name":"zhiyong.dai","email":"zhiyong.dai@easystack.cn","username":"zhiyong.dai"},"change_message_id":"b72a91b8a6eb17f9bde6373e52115fb0b3941847","unresolved":false,"context_lines":[{"line_number":320,"context_line":"                   \"(repeat option to set multiple properties)\")"},{"line_number":321,"context_line":"        )"},{"line_number":322,"context_line":"        parser.add_argument("},{"line_number":323,"context_line":"            \"--no-property\","},{"line_number":324,"context_line":"            action\u003d\"store_true\","},{"line_number":325,"context_line":"            help\u003d_(\"Remove all properties from this flavor \""},{"line_number":326,"context_line":"                   \"(specify both --property and --no-property to \""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_aa44bfb6","line":323,"range":{"start_line":323,"start_character":11,"end_line":323,"end_character":28},"updated":"2017-01-23 08:03:18.000000000","message":"Move \"--no-property\" above \"--property\"","commit_id":"4ee8862fe9f4e3f151e5f79d1aaabe276d863017"},{"author":{"_account_id":24081,"name":"zhiyong.dai","email":"zhiyong.dai@easystack.cn","username":"zhiyong.dai"},"change_message_id":"4f2e99882a17dcb4f1b4a42ce6c9d7598c40ede8","unresolved":false,"context_lines":[{"line_number":323,"context_line":"            \"--no-property\","},{"line_number":324,"context_line":"            action\u003d\"store_true\","},{"line_number":325,"context_line":"            help\u003d_(\"Remove all properties from this flavor \""},{"line_number":326,"context_line":"                   \"(specify both --property and --no-property to \""},{"line_number":327,"context_line":"                   \"overwrite the current properties)\"),"},{"line_number":328,"context_line":"        )"},{"line_number":329,"context_line":"        parser.add_argument("},{"line_number":330,"context_line":"            \u0027--project\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_645db046","line":327,"range":{"start_line":326,"start_character":21,"end_line":327,"end_character":53},"updated":"2017-01-23 07:04:09.000000000","message":"A small advice: make the help massage consistent with that\u003d\u003d\u003d\u003d\u003e https://review.openstack.org/#/c/421160/","commit_id":"4ee8862fe9f4e3f151e5f79d1aaabe276d863017"}],"openstackclient/tests/unit/compute/v2/test_flavor.py":[{"author":{"_account_id":24081,"name":"zhiyong.dai","email":"zhiyong.dai@easystack.cn","username":"zhiyong.dai"},"change_message_id":"b72a91b8a6eb17f9bde6373e52115fb0b3941847","unresolved":false,"context_lines":[{"line_number":543,"context_line":"        result \u003d self.cmd.take_action(parsed_args)"},{"line_number":544,"context_line":"        self.flavors_mock.find.assert_called_with(name\u003dparsed_args.flavor,"},{"line_number":545,"context_line":"                                                  is_public\u003dNone)"},{"line_number":546,"context_line":"        self.flavor.set_keys.assert_not_called()"},{"line_number":547,"context_line":"        self.assertIsNone(result)"},{"line_number":548,"context_line":""},{"line_number":549,"context_line":"    def test_flavor_set_project(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a3905b3_0a24f35d","line":546,"range":{"start_line":546,"start_character":8,"end_line":546,"end_character":48},"updated":"2017-01-23 08:03:18.000000000","message":"unset_keys() is called. So it would be better to add\n\"self.flavor.unset_keys.assert_called_with([\u0027property\u0027])\"\nhere for verification.","commit_id":"4ee8862fe9f4e3f151e5f79d1aaabe276d863017"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"e48fe46c9d3a7bf16c337c040345bd20deec1647","unresolved":false,"context_lines":[{"line_number":528,"context_line":"        self.flavor.set_keys.assert_called_with({\u0027FOO\u0027: \u0027\"B A R\"\u0027})"},{"line_number":529,"context_line":"        self.assertIsNone(result)"},{"line_number":530,"context_line":""},{"line_number":531,"context_line":"    def test_flavor_set_no_property(self):"},{"line_number":532,"context_line":"        arglist \u003d ["},{"line_number":533,"context_line":"            \u0027--no-property\u0027,"},{"line_number":534,"context_line":"            \u0027baremetal\u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a461143_818173fd","line":531,"updated":"2017-01-31 16:16:57.000000000","message":"No tests for just setting, or just removing/unsetting?","commit_id":"350c13307fe3645a6c8b78b6877f6d13c69419bd"}],"releasenotes/notes/add-no-property-f97e4b2f390cec06.yaml":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"7e63e24ca4bd383c6d35b7f32a4e605a1b766ec8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"    features:"},{"line_number":3,"context_line":"    |"},{"line_number":4,"context_line":"    This patch adds the support to clear/overwrite the property of a flavor"},{"line_number":5,"context_line":"    using ``--no-property`` option with ``flavor set`` command"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ba5201f7_6aef7f87","line":2,"range":{"start_line":1,"start_character":0,"end_line":2,"end_character":13},"updated":"2017-01-04 04:10:34.000000000","message":"the indenting is weird here, make sure it follows the convention we use: https://github.com/openstack/python-openstackclient/blob/master/releasenotes/notes/bug-1534202-1ba78f0bb744961f.yaml","commit_id":"11e3f266783529ff3bf264143ee81faad37125e6"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"7e63e24ca4bd383c6d35b7f32a4e605a1b766ec8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"    features:"},{"line_number":3,"context_line":"    |"},{"line_number":4,"context_line":"    This patch adds the support to clear/overwrite the property of a flavor"},{"line_number":5,"context_line":"    using ``--no-property`` option with ``flavor set`` command"},{"line_number":6,"context_line":"    [ Blueprint  `allow-overwrite-set-options \u003chttps://blueprints.launchpad.net/python-openstackclient/+spec/allow-overwrite-set-options\u003e` _]     "}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ba5201f7_2a50175d","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":14},"updated":"2017-01-04 04:10:34.000000000","message":"remove \"this patch\" since the notes are all collected in a single page -- like the following: http://docs.openstack.org/releasenotes/python-openstackclient/unreleased.html#id9","commit_id":"11e3f266783529ff3bf264143ee81faad37125e6"}]}