)]}'
{"id":"openstack%2Fpython-openstackclient~415447","triplet_id":"openstack%2Fpython-openstackclient~master~I5851bfec2752599ce18768d79be9469e3c574588","project":"openstack/python-openstackclient","branch":"master","topic":"project_set_identityV3","hashtags":[],"change_id":"I5851bfec2752599ce18768d79be9469e3c574588","subject":"Modified \"domain\" option in \"project set\"(identityV3)","status":"ABANDONED","created":"2016-12-28 11:36:55.000000000","updated":"2017-01-05 01:40:00.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"68c82fa8f559d4adc20635ac3f35b504a17ab5b8","_number":415447,"virtual_id_number":415447,"owner":{"_account_id":24080,"name":"jiahui.qiang","email":"jiahui.qiang@easystack.cn","username":"qiangjiahui"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"date":"2017-01-04 07:52:11.000000000","_account_id":24080,"name":"jiahui.qiang","email":"jiahui.qiang@easystack.cn","username":"qiangjiahui"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":-1,"date":"2016-12-28 12:46:58.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":24080,"name":"jiahui.qiang","email":"jiahui.qiang@easystack.cn","username":"qiangjiahui"},{"value":-1,"date":"2017-01-02 02:24:59.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":24080,"name":"jiahui.qiang","email":"jiahui.qiang@easystack.cn","username":"qiangjiahui"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":24080,"name":"jiahui.qiang","email":"jiahui.qiang@easystack.cn","username":"qiangjiahui"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-12-28 12:46:58.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2017-01-02 02:24:59.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"}],"messages":[{"id":"01ea8ad16ef29417c5bcb8b88d62e345f6280afe","author":{"_account_id":24080,"name":"jiahui.qiang","email":"jiahui.qiang@easystack.cn","username":"qiangjiahui"},"date":"2016-12-28 11:36:55.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"69186eb59c5684e67a62cddc03ad2d3630c331f1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-12-28 12:46:58.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/47/415447/1/check/gate-python-openstackclient-docs-ubuntu-xenial/84f55d8//doc/build/html/ : SUCCESS in 2m 48s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/47/415447/1/check/gate-python-openstackclient-pep8-ubuntu-xenial/80851ec/ : SUCCESS in 3m 11s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/47/415447/1/check/gate-python-openstackclient-python27-ubuntu-xenial/88717b3/ : SUCCESS in 2m 41s\n- gate-python-openstackclient-python35 http://logs.openstack.org/47/415447/1/check/gate-python-openstackclient-python35/a2ccd57/ : SUCCESS in 2m 40s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial http://logs.openstack.org/47/415447/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial/7218b79/ : SUCCESS in 52m 56s\n- check-osc-plugins http://logs.openstack.org/47/415447/1/check/check-osc-plugins/61d89be/ : SUCCESS in 6m 02s (non-voting)\n- gate-osc-dsvm-functional-ubuntu-xenial http://logs.openstack.org/47/415447/1/check/gate-osc-dsvm-functional-ubuntu-xenial/d4e87e9/ : FAILURE in 28m 57s\n- gate-tripleo-ci-centos-7-nonha-multinode-nv http://logs.openstack.org/47/415447/1/check/gate-tripleo-ci-centos-7-nonha-multinode-nv/8495c6a/ : SUCCESS in 1h 09m 51s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"fda4da79537177b2a37964443a5fc9dd03d7a2e2","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2017-01-02 02:24:59.000000000","message":"Patch Set 1: Code-Review-1\n\nchanging a user\u0027s, group\u0027s or project\u0027s domain is not allowed. anything in the keystone documentation or client libs that indicate otherwise is a bug.\n\nSee: https://github.com/openstack/keystone/blob/fcebc2fa8d075f24cc131bd550563c68c3dd24d9/keystone/common/controller.py#L667-L687","accounts_in_message":[],"_revision_number":1},{"id":"98c7bc596f1fb8c3a2b3e099a009a74fdfe8a2f1","author":{"_account_id":24080,"name":"jiahui.qiang","email":"jiahui.qiang@easystack.cn","username":"qiangjiahui"},"date":"2017-01-04 07:52:11.000000000","message":"Patch Set 1:\n\n\u003e changing a user\u0027s, group\u0027s or project\u0027s domain is not allowed.\n \u003e anything in the keystone documentation or client libs that indicate\n \u003e otherwise is a bug.\n \u003e \n \u003e See: https://github.com/openstack/keystone/blob/fcebc2fa8d075f24cc131bd550563c68c3dd24d9/keystone/common/controller.py#L667-L687\n\nYes, Thank you steve. I have tested \"domain\" option and the result is the domain can not be changed. I think we should delete the \"domain\" option in the update().\nhttps://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/v3/projects.py","accounts_in_message":[],"_revision_number":1},{"id":"5b50f4ea38694c742e419d6f9f1c4fe68590ce3b","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2017-01-04 12:51:55.000000000","message":"Patch Set 1:\n\n\u003e \u003e changing a user\u0027s, group\u0027s or project\u0027s domain is not allowed.\n \u003e \u003e anything in the keystone documentation or client libs that\n \u003e indicate\n \u003e \u003e otherwise is a bug.\n \u003e \u003e\n \u003e \u003e See: https://github.com/openstack/keystone/blob/fcebc2fa8d075f24cc131bd550563c68c3dd24d9/keystone/common/controller.py#L667-L687\n \u003e \n \u003e Yes, Thank you steve. I have tested \"domain\" option and the result\n \u003e is the domain can not be changed. I think we should delete the\n \u003e \"domain\" option in the update().\n \u003e https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/v3/projects.py\n\nthat makes sense to me","accounts_in_message":[],"_revision_number":1},{"id":"fcd089c7bb9e9b8c8849ced97d145c56867da110","author":{"_account_id":24080,"name":"jiahui.qiang","email":"jiahui.qiang@easystack.cn","username":"qiangjiahui"},"date":"2017-01-05 01:40:00.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"81dcf67073dcfa891f065d5a78f27923bacd924f","revisions":{"81dcf67073dcfa891f065d5a78f27923bacd924f":{"kind":"REWORK","_number":1,"created":"2016-12-28 11:36:55.000000000","uploader":{"_account_id":24080,"name":"jiahui.qiang","email":"jiahui.qiang@easystack.cn","username":"qiangjiahui"},"ref":"refs/changes/47/415447/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/47/415447/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/47/415447/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/47/415447/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/47/415447/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/47/415447/1"}}},"commit":{"parents":[{"commit":"317cbe2c6e5879f9ed1540313ef77215b464c75c","subject":"Merge \"Fix a spelling error\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/317cbe2c6e5879f9ed1540313ef77215b464c75c"}]}],"author":{"name":"jiahui.qiang","email":"jiahui.qiang@easystack.cn","date":"2016-11-13 02:11:13.000000000","tz":480},"committer":{"name":"jiahui.qiang","email":"jiahui.qiang@easystack.cn","date":"2016-11-13 02:23:18.000000000","tz":480},"subject":"Modified \"domain\" option in \"project set\"(identityV3)","message":"Modified \"domain\" option in \"project set\"(identityV3)\n\nI think the operation of \"domain\" option is wrong. The \"domain\" option in\nkeystoneclient/v3/projects is for setting the new domain of the project.\nSo i modified it. We can also add a new command to change the project\u0027s\ndomain as well.\n\nChange-Id: I5851bfec2752599ce18768d79be9469e3c574588\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/81dcf67073dcfa891f065d5a78f27923bacd924f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/81dcf67073dcfa891f065d5a78f27923bacd924f"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}