)]}'
{"openstackclient/tests/functional/network/v2/test_floating_ip.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"9a226735af9c663887701a4fadf728316b20d498","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        raw_output \u003d self.openstack(\u0027floating ip list\u0027)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        # Clean up after ourselves"},{"line_number":104,"context_line":"        del_output \u003d self.openstack(\u0027floating ip delete \u0027 + ip1 + \u0027 \u0027 + ip2)"},{"line_number":105,"context_line":"        self.assertOutput(\u0027\u0027, del_output)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        self.assertIsNotNone(re.search(\"\\|\\s+\" + ip1 + \"\\s+\\|\", raw_output))"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5201f7_ccf60bd7","line":104,"updated":"2016-12-30 16:37:30.000000000","message":"Given that you do little check on the del_output (which is fine, there\u0027s not a lot to check anyway), I\u0027d consider using self.addCleanup here:\n\nself.addCleanup(self.openstack, \u0027floating ip delete \u0027 + ip1 + \u0027 \u0027 + ip2)\n\nAnd do the addCleanup call, right after the floating ip create call. Because currently, if let\u0027s say assertion L99 raises an error, then the cleanup will never happen.","commit_id":"4f90933ce5c8143cce95ac03c2f47855e317512b"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"fcb9ce36a7f25324d3114863456f38d969d6379e","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        raw_output \u003d self.openstack(\u0027floating ip list\u0027)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        # Clean up after ourselves"},{"line_number":104,"context_line":"        del_output \u003d self.openstack(\u0027floating ip delete \u0027 + ip1 + \u0027 \u0027 + ip2)"},{"line_number":105,"context_line":"        self.assertOutput(\u0027\u0027, del_output)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        self.assertIsNotNone(re.search(\"\\|\\s+\" + ip1 + \"\\s+\\|\", raw_output))"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5201f7_af7c5921","line":104,"in_reply_to":"ba5201f7_ccf60bd7","updated":"2016-12-30 19:12:01.000000000","message":"Aha!  Yes...","commit_id":"4f90933ce5c8143cce95ac03c2f47855e317512b"}]}