)]}'
{"openstackclient/identity/v3/group.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"2a1b160b48b77d293ba8f24828fc43a2756a7eda","unresolved":false,"context_lines":[{"line_number":195,"context_line":"    def take_action(self, parsed_args):"},{"line_number":196,"context_line":"        identity_client \u003d self.app.client_manager.identity"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        result \u003d 0"},{"line_number":199,"context_line":"        for group in parsed_args.groups:"},{"line_number":200,"context_line":"            try:"},{"line_number":201,"context_line":"                group_obj \u003d common.find_group(identity_client,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5201f7_2cd07753","line":198,"updated":"2016-12-30 16:27:22.000000000","message":"That variable is misnamed. It\u0027s not a \"result\" it\u0027s a counter and it counts the number of errors, which is not a result. This variable should be named \"errors\" or \"error_count\".","commit_id":"0700f845840ba45cf312f050da645b042256a5b6"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"8c1475f5b8d11bb55a219c6d75b8eb88be04d928","unresolved":false,"context_lines":[{"line_number":195,"context_line":"    def take_action(self, parsed_args):"},{"line_number":196,"context_line":"        identity_client \u003d self.app.client_manager.identity"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        result \u003d 0"},{"line_number":199,"context_line":"        for group in parsed_args.groups:"},{"line_number":200,"context_line":"            try:"},{"line_number":201,"context_line":"                group_obj \u003d common.find_group(identity_client,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5201f7_65cfc97f","line":198,"in_reply_to":"ba5201f7_2cd07753","updated":"2017-01-03 15:31:39.000000000","message":"Done","commit_id":"0700f845840ba45cf312f050da645b042256a5b6"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"2a1b160b48b77d293ba8f24828fc43a2756a7eda","unresolved":false,"context_lines":[{"line_number":204,"context_line":"                identity_client.groups.delete(group_obj.id)"},{"line_number":205,"context_line":"            except Exception as e:"},{"line_number":206,"context_line":"                result +\u003d 1"},{"line_number":207,"context_line":"                LOG.error(_(\"Failed to delete group with \""},{"line_number":208,"context_line":"                          \"name or ID \u0027%(group)s\u0027: %(e)s\")"},{"line_number":209,"context_line":"                          % {\u0027group\u0027: group, \u0027e\u0027: e})"},{"line_number":210,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5201f7_8cf883e7","line":207,"updated":"2016-12-30 16:27:22.000000000","message":"You should \"Delay string interpolations at logging calls.\", i.e use a comma instead of %. There\u0027s no need to do this \u0027heavy\u0027 string formatting operations if logging is disabled.\n\nSee H904 here: https://github.com/openstack-dev/hacking#enabling-off-by-default-checks\n\nand oslo i18n here: http://docs.openstack.org/developer/oslo.i18n/guidelines.html#adding-variables-to-log-messages","commit_id":"0700f845840ba45cf312f050da645b042256a5b6"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"8c1475f5b8d11bb55a219c6d75b8eb88be04d928","unresolved":false,"context_lines":[{"line_number":204,"context_line":"                identity_client.groups.delete(group_obj.id)"},{"line_number":205,"context_line":"            except Exception as e:"},{"line_number":206,"context_line":"                result +\u003d 1"},{"line_number":207,"context_line":"                LOG.error(_(\"Failed to delete group with \""},{"line_number":208,"context_line":"                          \"name or ID \u0027%(group)s\u0027: %(e)s\")"},{"line_number":209,"context_line":"                          % {\u0027group\u0027: group, \u0027e\u0027: e})"},{"line_number":210,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5201f7_25ace19f","line":207,"in_reply_to":"ba5201f7_8cf883e7","updated":"2017-01-03 15:31:39.000000000","message":"Done, Thanks for your info :)","commit_id":"0700f845840ba45cf312f050da645b042256a5b6"}]}