)]}'
{"openstackclient/tests/unit/volume/v2/test_qos_specs.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"553127d6c72db24cff78bb056ccf953002c404d4","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        columns, data \u003d self.cmd.take_action(parsed_args)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        self.new_qos_spec.specs.update("},{"line_number":151,"context_line":"            {\u0027consumer\u0027: self.new_qos_spec.consumer})"},{"line_number":152,"context_line":"        self.qos_mock.create.assert_called_with("},{"line_number":153,"context_line":"            self.new_qos_spec.name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_471fdbb6","line":150,"updated":"2017-01-17 10:00:30.000000000","message":"You should make a copy of self.new_qos_spec.specs here an only update the copy. Because if, for some reason, the assertion L152 fails then an exception will be raised and your L161 (the pop) will not be executed.","commit_id":"ed64edf5c216ddacc61949fc339fbb02fb7efcb4"},{"author":{"_account_id":24080,"name":"jiahui.qiang","email":"jiahui.qiang@easystack.cn","username":"qiangjiahui"},"change_message_id":"d3c7f5aa556703f485691e987b54c2d263f2a6d4","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        columns, data \u003d self.cmd.take_action(parsed_args)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        self.new_qos_spec.specs.update("},{"line_number":151,"context_line":"            {\u0027consumer\u0027: self.new_qos_spec.consumer})"},{"line_number":152,"context_line":"        self.qos_mock.create.assert_called_with("},{"line_number":153,"context_line":"            self.new_qos_spec.name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_98512439","line":150,"in_reply_to":"7a3c09a3_471fdbb6","updated":"2017-01-17 11:49:33.000000000","message":"Yes, you are right. No need to add a copy and just write a dict inside assert because it is for us to comfirm the argument originally. I only consider i should delete extra done to new_qos_spec but you consider further :)","commit_id":"ed64edf5c216ddacc61949fc339fbb02fb7efcb4"}]}