)]}'
{"openstackclient/tests/functional/volume/v2/test_qos.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"672d415eee2aae5cfb63d7078ec9e4f4644f8587","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7a3c09a3_760ba42a","updated":"2017-01-17 12:50:38.000000000","message":"can you add a TODO to add tests for associate and disassociating volumes? https://github.com/openstack/python-openstackclient/blob/master/openstackclient/volume/v2/qos_specs.py#L32-L47","commit_id":"2a417c62d77d4d64ad5014ed0bf5f5f55edc5ea3"},{"author":{"_account_id":24080,"name":"jiahui.qiang","email":"jiahui.qiang@easystack.cn","username":"qiangjiahui"},"change_message_id":"3c43b3c3dff9699e054ac525fe3dd704595b2c4e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5a3905b3_90d27a33","in_reply_to":"7a3c09a3_760ba42a","updated":"2017-01-19 01:54:40.000000000","message":"thank you steve!","commit_id":"2a417c62d77d4d64ad5014ed0bf5f5f55edc5ea3"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"687f756f38704ba03e28cdbda4570576a4b21ee1","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            name"},{"line_number":65,"context_line":"        ))"},{"line_number":66,"context_line":"        self.addCleanup(self.openstack, \u0027volume qos delete \u0027 + name)"},{"line_number":67,"context_line":"        self.assertEqual("},{"line_number":68,"context_line":"            name,"},{"line_number":69,"context_line":"            cmd_output[\u0027name\u0027]"},{"line_number":70,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_13b66bdc","line":67,"updated":"2017-01-19 16:49:41.000000000","message":"We don\"t have to perform this assertion each and every time we create a volume qos. I mean, you did check the name already twice in test_volume_qos_list.","commit_id":"e46cdf462b163ea2e97af5a7fdd72e74474e1010"},{"author":{"_account_id":24080,"name":"jiahui.qiang","email":"jiahui.qiang@easystack.cn","username":"qiangjiahui"},"change_message_id":"f4ec937f002fca85726e8fb82d710f73d05a2e5c","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            name"},{"line_number":65,"context_line":"        ))"},{"line_number":66,"context_line":"        self.addCleanup(self.openstack, \u0027volume qos delete \u0027 + name)"},{"line_number":67,"context_line":"        self.assertEqual("},{"line_number":68,"context_line":"            name,"},{"line_number":69,"context_line":"            cmd_output[\u0027name\u0027]"},{"line_number":70,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_1a0ae121","line":67,"in_reply_to":"5a3905b3_13b66bdc","updated":"2017-01-20 03:18:54.000000000","message":"I think we need to check what we create is right.","commit_id":"e46cdf462b163ea2e97af5a7fdd72e74474e1010"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"41fc04ed7e1e33d7fcfc0d36356ad52931915e81","unresolved":false,"context_lines":[{"line_number":19,"context_line":"class QosTests(common.BaseVolumeTests):"},{"line_number":20,"context_line":"    \"\"\"Functional tests for volume qos. \"\"\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    def test_volume_qos_list(self):"},{"line_number":23,"context_line":"        \"\"\"Test create, list, delete multiple\"\"\""},{"line_number":24,"context_line":"        name1 \u003d uuid.uuid4().hex"},{"line_number":25,"context_line":"        cmd_output \u003d json.loads(self.openstack("}],"source_content_type":"text/x-python","patch_set":4,"id":"fa31d9ce_603b1d39","line":22,"range":{"start_line":22,"start_character":8,"end_line":22,"end_character":28},"updated":"2017-02-13 07:42:47.000000000","message":"What about renaming this to \"test_volume_qos_create_delete_list\", I\u0027d like the a clearer test name","commit_id":"5d87fbec847482d9c89bf65e164c50b433c71b07"},{"author":{"_account_id":24080,"name":"jiahui.qiang","email":"jiahui.qiang@easystack.cn","username":"qiangjiahui"},"change_message_id":"b7cb4a4387a5bae32856c9df44b6956839bcebca","unresolved":false,"context_lines":[{"line_number":19,"context_line":"class QosTests(common.BaseVolumeTests):"},{"line_number":20,"context_line":"    \"\"\"Functional tests for volume qos. \"\"\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    def test_volume_qos_list(self):"},{"line_number":23,"context_line":"        \"\"\"Test create, list, delete multiple\"\"\""},{"line_number":24,"context_line":"        name1 \u003d uuid.uuid4().hex"},{"line_number":25,"context_line":"        cmd_output \u003d json.loads(self.openstack("}],"source_content_type":"text/x-python","patch_set":4,"id":"fa31d9ce_74bd9c67","line":22,"range":{"start_line":22,"start_character":8,"end_line":22,"end_character":28},"in_reply_to":"fa31d9ce_603b1d39","updated":"2017-02-13 10:50:25.000000000","message":"Done","commit_id":"5d87fbec847482d9c89bf65e164c50b433c71b07"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"41fc04ed7e1e33d7fcfc0d36356ad52931915e81","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        del_output \u003d self.openstack(\u0027volume qos delete \u0027 + name1 + \u0027 \u0027 + name2)"},{"line_number":54,"context_line":"        self.assertOutput(\u0027\u0027, del_output)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def test_volume_qos_set(self):"},{"line_number":57,"context_line":"        \"\"\"Tests create volume, set, unset, show, delete\"\"\""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        name \u003d uuid.uuid4().hex"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa31d9ce_60223d03","line":56,"range":{"start_line":56,"start_character":8,"end_line":56,"end_character":27},"updated":"2017-02-13 07:42:47.000000000","message":"What about renaming this to \"test_volume_qos_set_show_unset\"?","commit_id":"5d87fbec847482d9c89bf65e164c50b433c71b07"},{"author":{"_account_id":24080,"name":"jiahui.qiang","email":"jiahui.qiang@easystack.cn","username":"qiangjiahui"},"change_message_id":"b7cb4a4387a5bae32856c9df44b6956839bcebca","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        del_output \u003d self.openstack(\u0027volume qos delete \u0027 + name1 + \u0027 \u0027 + name2)"},{"line_number":54,"context_line":"        self.assertOutput(\u0027\u0027, del_output)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def test_volume_qos_set(self):"},{"line_number":57,"context_line":"        \"\"\"Tests create volume, set, unset, show, delete\"\"\""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        name \u003d uuid.uuid4().hex"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa31d9ce_3495e4dd","line":56,"range":{"start_line":56,"start_character":8,"end_line":56,"end_character":27},"in_reply_to":"fa31d9ce_60223d03","updated":"2017-02-13 10:50:25.000000000","message":"Done","commit_id":"5d87fbec847482d9c89bf65e164c50b433c71b07"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"41fc04ed7e1e33d7fcfc0d36356ad52931915e81","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        self.assertOutput(\u0027\u0027, del_output)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def test_volume_qos_set(self):"},{"line_number":57,"context_line":"        \"\"\"Tests create volume, set, unset, show, delete\"\"\""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        name \u003d uuid.uuid4().hex"},{"line_number":60,"context_line":"        cmd_output \u003d json.loads(self.openstack("}],"source_content_type":"text/x-python","patch_set":4,"id":"fa31d9ce_406e1930","line":57,"range":{"start_line":57,"start_character":24,"end_line":57,"end_character":30},"updated":"2017-02-13 07:42:47.000000000","message":"volume qos?","commit_id":"5d87fbec847482d9c89bf65e164c50b433c71b07"},{"author":{"_account_id":24080,"name":"jiahui.qiang","email":"jiahui.qiang@easystack.cn","username":"qiangjiahui"},"change_message_id":"b7cb4a4387a5bae32856c9df44b6956839bcebca","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        self.assertOutput(\u0027\u0027, del_output)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def test_volume_qos_set(self):"},{"line_number":57,"context_line":"        \"\"\"Tests create volume, set, unset, show, delete\"\"\""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        name \u003d uuid.uuid4().hex"},{"line_number":60,"context_line":"        cmd_output \u003d json.loads(self.openstack("}],"source_content_type":"text/x-python","patch_set":4,"id":"fa31d9ce_94c050e2","line":57,"range":{"start_line":57,"start_character":24,"end_line":57,"end_character":30},"in_reply_to":"fa31d9ce_406e1930","updated":"2017-02-13 10:50:25.000000000","message":"Done","commit_id":"5d87fbec847482d9c89bf65e164c50b433c71b07"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"41fc04ed7e1e33d7fcfc0d36356ad52931915e81","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            name,"},{"line_number":69,"context_line":"            cmd_output[\u0027name\u0027]"},{"line_number":70,"context_line":"        )"},{"line_number":71,"context_line":"        # TODO(qiangjiahui): Add assertEqual of property when volume qos"},{"line_number":72,"context_line":"        # create fix"},{"line_number":73,"context_line":"        self.assertEqual("},{"line_number":74,"context_line":"            \"front-end\","},{"line_number":75,"context_line":"            cmd_output[\u0027consumer\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa31d9ce_60c6bd4a","line":72,"range":{"start_line":71,"start_character":0,"end_line":72,"end_character":20},"updated":"2017-02-13 07:42:47.000000000","message":"I think this has been fixed in https://review.openstack.org/#/c/421065/ ?","commit_id":"5d87fbec847482d9c89bf65e164c50b433c71b07"},{"author":{"_account_id":24080,"name":"jiahui.qiang","email":"jiahui.qiang@easystack.cn","username":"qiangjiahui"},"change_message_id":"b7cb4a4387a5bae32856c9df44b6956839bcebca","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            name,"},{"line_number":69,"context_line":"            cmd_output[\u0027name\u0027]"},{"line_number":70,"context_line":"        )"},{"line_number":71,"context_line":"        # TODO(qiangjiahui): Add assertEqual of property when volume qos"},{"line_number":72,"context_line":"        # create fix"},{"line_number":73,"context_line":"        self.assertEqual("},{"line_number":74,"context_line":"            \"front-end\","},{"line_number":75,"context_line":"            cmd_output[\u0027consumer\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa31d9ce_94677024","line":72,"range":{"start_line":71,"start_character":0,"end_line":72,"end_character":20},"in_reply_to":"fa31d9ce_60c6bd4a","updated":"2017-02-13 10:50:25.000000000","message":"Yes, this patch has merged, thanks!","commit_id":"5d87fbec847482d9c89bf65e164c50b433c71b07"}]}