)]}'
{"openstackclient/tests/functional/volume/v2/test_volume_type.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"505f7a63db95ddfeb36bf665bad37d956fcdc0ca","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from openstackclient.tests.functional.volume.v2 import common"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class VolumeTypeTests(common.BaseVolumeTests):"},{"line_number":20,"context_line":"    \"\"\"Functional tests for volume type. \"\"\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_120281b4","line":19,"updated":"2017-01-28 15:57:04.000000000","message":"I think you should introduce a helper function:\n\ndef create_volume_type(self, name):\n  ..\n  self.assertEqual(...\n  self.addCleanup(..\n\nThis would drasticaly reduce code duplication, ease maintenance and ease reviewing. For instance, there\u0027s no need to check that the expected volume type name is correct more than once. The feature is not going to break in the middle of the tests.","commit_id":"e19d7404293501fedcef1454fa7f2f1526acd954"}]}