)]}'
{"openstackclient/tests/functional/volume/v1/test_transfer_request.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"c3340a0d6077b390213d288ccd7a907df3ff7c40","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            cls.VOLUME_NAME_2"},{"line_number":52,"context_line":"        ))"},{"line_number":53,"context_line":"        cls.wait_for_status(\u0027volume show \u0027 + cls.VOLUME_NAME_2,"},{"line_number":54,"context_line":"                            \u0027available\\n\u0027, 6)"},{"line_number":55,"context_line":"        cls.VOLUME_ID_2 \u003d cmd_output[\u0027id\u0027]"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_0f5a382a","line":54,"updated":"2017-01-23 11:51:03.000000000","message":"The trailing \u0027\\n\u0027 is not nice. Use rstrip() in your wait_for_status function.","commit_id":"6326d07d0b58591699bdbc20fb1f286ac4db0754"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"c3340a0d6077b390213d288ccd7a907df3ff7c40","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        self.addCleanup(self.openstack,"},{"line_number":150,"context_line":"                        \u0027volume transfer request delete \u0027 + name1)"},{"line_number":151,"context_line":"        transfer_id_1 \u003d cmd_output[\u0027id\u0027]"},{"line_number":152,"context_line":"        self.assertEqual("},{"line_number":153,"context_line":"            self.VOLUME_ID_1,"},{"line_number":154,"context_line":"            cmd_output[\u0027volume_id\u0027],"},{"line_number":155,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_8f50e8d5","line":152,"updated":"2017-01-23 11:51:03.000000000","message":"The fact that you keep making this assertion and the one L156  in several tests are redundant and make each test case harder to read and understand. I suggest you have just one test case which checks the \"trivial\" stuff (like the names, the volume_id etc.) so that the other test cases focus on the more interesting stuff. You can safely assume that a feature is not going to break in the middle of a test class.","commit_id":"6326d07d0b58591699bdbc20fb1f286ac4db0754"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"c3340a0d6077b390213d288ccd7a907df3ff7c40","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        self.assertIn(self.VOLUME_ID_1, volume_ids)"},{"line_number":189,"context_line":"        self.assertIn(self.VOLUME_ID_2, volume_ids)"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    def test_volume_transfer_request_show(self):"},{"line_number":192,"context_line":"        name \u003d uuid.uuid4().hex"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        cmd_output \u003d json.loads(self.openstack("}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_8f1548e6","line":191,"updated":"2017-01-23 11:51:03.000000000","message":"All the assertions in this test are already done in your previous tests. Can you assert fields/stuff that are specific to the show command ?","commit_id":"6326d07d0b58591699bdbc20fb1f286ac4db0754"}]}