)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"2a65136429121e639a40c0b0412ad9e249275358","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Correctly  format the empty fields of \"openstack network show\" o/p."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"add new Formatters to correctly format following empty fields."},{"line_number":10,"context_line":"Format \u0027availability_zone_hits\u0027 and \u0027description\u0027 fields with empty value."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Iafb0da2439e595ceda891d65cfb1ec6a0221afc5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"dfeb2761_e2ba8408","line":9,"updated":"2017-04-02 10:34:11.000000000","message":"I don\u0027t understand the added value of such change: None means undefined not empty","commit_id":"e942f7b55444a20973e38441a4d2804e1340cd34"}],"openstackclient/network/v2/network.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"2a65136429121e639a40c0b0412ad9e249275358","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"def _format_avail_zone_hints(item):"},{"line_number":34,"context_line":"    data \u003d \u0027, \u0027.join(sorted(item))"},{"line_number":35,"context_line":"    return data if item else None"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"dfeb2761_c2d2e05c","line":34,"updated":"2017-04-02 10:34:11.000000000","message":"data is computed even if not item, prefer:\n\n return \u0027, \u0027.join(sorted(item)) if item else None\n\nor:\n\n return \u0027, \u0027.join(sorted(item)) if item else \u0027None\u0027\n\nindeed a formatting method should return only strings ...","commit_id":"e942f7b55444a20973e38441a4d2804e1340cd34"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"2a65136429121e639a40c0b0412ad9e249275358","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"def _format_description(item):"},{"line_number":39,"context_line":"    if item \u003d\u003d \u0027\u0027 or not item:"},{"line_number":40,"context_line":"            return None"},{"line_number":41,"context_line":"    else:"},{"line_number":42,"context_line":"            return item"}],"source_content_type":"text/x-python","patch_set":8,"id":"dfeb2761_42c6d09c","line":39,"range":{"start_line":39,"start_character":8,"end_line":39,"end_character":10},"updated":"2017-04-02 10:34:11.000000000","message":"This method can be simplified a lot:\n\n return item or None\n\nor:\n\n return item or \u0027None\u0027","commit_id":"e942f7b55444a20973e38441a4d2804e1340cd34"}],"releasenotes/notes/bug-1651725-6224769a0fe6dc43.yaml":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"99f24436f19d22673bb8ade5492c1823a903d929","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Format values of `availability_zone_hits`,`description` "},{"line_number":5,"context_line":"    from blank to None for command ``openstack network show``o/p."},{"line_number":6,"context_line":"    [Bug `1651725 \u003chttps://bugs.launchpad.net/bugs/1651725`\u003e_]"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5a3905b3_d7f5b8cb","line":4,"range":{"start_line":4,"start_character":59,"end_line":4,"end_character":60},"updated":"2017-01-25 09:04:40.000000000","message":"Please remove the extra space","commit_id":"543542f096014691e35ab07f5f1ff07a922f2572"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"99f24436f19d22673bb8ade5492c1823a903d929","unresolved":false,"context_lines":[{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Format values of `availability_zone_hits`,`description` "},{"line_number":5,"context_line":"    from blank to None for command ``openstack network show``o/p."},{"line_number":6,"context_line":"    [Bug `1651725 \u003chttps://bugs.launchpad.net/bugs/1651725`\u003e_]"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5a3905b3_97e17001","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":17},"updated":"2017-01-25 09:04:40.000000000","message":"no need to write blank.\n\nFormat values of \u0027description\u0027 and \u0027availability_zone_hints\u0027 to show None if their values are not defined , in the ``openstack network show`` op","commit_id":"543542f096014691e35ab07f5f1ff07a922f2572"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"23693f5262d5cbb5bb6eae9242d3bfce2db5f4f4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Format values of `availability_zone_hits`,`description`"},{"line_number":5,"context_line":"    to None if values undefined in ``openstack network show``op."},{"line_number":6,"context_line":"    [Bug `1651725 \u003chttps://bugs.launchpad.net/bugs/1651725`\u003e_]"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5a3905b3_e06e6895","line":4,"range":{"start_line":4,"start_character":22,"end_line":4,"end_character":44},"updated":"2017-01-25 10:05:10.000000000","message":"As mentioned in the previous patch set, its \"availability_zone_hints\" !","commit_id":"e4097a39644c81cf0561011dec246aa640156d0f"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"23693f5262d5cbb5bb6eae9242d3bfce2db5f4f4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Format values of `availability_zone_hits`,`description`"},{"line_number":5,"context_line":"    to None if values undefined in ``openstack network show``op."},{"line_number":6,"context_line":"    [Bug `1651725 \u003chttps://bugs.launchpad.net/bugs/1651725`\u003e_]"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5a3905b3_800e84e3","line":4,"range":{"start_line":4,"start_character":45,"end_line":4,"end_character":46},"updated":"2017-01-25 10:05:10.000000000","message":"nit: And instead of comma","commit_id":"e4097a39644c81cf0561011dec246aa640156d0f"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"23693f5262d5cbb5bb6eae9242d3bfce2db5f4f4","unresolved":false,"context_lines":[{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Format values of `availability_zone_hits`,`description`"},{"line_number":5,"context_line":"    to None if values undefined in ``openstack network show``op."},{"line_number":6,"context_line":"    [Bug `1651725 \u003chttps://bugs.launchpad.net/bugs/1651725`\u003e_]"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5a3905b3_a0f700f4","line":5,"range":{"start_line":5,"start_character":15,"end_line":5,"end_character":23},"updated":"2017-01-25 10:05:10.000000000","message":"their values are undefined","commit_id":"e4097a39644c81cf0561011dec246aa640156d0f"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"356c449079b0f4f862668611200a5bb007fd5627","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Format values of ``availability_zone_hits`` and ``description``"},{"line_number":5,"context_line":"    to None if their values are undefined in ``openstack network show``op."},{"line_number":6,"context_line":"    [Bug `1651725 \u003chttps://bugs.launchpad.net/bugs/1651725`\u003e_]"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5a3905b3_20f9504e","line":4,"range":{"start_line":4,"start_character":21,"end_line":4,"end_character":46},"updated":"2017-01-25 10:13:46.000000000","message":"its not ``availability_zone_hits`` \nits ``availability_zone_hints``","commit_id":"7529fdef6711fe28b15a44af029f0da1f57a58e3"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"75b65b4bcc32dd09412ca124dfb9253b6391fbbf","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Format values of ``availability_zone_hints`` and ``description``"},{"line_number":5,"context_line":"    to None if their values are undefined in ``openstack network show``op."},{"line_number":6,"context_line":"    [Bug `1651725 \u003chttps://bugs.launchpad.net/bugs/1651725`\u003e_]"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"dfeb2761_f390d34c","line":5,"updated":"2017-04-04 16:05:18.000000000","message":"The the column names here that a user will see, not what the code uses.","commit_id":"e942f7b55444a20973e38441a4d2804e1340cd34"}]}
