)]}'
{"id":"openstack%2Fpython-openstackclient~425293","triplet_id":"openstack%2Fpython-openstackclient~master~I610ec3b2fa7561072346d46e49cfc1ae82130e0d","project":"openstack/python-openstackclient","branch":"master","topic":"fix_mapping_set_command","hashtags":[],"change_id":"I610ec3b2fa7561072346d46e49cfc1ae82130e0d","subject":"Fix \u0027mapping set\u0027 return value","status":"MERGED","created":"2017-01-25 17:12:49.000000000","updated":"2017-01-25 22:27:31.000000000","submitted":"2017-01-25 22:27:31.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"fa1dc3cd634abca778df1fe7611807a090c15068","_number":425293,"virtual_id_number":425293,"owner":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2017-01-25 22:27:31.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":2,"date":"2017-01-25 17:30:27.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2017-01-25 17:34:31.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2017-01-25 17:34:31.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-01-25 17:30:27.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2017-01-25 17:34:31.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2017-01-25 22:27:31.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"a64b3d7e4d63ec1b89520bd720ca920163dca38c","author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"date":"2017-01-25 17:12:49.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"324cda1af8a34fc7851b282d773ac71a7720e94c","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2017-01-25 17:30:27.000000000","message":"Patch Set 1: Code-Review+2\n\nyeah, we had a few of these slip through","accounts_in_message":[],"_revision_number":1},{"id":"cb3522f4898b9fc54c42c179ef8fa0a58bd2c974","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2017-01-25 17:34:31.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"3efca444ebd9a4090cbd656fb913fc07ba3c6a74","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-01-25 19:58:48.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/93/425293/1/check/gate-python-openstackclient-docs-ubuntu-xenial/d1e02c2//doc/build/html/ : SUCCESS in 12m 18s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/93/425293/1/check/gate-python-openstackclient-pep8-ubuntu-xenial/887b096/ : SUCCESS in 14m 44s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/93/425293/1/check/gate-python-openstackclient-python27-ubuntu-xenial/363b887/ : SUCCESS in 12m 19s\n- gate-python-openstackclient-python35 http://logs.openstack.org/93/425293/1/check/gate-python-openstackclient-python35/96e802f/ : SUCCESS in 14m 22s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial http://logs.openstack.org/93/425293/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial/d04b3ea/ : SUCCESS in 1h 04m 56s\n- check-osc-plugins http://logs.openstack.org/93/425293/1/check/check-osc-plugins/87e3de9/ : FAILURE in 13m 40s (non-voting)\n- gate-osc-dsvm-functional-ubuntu-xenial http://logs.openstack.org/93/425293/1/check/gate-osc-dsvm-functional-ubuntu-xenial/a684996/ : SUCCESS in 36m 26s\n- gate-osc-dsvm-functional-tips-ubuntu-xenial-nv http://logs.openstack.org/93/425293/1/check/gate-osc-dsvm-functional-tips-ubuntu-xenial-nv/1da43cd/ : SUCCESS in 40m 26s (non-voting)\n- gate-tripleo-ci-centos-7-nonha-multinode-nv http://logs.openstack.org/93/425293/1/check/gate-tripleo-ci-centos-7-nonha-multinode-nv/60be7cf/ : FAILURE in 1h 46m 05s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"949023c7744d7a0b16a8046e5ceed8ad790c72a5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-01-25 19:58:59.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"be0aadc90efc9af543f68f47cbb332f517c0e07b","date":"2017-01-25 22:27:31.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"4c138f116fa365d33697bfdbedbdb71bf65ab481","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-01-25 22:27:31.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/93/425293/1/gate/gate-python-openstackclient-docs-ubuntu-xenial/1da3de0//doc/build/html/ : SUCCESS in 4m 55s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/93/425293/1/gate/gate-python-openstackclient-pep8-ubuntu-xenial/fd92e82/ : SUCCESS in 4m 59s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/93/425293/1/gate/gate-python-openstackclient-python27-ubuntu-xenial/66b9d1d/ : SUCCESS in 5m 00s\n- gate-python-openstackclient-python35 http://logs.openstack.org/93/425293/1/gate/gate-python-openstackclient-python35/ed014bc/ : SUCCESS in 3m 11s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial http://logs.openstack.org/93/425293/1/gate/gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial/9addddf/ : SUCCESS in 1h 03m 21s\n- gate-osc-dsvm-functional-ubuntu-xenial http://logs.openstack.org/93/425293/1/gate/gate-osc-dsvm-functional-ubuntu-xenial/e6c2f86/ : SUCCESS in 30m 00s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"365d839a5b4e685d9a12f81386ddfaab07c56d83","revisions":{"365d839a5b4e685d9a12f81386ddfaab07c56d83":{"kind":"REWORK","_number":1,"created":"2017-01-25 17:12:49.000000000","uploader":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"ref":"refs/changes/93/425293/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/93/425293/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/93/425293/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/93/425293/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/93/425293/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/93/425293/1"}}},"commit":{"parents":[{"commit":"b69b539a422860bfb402093ff9d93a1b6e338b26","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/b69b539a422860bfb402093ff9d93a1b6e338b26"}]}],"author":{"name":"Colleen Murphy","email":"colleen@gazlene.net","date":"2017-01-25 17:07:17.000000000","tz":60},"committer":{"name":"Colleen Murphy","email":"colleen@gazlene.net","date":"2017-01-25 17:07:17.000000000","tz":60},"subject":"Fix \u0027mapping set\u0027 return value","message":"Fix \u0027mapping set\u0027 return value\n\nWithout this patch, the command \u0027openstack mapping set \u003cargs\u003e\u0027 will,\nupon success, print the rules for the updated mapping and exit with\nreturn code 1 (failure). This is a problem for scripts and config\nmanagement tools that depend on the return code to validate whether the\noperation was successful, since even upon success the command returns a\nfailing error code. Moreover, the behavior of printing the new value is\ncompletely unlike the behavior of any of the \u0027set\u0027 subcommands for\nother entities. This patch normalizes the \u0027mapping set\u0027 command by\nomitting any return value in the SetMapping take_action() method. This\nway the client will only exit with an error code if an exception is\nraised, and not upon normal operation.\n\nChange-Id: I610ec3b2fa7561072346d46e49cfc1ae82130e0d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/365d839a5b4e685d9a12f81386ddfaab07c56d83"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/365d839a5b4e685d9a12f81386ddfaab07c56d83"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}