)]}'
{"openstackclient/network/v2/port.py":[{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"e6fddb70cd45d8af0fa5e19f2e3e1f1180fca3cf","unresolved":false,"context_lines":[{"line_number":667,"context_line":"            attrs[\u0027security_groups\u0027] \u003d obj.security_group_ids"},{"line_number":668,"context_line":"            for sg in parsed_args.security_groups:"},{"line_number":669,"context_line":"                sg_id \u003d client.find_security_group(sg, ignore_missing\u003dFalse).id"},{"line_number":670,"context_line":"                attrs[\u0027security_groups\u0027].append(sg_id)"},{"line_number":671,"context_line":"        elif parsed_args.no_security_group:"},{"line_number":672,"context_line":"            attrs[\u0027security_group_ids\u0027] \u003d []"},{"line_number":673,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa31d9ce_b39dd5bd","line":670,"range":{"start_line":670,"start_character":22,"end_line":670,"end_character":39},"updated":"2017-02-16 03:04:42.000000000","message":"I\u0027m not familiar with openstacksdk\u0027s code, these all should be attrs[\u0027security_group_ids\u0027] ? why only update the following code, I\u0027m not sure, just curious.","commit_id":"02f5d980d509eb7f006de23df292588ee77a8473"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"870a453d0a57f5a2338230211e6b463ed0203bfe","unresolved":false,"context_lines":[{"line_number":669,"context_line":"                sg_id \u003d client.find_security_group(sg, ignore_missing\u003dFalse).id"},{"line_number":670,"context_line":"                attrs[\u0027security_groups\u0027].append(sg_id)"},{"line_number":671,"context_line":"        elif parsed_args.no_security_group:"},{"line_number":672,"context_line":"            attrs[\u0027security_group_ids\u0027] \u003d []"},{"line_number":673,"context_line":""},{"line_number":674,"context_line":"        if (parsed_args.allowed_address_pairs and"},{"line_number":675,"context_line":"                parsed_args.no_allowed_address_pair):"}],"source_content_type":"text/x-python","patch_set":6,"id":"da36d5c6_233fc626","line":672,"updated":"2017-02-18 00:25:29.000000000","message":"why is it security_group_ids here? and security_groups above in #L670 and #L667","commit_id":"1c6a2f97af33a7c009fc59ea87a9c6a34dbb0f59"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"9c8b55522f05c7da51d96e039b371094a2088623","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        \u0027binding:vnic_type\u0027: \u0027binding_vnic_type\u0027,"},{"line_number":64,"context_line":"        \u0027is_admin_state_up\u0027: \u0027admin_state_up\u0027,"},{"line_number":65,"context_line":"        \u0027is_port_security_enabled\u0027: \u0027port_security_enabled\u0027,"},{"line_number":66,"context_line":"        \u0027security_group_ids\u0027: \u0027security_group_ids\u0027,"},{"line_number":67,"context_line":"        \u0027tenant_id\u0027: \u0027project_id\u0027,"},{"line_number":68,"context_line":"    }"},{"line_number":69,"context_line":"    return sdk_utils.get_osc_show_columns_for_sdk_resource(item, column_map)"}],"source_content_type":"text/x-python","patch_set":8,"id":"da36d5c6_5bdfb50c","line":66,"range":{"start_line":66,"start_character":9,"end_line":66,"end_character":51},"updated":"2017-02-23 04:34:27.000000000","message":"do we need this now?","commit_id":"b55426c6029433478a4add4c5a8a7aac31948e9f"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"8d4c1262b86a0c91b3fdc5bc305d038a72414d04","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        \u0027binding:vnic_type\u0027: \u0027binding_vnic_type\u0027,"},{"line_number":64,"context_line":"        \u0027is_admin_state_up\u0027: \u0027admin_state_up\u0027,"},{"line_number":65,"context_line":"        \u0027is_port_security_enabled\u0027: \u0027port_security_enabled\u0027,"},{"line_number":66,"context_line":"        \u0027security_group_ids\u0027: \u0027security_group_ids\u0027,"},{"line_number":67,"context_line":"        \u0027tenant_id\u0027: \u0027project_id\u0027,"},{"line_number":68,"context_line":"    }"},{"line_number":69,"context_line":"    return sdk_utils.get_osc_show_columns_for_sdk_resource(item, column_map)"}],"source_content_type":"text/x-python","patch_set":8,"id":"da36d5c6_89fab541","line":66,"range":{"start_line":66,"start_character":9,"end_line":66,"end_character":51},"in_reply_to":"da36d5c6_5bdfb50c","updated":"2017-02-23 15:31:43.000000000","message":"Done","commit_id":"b55426c6029433478a4add4c5a8a7aac31948e9f"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"92986bdc54f1c91e023237c296a82473d629ff84","unresolved":false,"context_lines":[{"line_number":347,"context_line":"            \u0027--security-group\u0027,"},{"line_number":348,"context_line":"            metavar\u003d\u0027\u003csecurity-group\u003e\u0027,"},{"line_number":349,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":350,"context_line":"            dest\u003d\u0027security_group_ids\u0027,"},{"line_number":351,"context_line":"            help\u003d_(\"Security group to associate with this port (name or ID) \""},{"line_number":352,"context_line":"                   \"(repeat option to set multiple security groups)\")"},{"line_number":353,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":10,"id":"da36d5c6_71cc4cbb","line":350,"updated":"2017-02-25 14:32:10.000000000","message":"No need to change this because we are taking Name OR ID as input, and the conversion of Name to ID will be in Line#393\n\nBesides, you are using destination as \"security_group_ids\" in Line #350 and \"no_security_group\" in Line 356.\nSo either change 350 to security_group or 356 to no_security_group_id","commit_id":"f3a0568f00c4c55a51c784c2abce4c9a24f434ba"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"8276d15d47436082782f681807bc490db91fc77b","unresolved":false,"context_lines":[{"line_number":347,"context_line":"            \u0027--security-group\u0027,"},{"line_number":348,"context_line":"            metavar\u003d\u0027\u003csecurity-group\u003e\u0027,"},{"line_number":349,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":350,"context_line":"            dest\u003d\u0027security_group_ids\u0027,"},{"line_number":351,"context_line":"            help\u003d_(\"Security group to associate with this port (name or ID) \""},{"line_number":352,"context_line":"                   \"(repeat option to set multiple security groups)\")"},{"line_number":353,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":10,"id":"da36d5c6_d0d5e9e4","line":350,"in_reply_to":"da36d5c6_71cc4cbb","updated":"2017-02-26 20:39:14.000000000","message":"Done","commit_id":"f3a0568f00c4c55a51c784c2abce4c9a24f434ba"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"92986bdc54f1c91e023237c296a82473d629ff84","unresolved":false,"context_lines":[{"line_number":394,"context_line":"                                           sg, ignore_missing\u003dFalse).id"},{"line_number":395,"context_line":"                                           for sg in"},{"line_number":396,"context_line":"                                           parsed_args.security_group_ids]"},{"line_number":397,"context_line":"        if parsed_args.no_security_group:"},{"line_number":398,"context_line":"            attrs[\u0027security_group_ids\u0027] \u003d []"},{"line_number":399,"context_line":"        if parsed_args.allowed_address_pairs:"},{"line_number":400,"context_line":"            attrs[\u0027allowed_address_pairs\u0027] \u003d ("}],"source_content_type":"text/x-python","patch_set":10,"id":"da36d5c6_f1b83c13","line":397,"range":{"start_line":397,"start_character":0,"end_line":397,"end_character":41},"updated":"2017-02-25 14:32:10.000000000","message":"elif as these options are mutually exclusive ( will save one CPU cycle per execution which is not much , but well, it saves something :) )","commit_id":"f3a0568f00c4c55a51c784c2abce4c9a24f434ba"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"8276d15d47436082782f681807bc490db91fc77b","unresolved":false,"context_lines":[{"line_number":394,"context_line":"                                           sg, ignore_missing\u003dFalse).id"},{"line_number":395,"context_line":"                                           for sg in"},{"line_number":396,"context_line":"                                           parsed_args.security_group_ids]"},{"line_number":397,"context_line":"        if parsed_args.no_security_group:"},{"line_number":398,"context_line":"            attrs[\u0027security_group_ids\u0027] \u003d []"},{"line_number":399,"context_line":"        if parsed_args.allowed_address_pairs:"},{"line_number":400,"context_line":"            attrs[\u0027allowed_address_pairs\u0027] \u003d ("}],"source_content_type":"text/x-python","patch_set":10,"id":"da36d5c6_f0066d84","line":397,"range":{"start_line":397,"start_character":0,"end_line":397,"end_character":41},"in_reply_to":"da36d5c6_f1b83c13","updated":"2017-02-26 20:39:14.000000000","message":"Done","commit_id":"f3a0568f00c4c55a51c784c2abce4c9a24f434ba"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"92986bdc54f1c91e023237c296a82473d629ff84","unresolved":false,"context_lines":[{"line_number":625,"context_line":"            \u0027--security-group\u0027,"},{"line_number":626,"context_line":"            metavar\u003d\u0027\u003csecurity-group\u003e\u0027,"},{"line_number":627,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":628,"context_line":"            dest\u003d\u0027security_group_ids\u0027,"},{"line_number":629,"context_line":"            help\u003d_(\"Security group to associate with this port (name or ID) \""},{"line_number":630,"context_line":"                   \"(repeat option to set multiple security groups)\")"},{"line_number":631,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":10,"id":"da36d5c6_113a3099","line":628,"updated":"2017-02-25 14:32:10.000000000","message":"same as earlier comment","commit_id":"f3a0568f00c4c55a51c784c2abce4c9a24f434ba"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"8276d15d47436082782f681807bc490db91fc77b","unresolved":false,"context_lines":[{"line_number":625,"context_line":"            \u0027--security-group\u0027,"},{"line_number":626,"context_line":"            metavar\u003d\u0027\u003csecurity-group\u003e\u0027,"},{"line_number":627,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":628,"context_line":"            dest\u003d\u0027security_group_ids\u0027,"},{"line_number":629,"context_line":"            help\u003d_(\"Security group to associate with this port (name or ID) \""},{"line_number":630,"context_line":"                   \"(repeat option to set multiple security groups)\")"},{"line_number":631,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":10,"id":"da36d5c6_50001966","line":628,"in_reply_to":"da36d5c6_113a3099","updated":"2017-02-26 20:39:14.000000000","message":"Done","commit_id":"f3a0568f00c4c55a51c784c2abce4c9a24f434ba"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"92986bdc54f1c91e023237c296a82473d629ff84","unresolved":false,"context_lines":[{"line_number":693,"context_line":"                attrs[\u0027fixed_ips\u0027] +\u003d [ip for ip in obj.fixed_ips if ip]"},{"line_number":694,"context_line":"        elif parsed_args.no_fixed_ip:"},{"line_number":695,"context_line":"            attrs[\u0027fixed_ips\u0027] \u003d []"},{"line_number":696,"context_line":"        if parsed_args.security_group_ids and parsed_args.no_security_group:"},{"line_number":697,"context_line":"            attrs[\u0027security_group_ids\u0027] \u003d [client.find_security_group(sg,"},{"line_number":698,"context_line":"                                           ignore_missing\u003dFalse).id"},{"line_number":699,"context_line":"                                           for sg in"},{"line_number":700,"context_line":"                                           parsed_args.security_group_ids]"},{"line_number":701,"context_line":"        elif parsed_args.security_group_ids:"},{"line_number":702,"context_line":"            attrs[\u0027security_group_ids\u0027] \u003d obj.security_group_ids"},{"line_number":703,"context_line":"            for sg in parsed_args.security_group_ids:"},{"line_number":704,"context_line":"                sg_id \u003d client.find_security_group(sg, ignore_missing\u003dFalse).id"},{"line_number":705,"context_line":"                attrs[\u0027security_group_ids\u0027].append(sg_id)"},{"line_number":706,"context_line":"        elif parsed_args.no_security_group:"},{"line_number":707,"context_line":"            attrs[\u0027security_group_ids\u0027] \u003d []"},{"line_number":708,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"da36d5c6_515748c9","line":705,"range":{"start_line":696,"start_character":0,"end_line":705,"end_character":57},"updated":"2017-02-25 14:32:10.000000000","message":"Similar conditions, can be a bit streamlines:\n\n if parsed_args.security_groups:\n  attrs[\u0027security_group_ids\u0027] \u003d[client.find_security_group(sg,ignore_missing\u003dFalse).id for sg in parsed_args.security_group_ids]\n  if not parsed_args.no_security_groups:\n        attrs[\u0027security_group_ids\u0027] +\u003d obj.security_group_ids","commit_id":"f3a0568f00c4c55a51c784c2abce4c9a24f434ba"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"8276d15d47436082782f681807bc490db91fc77b","unresolved":false,"context_lines":[{"line_number":693,"context_line":"                attrs[\u0027fixed_ips\u0027] +\u003d [ip for ip in obj.fixed_ips if ip]"},{"line_number":694,"context_line":"        elif parsed_args.no_fixed_ip:"},{"line_number":695,"context_line":"            attrs[\u0027fixed_ips\u0027] \u003d []"},{"line_number":696,"context_line":"        if parsed_args.security_group_ids and parsed_args.no_security_group:"},{"line_number":697,"context_line":"            attrs[\u0027security_group_ids\u0027] \u003d [client.find_security_group(sg,"},{"line_number":698,"context_line":"                                           ignore_missing\u003dFalse).id"},{"line_number":699,"context_line":"                                           for sg in"},{"line_number":700,"context_line":"                                           parsed_args.security_group_ids]"},{"line_number":701,"context_line":"        elif parsed_args.security_group_ids:"},{"line_number":702,"context_line":"            attrs[\u0027security_group_ids\u0027] \u003d obj.security_group_ids"},{"line_number":703,"context_line":"            for sg in parsed_args.security_group_ids:"},{"line_number":704,"context_line":"                sg_id \u003d client.find_security_group(sg, ignore_missing\u003dFalse).id"},{"line_number":705,"context_line":"                attrs[\u0027security_group_ids\u0027].append(sg_id)"},{"line_number":706,"context_line":"        elif parsed_args.no_security_group:"},{"line_number":707,"context_line":"            attrs[\u0027security_group_ids\u0027] \u003d []"},{"line_number":708,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"da36d5c6_30348548","line":705,"range":{"start_line":696,"start_character":0,"end_line":705,"end_character":57},"in_reply_to":"da36d5c6_515748c9","updated":"2017-02-26 20:39:14.000000000","message":"Done","commit_id":"f3a0568f00c4c55a51c784c2abce4c9a24f434ba"}],"openstackclient/tests/functional/network/v2/test_port.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"3655ee3c78eaf4dd589b1b6440ca4ddeb9b49329","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"da36d5c6_a75a0bf0","line":145,"updated":"2017-02-24 23:50:56.000000000","message":"Here you should read the port again (port show) and check the security group is not there anymore.","commit_id":"0e8415f9bb5f2fe45c63e00919dc1a1317ec1fc5"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"0804ef06db763a00b8e4efa33523458e601248c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"da36d5c6_fdf1f495","line":145,"in_reply_to":"da36d5c6_a75a0bf0","updated":"2017-02-25 03:53:32.000000000","message":"+1\n\nmake sense.","commit_id":"0e8415f9bb5f2fe45c63e00919dc1a1317ec1fc5"}],"openstackclient/tests/unit/network/v2/fakes.py":[{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"0804ef06db763a00b8e4efa33523458e601248c0","unresolved":false,"context_lines":[{"line_number":481,"context_line":"            \u0027name\u0027: \u0027port-name-\u0027 + uuid.uuid4().hex,"},{"line_number":482,"context_line":"            \u0027network_id\u0027: \u0027network-id-\u0027 + uuid.uuid4().hex,"},{"line_number":483,"context_line":"            \u0027port_security_enabled\u0027: True,"},{"line_number":484,"context_line":"            \u0027security_group_ids\u0027: [],"},{"line_number":485,"context_line":"            \u0027status\u0027: \u0027ACTIVE\u0027,"},{"line_number":486,"context_line":"            \u0027tenant_id\u0027: \u0027project-id-\u0027 + uuid.uuid4().hex,"},{"line_number":487,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":9,"id":"da36d5c6_3d2e2cfb","line":484,"updated":"2017-02-25 03:53:32.000000000","message":"Yeah, now is right way, like I say in comment of PS5","commit_id":"0e8415f9bb5f2fe45c63e00919dc1a1317ec1fc5"}]}