)]}'
{"id":"openstack%2Fpython-openstackclient~430266","triplet_id":"openstack%2Fpython-openstackclient~master~Ib1007c49745b743cdb99c34227816eca82847be6","project":"openstack/python-openstackclient","branch":"master","hashtags":[],"change_id":"Ib1007c49745b743cdb99c34227816eca82847be6","subject":"Add helpful message for malformed --nic arg","status":"ABANDONED","created":"2017-02-07 14:12:28.000000000","updated":"2017-02-16 04:44:42.000000000","total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"7f5985aa1dcfda428a623d0df693f0a36221f051","_number":430266,"virtual_id_number":430266,"owner":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},{"date":"2017-02-08 03:06:19.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":1,"date":"2017-02-07 16:48:34.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2017-02-16 03:32:09.000000000","_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},{"date":"2017-02-08 18:27:46.000000000","_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"all":[{"value":-1,"date":"2017-02-08 22:05:41.000000000","permitted_voting_range":{"min":-1,"max":0},"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-02-07 16:48:34.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2017-02-08 03:06:19.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2017-02-08 18:27:46.000000000","updated_by":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"reviewer":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"state":"REVIEWER"},{"updated":"2017-02-16 03:32:09.000000000","updated_by":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"reviewer":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"state":"REVIEWER"}],"messages":[{"id":"0043d4cde0a2572ad1b8ba20c61dec8daf468deb","author":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"date":"2017-02-07 14:12:28.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"053da6ccca87fe2d37029f25f3ff8d0a4b105a89","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-02-07 15:20:17.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/66/430266/1/check/gate-python-openstackclient-docs-ubuntu-xenial/fefb3df//doc/build/html/ : SUCCESS in 2m 47s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/66/430266/1/check/gate-python-openstackclient-pep8-ubuntu-xenial/c4757b7/ : FAILURE in 4m 55s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/66/430266/1/check/gate-python-openstackclient-python27-ubuntu-xenial/b523795/ : SUCCESS in 3m 50s\n- gate-python-openstackclient-python35 http://logs.openstack.org/66/430266/1/check/gate-python-openstackclient-python35/e711edb/ : SUCCESS in 2m 37s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial http://logs.openstack.org/66/430266/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial/66400b5/ : SUCCESS in 1h 05m 50s\n- check-osc-plugins http://logs.openstack.org/66/430266/1/check/check-osc-plugins/6ed59ec/ : SUCCESS in 3m 55s (non-voting)\n- gate-osc-dsvm-functional-ubuntu-xenial http://logs.openstack.org/66/430266/1/check/gate-osc-dsvm-functional-ubuntu-xenial/4778c1e/ : SUCCESS in 30m 47s\n- gate-osc-dsvm-functional-tips-ubuntu-xenial-nv http://logs.openstack.org/66/430266/1/check/gate-osc-dsvm-functional-tips-ubuntu-xenial-nv/56a73b1/ : SUCCESS in 46m 35s (non-voting)\n- gate-tripleo-ci-centos-7-nonha-multinode-nv http://logs.openstack.org/66/430266/1/check/gate-tripleo-ci-centos-7-nonha-multinode-nv/70fc23c/ : SUCCESS in 1h 02m 43s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"ab42935a2b29547bb9093aa635c40c263db53d49","author":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"date":"2017-02-07 15:51:32.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"78fecc04f263d6813798fef7866f41b704fc4950","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-02-07 16:48:34.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/66/430266/2/check/gate-python-openstackclient-docs-ubuntu-xenial/e1966d7//doc/build/html/ : SUCCESS in 3m 45s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/66/430266/2/check/gate-python-openstackclient-pep8-ubuntu-xenial/3907c6d/ : SUCCESS in 5m 23s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/66/430266/2/check/gate-python-openstackclient-python27-ubuntu-xenial/0f17b2a/ : SUCCESS in 2m 51s\n- gate-python-openstackclient-python35 http://logs.openstack.org/66/430266/2/check/gate-python-openstackclient-python35/0cf9e2e/ : SUCCESS in 3m 11s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial http://logs.openstack.org/66/430266/2/check/gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial/e17737e/ : SUCCESS in 56m 32s\n- check-osc-plugins http://logs.openstack.org/66/430266/2/check/check-osc-plugins/fb05209/ : SUCCESS in 4m 32s (non-voting)\n- gate-osc-dsvm-functional-ubuntu-xenial http://logs.openstack.org/66/430266/2/check/gate-osc-dsvm-functional-ubuntu-xenial/5461159/ : SUCCESS in 50m 46s\n- gate-osc-dsvm-functional-tips-ubuntu-xenial-nv http://logs.openstack.org/66/430266/2/check/gate-osc-dsvm-functional-tips-ubuntu-xenial-nv/4121812/ : SUCCESS in 45m 06s (non-voting)\n- gate-tripleo-ci-centos-7-nonha-multinode-nv http://logs.openstack.org/66/430266/2/check/gate-tripleo-ci-centos-7-nonha-multinode-nv/c7b2641/ : FAILURE in 21m 02s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"53f56eea016696b133c097c1f850e31312e2ac2e","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2017-02-08 03:06:19.000000000","message":"Patch Set 2:\n\nlogic checks out, but needs a test (unit, functional, or both) and a release note","accounts_in_message":[],"_revision_number":2},{"id":"80e5ec3ea8cfcdb36219496c8156e165843799c5","author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"date":"2017-02-08 18:27:46.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"06be938c2f40a6410363141b79b58672fc900fb9","author":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"date":"2017-02-08 22:05:41.000000000","message":"Patch Set 2: Workflow-1","accounts_in_message":[],"_revision_number":2},{"id":"616052734a4a67b79e4eae8e4f31e1fe59c395e1","author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"date":"2017-02-16 03:32:09.000000000","message":"Patch Set 2:\n\nHi Hugh, I\u0027m fixing a bug, that fix your issue by the way. see my unit test case.\n\nhttps://review.openstack.org/#/c/432993/","accounts_in_message":[],"_revision_number":2},{"id":"7f5985aa1dcfda428a623d0df693f0a36221f051","author":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"date":"2017-02-16 04:44:42.000000000","message":"Abandoned\n\nClosing as superseded by https://review.openstack.org/#/c/432993/","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"89eed5a7e47e10352611a9709a60385fc4b848bb","revisions":{"e3a7b6212569dccb7a90ec3303f3010e77f9b3a1":{"kind":"REWORK","_number":1,"created":"2017-02-07 14:12:28.000000000","uploader":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"ref":"refs/changes/66/430266/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/66/430266/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/66/430266/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/66/430266/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/66/430266/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/66/430266/1"}}},"commit":{"parents":[{"commit":"083b115d09b7ccf15bb3c3ab5c799a47efc2d6ac","subject":"Merge \"TODO cleanup: OSC_Config\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/083b115d09b7ccf15bb3c3ab5c799a47efc2d6ac"}]}],"author":{"name":"Hugh Saunders","email":"hugh@wherenow.org","date":"2017-02-07 11:03:54.000000000","tz":0},"committer":{"name":"Hugh Saunders","email":"hugh@wherenow.org","date":"2017-02-07 14:12:26.000000000","tz":0},"subject":"Add helpful message for malformed --nic arg","message":"Add helpful message for malformed --nic arg\n\nCurrently if \"\u003d\" is missing from a --nic arg, the error message is\n\"dictionary update sequence element #0 has length 1; 2 is required\".\nThat is impossible to decipher without reading the code.\n\nThis commit adds a more useful message for the user.\n\nAlso fixes the auto/none test, which wouldn\u0027t match previously as the\nnics list was compared, not an item from the list.\n\nChange-Id: Ib1007c49745b743cdb99c34227816eca82847be6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/e3a7b6212569dccb7a90ec3303f3010e77f9b3a1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/e3a7b6212569dccb7a90ec3303f3010e77f9b3a1"}]},"branch":"refs/heads/master"},"89eed5a7e47e10352611a9709a60385fc4b848bb":{"kind":"REWORK","_number":2,"created":"2017-02-07 15:51:32.000000000","uploader":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"ref":"refs/changes/66/430266/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/66/430266/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/66/430266/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/66/430266/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/66/430266/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/66/430266/2"}}},"commit":{"parents":[{"commit":"083b115d09b7ccf15bb3c3ab5c799a47efc2d6ac","subject":"Merge \"TODO cleanup: OSC_Config\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/083b115d09b7ccf15bb3c3ab5c799a47efc2d6ac"}]}],"author":{"name":"Hugh Saunders","email":"hugh@wherenow.org","date":"2017-02-07 11:03:54.000000000","tz":0},"committer":{"name":"Hugh Saunders","email":"hugh@wherenow.org","date":"2017-02-07 15:51:24.000000000","tz":0},"subject":"Add helpful message for malformed --nic arg","message":"Add helpful message for malformed --nic arg\n\nCurrently if \"\u003d\" is missing from a --nic arg, the error message is\n\"dictionary update sequence element #0 has length 1; 2 is required\".\nThat is impossible to decipher without reading the code.\n\nThis commit adds a more useful message for the user.\n\nAlso fixes the auto/none test, which wouldn\u0027t match previously as the\nnics list was compared, not an item from the list.\n\nChange-Id: Ib1007c49745b743cdb99c34227816eca82847be6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/89eed5a7e47e10352611a9709a60385fc4b848bb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/89eed5a7e47e10352611a9709a60385fc4b848bb"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}