)]}'
{"id":"openstack%2Fpython-openstackclient~430508","triplet_id":"openstack%2Fpython-openstackclient~master~Ie6b9d8cfc57a6943b5d64a4064e4bdd372cd8cd3","project":"openstack/python-openstackclient","branch":"master","topic":"bug/1654913","hashtags":[],"change_id":"Ie6b9d8cfc57a6943b5d64a4064e4bdd372cd8cd3","subject":"Use public and unified method get_console_url()","status":"MERGED","created":"2017-02-08 02:18:04.000000000","updated":"2017-02-20 19:46:15.000000000","submitted":"2017-02-20 19:46:15.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"d9fc023f480e21a2518d6f829b2ce27b86d5bee7","_number":430508,"virtual_id_number":430508,"owner":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2017-02-20 19:46:15.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},{"value":0,"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},{"value":0,"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":0,"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},{"value":2,"date":"2017-02-20 18:41:33.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},{"value":1,"date":"2017-02-14 18:14:34.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},{"value":0,"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":2,"date":"2017-02-20 18:39:03.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":0,"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},{"value":1,"date":"2017-02-20 18:41:33.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},{"value":0,"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},{"value":0,"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-02-08 02:20:38.000000000","updated_by":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"reviewer":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"state":"REVIEWER"},{"updated":"2017-02-14 01:28:11.000000000","updated_by":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"reviewer":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"state":"REVIEWER"},{"updated":"2017-02-14 18:14:34.000000000","updated_by":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"reviewer":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"state":"REVIEWER"},{"updated":"2017-02-20 18:39:03.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2017-02-20 18:41:33.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2017-02-20 19:46:15.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"95d973e4a08a7f33613275fe23d9040d8462870e","author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"date":"2017-02-08 02:18:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4a01ec636c665c0a1e208f6915650d3c7ffdb6ff","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2017-02-08 02:23:37.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"71c1531751f4629e4892c45c7cd2ebad7e02025b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-02-08 03:48:39.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/08/430508/1/check/gate-python-openstackclient-docs-ubuntu-xenial/fea4f05//doc/build/html/ : SUCCESS in 2m 33s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/08/430508/1/check/gate-python-openstackclient-pep8-ubuntu-xenial/c8d8abc/ : SUCCESS in 3m 07s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/08/430508/1/check/gate-python-openstackclient-python27-ubuntu-xenial/d19c5a7/ : SUCCESS in 2m 31s\n- gate-python-openstackclient-python35 http://logs.openstack.org/08/430508/1/check/gate-python-openstackclient-python35/08b4efa/ : SUCCESS in 2m 20s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial http://logs.openstack.org/08/430508/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial/21561ec/ : SUCCESS in 1h 07m 42s\n- check-osc-plugins http://logs.openstack.org/08/430508/1/check/check-osc-plugins/a41f58f/ : SUCCESS in 5m 39s (non-voting)\n- gate-osc-dsvm-functional-ubuntu-xenial http://logs.openstack.org/08/430508/1/check/gate-osc-dsvm-functional-ubuntu-xenial/c8d2159/ : SUCCESS in 31m 51s\n- gate-osc-dsvm-functional-tips-ubuntu-xenial-nv http://logs.openstack.org/08/430508/1/check/gate-osc-dsvm-functional-tips-ubuntu-xenial-nv/6b0e6ec/ : SUCCESS in 32m 04s (non-voting)\n- gate-tripleo-ci-centos-7-nonha-multinode-nv http://logs.openstack.org/08/430508/1/check/gate-tripleo-ci-centos-7-nonha-multinode-nv/da1a02f/ : SUCCESS in 1h 30m 17s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"6a996aa3ffb2ce29481ae26943e75b924b96e4e8","author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"date":"2017-02-08 06:27:42.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"5a43d83f2d23bb2d45b87f5ae946e1c02f1472b7","author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"date":"2017-02-14 03:22:03.000000000","message":"Patch Set 2: Patch Set 1 was rebased","accounts_in_message":[],"_revision_number":1},{"id":"921ad1e6fdf19c3c2ee6a4ad9c2ca67f5acc6552","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-02-14 04:39:05.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/08/430508/2/check/gate-python-openstackclient-docs-ubuntu-xenial/4a6aafa//doc/build/html/ : SUCCESS in 3m 20s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/08/430508/2/check/gate-python-openstackclient-pep8-ubuntu-xenial/2c3fe20/ : SUCCESS in 5m 34s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/08/430508/2/check/gate-python-openstackclient-python27-ubuntu-xenial/581b234/ : SUCCESS in 2m 32s\n- gate-python-openstackclient-python35 http://logs.openstack.org/08/430508/2/check/gate-python-openstackclient-python35/aeab70f/ : SUCCESS in 3m 01s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial http://logs.openstack.org/08/430508/2/check/gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial/5a142ac/ : SUCCESS in 1h 16m 06s\n- check-osc-plugins http://logs.openstack.org/08/430508/2/check/check-osc-plugins/2853276/ : SUCCESS in 3m 55s (non-voting)\n- gate-osc-dsvm-functional-ubuntu-xenial http://logs.openstack.org/08/430508/2/check/gate-osc-dsvm-functional-ubuntu-xenial/cec92ec/ : SUCCESS in 47m 43s\n- gate-osc-dsvm-functional-tips-ubuntu-xenial-nv http://logs.openstack.org/08/430508/2/check/gate-osc-dsvm-functional-tips-ubuntu-xenial-nv/6a2ace7/ : SUCCESS in 31m 20s (non-voting)\n- gate-tripleo-ci-centos-7-nonha-multinode-nv http://logs.openstack.org/08/430508/2/check/gate-tripleo-ci-centos-7-nonha-multinode-nv/e0a5129/ : SUCCESS in 1h 06m 50s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"eac5bfb15a816c0620492408122cc05398f0207c","author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"date":"2017-02-14 18:14:34.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"3d9ce692975948fa8930b1ad56b89780391a0642","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2017-02-15 19:12:17.000000000","message":"Patch Set 2:\n\nThis is a nice cleanup, and novaclient 7.1.0 is in our min requirements now.\n\nAre there any user-visible changes due to this, such as URLformats changed it additional console types supported?","accounts_in_message":[],"_revision_number":2},{"id":"2c38d62f9dcf16781a18d6026f9f9b1e34515fa9","author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"date":"2017-02-16 01:38:10.000000000","message":"Patch Set 2:\n\n@Dean Troyer：\nThanks for reviewing. The URLformats are same as before, when api version is 2.0-2.5, the url format still likes /servers/%s/action (with body info {os-getVNCConsole:{type: novnc}}); when api version is 2.6-latest, the url format still likes /remote-consoles. And about the unsupported console type, novaclient will raise corresponding exception to user.","accounts_in_message":[],"_revision_number":2},{"id":"e3cdacfcf06e34bcf9bca7d37766b72bd5185ea1","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2017-02-17 16:27:55.000000000","message":"Patch Set 2:\n\nThanks for the explanation.  since this is tied to a bug I\u0027m trying to decide what should go into a release note.  If na OSC user will see no differences at all then I suppose nothing needs to go in, otherwise we need to explain that difference.","accounts_in_message":[],"_revision_number":2},{"id":"c3ed85da27585022b2de30afcbeac63dd42d1131","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2017-02-20 18:39:03.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"ab3706715423378d0b7446a2e97855ae61162627","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2017-02-20 18:41:33.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"489bc296729e740495ea7484cc1ff638e9dda0f1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-02-20 18:41:44.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"acd36fc9dd7c655b8f670d839eb13fe95080497b","date":"2017-02-20 19:46:15.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"6d93af4f68d59dfc33d02284c98072b8a6f411b6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-02-20 19:46:15.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/08/430508/2/gate/gate-python-openstackclient-docs-ubuntu-xenial/96f26aa//doc/build/html/ : SUCCESS in 7m 13s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/08/430508/2/gate/gate-python-openstackclient-pep8-ubuntu-xenial/9ad9ac0/ : SUCCESS in 5m 38s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/08/430508/2/gate/gate-python-openstackclient-python27-ubuntu-xenial/c252e56/ : SUCCESS in 4m 48s\n- gate-python-openstackclient-python35 http://logs.openstack.org/08/430508/2/gate/gate-python-openstackclient-python35/a2f9bfb/ : SUCCESS in 2m 33s\n- gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial http://logs.openstack.org/08/430508/2/gate/gate-tempest-dsvm-neutron-src-python-openstackclient-ubuntu-xenial/21fe77d/ : SUCCESS in 1h 03m 27s\n- gate-osc-dsvm-functional-ubuntu-xenial http://logs.openstack.org/08/430508/2/gate/gate-osc-dsvm-functional-ubuntu-xenial/224b84a/ : SUCCESS in 27m 26s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"f891b6862f0b980051b7e6e0d88eb6e10b72ac29","revisions":{"5b2b5e147d8cd8a25a2f7fe0009d8defb19f516d":{"kind":"REWORK","_number":1,"created":"2017-02-08 02:18:04.000000000","uploader":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"ref":"refs/changes/08/430508/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/08/430508/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/08/430508/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/08/430508/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/08/430508/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/08/430508/1"}}},"commit":{"parents":[{"commit":"3afd2b7ff25af7e7998e9c8f4adac8a58a079675","subject":"Fix \"module list --all\" failed","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/3afd2b7ff25af7e7998e9c8f4adac8a58a079675"}]}],"author":{"name":"huangtianhua","email":"huangtianhua@huawei.com","date":"2017-01-09 02:11:02.000000000","tz":480},"committer":{"name":"huangtianhua","email":"huangtianhua@huawei.com","date":"2017-02-08 02:17:56.000000000","tz":480},"subject":"Use public and unified method get_console_url()","message":"Use public and unified method get_console_url()\n\nNovaclient has provided a public and unified method\nget_console_url() to get console urls of server.\nThis change switches to use it.\n\nChange-Id: Ie6b9d8cfc57a6943b5d64a4064e4bdd372cd8cd3\nDepends-on: I36c6209b17ef453e1c2e47841daf41f81af471dc\nCloses-Bug: #1654913\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/5b2b5e147d8cd8a25a2f7fe0009d8defb19f516d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/5b2b5e147d8cd8a25a2f7fe0009d8defb19f516d"}]},"branch":"refs/heads/master"},"f891b6862f0b980051b7e6e0d88eb6e10b72ac29":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2017-02-14 03:22:03.000000000","uploader":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"ref":"refs/changes/08/430508/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/08/430508/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/08/430508/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/08/430508/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/08/430508/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/08/430508/2"}}},"commit":{"parents":[{"commit":"f945cf7b5c263ca2fa47c636b498cd286b9767db","subject":"Merge \"Handle log message interpolation by the logger in compute/\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/f945cf7b5c263ca2fa47c636b498cd286b9767db"}]}],"author":{"name":"huangtianhua","email":"huangtianhua@huawei.com","date":"2017-01-09 02:11:02.000000000","tz":480},"committer":{"name":"huangtianhua","email":"huangtianhua@huawei.com","date":"2017-02-14 03:22:03.000000000","tz":0},"subject":"Use public and unified method get_console_url()","message":"Use public and unified method get_console_url()\n\nNovaclient has provided a public and unified method\nget_console_url() to get console urls of server.\nThis change switches to use it.\n\nChange-Id: Ie6b9d8cfc57a6943b5d64a4064e4bdd372cd8cd3\nDepends-on: I36c6209b17ef453e1c2e47841daf41f81af471dc\nCloses-Bug: #1654913\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/f891b6862f0b980051b7e6e0d88eb6e10b72ac29"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/f891b6862f0b980051b7e6e0d88eb6e10b72ac29"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}