)]}'
{"openstackclient/tests/functional/compute/v2/test_aggregate.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"3ff180c30a910cc076c861af6c1134f7595e737e","unresolved":false,"context_lines":[{"line_number":120,"context_line":"            cmd_output[\u0027availability_zone\u0027]"},{"line_number":121,"context_line":"        )"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def test_aggregate_property(self):"},{"line_number":124,"context_line":"        \"\"\"Test aggregate set and unset property\"\"\""},{"line_number":125,"context_line":"        name \u003d uuid.uuid4().hex"},{"line_number":126,"context_line":"        self.openstack("}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_b6a16e48","line":123,"range":{"start_line":123,"start_character":8,"end_line":123,"end_character":31},"updated":"2017-02-08 11:36:24.000000000","message":"why not combine this into test_aggregate_set? i forget the convention we\u0027ve been trying to set","commit_id":"c07fb92a6c747fb9944b9d8812bdb12db07d7cf5"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"6a3bd807139d848e92a41b0dff9453f5b3c1f362","unresolved":false,"context_lines":[{"line_number":120,"context_line":"            cmd_output[\u0027availability_zone\u0027]"},{"line_number":121,"context_line":"        )"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def test_aggregate_property(self):"},{"line_number":124,"context_line":"        \"\"\"Test aggregate set and unset property\"\"\""},{"line_number":125,"context_line":"        name \u003d uuid.uuid4().hex"},{"line_number":126,"context_line":"        self.openstack("}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_ef013006","line":123,"range":{"start_line":123,"start_character":8,"end_line":123,"end_character":31},"in_reply_to":"1a430d35_6234a0fb","updated":"2017-02-09 05:43:18.000000000","message":"Agree with Steve, we need not keep too much consistence with the base, we just make the new test better than the old","commit_id":"c07fb92a6c747fb9944b9d8812bdb12db07d7cf5"},{"author":{"_account_id":24081,"name":"zhiyong.dai","email":"zhiyong.dai@easystack.cn","username":"zhiyong.dai"},"change_message_id":"f910f44dda3d0b0a67d876e8f3e2aa2a213ff909","unresolved":false,"context_lines":[{"line_number":120,"context_line":"            cmd_output[\u0027availability_zone\u0027]"},{"line_number":121,"context_line":"        )"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def test_aggregate_property(self):"},{"line_number":124,"context_line":"        \"\"\"Test aggregate set and unset property\"\"\""},{"line_number":125,"context_line":"        name \u003d uuid.uuid4().hex"},{"line_number":126,"context_line":"        self.openstack("}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_6234a0fb","line":123,"range":{"start_line":123,"start_character":8,"end_line":123,"end_character":31},"in_reply_to":"1a430d35_b6a16e48","updated":"2017-02-08 12:47:49.000000000","message":"There is \"test_aggregate_properties\" in the Base, so I \nreserved it.","commit_id":"c07fb92a6c747fb9944b9d8812bdb12db07d7cf5"},{"author":{"_account_id":24081,"name":"zhiyong.dai","email":"zhiyong.dai@easystack.cn","username":"zhiyong.dai"},"change_message_id":"b0687c1b37be42a55a0f07ec2cc53c983a4ec19a","unresolved":false,"context_lines":[{"line_number":120,"context_line":"            cmd_output[\u0027availability_zone\u0027]"},{"line_number":121,"context_line":"        )"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def test_aggregate_property(self):"},{"line_number":124,"context_line":"        \"\"\"Test aggregate set and unset property\"\"\""},{"line_number":125,"context_line":"        name \u003d uuid.uuid4().hex"},{"line_number":126,"context_line":"        self.openstack("}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_0fcd9c30","line":123,"range":{"start_line":123,"start_character":8,"end_line":123,"end_character":31},"in_reply_to":"1a430d35_ef013006","updated":"2017-02-09 06:12:53.000000000","message":"OK, I made the change.","commit_id":"c07fb92a6c747fb9944b9d8812bdb12db07d7cf5"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"3ff180c30a910cc076c861af6c1134f7595e737e","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        host_name \u003d cmd_output[0][\u0027Host Name\u0027]"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        # Test add host"},{"line_number":179,"context_line":"        cmd_output \u003d json.loads(self.openstack("},{"line_number":180,"context_line":"            \u0027aggregate add host -f json \u0027 +"},{"line_number":181,"context_line":"            name + \u0027 \u0027 +"},{"line_number":182,"context_line":"            host_name"},{"line_number":183,"context_line":"        ))"},{"line_number":184,"context_line":"        self.assertIn("},{"line_number":185,"context_line":"            host_name,"},{"line_number":186,"context_line":"            cmd_output[\u0027hosts\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_b646ce78","line":183,"range":{"start_line":179,"start_character":8,"end_line":183,"end_character":10},"updated":"2017-02-08 11:36:24.000000000","message":"interesting, do we normally have output for \"add\" commands?","commit_id":"c07fb92a6c747fb9944b9d8812bdb12db07d7cf5"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"6a3bd807139d848e92a41b0dff9453f5b3c1f362","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        host_name \u003d cmd_output[0][\u0027Host Name\u0027]"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        # Test add host"},{"line_number":179,"context_line":"        cmd_output \u003d json.loads(self.openstack("},{"line_number":180,"context_line":"            \u0027aggregate add host -f json \u0027 +"},{"line_number":181,"context_line":"            name + \u0027 \u0027 +"},{"line_number":182,"context_line":"            host_name"},{"line_number":183,"context_line":"        ))"},{"line_number":184,"context_line":"        self.assertIn("},{"line_number":185,"context_line":"            host_name,"},{"line_number":186,"context_line":"            cmd_output[\u0027hosts\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_346c6d07","line":183,"range":{"start_line":179,"start_character":8,"end_line":183,"end_character":10},"in_reply_to":"1a430d35_b646ce78","updated":"2017-02-09 05:43:18.000000000","message":"Normally I guess not, but there is","commit_id":"c07fb92a6c747fb9944b9d8812bdb12db07d7cf5"},{"author":{"_account_id":24081,"name":"zhiyong.dai","email":"zhiyong.dai@easystack.cn","username":"zhiyong.dai"},"change_message_id":"f910f44dda3d0b0a67d876e8f3e2aa2a213ff909","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        host_name \u003d cmd_output[0][\u0027Host Name\u0027]"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        # Test add host"},{"line_number":179,"context_line":"        cmd_output \u003d json.loads(self.openstack("},{"line_number":180,"context_line":"            \u0027aggregate add host -f json \u0027 +"},{"line_number":181,"context_line":"            name + \u0027 \u0027 +"},{"line_number":182,"context_line":"            host_name"},{"line_number":183,"context_line":"        ))"},{"line_number":184,"context_line":"        self.assertIn("},{"line_number":185,"context_line":"            host_name,"},{"line_number":186,"context_line":"            cmd_output[\u0027hosts\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_a211285f","line":183,"range":{"start_line":179,"start_character":8,"end_line":183,"end_character":10},"in_reply_to":"1a430d35_b646ce78","updated":"2017-02-08 12:47:49.000000000","message":"Yes, \"add host\" and \"remove host\" both have output.","commit_id":"c07fb92a6c747fb9944b9d8812bdb12db07d7cf5"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"480cae80e8cc809db408446b8ebddf57b76da572","unresolved":false,"context_lines":[{"line_number":19,"context_line":"class AggregateTests(base.TestCase):"},{"line_number":20,"context_line":"    \"\"\"Functional tests for aggregate.\"\"\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    def test_aggregate_delete(self):"},{"line_number":23,"context_line":"        \"\"\"Test create, delete multiple\"\"\""},{"line_number":24,"context_line":"        name1 \u003d uuid.uuid4().hex"},{"line_number":25,"context_line":"        name2 \u003d uuid.uuid4().hex"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_566f1192","line":22,"range":{"start_line":22,"start_character":23,"end_line":22,"end_character":29},"updated":"2017-02-10 05:52:05.000000000","message":"nit: Can we rename this to \"create_and_delete\"? did not see any test for create from the test names","commit_id":"23fda6beba7b1babb40bd22f04eef855b940c4ff"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"480cae80e8cc809db408446b8ebddf57b76da572","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        self.assertIn({\u0027a\u0027: \u0027b\u0027}, properties)"},{"line_number":93,"context_line":"        self.assertIn({\u0027c\u0027: \u0027d\u0027}, properties)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def test_aggregate_set(self):"},{"line_number":96,"context_line":"        \"\"\"Test aggregate set, show\"\"\""},{"line_number":97,"context_line":"        name1 \u003d uuid.uuid4().hex"},{"line_number":98,"context_line":"        name2 \u003d uuid.uuid4().hex"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_9673494d","line":95,"updated":"2017-02-10 05:52:05.000000000","message":"I guess it is OK to combine set and unset test into one test like \"test_aggregate_set_and_unset\", it may make test easier","commit_id":"23fda6beba7b1babb40bd22f04eef855b940c4ff"}]}