)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"c6b269f26656ea01f844bfa00c30afdefb4393f2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add new parameter \"is_default\" to Network QoS policy."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added new excluding parameters to Network QoS policy:"},{"line_number":10,"context_line":"  --default: makes this policy the default policy for"},{"line_number":11,"context_line":"             the project to which belongs."},{"line_number":12,"context_line":"  --no-default: unset the property."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"da36d5c6_3742f668","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":52},"updated":"2017-02-23 21:15:43.000000000","message":"Add a set of exclusive parameters to the Network QoS policy.","commit_id":"e79bf9a5f64137243ec107843d75f02801bb8a7a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a93b34095d6c5f7b774c68839de977f276047a61","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add new parameter \"is_default\" to Network QoS policy."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added new excluding parameters to Network QoS policy:"},{"line_number":10,"context_line":"  --default: makes this policy the default policy for"},{"line_number":11,"context_line":"             the project to which belongs."},{"line_number":12,"context_line":"  --no-default: unset the property."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"da36d5c6_cf5d7a16","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":52},"in_reply_to":"da36d5c6_3742f668","updated":"2017-02-23 23:00:22.000000000","message":"Done","commit_id":"e79bf9a5f64137243ec107843d75f02801bb8a7a"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"c6b269f26656ea01f844bfa00c30afdefb4393f2","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added new excluding parameters to Network QoS policy:"},{"line_number":10,"context_line":"  --default: makes this policy the default policy for"},{"line_number":11,"context_line":"             the project to which belongs."},{"line_number":12,"context_line":"  --no-default: unset the property."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1639220"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"da36d5c6_1206e01c","line":11,"range":{"start_line":11,"start_character":33,"end_line":11,"end_character":40},"updated":"2017-02-23 21:15:43.000000000","message":"belongs -\u003e the qos policy belongs.","commit_id":"e79bf9a5f64137243ec107843d75f02801bb8a7a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a93b34095d6c5f7b774c68839de977f276047a61","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added new excluding parameters to Network QoS policy:"},{"line_number":10,"context_line":"  --default: makes this policy the default policy for"},{"line_number":11,"context_line":"             the project to which belongs."},{"line_number":12,"context_line":"  --no-default: unset the property."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1639220"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"da36d5c6_ef9cfec1","line":11,"range":{"start_line":11,"start_character":33,"end_line":11,"end_character":40},"in_reply_to":"da36d5c6_1206e01c","updated":"2017-02-23 23:00:22.000000000","message":"Done","commit_id":"e79bf9a5f64137243ec107843d75f02801bb8a7a"}],"doc/source/command-objects/network-qos-policy.rst":[{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"601cd891fabdf1e055160ee45fdf33fed6349f08","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    Set this as a default network QoS policy"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":".. option:: --no-default"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    Set this as a non-default network QoS policy"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa31d9ce_368a4fc0","line":51,"updated":"2017-02-13 08:43:31.000000000","message":"I guess \"no-default\" is the default when create without these options, right? we could mark this as default in the help message","commit_id":"a817e0920699f0841c2d0ebb30c0165123eebbd3"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"88e6cfe26c46734c37d13bd6981e71b408153093","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    Set this as a default network QoS policy"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":".. option:: --no-default"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    Set this as a non-default network QoS policy"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa31d9ce_11e1d5fe","line":51,"in_reply_to":"fa31d9ce_368a4fc0","updated":"2017-02-13 09:13:00.000000000","message":"You are right. \"no-default\" is ironically the default one. I\u0027ll change it.","commit_id":"a817e0920699f0841c2d0ebb30c0165123eebbd3"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"01fc583772e05769ec2f8c62d7cbda3960263271","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    Domain the project belongs to (name or ID)."},{"line_number":44,"context_line":"    This can be used in case collisions between project names exist."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":".. _network_qos_policy_create-name:"},{"line_number":47,"context_line":".. describe:: \u003cname\u003e"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    New QoS policy specification name"}],"source_content_type":"text/x-rst","patch_set":11,"id":"df140735_3d65e91e","side":"PARENT","line":46,"range":{"start_line":46,"start_character":0,"end_line":46,"end_character":35},"updated":"2017-06-02 07:07:45.000000000","message":"please don\u0027t remove the anchor.","commit_id":"b78153aec4f050e64ee8ec9c930ae673bb3ecd47"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1c90d6db6f8a4abfbd6b59f6b1cd0882861c2928","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    Domain the project belongs to (name or ID)."},{"line_number":44,"context_line":"    This can be used in case collisions between project names exist."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":".. _network_qos_policy_create-name:"},{"line_number":47,"context_line":".. describe:: \u003cname\u003e"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    New QoS policy specification name"}],"source_content_type":"text/x-rst","patch_set":11,"id":"df140735_eb96873e","side":"PARENT","line":46,"range":{"start_line":46,"start_character":0,"end_line":46,"end_character":35},"in_reply_to":"df140735_3d65e91e","updated":"2017-06-02 08:31:53.000000000","message":"Done","commit_id":"b78153aec4f050e64ee8ec9c930ae673bb3ecd47"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"01fc583772e05769ec2f8c62d7cbda3960263271","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    Make the QoS policy not accessible by other projects"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":".. _network_qos_policy_set-qos-policy:"},{"line_number":127,"context_line":".. describe:: \u003cqos-policy\u003e"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    Network QoS policy to modify (name or ID)"}],"source_content_type":"text/x-rst","patch_set":11,"id":"df140735_9db0758c","side":"PARENT","line":126,"range":{"start_line":126,"start_character":0,"end_line":126,"end_character":38},"updated":"2017-06-02 07:07:45.000000000","message":"please don\u0027t remove the anchor.","commit_id":"b78153aec4f050e64ee8ec9c930ae673bb3ecd47"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1c90d6db6f8a4abfbd6b59f6b1cd0882861c2928","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    Make the QoS policy not accessible by other projects"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":".. _network_qos_policy_set-qos-policy:"},{"line_number":127,"context_line":".. describe:: \u003cqos-policy\u003e"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    Network QoS policy to modify (name or ID)"}],"source_content_type":"text/x-rst","patch_set":11,"id":"df140735_aba40fa7","side":"PARENT","line":126,"range":{"start_line":126,"start_character":0,"end_line":126,"end_character":38},"in_reply_to":"df140735_9db0758c","updated":"2017-06-02 08:31:53.000000000","message":"Done","commit_id":"b78153aec4f050e64ee8ec9c930ae673bb3ecd47"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"01fc583772e05769ec2f8c62d7cbda3960263271","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":".. option:: --no-default"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    Set this as a non-default network QoS policy (default)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":".. describe:: \u003cname\u003e"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"df140735_3cee10b4","line":53,"range":{"start_line":53,"start_character":49,"end_line":53,"end_character":58},"updated":"2017-06-02 07:07:45.000000000","message":"ditto","commit_id":"e22d68290509042e235c9e1e59b8727c38cf1dfa"}],"openstackclient/network/v2/network_qos_policy.py":[{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"601cd891fabdf1e055160ee45fdf33fed6349f08","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        attrs[\u0027is_default\u0027] \u003d True"},{"line_number":50,"context_line":"    if parsed_args.no_default:"},{"line_number":51,"context_line":"        attrs[\u0027is_default\u0027] \u003d False"},{"line_number":52,"context_line":"    if is_create and parsed_args.project is not None:"},{"line_number":53,"context_line":"        identity_client \u003d client_manager.identity"},{"line_number":54,"context_line":"        project_id \u003d identity_common.find_project("},{"line_number":55,"context_line":"            identity_client,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_96ee9bb2","line":52,"range":{"start_line":52,"start_character":7,"end_line":52,"end_character":16},"updated":"2017-02-13 08:43:31.000000000","message":"just suggestion, you could use \"if \u0027project\u0027 in parsed_args\" and the \"is_create\" variable is no longer required","commit_id":"a817e0920699f0841c2d0ebb30c0165123eebbd3"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"be7c263df274afc254609a2b53af26d0fdf1af3d","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        attrs[\u0027is_default\u0027] \u003d True"},{"line_number":50,"context_line":"    if parsed_args.no_default:"},{"line_number":51,"context_line":"        attrs[\u0027is_default\u0027] \u003d False"},{"line_number":52,"context_line":"    if is_create and parsed_args.project is not None:"},{"line_number":53,"context_line":"        identity_client \u003d client_manager.identity"},{"line_number":54,"context_line":"        project_id \u003d identity_common.find_project("},{"line_number":55,"context_line":"            identity_client,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_ece706e2","line":52,"range":{"start_line":52,"start_character":7,"end_line":52,"end_character":16},"in_reply_to":"fa31d9ce_8c8cca80","updated":"2017-02-13 09:19:19.000000000","message":"Yes, you are right that \"--project\" is an optional, but we can only say that the value of \"project\" in changeable, if \"--project\" is not specified, the value of \"project\" will be None but \"project\" will still in parsed_args :)","commit_id":"a817e0920699f0841c2d0ebb30c0165123eebbd3"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"88e6cfe26c46734c37d13bd6981e71b408153093","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        attrs[\u0027is_default\u0027] \u003d True"},{"line_number":50,"context_line":"    if parsed_args.no_default:"},{"line_number":51,"context_line":"        attrs[\u0027is_default\u0027] \u003d False"},{"line_number":52,"context_line":"    if is_create and parsed_args.project is not None:"},{"line_number":53,"context_line":"        identity_client \u003d client_manager.identity"},{"line_number":54,"context_line":"        project_id \u003d identity_common.find_project("},{"line_number":55,"context_line":"            identity_client,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_8c8cca80","line":52,"range":{"start_line":52,"start_character":7,"end_line":52,"end_character":16},"in_reply_to":"fa31d9ce_96ee9bb2","updated":"2017-02-13 09:13:00.000000000","message":"\"--project\" is an optional input argument. Not all create commands will have this one.","commit_id":"a817e0920699f0841c2d0ebb30c0165123eebbd3"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f9b7c005055cbf19f675d0f2a5c337dbf2ca60c0","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        attrs[\u0027is_default\u0027] \u003d True"},{"line_number":50,"context_line":"    if parsed_args.no_default:"},{"line_number":51,"context_line":"        attrs[\u0027is_default\u0027] \u003d False"},{"line_number":52,"context_line":"    if is_create and parsed_args.project is not None:"},{"line_number":53,"context_line":"        identity_client \u003d client_manager.identity"},{"line_number":54,"context_line":"        project_id \u003d identity_common.find_project("},{"line_number":55,"context_line":"            identity_client,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_ce5eb775","line":52,"range":{"start_line":52,"start_character":7,"end_line":52,"end_character":16},"in_reply_to":"fa31d9ce_ece706e2","updated":"2017-02-13 09:45:20.000000000","message":"You are right!","commit_id":"a817e0920699f0841c2d0ebb30c0165123eebbd3"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"601cd891fabdf1e055160ee45fdf33fed6349f08","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    default_group.add_argument("},{"line_number":67,"context_line":"        \u0027--default\u0027,"},{"line_number":68,"context_line":"        action\u003d\u0027store_true\u0027,"},{"line_number":69,"context_line":"        help\u003d_(\"Set this as a default subnet pool\"),"},{"line_number":70,"context_line":"    )"},{"line_number":71,"context_line":"    default_group.add_argument("},{"line_number":72,"context_line":"        \u0027--no-default\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_36b08f43","line":69,"range":{"start_line":69,"start_character":28,"end_line":69,"end_character":49},"updated":"2017-02-13 08:43:31.000000000","message":"network QoS policy?","commit_id":"a817e0920699f0841c2d0ebb30c0165123eebbd3"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"88e6cfe26c46734c37d13bd6981e71b408153093","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    default_group.add_argument("},{"line_number":67,"context_line":"        \u0027--default\u0027,"},{"line_number":68,"context_line":"        action\u003d\u0027store_true\u0027,"},{"line_number":69,"context_line":"        help\u003d_(\"Set this as a default subnet pool\"),"},{"line_number":70,"context_line":"    )"},{"line_number":71,"context_line":"    default_group.add_argument("},{"line_number":72,"context_line":"        \u0027--no-default\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_31a419a5","line":69,"range":{"start_line":69,"start_character":28,"end_line":69,"end_character":49},"in_reply_to":"fa31d9ce_36b08f43","updated":"2017-02-13 09:13:00.000000000","message":"Yes... the problems of copy-paste","commit_id":"a817e0920699f0841c2d0ebb30c0165123eebbd3"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"c6b269f26656ea01f844bfa00c30afdefb4393f2","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        default_group.add_argument("},{"line_number":223,"context_line":"            \u0027--no-default\u0027,"},{"line_number":224,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":225,"context_line":"            help\u003d_(\"Set this as a non-default network QoS policy (default)\"),"},{"line_number":226,"context_line":"        )"},{"line_number":227,"context_line":"        return parser"},{"line_number":228,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da36d5c6_52a858db","line":225,"range":{"start_line":225,"start_character":66,"end_line":225,"end_character":73},"updated":"2017-02-23 21:15:43.000000000","message":"(default) is not in the RST file. so you can remove it from this help message as well.","commit_id":"e79bf9a5f64137243ec107843d75f02801bb8a7a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a93b34095d6c5f7b774c68839de977f276047a61","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        default_group.add_argument("},{"line_number":223,"context_line":"            \u0027--no-default\u0027,"},{"line_number":224,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":225,"context_line":"            help\u003d_(\"Set this as a non-default network QoS policy (default)\"),"},{"line_number":226,"context_line":"        )"},{"line_number":227,"context_line":"        return parser"},{"line_number":228,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da36d5c6_0f895275","line":225,"range":{"start_line":225,"start_character":66,"end_line":225,"end_character":73},"in_reply_to":"da36d5c6_52a858db","updated":"2017-02-23 23:00:22.000000000","message":"Done","commit_id":"e79bf9a5f64137243ec107843d75f02801bb8a7a"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"01fc583772e05769ec2f8c62d7cbda3960263271","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        attrs[\u0027shared\u0027] \u003d True"},{"line_number":46,"context_line":"    if parsed_args.no_share:"},{"line_number":47,"context_line":"        attrs[\u0027shared\u0027] \u003d False"},{"line_number":48,"context_line":"    if \u0027default\u0027 in parsed_args and parsed_args.default:"},{"line_number":49,"context_line":"        attrs[\u0027is_default\u0027] \u003d True"},{"line_number":50,"context_line":"    if \u0027default\u0027 in parsed_args and parsed_args.no_default:"},{"line_number":51,"context_line":"        attrs[\u0027is_default\u0027] \u003d False"}],"source_content_type":"text/x-python","patch_set":11,"id":"df140735_dcb5d47f","line":48,"range":{"start_line":48,"start_character":7,"end_line":48,"end_character":31},"updated":"2017-06-02 07:07:45.000000000","message":"Make me confused at the begin, until I found _get_attrs() is used by list and set and create commands, I think \u0027xxx\u0027 in parsed_args means we define the option in current command context. Add a NOTE for _get_attrs() method to clarify these, I think that\u0027s good for maintaining code.","commit_id":"e22d68290509042e235c9e1e59b8727c38cf1dfa"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1c90d6db6f8a4abfbd6b59f6b1cd0882861c2928","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        attrs[\u0027shared\u0027] \u003d True"},{"line_number":46,"context_line":"    if parsed_args.no_share:"},{"line_number":47,"context_line":"        attrs[\u0027shared\u0027] \u003d False"},{"line_number":48,"context_line":"    if \u0027default\u0027 in parsed_args and parsed_args.default:"},{"line_number":49,"context_line":"        attrs[\u0027is_default\u0027] \u003d True"},{"line_number":50,"context_line":"    if \u0027default\u0027 in parsed_args and parsed_args.no_default:"},{"line_number":51,"context_line":"        attrs[\u0027is_default\u0027] \u003d False"}],"source_content_type":"text/x-python","patch_set":11,"id":"df140735_068092bf","line":48,"range":{"start_line":48,"start_character":7,"end_line":48,"end_character":31},"in_reply_to":"df140735_dcb5d47f","updated":"2017-06-02 08:31:53.000000000","message":"Done","commit_id":"e22d68290509042e235c9e1e59b8727c38cf1dfa"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"01fc583772e05769ec2f8c62d7cbda3960263271","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        default_group.add_argument("},{"line_number":105,"context_line":"            \u0027--no-default\u0027,"},{"line_number":106,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":107,"context_line":"            help\u003d_(\"Set this as a non-default network QoS policy (default)\"),"},{"line_number":108,"context_line":"        )"},{"line_number":109,"context_line":"        return parser"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"df140735_5ce2e4a1","line":107,"range":{"start_line":107,"start_character":64,"end_line":107,"end_character":74},"updated":"2017-06-02 07:07:45.000000000","message":"non-default QoS policy is server side default behavior, please don\u0027t expose it in client side help message unless we set default\u003dTrue explicitly. Server side behavior might be changed in the future, it\u0027s not big chance, but I don\u0027t want to confuse user when it happen.","commit_id":"e22d68290509042e235c9e1e59b8727c38cf1dfa"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1c90d6db6f8a4abfbd6b59f6b1cd0882861c2928","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        default_group.add_argument("},{"line_number":105,"context_line":"            \u0027--no-default\u0027,"},{"line_number":106,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":107,"context_line":"            help\u003d_(\"Set this as a non-default network QoS policy (default)\"),"},{"line_number":108,"context_line":"        )"},{"line_number":109,"context_line":"        return parser"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"df140735_66618ed3","line":107,"range":{"start_line":107,"start_character":64,"end_line":107,"end_character":74},"in_reply_to":"df140735_5ce2e4a1","updated":"2017-06-02 08:31:53.000000000","message":"Good catch, this is a server side behaviour, not a client option.","commit_id":"e22d68290509042e235c9e1e59b8727c38cf1dfa"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"01fc583772e05769ec2f8c62d7cbda3960263271","unresolved":false,"context_lines":[{"line_number":190,"context_line":"            \u0027ID\u0027,"},{"line_number":191,"context_line":"            \u0027Name\u0027,"},{"line_number":192,"context_line":"            \u0027Shared\u0027,"},{"line_number":193,"context_line":"            \u0027Default QoS Policy\u0027,"},{"line_number":194,"context_line":"            \u0027Project\u0027,"},{"line_number":195,"context_line":"        )"},{"line_number":196,"context_line":"        attrs \u003d _get_attrs(self.app.client_manager, parsed_args)"}],"source_content_type":"text/x-python","patch_set":11,"id":"df140735_d70c8fed","line":193,"range":{"start_line":193,"start_character":20,"end_line":193,"end_character":31},"updated":"2017-06-02 07:07:45.000000000","message":"Context is QoS policy, so I think the column name is \"Default\", that\u0027s clear enough.","commit_id":"e22d68290509042e235c9e1e59b8727c38cf1dfa"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1c90d6db6f8a4abfbd6b59f6b1cd0882861c2928","unresolved":false,"context_lines":[{"line_number":190,"context_line":"            \u0027ID\u0027,"},{"line_number":191,"context_line":"            \u0027Name\u0027,"},{"line_number":192,"context_line":"            \u0027Shared\u0027,"},{"line_number":193,"context_line":"            \u0027Default QoS Policy\u0027,"},{"line_number":194,"context_line":"            \u0027Project\u0027,"},{"line_number":195,"context_line":"        )"},{"line_number":196,"context_line":"        attrs \u003d _get_attrs(self.app.client_manager, parsed_args)"}],"source_content_type":"text/x-python","patch_set":11,"id":"df140735_063e528b","line":193,"range":{"start_line":193,"start_character":20,"end_line":193,"end_character":31},"in_reply_to":"df140735_d70c8fed","updated":"2017-06-02 08:31:53.000000000","message":"Done","commit_id":"e22d68290509042e235c9e1e59b8727c38cf1dfa"}],"openstackclient/network/v2/subnet_pool.py":[{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"cfe7aa5865869716bd55ff9717cf30e17ad7b8a7","unresolved":false,"context_lines":[{"line_number":359,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":360,"context_line":"            help\u003d_(\"Remove address scope associated with the subnet pool\")"},{"line_number":361,"context_line":"        )"},{"line_number":362,"context_line":"        default_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":363,"context_line":"        default_group.add_argument("},{"line_number":364,"context_line":"            \u0027--default\u0027,"},{"line_number":365,"context_line":"            action\u003d\u0027store_true\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"da36d5c6_9b812dc6","line":362,"range":{"start_line":362,"start_character":8,"end_line":362,"end_character":21},"updated":"2017-02-23 04:39:21.000000000","message":"unrelated change? or maybe update commit msg and release note","commit_id":"1c942d7aa9d5ac76d51d9b019512d185c4767242"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f1fb464768ae506f4ae292991df5094260a9d20d","unresolved":false,"context_lines":[{"line_number":359,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":360,"context_line":"            help\u003d_(\"Remove address scope associated with the subnet pool\")"},{"line_number":361,"context_line":"        )"},{"line_number":362,"context_line":"        default_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":363,"context_line":"        default_group.add_argument("},{"line_number":364,"context_line":"            \u0027--default\u0027,"},{"line_number":365,"context_line":"            action\u003d\u0027store_true\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"da36d5c6_b8bb49e4","line":362,"range":{"start_line":362,"start_character":8,"end_line":362,"end_character":21},"in_reply_to":"da36d5c6_9b812dc6","updated":"2017-02-23 14:33:26.000000000","message":"Ok.... I don\u0027t know how this happend. I opened the worng file. Sorry, I need to be more focused!","commit_id":"1c942d7aa9d5ac76d51d9b019512d185c4767242"}],"openstackclient/tests/functional/network/v2/test_network_qos_policy.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9d6ac8b31a6116c4b4d3c71ba72ff233a39b72be","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        opts \u003d self.get_opts([\u0027is_default\u0027])"},{"line_number":75,"context_line":"        raw_output \u003d self.openstack(\u0027network qos policy show \u0027 + self.NAME +"},{"line_number":76,"context_line":"                                    opts)"},{"line_number":77,"context_line":"        self.assertEqual(\"True\\n\", raw_output)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        self.openstack(\u0027network qos policy set --no-default \u0027 + self.NAME)"},{"line_number":80,"context_line":"        opts \u003d self.get_opts([\u0027is_default\u0027])"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f1d235d_bdf67562","line":77,"updated":"2017-07-05 16:29:59.000000000","message":"Could you use JSON format for new functional tests? We converted functional tests to use JSON format for most tests, but it seems it is one of the remaining ones.\n\n  cmd_output \u003d json.loads(self.openstack(\n    \u0027network qos policy show -f json \u0027 + self.NAME)\n  self.assertTrue(cmd_output[\u0027is_default\u0027])\n\nself.get_opts() will be unnecessary.","commit_id":"c17819ab58db7ded30644d63575d47ee3c963ada"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9d6ac8b31a6116c4b4d3c71ba72ff233a39b72be","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        opts \u003d self.get_opts([\u0027is_default\u0027])"},{"line_number":81,"context_line":"        raw_output \u003d self.openstack(\u0027network qos policy show \u0027 + self.NAME +"},{"line_number":82,"context_line":"                                    opts)"},{"line_number":83,"context_line":"        self.assertEqual(\"False\\n\", raw_output)"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f1d235d_9de739ad","line":83,"updated":"2017-07-05 16:29:59.000000000","message":"Same as the above.","commit_id":"c17819ab58db7ded30644d63575d47ee3c963ada"}],"openstackclient/tests/unit/network/v2/test_network_qos_policy.py":[{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"01fc583772e05769ec2f8c62d7cbda3960263271","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        })"},{"line_number":131,"context_line":"        self.assertEqual(self.columns, columns)"},{"line_number":132,"context_line":"        self.assertEqual(self.data, data)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"class TestDeleteNetworkQosPolicy(TestQosPolicy):"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"df140735_a0966e92","line":133,"updated":"2017-06-02 07:07:45.000000000","message":"please add a case to cover \"network qos policy create --no-default xxx\", like you do for set command.","commit_id":"e22d68290509042e235c9e1e59b8727c38cf1dfa"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1c90d6db6f8a4abfbd6b59f6b1cd0882861c2928","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        })"},{"line_number":131,"context_line":"        self.assertEqual(self.columns, columns)"},{"line_number":132,"context_line":"        self.assertEqual(self.data, data)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"class TestDeleteNetworkQosPolicy(TestQosPolicy):"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"df140735_a6756666","line":133,"in_reply_to":"df140735_a0966e92","updated":"2017-06-02 08:31:53.000000000","message":"Done","commit_id":"e22d68290509042e235c9e1e59b8727c38cf1dfa"}]}