)]}'
{"doc/source/command-objects/router.rst":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"4263f26f485855fb7621eabf81d3620e50bf5f0b","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        [--project \u003cproject\u003e [--project-domain \u003cproject-domain\u003e]]"},{"line_number":65,"context_line":"        [--enable | --disable]"},{"line_number":66,"context_line":"        [--distributed]"},{"line_number":67,"context_line":"        [--centralized]"},{"line_number":68,"context_line":"        [--ha]"},{"line_number":69,"context_line":"        [--description \u003cdescription\u003e]"},{"line_number":70,"context_line":"        [--availability-zone-hint \u003cavailability-zone\u003e]"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a30ddce_7d40c434","line":67,"updated":"2017-03-10 15:10:53.000000000","message":"I think to be correct, this should be on one line, like L227 below:\n\n[--distributed | --centralized]\n\nSince you can\u0027t specify both.","commit_id":"72b91932ac250358c968b0ece6e7ce0dfc0844a3"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"9f5c099b10d34bdde4d34a457088d6d43b0e6319","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        [--project \u003cproject\u003e [--project-domain \u003cproject-domain\u003e]]"},{"line_number":65,"context_line":"        [--enable | --disable]"},{"line_number":66,"context_line":"        [--distributed]"},{"line_number":67,"context_line":"        [--centralized]"},{"line_number":68,"context_line":"        [--ha]"},{"line_number":69,"context_line":"        [--description \u003cdescription\u003e]"},{"line_number":70,"context_line":"        [--availability-zone-hint \u003cavailability-zone\u003e]"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a30ddce_750ef48c","line":67,"in_reply_to":"9a30ddce_7d40c434","updated":"2017-03-13 08:55:41.000000000","message":"done","commit_id":"72b91932ac250358c968b0ece6e7ce0dfc0844a3"}],"openstackclient/network/v2/router.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"a7fa841adab0f2bc65efbe2a3517d0bbad62a4a8","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        distribute_group.add_argument("},{"line_number":180,"context_line":"            \u0027--distributed\u0027,"},{"line_number":181,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":182,"context_line":"            help\u003d_(\"Create a distributed router (admin only)\")"},{"line_number":183,"context_line":"        )"},{"line_number":184,"context_line":"        distribute_group.add_argument("},{"line_number":185,"context_line":"            \u0027--centralized\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_55b5707b","line":182,"range":{"start_line":182,"start_character":48,"end_line":182,"end_character":60},"updated":"2017-03-13 09:03:42.000000000","message":"Why cant a tenant create a distributed or centralized router if router_distributed\u003dTrue in Neutron.conf\n\nAlso, do we need the --centralized option ?\nWont the router be set to centralized if we do not create it as a Distributed router?\n\nWhat would be the default behavior of a router?","commit_id":"b45fb2c6c975098a0aba8e312ac622fb8b0781fb"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"81f9626803b90e9f1451af310133764dfcbb31b4","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        distribute_group.add_argument("},{"line_number":180,"context_line":"            \u0027--distributed\u0027,"},{"line_number":181,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":182,"context_line":"            help\u003d_(\"Create a distributed router (admin only)\")"},{"line_number":183,"context_line":"        )"},{"line_number":184,"context_line":"        distribute_group.add_argument("},{"line_number":185,"context_line":"            \u0027--centralized\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bff0334d_f58dd07b","line":182,"range":{"start_line":182,"start_character":48,"end_line":182,"end_character":60},"in_reply_to":"1a1ced50_0411f903","updated":"2017-04-05 18:53:04.000000000","message":"Done","commit_id":"b45fb2c6c975098a0aba8e312ac622fb8b0781fb"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"355a6eff64203caf461bcd5d446d87e38f0896e5","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        distribute_group.add_argument("},{"line_number":180,"context_line":"            \u0027--distributed\u0027,"},{"line_number":181,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":182,"context_line":"            help\u003d_(\"Create a distributed router (admin only)\")"},{"line_number":183,"context_line":"        )"},{"line_number":184,"context_line":"        distribute_group.add_argument("},{"line_number":185,"context_line":"            \u0027--centralized\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a1ced50_0411f903","line":182,"range":{"start_line":182,"start_character":48,"end_line":182,"end_character":60},"in_reply_to":"1a1ced50_5255bcf7","updated":"2017-03-23 14:36:23.000000000","message":"I would prefer we don\u0027t mention \"(admin only)\" as it depends on policy.json configuration","commit_id":"b45fb2c6c975098a0aba8e312ac622fb8b0781fb"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"d2e5501d12f5c86363063527317ba50f09e9e18c","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        distribute_group.add_argument("},{"line_number":180,"context_line":"            \u0027--distributed\u0027,"},{"line_number":181,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":182,"context_line":"            help\u003d_(\"Create a distributed router (admin only)\")"},{"line_number":183,"context_line":"        )"},{"line_number":184,"context_line":"        distribute_group.add_argument("},{"line_number":185,"context_line":"            \u0027--centralized\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_70b602fa","line":182,"range":{"start_line":182,"start_character":48,"end_line":182,"end_character":60},"in_reply_to":"9a30ddce_55b5707b","updated":"2017-03-13 09:18:02.000000000","message":"Neutron won\u0027t accept if tenants pass these options to neutron router create API. It only allows admin to pass these options.\n\n\"centralized option\" is needed in this below situation -\n For example, when \"router_distributed\u003dTrue\" flag is set in neutron.conf, and admin wants to override this and create a centralized router, then he has to explicitly pass distributed\u003dfalse option through neutron API. So we need centralized option.\n\n\nWhat do you mean by default behavior of a router?","commit_id":"b45fb2c6c975098a0aba8e312ac622fb8b0781fb"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"8087fdf207f7f512e9235a6d385e19cfee5ad042","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        distribute_group.add_argument("},{"line_number":180,"context_line":"            \u0027--distributed\u0027,"},{"line_number":181,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":182,"context_line":"            help\u003d_(\"Create a distributed router (admin only)\")"},{"line_number":183,"context_line":"        )"},{"line_number":184,"context_line":"        distribute_group.add_argument("},{"line_number":185,"context_line":"            \u0027--centralized\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_84a17b96","line":182,"range":{"start_line":182,"start_character":48,"end_line":182,"end_character":60},"in_reply_to":"9a30ddce_70b602fa","updated":"2017-03-13 09:47:16.000000000","message":"Default meant if I am a tenant and I do not pass --distributed or --centralized, then what would it create.\n\nAnyways, I looked into the config and the req/resp bodies and found that this is correct.","commit_id":"b45fb2c6c975098a0aba8e312ac622fb8b0781fb"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"db730ba4450704f8a9166238aa131dd436b1bdaa","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        distribute_group.add_argument("},{"line_number":180,"context_line":"            \u0027--distributed\u0027,"},{"line_number":181,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":182,"context_line":"            help\u003d_(\"Create a distributed router (admin only)\")"},{"line_number":183,"context_line":"        )"},{"line_number":184,"context_line":"        distribute_group.add_argument("},{"line_number":185,"context_line":"            \u0027--centralized\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a1ced50_5255bcf7","line":182,"range":{"start_line":182,"start_character":48,"end_line":182,"end_character":60},"in_reply_to":"9a30ddce_84a17b96","updated":"2017-03-22 05:08:24.000000000","message":"Ok, thanks","commit_id":"b45fb2c6c975098a0aba8e312ac622fb8b0781fb"}],"openstackclient/tests/unit/network/v2/test_router.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"355a6eff64203caf461bcd5d446d87e38f0896e5","unresolved":false,"context_lines":[{"line_number":204,"context_line":"        self.assertEqual(self.columns, columns)"},{"line_number":205,"context_line":"        self.assertEqual(self.data, data)"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def test_create_with_centralized_option(self):"},{"line_number":208,"context_line":"        arglist \u003d ["},{"line_number":209,"context_line":"            \u0027--centralized\u0027,"},{"line_number":210,"context_line":"            self.new_router.name,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a1ced50_a46025a6","line":207,"updated":"2017-03-23 14:36:23.000000000","message":"Could we avoid code duplication by defining a 3rd method like it\u0027s done in https://review.openstack.org/#/c/449176/2/openstackclient/tests/unit/network/v2/test_router.py","commit_id":"b45fb2c6c975098a0aba8e312ac622fb8b0781fb"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"2ed2fd0733a8fe3463f0b7d9f72dd9fffc451076","unresolved":false,"context_lines":[{"line_number":204,"context_line":"        self.assertEqual(self.columns, columns)"},{"line_number":205,"context_line":"        self.assertEqual(self.data, data)"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def test_create_with_centralized_option(self):"},{"line_number":208,"context_line":"        arglist \u003d ["},{"line_number":209,"context_line":"            \u0027--centralized\u0027,"},{"line_number":210,"context_line":"            self.new_router.name,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bff0334d_87678526","line":207,"in_reply_to":"1a1ced50_a46025a6","updated":"2017-04-05 15:53:17.000000000","message":"FWIW, there is a balance between not duplicating code and keeping things easily readable that we must maintain.  OSC (me really) has always fallen on the side of duplicating code where readability is concerned.  For just two methods like here, I\u0027ll fall to leaving it as-is.  Same with the one referenced above.","commit_id":"b45fb2c6c975098a0aba8e312ac622fb8b0781fb"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"81f9626803b90e9f1451af310133764dfcbb31b4","unresolved":false,"context_lines":[{"line_number":204,"context_line":"        self.assertEqual(self.columns, columns)"},{"line_number":205,"context_line":"        self.assertEqual(self.data, data)"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def test_create_with_centralized_option(self):"},{"line_number":208,"context_line":"        arglist \u003d ["},{"line_number":209,"context_line":"            \u0027--centralized\u0027,"},{"line_number":210,"context_line":"            self.new_router.name,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bff0334d_75454017","line":207,"in_reply_to":"bff0334d_87678526","updated":"2017-04-05 18:53:04.000000000","message":"Cedric - when I rebase this I\u0027ll try and create a common function like you did in the other change.","commit_id":"b45fb2c6c975098a0aba8e312ac622fb8b0781fb"}],"releasenotes/notes/bug-1664255-f82c5c13d92fed2a.yaml":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"4263f26f485855fb7621eabf81d3620e50bf5f0b","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Allow centralized option with router create command."},{"line_number":5,"context_line":"    [Bug `1664255 \u003chttps://bugs.launchpad.net/bugs/1664255\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9a30ddce_9de3b8a3","line":5,"updated":"2017-03-10 15:10:53.000000000","message":"I think we should put a little more info here:\n\n    Allow an admin to create centralized (distributed\u003dFalse)\n    routers using ``--centralized`` option in ``router create``, regardless of the \u0027router_distributed\u0027\n    configuration setting in neutron.conf.\n    [Bug...]","commit_id":"72b91932ac250358c968b0ece6e7ce0dfc0844a3"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"9f5c099b10d34bdde4d34a457088d6d43b0e6319","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Allow centralized option with router create command."},{"line_number":5,"context_line":"    [Bug `1664255 \u003chttps://bugs.launchpad.net/bugs/1664255\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9a30ddce_3518fcd2","line":5,"in_reply_to":"9a30ddce_9de3b8a3","updated":"2017-03-13 08:55:41.000000000","message":"Thanks Brian. I add the text you suggested.","commit_id":"72b91932ac250358c968b0ece6e7ce0dfc0844a3"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"2ed2fd0733a8fe3463f0b7d9f72dd9fffc451076","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Allow an admin to create centralized (distributed\u003dFalse)"},{"line_number":5,"context_line":"    routers using ``--centralized`` option in ``router create``,"},{"line_number":6,"context_line":"    regardless of the \u0027router_distributed\u0027 flag in config"},{"line_number":7,"context_line":"    [Bug `1664255 \u003chttps://bugs.launchpad.net/bugs/1664255\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bff0334d_2a408035","line":6,"updated":"2017-04-05 15:53:17.000000000","message":"We need to be careful assuming that OSC users know or have access to Neutron configs, since they do not via the API at all.   Wording that explains that Neutron might be configured one way or the other is appropriate, assuming they know what router_distributed is is not friendly.\n\nSomething that talks about Neutron configurations may be one way or the other, here is the save way to make sure you get the sort of router you really want without having to know that.  And actually that maybe should also be in the doc itself.","commit_id":"b45fb2c6c975098a0aba8e312ac622fb8b0781fb"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"81f9626803b90e9f1451af310133764dfcbb31b4","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Allow an admin to create centralized (distributed\u003dFalse)"},{"line_number":5,"context_line":"    routers using ``--centralized`` option in ``router create``,"},{"line_number":6,"context_line":"    regardless of the \u0027router_distributed\u0027 flag in config"},{"line_number":7,"context_line":"    [Bug `1664255 \u003chttps://bugs.launchpad.net/bugs/1664255\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bff0334d_9527a465","line":6,"in_reply_to":"bff0334d_2a408035","updated":"2017-04-05 18:53:04.000000000","message":"I\u0027ll try and tweak this text a little based on the comments, thanks!","commit_id":"b45fb2c6c975098a0aba8e312ac622fb8b0781fb"}]}