)]}'
{"doc/source/command-objects/subnet-pool.rst":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"68316c65079bb67e8dd412701990e60daca651b8","unresolved":false,"context_lines":[{"line_number":247,"context_line":"subnet pool unset"},{"line_number":248,"context_line":"-----------------"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"Unset subnet pool properties"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":".. program:: subnet pool unset"},{"line_number":253,"context_line":".. code:: bash"}],"source_content_type":"text/x-rst","patch_set":4,"id":"dfeb2761_12a6f6c2","line":250,"updated":"2017-03-31 15:41:09.000000000","message":"It\u0027s also possible to have an empty default quota. Can you add the unset command for \"default-quota\"?","commit_id":"040a8c250957c13a453dcf69a295d48f36e56257"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"dce50df6c671baa595bc6229a32d622bc54b5d97","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":".. option:: --default-quota \u003cdefault-quota\u003e"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    Set default quota for subnet pool"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":".. _subnet_pool_create-name:"},{"line_number":87,"context_line":".. describe:: \u003cname\u003e"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7ffa3b31_4da170a9","line":84,"updated":"2017-04-17 16:29:23.000000000","message":"What is the actual value of \u003cdefault-quota\u003e?  Is it a max pool size?  What units if it is not a count?  We\u0027re getting sloppy with the metavar names, it should be an indication of what the argument is, an int or a size in GB or whatever.","commit_id":"2bc8defc999fd674f93d12a052898f28186b5848"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"cd4d4f61d5447da7a54eb9f0186b41dac47e9355","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":".. option:: --default-quota \u003cdefault-quota\u003e"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    Set default quota for subnet pool"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":".. _subnet_pool_create-name:"},{"line_number":87,"context_line":".. describe:: \u003cname\u003e"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7ffa3b31_d63741b0","line":84,"in_reply_to":"7ffa3b31_4da170a9","updated":"2017-04-18 06:38:05.000000000","message":"Understood your point, Dean.\nThanks :)","commit_id":"2bc8defc999fd674f93d12a052898f28186b5848"}],"openstackclient/network/v2/subnet_pool.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"68316c65079bb67e8dd412701990e60daca651b8","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        parser.add_argument("},{"line_number":189,"context_line":"            \u0027--default-quota\u0027,"},{"line_number":190,"context_line":"            metavar\u003d\u0027\u003cdefault-quota\u003e\u0027,"},{"line_number":191,"context_line":"            help\u003d_(\"Set the default quota for this subnet pool\"))"},{"line_number":192,"context_line":"        return parser"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfeb2761_b26cea36","line":191,"range":{"start_line":191,"start_character":20,"end_line":191,"end_character":62},"updated":"2017-03-31 15:41:09.000000000","message":"You should match this help string with the string the doc:\nhttps://review.openstack.org/#/c/437367/4/doc/source/command-objects/subnet-pool.rst@84","commit_id":"040a8c250957c13a453dcf69a295d48f36e56257"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"68316c65079bb67e8dd412701990e60daca651b8","unresolved":false,"context_lines":[{"line_number":379,"context_line":"        parser.add_argument("},{"line_number":380,"context_line":"            \u0027--default-quota\u0027,"},{"line_number":381,"context_line":"            metavar\u003d\u0027\u003cdefault-quota\u003e\u0027,"},{"line_number":382,"context_line":"            help\u003d_(\"Set the default quota for this subnet pool\"))"},{"line_number":383,"context_line":"        return parser"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfeb2761_12ccb633","line":382,"range":{"start_line":382,"start_character":20,"end_line":382,"end_character":62},"updated":"2017-03-31 15:41:09.000000000","message":"You should match this help string with the string the doc","commit_id":"040a8c250957c13a453dcf69a295d48f36e56257"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"68316c65079bb67e8dd412701990e60daca651b8","unresolved":false,"context_lines":[{"line_number":419,"context_line":"        return (display_columns, data)"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"class UnsetSubnetPool(command.Command):"},{"line_number":423,"context_line":"    _description \u003d _(\"Unset subnet pool properties\")"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"    def get_parser(self, prog_name):"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfeb2761_52747e35","line":422,"updated":"2017-03-31 15:41:09.000000000","message":"ditto: to add the unset command","commit_id":"040a8c250957c13a453dcf69a295d48f36e56257"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"a6a4ad9e29afb70944b01ecb2be8ce6f208b9f94","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    if parsed_args.description is not None:"},{"line_number":90,"context_line":"        attrs[\u0027description\u0027] \u003d parsed_args.description"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    if parsed_args.default_quota:"},{"line_number":93,"context_line":"        attrs[\u0027default_quota\u0027] \u003d parsed_args.default_quota"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    return attrs"}],"source_content_type":"text/x-python","patch_set":6,"id":"7ffa3b31_77816b8f","line":92,"updated":"2017-04-19 00:49:05.000000000","message":"By the way, if parsed_args.default_quota is \"int\", please use \"if parsed_args.default_quota is not None:\" here since parsed_args.default_quota maybe 0.","commit_id":"2bc8defc999fd674f93d12a052898f28186b5848"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"ceeff2db7ceafd76b04a7812c2297ed0c1283d4e","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        attrs[\u0027description\u0027] \u003d parsed_args.description"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    if parsed_args.default_quota:"},{"line_number":93,"context_line":"        attrs[\u0027default_quota\u0027] \u003d parsed_args.default_quota"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    return attrs"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7ffa3b31_0c625c3f","line":93,"range":{"start_line":93,"start_character":33,"end_line":93,"end_character":58},"updated":"2017-04-17 02:03:20.000000000","message":"Just a question, Should it be \"int\" or \"string\"? I see it is -1 in unset command","commit_id":"2bc8defc999fd674f93d12a052898f28186b5848"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"8f74911d1ed3721cc229be56b3cf2c9a4d725208","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    if parsed_args.default_quota:"},{"line_number":93,"context_line":"        attrs[\u0027default_quota\u0027] \u003d parsed_args.default_quota"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    return attrs"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7ffa3b31_96b659fa","line":94,"updated":"2017-04-18 07:05:48.000000000","message":"I saw the default_quota attribute of subnet pool is int in openstacksdk, I think we can add type\u003dint in parser.","commit_id":"2bc8defc999fd674f93d12a052898f28186b5848"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"8f74911d1ed3721cc229be56b3cf2c9a4d725208","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        parser.add_argument("},{"line_number":189,"context_line":"            \u0027--default-quota\u0027,"},{"line_number":190,"context_line":"            metavar\u003d\u0027\u003cdefault-quota\u003e\u0027,"},{"line_number":191,"context_line":"            help\u003d_(\"Set default quota for subnet pool\"))"},{"line_number":192,"context_line":"        return parser"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":6,"id":"7ffa3b31_56d1f1fa","line":191,"updated":"2017-04-18 07:05:48.000000000","message":"When I create subnet pool without \"--default-quota\" option, default-quota is \"None\" in response of creating commands, what\u0027s the difference between -1 and None?\n\nIf -1 have special means, we should mention it in help message of create and set.","commit_id":"2bc8defc999fd674f93d12a052898f28186b5848"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"9b8bba942c536d8e00bb9b0a575d125714d3be6d","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        attrs[\u0027description\u0027] \u003d parsed_args.description"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    if parsed_args.default_quota is not None:"},{"line_number":93,"context_line":"        attrs[\u0027default_quota\u0027] \u003d int(parsed_args.default_quota)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    return attrs"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"df140735_763fad86","line":93,"range":{"start_line":93,"start_character":33,"end_line":93,"end_character":36},"updated":"2017-06-06 03:56:41.000000000","message":"I still think we should avoid the force int conversion, and add type\u003dint in parser.add_argument(), like I say in PS5 comments.\n\nAlthough the help message mentioned that option is number of IPs, the following input will cause a ValueError with unclear error message, we should raise tip as soon as possible if the input is in bad format.\n\n    subnet pool create --default-quota 10.0 xxx","commit_id":"835734bc0320ac9aa7de75a231a662a386b7f217"}],"openstackclient/tests/functional/network/v2/test_subnet_pool.py":[{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"e4414707e11452c44b1fcc41386e8328feda3d35","unresolved":false,"context_lines":[{"line_number":273,"context_line":"        #    \u0027 --pool-prefix 10.110.0.0/16 \u0027 +"},{"line_number":274,"context_line":"        #    new_name,"},{"line_number":275,"context_line":"        # )"},{"line_number":276,"context_line":"        self.assertOutput(\u0027\u0027, cmd_output)"},{"line_number":277,"context_line":"        self.assertNone(cmd_output[\"prefixes\"])"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    def _subnet_pool_create(self, cmd, name, is_type_ipv4\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":17,"id":"ff0f0b1f_099dee64","line":276,"range":{"start_line":276,"start_character":0,"end_line":276,"end_character":41},"updated":"2017-05-25 02:27:16.000000000","message":"The CI failure must be related with L228","commit_id":"6f71914bc0224efd910332ef4ba61178f7e6b9f7"}],"releasenotes/notes/add_default_quota_to_subnet_pool-aff096871c1d716e.yaml":[{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"ceeff2db7ceafd76b04a7812c2297ed0c1283d4e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    It is now possible to define the default quotas of a subnetpool, using"},{"line_number":5,"context_line":"    the ``--default-quota`` option in ``openstack subnet pool create`` and"},{"line_number":6,"context_line":"    ``openstack subnet pool set`` CLIs."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7ffa3b31_ec7df0e7","line":7,"updated":"2017-04-17 02:03:20.000000000","message":"You need to mention unset command as well","commit_id":"2bc8defc999fd674f93d12a052898f28186b5848"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"8f74911d1ed3721cc229be56b3cf2c9a4d725208","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    the ``--default-quota`` option in ``openstack subnet pool create`` and"},{"line_number":6,"context_line":"    ``openstack subnet pool set`` CLIs."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7ffa3b31_b34f2791","line":8,"updated":"2017-04-18 07:05:48.000000000","message":"please add the bug link, and huanxuan\u0027s advise make sense.","commit_id":"2bc8defc999fd674f93d12a052898f28186b5848"}]}