)]}'
{"openstackclient/compute/v2/server.py":[{"author":{"_account_id":23913,"name":"David Rabel","email":"rabel@b1-systems.de","username":"rabel"},"change_message_id":"ed4356151aac116eb9d672cf140fa4576810e8fe","unresolved":false,"context_lines":[{"line_number":441,"context_line":"            metavar\u003d\u0027\u003cdev-name\u003dmapping\u003e\u0027,"},{"line_number":442,"context_line":"            action\u003dparseractions.KeyValueAction,"},{"line_number":443,"context_line":"            default\u003d{},"},{"line_number":444,"context_line":"            help\u003d_(\u0027Create a block device on the server. \u0027"},{"line_number":445,"context_line":"                   \u0027Block device mapping in the format \u003cdev-name\u003e\u003d\u0027"},{"line_number":446,"context_line":"                   \u0027\u003cid\u003e:\u003ctype\u003e:\u003csize(GB)\u003e:\u003cdelete-on-terminate\u003e \u0027"},{"line_number":447,"context_line":"                   \u0027\u003cdev-name\u003e: block device name, like: vdb, xvdc \u0027"},{"line_number":448,"context_line":"                   \u0027(required), \u0027"},{"line_number":449,"context_line":"                   \u0027\u003cid\u003e: UUID of the volume or snapshot (required), \u0027"},{"line_number":450,"context_line":"                   \u0027\u003ctype\u003e: volume or snapshot; default: volume (optional), \u0027"},{"line_number":451,"context_line":"                   \u0027\u003csize(GB)\u003e: volume size if create from snapshot \u0027"},{"line_number":452,"context_line":"                   \u0027(optional), \u0027"},{"line_number":453,"context_line":"                   \u0027\u003cdelete-on-terminate\u003e: true or false; default: false \u0027"},{"line_number":454,"context_line":"                   \u0027(optional) (optional extension)\u0027),"},{"line_number":455,"context_line":"        )"},{"line_number":456,"context_line":"        parser.add_argument("},{"line_number":457,"context_line":"            \u0027--nic\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"bff0334d_bdccad89","line":454,"range":{"start_line":444,"start_character":19,"end_line":454,"end_character":54},"updated":"2017-04-06 13:54:07.000000000","message":"I\u0027d suggest adding some . at the end of the lines or something like that. At the moment the output is very unclear.","commit_id":"b1fa391084cf18913ae5d7b0c55b185ee940ab10"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"da7e05d1d92e8d323ee489393eae8225d135477a","unresolved":false,"context_lines":[{"line_number":451,"context_line":"                   \u0027\u003csize(GB)\u003e: volume size if create from snapshot \u0027"},{"line_number":452,"context_line":"                   \u0027(optional), \u0027"},{"line_number":453,"context_line":"                   \u0027\u003cdelete-on-terminate\u003e: true or false; default: false \u0027"},{"line_number":454,"context_line":"                   \u0027(optional) (optional extension)\u0027),"},{"line_number":455,"context_line":"        )"},{"line_number":456,"context_line":"        parser.add_argument("},{"line_number":457,"context_line":"            \u0027--nic\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"bff0334d_ca078d1c","line":454,"in_reply_to":"bff0334d_b5aba1d4","updated":"2017-04-07 03:59:31.000000000","message":"There are so many values in one command option, that cause help message looks messy, honestly it doesn\u0027t look good for me too. The document is clean, because every value exist in single line.\n\nI will try to reformat the help message output, and I think the help message should be a self-document, the detailed help message make users efficient.","commit_id":"b1fa391084cf18913ae5d7b0c55b185ee940ab10"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"b771066c8b50e90da3cf1531563e156a28510606","unresolved":false,"context_lines":[{"line_number":451,"context_line":"                   \u0027\u003csize(GB)\u003e: volume size if create from snapshot \u0027"},{"line_number":452,"context_line":"                   \u0027(optional), \u0027"},{"line_number":453,"context_line":"                   \u0027\u003cdelete-on-terminate\u003e: true or false; default: false \u0027"},{"line_number":454,"context_line":"                   \u0027(optional) (optional extension)\u0027),"},{"line_number":455,"context_line":"        )"},{"line_number":456,"context_line":"        parser.add_argument("},{"line_number":457,"context_line":"            \u0027--nic\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"bff0334d_b5aba1d4","line":454,"in_reply_to":"bff0334d_bdccad89","updated":"2017-04-06 14:52:36.000000000","message":"help formatting is messy, which is one reason to consider if all of that information needs to be there or can we have enough to remind users of the syntax and keep the details in the docs?\n\nIt is a fine line to follow, but messy help is annoying.","commit_id":"b1fa391084cf18913ae5d7b0c55b185ee940ab10"},{"author":{"_account_id":23913,"name":"David Rabel","email":"rabel@b1-systems.de","username":"rabel"},"change_message_id":"60fee4eaab2fd9de14e1b76d8fe941a1f757cbcc","unresolved":false,"context_lines":[{"line_number":441,"context_line":"            metavar\u003d\u0027\u003cdev-name\u003dmapping\u003e\u0027,"},{"line_number":442,"context_line":"            action\u003dparseractions.KeyValueAction,"},{"line_number":443,"context_line":"            default\u003d{},"},{"line_number":444,"context_line":"            help\u003d_(\u0027Create a block device on the server.\\n\u0027"},{"line_number":445,"context_line":"                   \u0027Block device mapping in the format \u003cdev-name\u003e\u003d\u0027"},{"line_number":446,"context_line":"                   \u0027\u003cid\u003e:\u003ctype\u003e:\u003csize(GB)\u003e:\u003cdelete-on-terminate\u003e\\n\u0027"},{"line_number":447,"context_line":"                   \u0027\u003cdev-name\u003e: block device name, like: vdb, xvdc \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"bff0334d_27cce768","line":444,"range":{"start_line":444,"start_character":56,"end_line":444,"end_character":58},"updated":"2017-04-07 08:54:35.000000000","message":"Unfortunately that does not seem to work.","commit_id":"46adac985a95a729bb884be3db377fb90963f4ce"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"d8f6225b12212962e348a8df35b29b42372fd44a","unresolved":false,"context_lines":[{"line_number":441,"context_line":"            metavar\u003d\u0027\u003cdev-name\u003dmapping\u003e\u0027,"},{"line_number":442,"context_line":"            action\u003dparseractions.KeyValueAction,"},{"line_number":443,"context_line":"            default\u003d{},"},{"line_number":444,"context_line":"            help\u003d_(\u0027Create a block device on the server.\\n\u0027"},{"line_number":445,"context_line":"                   \u0027Block device mapping in the format \u003cdev-name\u003e\u003d\u0027"},{"line_number":446,"context_line":"                   \u0027\u003cid\u003e:\u003ctype\u003e:\u003csize(GB)\u003e:\u003cdelete-on-terminate\u003e\\n\u0027"},{"line_number":447,"context_line":"                   \u0027\u003cdev-name\u003e: block device name, like: vdb, xvdc \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"bff0334d_07ffa334","line":444,"range":{"start_line":444,"start_character":56,"end_line":444,"end_character":58},"in_reply_to":"bff0334d_27cce768","updated":"2017-04-07 08:59:57.000000000","message":"It have to works with cliff patch https://review.openstack.org/454613 , I add Depends-On in commit message :-)","commit_id":"46adac985a95a729bb884be3db377fb90963f4ce"},{"author":{"_account_id":23913,"name":"David Rabel","email":"rabel@b1-systems.de","username":"rabel"},"change_message_id":"919d56566d803b9ee40407a05c06b79c262f6c8a","unresolved":false,"context_lines":[{"line_number":462,"context_line":"                    \"port-id\u003dport-uuid,auto,none\u003e\","},{"line_number":463,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":464,"context_line":"            default\u003d[],"},{"line_number":465,"context_line":"            # NOTE(RuiChen): Add \u0027\\n\\n\u0027 at the end of line to put each item in"},{"line_number":466,"context_line":"            #                the separated line, avoid the help message looks"},{"line_number":467,"context_line":"            #                messy, see _SmartHelpFormatter in cliff."},{"line_number":468,"context_line":"            help\u003d_(\"Create a NIC on the server.\\n\\n\""},{"line_number":469,"context_line":"                   \"Specify option multiple times to create multiple NICs. \""},{"line_number":470,"context_line":"                   \"Either net-id or port-id must be provided, \""},{"line_number":471,"context_line":"                   \"but not both.\\n\\n\""},{"line_number":472,"context_line":"                   \"net-id: attach NIC to network with this UUID\\n\\n\""},{"line_number":473,"context_line":"                   \"port-id: attach NIC to port with this UUID\\n\\n\""},{"line_number":474,"context_line":"                   \"v4-fixed-ip: IPv4 fixed address for NIC (optional)\\n\\n\""},{"line_number":475,"context_line":"                   \"v6-fixed-ip: IPv6 fixed address for NIC (optional)\\n\\n\""},{"line_number":476,"context_line":"                   \"none: (v2.37+) no network is attached\\n\\n\""},{"line_number":477,"context_line":"                   \"auto: (v2.37+) the compute service will automatically \""},{"line_number":478,"context_line":"                   \"allocate a network\\n\\n\""},{"line_number":479,"context_line":"                   \"Specifying a --nic of auto or none cannot be used with \""},{"line_number":480,"context_line":"                   \"any other --nic value.\"),"},{"line_number":481,"context_line":"        )"},{"line_number":482,"context_line":"        parser.add_argument("},{"line_number":483,"context_line":"            \u0027--hint\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"9ff52f3f_dfbbfce2","line":480,"range":{"start_line":465,"start_character":0,"end_line":480,"end_character":45},"updated":"2017-04-13 16:44:15.000000000","message":"In general I like that, but this should not be part of this patch.\nImho you try to do a lot of things in one change, while it should be a lot of changes, things are not too heavily related to each other.\nFor example the commit name is \"Make block-device-mapping more stable and clear\", but now you change the help message of --nic.\n\nIn my opinion this should have been four patches from the beginning. One of them would have been \"Rework --block-device-mapping help message\" or something. In such a patch, these new changes could have been added, but like this I think it\u0027s a bad idea.","commit_id":"004bf1ce2a5a874fee31782bc35a78672f6e7560"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"df721f0b6c4bdfeec1e9d1f3173c583b90e21736","unresolved":false,"context_lines":[{"line_number":462,"context_line":"                    \"port-id\u003dport-uuid,auto,none\u003e\","},{"line_number":463,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":464,"context_line":"            default\u003d[],"},{"line_number":465,"context_line":"            # NOTE(RuiChen): Add \u0027\\n\\n\u0027 at the end of line to put each item in"},{"line_number":466,"context_line":"            #                the separated line, avoid the help message looks"},{"line_number":467,"context_line":"            #                messy, see _SmartHelpFormatter in cliff."},{"line_number":468,"context_line":"            help\u003d_(\"Create a NIC on the server.\\n\\n\""},{"line_number":469,"context_line":"                   \"Specify option multiple times to create multiple NICs. \""},{"line_number":470,"context_line":"                   \"Either net-id or port-id must be provided, \""},{"line_number":471,"context_line":"                   \"but not both.\\n\\n\""},{"line_number":472,"context_line":"                   \"net-id: attach NIC to network with this UUID\\n\\n\""},{"line_number":473,"context_line":"                   \"port-id: attach NIC to port with this UUID\\n\\n\""},{"line_number":474,"context_line":"                   \"v4-fixed-ip: IPv4 fixed address for NIC (optional)\\n\\n\""},{"line_number":475,"context_line":"                   \"v6-fixed-ip: IPv6 fixed address for NIC (optional)\\n\\n\""},{"line_number":476,"context_line":"                   \"none: (v2.37+) no network is attached\\n\\n\""},{"line_number":477,"context_line":"                   \"auto: (v2.37+) the compute service will automatically \""},{"line_number":478,"context_line":"                   \"allocate a network\\n\\n\""},{"line_number":479,"context_line":"                   \"Specifying a --nic of auto or none cannot be used with \""},{"line_number":480,"context_line":"                   \"any other --nic value.\"),"},{"line_number":481,"context_line":"        )"},{"line_number":482,"context_line":"        parser.add_argument("},{"line_number":483,"context_line":"            \u0027--hint\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"7ffa3b31_7309e2db","line":480,"range":{"start_line":465,"start_character":0,"end_line":480,"end_character":45},"in_reply_to":"9ff52f3f_dfbbfce2","updated":"2017-04-14 01:50:26.000000000","message":"ok, I split these to other patch, make reviewer focus on bdm changes, thank you.","commit_id":"004bf1ce2a5a874fee31782bc35a78672f6e7560"}]}